From unknown Sun Jun 15 08:54:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31651: 26.1.50; message-forward-included-headers should contain "^$" Resent-From: Katsumi Yamaoka Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 May 2018 03:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 31651 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 31651@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.152764969527757 (code B ref -1); Wed, 30 May 2018 03:09:02 +0000 Received: (at submit) by debbugs.gnu.org; 30 May 2018 03:08:15 +0000 Received: from localhost ([127.0.0.1]:54526 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fNrTC-0007Dc-Nz for submit@debbugs.gnu.org; Tue, 29 May 2018 23:08:14 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40130) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fNrTA-0007DQ-ON for submit@debbugs.gnu.org; Tue, 29 May 2018 23:08:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fNrT4-0000nX-Lq for submit@debbugs.gnu.org; Tue, 29 May 2018 23:08:07 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:35809) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fNrT4-0000nR-II for submit@debbugs.gnu.org; Tue, 29 May 2018 23:08:06 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59334) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fNrT3-0002Ln-IK for bug-gnu-emacs@gnu.org; Tue, 29 May 2018 23:08:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fNrSz-0000kN-Hp for bug-gnu-emacs@gnu.org; Tue, 29 May 2018 23:08:05 -0400 Received: from black.maple.relay.mailchannels.net ([23.83.214.19]:12256) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fNrSz-0000Q5-9K for bug-gnu-emacs@gnu.org; Tue, 29 May 2018 23:08:01 -0400 X-Sender-Id: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id F3B7C411FF; Wed, 30 May 2018 03:07:18 +0000 (UTC) Received: from hampton.hostforweb.net (unknown [100.96.30.19]) (Authenticated sender: tih5qno0ow) by relay.mailchannels.net (Postfix) with ESMTPA id 81127415C3; Wed, 30 May 2018 03:07:18 +0000 (UTC) X-Sender-Id: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net Received: from hampton.hostforweb.net (hampton.hostforweb.net [172.19.38.121]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.15.2); Wed, 30 May 2018 03:07:18 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net X-MailChannels-Auth-Id: tih5qno0ow X-Skirt-Imminent: 16601b6e3d25dbf7_1527649638843_2639655145 X-MC-Loop-Signature: 1527649638842:3773776038 X-MC-Ingress-Time: 1527649638842 Received: from s70.gtokyofl21.vectant.ne.jp ([202.215.75.70]:60000 helo=localhost) by hampton.hostforweb.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1fNrSE-008DuO-C4; Tue, 29 May 2018 22:07:15 -0500 Date: Wed, 30 May 2018 12:07:13 +0900 Message-ID: From: Katsumi Yamaoka Organization: Emacsen advocacy group X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (x86_64-unknown-cygwin) Cancel-Lock: sha1:ZDKks7EOd96TnUmA4TEaqlbvUqs= MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-OutGoing-Spam-Status: No, score=-1.5 X-AuthUser: yamaoka@hampton.hostforweb.net X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.1 (-----) Hi, The docstring of `message-forward-included-headers' says: This variable should be a regexp or a list of regexps. But if it is a regexp, it should contain "^$" like: "^$\\|^\\(?:Cc\\|Date\\|From\\|In-Reply-To\\|Message-Id\\|References\\|Reply-To\\|Subject\\|To\\|User-Agent\\|X-Mailer\\):" Or the header separator in a forward message will be removed and the message will get malformed. A better way to solve this issue would be to improve the `message-remove-ignored-headers' code rather than adding a causion to the docstring of `message-forward-included-headers', I think. I use `message-forward-as-mime' with t as it was before. Thanks. From unknown Sun Jun 15 08:54:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31651: 26.1.50; message-forward-included-headers should contain "^$" Resent-From: Andreas Schwab Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 May 2018 07:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31651 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Katsumi Yamaoka Cc: 31651@debbugs.gnu.org Received: via spool by 31651-submit@debbugs.gnu.org id=B31651.152766698122987 (code B ref 31651); Wed, 30 May 2018 07:57:02 +0000 Received: (at 31651) by debbugs.gnu.org; 30 May 2018 07:56:21 +0000 Received: from localhost ([127.0.0.1]:54627 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fNvy1-0005yh-1b for submit@debbugs.gnu.org; Wed, 30 May 2018 03:56:21 -0400 Received: from mx2.suse.de ([195.135.220.15]:55035) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fNvxz-0005yU-5G for 31651@debbugs.gnu.org; Wed, 30 May 2018 03:56:19 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext-too.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id E93EBAC9E; Wed, 30 May 2018 07:56:11 +0000 (UTC) From: Andreas Schwab References: X-Yow: Well, I'm a classic ANAL RETENTIVE!! And I'm looking for a way to VICARIOUSLY experience some reason to LIVE!! Date: Wed, 30 May 2018 09:56:11 +0200 In-Reply-To: (Katsumi Yamaoka's message of "Wed, 30 May 2018 12:07:13 +0900") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On Mai 30 2018, Katsumi Yamaoka wrote: > But if it is a regexp, it should contain "^$" like: > > "^$\\|^\\(?:Cc\\|Date\\|From\\|In-Reply-To\\|Message-Id\\|References\\|Reply-To\\|Subject\\|To\\|User-Agent\\|X-Mailer\\):" > > Or the header separator in a forward message will be removed > and the message will get malformed. I think this is a bug. The empty line is not a header line, so it should not be matched against. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." From unknown Sun Jun 15 08:54:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31651: 26.1.50; message-forward-included-headers should contain "^$" In-Reply-To: Resent-From: Katsumi Yamaoka Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 May 2018 23:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31651 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Andreas Schwab Cc: 31651@debbugs.gnu.org Received: via spool by 31651-submit@debbugs.gnu.org id=B31651.152772305032030 (code B ref 31651); Wed, 30 May 2018 23:31:02 +0000 Received: (at 31651) by debbugs.gnu.org; 30 May 2018 23:30:50 +0000 Received: from localhost ([127.0.0.1]:55466 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fOAYM-0008KY-0V for submit@debbugs.gnu.org; Wed, 30 May 2018 19:30:50 -0400 Received: from buffalo.ash.relay.mailchannels.net ([23.83.222.24]:43366) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fOAYJ-0008KM-3N for 31651@debbugs.gnu.org; Wed, 30 May 2018 19:30:49 -0400 X-Sender-Id: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 05C7F281840; Wed, 30 May 2018 23:30:43 +0000 (UTC) Received: from hampton.hostforweb.net (unknown [100.96.28.18]) (Authenticated sender: tih5qno0ow) by relay.mailchannels.net (Postfix) with ESMTPA id 8AD2A281A37; Wed, 30 May 2018 23:30:42 +0000 (UTC) X-Sender-Id: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net Received: from hampton.hostforweb.net (hampton.hostforweb.net [172.19.51.240]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.15.2); Wed, 30 May 2018 23:30:42 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net X-MailChannels-Auth-Id: tih5qno0ow X-Shoe-Wipe: 526f64052512252a_1527723042884_2393651436 X-MC-Loop-Signature: 1527723042884:2197870205 X-MC-Ingress-Time: 1527723042884 Received: from s70.gtokyofl21.vectant.ne.jp ([202.215.75.70]:60000 helo=localhost) by hampton.hostforweb.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1fOAYB-00ECjE-G2; Wed, 30 May 2018 18:30:40 -0500 Date: Thu, 31 May 2018 08:30:37 +0900 Message-ID: From: Katsumi Yamaoka References: Organization: Emacsen advocacy group X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (x86_64-unknown-cygwin) Cancel-Lock: sha1:afSsolfmHHk9mIMO7uwi3OmbB94= MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-OutGoing-Spam-Status: No, score=-1.0 X-AuthUser: yamaoka@hampton.hostforweb.net X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Wed, 30 May 2018 09:56:11 +0200, Andreas Schwab wrote: > I think this is a bug. The empty line is not a header line, so it > should not be matched against. Though I was going to apply the following first change, I came to think you are right and committed the second one. Thanks. 1. Make `message-remove-ignored-headers' exclude header separator when narrowing. --- message.el~ 2018-01-12 03:53:45.394148600 +0000 +++ message.el 2018-05-30 22:49:55.198043700 +0000 @@ -7393,3 +7393,6 @@ (narrow-to-region (point) - (or (search-forward "\n\n" nil t) (point))) + (if (search-forward "\n\n" nil t) + ;; Exclude header separator. + (1- (match-end 0)) + (point))) (when message-forward-ignored-headers 2. Make `message-remove-header' not remove things not looking like header ("[!-9;-~]+:" comes from RFC2822 section 2.2). --- message.el~ 2018-01-12 03:53:45.394148600 +0000 +++ message.el 2018-05-30 22:49:55.198043700 +0000 @@ -2433,3 +2433,5 @@ (if (if reverse - (not (looking-at regexp)) + (and (not (looking-at regexp)) + ;; Don't remove things not looking like header. + (looking-at "[!-9;-~]+:")) (looking-at regexp)) From debbugs-submit-bounces@debbugs.gnu.org Thu May 31 04:04:48 2018 Received: (at control) by debbugs.gnu.org; 31 May 2018 08:04:49 +0000 Received: from localhost ([127.0.0.1]:55578 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fOIZk-0003PZ-O2 for submit@debbugs.gnu.org; Thu, 31 May 2018 04:04:48 -0400 Received: from anteater.ash.relay.mailchannels.net ([23.83.222.3]:57581) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fOIZi-0003PN-Ea for control@debbugs.gnu.org; Thu, 31 May 2018 04:04:47 -0400 X-Sender-Id: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 54BC8281E8D; Thu, 31 May 2018 08:04:42 +0000 (UTC) Received: from hampton.hostforweb.net (unknown [100.96.31.16]) (Authenticated sender: tih5qno0ow) by relay.mailchannels.net (Postfix) with ESMTPA id DABFA281917; Thu, 31 May 2018 08:04:41 +0000 (UTC) X-Sender-Id: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net Received: from hampton.hostforweb.net (hampton.hostforweb.net [172.19.51.240]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.15.2); Thu, 31 May 2018 08:04:42 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net X-MailChannels-Auth-Id: tih5qno0ow X-Grain-Lyrical: 23524fe4336434d8_1527753882199_3426882570 X-MC-Loop-Signature: 1527753882199:2622201852 X-MC-Ingress-Time: 1527753882199 Received: from s70.gtokyofl21.vectant.ne.jp ([202.215.75.70]:60000 helo=localhost) by hampton.hostforweb.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1fOIZb-00GTAT-0o; Thu, 31 May 2018 03:04:40 -0500 Date: Thu, 31 May 2018 17:04:36 +0900 Message-ID: From: Katsumi Yamaoka To: control@debbugs.gnu.org Subject: Re: bug#31651: 26.1.50; message-forward-included-headers should contain "^$" References: Organization: Emacsen advocacy group User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (x86_64-unknown-cygwin) Cancel-Lock: sha1:xqaR6gJFWFr9m/MpdOUqT+x8F9o= MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-OutGoing-Spam-Status: No, score=-0.2 X-AuthUser: yamaoka@hampton.hostforweb.net X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 31651 quit