GNU bug report logs - #31634
emacs 26.1 Compilation error and fix on Solaris 10

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 31634 in the body.
You can then email your comments to 31634 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Christian Jullien" <eligis <at> orange.fr>
To: <bug-gnu-emacs <at> gnu.org>
Subject: emacs 26.1 Compilation error and fix on Solaris 10
Date: Tue, 29 May 2018 07:49:43 +0200

[Message part 1 (text/plain, inline)]

Hello emacs maintainers,

 

Many thanks for the energy you put on emacs.

 

Trying to compile emacs 26.1 on solaris 10 sparc with gcc 7.3, I get

 

xftfont.c: In function 'xftfont_open':

xftfont.c:338:19: error: 'xftfont_driver' undeclared (first use in this
function); did you mean 'ftxfont_driver'?

   font->driver = &xftfont_driver;

                   ^~~~~~~~~~~~~~

                   ftxfont_driver

 

Which I can easily fix by adding ligne 251:

 

extern struct font_driver const xftfont_driver;

 

Hope it helps.

 

C. Jullien

[Message part 2 (text/html, inline)]

Message #8 received at 31634 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Schwab <schwab <at> linux-m68k.org>
To: "Christian Jullien" <eligis <at> orange.fr>
Cc: 31634 <at> debbugs.gnu.org
Subject: Re: bug#31634: emacs 26.1 Compilation error and fix on Solaris 10
Date: Tue, 29 May 2018 08:49:56 +0200

On Mai 29 2018, "Christian Jullien" <eligis <at> orange.fr> wrote:

> Trying to compile emacs 26.1 on solaris 10 sparc with gcc 7.3, I get
>
>  
>
> xftfont.c: In function 'xftfont_open':
>
> xftfont.c:338:19: error: 'xftfont_driver' undeclared (first use in this
> function); did you mean 'ftxfont_driver'?

Why aren't you seeing the declaration in src/font.h?

Andreas.

-- 
Andreas Schwab, schwab <at> linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

Message #11 received at 31634 <at> debbugs.gnu.org (full text, mbox):

From: "Christian Jullien" <eligis <at> orange.fr>
To: "'Andreas Schwab'" <schwab <at> linux-m68k.org>
Cc: 31634 <at> debbugs.gnu.org
Subject: RE: bug#31634: emacs 26.1 Compilation error and fix on Solaris 10
Date: Tue, 29 May 2018 09:10:45 +0200

In font.h I see

#ifdef HAVE_XFT
extern struct font_driver const xftfont_driver;
#endif

The result of configure gives config.h with XFT feature:

/* Summary of some of the main features enabled by configure. */
#define EMACS_CONFIG_FEATURES "XPM JPEG TIFF PNG ACL FREETYPE XFT
TOOLKIT_SCROLL_BARS LUCID X11 THREADS"

But later in this file, it gives

/* Define to 1 if you have the Xft library. */
/* #undef HAVE_XFT */

So there is no chance to see external declaration in font.h

Christian


-----Original Message-----
From: Andreas Schwab [mailto:schwab <at> linux-m68k.org] 
Sent: mardi 29 mai 2018 08:50
To: Christian Jullien
Cc: 31634 <at> debbugs.gnu.org
Subject: Re: bug#31634: emacs 26.1 Compilation error and fix on Solaris 10

On Mai 29 2018, "Christian Jullien" <eligis <at> orange.fr> wrote:

> Trying to compile emacs 26.1 on solaris 10 sparc with gcc 7.3, I get
>
>  
>
> xftfont.c: In function 'xftfont_open':
>
> xftfont.c:338:19: error: 'xftfont_driver' undeclared (first use in this
> function); did you mean 'ftxfont_driver'?

Why aren't you seeing the declaration in src/font.h?

Andreas.

-- 
Andreas Schwab, schwab <at> linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

Message #14 received at 31634 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Schwab <schwab <at> linux-m68k.org>
To: "Christian Jullien" <eligis <at> orange.fr>
Cc: 31634 <at> debbugs.gnu.org
Subject: Re: bug#31634: emacs 26.1 Compilation error and fix on Solaris 10
Date: Tue, 29 May 2018 09:23:25 +0200

On Mai 29 2018, "Christian Jullien" <eligis <at> orange.fr> wrote:

> The result of configure gives config.h with XFT feature:
>
> /* Summary of some of the main features enabled by configure. */
> #define EMACS_CONFIG_FEATURES "XPM JPEG TIFF PNG ACL FREETYPE XFT
> TOOLKIT_SCROLL_BARS LUCID X11 THREADS"
>
> But later in this file, it gives
>
> /* Define to 1 if you have the Xft library. */
> /* #undef HAVE_XFT */

Looks like there is a logic error in configure, failing to reset
HAVE_XFT to no if Xrender is missing.

Andreas.

-- 
Andreas Schwab, schwab <at> linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

Message #17 received at 31634 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: Andreas Schwab <schwab <at> linux-m68k.org>
Cc: 31634 <at> debbugs.gnu.org, Christian Jullien <eligis <at> orange.fr>
Subject: Re: bug#31634: emacs 26.1 Compilation error and fix on Solaris 10
Date: Tue, 29 May 2018 11:46:45 +0200

Andreas Schwab <schwab <at> linux-m68k.org> writes:

> On Mai 29 2018, "Christian Jullien" <eligis <at> orange.fr> wrote:
>
>> The result of configure gives config.h with XFT feature:
>>
>> /* Summary of some of the main features enabled by configure. */
>> #define EMACS_CONFIG_FEATURES "XPM JPEG TIFF PNG ACL FREETYPE XFT
>> TOOLKIT_SCROLL_BARS LUCID X11 THREADS"
>>
>> But later in this file, it gives
>>
>> /* Define to 1 if you have the Xft library. */
>> /* #undef HAVE_XFT */
>
> Looks like there is a logic error in configure, failing to reset
> HAVE_XFT to no if Xrender is missing.

Indeed. Christian, could you try the following patch? (you'll need to
regenerate configure and re-run it).

diff --git i/configure.ac w/configure.ac
index c66c80adbb..c6101d6353 100644
--- i/configure.ac
+++ w/configure.ac
@@ -3210,8 +3210,8 @@ AC_DEFUN
     if test "x${with_xft}" != "xno"; then
 
       EMACS_CHECK_MODULES([XFT], [xft >= 0.13.0], [], [HAVE_XFT=no])
-      ## Because xftfont.c uses XRenderQueryExtension, we also
-      ## need to link to -lXrender.
+      ## Because xterm.c uses XRenderQueryExtension when XFT is
+      ## enabled, we also need to link to -lXrender.
       HAVE_XRENDER=no
       AC_CHECK_LIB(Xrender, XRenderQueryExtension, HAVE_XRENDER=yes)
       if test "$HAVE_XFT" != no && test "$HAVE_XRENDER" != no; then
@@ -3234,6 +3234,9 @@ AC_DEFUN
 	CPPFLAGS=$OLD_CPPFLAGS
 	CFLAGS=$OLD_CFLAGS
 	LIBS=$OLD_LIBS
+      else
+      # Make sure XFT is disabled if we found XFT but not XRender
+	HAVE_XFT=no
       fi                          # "$HAVE_XFT" != no
     fi                            # "x${with_xft}" != "xno"
 

Message #20 received at 31634 <at> debbugs.gnu.org (full text, mbox):

From: "Christian Jullien" <eligis <at> orange.fr>
To: "'Robert Pluim'" <rpluim <at> gmail.com>,
 "'Andreas Schwab'" <schwab <at> linux-m68k.org>
Cc: 31634 <at> debbugs.gnu.org
Subject: RE: bug#31634: emacs 26.1 Compilation error and fix on Solaris 10
Date: Tue, 29 May 2018 13:09:57 +0200

Thanks, this patch works and you can close the bug report.

I'm facing other issues like:
ld.so.1: temacs: fatal: libxml2.so.2: version 'SUNW_1.1' not found (required
by file temacs)

But it's another story I'm investigating (LD_NOVERSION=yes ./temacs let it
work)

-----Original Message-----
From: Robert Pluim [mailto:rpluim <at> gmail.com] 
Sent: mardi 29 mai 2018 11:47
To: Andreas Schwab
Cc: Christian Jullien; 31634 <at> debbugs.gnu.org
Subject: Re: bug#31634: emacs 26.1 Compilation error and fix on Solaris 10

Andreas Schwab <schwab <at> linux-m68k.org> writes:

> On Mai 29 2018, "Christian Jullien" <eligis <at> orange.fr> wrote:
>
>> The result of configure gives config.h with XFT feature:
>>
>> /* Summary of some of the main features enabled by configure. */
>> #define EMACS_CONFIG_FEATURES "XPM JPEG TIFF PNG ACL FREETYPE XFT
>> TOOLKIT_SCROLL_BARS LUCID X11 THREADS"
>>
>> But later in this file, it gives
>>
>> /* Define to 1 if you have the Xft library. */
>> /* #undef HAVE_XFT */
>
> Looks like there is a logic error in configure, failing to reset
> HAVE_XFT to no if Xrender is missing.

Indeed. Christian, could you try the following patch? (you'll need to
regenerate configure and re-run it).

diff --git i/configure.ac w/configure.ac
index c66c80adbb..c6101d6353 100644
--- i/configure.ac
+++ w/configure.ac
@@ -3210,8 +3210,8 @@ AC_DEFUN
     if test "x${with_xft}" != "xno"; then
 
       EMACS_CHECK_MODULES([XFT], [xft >= 0.13.0], [], [HAVE_XFT=no])
-      ## Because xftfont.c uses XRenderQueryExtension, we also
-      ## need to link to -lXrender.
+      ## Because xterm.c uses XRenderQueryExtension when XFT is
+      ## enabled, we also need to link to -lXrender.
       HAVE_XRENDER=no
       AC_CHECK_LIB(Xrender, XRenderQueryExtension, HAVE_XRENDER=yes)
       if test "$HAVE_XFT" != no && test "$HAVE_XRENDER" != no; then
@@ -3234,6 +3234,9 @@ AC_DEFUN
 	CPPFLAGS=$OLD_CPPFLAGS
 	CFLAGS=$OLD_CFLAGS
 	LIBS=$OLD_LIBS
+      else
+      # Make sure XFT is disabled if we found XFT but not XRender
+	HAVE_XFT=no
       fi                          # "$HAVE_XFT" != no
     fi                            # "x${with_xft}" != "xno"
 

Message #23 received at 31634 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: "Christian Jullien" <eligis <at> orange.fr>
Cc: 31634 <at> debbugs.gnu.org, 'Andreas Schwab' <schwab <at> linux-m68k.org>
Subject: Re: bug#31634: emacs 26.1 Compilation error and fix on Solaris 10
Date: Tue, 29 May 2018 14:55:27 +0200

"Christian Jullien" <eligis <at> orange.fr> writes:

> Thanks, this patch works and you can close the bug report.
>

OK. Eli, for master I presume?

> I'm facing other issues like:
> ld.so.1: temacs: fatal: libxml2.so.2: version 'SUNW_1.1' not found (required
> by file temacs)
>

That sounds like ld is finding a different library version from the
headers used to compile emacs. That shouldn't happen, so it might be
another configure bug.

Regards

Robert

Message #26 received at 31634 <at> debbugs.gnu.org (full text, mbox):

From: "Christian Jullien" <eligis <at> orange.fr>
To: "'Robert Pluim'" <rpluim <at> gmail.com>
Cc: 31634 <at> debbugs.gnu.org, 'Andreas Schwab' <schwab <at> linux-m68k.org>
Subject: RE: bug#31634: emacs 26.1 Compilation error and fix on Solaris 10
Date: Tue, 29 May 2018 15:16:32 +0200

I compile around 100 different open source packages (mostly GNU) for more
than 10 year on Solaris and this is the very first time I see version
'SUNW_1.1' not found (required)' with a shared lib.
I'm trying emacs without libxml2 to see what happens

-----Original Message-----
From: Robert Pluim [mailto:rpluim <at> gmail.com] 
Sent: mardi 29 mai 2018 14:55
To: Christian Jullien
Cc: 'Andreas Schwab'; 31634 <at> debbugs.gnu.org
Subject: Re: bug#31634: emacs 26.1 Compilation error and fix on Solaris 10

"Christian Jullien" <eligis <at> orange.fr> writes:

> Thanks, this patch works and you can close the bug report.
>

OK. Eli, for master I presume?

> I'm facing other issues like:
> ld.so.1: temacs: fatal: libxml2.so.2: version 'SUNW_1.1' not found
(required
> by file temacs)
>

That sounds like ld is finding a different library version from the
headers used to compile emacs. That shouldn't happen, so it might be
another configure bug.

Regards

Robert

Message #29 received at 31634 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Robert Pluim <rpluim <at> gmail.com>
Cc: 31634 <at> debbugs.gnu.org, schwab <at> linux-m68k.org, eligis <at> orange.fr
Subject: Re: bug#31634: emacs 26.1 Compilation error and fix on Solaris 10
Date: Tue, 29 May 2018 19:34:02 +0300

> From: Robert Pluim <rpluim <at> gmail.com>
> Date: Tue, 29 May 2018 14:55:27 +0200
> Cc: 31634 <at> debbugs.gnu.org, 'Andreas Schwab' <schwab <at> linux-m68k.org>
> 
> "Christian Jullien" <eligis <at> orange.fr> writes:
> 
> > Thanks, this patch works and you can close the bug report.
> >
> 
> OK. Eli, for master I presume?

No, emacs-26.  Emacs 26.1 was released, so we can now fix more bugs on
the release branch.

Thanks.

Message #34 received at 31634-done <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 31634-done <at> debbugs.gnu.org, schwab <at> linux-m68k.org, eligis <at> orange.fr
Subject: Re: bug#31634: emacs 26.1 Compilation error and fix on Solaris 10
Date: Tue, 29 May 2018 20:35:57 +0200

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Robert Pluim <rpluim <at> gmail.com>
>> Date: Tue, 29 May 2018 14:55:27 +0200
>> Cc: 31634 <at> debbugs.gnu.org, 'Andreas Schwab' <schwab <at> linux-m68k.org>
>> 
>> "Christian Jullien" <eligis <at> orange.fr> writes:
>> 
>> > Thanks, this patch works and you can close the bug report.
>> >
>> 
>> OK. Eli, for master I presume?
>
> No, emacs-26.  Emacs 26.1 was released, so we can now fix more bugs on
> the release branch.
>
> Thanks.

Closing bug, pushed as f212fe512c

Robert

Message #37 received at 31634 <at> debbugs.gnu.org (full text, mbox):

From: Richard Stallman <rms <at> gnu.org>
To: "Christian Jullien" <eligis <at> orange.fr>
Cc: 31634 <at> debbugs.gnu.org, rpluim <at> gmail.com, schwab <at> linux-m68k.org
Subject: Re: bug#31634: emacs 26.1 Compilation error and fix on Solaris 10
Date: Tue, 29 May 2018 23:27:59 -0400

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > I compile around 100 different open source packages (mostly GNU) for more

Please don't think of the GNU system or GNU packages as "open source"
-- on the contrary, that's the slogan used for rejection of what we
stand for.  We stand for giving users freedom -- that's why it is
called "free (libre) software".

See https://gnu.org/philosophy/open-source-misses-the-point.html
for more explanation of the difference between free software and open
source.  See also https://thebaffler.com/salvos/the-meme-hustler for
Evgeny Morozov's article on the same point.

Nonetheless, thanks for reporting a problem -- that helps us do
a good job.

-- 
Dr Richard Stallman
President, Free Software Foundation (https://gnu.org, https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.