GNU bug report logs - #31621
[PATCH 1/3] gnu: Add hpcguix-web.

Previous Next

Package: guix-patches;

Reported by: Rouby Pierre-Antoine <pierre-antoine.rouby <at> inria.fr>

Date: Mon, 28 May 2018 13:26:01 UTC

Severity: normal

Tags: patch

Done: ludo <at> gnu.org (Ludovic Courtès)

Bug is archived. No further changes may be made.

Full log

Message #35 received at 31621 <at> debbugs.gnu.org (full text, mbox):

From: ludovic.courtes <at> inria.fr (Ludovic Courtès)
To: Rouby Pierre-Antoine <pierre-antoine.rouby <at> inria.fr>
Cc: 31621 <at> debbugs.gnu.org, ng0 <at> n0.is
Subject: Re: [bug#31621] [PATCH 2/3] gnu: service: Add hpcguix-web.
Date: Thu, 31 May 2018 18:12:30 +0200

Rouby Pierre-Antoine <pierre-antoine.rouby <at> inria.fr> skribis:

> * gnu/service/web.scm (<hpcguix-web-configuration>): New record-type.
>   (%hpcguix-web-accounts): New variable.
>   (%hpcguix-web-activation,hpcguix-web-shepherd-service,
>   hpcguix-web-service-type): New procedures.
> * doc/guix.texi (Web Services): Add 'hpcguix-web'.

I think you had written a system test no?  Did it end up in a different
patch?

Apart from that it LGTM, thank you, and thanks Nils for the review!

Ludo’.
This bug report was last modified 7 years and 50 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.