GNU bug report logs - #31603
27.0.50; pinentry loopback disappeared

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 31603 in the body.
You can then email your comments to 31603 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: adrian.lanz <at> wsl.ch
To: bug-gnu-emacs <at> gnu.org
Subject: 27.0.50; pinentry loopback disappeared
Date: Sat, 26 May 2018 10:46:45 +0200

With 'allow-loopback-pinentry' in gpg-agent.conf and (setq
epa-pinentry-mode 'loopback) in .emacs, I enjoy reliable pass-phrase
prompting and entering in the Emacs minibuffer for quite some time (at
least since September 2016).

Now unexpectedly, pinentry-curses started to pop-up for pass-phrase
prompting. I suspect commit 302e500087fd4cc1c5f37ec87c98e828b22aaa05
being the cause. I did not find a way to get pinentry-loopback back and
working.


Remark 1: The default graphical mode pinentry (X11 or similar) is
available as expected.

Remark 2: Text mode pinentry-curses is very unreliable (under my
configuration). Several attempts are often needed to get the pass-phrase
accepted. When pinentry-curses is automatically called to find-file a
*.gpg file, mangled parts of the pass-phrase are inserted as clear text
on top of the Emacs buffer into which the file is loaded. Mangled
pass-phrase parts may also otherwise passed to Emacs (seems as key
strokes with unpredictable effects).

[This bug report is, however, not intended towards pinentry-curses, but
pinentry-loopback. On the other hand, pinentry-curses seems the
fall-back of pinentry-loopback (and graphical mode pinentry).]

Use case: I access the system (at work) also on a daily basis from
outside - through VPN/SSH and in terminal/text mode, so that a
functioning text mode pinentry is a must (e.g. encrypted .authinfo.gpg
for Emacs/Gnus).

Workaround: I detected https://wiki.gnupg.org/AgentForwarding as an
intermediate solution - graphical pinentry, and external access with a
linux laptop, GnuPG configured.



Ubuntu 16.04.4 LTS (Stable)

GNU Emacs 27.0.50 (Snapshot)
[http://ppa.launchpad.net/ubuntu-elisp/ppa/ubuntu xenial main]

Message #8 received at 31603 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: <adrian.lanz <at> wsl.ch>
Cc: 31603 <at> debbugs.gnu.org
Subject: Re: bug#31603: 27.0.50; pinentry loopback disappeared
Date: Sat, 26 May 2018 12:14:13 +0100

[Message part 1 (text/plain, inline)]

<adrian.lanz <at> wsl.ch> writes:

> With 'allow-loopback-pinentry' in gpg-agent.conf and (setq
> epa-pinentry-mode 'loopback) in .emacs, I enjoy reliable pass-phrase
> prompting and entering in the Emacs minibuffer for quite some time (at
> least since September 2016).
>
> Now unexpectedly, pinentry-curses started to pop-up for pass-phrase
> prompting. I suspect commit 302e500087fd4cc1c5f37ec87c98e828b22aaa05
> being the cause. I did not find a way to get pinentry-loopback back and
> working.

Have you tried replacing (setq epa-pinentry-mode 'loopback) with
(setq epg-pinentry-mode 'loopback)?  If doing this solves your issue,
then I think the problem with the referenced commit [1: 302e500087] is
that it uses define-obsolete-variable-alias (see docstring) in epa.el
after epg-pinentry-mode has already been defined in epg-config.el.

[1: 302e500087]: 2018-05-23 07:53:58 -0400
  Move epa-pinentry-mode to epg-config (Bug#26298)
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=302e500087fd4cc1c5f37ec87c98e828b22aaa05

In other words, should we do the following?

[0001-Place-epg-pinentry-mode-varalias-before-defcustom.patch (text/x-diff, inline)]

From e0577acadc471ffe64fb31a2a3ea457046cf1944 Mon Sep 17 00:00:00 2001
From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Date: Sat, 26 May 2018 12:09:15 +0100
Subject: [PATCH] Place epg-pinentry-mode varalias before defcustom

* lisp/epa.el (epa-pinentry-mode):
Move obsolete varalias from here...
* lisp/epg-config.el (epg-pinentry-mode): ...to here. (bug#31603)
---
 lisp/epa.el        | 3 ---
 lisp/epg-config.el | 2 ++
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/lisp/epa.el b/lisp/epa.el
index 16621659a6..c3938e90a7 100644
--- a/lisp/epa.el
+++ b/lisp/epa.el
@@ -56,9 +56,6 @@ epa-info-window-height
   :type 'integer
   :group 'epa)
 
-(define-obsolete-variable-alias
-  'epa-pinentry-mode 'epg-pinentry-mode "27.1")
-
 (defgroup epa-faces nil
   "Faces for epa-mode."
   :version "23.1"
diff --git a/lisp/epg-config.el b/lisp/epg-config.el
index 9d9bd7101e..98f458d996 100644
--- a/lisp/epg-config.el
+++ b/lisp/epg-config.el
@@ -69,6 +69,8 @@ epg-passphrase-coding-system
   "Coding system to use with messages from `epg-gpg-program'."
   :type 'symbol)
 
+(define-obsolete-variable-alias
+  'epa-pinentry-mode 'epg-pinentry-mode "27.1")
 
 ;; In the doc string below, we say "symbol `error'" to avoid producing
 ;; a hyperlink for `error' the function.
-- 
2.17.0

[Message part 3 (text/plain, inline)]

-- 
Basil

Message #11 received at 31603 <at> debbugs.gnu.org (full text, mbox):

From: adrian.lanz <at> wsl.ch
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: 31603 <at> debbugs.gnu.org
Subject: Re: bug#31603: 27.0.50; pinentry loopback disappeared
Date: Sat, 26 May 2018 14:49:06 +0200

On Sam 26 Mai 2018 (12:14:13 +0100) Basil L. Contovounesios writes:

> Have you tried replacing (setq epa-pinentry-mode 'loopback) with
> (setq epg-pinentry-mode 'loopback)?  If doing this solves your issue,
> then I think the problem with the referenced commit [1: 302e500087] is
> that it uses define-obsolete-variable-alias (see docstring) in epa.el
> after epg-pinentry-mode has already been defined in epg-config.el.

This was actually the first thing I tried (and I just tried it again to
be sure): pinentry-loopback still fails.

Message #14 received at 31603 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: adrian.lanz <at> wsl.ch
Cc: "Basil L. Contovounesios" <contovob <at> tcd.ie>, 31603 <at> debbugs.gnu.org
Subject: Re: bug#31603: 27.0.50; pinentry loopback disappeared
Date: Sat, 26 May 2018 12:04:46 -0400

> On Sam 26 Mai 2018 (12:14:13 +0100) Basil L. Contovounesios writes:
>
>> then I think the problem with the referenced commit [1: 302e500087] is
>> that it uses define-obsolete-variable-alias (see docstring) in epa.el
>> after epg-pinentry-mode has already been defined in epg-config.el.

Oh, you're right

    emacs -Q --eval "(setq epa-loopback-mode 'loopback)" -l epa

Then <f1> v epa-loopback-mode RET shows that it has been reset to nil.


adrian.lanz <at> wsl.ch writes:

> This was actually the first thing I tried (and I just tried it again to
> be sure): pinentry-loopback still fails.

Well, it's at least part of the problem.  Can you double check that
epa-loopback-mode has the right value?  When I apply Basil's patch, add
'allow-loopback-pinentry' to ~/.gnupg/gpg-agent.conf and (setq
epa-loopback-mode 'loopback), then M-x epa-sign-file does give me a
prompt in the minibuffer, as expected.

Could you also double check that reverting 302e500087 fixes your
problem?

Message #17 received at 31603 <at> debbugs.gnu.org (full text, mbox):

From: adrian.lanz <at> wsl.ch
To: Noam Postavsky <npostavs <at> gmail.com>
Cc: "Basil L. Contovounesios" <contovob <at> tcd.ie>, 31603 <at> debbugs.gnu.org
Subject: Re: bug#31603: 27.0.50; pinentry loopback disappeared
Date: Sun, 27 May 2018 18:41:20 +0200

On Sa 26 Mai 2018 (12:04:46 -0400) Noam Postavsky writes:

>> On Sam 26 Mai 2018 (12:14:13 +0100) Basil L. Contovounesios writes:
>>
>>> then I think the problem with the referenced commit [1: 302e500087] is
>>> that it uses define-obsolete-variable-alias (see docstring) in epa.el
>>> after epg-pinentry-mode has already been defined in epg-config.el.
>
> Oh, you're right
>
>     emacs -Q --eval "(setq epa-loopback-mode 'loopback)" -l epa
>
> Then <f1> v epa-loopback-mode RET shows that it has been reset to nil.
>
>
> adrian.lanz <at> wsl.ch writes:
>
>> This was actually the first thing I tried (and I just tried it again to
>> be sure): pinentry-loopback still fails.
>
> Well, it's at least part of the problem.  Can you double check that
> epa-loopback-mode has the right value?  When I apply Basil's patch, add
> 'allow-loopback-pinentry' to ~/.gnupg/gpg-agent.conf and (setq
> epa-loopback-mode 'loopback), then M-x epa-sign-file does give me a

(The variable name is epa-pinentry-mode, not epa-loopback-mode.)

> prompt in the minibuffer, as expected.

I confirm setting (setq epg-pinentry-mode 'loopback) in .emacs init file
solves the problem (I get again the minibuffer prompt).

The <contovob <at> tcd.ie> proposed patch leads to minibuffer passphrase
prompts, even with only the old (now obsoleted) variable (setq
epa-pinentry-mode 'loopback) present in the .emacs init file. In other
words, with this patch, users do not have to change the configuration
right away.

Thanks!

Message #20 received at 31603 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: adrian.lanz <at> wsl.ch
Cc: "Basil L. Contovounesios" <contovob <at> tcd.ie>, 31603 <at> debbugs.gnu.org
Subject: Re: bug#31603: 27.0.50; pinentry loopback disappeared
Date: Sun, 27 May 2018 14:21:36 -0400

tags 31603 fixed
close 31603 27.1
quit

adrian.lanz <at> wsl.ch writes:

> (The variable name is epa-pinentry-mode, not epa-loopback-mode.)

Oops, that's what I get for typing from memory instead of copying
straight from the working example.

> I confirm setting (setq epg-pinentry-mode 'loopback) in .emacs init file
> solves the problem (I get again the minibuffer prompt).
>
> The <contovob <at> tcd.ie> proposed patch leads to minibuffer passphrase
> prompts, even with only the old (now obsoleted) variable (setq
> epa-pinentry-mode 'loopback) present in the .emacs init file. In other
> words, with this patch, users do not have to change the configuration
> right away.

Thanks for testing, I've pushed to master.

[1: 584f05cb11]: 2018-05-27 14:14:35 -0400
  Place epg-pinentry-mode varalias before defcustom
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=584f05cb11a8010f31beaf07c9ef4180b70d1d66

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.