Subject: Re: [bug#31592] [PATCH 1/4] gnu: Add squashfs-tools-next.

From: [email-masked] (Ludovic Courtès)
Date: Sun, 27 May 2018 14:50:16 +0200

Hello!

Ricardo Wurmus <[email-masked]> skribis:

> * gnu/packages/compression.scm (squashfs-tools-next): New variable.

[...]

> +;; We need this for building squashfs images with symlinks.
> +(define-public squashfs-tools-next
> +  (let ((commit "fb33dfc32b131a1162dcf0e35bd88254ae10e265")
> +        (revision "1"))

Does it mean that the current version does not support symlinks in the
image?

> +    (package (inherit squashfs-tools)
> +      (name "squashfs-tools-next")
> +      (version (string-append "4.3-" revision (string-take commit 7)))

Nitpick: you can use (git-version …) here.

Otherwise LGTM, thanks!

Ludo’.