From debbugs-submit-bounces@debbugs.gnu.org Wed May 23 15:45:31 2018 Received: (at submit) by debbugs.gnu.org; 23 May 2018 19:45:31 +0000 Received: from localhost ([127.0.0.1]:45663 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fLZhS-0000cc-Pi for submit@debbugs.gnu.org; Wed, 23 May 2018 15:45:31 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34656) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fLZhQ-0000cP-U4 for submit@debbugs.gnu.org; Wed, 23 May 2018 15:45:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fLZhK-0002Fe-Mt for submit@debbugs.gnu.org; Wed, 23 May 2018 15:45:23 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:60069) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fLZhK-0002FY-JH for submit@debbugs.gnu.org; Wed, 23 May 2018 15:45:22 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53858) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fLZhJ-0003zZ-HQ for bug-gnu-emacs@gnu.org; Wed, 23 May 2018 15:45:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fLZhG-0002Cr-Eb for bug-gnu-emacs@gnu.org; Wed, 23 May 2018 15:45:21 -0400 Received: from aserp2130.oracle.com ([141.146.126.79]:50950) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fLZhG-0002BZ-1H for bug-gnu-emacs@gnu.org; Wed, 23 May 2018 15:45:18 -0400 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w4NJfTiH009532 for ; Wed, 23 May 2018 19:45:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : subject : content-type : content-transfer-encoding; s=corp-2017-10-26; bh=JbbvjVjRc+oqLtLIBXBS99U5Arcf1duNTcuUajyvjD8=; b=nM2dBIWxCz3+5DlTJqUEfRu2M5JIfMZ05Aj/+Za3k1O4tFSGgUdhiEoz989H4FsVI+Ho qLSATJAeScSTkn8Ys3ogWWYns1j9+eBzcDvaE/vSJCI8RC33r5Jm7DoGppDH7vjr4HoB LcB37Yna+P7z/XzyBflAEno46JlhrGu4WnIje/C53rpxphi85kz5xYqG1JFVRHKTCHMR IowWPuLadhSmVPuVGgRm7KVNxnjmTH5Rj8401et8BL07TXkAkPLICkGJUfhcbpO2K6r4 46BR89X/vVpxx5hV9wqBjDTY0ecXfzwARYiQGs656Qxb1OMa67Qjewj/kX14UQXaTZPt Kg== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp2130.oracle.com with ESMTP id 2j4nh7dht4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 23 May 2018 19:45:15 +0000 Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w4NJjETI000976 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 23 May 2018 19:45:14 GMT Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w4NJjDk4001034 for ; Wed, 23 May 2018 19:45:14 GMT MIME-Version: 1.0 Message-ID: Date: Wed, 23 May 2018 12:45:12 -0700 (PDT) From: Drew Adams To: bug-gnu-emacs@gnu.org Subject: 27.0; Doc string for `with-help-window' X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4690.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8902 signatures=668700 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=805 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1805230192 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) The doc string ends with this sentence:=20 See 'help-window-setup' for more options. But that link takes you to this text, which tells you nothing at all about "more options": Set up help window WINDOW for 'with-help-window'. WINDOW is the window used for displaying the help buffer. Return VALUE. In GNU Emacs 27.0.50 (build 3, x86_64-w64-mingw32) of 2018-03-21 Repository revision: e70d0c9e66d7a8609450b2889869d16aeb0363b5 Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --without-dbus --host=3Dx86_64-w64-mingw32 --without-compress-install -C 'CFLAGS=3D-O2 -static -g3'' From debbugs-submit-bounces@debbugs.gnu.org Thu May 24 03:25:05 2018 Received: (at 31574) by debbugs.gnu.org; 24 May 2018 07:25:05 +0000 Received: from localhost ([127.0.0.1]:45937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fLkcT-0005fU-29 for submit@debbugs.gnu.org; Thu, 24 May 2018 03:25:05 -0400 Received: from mout.gmx.net ([212.227.17.21]:54095) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fLkcR-0005ex-E8 for 31574@debbugs.gnu.org; Thu, 24 May 2018 03:25:03 -0400 Received: from [192.168.1.100] ([213.162.73.65]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0Ls7MZ-1gMCoT3v0Z-013tZg; Thu, 24 May 2018 09:20:55 +0200 Message-ID: <5B0667D0.8060007@gmx.at> Date: Thu, 24 May 2018 09:20:48 +0200 From: martin rudalics MIME-Version: 1.0 To: Drew Adams , 31574@debbugs.gnu.org, Nick Helm Subject: Re: bug#31574: 27.0; Doc string for `with-help-window' References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:5vwqJ22J5fionceGQ7NXmOQNa2353qeWQYEZaxhuUaz3JjPpgJH 6Y1ru0VcSp7x0GqYrAhCc7qZ0MV3HgCUXNTOnFh7cysmxSeP+KGT+GXSjeAEPzDE936mkpx tUKliA66bMesCGFPkX8B7MdWurdAfMuPnR2NE2ib2MyZ21uarXJb1f1xB2rxUQWhWv34ocw EvYfsr3Jbu2Cy2bXSQkQg== X-UI-Out-Filterresults: notjunk:1;V01:K0:8n8K2HoS+/E=:rhXd8szIkby3mIFVQCN5+4 tpE/PSjTK0x8TZZfpFwtF6fC0VIAPUaNPLs8jRltEFUfs5d0YW2RkKw9HSbxYMlK7+phRblGT Gr7oE9/rI1xQbhavhLzK4EiMbKqW0LR9jr1UFEKjxSt+zxxlzeNSO49HHBJKYoc88UjQxeMnw sLVYNCGhdOUZp2T5tkO6zaZ+Nu7Y6poRvvCaWJdWXc9Ug7TqoMZeptFKVT46qn4i37Aj16S1B Q0m3bC5co6amo0N2Cuop5QoLWWbzR5bYRhTp/jsnEPqPkkZTLEVNqVds3/u/yhW9zwwdaoHUC ui45YEtIR0HqQMPtaIZmDOz8tuRkAIaPQCARNkjcmy7xH71Di/R7OOLpYnSde2qG6/LYQJcrZ ufSP2p5/TTJ0kUix962zgDaoiVleSet/EX4krEo1ouzv8rgKX/WAizJM3mqJ64WqCVrMhoIbM K3u0yxoYn7lAe+qJNXj/hlV9Ouuu5PkcLQN7apWqndFdvKOerxRlFhCGMwToUrBKm6JEQua5x LQ78EPk2KIOiVp0iYVvGMae8N3TSup61d0eCzG65EO7F0DsSIRyZ0bqMRi2DA9IhF897sKuHw uNu7kKS2xXvZosZux3xO8hIEiY+E+e4IWsEIsrC/paqdMQNAU+AigaxzuGP2CqMJR+GROMzFS WwrOG+AsoHht4OWRjPCfrI7A/9EuGnlu00oKskHBALkBx+fzKrr7QCDQ41DFdGOHePOAj2xos DDL33Nmft5UwhabB3AQ3tXdgEbnfF2gswAnPQ2LrJmFgMdJYnFHnDkhxOsv0iJxMQPLquuKHf BFhX+7x X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 31574 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > The doc string ends with this sentence: > > See 'help-window-setup' for more options. > > But that link takes you to this text, which tells you nothing at all > about "more options": Indeed. This was part of the fix for Bug#30792. Nick, could you please have a look ? martin From debbugs-submit-bounces@debbugs.gnu.org Thu May 24 12:31:39 2018 Received: (at 31574-done) by debbugs.gnu.org; 24 May 2018 16:31:39 +0000 Received: from localhost ([127.0.0.1]:46674 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fLt9P-0003g2-IU for submit@debbugs.gnu.org; Thu, 24 May 2018 12:31:39 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45652) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fLt9N-0003fo-K2 for 31574-done@debbugs.gnu.org; Thu, 24 May 2018 12:31:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fLt9C-0005ek-FO for 31574-done@debbugs.gnu.org; Thu, 24 May 2018 12:31:32 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:38325) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fLt9C-0005eg-C3; Thu, 24 May 2018 12:31:26 -0400 Received: from [176.228.60.248] (port=3935 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fLt9B-0003AQ-Qo; Thu, 24 May 2018 12:31:26 -0400 Date: Thu, 24 May 2018 19:31:36 +0300 Message-Id: <83k1rtauc7.fsf@gnu.org> From: Eli Zaretskii To: Drew Adams In-reply-to: (message from Drew Adams on Wed, 23 May 2018 12:45:12 -0700 (PDT)) Subject: Re: bug#31574: 27.0; Doc string for `with-help-window' References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31574-done Cc: 31574-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > Date: Wed, 23 May 2018 12:45:12 -0700 (PDT) > From: Drew Adams > > The doc string ends with this sentence: > > See 'help-window-setup' for more options. > > But that link takes you to this text, which tells you nothing at all > about "more options": "Options" was not the best word here, so I rephrased the last sentence of the doc string. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu May 24 13:18:03 2018 Received: (at 31574-done) by debbugs.gnu.org; 24 May 2018 17:18:03 +0000 Received: from localhost ([127.0.0.1]:46731 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fLtsJ-0004ob-Cu for submit@debbugs.gnu.org; Thu, 24 May 2018 13:18:03 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:43364) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fLtsH-0004o7-6S for 31574-done@debbugs.gnu.org; Thu, 24 May 2018 13:18:01 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w4OHGJJb172146; Thu, 24 May 2018 17:17:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2017-10-26; bh=6BMYsMeaZ+PSSHiPXpbk4wj34LKjCRvBUVLS5Gq3lNk=; b=F/V185fxevJl2362+XiziDEFNcUoX09cEo1OVD8tWoIBsszrHwB8j0KzepPOZL97tYsQ 7IgzL0tQBEDRZucYIHNC6rkIJkCtqSKSZS800BAQoRLm5T5+n2tecK+Sm0pd+7AB+FOb vsAkPE5DMsmkLfluLyCOzTcEE+ULBo26+V+mQs1GLc1Z28uvpCKWxzvzutebIJ4n7E5p H47RuSVF5Cz2nP2NeybtJA26tRHPZ/Kj39WN7OZzOBSoBz0la/KG9sU5jqRFUS3UqaH/ vkGl85aJC2VV0zjUJDUgnFNrJ7/mpDq3Ba1NYOcXXusWdWChmZnq3X5hSUMs3NJbysy4 wg== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp2120.oracle.com with ESMTP id 2j4nh7sfw5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 24 May 2018 17:17:53 +0000 Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w4OHHqXU013181 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 24 May 2018 17:17:53 GMT Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w4OHHpMn020648; Thu, 24 May 2018 17:17:51 GMT MIME-Version: 1.0 Message-ID: <73e710f8-8373-46e5-913a-b3cba178a384@default> Date: Thu, 24 May 2018 10:17:49 -0700 (PDT) From: Drew Adams To: Eli Zaretskii , Drew Adams Subject: RE: bug#31574: 27.0; Doc string for `with-help-window' References: <> <<83k1rtauc7.fsf@gnu.org>> In-Reply-To: <<83k1rtauc7.fsf@gnu.org>> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4690.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8902 signatures=668700 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=732 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1805240197 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 31574-done Cc: 31574-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > > The doc string ends with this sentence: > > > > See 'help-window-setup' for more options. > > > > But that link takes you to this text, which tells you nothing at all > > about "more options": >=20 > "Options" was not the best word here, so I rephrased the last sentence > of the doc string. I see that the bug was closed. Not sure what the fix was, but if it was just to change "options" then it might not really be fixed. The real problem is that after you follow the link there is NOTHING about `with-help-window', AFAICT. And I should have been clear that the doc string of `help-window-setup' is even more problematic. It doesn't say anything helpful at all, AFAICT. What does setting up that window even mean? The only thing this doc string tells you, that you might not guess, is that VALUE is returned from the function. Did you fix the doc string of `help-window-setup', or can you please do so as part of this bug? Or do you need a separate bug filed for that? From debbugs-submit-bounces@debbugs.gnu.org Thu May 24 14:09:31 2018 Received: (at 31574) by debbugs.gnu.org; 24 May 2018 18:09:31 +0000 Received: from localhost ([127.0.0.1]:46773 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fLug7-00060F-BA for submit@debbugs.gnu.org; Thu, 24 May 2018 14:09:31 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43303) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fLug5-000601-Ep for 31574@debbugs.gnu.org; Thu, 24 May 2018 14:09:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fLufw-0002XC-B1 for 31574@debbugs.gnu.org; Thu, 24 May 2018 14:09:24 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:40248) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fLufw-0002X6-8l; Thu, 24 May 2018 14:09:20 -0400 Received: from [176.228.60.248] (port=4151 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fLufv-0007zD-L6; Thu, 24 May 2018 14:09:20 -0400 Date: Thu, 24 May 2018 21:09:30 +0300 Message-Id: <83zi0p9b8l.fsf@gnu.org> From: Eli Zaretskii To: Drew Adams In-reply-to: <73e710f8-8373-46e5-913a-b3cba178a384@default> (message from Drew Adams on Thu, 24 May 2018 10:17:49 -0700 (PDT)) Subject: Re: bug#31574: 27.0; Doc string for `with-help-window' References: <> <<83k1rtauc7.fsf@gnu.org>> <73e710f8-8373-46e5-913a-b3cba178a384@default> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31574 Cc: 31574@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > Date: Thu, 24 May 2018 10:17:49 -0700 (PDT) > From: Drew Adams > Cc: 31574-done@debbugs.gnu.org > > > "Options" was not the best word here, so I rephrased the last sentence > > of the doc string. > > I see that the bug was closed. Not sure what the fix was, > but if it was just to change "options" then it might not > really be fixed. I told yesterday in response to another message of yours how can you see the changes in the repository using Web browser. Please take a look, then we can discuss the fix. > The real problem is that after you follow the link there > is NOTHING about `with-help-window', AFAICT. No, the real problem is that the reference to help-window-setup gave you wrong expectations regarding what information that function should add. My change tried to make those expectations match the original intent. > And I should have been clear that the doc string of > `help-window-setup' is even more problematic. It doesn't > say anything helpful at all, AFAICT. That's a subroutine, so I don't necessarily see its doc string as something we need to invest an effort in. From debbugs-submit-bounces@debbugs.gnu.org Thu May 24 15:03:08 2018 Received: (at 31574) by debbugs.gnu.org; 24 May 2018 19:03:08 +0000 Received: from localhost ([127.0.0.1]:46786 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fLvW0-0007Kc-G9 for submit@debbugs.gnu.org; Thu, 24 May 2018 15:03:08 -0400 Received: from aserp2130.oracle.com ([141.146.126.79]:37414) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fLvVw-0007K4-V5 for 31574@debbugs.gnu.org; Thu, 24 May 2018 15:03:05 -0400 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w4OJ11ws178855; Thu, 24 May 2018 19:02:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2017-10-26; bh=caClaWmvnLXP7X/6jp5uXlTOFOw6La8Co42Sz/meWeo=; b=JrXyJSvY0MMGaYqCxTzWHVU4EcnuHyKqYRHNFlU9zHk4pXyBgsxZTe/57hu0olEfDdIc dQzNDL0rItVDJ+0OaqJuQsowaeH9h9ZWFs2cOvl+stiCdTf5STebgbWa5N2KhaL6vLg0 ZkMby7XDMuN7kK/NzZdvkbdE3lNxf3LTUv+YZiorxV4Yp6CUh88Vikt+gYtghmGgho+E NjOUM8wMkMxHBMDYdxodkanazhD1AQi8OGZHgSTVJZGHvOfaVwLbXH8xbSrQ/RucP25s XNrMa5ONGNG0y/IT6XGpPkZyzA9yt3x/VBPST1mhLyeOzVSCALpIs2u9jgUK7+jfSGjA 7Q== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by aserp2130.oracle.com with ESMTP id 2j62sw86ae-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 24 May 2018 19:02:57 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w4OIQOjs009829 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 24 May 2018 18:26:25 GMT Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w4OIQNJi002266; Thu, 24 May 2018 18:26:24 GMT MIME-Version: 1.0 Message-ID: Date: Thu, 24 May 2018 11:26:22 -0700 (PDT) From: Drew Adams To: Eli Zaretskii , Drew Adams Subject: RE: bug#31574: 27.0; Doc string for `with-help-window' References: <<>> <<<83k1rtauc7.fsf@gnu.org>>> <<73e710f8-8373-46e5-913a-b3cba178a384@default>> <<83zi0p9b8l.fsf@gnu.org>> In-Reply-To: <<83zi0p9b8l.fsf@gnu.org>> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4690.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8903 signatures=668700 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1805240218 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 31574 Cc: 31574@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > I told yesterday in response to another message of yours how can you > see the changes in the repository using Web browser. Please take a > look, then we can discuss the fix. I looked at your mention of this, which was apparently in a bug #31311 message. After jumping through some hoops, yes, one can see the texinfo source code. But even trying that for this bug, I don't see it. I don't see anything about 31574 here, which is presumably the latest and right place to look for it (?): http://git.savannah.gnu.org/cgit/emacs.git/log/ > > The real problem is that after you follow the link there > > is NOTHING about `with-help-window', AFAICT. >=20 > No, the real problem is that the reference to help-window-setup gave > you wrong expectations regarding what information that function should > add. My change tried to make those expectations match the original > intent. Which was what? > > And I should have been clear that the doc string of > > `help-window-setup' is even more problematic. It doesn't > > say anything helpful at all, AFAICT. >=20 > That's a subroutine, so I don't necessarily see its doc string as > something we need to invest an effort in. We disagree. A doc string that says only that WINDOW is the windo for displaying the help buffer (obvious), plus just "Return VALUE" might as well not even exist (and the optional arg should be called RETURN-VALUE). This is a non-trivial function. Some explanation of what the window "setup" entails is appropriate. From debbugs-submit-bounces@debbugs.gnu.org Thu May 24 15:09:56 2018 Received: (at 31574) by debbugs.gnu.org; 24 May 2018 19:09:56 +0000 Received: from localhost ([127.0.0.1]:46817 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fLvcY-0007Vj-GX for submit@debbugs.gnu.org; Thu, 24 May 2018 15:09:56 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54320) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fLvcX-0007VW-CO for 31574@debbugs.gnu.org; Thu, 24 May 2018 15:09:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fLvcP-00017L-03 for 31574@debbugs.gnu.org; Thu, 24 May 2018 15:09:48 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41050) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fLvcO-00017E-Se; Thu, 24 May 2018 15:09:44 -0400 Received: from [176.228.60.248] (port=4559 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fLvcN-0001O9-NH; Thu, 24 May 2018 15:09:44 -0400 Date: Thu, 24 May 2018 22:09:50 +0300 Message-Id: <83wovsan0h.fsf@gnu.org> From: Eli Zaretskii To: Drew Adams In-reply-to: (message from Drew Adams on Thu, 24 May 2018 11:26:22 -0700 (PDT)) Subject: Re: bug#31574: 27.0; Doc string for `with-help-window' References: <<>> <<<83k1rtauc7.fsf@gnu.org>>> <<73e710f8-8373-46e5-913a-b3cba178a384@default>> <<83zi0p9b8l.fsf@gnu.org>> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31574 Cc: 31574@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > Date: Thu, 24 May 2018 11:26:22 -0700 (PDT) > From: Drew Adams > Cc: 31574@debbugs.gnu.org > > But even trying that for this bug, I don't see it. I don't see > anything about 31574 here, which is presumably the latest and > right place to look for it (?): > > http://git.savannah.gnu.org/cgit/emacs.git/log/ That's the master branch. You need to look at emacs-26, which is where I fixed this. There's a dialog box on the top right corner of the window, which should say "master"; click the arrow, and select "emacs-26". > > No, the real problem is that the reference to help-window-setup gave > > you wrong expectations regarding what information that function should > > add. My change tried to make those expectations match the original > > intent. > > Which was what? That the doc string of help-window-setup says something that sheds light on with-help-window. From debbugs-submit-bounces@debbugs.gnu.org Thu May 24 15:26:52 2018 Received: (at 31574) by debbugs.gnu.org; 24 May 2018 19:26:52 +0000 Received: from localhost ([127.0.0.1]:46863 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fLvsy-0007vZ-12 for submit@debbugs.gnu.org; Thu, 24 May 2018 15:26:52 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:52022) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fLvss-0007uY-Cj for 31574@debbugs.gnu.org; Thu, 24 May 2018 15:26:46 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w4OJPwLN077681; Thu, 24 May 2018 19:26:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2017-10-26; bh=BrCY6oVs26hXCkvfMx0/9xZy9I+OF6rwi31mALRtpbU=; b=gTx0YcWlTvbXHUSUzaAuhU9IyQEHCI+hzq6wGG/W2JGbtJ3/A0SFL1L4QVZ+dEDbehyC SWDqf7B3W52sxqpB4OAz1HVk7MF/fLgIxH8g47jqtV0CGilbzKFMD1egZBWvRk9Sue/u /Cp6b2h6CIA5kxapbbv6wuDqiaNMai16QQQbJnTUVBcdk/F1zyQtjds5yfwn7+GRdUO5 0oQ4Q/G3pi3sTNdtCgwGPHVXm9zVcSSR/JmKSvarO/RYECCgfIajji2UARiFN02psZVj IbbxIju+bv/TQIKfXtNesa3UovacnDpr0th6o6G1fl6yCn9u3Jrq75Www8OhNT5OzRXR /w== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp2120.oracle.com with ESMTP id 2j62swg99y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 24 May 2018 19:26:38 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w4OJQb3T015031 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 24 May 2018 19:26:37 GMT Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w4OJQaOV009015; Thu, 24 May 2018 19:26:37 GMT MIME-Version: 1.0 Message-ID: <3bbb4d9f-77ac-49d9-9bd8-5b25563ca350@default> Date: Thu, 24 May 2018 12:26:35 -0700 (PDT) From: Drew Adams To: Eli Zaretskii Subject: RE: bug#31574: 27.0; Doc string for `with-help-window' References: <<>> <<<83k1rtauc7.fsf@gnu.org>>> <<73e710f8-8373-46e5-913a-b3cba178a384@default>> <<83zi0p9b8l.fsf@gnu.org>> <83wovsan0h.fsf@gnu.org> In-Reply-To: <83wovsan0h.fsf@gnu.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4690.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8903 signatures=668700 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=455 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1805240222 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 31574 Cc: 31574@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > That's the master branch. You need to look at emacs-26, which is > where I fixed this. There's a dialog box on the top right corner of > the window, which should say "master"; click the arrow, and select > "emacs-26". Thanks for this info. From unknown Fri Jun 20 19:50:20 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 22 Jun 2018 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator