From debbugs-submit-bounces@debbugs.gnu.org Sun May 20 18:57:10 2018 Received: (at submit) by debbugs.gnu.org; 20 May 2018 22:57:11 +0000 Received: from localhost ([127.0.0.1]:42222 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fKXGI-0003gk-IO for submit@debbugs.gnu.org; Sun, 20 May 2018 18:57:10 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55649) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fKXGG-0003gX-Tl for submit@debbugs.gnu.org; Sun, 20 May 2018 18:57:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fKXGA-0006Yu-MR for submit@debbugs.gnu.org; Sun, 20 May 2018 18:57:03 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:36178) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fKXGA-0006Ym-Io for submit@debbugs.gnu.org; Sun, 20 May 2018 18:57:02 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46618) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fKXG8-0006Q5-Ux for guix-patches@gnu.org; Sun, 20 May 2018 18:57:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fKXG4-0006Xg-To for guix-patches@gnu.org; Sun, 20 May 2018 18:57:01 -0400 Received: from mail-qt0-x241.google.com ([2607:f8b0:400d:c0d::241]:34715) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fKXG4-0006XV-MX for guix-patches@gnu.org; Sun, 20 May 2018 18:56:56 -0400 Received: by mail-qt0-x241.google.com with SMTP id m5-v6so16888374qti.1 for ; Sun, 20 May 2018 15:56:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:user-agent:mime-version; bh=MGkQLJNOmTUO3Em21ZbHatS7D6/ZMpqzyx91W3BangA=; b=QHs6eT6b7I/YuDWUjkJPwKOQC3Ixu43qhpAqmwbWjuiN8xWcNWg4RXuM6StZJWWnEe AleboK4m8zYllQQOJ4HnfkRSpWFcB0AeSCv24P6QPUW0azFtT++MpDxTPf/iO/uvDE9B EqHLWDjN8fFQkXRIJGfb3J4yUme2DHfI0db3yMkfy3dZG2uMihloraofvBMkczD4A+FF hKLahJP/8B1lSTfGmbWvZy/ddcqCrhE7iShrS3qxhFD64UNBSPK8po4W9Ji5CklwpbGj XUPQu5DZO50x6n9WdKg/E8VEPMof20YZxpLdrIkc9gMzlh2TI7ld8aWAHMV8HyiSZWEx fbcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :mime-version; bh=MGkQLJNOmTUO3Em21ZbHatS7D6/ZMpqzyx91W3BangA=; b=MKtn1fq9XlcwAIjpPBuEzMfSvuYe+QnWpB1AevFlJdMW6wdmt9Pf/DbOZnuKd75fD1 UDp6bAkbWHQ270QsoERMWd3oeuUoMwUIUxWYE2SPHXLTDVJztWJHszh8ppCxC3zLr4ee 0PiH5oDaSPmyhDQ+0lvKoyiRmakG9IrsmyTH4bHFZ9Zwuf2Zj6iCplgCzUg4LgjeAomT 0qtXuIipGaV0dWp64DVjJ2ajFopgNYldo+M4sW1yVM3TRdZXuO9FcH0m81fPcKO6s6S9 W0b4PrwSVqTxW7Acyce+csA/xTDQ+x58d3xO2a4xxijE4xl9nKVp3Q1IX3x3XfUbKMj9 nxJw== X-Gm-Message-State: ALKqPwdShwTeaikUGnQTMO14tZtXLr0NU6JVToGy9qClhhPSh0toUPH1 mPkRs0YabCKcHbfY+g7sEdk5aJqA X-Google-Smtp-Source: AB8JxZoasTDpF4Hm8lPAwq+RxPjCs5vr9EU50nsnDCg23UiIIJh8I9g2zOcG38DTwfayKWQcu3JWCQ== X-Received: by 2002:ac8:347c:: with SMTP id v57-v6mr16284492qtb.219.1526857015557; Sun, 20 May 2018 15:56:55 -0700 (PDT) Received: from localhost (dyn-160-39-62-188.dyn.columbia.edu. [160.39.62.188]) by smtp.gmail.com with ESMTPSA id r74-v6sm10540641qkh.17.2018.05.20.15.56.54 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 20 May 2018 15:56:54 -0700 (PDT) From: Adam Massmann To: guix-patches@gnu.org Subject: [PATCH] gnu: xapers: Fix recommended packages Date: Sun, 20 May 2018 18:56:53 -0400 Message-ID: <874lj25422.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --=-=-= Content-Type: text/plain Hi Guix, Below is a patch to fix/update inputs for xapers. When I originally added xapers I avoided including inputs upstream considers "recommended." After using Guix and xapers some more and thinking about it, I now lean towards including these inputs because in this case not including them will break xapers functionality in undocumented ways, and the recommended packages are relatively modest. However, I am also curious for future use if there is any documentation on standards for handling "recommended" packages (e.g. packages other disdros would assign a "recommended tag" to) in Guix? I couldn't find anything in the manual, but it is very possible I missed something. I also disabled the "xapers-adder" command from spawning an x-terminal program (upstream uses Debian's "x-terminal-emulator"). By disabling this function we avoid pushing an x-terminal program onto users, which I find undesirable (if users need to spawn a terminal they can just wrap xapers-adder e.g. "xterm -e xapers-adder %F"). However, I'm open to other solutions if anyone else has another preference/idea (see comment in patch). Feedback very welcome, and thank you very much for your time/help. Best, Adam --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnu-xapers-Fix-recommended-packages.patch >From 434455c9be92ecb34e220726dfc75b916e0eaa6c Mon Sep 17 00:00:00 2001 From: Adam Massmann Date: Sun, 20 May 2018 18:50:03 -0400 Subject: [PATCH] gnu: xapers: Fix recommended packages * gnu/packages/search.scm (xapers): [inputs]: remove python, poppler [propagated-inputs]: add poppler, xclip, xdg-utils. [arguments]: modify-phases to disable x-terminal options. --- gnu/packages/search.scm | 39 +++++++++++++++++++++++++++++++++------ 1 file changed, 33 insertions(+), 6 deletions(-) diff --git a/gnu/packages/search.scm b/gnu/packages/search.scm index 02deb5c4a..5c8539d56 100644 --- a/gnu/packages/search.scm +++ b/gnu/packages/search.scm @@ -32,12 +32,14 @@ #:use-module (gnu packages compression) #:use-module (gnu packages check) #:use-module (gnu packages databases) + #:use-module (gnu packages freedesktop) #:use-module (gnu packages linux) #:use-module (gnu packages perl) #:use-module (gnu packages pdf) #:use-module (gnu packages python) #:use-module (gnu packages python-web) #:use-module (gnu packages web) + #:use-module (gnu packages xdisorg) #:use-module (gnu packages xml)) (define-public xapian @@ -326,27 +328,52 @@ search the generated indexes.") "0ykz6hn3qj46w3c99d6q0pi5ncq2894simcl7vapv047zm3cylmd")))) (build-system python-build-system) (propagated-inputs - `(("python-urwid" ,python-urwid))) - (inputs `(("poppler" ,poppler) - ("python" ,python) - ("python-latexcodec" ,python-latexcodec) + ("python-urwid" ,python-urwid) + ("xclip" ,xclip) + ("xdg-utils" ,xdg-utils))) + (inputs + `(("python-latexcodec" ,python-latexcodec) ("python-pybtex" ,python-pybtex) ("python-pycurl" ,python-pycurl) ("python-pyyaml" ,python-pyyaml) ("python-six" ,python-six) ("python-xapian-bindings" ,python-xapian-bindings))) (arguments - `(#:phases + `(#:modules ((ice-9 rdelim) + (guix build python-build-system) + (guix build utils)) + #:phases (modify-phases %standard-phases (add-after 'install 'install-doc (lambda* (#:key inputs outputs #:allow-other-keys) + (define (purge-term-support input output) + (let loop ((line (read-line input))) + (if (string-prefix? "if [[ \"$term\"" line) + (begin (display "eval \"$cmd\"\n" output) + #t) + (begin (display (string-append line "\n") output) + (loop (read-line input)))))) (let* ((out (assoc-ref outputs "out")) (bin (string-append out "/bin")) + (adder-out (string-append bin "/xapers-adder")) (man1 (string-append out "/share/man/man1"))) (install-file "man/man1/xapers.1" man1) (install-file "man/man1/xapers-adder.1" man1) - (install-file "bin/xapers-adder" bin))))))) + ;; below is equivalent to setting --no-term option + ;; permanently on; this is desirable to avoid imposing + ;; an x-terminal installation on the user but breaks + ;; some potential xapers-adder uses like auto browser + ;; pdf handler, but user could instead still use + ;; e.g. "xterm -e xapers-adder %F" for same use. + ;; alternatively we could propagate xterm as an input + ;; and replace 'x-terminal-emulator' with 'xterm' + (call-with-input-file "bin/xapers-adder" + (lambda (input) + (call-with-output-file adder-out + (lambda (output) + (purge-term-support input output))))) + (chmod adder-out #o555))))))) (home-page "https://finestructure.net/xapers/") (synopsis "Personal document indexing system") (description -- 2.17.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat May 26 15:55:43 2018 Received: (at 31540-done) by debbugs.gnu.org; 26 May 2018 19:55:43 +0000 Received: from localhost ([127.0.0.1]:49917 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fMfHz-00034t-G2 for submit@debbugs.gnu.org; Sat, 26 May 2018 15:55:43 -0400 Received: from eggs.gnu.org ([208.118.235.92]:51020) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fMfHx-00034h-QX for 31540-done@debbugs.gnu.org; Sat, 26 May 2018 15:55:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fMfHr-00085n-Gm for 31540-done@debbugs.gnu.org; Sat, 26 May 2018 15:55:36 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:38720) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fMfHr-00085h-Ae; Sat, 26 May 2018 15:55:35 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=34270 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fMfHq-0002il-TB; Sat, 26 May 2018 15:55:35 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Adam Massmann Subject: Re: [bug#31540] [PATCH] gnu: xapers: Fix recommended packages References: <874lj25422.fsf@gmail.com> Date: Sat, 26 May 2018 21:55:33 +0200 In-Reply-To: <874lj25422.fsf@gmail.com> (Adam Massmann's message of "Sun, 20 May 2018 18:56:53 -0400") Message-ID: <87tvquyyx6.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31540-done Cc: 31540-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Hi Adam, Adam Massmann skribis: > Below is a patch to fix/update inputs for xapers. When I originally > added xapers I avoided including inputs upstream considers > "recommended." After using Guix and xapers some more and thinking about > it, I now lean towards including these inputs because in this case not > including them will break xapers functionality in undocumented ways, and > the recommended packages are relatively modest. However, I am also > curious for future use if there is any documentation on standards for > handling "recommended" packages (e.g. packages other disdros would > assign a "recommended tag" to) in Guix? I couldn't find anything in the > manual, but it is very possible I missed something. There=E2=80=99s currently no mechanism to recommend a package. However in = this case the recommend packages need to be present at build time, not just at configure time IIUC, so a recommendation system wouldn=E2=80=99t help, w= ould it? For optional build-time dependencies, a criterion we commonly use is the benefit vs. space ratio. So basically you run =E2=80=98guix size=E2=80=99 = with and without the optional dependency, and based on that you determine whether it=E2=80=99s a good idea to add it. Here I get 323=C2=A0MiB with your patch and 324=C2=A0MiB (!) without it for= the whole xapers closure. I think that=E2=80=99s because the new one no longer refers to xterm or something? > I also disabled the "xapers-adder" command from spawning an x-terminal > program (upstream uses Debian's "x-terminal-emulator"). By disabling > this function we avoid pushing an x-terminal program onto users, which I > find undesirable (if users need to spawn a terminal they can just wrap > xapers-adder e.g. "xterm -e xapers-adder %F"). However, I'm open to > other solutions if anyone else has another preference/idea (see comment > in patch). Makes sense to me. >>>From 434455c9be92ecb34e220726dfc75b916e0eaa6c Mon Sep 17 00:00:00 2001 > From: Adam Massmann > Date: Sun, 20 May 2018 18:50:03 -0400 > Subject: [PATCH] gnu: xapers: Fix recommended packages > > * gnu/packages/search.scm (xapers): [inputs]: remove python, poppler > [propagated-inputs]: add poppler, xclip, xdg-utils. > [arguments]: modify-phases to disable x-terminal options. Applied, thanks! Ludo=E2=80=99. From unknown Tue Jun 17 22:22:08 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 24 Jun 2018 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator