Subject: [bug#31531] [PATCH 1/3] gnu: Add cppzmq.

From: Ricardo Wurmus <[email-masked]>
Date: Mon, 21 May 2018 22:31:48 +0200

Hi Theodoros,

> * gnu/packages/networking.scm (cppzmq): New variable.

Thanks for the patch!

> +(define-public cppzmq
> +  (package
> +    (name "cppzmq")
> +    (version "4.2.2")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "https://github.com/zeromq/" name
> +                    "/archive/v" version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "0zbk3726pvcl088qzl5z3cc0w0k5hh192l5jddnc0xsqmiq01x9y"))
> +              (file-name (string-append name "-" version
> ".tar.gz"))))

Please use “git-fetch” here and let the file name end on “-checkout”.
These automatically generated tarballs on GitHub are not stable; they
change over time.

> +    (build-system cmake-build-system)
> +    (arguments
> +     '(#:tests? #f)) ;; No tests.

Please just use a single semicolon for end of line comments.  You can
move this expression on the previous line, because it is short.

> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)))
> +    (inputs
> +     `(("zeromq" ,zeromq)))
> +    (home-page "http://zeromq.org")
> +    (synopsis "C++ bindings for ØMQ")
> +    (description
> +     "Header-only C++ bindings for ØMQ.  Contains direct mappings of the
> +abstractions provided by the ØMQ C API.")

Please use complete sentences.

Could you please send a new patch?

-- 
Ricardo