GNU bug report logs - #31528
patch get-bytevector-n to read more than 4 GB

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: tracker <at> debbugs.gnu.org
Subject: bug#31528: closed (patch get-bytevector-n to read more than 4 GB)
Date: Mon, 18 Jun 2018 12:06:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 18 Jun 2018 14:05:16 +0200
with message-id <874li0wb9f.fsf <at> gnu.org>
and subject line Re: bug#31528: patch get-bytevector-n to read more than 4 GB
has caused the debbugs.gnu.org bug report #31528,
regarding patch get-bytevector-n to read more than 4 GB
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
31528: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=31528
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Jan Šmydke <jan.smydke <at> gmail.com>
To: bug-guile <at> gnu.org
Subject: patch get-bytevector-n to read more than 4 GB
Date: Sat, 19 May 2018 13:10:15 +0200

[Message part 3 (text/plain, inline)]

Hi,

I found

(use-modules (rnrs io ports))

(define v (call-with-input-file "EIVE01.DAT" (lambda (port)
>
  (get-bytevector-n port (* 5 1024 1024 1024)))))
>

fails due to 'out of range':

ERROR: In procedure get-bytevector-n:

ERROR: Value out of range 0 to 4294967295: 52434042880


 The "count" variable was of "unsigned" type (i.e. 32-bit) so I changed it
to "size_t" and the problem is solved.

Enclosed is the corresponding patch (using format-patch)

Jan Šmydke

[Message part 4 (text/html, inline)]

[patch (application/octet-stream, attachment)]

[Message part 6 (message/rfc822, inline)]

From: ludo <at> gnu.org (Ludovic Courtès)
To: Jan Šmydke <jan.smydke <at> gmail.com>
Cc: 31528-done <at> debbugs.gnu.org
Subject: Re: bug#31528: patch get-bytevector-n to read more than 4 GB
Date: Mon, 18 Jun 2018 14:05:16 +0200

Hello Jan,

Jan Šmydke <jan.smydke <at> gmail.com> skribis:

>  The "count" variable was of "unsigned" type (i.e. 32-bit) so I changed it
> to "size_t" and the problem is solved.
>
> Enclosed is the corresponding patch (using format-patch)
>
> Jan Šmydke
> From 5b72b9d9c3cfa40884594eb1d403ec1d2f477d37 Mon Sep 17 00:00:00 2001
> From: Jan Smydke <jan.smydke <at> gmail.com>
> Date: Sat, 19 May 2018 12:48:01 +0200
> Subject: [PATCH] get-bytevector-n and get-bytevector-n! can now read more than
>  4 GB: var "count" changed from unsigned to size_t
>
> ---
>  libguile/r6rs-ports.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)

Awesome.  I adjusted the commit log to match our conventions and
committed.

Thank you!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.