From debbugs-submit-bounces@debbugs.gnu.org Fri May 18 15:13:35 2018 Received: (at submit) by debbugs.gnu.org; 18 May 2018 19:13:35 +0000 Received: from localhost ([127.0.0.1]:40200 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fJkoi-00021u-Gi for submit@debbugs.gnu.org; Fri, 18 May 2018 15:13:35 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40074) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fJkog-00021i-Mi for submit@debbugs.gnu.org; Fri, 18 May 2018 15:13:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fJkoa-0005kG-2W for submit@debbugs.gnu.org; Fri, 18 May 2018 15:13:21 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:47370) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fJkoZ-0005k6-V4 for submit@debbugs.gnu.org; Fri, 18 May 2018 15:13:19 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59277) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fJkoY-0003jb-Hs for guix-patches@gnu.org; Fri, 18 May 2018 15:13:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fJkoV-0005hY-7o for guix-patches@gnu.org; Fri, 18 May 2018 15:13:18 -0400 Received: from dd26836.kasserver.com ([85.13.145.193]:59464) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fJkoV-0005bq-12 for guix-patches@gnu.org; Fri, 18 May 2018 15:13:15 -0400 Received: from dayas.3.home (77.118.252.173.wireless.dyn.drei.com [77.118.252.173]) by dd26836.kasserver.com (Postfix) with ESMTPSA id 0A415336072E; Fri, 18 May 2018 21:13:03 +0200 (CEST) From: Danny Milosavljevic To: guix-patches@gnu.org Subject: [PATCH] gnu: u-boot-tools: Enable tests. Date: Fri, 18 May 2018 21:12:47 +0200 Message-Id: <20180518191247.18456-1-dannym@scratchpost.org> X-Mailer: git-send-email 2.16.2 Tags: patch X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit Cc: Danny Milosavljevic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) * gnu/packages/bootloaders.scm (dtc)[native-search-paths]: Add PYTHONPATH. (u-boot-tools)[native-inputs]: Add openssl, python2-coverage, python2-pytest, sdl. [arguments]<#:make-flags>: Remove NO_SDL. [arguments]<#:test-target>: Change to "tests". [arguments]<#:phases>[patch]: New phase. [arguments]<#:phases>[check]: Replace and move. --- gnu/packages/bootloaders.scm | 49 +++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 46 insertions(+), 3 deletions(-) diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm index 333f30e72..4041f2320 100644 --- a/gnu/packages/bootloaders.scm +++ b/gnu/packages/bootloaders.scm @@ -33,6 +33,7 @@ #:use-module (gnu packages disk) #:use-module (gnu packages bison) #:use-module (gnu packages cdrom) + #:use-module (gnu packages check) #:use-module (gnu packages cross-base) #:use-module (gnu packages disk) #:use-module (gnu packages firmware) @@ -49,6 +50,7 @@ #:use-module (gnu packages python) #:use-module (gnu packages texinfo) #:use-module (gnu packages tls) + #:use-module (gnu packages sdl) #:use-module (gnu packages swig) #:use-module (gnu packages virtualization) #:use-module (gnu packages web) @@ -317,6 +319,10 @@ menu to select one of the installed operating systems.") `(("bison" ,bison) ("flex" ,flex) ("swig" ,swig))) + (native-search-paths + (list (search-path-specification + (variable "PYTHONPATH") + (files '("/lib/python2.7/site-packages"))))) (inputs `(("python-2" ,python-2))) (arguments @@ -350,7 +356,11 @@ tree binary files. These are board description files used by Linux and BSD.") (native-inputs `(("bc" ,bc) ("dtc" ,dtc) + ("openssl" ,openssl) ("python-2" ,python-2) + ("python2-coverage" ,python2-coverage) + ("python2-pytest" ,python2-pytest) + ("sdl" ,sdl) ("swig" ,swig))) (build-system gnu-build-system) (home-page "http://www.denx.de/wiki/U-Boot/") @@ -364,10 +374,34 @@ also initializes the boards (RAM etc).") (inherit u-boot) (name "u-boot-tools") (arguments - `(#:make-flags '("HOSTCC=gcc" "NO_SDL=1") - #:test-target "test" + `(#:make-flags '("HOSTCC=gcc") + #:test-target "tests" #:phases (modify-phases %standard-phases + (add-after 'unpack 'patch + (lambda* (#:key inputs #:allow-other-keys) + (substitute* "Makefile" + (("/bin/pwd") (which "pwd")) + (("/bin/false") (which "false"))) + (substitute* "tools/dtoc/fdt_util.py" + (("'cc'") "'gcc'")) + (substitute* "test/run" + ;; Make it easier to find test failures. + (("#!/bin/bash") "#!/bin/bash -x") + ;; pytest doesn't find it otherwise. + (("test/py/tests/test_ofplatdata.py") + "tests/test_ofplatdata.py") + ;; This test would require git. + (("\\./tools/patman/patman") (which "true")) + ;; This test would require internet access. + (("\\./tools/buildman/buildman") (which "true"))) + (substitute* "test/py/tests/test_sandbox_exit.py" + (("def test_ctrl_c") + "@pytest.mark.skip(reason='Guix has problems with SIGINT') +def test_ctrl_c")) + (substitute* "tools/binman/binman.py" + (("100%") "99%")) ; TODO: Find out why that is needed. + #t)) (replace 'configure (lambda* (#:key make-flags #:allow-other-keys) (call-with-output-file "configs/tools_defconfig" @@ -395,7 +429,16 @@ also initializes the boards (RAM etc).") "tools/proftool" "tools/fdtgrep" "tools/env/fw_printenv")) - #t)))))) + #t))) + (delete 'check) + (add-after 'install 'check + (lambda* (#:key make-flags test-target #:allow-other-keys) + (apply invoke "make" "mrproper" make-flags) + (setenv "SDL_VIDEODRIVER" "dummy") + (setenv "PAGER" "cat") + (apply invoke "make" test-target make-flags) + (symlink "build-sandbox_spl" "sandbox") + (invoke "test/image/test-imagetools.sh")))))) (description "U-Boot is a bootloader used mostly for ARM boards. It also initializes the boards (RAM etc). This package provides its board-independent tools."))) From debbugs-submit-bounces@debbugs.gnu.org Sat May 26 14:26:30 2018 Received: (at 31520) by debbugs.gnu.org; 26 May 2018 18:26:30 +0000 Received: from localhost ([127.0.0.1]:49886 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fMdte-00015J-Cc for submit@debbugs.gnu.org; Sat, 26 May 2018 14:26:30 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40793) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fMdtc-000156-Kk for 31520@debbugs.gnu.org; Sat, 26 May 2018 14:26:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fMdtW-0004iP-K7 for 31520@debbugs.gnu.org; Sat, 26 May 2018 14:26:23 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37139) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fMdtW-0004iE-HP; Sat, 26 May 2018 14:26:22 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=34182 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fMdtW-0005Hp-5F; Sat, 26 May 2018 14:26:22 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Danny Milosavljevic Subject: Re: [bug#31520] [PATCH] gnu: u-boot-tools: Enable tests. References: <20180518191247.18456-1-dannym@scratchpost.org> Date: Sat, 26 May 2018 20:26:20 +0200 In-Reply-To: <20180518191247.18456-1-dannym@scratchpost.org> (Danny Milosavljevic's message of "Fri, 18 May 2018 21:12:47 +0200") Message-ID: <878t861df7.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31520 Cc: 31520@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Hey Danny, Danny Milosavljevic skribis: > * gnu/packages/bootloaders.scm (dtc)[native-search-paths]: Add PYTHONPATH. > (u-boot-tools)[native-inputs]: Add openssl, python2-coverage, python2-pyt= est, > sdl. > [arguments]<#:make-flags>: Remove NO_SDL. > [arguments]<#:test-target>: Change to "tests". > [arguments]<#:phases>[patch]: New phase. > [arguments]<#:phases>[check]: Replace and move. No need to repeat =E2=80=9C[arguments]=E2=80=9D. > + (native-search-paths > + (list (search-path-specification > + (variable "PYTHONPATH") > + (files '("/lib/python2.7/site-packages"))))) Why is it needed? That would need a comment. :-) Even better if we can achieve the same effect without defining this search path. Also no need for the leading slash in =E2=80=98files=E2=80=99. > + (add-after 'install 'check > + (lambda* (#:key make-flags test-target #:allow-other-keys) > + (apply invoke "make" "mrproper" make-flags) > + (setenv "SDL_VIDEODRIVER" "dummy") > + (setenv "PAGER" "cat") > + (apply invoke "make" test-target make-flags) > + (symlink "build-sandbox_spl" "sandbox") > + (invoke "test/image/test-imagetools.sh")))))) Please return #t. Thanks! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sat May 26 15:16:22 2018 Received: (at 31520) by debbugs.gnu.org; 26 May 2018 19:16:22 +0000 Received: from localhost ([127.0.0.1]:49904 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fMeft-0002CP-SM for submit@debbugs.gnu.org; Sat, 26 May 2018 15:16:22 -0400 Received: from dd26836.kasserver.com ([85.13.145.193]:36430) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fMefr-0002CG-Of for 31520@debbugs.gnu.org; Sat, 26 May 2018 15:16:20 -0400 Received: from localhost (84-113-15-225.cable.dynamic.surfer.at [84.113.15.225]) by dd26836.kasserver.com (Postfix) with ESMTPSA id 56124336123C; Sat, 26 May 2018 21:16:18 +0200 (CEST) Date: Sat, 26 May 2018 21:16:04 +0200 From: Danny Milosavljevic To: ludo@gnu.org (Ludovic =?ISO-8859-1?Q?Court=E8s?=) Subject: Re: [bug#31520] [PATCH] gnu: u-boot-tools: Enable tests. Message-ID: <20180526211604.72c336bf@scratchpost.org> In-Reply-To: <878t861df7.fsf@gnu.org> References: <20180518191247.18456-1-dannym@scratchpost.org> <878t861df7.fsf@gnu.org> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/aGp7nls2nK=uk_ULlzXX__Q"; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 31520 Cc: 31520@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --Sig_/aGp7nls2nK=uk_ULlzXX__Q Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Ludo, On Sat, 26 May 2018 20:26:20 +0200 ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > Why is it needed? That would need a comment. :-) dtc has Python bindings and we build them. The u-boot-tools tests use them (nothing else does). I'll add a comment. > Even better if we > can achieve the same effect without defining this search path. Sure, I guess. If you install dtc into your profile it won't work then tho= ugh. Also, do you think we should try to extract the Python bindings into its own package? > Also no need for the leading slash in =E2=80=98files=E2=80=99. Okay. > > + (add-after 'install 'check > > + (lambda* (#:key make-flags test-target #:allow-other-keys) > > + (apply invoke "make" "mrproper" make-flags) > > + (setenv "SDL_VIDEODRIVER" "dummy") > > + (setenv "PAGER" "cat") > > + (apply invoke "make" test-target make-flags) > > + (symlink "build-sandbox_spl" "sandbox") > > + (invoke "test/image/test-imagetools.sh")))))) =20 >=20 > Please return #t. invoke does :) We can add another one, though. --Sig_/aGp7nls2nK=uk_ULlzXX__Q Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlsJsnQACgkQ5xo1VCww uqVNegf+Popjs2XCAUE7BCQzqDfOssInjtOW4fGnNrjKFbBn+yt8dB5NwDjc2dnH 222vgR4NawFIXpEh0+sskxsQi1yQJRhGlVt9pyy/Ak1a33Sxh419WhpQpWmitLeA 8X/aywckcb1G7L/hux/huw1pavPOXc/7VsJBVCI4EDxWNLTv6In4/U5veJXczOST EQFop8ROTkn2e2Jwd4M4cWh5Qw3XQowy/BRggh8i8Z31Mykpc7Jq0bxuClFOR+Tm odkwxBuWQJGTo0N3lNnwGofvRQgxOBiV2ufpizK5bIuC77EAV5SzqZxY9dI/5a3c AVc9wkXpT3oZX3I53LeaSgt1WjbKPA== =AbRy -----END PGP SIGNATURE----- --Sig_/aGp7nls2nK=uk_ULlzXX__Q-- From debbugs-submit-bounces@debbugs.gnu.org Sun May 27 09:10:15 2018 Received: (at 31520) by debbugs.gnu.org; 27 May 2018 13:10:15 +0000 Received: from localhost ([127.0.0.1]:50228 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fMvR9-0003W9-7B for submit@debbugs.gnu.org; Sun, 27 May 2018 09:10:15 -0400 Received: from eggs.gnu.org ([208.118.235.92]:58624) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fMvR7-0003Vy-UA for 31520@debbugs.gnu.org; Sun, 27 May 2018 09:10:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fMvR1-0003qF-NP for 31520@debbugs.gnu.org; Sun, 27 May 2018 09:10:08 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48753) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fMvR1-0003q3-JL; Sun, 27 May 2018 09:10:07 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=39106 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fMvR1-0005AZ-4T; Sun, 27 May 2018 09:10:07 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Danny Milosavljevic Subject: Re: [bug#31520] [PATCH] gnu: u-boot-tools: Enable tests. References: <20180518191247.18456-1-dannym@scratchpost.org> <878t861df7.fsf@gnu.org> <20180526211604.72c336bf@scratchpost.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 8 Prairial an 226 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sun, 27 May 2018 15:10:05 +0200 In-Reply-To: <20180526211604.72c336bf@scratchpost.org> (Danny Milosavljevic's message of "Sat, 26 May 2018 21:16:04 +0200") Message-ID: <876039xn0y.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31520 Cc: 31520@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Hello Danny! Danny Milosavljevic skribis: > On Sat, 26 May 2018 20:26:20 +0200 > ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > >> Why is it needed? That would need a comment. :-) > > dtc has Python bindings and we build them. But then we do not need a search path definition in dtc itself; the one in Python is enough. Or am I missing something? >> Even better if we >> can achieve the same effect without defining this search path. > > Sure, I guess. If you install dtc into your profile it won't work then t= hough. I think there are two possible situations: 1. dtc provides Python bindings that are useful to Python programmers. This is addressed by having both Python and dtc in the same profile, in which case PYTHONPATH is automatically defined. Nothing special to do. 2. dtc is itself written in Python and needs to access its own Python code. In that case we should wrap the =E2=80=98dtc=E2=80=99 co= mmand such that PYTHONPATH contains the right thing. Does that make sense? > Also, do you think we should try to extract the Python bindings into its = own > package? Not necessarily, it probably doesn=E2=80=99t take up much space. >> > + (add-after 'install 'check >> > + (lambda* (#:key make-flags test-target #:allow-other-key= s) >> > + (apply invoke "make" "mrproper" make-flags) >> > + (setenv "SDL_VIDEODRIVER" "dummy") >> > + (setenv "PAGER" "cat") >> > + (apply invoke "make" test-target make-flags) >> > + (symlink "build-sandbox_spl" "sandbox") >> > + (invoke "test/image/test-imagetools.sh"))))))=20=20 >>=20 >> Please return #t. > > invoke does :) Oh, true, sorry! Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sun May 27 18:06:02 2018 Received: (at 31520) by debbugs.gnu.org; 27 May 2018 22:06:02 +0000 Received: from localhost ([127.0.0.1]:51328 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fN3ne-0006xg-8o for submit@debbugs.gnu.org; Sun, 27 May 2018 18:06:02 -0400 Received: from dd26836.kasserver.com ([85.13.145.193]:33476) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fN3nd-0006xH-2X for 31520@debbugs.gnu.org; Sun, 27 May 2018 18:06:01 -0400 Received: from localhost (84-113-15-225.cable.dynamic.surfer.at [84.113.15.225]) by dd26836.kasserver.com (Postfix) with ESMTPSA id F143933675BF; Mon, 28 May 2018 00:05:59 +0200 (CEST) Date: Mon, 28 May 2018 00:05:45 +0200 From: Danny Milosavljevic To: ludo@gnu.org (Ludovic =?ISO-8859-1?Q?Court=E8s?=) Subject: Re: [bug#31520] [PATCH] gnu: u-boot-tools: Enable tests. Message-ID: <20180528000545.50ceb0ba@scratchpost.org> In-Reply-To: <876039xn0y.fsf@gnu.org> References: <20180518191247.18456-1-dannym@scratchpost.org> <878t861df7.fsf@gnu.org> <20180526211604.72c336bf@scratchpost.org> <876039xn0y.fsf@gnu.org> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/rtqJ76AdsU7bsqEov7c3Eyi"; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 31520 Cc: 31520@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --Sig_/rtqJ76AdsU7bsqEov7c3Eyi Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Ludo, On Sun, 27 May 2018 15:10:05 +0200 ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > > dtc has Python bindings and we build them. =20 >=20 > But then we do not need a search path definition in dtc itself; the one > in Python is enough. Or am I missing something? There's a libfdt.py, provided by the dtc package, and u-boot-tools tests use it. Right now, we're not necessarily installing libfdt.py into python (?) or the profile or anything. Like u-boot-tools has somewhere (in its unit tests): #!/usr/bin/env python3 import pylibfdt And dtc provides libfdt.py which could be useful for Python programmers, too. > 1. dtc provides Python bindings that are useful to Python > programmers. This is addressed by having both Python and dtc in > the same profile, in which case PYTHONPATH is automatically > defined. Nothing special to do. Yes. But in this case u-boot-tools uses libfdt.py when building (testing) = itself. --Sig_/rtqJ76AdsU7bsqEov7c3Eyi Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlsLK7kACgkQ5xo1VCww uqWMKggAjDDkWIFG0wunC60rhExkwbsduBP4301PPAVta3uWlcg6jmne3WnLA9Ra fqsK30YRN8npRZAa2SCuDtUXp6e3LFRoqheS+rng3JV34+nJIUJYNoIHo1ffpNKU uneMaoajCq97ehatJiO+g6IrXg0RsYiWY0HsV28J4XCw7Ei5TNnzI9wPTVuvMjsj b9jyATPAs/h9Ashi/Tlw+l5zTaGXZaW1Io71DSI66PiuX82gu7khj9ljTbBrZpNW jqg+0Nukv//UDqbhmN3NTSOZ8mscnYs/hC38CGX5Z4VQYNXMo+C1aTK2mL//klP/ 8QL1e2DKLd2WDvPfOYVI37d0ibL0Rw== =Kx3W -----END PGP SIGNATURE----- --Sig_/rtqJ76AdsU7bsqEov7c3Eyi-- From debbugs-submit-bounces@debbugs.gnu.org Mon May 28 03:57:49 2018 Received: (at 31520) by debbugs.gnu.org; 28 May 2018 07:57:49 +0000 Received: from localhost ([127.0.0.1]:51545 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fND2L-0005zE-DM for submit@debbugs.gnu.org; Mon, 28 May 2018 03:57:49 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52019) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fND2J-0005z2-QM for 31520@debbugs.gnu.org; Mon, 28 May 2018 03:57:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fND2B-0007Kj-Mu for 31520@debbugs.gnu.org; Mon, 28 May 2018 03:57:42 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33806) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fND2B-0007Kc-J9; Mon, 28 May 2018 03:57:39 -0400 Received: from [193.50.110.236] (port=50850 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fND2A-0007YC-QD; Mon, 28 May 2018 03:57:39 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Danny Milosavljevic Subject: Re: [bug#31520] [PATCH] gnu: u-boot-tools: Enable tests. References: <20180518191247.18456-1-dannym@scratchpost.org> <878t861df7.fsf@gnu.org> <20180526211604.72c336bf@scratchpost.org> <876039xn0y.fsf@gnu.org> <20180528000545.50ceb0ba@scratchpost.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 9 Prairial an 226 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 28 May 2018 09:57:37 +0200 In-Reply-To: <20180528000545.50ceb0ba@scratchpost.org> (Danny Milosavljevic's message of "Mon, 28 May 2018 00:05:45 +0200") Message-ID: <874lis43gu.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31520 Cc: 31520@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Morning! Danny Milosavljevic skribis: > On Sun, 27 May 2018 15:10:05 +0200 > ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > >> > dtc has Python bindings and we build them.=20=20 >>=20 >> But then we do not need a search path definition in dtc itself; the one >> in Python is enough. Or am I missing something? > > There's a libfdt.py, provided by the dtc package, and u-boot-tools > tests use it. OK. If u-boot-tools has both Python and dtc as inputs, then PYTHONPATH is correctly defined, isn=E2=80=99t it? > Right now, we're not necessarily installing libfdt.py into python (?) or = the > profile or anything. So we should make sure dtc installs libfdt.py in $prefix/lib/python2.7/=E2= =80=A6. Does that make sense? Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon May 28 17:52:26 2018 Received: (at 31520-done) by debbugs.gnu.org; 28 May 2018 21:52:26 +0000 Received: from localhost ([127.0.0.1]:52833 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fNQ42-0004fW-J4 for submit@debbugs.gnu.org; Mon, 28 May 2018 17:52:26 -0400 Received: from dd26836.kasserver.com ([85.13.145.193]:50500) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fNQ40-0004fN-Kt for 31520-done@debbugs.gnu.org; Mon, 28 May 2018 17:52:25 -0400 Received: from localhost (84-113-15-225.cable.dynamic.surfer.at [84.113.15.225]) by dd26836.kasserver.com (Postfix) with ESMTPSA id 30E0E3360129; Mon, 28 May 2018 23:52:23 +0200 (CEST) Date: Mon, 28 May 2018 23:52:21 +0200 From: Danny Milosavljevic To: ludo@gnu.org (Ludovic =?ISO-8859-1?Q?Court=E8s?=) Subject: Re: [bug#31520] [PATCH] gnu: u-boot-tools: Enable tests. Message-ID: <20180528235221.55ae2b83@scratchpost.org> In-Reply-To: <874lis43gu.fsf@gnu.org> References: <20180518191247.18456-1-dannym@scratchpost.org> <878t861df7.fsf@gnu.org> <20180526211604.72c336bf@scratchpost.org> <876039xn0y.fsf@gnu.org> <20180528000545.50ceb0ba@scratchpost.org> <874lis43gu.fsf@gnu.org> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/rw6wsvA_WRRCcolkXXr6uev"; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 31520-done Cc: 31520-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --Sig_/rw6wsvA_WRRCcolkXXr6uev Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Ludo, On Mon, 28 May 2018 09:57:37 +0200 ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > OK. If u-boot-tools has both Python and dtc as inputs, then PYTHONPATH > is correctly defined, isn=E2=80=99t it? Hmm, then I don't understand how native-search-paths works. I thought native-search-paths would just add $package/$path for the current package--but it seems guix uses it as a pattern in all packages, not just the package that specified it. It indeed works if I remove native-search-paths from dtc, so I've pushed it without. --Sig_/rw6wsvA_WRRCcolkXXr6uev Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlsMehUACgkQ5xo1VCww uqXJmQf5Af0tBSXx4Cm6kDFxUPFh5QGi1CxUPLjjmhkBDRFq0bZ1jz0jfYJoAU4/ AU9aBIxmFzE88qMERHyir6aq7G1MnrxEZiFsU6FStibmz0I4K1JTF9dA7Xqt9n8H cu6qbTLFKZ4+7SpiD3nZj33o3rBfzRdnlzSTk+1Fbq2X7CBJ7FloBAByTTvwa5W5 lUCwfQn3oRQjThogtQ4IfPihVZcl4FpN2MnHiOVYOr8hKjnaQg31xZqI7HL/t+/9 7yChrguFVgC5bAYC3/UyH/2Wth9+ZjEL9RvYoXInzgM4EQTf/8qIVt1ybrg3kOGR BO/ge5F8SaCplBni88sRCdzJOJJ26Q== =Bb3r -----END PGP SIGNATURE----- --Sig_/rw6wsvA_WRRCcolkXXr6uev-- From debbugs-submit-bounces@debbugs.gnu.org Tue May 29 10:34:05 2018 Received: (at 31520-done) by debbugs.gnu.org; 29 May 2018 14:34:05 +0000 Received: from localhost ([127.0.0.1]:54131 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fNfhN-0006lg-Jz for submit@debbugs.gnu.org; Tue, 29 May 2018 10:34:05 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46658) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fNfhL-0006lC-OQ for 31520-done@debbugs.gnu.org; Tue, 29 May 2018 10:34:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fNfhF-0000ON-Sw for 31520-done@debbugs.gnu.org; Tue, 29 May 2018 10:33:58 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:32974) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fNfhF-0000OD-Px; Tue, 29 May 2018 10:33:57 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=46758 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fNfhF-0003M3-DD; Tue, 29 May 2018 10:33:57 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Danny Milosavljevic Subject: Re: [bug#31520] [PATCH] gnu: u-boot-tools: Enable tests. References: <20180518191247.18456-1-dannym@scratchpost.org> <878t861df7.fsf@gnu.org> <20180526211604.72c336bf@scratchpost.org> <876039xn0y.fsf@gnu.org> <20180528000545.50ceb0ba@scratchpost.org> <874lis43gu.fsf@gnu.org> <20180528235221.55ae2b83@scratchpost.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 10 Prairial an 226 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 29 May 2018 16:33:55 +0200 In-Reply-To: <20180528235221.55ae2b83@scratchpost.org> (Danny Milosavljevic's message of "Mon, 28 May 2018 23:52:21 +0200") Message-ID: <87zi0iy1ik.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31520-done Cc: 31520-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Hello, Danny Milosavljevic skribis: > Hmm, then I don't understand how native-search-paths works. The search path spec is attached to the package that =E2=80=9Cowns=E2=80=9D= the given variables. So python has a spec for PYTHONPATH, Guile has a spec for GUILE_LOAD_PATH, and so on. Then, if you have both python and a python package in the same profile, the machinery automatically defines PYTHONPATH according to the spec. > It indeed works if I remove native-search-paths from dtc, so I've pushed = it > without. Cool, thanks! Ludo=E2=80=99. From unknown Sat Sep 20 02:11:01 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 27 Jun 2018 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator