Subject: [bug#31514] [PATCH 09/21] gnu: Add emacs-gif-screencast.

From: [email-masked] (Ludovic Courtès)
Date: Sat, 02 Jun 2018 22:41:25 +0200

Pierre Neidhardt <[email-masked]> skribis:

> Ludovic Courtès <[email-masked]> writes:
>
>> Pierre Neidhardt <[email-masked]> skribis:
>>
>>> * gnu/packages/emacs.scm (emacs-gif-screencast): New variable.
>>
>> [...]
>>
>>> +  (package
>>> +    (name "emacs-gif-screencast")
>>> +    (version "20180309")
>>> +    (source
>>> +     (origin
>>> +       (method url-fetch)
>>> +       (uri (string-append
>>> +             "https://github.com/Ambrevar/emacs-gif-screencast/archive/"
>>> +             "825e606950ec842304bf75cf85baef707b853b03"
>>> +             ".tar.gz"))
>>
>> Could you use the usual scheme for version numbers of Git snapshots
>> (info "(guix) Version Numbers")?
>
> I followed the form of emacs-zotxt that was just packaged.
> emacs-gif-screencast, like many other Emacs packages, has no version
> number.
> Do you suggest something like
>
> (let ((commit ...))
>   ; ...
> 	(gitversion "20180309" "1" commit)
>
> ?

Yes.  I think it’s useful to have the shortened commit ID in the version
string.

Thanks,
Ludo’.