Subject: Re: [bug#31514] [PATCH 09/21] gnu: Add emacs-gif-screencast.

From: [email-masked] (Ludovic Courtès)
Date: Sat, 02 Jun 2018 16:02:21 +0200

Pierre Neidhardt <[email-masked]> skribis:

> * gnu/packages/emacs.scm (emacs-gif-screencast): New variable.

[...]

> +  (package
> +    (name "emacs-gif-screencast")
> +    (version "20180309")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "https://github.com/Ambrevar/emacs-gif-screencast/archive/"
> +             "825e606950ec842304bf75cf85baef707b853b03"
> +             ".tar.gz"))

Could you use the usual scheme for version numbers of Git snapshots
(info "(guix) Version Numbers")?

> +    (propagated-inputs
> +     `(("scrot" ,scrot)
> +       ("imagemagick" ,imagemagick)
> +       ("gifsicle" ,gifsicle)))

Instead of propagating these, which could “pollute” the user’s profile,
could you hardcode the absolute file names of these programs in the .el
files?  See how this is done for EMMS, for instance.

> +    (home-page
> +     "https://github.com/Ambrevar/emacs-gif-screencast")
> +    (synopsis "One-frame-per-action GIF recording")

This looks very useful!

TIA!

Ludo’.