GNU bug report logs - #31509
[PATCH 03/21] gnu: emacs-evil-ediff: New variable.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 31509 in the body.
You can then email your comments to 31509 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <ambrevar <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH 03/21] gnu: emacs-evil-ediff: New variable.
Date: Fri, 18 May 2018 20:49:00 +0200

* gnu/packages/emacs.scm (emacs-evil-ediff): New variable.
---
 gnu/packages/emacs.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index b84c58e2e..fd2fc54fc 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -10515,3 +10515,27 @@ Unless you're using @code{use-package}'s hook keyword, you can enable the
 autosuggestions with:
 @code{(add-hook 'eshell-mode-hook #'esh-autosuggest-mode)}")
     (license license:gpl3+)))
+
+(define-public emacs-evil-ediff
+  (package
+    (name "emacs-evil-ediff")
+    (version "20170724.1223")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://melpa.org/packages/evil-ediff-"
+             version
+             ".el"))
+       (sha256
+        (base32
+         "1sinr8r8iiimacr2szpz8ln32ngjar7ix8pvaiiz05i8g2xy7d57"))))
+    (build-system emacs-build-system)
+    (propagated-inputs `(("emacs-evil" ,emacs-evil)))
+    (home-page "https://github.com/emacs-evil/evil-ediff")
+    (synopsis "Make ediff a little evil")
+    (description
+     "Make ediff a little evil.  This configures ediff to be friendlier to
+users of vim-like keybindings.  Consult the help buffer for more
+information.")
+    (license license:gpl3+)))
-- 
2.17.0

Message #10 received at 31509-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Pierre Neidhardt <ambrevar <at> gmail.com>
Cc: 31509-done <at> debbugs.gnu.org
Subject: Re: [bug#31509] [PATCH 03/21] gnu: emacs-evil-ediff: New variable.
Date: Thu, 31 May 2018 17:47:21 +0200

Pierre Neidhardt <ambrevar <at> gmail.com> skribis:

> * gnu/packages/emacs.scm (emacs-evil-ediff): New variable.

Applied, thanks!

Message #15 received at 31509 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Pierre Neidhardt <ambrevar <at> gmail.com>
Cc: 31509 <at> debbugs.gnu.org
Subject: Re: [bug#31509] [PATCH 03/21] gnu: emacs-evil-ediff: New variable.
Date: Thu, 31 May 2018 17:53:44 +0200

Pierre Neidhardt <ambrevar <at> gmail.com> skribis:

> * gnu/packages/emacs.scm (emacs-evil-ediff): New variable.

Actually we’re not done.   :-/

> +       (uri (string-append
> +             "https://melpa.org/packages/evil-ediff-"
> +             version
> +             ".el"))

We cannot use melpa.org URLs because they are highly volatile.  For
instance, the URL for evil-magit.el in the patch that you sent is
already 404.

That’s why we instead refer to upstream URLs (on GitHub or other hosting
sites.)

Could you resent this series with such URLs?  I understand it’s
cumbersome but it’s really important if we want to be able to build
these things even just a couple of weeks from now.

(Please send each updated patch to the right NNN <at> debbugs.gnu.org
address.)

Thanks in advance,
Ludo’.

Message #18 received at 31509 <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <ambrevar <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 31509 <at> debbugs.gnu.org
Subject: Re: [bug#31509] [PATCH 03/21] gnu: emacs-evil-ediff: New variable.
Date: Thu, 31 May 2018 17:57:00 +0200

[Message part 1 (text/plain, inline)]

Indeed...

But then we should urgently modify `guix import elpa` accordingly ;)

I'll resubmit the patches as soon as possible.

-- 
Pierre Neidhardt

[signature.asc (application/pgp-signature, inline)]

Message #21 received at 31509 <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <ambrevar <at> gmail.com>
To: 31509 <at> debbugs.gnu.org
Subject: [PATCH 03/21] gnu: Add emacs-evil-ediff.
Date: Fri,  1 Jun 2018 09:44:06 +0200

* gnu/packages/emacs.scm (emacs-evil-ediff): New variable.
---
 gnu/packages/emacs.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 90b7fb2ca..0c2081c90 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -10600,3 +10600,27 @@ This code is still alpha.")
 and the Zotero research assistant: Insertion of links to Zotero items into an
 Org-mode file, and citations of Zotero items in Pandoc Markdown files.")
     (license license:gpl3+)))
+
+(define-public emacs-evil-ediff
+  (package
+    (name "emacs-evil-ediff")
+    (version "20170724")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://github.com/emacs-evil/evil-ediff/archive/"
+             "67b0e69f65c196eff5b39dacb7a9ec05bb919c74"
+             ".tar.gz"))
+       (sha256
+        (base32
+         "0j2x26zfc6md54mjf76qpybil4yal70lp5bifcz62l1f8fc1vvlq"))))
+    (build-system emacs-build-system)
+    (propagated-inputs `(("emacs-evil" ,emacs-evil)))
+    (home-page "https://github.com/emacs-evil/evil-ediff")
+    (synopsis "Make Ediff a little evil")
+    (description
+     "Make Ediff a little evil.  This configures Ediff to be friendlier to
+users of Vim-like keybindings.  Consult the help buffer for more
+information.")
+    (license license:gpl3+)))
-- 
2.17.0

Message #24 received at 31509 <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <ambrevar <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 31509 <at> debbugs.gnu.org
Subject: Re: [bug#31509] [PATCH 03/21] gnu: emacs-evil-ediff: New variable.
Date: Fri, 01 Jun 2018 09:59:33 +0200

[Message part 1 (text/plain, inline)]

I've sent all updated patches to their respective NNN <at> debbugs.gnu.org.

Sorry for the mess :(
(And I hope I didn't make it any worse.)

-- 
Pierre Neidhardt

[signature.asc (application/pgp-signature, inline)]

Message #27 received at 31509 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Pierre Neidhardt <ambrevar <at> gmail.com>
Cc: 31509 <at> debbugs.gnu.org
Subject: Re: [bug#31509] [PATCH 03/21] gnu: emacs-evil-ediff: New variable.
Date: Fri, 01 Jun 2018 14:13:55 +0200

Pierre Neidhardt <ambrevar <at> gmail.com> skribis:

> Indeed...
>
> But then we should urgently modify `guix import elpa` accordingly ;)

Unfortunately I don’t think the “real” upstream URLs can be
automatically inferred.

Ludo’.

Message #30 received at 31509 <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <ambrevar <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 31509 <at> debbugs.gnu.org
Subject: Re: [bug#31509] [PATCH 03/21] gnu: emacs-evil-ediff: New variable.
Date: Fri, 01 Jun 2018 15:52:09 +0200

[Message part 1 (text/plain, inline)]

I haven't looked into the details, but why not?
I think all MELPA packages have an upstream URL.

-- 
Pierre Neidhardt

[signature.asc (application/pgp-signature, inline)]

Message #35 received at 31509-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Pierre Neidhardt <ambrevar <at> gmail.com>
Cc: 31509-done <at> debbugs.gnu.org
Subject: Re: [bug#31509] [PATCH 03/21] gnu: Add emacs-evil-ediff.
Date: Sat, 02 Jun 2018 15:47:09 +0200

Pierre Neidhardt <ambrevar <at> gmail.com> skribis:

> * gnu/packages/emacs.scm (emacs-evil-ediff): New variable.

Applied, thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.