From unknown Sat Sep 20 00:09:08 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#31498 <31498@debbugs.gnu.org> To: bug#31498 <31498@debbugs.gnu.org> Subject: Status: [PATCH] Notify systemd in daemon-initialized Reply-To: bug#31498 <31498@debbugs.gnu.org> Date: Sat, 20 Sep 2025 07:09:08 +0000 retitle 31498 [PATCH] Notify systemd in daemon-initialized reassign 31498 emacs submitter 31498 Lucas Werkmeister severity 31498 wishlist tag 31498 patch fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Fri May 18 13:45:35 2018 Received: (at submit) by debbugs.gnu.org; 18 May 2018 17:45:35 +0000 Received: from localhost ([127.0.0.1]:40061 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fJjRe-0008L7-O8 for submit@debbugs.gnu.org; Fri, 18 May 2018 13:45:34 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49153) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fJjN2-0008CH-EE for submit@debbugs.gnu.org; Fri, 18 May 2018 13:40:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fJjMw-0000m9-8M for submit@debbugs.gnu.org; Fri, 18 May 2018 13:40:43 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:48798) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fJjMw-0000m3-4T for submit@debbugs.gnu.org; Fri, 18 May 2018 13:40:42 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40114) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fJjMu-00029o-RS for bug-gnu-emacs@gnu.org; Fri, 18 May 2018 13:40:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fJjMr-0000kd-Q7 for bug-gnu-emacs@gnu.org; Fri, 18 May 2018 13:40:40 -0400 Received: from lucaswerkmeister.de ([94.130.58.99]:38978) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fJjMr-0000jp-Ft for bug-gnu-emacs@gnu.org; Fri, 18 May 2018 13:40:37 -0400 Received: from theoden.lucaswerkmeister.de.home (unknown [IPv6:2a02:8109:92c0:22bb:d412:2b0:339e:ab21]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mail@lucaswerkmeister.de) by lucaswerkmeister.de (Postfix) with ESMTPSA id 27F8836DA42; Fri, 18 May 2018 19:40:34 +0200 (CEST) Authentication-Results: lucaswerkmeister.de; dmarc=fail (p=none dis=none) header.from=lucaswerkmeister.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lucaswerkmeister.de; s=mail; t=1526665235; bh=kzRtrRer8hA/nmXllpPgtF31472OPliC85QiUBv8nA0=; h=From:To:Cc:Subject:Date:Message-Id:From:Reply-To:Subject:Date:To: Cc:In-Reply-To:References:Message-Id:Sender:Content-Type: Content-Transfer-Encoding:Content-Disposition:Mime-Version; b=hX5fA68B6i35ri8S/El4dFpm/RkrJSpN2Bt2gZDkv0W3YJzt/7gTkEO5oCKP4PiGA dKgAGJlnU1WqmFvRjIbPFW0YhPr5wzCncGFNW54dIzDdqtbG7Ha4hvC7oPY387v6FT QfCU9iJwCUeoGYgFkT+xmZDsMpZqGXlm/ObK0Fr4= From: Lucas Werkmeister To: bug-gnu-emacs@gnu.org Subject: [PATCH] Notify systemd in daemon-initialized Date: Fri, 18 May 2018 19:40:31 +0200 Message-Id: <20180518174031.12514-1-mail@lucaswerkmeister.de> X-Mailer: git-send-email 2.17.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Fri, 18 May 2018 13:45:33 -0400 Cc: Lucas Werkmeister X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.1 (-----) With --[bg-]daemon and Type=forking, systemd will only consider the daemon to have fully started up once the original process exits, and will wait until then to start units depending on the Emacs service. To get the same functionality with --fg-daemon, use Type=notify instead of Type=simple and explicitly send a readiness notification to systemd at the point where the forked process would in --bg-daemon mode notify its parent process and cause it to exit. * etc/emacs.service: update Type * src/emacs.c (daemon-initialized): call sd_notify() --- etc/emacs.service | 2 +- src/emacs.c | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/etc/emacs.service b/etc/emacs.service index b29177b120..dbcb6bc301 100644 --- a/etc/emacs.service +++ b/etc/emacs.service @@ -7,7 +7,7 @@ Description=Emacs text editor Documentation=info:emacs man:emacs(1) https://gnu.org/software/emacs/ [Service] -Type=simple +Type=notify ExecStart=emacs --fg-daemon ExecStop=emacsclient --eval "(kill-emacs)" Environment=SSH_AUTH_SOCK=%t/keyring/ssh diff --git a/src/emacs.c b/src/emacs.c index f25e612664..8718b301a4 100644 --- a/src/emacs.c +++ b/src/emacs.c @@ -2477,6 +2477,13 @@ from the parent process and its tty file descriptors. */) error ("This function can only be called after loading the init files"); #ifndef WINDOWSNT + if (daemon_type == 1) + { +#ifdef HAVE_LIBSYSTEMD + sd_notify(0, "READY=1"); +#endif /* HAVE_LIBSYSTEMD */ + } + if (daemon_type == 2) { int nfd; -- 2.17.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 07 09:09:03 2018 Received: (at 31498) by debbugs.gnu.org; 7 Jun 2018 13:09:03 +0000 Received: from localhost ([127.0.0.1]:37551 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fQuf0-00028s-Vv for submit@debbugs.gnu.org; Thu, 07 Jun 2018 09:09:03 -0400 Received: from mail-it0-f68.google.com ([209.85.214.68]:54093) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fQuez-00028I-44; Thu, 07 Jun 2018 09:09:01 -0400 Received: by mail-it0-f68.google.com with SMTP id a195-v6so12730856itd.3; Thu, 07 Jun 2018 06:09:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=XcUqqe0gRfqcWdqcf0J9sIIEMhELgy23N/ghRuwy8fE=; b=cxBTd+C6kQm3OhrzoiA7tEc3eyYCRe9FjqiBDLbHHkzS6PqYBWZ4Lo21ERHxJQ0h89 h0P8FZLG5bE+/ohA8RCmAklbBt3di3TeW67aSXo7X3lLX16qdR0UalFnN01hCUBfhtR3 hMlPs2H4LODNrcH9m8du668PWb8wh4+8j9qoiloyOLC2xPtEQKx20hsIt+HO8TuZaJVz HL69teePG7N3KiSuJ4XD19soIjgyMBVeiOecWKBUFdxNDIsXGoMHQvRSSnBW/haJT8D3 8tkSWLgAe2t2bdzDUdFX3Nd21EdnDh8r18jgo6sbYWaXkXC6tx8wdGRPFws9lr9KeTym GWUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=XcUqqe0gRfqcWdqcf0J9sIIEMhELgy23N/ghRuwy8fE=; b=ZRwvMKNVReYXJX3L7hP4qPJKhz6c9V0p74dlbcFY/iKBq4LpNC12TjqvRlHWDgayh5 +Y3NZcPUsT4NlMhC93cOgwppTMfxDVCuWBXBlZyF9EclKqSzd3d0M0jlQqbC2iruQUfw GtYSW2bIM9AfyyoH7SA8PbrXaw6B9oc1kemm8vY7sRaLR8HkCWf68vCEZmp5rB3LnlKz 54rkflztuvTMjbTTnGAgxzFiFSXKSSdVR9gOr8giwb4downKxpYcGMp+HnEoPZ3X/4Ap VWTvKwBz6+2pMSTfzwkqv3b2TQBHpzHqQ9H6k8ZV4IsGC/09YcYhxo1Sj/ovZ8yuroGf LOPg== X-Gm-Message-State: APt69E396W4n4HKl/T+Ku5QsaKZvtC3WXqJbXM71r91Ohp2g1sa+VVD1 sCBFwboYOhtClwtNjAvxVyKMAA== X-Google-Smtp-Source: ADUXVKIjBeZgsvKsvIqWexe7haBRMVeCxbcxirUV6K+wZaqblqpuASRax8SOeXgffh+2DOxS/3AtoQ== X-Received: by 2002:a24:d651:: with SMTP id o78-v6mr1727963itg.94.1528376935530; Thu, 07 Jun 2018 06:08:55 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id z6-v6sm4818648iob.15.2018.06.07.06.08.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 07 Jun 2018 06:08:54 -0700 (PDT) From: Noam Postavsky To: Lucas Werkmeister Subject: Re: bug#31498: [PATCH] Notify systemd in daemon-initialized References: <20180518174031.12514-1-mail@lucaswerkmeister.de> Date: Thu, 07 Jun 2018 09:08:51 -0400 In-Reply-To: <20180518174031.12514-1-mail@lucaswerkmeister.de> (Lucas Werkmeister's message of "Fri, 18 May 2018 19:40:31 +0200") Message-ID: <87bmcm3frw.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 31498 Cc: 31498@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) severity 31498 wishlist severity 31521 wishlist quit Thanks, the patch seems straightforward enough. Just a few minor comments about formatting. Have you assigned copyright for Emacs? The patch is small enough to go in anyway, it would just have to be marked. Lucas Werkmeister writes: > With --[bg-]daemon and Type=forking, systemd will only consider the > daemon to have fully started up once the original process exits, and > will wait until then to start units depending on the Emacs service. To ^ double space > get the same functionality with --fg-daemon, use Type=notify instead of > Type=simple and explicitly send a readiness notification to systemd at > the point where the forked process would in --bg-daemon mode notify its > parent process and cause it to exit. > * etc/emacs.service: update Type The ChangeLog entries should be captilalized and end with a period: "Update Type." > * src/emacs.c (daemon-initialized): call sd_notify() Same here. I think it should have a NEWS entry mentioning that Emacs now supports this systemd notification feature. I would probably go ahead and combine with #31521, since it's using the same feature. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 07 11:38:25 2018 Received: (at 31498) by debbugs.gnu.org; 7 Jun 2018 15:38:25 +0000 Received: from localhost ([127.0.0.1]:38338 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fQwzY-0007jt-Qx for submit@debbugs.gnu.org; Thu, 07 Jun 2018 11:38:25 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44129) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fQwzX-0007jh-E5 for 31498@debbugs.gnu.org; Thu, 07 Jun 2018 11:38:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fQwzP-0003js-7I for 31498@debbugs.gnu.org; Thu, 07 Jun 2018 11:38:18 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56924) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fQwzP-0003jk-43; Thu, 07 Jun 2018 11:38:15 -0400 Received: from [176.228.60.248] (port=3776 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fQwzN-0004sz-RF; Thu, 07 Jun 2018 11:38:14 -0400 Date: Thu, 07 Jun 2018 18:38:12 +0300 Message-Id: <83a7s6wqsb.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky In-reply-to: <87bmcm3frw.fsf@gmail.com> (message from Noam Postavsky on Thu, 07 Jun 2018 09:08:51 -0400) Subject: Re: bug#31498: [PATCH] Notify systemd in daemon-initialized References: <20180518174031.12514-1-mail@lucaswerkmeister.de> <87bmcm3frw.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31498 Cc: 31498@debbugs.gnu.org, mail@lucaswerkmeister.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Noam Postavsky > Date: Thu, 07 Jun 2018 09:08:51 -0400 > Cc: 31498@debbugs.gnu.org > > Have you assigned copyright for Emacs? I don't see an assignment for Lucas Werkmeister on file. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 07 17:39:55 2018 Received: (at 31498) by debbugs.gnu.org; 7 Jun 2018 21:39:55 +0000 Received: from localhost ([127.0.0.1]:38472 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fR2dP-0007Iu-3O for submit@debbugs.gnu.org; Thu, 07 Jun 2018 17:39:55 -0400 Received: from lucaswerkmeister.de ([94.130.58.99]:35426) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fR2dM-0007Ik-W2 for 31498@debbugs.gnu.org; Thu, 07 Jun 2018 17:39:53 -0400 Received: from theoden.lucaswerkmeister.de (unknown [IPv6:2a02:8109:92c0:22bb:d412:2b0:339e:ab21]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mail@lucaswerkmeister.de) by lucaswerkmeister.de (Postfix) with ESMTPSA id 9F5B9396855; Thu, 7 Jun 2018 23:39:51 +0200 (CEST) Authentication-Results: lucaswerkmeister.de; dmarc=fail (p=none dis=none) header.from=lucaswerkmeister.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lucaswerkmeister.de; s=mail; t=1528407591; bh=Z8h45/kaJDXiFJvpploQri7Ex/p+YP4O4Ypa2fEToUM=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type:Content-Transfer-Encoding:From:Reply-To: Subject:Date:To:Cc:In-Reply-To:References:Message-Id:Sender: Content-Type:Content-Transfer-Encoding:Content-Disposition: Mime-Version; b=He2j3BRW+CUmhp6G4NPCmlIU7gvaTl8pRjo/p9gcFOVei5WSrXylQvf+zhhZ6HXNR C4wVj7j0s6UcWBuGuIT3UJGhIwCIli1c+9osbkr6j9DTx0QB2XL5qSUs3ngKK4Chzu P0LIL9sbQyo7pqkkdXJyTiuB3RgWQaxuN4h14tA8= Subject: Re: bug#31498: [PATCH] Notify systemd in daemon-initialized To: Noam Postavsky References: <20180518174031.12514-1-mail@lucaswerkmeister.de> <87bmcm3frw.fsf@gmail.com> From: Lucas Werkmeister Openpgp: preference=signencrypt Autocrypt: addr=mail@lucaswerkmeister.de; prefer-encrypt=mutual; keydata= xsFNBFKkO1oBEACXP/JGIJsKiXsA866Ak439ZIaU5xNss6V2QoOQBSj6848kkxhDLEbfgVYW 4meXYpYJV9P2Vk0PC2kQWadqbvqhfP7OomlIlZzlpvbi2xbjW4tr09brY7d7GvMcplh5igYS gWo5J/6+4ZDgVj+TG0OuvkTDZmJmHhrwDuIsvh3KDJhT0z6t43qzQ69Efse/OjJRpWha5nZt fvtdBCI/v2Pq6pJrPx1g1u/BKArRcrrWLpCRQRbFwrQ1MsIkj8Wzz1tKjulGUSPIXvvssxYA /3BQEniMKzxbkZlhi4DUe5WJZWFS6BWaS+Qbwd0bq2WaCD/PFddjHN6qWAxxPY2rvP7C+Lj7 FQiHLbeMi2K0hiMEsUUsORq/A0LjG84RSwhic2a6cvszj9b6WRmRUb1PMMxcNCjCzebkdZeL RWrqhCnMU+rxQJ+qib5rbYCjvpV2hWzlXcvjaW2B32jUAhG3sDK6Cd4A+Ao7gJPv1KzdvqZj Aoo5/5RI1Er5EYkhcjGAc0N/VWnOq5WDuL4CdeamIwMyOlI42npbzKsHhlb5nXPeFl7eEOdZ RVKs3yuE3/23XpWisjKUk9tUpGBHi098rPPnbA4T9P7ZwWNwo8j4Bh8D71nC+JJ1ue92NzSi T9E7ckdSIatPl5rJIEjvf9pZB4YUugGM06JdlYakVVZZHLXFgQARAQABzSxMdWNhcyBXZXJr bWVpc3RlciA8bWFpbEBsdWNhc3dlcmttZWlzdGVyLmRlPsLBmAQTAQoAQgIbAwYLCQgHAwIG FQgCCQoLBBYCAwECHgECF4ACGQEWIQRriVuLEaR1seyTFpj8Rihycq4yPwUCWK8aSwUJGNbh 8QAKCRD8Rihycq4yP/FSD/45wEQTFrMYzti+9B4/4c4GpGajT2HEw5YxKL/Gcifu3mwMrQLn uxbCtuuBLtmOt1W13c+MBFVu2fals6fABlTev7Ikh7NSu6APA3XBpgk/ckJHwOaPPRGp8GDD N3UmDBOXd/mzWK2Zz+m1iU0xpcd4Td34TkOa/qYFqCmY5SZILFRzpgZ9QNZEBQBOGwwvvnax rIKVpH5Vgghp9WBDtElOM9cFH8uq1IOXob/nRsxwAC1kEB04uMneA+Xm4T7KhJ+0QKCNe54s BxK6SI54mEpy8cfyVr3oopM8uDcj014ebxsbrvQmcC8AI8ptt+BwgCl4kO033qhc0ll5kRXB EDtbvTDVf6OafLNECaWxxWnYadxVLOfbTaHMjdGyqA7GLmOL+Wcb/uZpW1sFnpMSAeGTBvap jXmjxNleJThHviD/WqR218yZevvWcA1XvgAObYwGiNF8KbOzKw8oUUp/nzMZYL0JN85gUDDa ef28x/2spQEtDs9zlTZxioHogVNVOzGlt+7Sm23RzE0aU/f14nahI2g8/179e5B4Nv10lO8d 8ZiQ663n42ODZju5iqVYvIkBlqVYliGxd7dgJLX9D5Qo65a62BhKuLQclyYBVVuoe4+HsUET wfshMFAAnGPWbWM6ZY96+XQ1tnyWKKTaosGJ1XwNwuZA31rCwruWtW2JxM7BTQRSpDtaARAA 6s6WSxIWC4NuNiYSUTIaqOTkYnv2w9ME/3WF/o/F50eBY5ko+5tll7dLQDH1SKtReqFc2ZnY AIXkFSAkbweu+7VxEcosPKP67xUGJyCAGikCgW7uVFSsnVyOPSpt4GixQjq6p4NxOMGpnxCk cy9pTwBudMwSE1j/NF0SVDFYChKo9OR5eyetHuHzglGdBjE/izu//gMY5JOgZEfz4MqDL8Vw ypK+w1qTI7t7rQAme1Ia+7shxv5+gCJMH/IJL4RL8lQ2uEFbUpJ6KiJhpAhf4CrMTPkZxxs2 x3mfcUDW7YZW9r8n2iUrVkzVHCEvbN7PRREf3LeiBF8eZKM5GcimtMgriit9Vv6DbpK8r9/2 QJeGyblN9kk97GLQ2IG0PzrpLcn1/0aTJcwqFvA3phG2baY2M0FMdvJW1G9EjJsQAvwvCFAs m7v4xxzmyADnPJjqWCe0EqOBuoYrjEOf8Hd7LsnoSHdsIuIQiyY3SQ9Et6d/lTiUFYcwAtXI 0xhDEcBKjp5mBo19OBPKR0HvlhEMwyikoUkTl4Hf3ZVa2ohNZ3g8xE0oDFaBwnSW/GYtLBqd uOhk8yoWyGN7gIv7Bgquwq1uCE2UtBI9kYCM9Oscp/Zu8pmYe44p/8SpCPA5G7Vsjmf4ax2S +Fazd1lvIKgRIu4QozBMhlMOgpQsErDpwD0AEQEAAcLBXwQYAQIACQUCUqQ7WgIbDAAKCRD8 Rihycq4yP/QeEACDfzBFA2RBpAEuuJm89v53NA5vfmuy2LZxnwez+tc1/PjRdyZAU+/GcYd5 QGLcTfDkrrLqbCWrQ09044ObCJeY8gdF4wFTGP1kpCHeLBrS5ZKLUoBQNbbBG+vJn6iDcpJV qHwG+3HoC79cj0g2Bi09x/c8F5Zg1m4gcnZFfwRSxIyUk+TI2IAZUO2F6k6u4g1+ZFHxOLNp jjbEMV/BgVRhWV3M6cwtF7SFZ69raSZNPemHyhQ3XjCZ04czvHyLILYMwWAt/v7MID2pusEr NyMa/CLDadQbRaABeXqW6O6X6JycFbRFtR8997BFcaGGb8OcYvgTDG6puAhsVZi6I71JhEJ9 psCFBaoIG91ZVdb+bnVrFMuyvVJXjblSeBLwv5CCr4RpLpZq/yjxiclQ3IXVRCqp6kNR5dit Gl8pI8b0TZNjorq5/t/J/ALCu0nD3gyuK/DyUyA1vILCX6Gqhp3Ng1t2gBJI5sq3ZZrcYLhs mlNgF7uByLe1oqWuHRrL+MxP5+x7xyVlQRgr8bPfec7uS0a/Ip/NaYao9EKRq1Xr6k6R5cSB aZVxGTIY2539GttvdFSue6TaGT9irKqKdtK0rT6Hr+u2rm2ppuayv+vs9TaTNDovnG9J0Dco ZyF1BmKBHQEjhSfIxsww+29tmGfzLwFmXNj5CILUuuJXiJyy9A== Message-ID: Date: Thu, 7 Jun 2018 23:40:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <87bmcm3frw.fsf@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: de-DE Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31498 Cc: 31498@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Thanks for the review! Replies inline. On 07.06.2018 15:08, Noam Postavsky wrote: > severity 31498 wishlist > severity 31521 wishlist > quit > > > Thanks, the patch seems straightforward enough. Just a few minor > comments about formatting. Have you assigned copyright for Emacs? The > patch is small enough to go in anyway, it would just have to be marked. I haven’t assigned copyright yet, but I’d be happy to do so – I’ve tried to get the process started on emacs-devel. > > Lucas Werkmeister writes: > >> With --[bg-]daemon and Type=forking, systemd will only consider the >> daemon to have fully started up once the original process exits, and >> will wait until then to start units depending on the Emacs service. To > ^ > double space ack >> get the same functionality with --fg-daemon, use Type=notify instead of >> Type=simple and explicitly send a readiness notification to systemd at >> the point where the forked process would in --bg-daemon mode notify its >> parent process and cause it to exit. >> * etc/emacs.service: update Type > > The ChangeLog entries should be captilalized and end with a period: > "Update Type." > >> * src/emacs.c (daemon-initialized): call sd_notify() > > Same here. 2× ack > > I think it should have a NEWS entry mentioning that Emacs now supports > this systemd notification feature. I would probably go ahead and > combine with #31521, since it's using the same feature. > Do you mean, announce both in this patch, or completely merge that patch into this one? Once I’ve fixed the problems locally, what’s the best way to re-roll the patch in this bug tracking system? Should I try to configure `git send-email` to reply to the right email (and with the right bug in CC), or perhaps use `git format-patch` and add the patch file as a regular attachment in a manual response? From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 07 20:41:48 2018 Received: (at 31498) by debbugs.gnu.org; 8 Jun 2018 00:41:48 +0000 Received: from localhost ([127.0.0.1]:38516 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fR5TP-0002wu-OX for submit@debbugs.gnu.org; Thu, 07 Jun 2018 20:41:48 -0400 Received: from mail-it0-f67.google.com ([209.85.214.67]:38533) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fR5TM-0002we-Uh for 31498@debbugs.gnu.org; Thu, 07 Jun 2018 20:41:45 -0400 Received: by mail-it0-f67.google.com with SMTP id v83-v6so340948itc.3 for <31498@debbugs.gnu.org>; Thu, 07 Jun 2018 17:41:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=E298e/Q8ZJIf9OZvpgR/ipDY+bDSEalKbKCLwyrMNCo=; b=baWRrBr8h4snEtmOJeJv5hJ3U8I2uXSvWg8q+5HxCY3vUFy9jyGGRv8DlOktbjSdyw 8EkpbnUKj6tYfCxBqmiIab3eX7QS5am23g8/kl1d1Gw7wYL6omGBDTEyrueWr1vJqj7z SXQHNY/EPTuA0cQ5WRLRG4S1cC0a7kieuzyrS5KuNoeb0CDwpzHIOigrBcQlG5mR+u1O lpO/+76/jTMbTtdHaLzqlLcZqSyPmtP0QzRrO+DFBZ6uA5rQaYhayNnFq9ntfbGCPi3p ZnfMVP0427P9nziuecinhly5o8/gCNUsjG4a0UjC68mkLSQaVSTe29/MMROzSOE0Efn4 FSUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=E298e/Q8ZJIf9OZvpgR/ipDY+bDSEalKbKCLwyrMNCo=; b=XzErMrdW1eLhjakqIEJOWsPz+lV1scY7KqIiVhiKPzPWOiEzeF84Pllr05ZpF89sQe 3zI95SVvztMXrVpP58E9UiYexRv2Orp20zm2xZnTwz4nz9weSE8w6KihF3fS3POgT3sK 2OQINeVw6ruPECtIvr+OqVUfkbkZ3FIuhOjZfCHWg3YoBI2w2N4ofzhlZH6A95nUK6K6 BXaaVZMl7ZSCiVEG5P69Qlb8UJ/KM7KPZ+QZJIExGYz7l4XM/snw2L4H6a4KYQFWJ39O +qImeXJK/1XQ63PmqTtpT0bh46dXb/O7H0ANXv4PrFjaZtfaZHKlOhc6PC08HWHozuGC ft6g== X-Gm-Message-State: APt69E1XZ1iW0NdZw3Hb/2o0MOADIMt9p8QZ4V5COoBDa1dSA4RLADUt lbAh8bdwjBBqq3UGuumH4U8B9w== X-Google-Smtp-Source: ADUXVKKRpUz79pH61yiQZWey59QL5IEdiBCV0Ce1W9qNMHzrnJfxWBDDEjG6bQiu0bzI3v3XHd4Dsg== X-Received: by 2002:a24:9486:: with SMTP id j128-v6mr3980980ite.107.1528418499155; Thu, 07 Jun 2018 17:41:39 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id 142-v6sm9006530ion.21.2018.06.07.17.41.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 07 Jun 2018 17:41:38 -0700 (PDT) From: Noam Postavsky To: Lucas Werkmeister Subject: Re: bug#31498: [PATCH] Notify systemd in daemon-initialized References: <20180518174031.12514-1-mail@lucaswerkmeister.de> <87bmcm3frw.fsf@gmail.com> Date: Thu, 07 Jun 2018 20:41:36 -0400 In-Reply-To: (Lucas Werkmeister's message of "Thu, 7 Jun 2018 23:40:08 +0200") Message-ID: <8736xy2jpb.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 31498 Cc: 31498@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lucas Werkmeister writes: > I haven=E2=80=99t assigned copyright yet, but I=E2=80=99d be happy to do = so =E2=80=93 I=E2=80=99ve tried > to get the process started on emacs-devel. Cool, since this patch will be destined for Emacs 27, there's not much urgency, so I'll wait for that to resolve before pushing. >> I think it should have a NEWS entry mentioning that Emacs now supports >> this systemd notification feature. I would probably go ahead and >> combine with #31521, since it's using the same feature. >>=20 > > Do you mean, announce both in this patch, or completely merge that patch > into this one? The latter (maybe it would have been clearer to put those two sentences in separate paragraphs). > Once I=E2=80=99ve fixed the problems locally, what=E2=80=99s the best way= to re-roll the > patch in this bug tracking system? Should I try to configure `git > send-email` to reply to the right email (and with the right bug in CC), > or perhaps use `git format-patch` and add the patch file as a regular > attachment in a manual response? Either way is fine I guess, though I've never tried 'git send-email' myself. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 09 06:28:32 2018 Received: (at 31498) by debbugs.gnu.org; 9 Jun 2018 10:28:32 +0000 Received: from localhost ([127.0.0.1]:40348 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRb6l-0006sN-Qz for submit@debbugs.gnu.org; Sat, 09 Jun 2018 06:28:32 -0400 Received: from lucaswerkmeister.de ([94.130.58.99]:55588) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRb6j-0006sE-JN for 31498@debbugs.gnu.org; Sat, 09 Jun 2018 06:28:30 -0400 Received: from theoden.lucaswerkmeister.de.home (unknown [IPv6:2a02:8109:92c0:22bb:d412:2b0:339e:ab21]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mail@lucaswerkmeister.de) by lucaswerkmeister.de (Postfix) with ESMTPSA id D5030399AE1; Sat, 9 Jun 2018 12:28:27 +0200 (CEST) Authentication-Results: lucaswerkmeister.de; dmarc=fail (p=none dis=none) header.from=lucaswerkmeister.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lucaswerkmeister.de; s=mail; t=1528540108; bh=oUTxy2SAu1LeGCgXRnlwFXlNgq8QY6v/YzpUcf+lZJM=; h=From:To:Cc:Subject:Date:Message-Id:From:Reply-To:Subject:Date:To: Cc:In-Reply-To:References:Message-Id:Sender:Content-Type: Content-Transfer-Encoding:Content-Disposition:Mime-Version; b=twJNWCkyOpXp6BgG23GhICy6Fvwa5/l5fC3fkQWVPb1lxd7V8Pq1/iQsfJdQ6j9em K777uQq1AAh+7FU4FEk/Rqp/H+8R0Vfe7bRonr3WT6Yn8Q89Nm2YibTvSnqvte5QQi tnBDHHtLGETtnThLb255xZ1GYvYHbanOfnR6KnQ8= From: Lucas Werkmeister To: 31498@debbugs.gnu.org Subject: [PATCH] Notify systemd in daemon-initialized and kill-emacs Date: Sat, 9 Jun 2018 12:27:26 +0200 Message-Id: <20180609102726.7032-1-mail@lucaswerkmeister.de> X-Mailer: git-send-email 2.17.1 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31498 Cc: Noam Postavsky , Lucas Werkmeister X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) With --[bg-]daemon and Type=forking, systemd will only consider the daemon to have fully started up once the original process exits, and will wait until then to start units depending on the Emacs service. To get the same functionality with --fg-daemon, use Type=notify instead of Type=simple and explicitly send a readiness notification to systemd at the point where the forked process would in --bg-daemon mode notify its parent process and cause it to exit. Similarly, notify systemd at the beginning of the shutdown process as well. (Both of these calls are successful no-ops if emacs was not started by systemd.) * etc/emacs.service: Update Type. * src/emacs.c (daemon-initialized): Call sd_notify(). * src/emacs.c (kill-emacs): Call sd_notify(). --- etc/emacs.service | 2 +- src/emacs.c | 11 +++++++++++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/etc/emacs.service b/etc/emacs.service index b29177b120..dbcb6bc301 100644 --- a/etc/emacs.service +++ b/etc/emacs.service @@ -7,7 +7,7 @@ Description=Emacs text editor Documentation=info:emacs man:emacs(1) https://gnu.org/software/emacs/ [Service] -Type=simple +Type=notify ExecStart=emacs --fg-daemon ExecStop=emacsclient --eval "(kill-emacs)" Environment=SSH_AUTH_SOCK=%t/keyring/ssh diff --git a/src/emacs.c b/src/emacs.c index 8633e934e5..cde20fc096 100644 --- a/src/emacs.c +++ b/src/emacs.c @@ -2017,6 +2017,10 @@ all of which are called before Emacs is actually killed. */ { int exit_code; +#ifdef HAVE_LIBSYSTEMD + sd_notify(0, "STOPPING=1"); +#endif /* HAVE_LIBSYSTEMD */ + /* Fsignal calls emacs_abort () if it sees that waiting_for_input is set. */ waiting_for_input = 0; @@ -2477,6 +2481,13 @@ from the parent process and its tty file descriptors. */) error ("This function can only be called after loading the init files"); #ifndef WINDOWSNT + if (daemon_type == 1) + { +#ifdef HAVE_LIBSYSTEMD + sd_notify(0, "READY=1"); +#endif /* HAVE_LIBSYSTEMD */ + } + if (daemon_type == 2) { int nfd; -- 2.17.1 From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 09 06:55:35 2018 Received: (at 31498) by debbugs.gnu.org; 9 Jun 2018 10:55:35 +0000 Received: from localhost ([127.0.0.1]:40364 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRbWw-0007XD-P1 for submit@debbugs.gnu.org; Sat, 09 Jun 2018 06:55:34 -0400 Received: from lucaswerkmeister.de ([94.130.58.99]:57094) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRbWt-0007X3-I4 for 31498@debbugs.gnu.org; Sat, 09 Jun 2018 06:55:33 -0400 Received: from theoden.lucaswerkmeister.de (unknown [IPv6:2a02:8109:92c0:22bb:d412:2b0:339e:ab21]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mail@lucaswerkmeister.de) by lucaswerkmeister.de (Postfix) with ESMTPSA id C2CB3399B28 for <31498@debbugs.gnu.org>; Sat, 9 Jun 2018 12:55:30 +0200 (CEST) Authentication-Results: lucaswerkmeister.de; dmarc=fail (p=none dis=none) header.from=lucaswerkmeister.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lucaswerkmeister.de; s=mail; t=1528541730; bh=k4gx+B3A50I5z4Xb7PKLpjfjOS0YRTRGy3epvxv068A=; h=To:From:Message-ID:Date:MIME-Version:Content-Type:From:Reply-To: Subject:Date:To:Cc:In-Reply-To:References:Message-Id:Sender: Content-Type:Content-Transfer-Encoding:Content-Disposition: Mime-Version; b=t8qDTBV6mgxJRngVf5Ohm5Ds6KaOJ7XfFWEIVQ+uCH+0iluNF4QFH/c2MusKWRfmi eoNdwxmrVCV1ibBsvkm/hVVV7E+zyMaObXOtyPcRwchPpeQ7P5ZKzyA/DZUIxaKQCW +81dbKzUFWZMt+tQj+9wFalek0fgm9kEVKUWkbb0= To: 31498@debbugs.gnu.org From: Lucas Werkmeister Openpgp: preference=signencrypt Autocrypt: addr=mail@lucaswerkmeister.de; prefer-encrypt=mutual; keydata= xsFNBFKkO1oBEACXP/JGIJsKiXsA866Ak439ZIaU5xNss6V2QoOQBSj6848kkxhDLEbfgVYW 4meXYpYJV9P2Vk0PC2kQWadqbvqhfP7OomlIlZzlpvbi2xbjW4tr09brY7d7GvMcplh5igYS gWo5J/6+4ZDgVj+TG0OuvkTDZmJmHhrwDuIsvh3KDJhT0z6t43qzQ69Efse/OjJRpWha5nZt fvtdBCI/v2Pq6pJrPx1g1u/BKArRcrrWLpCRQRbFwrQ1MsIkj8Wzz1tKjulGUSPIXvvssxYA /3BQEniMKzxbkZlhi4DUe5WJZWFS6BWaS+Qbwd0bq2WaCD/PFddjHN6qWAxxPY2rvP7C+Lj7 FQiHLbeMi2K0hiMEsUUsORq/A0LjG84RSwhic2a6cvszj9b6WRmRUb1PMMxcNCjCzebkdZeL RWrqhCnMU+rxQJ+qib5rbYCjvpV2hWzlXcvjaW2B32jUAhG3sDK6Cd4A+Ao7gJPv1KzdvqZj Aoo5/5RI1Er5EYkhcjGAc0N/VWnOq5WDuL4CdeamIwMyOlI42npbzKsHhlb5nXPeFl7eEOdZ RVKs3yuE3/23XpWisjKUk9tUpGBHi098rPPnbA4T9P7ZwWNwo8j4Bh8D71nC+JJ1ue92NzSi T9E7ckdSIatPl5rJIEjvf9pZB4YUugGM06JdlYakVVZZHLXFgQARAQABzSxMdWNhcyBXZXJr bWVpc3RlciA8bWFpbEBsdWNhc3dlcmttZWlzdGVyLmRlPsLBmAQTAQoAQgIbAwYLCQgHAwIG FQgCCQoLBBYCAwECHgECF4ACGQEWIQRriVuLEaR1seyTFpj8Rihycq4yPwUCWK8aSwUJGNbh 8QAKCRD8Rihycq4yP/FSD/45wEQTFrMYzti+9B4/4c4GpGajT2HEw5YxKL/Gcifu3mwMrQLn uxbCtuuBLtmOt1W13c+MBFVu2fals6fABlTev7Ikh7NSu6APA3XBpgk/ckJHwOaPPRGp8GDD N3UmDBOXd/mzWK2Zz+m1iU0xpcd4Td34TkOa/qYFqCmY5SZILFRzpgZ9QNZEBQBOGwwvvnax rIKVpH5Vgghp9WBDtElOM9cFH8uq1IOXob/nRsxwAC1kEB04uMneA+Xm4T7KhJ+0QKCNe54s BxK6SI54mEpy8cfyVr3oopM8uDcj014ebxsbrvQmcC8AI8ptt+BwgCl4kO033qhc0ll5kRXB EDtbvTDVf6OafLNECaWxxWnYadxVLOfbTaHMjdGyqA7GLmOL+Wcb/uZpW1sFnpMSAeGTBvap jXmjxNleJThHviD/WqR218yZevvWcA1XvgAObYwGiNF8KbOzKw8oUUp/nzMZYL0JN85gUDDa ef28x/2spQEtDs9zlTZxioHogVNVOzGlt+7Sm23RzE0aU/f14nahI2g8/179e5B4Nv10lO8d 8ZiQ663n42ODZju5iqVYvIkBlqVYliGxd7dgJLX9D5Qo65a62BhKuLQclyYBVVuoe4+HsUET wfshMFAAnGPWbWM6ZY96+XQ1tnyWKKTaosGJ1XwNwuZA31rCwruWtW2JxM7BTQRSpDtaARAA 6s6WSxIWC4NuNiYSUTIaqOTkYnv2w9ME/3WF/o/F50eBY5ko+5tll7dLQDH1SKtReqFc2ZnY AIXkFSAkbweu+7VxEcosPKP67xUGJyCAGikCgW7uVFSsnVyOPSpt4GixQjq6p4NxOMGpnxCk cy9pTwBudMwSE1j/NF0SVDFYChKo9OR5eyetHuHzglGdBjE/izu//gMY5JOgZEfz4MqDL8Vw ypK+w1qTI7t7rQAme1Ia+7shxv5+gCJMH/IJL4RL8lQ2uEFbUpJ6KiJhpAhf4CrMTPkZxxs2 x3mfcUDW7YZW9r8n2iUrVkzVHCEvbN7PRREf3LeiBF8eZKM5GcimtMgriit9Vv6DbpK8r9/2 QJeGyblN9kk97GLQ2IG0PzrpLcn1/0aTJcwqFvA3phG2baY2M0FMdvJW1G9EjJsQAvwvCFAs m7v4xxzmyADnPJjqWCe0EqOBuoYrjEOf8Hd7LsnoSHdsIuIQiyY3SQ9Et6d/lTiUFYcwAtXI 0xhDEcBKjp5mBo19OBPKR0HvlhEMwyikoUkTl4Hf3ZVa2ohNZ3g8xE0oDFaBwnSW/GYtLBqd uOhk8yoWyGN7gIv7Bgquwq1uCE2UtBI9kYCM9Oscp/Zu8pmYe44p/8SpCPA5G7Vsjmf4ax2S +Fazd1lvIKgRIu4QozBMhlMOgpQsErDpwD0AEQEAAcLBXwQYAQIACQUCUqQ7WgIbDAAKCRD8 Rihycq4yP/QeEACDfzBFA2RBpAEuuJm89v53NA5vfmuy2LZxnwez+tc1/PjRdyZAU+/GcYd5 QGLcTfDkrrLqbCWrQ09044ObCJeY8gdF4wFTGP1kpCHeLBrS5ZKLUoBQNbbBG+vJn6iDcpJV qHwG+3HoC79cj0g2Bi09x/c8F5Zg1m4gcnZFfwRSxIyUk+TI2IAZUO2F6k6u4g1+ZFHxOLNp jjbEMV/BgVRhWV3M6cwtF7SFZ69raSZNPemHyhQ3XjCZ04czvHyLILYMwWAt/v7MID2pusEr NyMa/CLDadQbRaABeXqW6O6X6JycFbRFtR8997BFcaGGb8OcYvgTDG6puAhsVZi6I71JhEJ9 psCFBaoIG91ZVdb+bnVrFMuyvVJXjblSeBLwv5CCr4RpLpZq/yjxiclQ3IXVRCqp6kNR5dit Gl8pI8b0TZNjorq5/t/J/ALCu0nD3gyuK/DyUyA1vILCX6Gqhp3Ng1t2gBJI5sq3ZZrcYLhs mlNgF7uByLe1oqWuHRrL+MxP5+x7xyVlQRgr8bPfec7uS0a/Ip/NaYao9EKRq1Xr6k6R5cSB aZVxGTIY2539GttvdFSue6TaGT9irKqKdtK0rT6Hr+u2rm2ppuayv+vs9TaTNDovnG9J0Dco ZyF1BmKBHQEjhSfIxsww+29tmGfzLwFmXNj5CILUuuJXiJyy9A== Message-ID: <3e8eb182-b99c-02b0-d561-23b8923402fc@lucaswerkmeister.de> Date: Sat, 9 Jun 2018 12:55:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="------------4B342687B704A455E85E90C6" Content-Language: de-DE X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: sorry, forgot the double-space after periods after editing the commit message, rerolling sorry, forgot the double-space after periods after editing the commit message, rerolling [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 HTML_MESSAGE BODY: HTML included in message 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject X-Debbugs-Envelope-To: 31498 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) This is a multi-part message in MIME format. --------------4B342687B704A455E85E90C6 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit sorry, forgot the double-space after periods after editing the commit message, rerolling --------------4B342687B704A455E85E90C6 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit

sorry, forgot the double-space after periods after editing the commit message, rerolling

--------------4B342687B704A455E85E90C6-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 09 06:56:46 2018 Received: (at 31498) by debbugs.gnu.org; 9 Jun 2018 10:56:46 +0000 Received: from localhost ([127.0.0.1]:40368 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRbY6-0007Z6-5S for submit@debbugs.gnu.org; Sat, 09 Jun 2018 06:56:46 -0400 Received: from lucaswerkmeister.de ([94.130.58.99]:57170) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRbY4-0007Yu-5M for 31498@debbugs.gnu.org; Sat, 09 Jun 2018 06:56:44 -0400 Received: from theoden.lucaswerkmeister.de.home (unknown [IPv6:2a02:8109:92c0:22bb:d412:2b0:339e:ab21]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mail@lucaswerkmeister.de) by lucaswerkmeister.de (Postfix) with ESMTPSA id 069A6399B2F; Sat, 9 Jun 2018 12:56:42 +0200 (CEST) Authentication-Results: lucaswerkmeister.de; dmarc=fail (p=none dis=none) header.from=lucaswerkmeister.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lucaswerkmeister.de; s=mail; t=1528541803; bh=oUTxy2SAu1LeGCgXRnlwFXlNgq8QY6v/YzpUcf+lZJM=; h=From:To:Cc:Subject:Date:Message-Id:From:Reply-To:Subject:Date:To: Cc:In-Reply-To:References:Message-Id:Sender:Content-Type: Content-Transfer-Encoding:Content-Disposition:Mime-Version; b=RhNPa1PLj5Jzx0c/hap9GDCNPTNnJavgCKLj7TEHr1FrDYSLjw0o3hMiwf4AuQNcn zQ2jw+dCou3DTndg1N9M6RavmSw4ptyaZagD3/oxGF6EE41LESFRK7NFFw7GSRUbEi DJIUv08jJ0kYyz5QhHZQIca58zWHKOE3wajelQmg= From: Lucas Werkmeister To: 31498@debbugs.gnu.org Subject: [PATCH] Notify systemd in daemon-initialized and kill-emacs Date: Sat, 9 Jun 2018 12:56:16 +0200 Message-Id: <20180609105616.12927-1-mail@lucaswerkmeister.de> X-Mailer: git-send-email 2.17.1 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31498 Cc: Noam Postavsky , Lucas Werkmeister X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) With --[bg-]daemon and Type=forking, systemd will only consider the daemon to have fully started up once the original process exits, and will wait until then to start units depending on the Emacs service. To get the same functionality with --fg-daemon, use Type=notify instead of Type=simple and explicitly send a readiness notification to systemd at the point where the forked process would in --bg-daemon mode notify its parent process and cause it to exit. Similarly, notify systemd at the beginning of the shutdown process as well. (Both of these calls are successful no-ops if emacs was not started by systemd.) * etc/emacs.service: Update Type. * src/emacs.c (daemon-initialized): Call sd_notify(). * src/emacs.c (kill-emacs): Call sd_notify(). --- etc/emacs.service | 2 +- src/emacs.c | 11 +++++++++++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/etc/emacs.service b/etc/emacs.service index b29177b120..dbcb6bc301 100644 --- a/etc/emacs.service +++ b/etc/emacs.service @@ -7,7 +7,7 @@ Description=Emacs text editor Documentation=info:emacs man:emacs(1) https://gnu.org/software/emacs/ [Service] -Type=simple +Type=notify ExecStart=emacs --fg-daemon ExecStop=emacsclient --eval "(kill-emacs)" Environment=SSH_AUTH_SOCK=%t/keyring/ssh diff --git a/src/emacs.c b/src/emacs.c index 8633e934e5..cde20fc096 100644 --- a/src/emacs.c +++ b/src/emacs.c @@ -2017,6 +2017,10 @@ all of which are called before Emacs is actually killed. */ { int exit_code; +#ifdef HAVE_LIBSYSTEMD + sd_notify(0, "STOPPING=1"); +#endif /* HAVE_LIBSYSTEMD */ + /* Fsignal calls emacs_abort () if it sees that waiting_for_input is set. */ waiting_for_input = 0; @@ -2477,6 +2481,13 @@ from the parent process and its tty file descriptors. */) error ("This function can only be called after loading the init files"); #ifndef WINDOWSNT + if (daemon_type == 1) + { +#ifdef HAVE_LIBSYSTEMD + sd_notify(0, "READY=1"); +#endif /* HAVE_LIBSYSTEMD */ + } + if (daemon_type == 2) { int nfd; -- 2.17.1 From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 09 08:29:32 2018 Received: (at 31498) by debbugs.gnu.org; 9 Jun 2018 12:29:32 +0000 Received: from localhost ([127.0.0.1]:40416 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRczs-0003FV-85 for submit@debbugs.gnu.org; Sat, 09 Jun 2018 08:29:32 -0400 Received: from mail-io0-f182.google.com ([209.85.223.182]:46081) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRczq-0003FJ-Gg for 31498@debbugs.gnu.org; Sat, 09 Jun 2018 08:29:30 -0400 Received: by mail-io0-f182.google.com with SMTP id d22-v6so18857384iof.13 for <31498@debbugs.gnu.org>; Sat, 09 Jun 2018 05:29:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=nKX9Yq4UKsFJ3leiyg1mqFf48NZU7Oj91Au5NFcjCoY=; b=n2BDZVTAbRmyId8z40d1HqNh0Hy6y0NnEhV9IV4GvZLfLQeE8CaIhkWsdFRyzYxdMN t/vyBObIF42z8qWDEJYwI/6Lis8FFR2F+5o26Uj/iIGiZqXBkmLdXIqsBkyJsuF4xOLk SyW0ZEgxgXRM3CUMTG43RLy/mQphiQWrGPmOpGB2fvTNasb9kp4EVBoOYvl0aTeDPKhq 5PKXvkNhKLZg4nRLYoUF24+qtraX4KEflEHifOyGLVVWtbHDrTRuO65vh+L/dEF1+3T7 93pYFjR96401qI2QMIQb4kl0IDFiXj8NYDGRDoPeZ/6Z1rcIU8MXW9+UdnbLwrZAW6zV DHtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=nKX9Yq4UKsFJ3leiyg1mqFf48NZU7Oj91Au5NFcjCoY=; b=NWrtjZUNQoo1UYtPF/Tv876cv1mHsshZEQeL6iuajGOHCSco4/VbdcOD1hLkpT+lnX gGi2xjtL7vXXqJlPgAn7oXZ2zR32b1XhBz4NYoP0nHvbnspDT7nS2Y1RRxKr/kxPTefR tDafz1SUWFrRzk8dK5UwNn6SG1neNTa2slxYgiuI7fm9wigIqcpyuPVwql/+VHPf57zC k49KImnh6iH2EhwNHL+2KqTw81ZNcXOcflfpa5efUct2Od1itDLUqYIj8+5p/waDzt45 9lDFPsd9JjJQCIXW0e0AckJx5/nRbcELKFgGIrW0ms5+ffOiNQKlE7HoKVGKIOLZ/9WD XP+g== X-Gm-Message-State: APt69E2dQ4PuOIEKvKzoLH71qHAuqyvKxDY2U4UPJ5OQOL9fZFf/OjZZ 3fG+uuysj6BBtEcNNkLY4QKaoQ== X-Google-Smtp-Source: ADUXVKKOQlW1bFL6ck8kLoD40A0fFk57bmDz7AJyxFRGoXl4tZbvf+I0SRnRQavkPxVSMB9Gd271Gw== X-Received: by 2002:a6b:978c:: with SMTP id z134-v6mr8056019iod.184.1528547364965; Sat, 09 Jun 2018 05:29:24 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id k1-v6sm9611633iob.9.2018.06.09.05.29.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 09 Jun 2018 05:29:24 -0700 (PDT) From: Noam Postavsky To: Lucas Werkmeister Subject: Re: bug#31498: [PATCH] Notify systemd in daemon-initialized and kill-emacs References: <20180518174031.12514-1-mail@lucaswerkmeister.de> <20180609105616.12927-1-mail@lucaswerkmeister.de> Date: Sat, 09 Jun 2018 08:29:22 -0400 In-Reply-To: <20180609105616.12927-1-mail@lucaswerkmeister.de> (Lucas Werkmeister's message of "Sat, 9 Jun 2018 12:56:16 +0200") Message-ID: <87k1r816u5.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31498 Cc: 31498@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > >> I think it should have a NEWS entry mentioning that Emacs now supports > >> this systemd notification feature. I would probably go ahead and > >> combine with #31521, since it's using the same feature. > >> > > > > Do you mean, announce both in this patch, or completely merge that patch > > into this one? > The latter (maybe it would have been clearer to put those two sentences > in separate paragraphs). I think I still managed to be unclear about this; I meant you should both announce the change in etc/NEWS, and merge the patches. Lucas Werkmeister writes: > With --[bg-]daemon and Type=forking, systemd will only consider the > daemon to have fully started up once the original process exits, and > will wait until then to start units depending on the Emacs service. To > get the same functionality with --fg-daemon, use Type=notify instead of > Type=simple and explicitly send a readiness notification to systemd at > the point where the forked process would in --bg-daemon mode notify its > parent process and cause it to exit. Similarly, notify systemd at the > beginning of the shutdown process as well. (Both of these calls are > successful no-ops if emacs was not started by systemd.) > * etc/emacs.service: Update Type. > * src/emacs.c (daemon-initialized): Call sd_notify(). > * src/emacs.c (kill-emacs): Call sd_notify(). Thanks, I think I still managed to be unclear about the From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 09 08:31:11 2018 Received: (at 31498) by debbugs.gnu.org; 9 Jun 2018 12:31:11 +0000 Received: from localhost ([127.0.0.1]:40420 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRd1R-0003JR-Ir for submit@debbugs.gnu.org; Sat, 09 Jun 2018 08:31:09 -0400 Received: from lucaswerkmeister.de ([94.130.58.99]:34308) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRd1P-0003JJ-Oo for 31498@debbugs.gnu.org; Sat, 09 Jun 2018 08:31:08 -0400 Received: from theoden.lucaswerkmeister.de (unknown [IPv6:2a02:8109:92c0:22bb:d412:2b0:339e:ab21]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mail@lucaswerkmeister.de) by lucaswerkmeister.de (Postfix) with ESMTPSA id 439FC399D95; Sat, 9 Jun 2018 14:31:05 +0200 (CEST) Authentication-Results: lucaswerkmeister.de; dmarc=fail (p=none dis=none) header.from=lucaswerkmeister.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lucaswerkmeister.de; s=mail; t=1528547466; bh=EznZbtTb2vJsybkXVkvPiJE/sUhqKsXbZiYxLsAyFVQ=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type:Content-Transfer-Encoding:From:Reply-To: Subject:Date:To:Cc:In-Reply-To:References:Message-Id:Sender: Content-Type:Content-Transfer-Encoding:Content-Disposition: Mime-Version; b=YOk1bhklXPZQD0pme1bN2nql6aBnhEQ39hE8MSgOsUwSCC4Q9VMk6KMqPtmGcZj/z A0KJzAo8pjyTstjr3gFVHsSCpNsqE2gSWp0F953vKX1znBT/ZlY0zTkg2E0i99OUKM 3t1CNGSwrmatHquDOgcA4wIXyaPLaHrMLHi0cB0g= Subject: Re: bug#31498: [PATCH] Notify systemd in daemon-initialized and kill-emacs To: Noam Postavsky References: <20180518174031.12514-1-mail@lucaswerkmeister.de> <20180609105616.12927-1-mail@lucaswerkmeister.de> <87k1r816u5.fsf@gmail.com> From: Lucas Werkmeister Openpgp: preference=signencrypt Autocrypt: addr=mail@lucaswerkmeister.de; prefer-encrypt=mutual; keydata= xsFNBFKkO1oBEACXP/JGIJsKiXsA866Ak439ZIaU5xNss6V2QoOQBSj6848kkxhDLEbfgVYW 4meXYpYJV9P2Vk0PC2kQWadqbvqhfP7OomlIlZzlpvbi2xbjW4tr09brY7d7GvMcplh5igYS gWo5J/6+4ZDgVj+TG0OuvkTDZmJmHhrwDuIsvh3KDJhT0z6t43qzQ69Efse/OjJRpWha5nZt fvtdBCI/v2Pq6pJrPx1g1u/BKArRcrrWLpCRQRbFwrQ1MsIkj8Wzz1tKjulGUSPIXvvssxYA /3BQEniMKzxbkZlhi4DUe5WJZWFS6BWaS+Qbwd0bq2WaCD/PFddjHN6qWAxxPY2rvP7C+Lj7 FQiHLbeMi2K0hiMEsUUsORq/A0LjG84RSwhic2a6cvszj9b6WRmRUb1PMMxcNCjCzebkdZeL RWrqhCnMU+rxQJ+qib5rbYCjvpV2hWzlXcvjaW2B32jUAhG3sDK6Cd4A+Ao7gJPv1KzdvqZj Aoo5/5RI1Er5EYkhcjGAc0N/VWnOq5WDuL4CdeamIwMyOlI42npbzKsHhlb5nXPeFl7eEOdZ RVKs3yuE3/23XpWisjKUk9tUpGBHi098rPPnbA4T9P7ZwWNwo8j4Bh8D71nC+JJ1ue92NzSi T9E7ckdSIatPl5rJIEjvf9pZB4YUugGM06JdlYakVVZZHLXFgQARAQABzSxMdWNhcyBXZXJr bWVpc3RlciA8bWFpbEBsdWNhc3dlcmttZWlzdGVyLmRlPsLBmAQTAQoAQgIbAwYLCQgHAwIG FQgCCQoLBBYCAwECHgECF4ACGQEWIQRriVuLEaR1seyTFpj8Rihycq4yPwUCWK8aSwUJGNbh 8QAKCRD8Rihycq4yP/FSD/45wEQTFrMYzti+9B4/4c4GpGajT2HEw5YxKL/Gcifu3mwMrQLn uxbCtuuBLtmOt1W13c+MBFVu2fals6fABlTev7Ikh7NSu6APA3XBpgk/ckJHwOaPPRGp8GDD N3UmDBOXd/mzWK2Zz+m1iU0xpcd4Td34TkOa/qYFqCmY5SZILFRzpgZ9QNZEBQBOGwwvvnax rIKVpH5Vgghp9WBDtElOM9cFH8uq1IOXob/nRsxwAC1kEB04uMneA+Xm4T7KhJ+0QKCNe54s BxK6SI54mEpy8cfyVr3oopM8uDcj014ebxsbrvQmcC8AI8ptt+BwgCl4kO033qhc0ll5kRXB EDtbvTDVf6OafLNECaWxxWnYadxVLOfbTaHMjdGyqA7GLmOL+Wcb/uZpW1sFnpMSAeGTBvap jXmjxNleJThHviD/WqR218yZevvWcA1XvgAObYwGiNF8KbOzKw8oUUp/nzMZYL0JN85gUDDa ef28x/2spQEtDs9zlTZxioHogVNVOzGlt+7Sm23RzE0aU/f14nahI2g8/179e5B4Nv10lO8d 8ZiQ663n42ODZju5iqVYvIkBlqVYliGxd7dgJLX9D5Qo65a62BhKuLQclyYBVVuoe4+HsUET wfshMFAAnGPWbWM6ZY96+XQ1tnyWKKTaosGJ1XwNwuZA31rCwruWtW2JxM7BTQRSpDtaARAA 6s6WSxIWC4NuNiYSUTIaqOTkYnv2w9ME/3WF/o/F50eBY5ko+5tll7dLQDH1SKtReqFc2ZnY AIXkFSAkbweu+7VxEcosPKP67xUGJyCAGikCgW7uVFSsnVyOPSpt4GixQjq6p4NxOMGpnxCk cy9pTwBudMwSE1j/NF0SVDFYChKo9OR5eyetHuHzglGdBjE/izu//gMY5JOgZEfz4MqDL8Vw ypK+w1qTI7t7rQAme1Ia+7shxv5+gCJMH/IJL4RL8lQ2uEFbUpJ6KiJhpAhf4CrMTPkZxxs2 x3mfcUDW7YZW9r8n2iUrVkzVHCEvbN7PRREf3LeiBF8eZKM5GcimtMgriit9Vv6DbpK8r9/2 QJeGyblN9kk97GLQ2IG0PzrpLcn1/0aTJcwqFvA3phG2baY2M0FMdvJW1G9EjJsQAvwvCFAs m7v4xxzmyADnPJjqWCe0EqOBuoYrjEOf8Hd7LsnoSHdsIuIQiyY3SQ9Et6d/lTiUFYcwAtXI 0xhDEcBKjp5mBo19OBPKR0HvlhEMwyikoUkTl4Hf3ZVa2ohNZ3g8xE0oDFaBwnSW/GYtLBqd uOhk8yoWyGN7gIv7Bgquwq1uCE2UtBI9kYCM9Oscp/Zu8pmYe44p/8SpCPA5G7Vsjmf4ax2S +Fazd1lvIKgRIu4QozBMhlMOgpQsErDpwD0AEQEAAcLBXwQYAQIACQUCUqQ7WgIbDAAKCRD8 Rihycq4yP/QeEACDfzBFA2RBpAEuuJm89v53NA5vfmuy2LZxnwez+tc1/PjRdyZAU+/GcYd5 QGLcTfDkrrLqbCWrQ09044ObCJeY8gdF4wFTGP1kpCHeLBrS5ZKLUoBQNbbBG+vJn6iDcpJV qHwG+3HoC79cj0g2Bi09x/c8F5Zg1m4gcnZFfwRSxIyUk+TI2IAZUO2F6k6u4g1+ZFHxOLNp jjbEMV/BgVRhWV3M6cwtF7SFZ69raSZNPemHyhQ3XjCZ04czvHyLILYMwWAt/v7MID2pusEr NyMa/CLDadQbRaABeXqW6O6X6JycFbRFtR8997BFcaGGb8OcYvgTDG6puAhsVZi6I71JhEJ9 psCFBaoIG91ZVdb+bnVrFMuyvVJXjblSeBLwv5CCr4RpLpZq/yjxiclQ3IXVRCqp6kNR5dit Gl8pI8b0TZNjorq5/t/J/ALCu0nD3gyuK/DyUyA1vILCX6Gqhp3Ng1t2gBJI5sq3ZZrcYLhs mlNgF7uByLe1oqWuHRrL+MxP5+x7xyVlQRgr8bPfec7uS0a/Ip/NaYao9EKRq1Xr6k6R5cSB aZVxGTIY2539GttvdFSue6TaGT9irKqKdtK0rT6Hr+u2rm2ppuayv+vs9TaTNDovnG9J0Dco ZyF1BmKBHQEjhSfIxsww+29tmGfzLwFmXNj5CILUuuJXiJyy9A== Message-ID: <768f4f21-fea1-ff8b-30b5-1cba31b0c6a3@lucaswerkmeister.de> Date: Sat, 9 Jun 2018 14:31:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <87k1r816u5.fsf@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: de-DE Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31498 Cc: 31498@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 09.06.2018 14:29, Noam Postavsky wrote: > > I think I still managed to be unclear about this; I meant you should > both announce the change in etc/NEWS, and merge the patches. Sorry, no, that’s not your fault, I just forgot :) will reroll From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 09 08:36:10 2018 Received: (at 31498) by debbugs.gnu.org; 9 Jun 2018 12:36:11 +0000 Received: from localhost ([127.0.0.1]:40424 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRd6I-0003Qy-Ma for submit@debbugs.gnu.org; Sat, 09 Jun 2018 08:36:10 -0400 Received: from mail-it0-f46.google.com ([209.85.214.46]:55536) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRd6H-0003Qf-JK for 31498@debbugs.gnu.org; Sat, 09 Jun 2018 08:36:09 -0400 Received: by mail-it0-f46.google.com with SMTP id 16-v6so770916itl.5 for <31498@debbugs.gnu.org>; Sat, 09 Jun 2018 05:36:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=mvInNKu9YcRbprZ10iFBw3UQXfvdZ+iHhVKc4iXa1Wc=; b=rBF68gzKiFSpTNFwYTa2oXZoaMDjOPMGBMybq7by7Ow+CN/NIhTD91kh6uHvguoOZe Ipjk9QD6urkZN6RPgAW0qkFWKLNm/8Ae/JIZigQUpyRoMBTnAMqV6YHvjA+YPSafznDK vtqrE2/O1eHb/yjzprkLhwSE3Qc9jpjr9yPUGaQCYzCF0v9YlyR3kx8ysXtOh72Skryd ZxlhHJYLEVgkoi6oTRqL5v2etw3tWimbyl82WycLEgPxRnBbsu7+RuJgl6vo+M5SgR7v ih6HZZoXYf22ePAPuk0kzUmPcqqY0DXXuVpdXjMSGONvoZokG8lc8HoXPudPtZ7fYioB zt9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=mvInNKu9YcRbprZ10iFBw3UQXfvdZ+iHhVKc4iXa1Wc=; b=r//16vduDa6SEEE0nOvRM1IFm397yHn3UWO4OCZupm0X718RcKgb9JOKn2oavV5eZZ xRIjk/fxhSbaM674lTwq4GzEm13OS61iiTz/ftovKQfNhw0gJ/AGRstIL2Ny3BWpGa5y A10uqz0PzK/zmVbu/mJmKspBR0F41aE0NTkKiNRhpFD4PgDrzKUsW1BOXlMIOtwAP0re GrGEAkFpOSRUU85TfpnTP29rGYmurQRcdEhba0OXSizeERODKSgvT0p/MNZzXdj68Xhi HzQq+XUj0CMR9pfU9G1ZGOBo3wjDu8vdsE9QzpoFXcZahefhFt+vKiHuus4S7dLS7t5X ckMQ== X-Gm-Message-State: APt69E1mwchbqYRI1vsrEzjLrFsE48zkbNpYfAejuSEhXLTNKcL0zP+D eTwW8wroWJ1rmITdwt1TF+HjKg== X-Google-Smtp-Source: ADUXVKKp9qgMBzqhMReO4wN+s7awhyJJ+TSZn6PPRBuAXOoNyX/100+yP1FRvtGSTylRA/YMlbNPtA== X-Received: by 2002:a24:82c2:: with SMTP id t185-v6mr5434304itd.117.1528547764018; Sat, 09 Jun 2018 05:36:04 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id g26-v6sm2939794iti.0.2018.06.09.05.36.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 09 Jun 2018 05:36:03 -0700 (PDT) From: Noam Postavsky To: Lucas Werkmeister Subject: Re: bug#31498: [PATCH] Notify systemd in daemon-initialized and kill-emacs References: <20180518174031.12514-1-mail@lucaswerkmeister.de> <20180609105616.12927-1-mail@lucaswerkmeister.de> <87k1r816u5.fsf@gmail.com> Date: Sat, 09 Jun 2018 08:36:02 -0400 In-Reply-To: <87k1r816u5.fsf@gmail.com> (Noam Postavsky's message of "Sat, 09 Jun 2018 08:29:22 -0400") Message-ID: <87fu1w16j1.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 31498 Cc: 31498@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Noam Postavsky writes: > Lucas Werkmeister writes: > >> * etc/emacs.service: Update Type. >> * src/emacs.c (daemon-initialized): Call sd_notify(). >> * src/emacs.c (kill-emacs): Call sd_notify(). Oops, hit send too early. I wanted to add, that you don't need to repeat the same message for the last two ChangeLog entries, and you should use the "Conditional Changes" syntax [1], like so: * src/emacs.c (daemon-initialized) [HAVE_LIBSYSTEMD]: * src/emacs.c (kill-emacs) [HAVE_LIBSYSTEMD]: Call sd_notify(). [1]: https://www.gnu.org/prep/standards/html_node/Conditional-Changes.html PS I was wrong about 'git send-email' being just as good as replying with attachment. The bug tracker adds a "bug#xxxxx:" prefix, so I end up getting duplicate emails. Next time someone asks I'll know what to answer :) From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 09 09:00:01 2018 Received: (at 31498) by debbugs.gnu.org; 9 Jun 2018 13:00:02 +0000 Received: from localhost ([127.0.0.1]:40437 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRdTN-0003yI-6y for submit@debbugs.gnu.org; Sat, 09 Jun 2018 09:00:01 -0400 Received: from lucaswerkmeister.de ([94.130.58.99]:35782) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRdTK-0003y8-VS for 31498@debbugs.gnu.org; Sat, 09 Jun 2018 08:59:59 -0400 Received: from theoden.lucaswerkmeister.de (unknown [IPv6:2a02:8109:92c0:22bb:d412:2b0:339e:ab21]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mail@lucaswerkmeister.de) by lucaswerkmeister.de (Postfix) with ESMTPSA id C085A399DD8; Sat, 9 Jun 2018 14:59:57 +0200 (CEST) Authentication-Results: lucaswerkmeister.de; dmarc=fail (p=none dis=none) header.from=lucaswerkmeister.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lucaswerkmeister.de; s=mail; t=1528549197; bh=Ei9Lc78T04Tvslb8A2iSH68s+RORe1CTzvijyoAV3RU=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type:Content-Transfer-Encoding:From:Reply-To: Subject:Date:To:Cc:In-Reply-To:References:Message-Id:Sender: Content-Type:Content-Transfer-Encoding:Content-Disposition: Mime-Version; b=jKXpqo/WMkrBufrGRdNIZ+pcu1grhaVxoNFqX13Ap7l2abURTisl73KR0Mc0rJgT6 Ch1tW1tTgIK5AS3JP/n4mLpyUOOPtiK870OWa6ZoxhQ+yhrmy1+2v50gT+PTroCWfn 2sQcbQ/gUXuu8PTwTbVlSnEj5iOxGUQwi0Lve2Kk= Subject: Re: bug#31498: [PATCH] Notify systemd in daemon-initialized and kill-emacs To: Noam Postavsky References: <20180518174031.12514-1-mail@lucaswerkmeister.de> <20180609105616.12927-1-mail@lucaswerkmeister.de> <87k1r816u5.fsf@gmail.com> <87fu1w16j1.fsf@gmail.com> From: Lucas Werkmeister Openpgp: preference=signencrypt Autocrypt: addr=mail@lucaswerkmeister.de; prefer-encrypt=mutual; keydata= xsFNBFKkO1oBEACXP/JGIJsKiXsA866Ak439ZIaU5xNss6V2QoOQBSj6848kkxhDLEbfgVYW 4meXYpYJV9P2Vk0PC2kQWadqbvqhfP7OomlIlZzlpvbi2xbjW4tr09brY7d7GvMcplh5igYS gWo5J/6+4ZDgVj+TG0OuvkTDZmJmHhrwDuIsvh3KDJhT0z6t43qzQ69Efse/OjJRpWha5nZt fvtdBCI/v2Pq6pJrPx1g1u/BKArRcrrWLpCRQRbFwrQ1MsIkj8Wzz1tKjulGUSPIXvvssxYA /3BQEniMKzxbkZlhi4DUe5WJZWFS6BWaS+Qbwd0bq2WaCD/PFddjHN6qWAxxPY2rvP7C+Lj7 FQiHLbeMi2K0hiMEsUUsORq/A0LjG84RSwhic2a6cvszj9b6WRmRUb1PMMxcNCjCzebkdZeL RWrqhCnMU+rxQJ+qib5rbYCjvpV2hWzlXcvjaW2B32jUAhG3sDK6Cd4A+Ao7gJPv1KzdvqZj Aoo5/5RI1Er5EYkhcjGAc0N/VWnOq5WDuL4CdeamIwMyOlI42npbzKsHhlb5nXPeFl7eEOdZ RVKs3yuE3/23XpWisjKUk9tUpGBHi098rPPnbA4T9P7ZwWNwo8j4Bh8D71nC+JJ1ue92NzSi T9E7ckdSIatPl5rJIEjvf9pZB4YUugGM06JdlYakVVZZHLXFgQARAQABzSxMdWNhcyBXZXJr bWVpc3RlciA8bWFpbEBsdWNhc3dlcmttZWlzdGVyLmRlPsLBmAQTAQoAQgIbAwYLCQgHAwIG FQgCCQoLBBYCAwECHgECF4ACGQEWIQRriVuLEaR1seyTFpj8Rihycq4yPwUCWK8aSwUJGNbh 8QAKCRD8Rihycq4yP/FSD/45wEQTFrMYzti+9B4/4c4GpGajT2HEw5YxKL/Gcifu3mwMrQLn uxbCtuuBLtmOt1W13c+MBFVu2fals6fABlTev7Ikh7NSu6APA3XBpgk/ckJHwOaPPRGp8GDD N3UmDBOXd/mzWK2Zz+m1iU0xpcd4Td34TkOa/qYFqCmY5SZILFRzpgZ9QNZEBQBOGwwvvnax rIKVpH5Vgghp9WBDtElOM9cFH8uq1IOXob/nRsxwAC1kEB04uMneA+Xm4T7KhJ+0QKCNe54s BxK6SI54mEpy8cfyVr3oopM8uDcj014ebxsbrvQmcC8AI8ptt+BwgCl4kO033qhc0ll5kRXB EDtbvTDVf6OafLNECaWxxWnYadxVLOfbTaHMjdGyqA7GLmOL+Wcb/uZpW1sFnpMSAeGTBvap jXmjxNleJThHviD/WqR218yZevvWcA1XvgAObYwGiNF8KbOzKw8oUUp/nzMZYL0JN85gUDDa ef28x/2spQEtDs9zlTZxioHogVNVOzGlt+7Sm23RzE0aU/f14nahI2g8/179e5B4Nv10lO8d 8ZiQ663n42ODZju5iqVYvIkBlqVYliGxd7dgJLX9D5Qo65a62BhKuLQclyYBVVuoe4+HsUET wfshMFAAnGPWbWM6ZY96+XQ1tnyWKKTaosGJ1XwNwuZA31rCwruWtW2JxM7BTQRSpDtaARAA 6s6WSxIWC4NuNiYSUTIaqOTkYnv2w9ME/3WF/o/F50eBY5ko+5tll7dLQDH1SKtReqFc2ZnY AIXkFSAkbweu+7VxEcosPKP67xUGJyCAGikCgW7uVFSsnVyOPSpt4GixQjq6p4NxOMGpnxCk cy9pTwBudMwSE1j/NF0SVDFYChKo9OR5eyetHuHzglGdBjE/izu//gMY5JOgZEfz4MqDL8Vw ypK+w1qTI7t7rQAme1Ia+7shxv5+gCJMH/IJL4RL8lQ2uEFbUpJ6KiJhpAhf4CrMTPkZxxs2 x3mfcUDW7YZW9r8n2iUrVkzVHCEvbN7PRREf3LeiBF8eZKM5GcimtMgriit9Vv6DbpK8r9/2 QJeGyblN9kk97GLQ2IG0PzrpLcn1/0aTJcwqFvA3phG2baY2M0FMdvJW1G9EjJsQAvwvCFAs m7v4xxzmyADnPJjqWCe0EqOBuoYrjEOf8Hd7LsnoSHdsIuIQiyY3SQ9Et6d/lTiUFYcwAtXI 0xhDEcBKjp5mBo19OBPKR0HvlhEMwyikoUkTl4Hf3ZVa2ohNZ3g8xE0oDFaBwnSW/GYtLBqd uOhk8yoWyGN7gIv7Bgquwq1uCE2UtBI9kYCM9Oscp/Zu8pmYe44p/8SpCPA5G7Vsjmf4ax2S +Fazd1lvIKgRIu4QozBMhlMOgpQsErDpwD0AEQEAAcLBXwQYAQIACQUCUqQ7WgIbDAAKCRD8 Rihycq4yP/QeEACDfzBFA2RBpAEuuJm89v53NA5vfmuy2LZxnwez+tc1/PjRdyZAU+/GcYd5 QGLcTfDkrrLqbCWrQ09044ObCJeY8gdF4wFTGP1kpCHeLBrS5ZKLUoBQNbbBG+vJn6iDcpJV qHwG+3HoC79cj0g2Bi09x/c8F5Zg1m4gcnZFfwRSxIyUk+TI2IAZUO2F6k6u4g1+ZFHxOLNp jjbEMV/BgVRhWV3M6cwtF7SFZ69raSZNPemHyhQ3XjCZ04czvHyLILYMwWAt/v7MID2pusEr NyMa/CLDadQbRaABeXqW6O6X6JycFbRFtR8997BFcaGGb8OcYvgTDG6puAhsVZi6I71JhEJ9 psCFBaoIG91ZVdb+bnVrFMuyvVJXjblSeBLwv5CCr4RpLpZq/yjxiclQ3IXVRCqp6kNR5dit Gl8pI8b0TZNjorq5/t/J/ALCu0nD3gyuK/DyUyA1vILCX6Gqhp3Ng1t2gBJI5sq3ZZrcYLhs mlNgF7uByLe1oqWuHRrL+MxP5+x7xyVlQRgr8bPfec7uS0a/Ip/NaYao9EKRq1Xr6k6R5cSB aZVxGTIY2539GttvdFSue6TaGT9irKqKdtK0rT6Hr+u2rm2ppuayv+vs9TaTNDovnG9J0Dco ZyF1BmKBHQEjhSfIxsww+29tmGfzLwFmXNj5CILUuuJXiJyy9A== Message-ID: Date: Sat, 9 Jun 2018 15:00:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <87fu1w16j1.fsf@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: de-DE Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31498 Cc: 31498@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > PS I was wrong about 'git send-email' being just as good as replying > with attachment. The bug tracker adds a "bug#xxxxx:" prefix, so I end > up getting duplicate emails. Next time someone asks I'll know what to > answer :) > Sorry, I think that was just because I manually added you to CC. I’ll skip that for the next time and we’ll see if it’s better, okay? :) From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 09 09:01:02 2018 Received: (at 31498) by debbugs.gnu.org; 9 Jun 2018 13:01:02 +0000 Received: from localhost ([127.0.0.1]:40440 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRdUL-00041W-Pk for submit@debbugs.gnu.org; Sat, 09 Jun 2018 09:01:02 -0400 Received: from lucaswerkmeister.de ([94.130.58.99]:35840) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRdUK-00041A-2o for 31498@debbugs.gnu.org; Sat, 09 Jun 2018 09:01:00 -0400 Received: from theoden.lucaswerkmeister.de.home (unknown [IPv6:2a02:8109:92c0:22bb:d412:2b0:339e:ab21]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mail@lucaswerkmeister.de) by lucaswerkmeister.de (Postfix) with ESMTPSA id E57D6399DDD; Sat, 9 Jun 2018 15:00:58 +0200 (CEST) Authentication-Results: lucaswerkmeister.de; dmarc=fail (p=none dis=none) header.from=lucaswerkmeister.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lucaswerkmeister.de; s=mail; t=1528549259; bh=dIWZNh5Tisf1ubjgHdZE3F7vgNCZKZXY/o/kZitBpnk=; h=From:To:Cc:Subject:Date:Message-Id:From:Reply-To:Subject:Date:To: Cc:In-Reply-To:References:Message-Id:Sender:Content-Type: Content-Transfer-Encoding:Content-Disposition:Mime-Version; b=fi/ptfHMMyChawlNsIOkjsGt9C9/NIWyiNs0xg8I1CDfG+TPqsY5DO6akB53UoVwK lw24l41ME+CZT3RDrVsVGcikYxErgA34Euw3N2dsXwEOfKlCaXnBc6w3RoEgtiiWU/ WO94crOHE63RP080spUt8RL9kB5V9wOgGPLivqfk= From: Lucas Werkmeister To: 31498@debbugs.gnu.org Subject: [PATCH] Notify systemd in daemon-initialized and kill-emacs Date: Sat, 9 Jun 2018 15:01:08 +0200 Message-Id: <20180609130108.20598-1-mail@lucaswerkmeister.de> X-Mailer: git-send-email 2.17.1 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31498 Cc: Lucas Werkmeister X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) With --[bg-]daemon and Type=forking, systemd will only consider the daemon to have fully started up once the original process exits, and will wait until then to start units depending on the Emacs service. To get the same functionality with --fg-daemon, use Type=notify instead of Type=simple and explicitly send a readiness notification to systemd at the point where the forked process would in --bg-daemon mode notify its parent process and cause it to exit. Similarly, notify systemd at the beginning of the shutdown process as well. (Both of these calls are successful no-ops if emacs was not started by systemd.) * etc/emacs.service: Update Type. * src/emacs.c (daemon-initialized) [HAVE_LIBSYSTEMD]: * src/emacs.c (kill-emacs) [HAVE_LIBSYSTEMD]: Call sd_notify(). --- etc/NEWS | 8 ++++++++ etc/emacs.service | 2 +- src/emacs.c | 11 +++++++++++ 3 files changed, 20 insertions(+), 1 deletion(-) diff --git a/etc/NEWS b/etc/NEWS index 4ea3440754..ba693e7e52 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -74,6 +74,14 @@ work right without some adjustment: - you can use the new 'package-quickstart' so activation of packages does not need to pay attention to 'package-load-list' or 'package-user-dir' any more. +--- +** Emacs now notifies systemd when startup finishes or shutdown begins. +Units that are ordered after 'emacs.service' will only be started +after Emacs has finished initialization and is ready for use. +(If your Emacs is installed in a non-standard location and you copied the +emacs.service file to eg ~/.config/systemd/user/, you will need to copy +the new version of the file again.) + * Changes in Emacs 27.1 diff --git a/etc/emacs.service b/etc/emacs.service index b29177b120..dbcb6bc301 100644 --- a/etc/emacs.service +++ b/etc/emacs.service @@ -7,7 +7,7 @@ Description=Emacs text editor Documentation=info:emacs man:emacs(1) https://gnu.org/software/emacs/ [Service] -Type=simple +Type=notify ExecStart=emacs --fg-daemon ExecStop=emacsclient --eval "(kill-emacs)" Environment=SSH_AUTH_SOCK=%t/keyring/ssh diff --git a/src/emacs.c b/src/emacs.c index 8633e934e5..cde20fc096 100644 --- a/src/emacs.c +++ b/src/emacs.c @@ -2017,6 +2017,10 @@ all of which are called before Emacs is actually killed. */ { int exit_code; +#ifdef HAVE_LIBSYSTEMD + sd_notify(0, "STOPPING=1"); +#endif /* HAVE_LIBSYSTEMD */ + /* Fsignal calls emacs_abort () if it sees that waiting_for_input is set. */ waiting_for_input = 0; @@ -2477,6 +2481,13 @@ from the parent process and its tty file descriptors. */) error ("This function can only be called after loading the init files"); #ifndef WINDOWSNT + if (daemon_type == 1) + { +#ifdef HAVE_LIBSYSTEMD + sd_notify(0, "READY=1"); +#endif /* HAVE_LIBSYSTEMD */ + } + if (daemon_type == 2) { int nfd; -- 2.17.1 From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 09 10:05:56 2018 Received: (at 31498) by debbugs.gnu.org; 9 Jun 2018 14:05:56 +0000 Received: from localhost ([127.0.0.1]:41412 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fReVA-0005iR-CO for submit@debbugs.gnu.org; Sat, 09 Jun 2018 10:05:56 -0400 Received: from mail-io0-f178.google.com ([209.85.223.178]:40189) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fReV9-0005iG-DO for 31498@debbugs.gnu.org; Sat, 09 Jun 2018 10:05:55 -0400 Received: by mail-io0-f178.google.com with SMTP id g22-v6so19044216iob.7 for <31498@debbugs.gnu.org>; Sat, 09 Jun 2018 07:05:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=z95lCdZrZStedBihVBiC3Vko+dIQoD+vAMQ6PV0fVLY=; b=bI1w5tyjwEAHvBu/0lB/GxBWSx+YxICq+vRylxr74abkJwHK684kvD/kdUcHCyYvpu zJJ2ZWjB3h436z3oi/7aWu5C94J7hTCn3vlKoo902guijdO5OPTv5zpi9LK1YG/hGl7E Z7an5uNTLiv49b+58y102FfMzpNXfRkq6fvkKLPLTKEE1WHSSpXPyINAopTc+KpgafHK Ijo8HqL7bNl5CB+Z37ecMmSxZGRjq/ynn1ZL4+XRoiQKrJIvCM3Fx7caQlkMBRHbJ6an zxrMGtIhkN/O3IKUU8i7DXjqY5v8FSix+vFvjARrD5hBzJjzIbYrXmtnvTRKUFqGb14m SC7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=z95lCdZrZStedBihVBiC3Vko+dIQoD+vAMQ6PV0fVLY=; b=IH4XnfEFxwL3GY1p8KP658ZIA+QoCslTYoC1TSVLb47VPZCP4MS9ZCYg4mxexz1+Ad oC6EQ34JFAKTJBcBmiPQRMRcxSFe0YBop0qwlMHV4yF6r4PeZmqhcaHhFPMoA/kWUUee FcJX32NR7zzYMRilRyhcWEo8bjw/5f+oTzCv/c7uGZTA5o39btfd1/DWgeZ/4vROLRDW FEaHZoXJeSIhoZi1DPS74tWR4X6SJ78qyBIH5BKRnHw96Vnip4uRhgFLTL0ocoXo3jTm lI7SVA4akJt8xzTlzpVr3Mmm7KS1X7PcR6ezpHnAZsnAkprsWdNKQ8znOkkfQ1a2mDQ9 e8kQ== X-Gm-Message-State: APt69E1CwLdOk0Ku4IJEzg+umtgEfatiMsahOmz1A9UY1mNchGNh9Snd R0gsyQv4QNLCeIgMpbau6qWHPw== X-Google-Smtp-Source: ADUXVKIFJLGXtXkZOmYArUz5IagZerExSjD5BsNB1lG4HN+eMdfoNe7Yjjg4eY3PGWTm4BMW9PeR6Q== X-Received: by 2002:a6b:106:: with SMTP id 6-v6mr8610292iob.175.1528553149748; Sat, 09 Jun 2018 07:05:49 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id l19-v6sm10254479ioh.27.2018.06.09.07.05.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 09 Jun 2018 07:05:49 -0700 (PDT) From: Noam Postavsky To: Lucas Werkmeister Subject: Re: bug#31498: [PATCH] Notify systemd in daemon-initialized and kill-emacs References: <20180518174031.12514-1-mail@lucaswerkmeister.de> <20180609105616.12927-1-mail@lucaswerkmeister.de> <87k1r816u5.fsf@gmail.com> <87fu1w16j1.fsf@gmail.com> Date: Sat, 09 Jun 2018 10:05:47 -0400 In-Reply-To: (Lucas Werkmeister's message of "Sat, 9 Jun 2018 15:00:15 +0200") Message-ID: <87d0x012dg.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31498 Cc: 31498@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lucas Werkmeister writes: >> PS I was wrong about 'git send-email' being just as good as replying >> with attachment. The bug tracker adds a "bug#xxxxx:" prefix, so I end >> up getting duplicate emails. Next time someone asks I'll know what to >> answer :) >>=20 > > Sorry, I think that was just because I manually added you to CC. I=E2=80= =99ll > skip that for the next time and we=E2=80=99ll see if it=E2=80=99s better,= okay? :) It's okay for this thread because I'm subscribed to the bug list, but in general, if there were non-subscribed people discussing the bug then they wouldn't have received the patch. Anyway, the latest patch looks good, please ping the thread again when the copyright stuff is done and I'll push to master. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 13 09:42:45 2018 Received: (at 31498) by debbugs.gnu.org; 13 Jun 2018 13:42:45 +0000 Received: from localhost ([127.0.0.1]:45876 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fT62v-0005fg-BN for submit@debbugs.gnu.org; Wed, 13 Jun 2018 09:42:45 -0400 Received: from lucaswerkmeister.de ([94.130.58.99]:60866) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fT62t-0005fY-Px for 31498@debbugs.gnu.org; Wed, 13 Jun 2018 09:42:44 -0400 Received: from [172.16.66.247] (p578a6e4c.dip0.t-ipconnect.de [87.138.110.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mail@lucaswerkmeister.de) by lucaswerkmeister.de (Postfix) with ESMTPSA id DA3B83A20F0 for <31498@debbugs.gnu.org>; Wed, 13 Jun 2018 15:42:42 +0200 (CEST) Authentication-Results: lucaswerkmeister.de; dmarc=fail (p=none dis=none) header.from=lucaswerkmeister.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lucaswerkmeister.de; s=mail; t=1528897362; bh=DxlzoHNnpA3jxD2zenvhPY7wtJdllbdM/mWonNeUAiQ=; h=Subject:To:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type:Content-Transfer-Encoding:From:Reply-To: Subject:Date:To:Cc:In-Reply-To:References:Message-Id:Sender: Content-Type:Content-Transfer-Encoding:Content-Disposition: Mime-Version; b=Z0RAK8ECiVKkPNoST7FLQ4KK5YLexn9XFNKbOD370HwonFbMY1cOsM+zVp5zlsQLB pxgnzb2Zlicb+Qi/9FyKx6KNsPn98QyNh5wMwfeILsggyxqzWvNoaqkp08b1O91M0C +cxp3naRwu2xVo6/bUTUfD2UKkmTM3NgEnDWTU8o= Subject: Re: bug#31498: [PATCH] Notify systemd in daemon-initialized and kill-emacs To: 31498@debbugs.gnu.org References: <20180518174031.12514-1-mail@lucaswerkmeister.de> <20180609105616.12927-1-mail@lucaswerkmeister.de> <87k1r816u5.fsf@gmail.com> <87fu1w16j1.fsf@gmail.com> <87d0x012dg.fsf@gmail.com> From: Lucas Werkmeister Message-ID: <8e115f58-c6ef-76e1-05c5-25725b74f7c3@lucaswerkmeister.de> Date: Wed, 13 Jun 2018 15:42:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <87d0x012dg.fsf@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31498 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 09.06.2018 16:05, Noam Postavsky wrote:> Anyway, the latest patch looks good, please ping the thread again when > the copyright stuff is done and I'll push to master. > I think it’s done now, I just received a signed copy of the assignment document (dated June 8th). From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 13 12:34:13 2018 Received: (at 31498) by debbugs.gnu.org; 13 Jun 2018 16:34:13 +0000 Received: from localhost ([127.0.0.1]:46807 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fT8iq-0005Ip-Q3 for submit@debbugs.gnu.org; Wed, 13 Jun 2018 12:34:12 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35120) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fT8ip-0005Ic-28 for 31498@debbugs.gnu.org; Wed, 13 Jun 2018 12:34:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fT8ie-0000xL-SS for 31498@debbugs.gnu.org; Wed, 13 Jun 2018 12:34:06 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56596) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fT8ie-0000wk-Nl; Wed, 13 Jun 2018 12:34:00 -0400 Received: from [176.228.60.248] (port=1637 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fT8ie-0007ZC-27; Wed, 13 Jun 2018 12:34:00 -0400 Date: Wed, 13 Jun 2018 19:33:57 +0300 Message-Id: <83efha4pe2.fsf@gnu.org> From: Eli Zaretskii To: Lucas Werkmeister In-reply-to: <8e115f58-c6ef-76e1-05c5-25725b74f7c3@lucaswerkmeister.de> (message from Lucas Werkmeister on Wed, 13 Jun 2018 15:42:41 +0200) Subject: Re: bug#31498: [PATCH] Notify systemd in daemon-initialized and kill-emacs References: <20180518174031.12514-1-mail@lucaswerkmeister.de> <20180609105616.12927-1-mail@lucaswerkmeister.de> <87k1r816u5.fsf@gmail.com> <87fu1w16j1.fsf@gmail.com> <87d0x012dg.fsf@gmail.com> <8e115f58-c6ef-76e1-05c5-25725b74f7c3@lucaswerkmeister.de> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31498 Cc: 31498@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Lucas Werkmeister > Date: Wed, 13 Jun 2018 15:42:41 +0200 > > On 09.06.2018 16:05, Noam Postavsky wrote:> Anyway, the latest patch > looks good, please ping the thread again when > > the copyright stuff is done and I'll push to master. > > > > I think it’s done now, I just received a signed copy of the assignment > document (dated June 8th). Your assignment is not yet on file, so let's please wait a few more days for it to appear, which is a sign for us that the paperwork is complete. From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 12 18:20:19 2018 Received: (at 31498) by debbugs.gnu.org; 12 Jul 2018 22:20:19 +0000 Received: from localhost ([127.0.0.1]:57505 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fdjwh-0001V7-Fi for submit@debbugs.gnu.org; Thu, 12 Jul 2018 18:20:19 -0400 Received: from lucaswerkmeister.de ([94.130.58.99]:34698) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fdjwg-0001Uz-64 for 31498@debbugs.gnu.org; Thu, 12 Jul 2018 18:20:18 -0400 Received: from theoden.lucaswerkmeister.de (unknown [IPv6:2a02:8109:92c0:22bb:d412:2b0:339e:ab21]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mail@lucaswerkmeister.de) by lucaswerkmeister.de (Postfix) with ESMTPSA id 54FC944872E for <31498@debbugs.gnu.org>; Fri, 13 Jul 2018 00:20:15 +0200 (CEST) Authentication-Results: lucaswerkmeister.de; dmarc=fail (p=none dis=none) header.from=lucaswerkmeister.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lucaswerkmeister.de; s=mail; t=1531434016; bh=JisKw/3Lr+mvyOd7+xdvhAiOUsnvrCpdncO3jLQKo24=; h=To:From:Subject:Message-ID:Date:MIME-Version:Content-Type: Content-Transfer-Encoding:From:Reply-To:Subject:Date:To:Cc: In-Reply-To:References:Message-Id:Sender:Content-Type: Content-Transfer-Encoding:Content-Disposition:Mime-Version; b=WAI1X0NCG3FiF7ep/gRTqwTZ2Q9eoJbexjOhdXNab+dv0lCZh/IBpiCm/ab+t7Xdq mkhTE03Qv1hIDbxzYO7knZCveH4Cf8cwfRVCHAgio77i4Mf2TiXcx1TU/h53gLWPuA 9xAzU5VtLauryCavCSvq5lHnztXmG8O2vGcRLLbo= To: 31498@debbugs.gnu.org From: Lucas Werkmeister Subject: Re: bug#31498: [PATCH] Notify systemd in daemon-initialized and, kill-emacs Openpgp: preference=signencrypt Autocrypt: addr=mail@lucaswerkmeister.de; prefer-encrypt=mutual; keydata= xsFNBFKkO1oBEACXP/JGIJsKiXsA866Ak439ZIaU5xNss6V2QoOQBSj6848kkxhDLEbfgVYW 4meXYpYJV9P2Vk0PC2kQWadqbvqhfP7OomlIlZzlpvbi2xbjW4tr09brY7d7GvMcplh5igYS gWo5J/6+4ZDgVj+TG0OuvkTDZmJmHhrwDuIsvh3KDJhT0z6t43qzQ69Efse/OjJRpWha5nZt fvtdBCI/v2Pq6pJrPx1g1u/BKArRcrrWLpCRQRbFwrQ1MsIkj8Wzz1tKjulGUSPIXvvssxYA /3BQEniMKzxbkZlhi4DUe5WJZWFS6BWaS+Qbwd0bq2WaCD/PFddjHN6qWAxxPY2rvP7C+Lj7 FQiHLbeMi2K0hiMEsUUsORq/A0LjG84RSwhic2a6cvszj9b6WRmRUb1PMMxcNCjCzebkdZeL RWrqhCnMU+rxQJ+qib5rbYCjvpV2hWzlXcvjaW2B32jUAhG3sDK6Cd4A+Ao7gJPv1KzdvqZj Aoo5/5RI1Er5EYkhcjGAc0N/VWnOq5WDuL4CdeamIwMyOlI42npbzKsHhlb5nXPeFl7eEOdZ RVKs3yuE3/23XpWisjKUk9tUpGBHi098rPPnbA4T9P7ZwWNwo8j4Bh8D71nC+JJ1ue92NzSi T9E7ckdSIatPl5rJIEjvf9pZB4YUugGM06JdlYakVVZZHLXFgQARAQABzSxMdWNhcyBXZXJr bWVpc3RlciA8bWFpbEBsdWNhc3dlcmttZWlzdGVyLmRlPsLBmAQTAQoAQgIbAwYLCQgHAwIG FQgCCQoLBBYCAwECHgECF4ACGQEWIQRriVuLEaR1seyTFpj8Rihycq4yPwUCWK8aSwUJGNbh 8QAKCRD8Rihycq4yP/FSD/45wEQTFrMYzti+9B4/4c4GpGajT2HEw5YxKL/Gcifu3mwMrQLn uxbCtuuBLtmOt1W13c+MBFVu2fals6fABlTev7Ikh7NSu6APA3XBpgk/ckJHwOaPPRGp8GDD N3UmDBOXd/mzWK2Zz+m1iU0xpcd4Td34TkOa/qYFqCmY5SZILFRzpgZ9QNZEBQBOGwwvvnax rIKVpH5Vgghp9WBDtElOM9cFH8uq1IOXob/nRsxwAC1kEB04uMneA+Xm4T7KhJ+0QKCNe54s BxK6SI54mEpy8cfyVr3oopM8uDcj014ebxsbrvQmcC8AI8ptt+BwgCl4kO033qhc0ll5kRXB EDtbvTDVf6OafLNECaWxxWnYadxVLOfbTaHMjdGyqA7GLmOL+Wcb/uZpW1sFnpMSAeGTBvap jXmjxNleJThHviD/WqR218yZevvWcA1XvgAObYwGiNF8KbOzKw8oUUp/nzMZYL0JN85gUDDa ef28x/2spQEtDs9zlTZxioHogVNVOzGlt+7Sm23RzE0aU/f14nahI2g8/179e5B4Nv10lO8d 8ZiQ663n42ODZju5iqVYvIkBlqVYliGxd7dgJLX9D5Qo65a62BhKuLQclyYBVVuoe4+HsUET wfshMFAAnGPWbWM6ZY96+XQ1tnyWKKTaosGJ1XwNwuZA31rCwruWtW2JxM7BTQRSpDtaARAA 6s6WSxIWC4NuNiYSUTIaqOTkYnv2w9ME/3WF/o/F50eBY5ko+5tll7dLQDH1SKtReqFc2ZnY AIXkFSAkbweu+7VxEcosPKP67xUGJyCAGikCgW7uVFSsnVyOPSpt4GixQjq6p4NxOMGpnxCk cy9pTwBudMwSE1j/NF0SVDFYChKo9OR5eyetHuHzglGdBjE/izu//gMY5JOgZEfz4MqDL8Vw ypK+w1qTI7t7rQAme1Ia+7shxv5+gCJMH/IJL4RL8lQ2uEFbUpJ6KiJhpAhf4CrMTPkZxxs2 x3mfcUDW7YZW9r8n2iUrVkzVHCEvbN7PRREf3LeiBF8eZKM5GcimtMgriit9Vv6DbpK8r9/2 QJeGyblN9kk97GLQ2IG0PzrpLcn1/0aTJcwqFvA3phG2baY2M0FMdvJW1G9EjJsQAvwvCFAs m7v4xxzmyADnPJjqWCe0EqOBuoYrjEOf8Hd7LsnoSHdsIuIQiyY3SQ9Et6d/lTiUFYcwAtXI 0xhDEcBKjp5mBo19OBPKR0HvlhEMwyikoUkTl4Hf3ZVa2ohNZ3g8xE0oDFaBwnSW/GYtLBqd uOhk8yoWyGN7gIv7Bgquwq1uCE2UtBI9kYCM9Oscp/Zu8pmYe44p/8SpCPA5G7Vsjmf4ax2S +Fazd1lvIKgRIu4QozBMhlMOgpQsErDpwD0AEQEAAcLBXwQYAQIACQUCUqQ7WgIbDAAKCRD8 Rihycq4yP/QeEACDfzBFA2RBpAEuuJm89v53NA5vfmuy2LZxnwez+tc1/PjRdyZAU+/GcYd5 QGLcTfDkrrLqbCWrQ09044ObCJeY8gdF4wFTGP1kpCHeLBrS5ZKLUoBQNbbBG+vJn6iDcpJV qHwG+3HoC79cj0g2Bi09x/c8F5Zg1m4gcnZFfwRSxIyUk+TI2IAZUO2F6k6u4g1+ZFHxOLNp jjbEMV/BgVRhWV3M6cwtF7SFZ69raSZNPemHyhQ3XjCZ04czvHyLILYMwWAt/v7MID2pusEr NyMa/CLDadQbRaABeXqW6O6X6JycFbRFtR8997BFcaGGb8OcYvgTDG6puAhsVZi6I71JhEJ9 psCFBaoIG91ZVdb+bnVrFMuyvVJXjblSeBLwv5CCr4RpLpZq/yjxiclQ3IXVRCqp6kNR5dit Gl8pI8b0TZNjorq5/t/J/ALCu0nD3gyuK/DyUyA1vILCX6Gqhp3Ng1t2gBJI5sq3ZZrcYLhs mlNgF7uByLe1oqWuHRrL+MxP5+x7xyVlQRgr8bPfec7uS0a/Ip/NaYao9EKRq1Xr6k6R5cSB aZVxGTIY2539GttvdFSue6TaGT9irKqKdtK0rT6Hr+u2rm2ppuayv+vs9TaTNDovnG9J0Dco ZyF1BmKBHQEjhSfIxsww+29tmGfzLwFmXNj5CILUuuJXiJyy9A== Message-ID: <16178ba9-c8d5-ee19-5ecb-ac734237c676@lucaswerkmeister.de> Date: Fri, 13 Jul 2018 00:20:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: de-DE Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31498 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Any news on the copyright status? I haven’t received any further emails from the FSF on this, so if there’s anything I still need to do, please let me know :) From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 13 02:58:54 2018 Received: (at 31498) by debbugs.gnu.org; 13 Jul 2018 06:58:55 +0000 Received: from localhost ([127.0.0.1]:57609 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fds2Y-0007UN-N5 for submit@debbugs.gnu.org; Fri, 13 Jul 2018 02:58:54 -0400 Received: from eggs.gnu.org ([208.118.235.92]:56015) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fds2X-0007UB-Qf for 31498@debbugs.gnu.org; Fri, 13 Jul 2018 02:58:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fds2P-0006nW-A9 for 31498@debbugs.gnu.org; Fri, 13 Jul 2018 02:58:48 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58027) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fds2P-0006nQ-5j; Fri, 13 Jul 2018 02:58:45 -0400 Received: from [176.228.60.248] (port=4483 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fds2O-0001yT-I9; Fri, 13 Jul 2018 02:58:44 -0400 Date: Fri, 13 Jul 2018 09:58:47 +0300 Message-Id: <83d0vrei54.fsf@gnu.org> From: Eli Zaretskii To: Lucas Werkmeister In-reply-to: <16178ba9-c8d5-ee19-5ecb-ac734237c676@lucaswerkmeister.de> (message from Lucas Werkmeister on Fri, 13 Jul 2018 00:20:15 +0200) Subject: Re: bug#31498: [PATCH] Notify systemd in daemon-initialized and, kill-emacs References: <20180518174031.12514-1-mail@lucaswerkmeister.de> <16178ba9-c8d5-ee19-5ecb-ac734237c676@lucaswerkmeister.de> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31498 Cc: 31498@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Lucas Werkmeister > Date: Fri, 13 Jul 2018 00:20:15 +0200 > > Any news on the copyright status? I haven’t received any further emails > from the FSF on this, so if there’s anything I still need to do, please > let me know :) Please ping the copyright clerk. Your name is still not on file. Sorry for the delay. From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 25 08:03:09 2018 Received: (at 31498) by debbugs.gnu.org; 25 Jul 2018 12:03:09 +0000 Received: from localhost ([127.0.0.1]:56331 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fiIVZ-0002V9-5N for submit@debbugs.gnu.org; Wed, 25 Jul 2018 08:03:09 -0400 Received: from lucaswerkmeister.de ([94.130.58.99]:37300) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fiIVX-0002V0-80 for 31498@debbugs.gnu.org; Wed, 25 Jul 2018 08:03:07 -0400 Received: from [172.16.66.247] (p578a6e4c.dip0.t-ipconnect.de [87.138.110.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mail@lucaswerkmeister.de) by lucaswerkmeister.de (Postfix) with ESMTPSA id B9D6646041F for <31498@debbugs.gnu.org>; Wed, 25 Jul 2018 14:03:05 +0200 (CEST) Authentication-Results: lucaswerkmeister.de; dmarc=fail (p=none dis=none) header.from=lucaswerkmeister.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lucaswerkmeister.de; s=mail; t=1532520185; bh=8AdFmGXdKELr9ZWch324zSAuX4U0AfBUpHbNjXXIBys=; h=To:From:Subject:Message-ID:Date:MIME-Version:Content-Type: Content-Transfer-Encoding:From:Reply-To:Subject:Date:To:Cc: In-Reply-To:References:Message-Id:Sender:Content-Type: Content-Transfer-Encoding:Content-Disposition:Mime-Version; b=oYvsLNL2/xhhx1jBcsdKv+bZyCWI7/YWct0BO1CElaGEtSiV8gmNfeK/e1nSSArRn uc3fU72BJ+CeoRHXCrQdwu+Z71XKiJ/eFez5WW1JZJCrGU7/eHOslgrQtKTa730nJg CPMOIy+j0cNvVBkw+6AilBeWAUCzJHOX/p3dsDkM= To: 31498@debbugs.gnu.org From: Lucas Werkmeister Subject: Re: bug#31498: [PATCH] Notify systemd in daemon-initialized and,, kill-emacs Message-ID: <9357f81a-2bf4-acfd-3743-1616b6062dd0@lucaswerkmeister.de> Date: Wed, 25 Jul 2018 14:03:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31498 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) I’ve been notified that my name should be on the file now. From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 25 10:48:42 2018 Received: (at 31498) by debbugs.gnu.org; 25 Jul 2018 14:48:42 +0000 Received: from localhost ([127.0.0.1]:57344 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fiL5m-0007c4-5l for submit@debbugs.gnu.org; Wed, 25 Jul 2018 10:48:42 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60757) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fiL5j-0007br-Mr for 31498@debbugs.gnu.org; Wed, 25 Jul 2018 10:48:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fiL5b-0007b9-MH for 31498@debbugs.gnu.org; Wed, 25 Jul 2018 10:48:34 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58428) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fiL5b-0007b5-Hk; Wed, 25 Jul 2018 10:48:31 -0400 Received: from [176.228.60.248] (port=1147 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fiL5a-00017g-VJ; Wed, 25 Jul 2018 10:48:31 -0400 Date: Wed, 25 Jul 2018 17:48:28 +0300 Message-Id: <83wotjtlqb.fsf@gnu.org> From: Eli Zaretskii To: Lucas Werkmeister In-reply-to: <9357f81a-2bf4-acfd-3743-1616b6062dd0@lucaswerkmeister.de> (message from Lucas Werkmeister on Wed, 25 Jul 2018 14:03:08 +0200) Subject: Re: bug#31498: [PATCH] Notify systemd in daemon-initialized and, , kill-emacs References: <20180518174031.12514-1-mail@lucaswerkmeister.de> <9357f81a-2bf4-acfd-3743-1616b6062dd0@lucaswerkmeister.de> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31498 Cc: 31498@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Lucas Werkmeister > Date: Wed, 25 Jul 2018 14:03:08 +0200 > > I’ve been notified that my name should be on the file now. Indeed, it is. From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 25 21:14:00 2018 Received: (at 31498) by debbugs.gnu.org; 26 Jul 2018 01:14:00 +0000 Received: from localhost ([127.0.0.1]:57887 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fiUqu-000840-BT for submit@debbugs.gnu.org; Wed, 25 Jul 2018 21:14:00 -0400 Received: from mail-io0-f178.google.com ([209.85.223.178]:34710) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fiUqs-00083h-6q; Wed, 25 Jul 2018 21:13:58 -0400 Received: by mail-io0-f178.google.com with SMTP id l7-v6so42442ioj.1; Wed, 25 Jul 2018 18:13:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=LkUPULifwHdXX2i2Elb81/E4x7+I14U96o1U+VgZQXE=; b=LiU8l2TJ3y546I/nqzFrNCL9iUBI0as/qm4j0t2x75QhclabgRnt3hMq/PwRagqMZj QrMwsjxR0qBwjOQTbigF14ngX2JwDnOrz1HhJVtphPjEhqSRswlhZ8bDLeJASxhu/qP3 06jWnARqgzF2rMT/0T43X/l6iYOJfwoAXNyyKcctuCtOjINrTLKUmkO3ppssBfXyqIS8 OEN1/RlwanNVu28uS5nbR/gEXvhSyqnTcwcu+EekfoGcpA0/KSnWVTozJTXdRfwp5Ihl OThEr0XPiX75/SSGT2F2FJuMSzd12A3kHbnhVJ06WNykCmUVNJS9EanA+5DcE4Kz5qPd nMnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=LkUPULifwHdXX2i2Elb81/E4x7+I14U96o1U+VgZQXE=; b=PcDH4UH07TyIWuYZYwgx73NnxIMvko3pDzPJRsguBwpspSDykjgjjSgo3O8mDZEF0p VPzQmnz6SIng50cvWR8izBepjZQin7O9e5ITb9M/N7zOyBmkWVDovKH+Hs2dc+W42SMY 75hra74XpZnZc80VgAYGFVk2TzSDkB4+z81p0qP4TG6Nnjw0N1xjFohJ98WM3QXtvz4h DmQ/gxT6NA8SPhxEWj3BvtH4f9ULYUKE/Pvdfat7iJiG6A5py1IjzUZWqPmbKnd99GSW 89l84/PA1G9H2fMXHwuNDbwxs7jDvfoULK0Zgb++hsjgq6ChfpGYPkoPzizKjsgOp+tf x2Ow== X-Gm-Message-State: AOUpUlHVoXZWW8aH1UJYqwJfgv+k5IuJ7XF+hBkMdMVYgkww58EMybQT 79g2IwsQSLBDSEOYhfrZ1r9YNzTd X-Google-Smtp-Source: AAOMgpccjVCd4TPCaWDCYTwlojKHTQNmMLAaesUVmz1xSuRvlJb2RX0elFg5SGe7CI61ozK9h7WKLQ== X-Received: by 2002:a6b:e403:: with SMTP id u3-v6mr9359212iog.131.1532567632510; Wed, 25 Jul 2018 18:13:52 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id e2-v6sm4587095ioa.33.2018.07.25.18.13.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Jul 2018 18:13:51 -0700 (PDT) From: Noam Postavsky To: Eli Zaretskii Subject: Re: bug#31498: [PATCH] Notify systemd in daemon-initialized and, , kill-emacs References: <20180518174031.12514-1-mail@lucaswerkmeister.de> <9357f81a-2bf4-acfd-3743-1616b6062dd0@lucaswerkmeister.de> <83wotjtlqb.fsf@gnu.org> Date: Wed, 25 Jul 2018 21:13:50 -0400 In-Reply-To: <83wotjtlqb.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 25 Jul 2018 17:48:28 +0300") Message-ID: <871sbq4x4h.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31498 Cc: 31498@debbugs.gnu.org, Lucas Werkmeister X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) merge 31498 31521 tags 31498 fixed close 31498 27.1 quit Eli Zaretskii writes: >> From: Lucas Werkmeister >> Date: Wed, 25 Jul 2018 14:03:08 +0200 >>=20 >> I=E2=80=99ve been notified that my name should be on the file now. > > Indeed, it is. I've pushed to master. [1: 19f5f7b19b]: 2018-07-25 21:07:03 -0400 Notify systemd in daemon-initialized and kill-emacs (Bug#31498) https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3D19f5f7b19b0dcdae= 87476a3fd51c41f840b2b80f From unknown Sat Sep 20 00:09:08 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 23 Aug 2018 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator