Subject: [bug#31494] [PATCH] gnu: gifsicle: New variable.

From: [email-masked] (Ludovic Courtès)
Date: Sat, 19 May 2018 22:46:48 +0200

Hi,

Pierre Neidhardt <[email-masked]> skribis:

> * gnu/packages/image.scm (gifsicle): New variable.

Copyright line please.  :-)

> +   (build-system gnu-build-system)
> +   ;; TODO: Tests fail with "undefined error at undefined point in script".
> +   ;; They pass when run manually with
> +   ;;   guix environment gifsicle -- ./test/testie -p src/ test/
> +   (arguments '(#:tests? #f))
> +   ;; (arguments
> +   ;;  '(#:phases
> +   ;;    (modify-phases %standard-phases
> +   ;;      (add-before 'check 'patch-tests
> +   ;;        (lambda _
> +   ;;          (substitute* "test/testie"
> +   ;;            (("/usr/bin/perl")
> +   ;;             (which "perl"))
> +   ;;            (("/bin/rm")
> +   ;;             (which "rm"))))))))
> +   ;; (native-inputs `(("perl" ,perl))) ; Only for tests.

Could the test failures be caused by other hardcoded file names (like
“/bin/sh”)?  If they pass in ’guix environment’ that may well be the
reason.

> +   (inputs `(("libx11" ,libx11)))
> +   (home-page "http://www.lcdf.org/gifsicle/")
> +   (synopsis "Create, edit, manipulate and get information about GIF images and animations")

To shorten a bit, what about: “Edit GIF images and animations”?

> +   (description "Some Gifsicle features:
> +- Batch mode for changing GIFs in place.
> +- Prints detailed information about GIFs, including comments.
> +- Control over interlacing, comments, looping, transparency...
> +- Creates well-behaved GIFs: removes redundant colors, only uses local color
> +tables if it absolutely has to (local color tables waste space and can cause
> +viewing artifacts), etc.
> +- It can shrink colormaps and change images to use the Web-safe palette (or
> +any colormap you choose).
> +- Optimize your animations! This stores only the changed portion of each
> +frame, and can radically shrink your GIFs. You can also use transparency to
> +make them even smaller. Gifsicle's optimizer is pretty powerful, and usually
> +reduces animations to within a couple bytes of the best commercial optimizers.
> +- Unoptimizing animations, which makes them easier to edit.
> +
> +Two other programs are included with Gifsicle: @code{gifview} is a lightweight
> +animated-GIF viewer which can show animations as slideshows or in real time,
> +and @code{gifdiff} compares two GIFs for identical visual appearance. ")

Please @itemize and full sentences.

Could you send an updated patch?

Thank you!

Ludo’.