GNU bug report logs - #31490
[PATCH] gnu: Add emacs-cmake-mode.

Previous Next

Full log

Message #34 received at 31490 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Oleg Pykhalov <go.wigust <at> gmail.com>,
 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 31490 <at> debbugs.gnu.org, 31490-done <at> debbugs.gnu.org
Subject: Re: bug#31490: [PATCH] gnu: Add emacs-cmake-mode.
Date: Tue, 22 May 2018 17:21:28 +0200

[Message part 1 (text/plain, inline)]

Oleg Pykhalov <go.wigust <at> gmail.com> writes:

> Maxim Cournoyer <maxim.cournoyer <at> gmail.com> writes:
>
> […]
>
>>> +             (substitute* "Auxiliary/CMakeLists.txt"
>>> +               (("install\\(FILES cmake-mode.el \
>>> +DESTINATION \\$\\{CMAKE_DATA_DIR\\}/editors/emacs\\)") ""))))
>>
>> Nitpick: I'd use a regexp to match the text following cmake-mode.el on
>> the line to make it more resilient to any future changes. Otherwise this
>> LGTM :)
>
> Agree, pushed as f037673c3133ae7453794f1f62eecebf9d06b092

'core-updates' is currently live on Hydra:

https://hydra.gnu.org/jobset/gnu/core-updates

Since we already have substitutes for CMake and many dependents, this
commit will have to wait until the next rebuild cycle.  Can you revert
it on 'core-updates' and resubmit the patch to 'core-updates-next'?

PS: Please also end the phase on #t ;-)

Thanks!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.