From unknown Sat Jun 21 05:18:28 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#31490] [PATCH] gnu: Add emacs-cmake-mode. Resent-From: Oleg Pykhalov Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 18 May 2018 12:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 31490 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 31490@debbugs.gnu.org Cc: Oleg Pykhalov X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.15266464743046 (code B ref -1); Fri, 18 May 2018 12:28:01 +0000 Received: (at submit) by debbugs.gnu.org; 18 May 2018 12:27:54 +0000 Received: from localhost ([127.0.0.1]:39260 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fJeUD-0000n4-O1 for submit@debbugs.gnu.org; Fri, 18 May 2018 08:27:54 -0400 Received: from eggs.gnu.org ([208.118.235.92]:56585) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fJeUB-0000mp-NF for submit@debbugs.gnu.org; Fri, 18 May 2018 08:27:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fJeU5-0006Qb-IH for submit@debbugs.gnu.org; Fri, 18 May 2018 08:27:46 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:38255) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fJeU5-0006QS-EW for submit@debbugs.gnu.org; Fri, 18 May 2018 08:27:45 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47556) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fJeU4-0002CD-Ac for guix-patches@gnu.org; Fri, 18 May 2018 08:27:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fJeU1-0006O9-5R for guix-patches@gnu.org; Fri, 18 May 2018 08:27:44 -0400 Received: from mail-wm0-x232.google.com ([2a00:1450:400c:c09::232]:38251) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fJeU0-0006NO-Uq for guix-patches@gnu.org; Fri, 18 May 2018 08:27:41 -0400 Received: by mail-wm0-x232.google.com with SMTP id m129-v6so14791857wmb.3 for ; Fri, 18 May 2018 05:27:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=ug5U0N+yqYdrHoKJdt0WERhGWd7qbVcEfQwhZqAZSgw=; b=trYyF2l2hmVaNVzUYm39aYZyKSDIuIRyMTMwXszGtlYY0bo6MovIepjkx3Dee5fs9V 8vOfKGBAZecwKJuhtSw2zXp1znLOmBIM9c9cBposqSgv0mV/hqTgd1jS5wKPfV7m5Auo pRS3BN/0qvpSDefvH+C2mqAmWCuEvWyCPdBu6l+DwSyL3dMZg4aDdi0hmFOfi75DcDgw sRJRbW4/fT+hvJKVec5Cn26vkzPk1/xEaRADpuF4/vEIOVB9GY2sxt9hb3zm8aVCwXdM uj0IdjTWjtDZuZ441MJ9jAQ21lLgy4BZJiFplCw1ul8cqk1ksLhu//ZWW8NriWz3VI3y q3yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=ug5U0N+yqYdrHoKJdt0WERhGWd7qbVcEfQwhZqAZSgw=; b=drEnQV8wH60MF0H23KxUki5qaJCBPEQ6uaUK3U+z+Y8OhDHhkOri3rmrIm4CPHLOXZ dWolKRw6yeFcRGDGkOLnNAOK/EtQHIGAXMjGfFenpzBTmoVwmW1obuJTw6hE9HGTxPtb RXjZg8BXZ/1K81DMmkc5l9hiEyYzaFOIrdNq1g+fEtXg1NOSbkJfofUkJ8OxqqoYEdcn YwApI0621n46lYIIfjfJyFOjNXpQi+xY5AhI1KSCe0/N6HJeF/0R4RGKYD/GTki21l+p J54b6ZdyUTskOX9Rj+BkbXBU8VG6cClxHbMpoOEKhy3DQmcBuz1Y9w/qF9pmZ0L7cL/y 9l2g== X-Gm-Message-State: ALKqPwfs59amlv2Gk1UYiM4CpFFEH6sg9w2v832S/qzycKkz18SgW1H5 E1mFYJpHB3u0FhkI7bxbKCS8yQ== X-Google-Smtp-Source: AB8JxZoxm5R6wNFvwj/08HWACWcxUpywnSurJZgOQ6OgD3aFhkmaIy1T36K4dKgnImR+na/4x3H0aQ== X-Received: by 2002:a50:c8cb:: with SMTP id k11-v6mr11602847edh.94.1526646459236; Fri, 18 May 2018 05:27:39 -0700 (PDT) Received: from localhost.localdomain ([178.71.236.98]) by smtp.gmail.com with ESMTPSA id y7-v6sm3599181edq.8.2018.05.18.05.27.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 May 2018 05:27:38 -0700 (PDT) From: Oleg Pykhalov Date: Fri, 18 May 2018 15:27:16 +0300 Message-Id: <20180518122716.9272-1-go.wigust@gmail.com> X-Mailer: git-send-email 2.17.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) * gnu/packages/cmake.scm (emacs-cmake-mode): New public variable. --- gnu/packages/cmake.scm | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/gnu/packages/cmake.scm b/gnu/packages/cmake.scm index e6c5c4e79..eba7a92c0 100644 --- a/gnu/packages/cmake.scm +++ b/gnu/packages/cmake.scm @@ -206,3 +206,20 @@ and workspaces that can be used in the compiler environment of your choice.") (inputs `(("rhash" ,rhash) ,@(package-inputs cmake))))) + +(define-public emacs-cmake-mode + (package + (inherit cmake) + (name "emacs-cmake-mode") + (build-system emacs-build-system) + (arguments + `(#:phases + (modify-phases %standard-phases + (add-after 'unpack 'chdir-elisp + ;; Elisp directory is not in root of the source. + (lambda _ + (chdir "Auxiliary")))))) + (synopsis "Emacs major mode for editing Cmake expressions") + (description "@code{cmakeos-mode} provides an Emacs major mode for editing +Cmake files. It supports syntax highlighting, indenting and refilling of +comments."))) -- 2.17.0 From unknown Sat Jun 21 05:18:28 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#31490] [PATCH] gnu: Add emacs-cmake-mode. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 18 May 2018 13:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31490 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 31490@debbugs.gnu.org, go.wigust@gmail.com X-Debbugs-Original-To: guix-patches@gnu.org, Oleg Pykhalov , 31490@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.15266493877647 (code B ref -1); Fri, 18 May 2018 13:17:02 +0000 Received: (at submit) by debbugs.gnu.org; 18 May 2018 13:16:27 +0000 Received: from localhost ([127.0.0.1]:39294 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fJfFC-0001zH-TP for submit@debbugs.gnu.org; Fri, 18 May 2018 09:16:27 -0400 Received: from eggs.gnu.org ([208.118.235.92]:39089) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fJfFB-0001z5-Q2 for submit@debbugs.gnu.org; Fri, 18 May 2018 09:16:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fJfF2-0001Ko-Fu for submit@debbugs.gnu.org; Fri, 18 May 2018 09:16:20 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:47970) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fJfF2-0001KV-Cd for submit@debbugs.gnu.org; Fri, 18 May 2018 09:16:16 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58243) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fJfEx-0006w5-7i for guix-patches@gnu.org; Fri, 18 May 2018 09:16:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fJfEr-00018O-7O for guix-patches@gnu.org; Fri, 18 May 2018 09:16:11 -0400 Received: from mail-it0-x242.google.com ([2607:f8b0:4001:c0b::242]:39679) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fJfEr-00017q-2H for guix-patches@gnu.org; Fri, 18 May 2018 09:16:05 -0400 Received: by mail-it0-x242.google.com with SMTP id c3-v6so13048291itj.4 for ; Fri, 18 May 2018 06:16:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:in-reply-to:references:mime-version:content-transfer-encoding :subject:to:from:message-id; bh=rnz/gcoUUDXLlWx9+ZzNF6TQC6h4r6qp0pZ/YgpXqTg=; b=Bi4//ODDzFFd9opnkaa5y9fp8ctN3L0FQJsmmrsB7ETIkHQVS36aN4q/QbR22pmXnN +B/iunZiSDTEuNMjLyXrpOluBljYlP57I2gJGYaxaB/iDXT8tNueSSqI4+qe0rgumqSE OfqKiwpoQsMfOdW/AvJy4VC5JP2ZbgQwFgWMs8MMi8JLvKkZCMikH7WYqy5nzw5zpM2V 4LVqtraruyQrnnUFRYRCmD+8NPt5X+IB/SBh8CGO/3WktWurKJPIChP2QERn/oWFCkQz LpoTU4vyi4n4xl3tsN1vHdTwT2Fp8C3gaVvotqw+AbDcOHDwptgioiO2i/6f+E0o4nlK a12g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:references:mime-version :content-transfer-encoding:subject:to:from:message-id; bh=rnz/gcoUUDXLlWx9+ZzNF6TQC6h4r6qp0pZ/YgpXqTg=; b=dh/A6v3lTIZz6J4q72Y7ifOKOwK8BlGXHNJ2sPZGYwGmPeoOMQMXgFbRfcu5vJZEiH Gh+JzM1GZYMltpjUwqXM6+dIjYDsb1Kg4b1SESk56IRwbdGrbMzUi7hnd78G3jzSLjd2 DKiuCh1Nki1GCu8ix/dkPMslChPALosPWJf1wsu0RvKYpAWcUwaoygrKjiiHjI73HcuC bj7pjappaFozAVOmbrBIENPobhLirEgk4vGIUYlRGnAFLNEjde35wLYeCmM7K+ZMRFk4 0L0hg+CJhu856McMKqAcR4sQfLvdWpXbXUgTytXbH11mCaU5xz6Y81SlL2uNrEOkkpJ7 XxjQ== X-Gm-Message-State: ALKqPwevX64gaUxiPwTyY32cDiTgeZgC2p/ENUuA1UKv+7P2T9vF/J5u fa1vWlbl3CfMaGmdjG0vggTr+QFapgA= X-Google-Smtp-Source: AB8JxZpfymYe3BwxdmiVAkcy4G5VV4cLBaWLNLjYEWULtlrhdFLGQnH1zTH2OEnFU9YB/Z4sIQh0Jg== X-Received: by 2002:a24:56c3:: with SMTP id o186-v6mr6843330itb.127.1526649364265; Fri, 18 May 2018 06:16:04 -0700 (PDT) Received: from [25.48.74.45] ([24.114.107.198]) by smtp.gmail.com with ESMTPSA id o123-v6sm4678603ith.25.2018.05.18.06.16.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 May 2018 06:16:03 -0700 (PDT) Date: Fri, 18 May 2018 13:07:07 +0000 In-Reply-To: <20180518122716.9272-1-go.wigust@gmail.com> References: <20180518122716.9272-1-go.wigust@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Maxim Cournoyer Message-ID: <462AD6C1-4912-4999-BDC9-3B3AE7C2D07F@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) On May 18, 2018 12:27:16 PM UTC, Oleg Pykhalov wr= ote: >* gnu/packages/cmake=2Escm (emacs-cmake-mode): New public variable=2E >--- > gnu/packages/cmake=2Escm | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > >diff --git a/gnu/packages/cmake=2Escm b/gnu/packages/cmake=2Escm >index e6c5c4e79=2E=2Eeba7a92c0 100644 >--- a/gnu/packages/cmake=2Escm >+++ b/gnu/packages/cmake=2Escm >@@ -206,3 +206,20 @@ and workspaces that can be used in the compiler >environment of your choice=2E") > (inputs > `(("rhash" ,rhash) > ,@(package-inputs cmake))))) >+ >+(define-public emacs-cmake-mode >+ (package >+ (inherit cmake) >+ (name "emacs-cmake-mode") >+ (build-system emacs-build-system) >+ (arguments >+ `(#:phases >+ (modify-phases %standard-phases >+ (add-after 'unpack 'chdir-elisp >+ ;; Elisp directory is not in root of the source=2E >+ (lambda _ >+ (chdir "Auxiliary")))))) >+ (synopsis "Emacs major mode for editing Cmake expressions") >+ (description "@code{cmakeos-mode} provides an Emacs major mode for >editing >+Cmake files=2E It supports syntax highlighting, indenting and refilling >of >+comments=2E"))) Thanks for packaging it=2E Should we delete the Emacs mode files from our = cmake package to not have duplication in the store when installing both CMa= ke and emacs-cmake-mode? I haven't tested it but it LGTM=2E Maxim Hi, From unknown Sat Jun 21 05:18:28 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#31490] [PATCH] gnu: Add emacs-cmake-mode. Resent-From: Oleg Pykhalov Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 22 May 2018 05:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31490 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 31490@debbugs.gnu.org Received: via spool by 31490-submit@debbugs.gnu.org id=B31490.152696783524841 (code B ref 31490); Tue, 22 May 2018 05:44:02 +0000 Received: (at 31490) by debbugs.gnu.org; 22 May 2018 05:43:55 +0000 Received: from localhost ([127.0.0.1]:43511 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fL05T-0006Sb-4P for submit@debbugs.gnu.org; Tue, 22 May 2018 01:43:55 -0400 Received: from mail-wr0-f193.google.com ([209.85.128.193]:45078) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fL05R-0006SO-J4 for 31490@debbugs.gnu.org; Tue, 22 May 2018 01:43:53 -0400 Received: by mail-wr0-f193.google.com with SMTP id w3-v6so10394807wrl.12 for <31490@debbugs.gnu.org>; Mon, 21 May 2018 22:43:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=95Z9E2B9ew0X+Nf4LfbCoIVZ5ENx9o8OFVxZEIwIlbw=; b=chYE+AsO3MypWBgqMPgDYenPDe3lYdROSfIevLe/wkcHIiTvXz+TDMo77pDx67hHU8 5LsTooH1lW2+P2wQQ/XY4yzLuMd8KgM4Hb/NAkHyR7a+jcZUisW0yzWS+44cd1UzJMkU fDYbCSUV7YzVLbeUlnkYiQhqEDvW5cMj+vB2ZGrtPS0ombGhKhsFu5vKpUagRXJo8CR1 0Z+AE/Ss1Ou2ha736h0uKts0xi3gkZ1y77KfWqAWk6fbRkJShUG+H1wvJuI2ggnbURa3 IDEVxtW9nvnB4bIUxN7TPxUn1C9+DD4ZopzCgt3zxfnXm0h5djNvlT7gBN+RfUVLJXp4 u0ZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=95Z9E2B9ew0X+Nf4LfbCoIVZ5ENx9o8OFVxZEIwIlbw=; b=kzjBXTWgWWJsDuXLzbNjwSH0wB39wZfon2DlsI4HQJKUyyUfWT5y55JAIILOngZ/A4 0Zm7bYNRs0TKVmYcIhcBM0J9VNDF3oiasGdSr32cbMboUJdB94K5G4IlAAojqlcoODjB XVw7ck9hF2Mggj9fqzOt0zUJRbYtkkiWlG3QXE86C0+AM4zR4zHGdLOKPfzuzExLACcf LIKZ+zgbLJemf5+fJ4qfklliP/qeQGfRsWZA68EbzM7ILsuAssvGyQnI5h39KAeNisqY 32YoOuDkItAmI4ghR/tC31/U8BANJ4GBomPvGuQep0VKGXRApI5dwBdl3/y/lkpOowyI AeuA== X-Gm-Message-State: ALKqPwcl27C1f6HLiBX9gQTJZuyAb+RG518KR2lKrvfjCOXgOXIcHy6t T/weoBmSBJrP4d3swW/TjTYKIA== X-Google-Smtp-Source: AB8JxZoaOahH2vUqkP1ZUjwRJf/TV/VnRmofL+m/zRyv6OYu5d7xn0Yka+WlP2VBjA9FdQCpw96GBQ== X-Received: by 2002:adf:b2f5:: with SMTP id g108-v6mr18748595wrd.147.1526967827487; Mon, 21 May 2018 22:43:47 -0700 (PDT) Received: from magnolia ([178.71.63.173]) by smtp.gmail.com with ESMTPSA id h81-v6sm27859072wmd.0.2018.05.21.22.43.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 21 May 2018 22:43:46 -0700 (PDT) From: Oleg Pykhalov References: <20180518122716.9272-1-go.wigust@gmail.com> <462AD6C1-4912-4999-BDC9-3B3AE7C2D07F@gmail.com> Date: Tue, 22 May 2018 08:43:41 +0300 In-Reply-To: <462AD6C1-4912-4999-BDC9-3B3AE7C2D07F@gmail.com> (Maxim Cournoyer's message of "Fri, 18 May 2018 13:07:07 +0000") Message-ID: <87in7gb5yq.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -1.8 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello Maxim, Thank you for review. Maxim Cournoyer writes: > On May 18, 2018 12:27:16 PM UTC, Oleg Pykhalov wrot= e: >>* gnu/packages/cmake.scm (emacs-cmake-mode): New public variable. >>--- >> gnu/packages/cmake.scm | 17 +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> [=E2=80=A6] > Should we delete the Emacs mode files from our cmake package to not > have duplication in the store when installing both CMake and > emacs-cmake-mode? Sure, we should. Could I push the following patch to core-updates? --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-gnu-cmake-Delete-Emacs-library.patch Content-Transfer-Encoding: quoted-printable Content-Description: gnu: cmake: Delete Emacs library. From=2046cb6d48c7fd7712fca1d5619d02eba992b9182a Mon Sep 17 00:00:00 2001 From: Oleg Pykhalov Date: Tue, 22 May 2018 07:41:45 +0300 Subject: [PATCH] gnu: cmake: Delete Emacs library. * gnu/packages/finance.scm (cmake)[arguments]: Delete Emacs library. =2D-- gnu/packages/cmake.scm | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/gnu/packages/cmake.scm b/gnu/packages/cmake.scm index e9fa86641..5f4a3c846 100644 =2D-- a/gnu/packages/cmake.scm +++ b/gnu/packages/cmake.scm @@ -85,6 +85,13 @@ " --exclude-regex ^\\(" (string-join skipped-tests "\\|") "\\)$= "))) #:phases (modify-phases %standard-phases + (add-after 'unpack 'split-package + ;; Remove files that have been packaged in other package recipe= s. + (lambda _ + (delete-file "Auxiliary/cmake-mode.el") + (substitute* "Auxiliary/CMakeLists.txt" + (("install\\(FILES cmake-mode.el \ +DESTINATION \\$\\{CMAKE_DATA_DIR\\}/editors/emacs\\)") "")))) (add-before 'configure 'patch-bin-sh (lambda _ ;; Replace "/bin/sh" by the right path in... a lot of =2D-=20 2.17.0 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 DQpb4oCmXQ0KDQpPbGVnLg0K --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEc+OyAXw1EaDPCmAPckbhHGm3lWkFAlsDrg4ACgkQckbhHGm3 lWnr/Q//UXl+iJA/u5axeAWESEBR55eO9nGkf64uw8CBnvgS02Axep8QYv4Hel/k ezSBJRtVv1OPepsoQiiScEQ3TUubLLTOvmOy6Zpw0w+B7x+Cj2kyjSBvZoxrem4x yZ1eImbvwDP44RTnCMRix5f1xYK8+Lmd0rDT69NmFroigud5103J2BdxiKQfdu8K /oEYGi6H4GEaewLX6vlZ7CKGoS60/5KbEOatPnGTeWW3g2kTHH/KjqZQeI+uvHMT miyetX/73agFdQghGwK5wVZUU/WIJY+hFznJdn5GrFB7lPDFhH7lBMlxxaEqioMP rFlqNL/tDcP+CfV7tqK1tsOH3fKUr163lMlPBVnECgC3rpx50Lre1WdeUW4ka3Bd vr6bMsFFpDpWwsAjGwjao5D3Ww4GMaiXFgO+YJd+KuHB+6v8FS3QxZhgx3Pra2SF 3ViuvE9YtM1ZoV8dKfVci0hsRmRDLN94EIvysSPXXCrRQ8Fuc6zAgeCrore8IxUV hrMTky0dZhfF0BCdxXA5Fnf25bYtk/IAP4hE22MFd3AP13qo2mEq+ciAdsFg5ps/ V1YLvBVhAD6PkhIc/7a/udRmojivIbZrUHroaTHMCoBz/3gzV1cxUCVNtvK+2LBu q/AuICWuhFkYNiUqUNxQJkqpFpyQ8NDg7mKb65FRb2YJDPSMKd0= =EmEv -----END PGP SIGNATURE----- --==-=-=-- From unknown Sat Jun 21 05:18:28 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#31490] [PATCH] gnu: Add emacs-cmake-mode. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 22 May 2018 13:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31490 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Oleg Pykhalov Cc: 31490@debbugs.gnu.org Received: via spool by 31490-submit@debbugs.gnu.org id=B31490.15269949768032 (code B ref 31490); Tue, 22 May 2018 13:17:02 +0000 Received: (at 31490) by debbugs.gnu.org; 22 May 2018 13:16:16 +0000 Received: from localhost ([127.0.0.1]:43796 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fL79D-00025R-5X for submit@debbugs.gnu.org; Tue, 22 May 2018 09:16:15 -0400 Received: from mail-io0-f194.google.com ([209.85.223.194]:39277) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fL79B-000259-Fy for 31490@debbugs.gnu.org; Tue, 22 May 2018 09:16:14 -0400 Received: by mail-io0-f194.google.com with SMTP id r9-v6so18404674iod.6 for <31490@debbugs.gnu.org>; Tue, 22 May 2018 06:16:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=+xDfcPdii5T6OzeAwZRvLvJWAiG/lFgyShtoC1aV62A=; b=Db/DW1q6x+w/2dHSNAyvPnsnJQUcEwbG/crcLRHk7sFMRYWFysYpUu2yT33RyjoJCF +QENYSUYibLL4OsWdtR3l4HopRuGKkAwPttuXbr9chZK31LEW1nMjDHzrvc5bmGHSVkS +R8d+3qyTBXUmSpibnkaXO2EoHyz1c+5H/p5Q6awYSIrZkjAWj/gGSceloRJlxQ4FWHN TqZHRMJnS0Y/M0fq/pXn3TyE7lmDSvyP9KwZ0EVjwDHfiByNNuVNf+GfRSSdFSHBom/t 0Zp7wJtrfdhBaU4gfW6e/43n9SwjIx6z5TMy38BmbeyRGgmP8vlCMc2S7QHYM8d4AgkS h7qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=+xDfcPdii5T6OzeAwZRvLvJWAiG/lFgyShtoC1aV62A=; b=ley+s1qCQIu4lAXyV1/g3Hzxk9ura9WOnsDRHJqwqCZvzL9Mvp/wn+ET23b98iO7fI Oqg9qkcCvFNbASL+q1kAveNZi+R92X5Vx19lrzyDriMH0mp/dZZAWTx6D291ntUu5HKj biACRXPO6maFueiB4VXfesDn1lZXb2bhLG8K7x/93fmUhO2hEgJ7bjL2nyiWtWEt3KGe dhdS6Bj7eV7ZYbwrTsNERpgmQc1CjCguYf76czaISvsAtYSxrslhL8DEcZ77Y/WjQ51T DVur5+KpnjaN2FrJO5cYIAu3WLjnmTXi1sQ+bc0sxQVRlA68RvvT3etVSESei41DIcRQ qZFA== X-Gm-Message-State: ALKqPwelutjHpa+cKjgyxddvuVYNwIGmFKwuDqzzGoNmM0deorxf7J+N //MYSSvs7kzZd83HRue/+NTspw== X-Google-Smtp-Source: AB8JxZoSpN4rE5HYbFqYyMzgV94F9yMNSaiyuJnRl67i7qL1xwwze7EjN5lDANIBcN8WC1xoYX91Ag== X-Received: by 2002:a6b:948d:: with SMTP id w135-v6mr27601855iod.161.1526994967812; Tue, 22 May 2018 06:16:07 -0700 (PDT) Received: from apteryx ([45.72.197.2]) by smtp.gmail.com with ESMTPSA id e22-v6sm4334371ita.0.2018.05.22.06.16.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 22 May 2018 06:16:07 -0700 (PDT) From: Maxim Cournoyer References: <20180518122716.9272-1-go.wigust@gmail.com> <462AD6C1-4912-4999-BDC9-3B3AE7C2D07F@gmail.com> <87in7gb5yq.fsf@gmail.com> Date: Tue, 22 May 2018 09:16:06 -0400 In-Reply-To: <87in7gb5yq.fsf@gmail.com> (Oleg Pykhalov's message of "Tue, 22 May 2018 08:43:41 +0300") Message-ID: <87lgcbltk9.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -1.8 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) Hi Oleg, Oleg Pykhalov writes: > Hello Maxim, > > Thank you for review. > > Maxim Cournoyer writes: > >> On May 18, 2018 12:27:16 PM UTC, Oleg Pykhalov wro= te: >>>* gnu/packages/cmake.scm (emacs-cmake-mode): New public variable. >>>--- >>> gnu/packages/cmake.scm | 17 +++++++++++++++++ >>> 1 file changed, 17 insertions(+) >>> > > [=E2=80=A6] > >> Should we delete the Emacs mode files from our cmake package to not >> have duplication in the store when installing both CMake and >> emacs-cmake-mode? > > Sure, we should. Could I push the following patch to core-updates? > > From 46cb6d48c7fd7712fca1d5619d02eba992b9182a Mon Sep 17 00:00:00 2001 > From: Oleg Pykhalov > Date: Tue, 22 May 2018 07:41:45 +0300 > Subject: [PATCH] gnu: cmake: Delete Emacs library. > > * gnu/packages/finance.scm (cmake)[arguments]: Delete Emacs library. > --- > gnu/packages/cmake.scm | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/gnu/packages/cmake.scm b/gnu/packages/cmake.scm > index e9fa86641..5f4a3c846 100644 > --- a/gnu/packages/cmake.scm > +++ b/gnu/packages/cmake.scm > @@ -85,6 +85,13 @@ > " --exclude-regex ^\\(" (string-join skipped-tests "\\|") "\\= )$"))) > #:phases > (modify-phases %standard-phases > + (add-after 'unpack 'split-package > + ;; Remove files that have been packaged in other package reci= pes. > + (lambda _ > + (delete-file "Auxiliary/cmake-mode.el") > + (substitute* "Auxiliary/CMakeLists.txt" > + (("install\\(FILES cmake-mode.el \ > +DESTINATION \\$\\{CMAKE_DATA_DIR\\}/editors/emacs\\)") "")))) Nitpick: I'd use a regexp to match the text following cmake-mode.el on the line to make it more resilient to any future changes. Otherwise this LGTM :) Maxim From unknown Sat Jun 21 05:18:28 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#31490] [PATCH] gnu: Add emacs-cmake-mode. Resent-From: Oleg Pykhalov Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 22 May 2018 14:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31490 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 31490@debbugs.gnu.org, 31490-done@debbugs.gnu.org Received: via spool by 31490-submit@debbugs.gnu.org id=B31490.152699915714545 (code B ref 31490); Tue, 22 May 2018 14:26:02 +0000 Received: (at 31490) by debbugs.gnu.org; 22 May 2018 14:25:57 +0000 Received: from localhost ([127.0.0.1]:44268 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fL8Ef-0003mS-6O for submit@debbugs.gnu.org; Tue, 22 May 2018 10:25:57 -0400 Received: from mail-wm0-f52.google.com ([74.125.82.52]:39137) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fL8Ed-0003m9-AW; Tue, 22 May 2018 10:25:55 -0400 Received: by mail-wm0-f52.google.com with SMTP id f8-v6so275763wmc.4; Tue, 22 May 2018 07:25:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=YKs/v2mZdSzzXIqk9PvvzaFib3Sa1U4S3rBLPD46NqI=; b=oKl+ObcoUFMMaVCqSehw9SgALsnS0+JhpYzm8YGI9h0TZF6AndWf789mcDwRmXNAzc FoTmpcSQXb09JZ3mdrmH58QpOf5c5TMmsX1LA1V88jXR6wOW/izmQ1KNib+luKfe0Wzi LWzECJ3qlYZk31Iag3K2FdzQQWyT1EIjHZcaGD2JnAU3bfDukILJw5dji5uG089spUTS BivQCACBfGnnEViadUfxg+lePmYvDFAqe0rn/Pna4CzOVlMbl9iCYfFtJkYkgKzIX0jV R08vj/p8tQARVpBl9EUMQ+H6/1UIIRvB0kwLR0wACo1b4cTdjX2eYy9gUCOSRff014hw xVJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=YKs/v2mZdSzzXIqk9PvvzaFib3Sa1U4S3rBLPD46NqI=; b=UzxarJM/QuBgxqn7XoVzw/1bvywtHxpVdZ9Idb8pFHL6FM8l0bHxJjTYeTKaq6W4NU aSC8dWPFjAy76X4+F4k5U4ftpCTWjepPy8KDg649tBhI/+Z8lvpfm+BA9Yosfad1En/n wVNPCuayrv6vKc7EaJ9szvqUQHN8INrH28mM9YSQlyXt7tkPQO6Jfbcp9PBNzfh/PXCZ Z3mkG1ONPqRWZRUR48YMYphLOYFgJGSeIuiGk6w4cF/Cwh8OzRffFMGRS1X6L7O2GrY0 m/VIWDzPhNGSShJ5rVcWlq5t4RvAMfPRRjU+J55Vz6K1JubQ12dZ+P0zvuEYXSuidapu stuQ== X-Gm-Message-State: ALKqPwdBZU5g75OaDsRwTGrMv1Ws8bgtj/OvmLi/OJ/hoDldyCIkDRPW W1aoBYkIBMo+u7kux8iXCdZo6Q== X-Google-Smtp-Source: AB8JxZqgVWI0iZiuRcfCkJrf1Wsdx9YU9wyRdXcVXixbq3YWZD/NQH9+quK8jsumAxuj/Qy4lAB27w== X-Received: by 2002:a2e:300c:: with SMTP id w12-v6mr15913569ljw.98.1526999148995; Tue, 22 May 2018 07:25:48 -0700 (PDT) Received: from magnolia ([178.71.63.173]) by smtp.gmail.com with ESMTPSA id c6-v6sm2948921lja.22.2018.05.22.07.25.47 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 22 May 2018 07:25:47 -0700 (PDT) From: Oleg Pykhalov References: <20180518122716.9272-1-go.wigust@gmail.com> <462AD6C1-4912-4999-BDC9-3B3AE7C2D07F@gmail.com> <87in7gb5yq.fsf@gmail.com> <87lgcbltk9.fsf@gmail.com> Date: Tue, 22 May 2018 17:25:43 +0300 In-Reply-To: <87lgcbltk9.fsf@gmail.com> (Maxim Cournoyer's message of "Tue, 22 May 2018 09:16:06 -0400") Message-ID: <87bmd7bwd4.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Maxim Cournoyer writes: [=E2=80=A6] >> + (substitute* "Auxiliary/CMakeLists.txt" >> + (("install\\(FILES cmake-mode.el \ >> +DESTINATION \\$\\{CMAKE_DATA_DIR\\}/editors/emacs\\)") "")))) > > Nitpick: I'd use a regexp to match the text following cmake-mode.el on > the line to make it more resilient to any future changes. Otherwise this > LGTM :) Agree, pushed as f037673c3133ae7453794f1f62eecebf9d06b092 and emacs-cmake-mode bbdf36666b82eae0a583d7124d8117801969570c Oleg. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEc+OyAXw1EaDPCmAPckbhHGm3lWkFAlsEKGcACgkQckbhHGm3 lWk73BAArrpo0tY/TLdkRTIAWyNCXijNzSxcG5l7nmOkEQUTx13jzR+T5PekN3sT Z1QCAWiEnZI77nDJYfYdwJDCLPoUQM7V2xrDUPFA/q0Xp/dTWLvg525fX0gk9FX0 i1jHiGnBvWxs5pqjPveGsZ+LKQqpHg90sbElwS3M94Vkelh3mkSgVqi4HorDk2ip 1vdRelOyQb2DRUCmwVXGueNWEKDmLygenstwd5hSyXFgdyS4/NOz7eEcQop4rZid Z2zOs8PXB6mFGBmGn++3kE+OPNQrn0QOtwz4XGAdu9j6eHao7h9l9kd8u63BtBLZ NQn1HWbk/MeytAKx29zP4vhUqTs+fAx7+eami39gptrq4au4kxLJeNjwVMAs5YsJ hKH15jAcIZdgdtRm7IlklKXiOr8AnD6wIXmfxwqw0wOlio3j+7HaQEbu++Hmvds2 Q2Lsvk8SdpmmxnpPDmu01HgVAPbzPUhfZQPkPK9tuizrn0yjxEUeweSv6GiVYGxW CRdu9Np8ckbnoJsjJKNtdTELS5nyeg0CWejIFXI42ou/saac+LXZq/d18WSvanpk Blk9Anwk3JcKUNAZB328SZeBFyfldPS8uzq1Z0jHk1bkWIaki+11Q25uI+WojWEg nS5A/LB40wtLEWUIteK6GIK9SALKX8UAdpghb9Y1vYtHD12Am/w= =n6bu -----END PGP SIGNATURE----- --=-=-=-- From unknown Sat Jun 21 05:18:28 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Oleg Pykhalov Subject: bug#31490: closed (Re: [bug#31490] [PATCH] gnu: Add emacs-cmake-mode.) Message-ID: References: <87bmd7bwd4.fsf@gmail.com> <20180518122716.9272-1-go.wigust@gmail.com> X-Gnu-PR-Message: they-closed 31490 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 31490@debbugs.gnu.org Date: Tue, 22 May 2018 14:26:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1526999163-14564-1" This is a multi-part message in MIME format... ------------=_1526999163-14564-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #31490: [PATCH] gnu: Add emacs-cmake-mode. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 31490@debbugs.gnu.org. --=20 31490: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D31490 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1526999163-14564-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 31490-done) by debbugs.gnu.org; 22 May 2018 14:25:57 +0000 Received: from localhost ([127.0.0.1]:44266 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fL8Ee-0003mP-Ub for submit@debbugs.gnu.org; Tue, 22 May 2018 10:25:57 -0400 Received: from mail-wm0-f52.google.com ([74.125.82.52]:39137) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fL8Ed-0003m9-AW; Tue, 22 May 2018 10:25:55 -0400 Received: by mail-wm0-f52.google.com with SMTP id f8-v6so275763wmc.4; Tue, 22 May 2018 07:25:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=YKs/v2mZdSzzXIqk9PvvzaFib3Sa1U4S3rBLPD46NqI=; b=oKl+ObcoUFMMaVCqSehw9SgALsnS0+JhpYzm8YGI9h0TZF6AndWf789mcDwRmXNAzc FoTmpcSQXb09JZ3mdrmH58QpOf5c5TMmsX1LA1V88jXR6wOW/izmQ1KNib+luKfe0Wzi LWzECJ3qlYZk31Iag3K2FdzQQWyT1EIjHZcaGD2JnAU3bfDukILJw5dji5uG089spUTS BivQCACBfGnnEViadUfxg+lePmYvDFAqe0rn/Pna4CzOVlMbl9iCYfFtJkYkgKzIX0jV R08vj/p8tQARVpBl9EUMQ+H6/1UIIRvB0kwLR0wACo1b4cTdjX2eYy9gUCOSRff014hw xVJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=YKs/v2mZdSzzXIqk9PvvzaFib3Sa1U4S3rBLPD46NqI=; b=UzxarJM/QuBgxqn7XoVzw/1bvywtHxpVdZ9Idb8pFHL6FM8l0bHxJjTYeTKaq6W4NU aSC8dWPFjAy76X4+F4k5U4ftpCTWjepPy8KDg649tBhI/+Z8lvpfm+BA9Yosfad1En/n wVNPCuayrv6vKc7EaJ9szvqUQHN8INrH28mM9YSQlyXt7tkPQO6Jfbcp9PBNzfh/PXCZ Z3mkG1ONPqRWZRUR48YMYphLOYFgJGSeIuiGk6w4cF/Cwh8OzRffFMGRS1X6L7O2GrY0 m/VIWDzPhNGSShJ5rVcWlq5t4RvAMfPRRjU+J55Vz6K1JubQ12dZ+P0zvuEYXSuidapu stuQ== X-Gm-Message-State: ALKqPwdBZU5g75OaDsRwTGrMv1Ws8bgtj/OvmLi/OJ/hoDldyCIkDRPW W1aoBYkIBMo+u7kux8iXCdZo6Q== X-Google-Smtp-Source: AB8JxZqgVWI0iZiuRcfCkJrf1Wsdx9YU9wyRdXcVXixbq3YWZD/NQH9+quK8jsumAxuj/Qy4lAB27w== X-Received: by 2002:a2e:300c:: with SMTP id w12-v6mr15913569ljw.98.1526999148995; Tue, 22 May 2018 07:25:48 -0700 (PDT) Received: from magnolia ([178.71.63.173]) by smtp.gmail.com with ESMTPSA id c6-v6sm2948921lja.22.2018.05.22.07.25.47 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 22 May 2018 07:25:47 -0700 (PDT) From: Oleg Pykhalov To: Maxim Cournoyer Subject: Re: [bug#31490] [PATCH] gnu: Add emacs-cmake-mode. References: <20180518122716.9272-1-go.wigust@gmail.com> <462AD6C1-4912-4999-BDC9-3B3AE7C2D07F@gmail.com> <87in7gb5yq.fsf@gmail.com> <87lgcbltk9.fsf@gmail.com> Date: Tue, 22 May 2018 17:25:43 +0300 In-Reply-To: <87lgcbltk9.fsf@gmail.com> (Maxim Cournoyer's message of "Tue, 22 May 2018 09:16:06 -0400") Message-ID: <87bmd7bwd4.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 31490-done Cc: 31490@debbugs.gnu.org, 31490-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Maxim Cournoyer writes: [=E2=80=A6] >> + (substitute* "Auxiliary/CMakeLists.txt" >> + (("install\\(FILES cmake-mode.el \ >> +DESTINATION \\$\\{CMAKE_DATA_DIR\\}/editors/emacs\\)") "")))) > > Nitpick: I'd use a regexp to match the text following cmake-mode.el on > the line to make it more resilient to any future changes. Otherwise this > LGTM :) Agree, pushed as f037673c3133ae7453794f1f62eecebf9d06b092 and emacs-cmake-mode bbdf36666b82eae0a583d7124d8117801969570c Oleg. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEc+OyAXw1EaDPCmAPckbhHGm3lWkFAlsEKGcACgkQckbhHGm3 lWk73BAArrpo0tY/TLdkRTIAWyNCXijNzSxcG5l7nmOkEQUTx13jzR+T5PekN3sT Z1QCAWiEnZI77nDJYfYdwJDCLPoUQM7V2xrDUPFA/q0Xp/dTWLvg525fX0gk9FX0 i1jHiGnBvWxs5pqjPveGsZ+LKQqpHg90sbElwS3M94Vkelh3mkSgVqi4HorDk2ip 1vdRelOyQb2DRUCmwVXGueNWEKDmLygenstwd5hSyXFgdyS4/NOz7eEcQop4rZid Z2zOs8PXB6mFGBmGn++3kE+OPNQrn0QOtwz4XGAdu9j6eHao7h9l9kd8u63BtBLZ NQn1HWbk/MeytAKx29zP4vhUqTs+fAx7+eami39gptrq4au4kxLJeNjwVMAs5YsJ hKH15jAcIZdgdtRm7IlklKXiOr8AnD6wIXmfxwqw0wOlio3j+7HaQEbu++Hmvds2 Q2Lsvk8SdpmmxnpPDmu01HgVAPbzPUhfZQPkPK9tuizrn0yjxEUeweSv6GiVYGxW CRdu9Np8ckbnoJsjJKNtdTELS5nyeg0CWejIFXI42ou/saac+LXZq/d18WSvanpk Blk9Anwk3JcKUNAZB328SZeBFyfldPS8uzq1Z0jHk1bkWIaki+11Q25uI+WojWEg nS5A/LB40wtLEWUIteK6GIK9SALKX8UAdpghb9Y1vYtHD12Am/w= =n6bu -----END PGP SIGNATURE----- --=-=-=-- ------------=_1526999163-14564-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 18 May 2018 12:27:54 +0000 Received: from localhost ([127.0.0.1]:39260 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fJeUD-0000n4-O1 for submit@debbugs.gnu.org; Fri, 18 May 2018 08:27:54 -0400 Received: from eggs.gnu.org ([208.118.235.92]:56585) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fJeUB-0000mp-NF for submit@debbugs.gnu.org; Fri, 18 May 2018 08:27:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fJeU5-0006Qb-IH for submit@debbugs.gnu.org; Fri, 18 May 2018 08:27:46 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:38255) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fJeU5-0006QS-EW for submit@debbugs.gnu.org; Fri, 18 May 2018 08:27:45 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47556) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fJeU4-0002CD-Ac for guix-patches@gnu.org; Fri, 18 May 2018 08:27:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fJeU1-0006O9-5R for guix-patches@gnu.org; Fri, 18 May 2018 08:27:44 -0400 Received: from mail-wm0-x232.google.com ([2a00:1450:400c:c09::232]:38251) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fJeU0-0006NO-Uq for guix-patches@gnu.org; Fri, 18 May 2018 08:27:41 -0400 Received: by mail-wm0-x232.google.com with SMTP id m129-v6so14791857wmb.3 for ; Fri, 18 May 2018 05:27:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=ug5U0N+yqYdrHoKJdt0WERhGWd7qbVcEfQwhZqAZSgw=; b=trYyF2l2hmVaNVzUYm39aYZyKSDIuIRyMTMwXszGtlYY0bo6MovIepjkx3Dee5fs9V 8vOfKGBAZecwKJuhtSw2zXp1znLOmBIM9c9cBposqSgv0mV/hqTgd1jS5wKPfV7m5Auo pRS3BN/0qvpSDefvH+C2mqAmWCuEvWyCPdBu6l+DwSyL3dMZg4aDdi0hmFOfi75DcDgw sRJRbW4/fT+hvJKVec5Cn26vkzPk1/xEaRADpuF4/vEIOVB9GY2sxt9hb3zm8aVCwXdM uj0IdjTWjtDZuZ441MJ9jAQ21lLgy4BZJiFplCw1ul8cqk1ksLhu//ZWW8NriWz3VI3y q3yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=ug5U0N+yqYdrHoKJdt0WERhGWd7qbVcEfQwhZqAZSgw=; b=drEnQV8wH60MF0H23KxUki5qaJCBPEQ6uaUK3U+z+Y8OhDHhkOri3rmrIm4CPHLOXZ dWolKRw6yeFcRGDGkOLnNAOK/EtQHIGAXMjGfFenpzBTmoVwmW1obuJTw6hE9HGTxPtb RXjZg8BXZ/1K81DMmkc5l9hiEyYzaFOIrdNq1g+fEtXg1NOSbkJfofUkJ8OxqqoYEdcn YwApI0621n46lYIIfjfJyFOjNXpQi+xY5AhI1KSCe0/N6HJeF/0R4RGKYD/GTki21l+p J54b6ZdyUTskOX9Rj+BkbXBU8VG6cClxHbMpoOEKhy3DQmcBuz1Y9w/qF9pmZ0L7cL/y 9l2g== X-Gm-Message-State: ALKqPwfs59amlv2Gk1UYiM4CpFFEH6sg9w2v832S/qzycKkz18SgW1H5 E1mFYJpHB3u0FhkI7bxbKCS8yQ== X-Google-Smtp-Source: AB8JxZoxm5R6wNFvwj/08HWACWcxUpywnSurJZgOQ6OgD3aFhkmaIy1T36K4dKgnImR+na/4x3H0aQ== X-Received: by 2002:a50:c8cb:: with SMTP id k11-v6mr11602847edh.94.1526646459236; Fri, 18 May 2018 05:27:39 -0700 (PDT) Received: from localhost.localdomain ([178.71.236.98]) by smtp.gmail.com with ESMTPSA id y7-v6sm3599181edq.8.2018.05.18.05.27.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 May 2018 05:27:38 -0700 (PDT) From: Oleg Pykhalov To: guix-patches@gnu.org Subject: [PATCH] gnu: Add emacs-cmake-mode. Date: Fri, 18 May 2018 15:27:16 +0300 Message-Id: <20180518122716.9272-1-go.wigust@gmail.com> X-Mailer: git-send-email 2.17.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit Cc: Oleg Pykhalov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) * gnu/packages/cmake.scm (emacs-cmake-mode): New public variable. --- gnu/packages/cmake.scm | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/gnu/packages/cmake.scm b/gnu/packages/cmake.scm index e6c5c4e79..eba7a92c0 100644 --- a/gnu/packages/cmake.scm +++ b/gnu/packages/cmake.scm @@ -206,3 +206,20 @@ and workspaces that can be used in the compiler environment of your choice.") (inputs `(("rhash" ,rhash) ,@(package-inputs cmake))))) + +(define-public emacs-cmake-mode + (package + (inherit cmake) + (name "emacs-cmake-mode") + (build-system emacs-build-system) + (arguments + `(#:phases + (modify-phases %standard-phases + (add-after 'unpack 'chdir-elisp + ;; Elisp directory is not in root of the source. + (lambda _ + (chdir "Auxiliary")))))) + (synopsis "Emacs major mode for editing Cmake expressions") + (description "@code{cmakeos-mode} provides an Emacs major mode for editing +Cmake files. It supports syntax highlighting, indenting and refilling of +comments."))) -- 2.17.0 ------------=_1526999163-14564-1-- From unknown Sat Jun 21 05:18:28 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#31490] [PATCH] gnu: Add emacs-cmake-mode. Resent-From: Oleg Pykhalov Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 22 May 2018 14:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31490 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 31490@debbugs.gnu.org, 31490-done@debbugs.gnu.org Received: via spool by 31490-submit@debbugs.gnu.org id=B31490.152700007115969 (code B ref 31490); Tue, 22 May 2018 14:42:01 +0000 Received: (at 31490) by debbugs.gnu.org; 22 May 2018 14:41:11 +0000 Received: from localhost ([127.0.0.1]:44291 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fL8TP-00049Q-Lx for submit@debbugs.gnu.org; Tue, 22 May 2018 10:41:11 -0400 Received: from mail-wr0-f173.google.com ([209.85.128.173]:44422) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fL8TO-000498-3U; Tue, 22 May 2018 10:41:10 -0400 Received: by mail-wr0-f173.google.com with SMTP id y15-v6so20649659wrg.11; Tue, 22 May 2018 07:41:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=HOrh93cJy+BmlmvP+oGoYkm/36B9IusS+8IyGGHvsKg=; b=GlJvGNg0NljJ7/glL2rTb1V+0aWRmJt3MKL1RF2xp7qW5D02lsRLC8by3/Fhpp2dIr Je+FCWjP6D8rx3BP7fw5QtvPS8+HAfCGeARvG9IlCsxQkQQOWRzs5r9dG358pyT+EL+8 tnjylfdQ6gh3NRL2Ve9MRgZKsREmnfliK+BSq6DDf4ngLc2TUlFdZwcWL+7/YWeTHwRc ogy6TtvyQHv556/H3My4J3pEUs8CVAMI2VF3baoH66c0MzZ0o8JA+/z+iZ4rSLqMdD42 3aOAA9sUS8zRt8/5vYPA2l/RBJCUVN2fpuBMFZBMvpdGyicE5F4++tHCA8Io/tZCiFtN Lxww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=HOrh93cJy+BmlmvP+oGoYkm/36B9IusS+8IyGGHvsKg=; b=IE8XkDZcoFZmd6wn41RLgfAYc86o4Xd7rW6z2gtyYwA/xmRoQANvrydacXnU8HOkBn tFLiV+JLoL7rjd2mI5IKPFIWWcStiYH7d2ralZLu0H8U4y+kVECRdgxUnBpb4RgWwuM9 otbx8gLtr3hvFnbJ5Efa+9/3ocnGtSv7zvhdn9IYrAhp3eAtHB8T/4/gmILI2Jhfmo8c lsvfidvFwzbaMMsAQXZd57A3HxDHFlfnpSJGE20G8JDy/O8/0HqmNbpmFq6twDNUZsgZ 2QOBIGTDjJf9vFdkiK3W8N2AY7VubpbPgGDEAgxWdJSMoawbV4ynuEnUBOEp3FNtMO6h XUZA== X-Gm-Message-State: ALKqPwe5wtjGD2dJpXd77KqzB8rFL671p4aBJDNLfe5cAdaszS56zxBM v0/xGsJ1MmLQbzUqoSHiF+Hk/g== X-Google-Smtp-Source: AB8JxZquTWtsG+MjMpfL+59b9N4zH+/zj6YY+8MHV667basMGJklus5o5VBY6ce4zsOjISL9J95CmA== X-Received: by 2002:a19:e117:: with SMTP id y23-v6mr1432310lfg.9.1527000064002; Tue, 22 May 2018 07:41:04 -0700 (PDT) Received: from magnolia ([178.71.63.173]) by smtp.gmail.com with ESMTPSA id x73-v6sm1117579lfa.18.2018.05.22.07.41.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 22 May 2018 07:41:03 -0700 (PDT) From: Oleg Pykhalov References: <20180518122716.9272-1-go.wigust@gmail.com> <462AD6C1-4912-4999-BDC9-3B3AE7C2D07F@gmail.com> <87in7gb5yq.fsf@gmail.com> <87lgcbltk9.fsf@gmail.com> <87bmd7bwd4.fsf@gmail.com> Date: Tue, 22 May 2018 17:40:59 +0300 In-Reply-To: <87bmd7bwd4.fsf@gmail.com> (Oleg Pykhalov's message of "Tue, 22 May 2018 17:25:43 +0300") Message-ID: <878t8bbvno.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Oleg Pykhalov writes: [=E2=80=A6] > Agree, pushed as f037673c3133ae7453794f1f62eecebf9d06b092 > and emacs-cmake-mode bbdf36666b82eae0a583d7124d8117801969570c Ah, apologies for not running =E2=80=98make=E2=80=99 before. I've got an e= rror about missing emacs-build-system variable. Fixed in aa4818c33b6b2fd8d602ee93a2f53005d9472f41 Oleg. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEc+OyAXw1EaDPCmAPckbhHGm3lWkFAlsEK/sACgkQckbhHGm3 lWkC2xAAtHTFrbdtiBUZBmfbp8NcEAT1FdVv87FOWXvviCIFeckiKwkB0uCPcCIg rKPATsDMvX35a7Yg+B9IIhxLz44z2KnROTrerL7y851+9kNj9WU2DWGG+Wx223F7 dx457BXY5dpBQTC8ih0H1Hkq0GZxb4HJCFCZc7U5LzlfVK+BUED88ejaS2lRvgbD vZvp8V2bV6Grr2xvgE1Xa5plA89xN3vC0CjnUD+RFZkbiLQ4iEey1TYcgLqOREtm zME6IpQa1cxxwfbqpJc2sOkkRmMI8jWPDsLLgB5YXot1lu3q0sTgkXhINm8JSipo Js3KhEDD554IupWwPnN9MwhNwlmjDTrBLdDhtCf1kJaw1YREmdWma6FcjrzPFNwr Ah82D5GJWTvO3gVF1GdoX8tnCvxVKWHDkxC1deibm6s6pL+kZ1U2J1SuTDZxIEQf qN9RvPmfqRWFjuM0kY5ThA0Uv+Bqpqh0uEwG98XvWLeHf7hOyK6a94Q9Z/NDA6xp qZN32jqIG01RtGm8O7zQPOVlpCfMmB4SsKaVcK5bDLCROMd0vJFf/c6vHZTkBYOr CChDhsYTjT/YWE8Op/ShTbifbCt1EW2O8nriYGd5xD8kSdzdWtiftwMV8v2KXv60 aQco0VVd0XBwQdwF1OTzkSnE2aFKPZT3ca0cUclqsz/NtniL4uk= =Oz8/ -----END PGP SIGNATURE----- --=-=-=-- From unknown Sat Jun 21 05:18:28 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#31490] [PATCH] gnu: Add emacs-cmake-mode. Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 22 May 2018 15:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31490 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Oleg Pykhalov , Maxim Cournoyer Cc: 31490@debbugs.gnu.org, 31490-done@debbugs.gnu.org Received: via spool by 31490-submit@debbugs.gnu.org id=B31490.152700249319843 (code B ref 31490); Tue, 22 May 2018 15:22:01 +0000 Received: (at 31490) by debbugs.gnu.org; 22 May 2018 15:21:33 +0000 Received: from localhost ([127.0.0.1]:44316 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fL96T-00059t-0n for submit@debbugs.gnu.org; Tue, 22 May 2018 11:21:33 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:60415) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fL96Q-00059e-UY; Tue, 22 May 2018 11:21:31 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 60ABB21AFB; Tue, 22 May 2018 11:21:30 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 22 May 2018 11:21:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=w9z5/n2ope3zJwycAvCetp0qPWNEgzljqSqr2CEkwBg=; b=jYhGvep8 ttC4KMywGovR1gcRmZOM62+BFx82YRxU9r+D+kJh7Lbk4IE5ruIA7KJmuMEy/Gq4 OQ9toac5TDK6r5+Xrp3Oj8UVSAMiWqFPByP8c+M6cOyT160uE5set73Maq1SMAkM mWA2AxTb84zF0g6ur7avfq+Y8Iz1aXXpcRsa1wlrnK3CYKp3gQzxfLXSid4UkP5d fucin3HD4UCqzea0TTQeI7Kt2HRajkq/l3c+mLEPYuDx+ueCerMN7Kn/EEOPsQfG 3uh5j2Bqah/X6PediGUqssmfj3PLfLtUD/Es7RzaHyCjwvW4f9QdlhbsLDVKknPU ROgsFfAFuyM9sA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=w9z5/n2ope3zJwycAvCetp0qPWNEg zljqSqr2CEkwBg=; b=MPPSWY4+FuECB3KAVD8aSfiRTnrkxUtSz59UDMGlEMwoD y+WbkS3QX1fxFpaz0A1RtXF0R58aHcQtTNUFSS3B0Bo6aXe9Z6vc7hj82XPSoa8R 7rEA5OD+HxgnmwYEjeQkNrGdCtGwK8LyBveaUS/UdjHVY4qQNJNwyFdz36yUNwgH LXBmBPntWT2/wv69PjkmHbetyCqeZR03esIgYgjDowEO1/wIAiJt70s8hraqSsQj wjKV7eTJf4jOotI8tmYOLlnTLYLvtUc6ALUrApVc/zTodUY7ShM/1mkfTltp9g6x UQdEa2rfT3NSpfIptIxQax1aXg4UueaAo1vaxzwyQ== X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Sender: Received: from localhost (95.92-221-151.customer.lyse.net [92.221.151.95]) by mail.messagingengine.com (Postfix) with ESMTPA id E2930103AC; Tue, 22 May 2018 11:21:29 -0400 (EDT) From: Marius Bakke In-Reply-To: <87bmd7bwd4.fsf@gmail.com> References: <20180518122716.9272-1-go.wigust@gmail.com> <462AD6C1-4912-4999-BDC9-3B3AE7C2D07F@gmail.com> <87in7gb5yq.fsf@gmail.com> <87lgcbltk9.fsf@gmail.com> <87bmd7bwd4.fsf@gmail.com> User-Agent: Notmuch/0.26.2 (https://notmuchmail.org) Emacs/25.3.1 (x86_64-pc-linux-gnu) Date: Tue, 22 May 2018 17:21:28 +0200 Message-ID: <87bmd7g1hj.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Oleg Pykhalov writes: > Maxim Cournoyer writes: > > [=E2=80=A6] > >>> + (substitute* "Auxiliary/CMakeLists.txt" >>> + (("install\\(FILES cmake-mode.el \ >>> +DESTINATION \\$\\{CMAKE_DATA_DIR\\}/editors/emacs\\)") "")))) >> >> Nitpick: I'd use a regexp to match the text following cmake-mode.el on >> the line to make it more resilient to any future changes. Otherwise this >> LGTM :) > > Agree, pushed as f037673c3133ae7453794f1f62eecebf9d06b092 'core-updates' is currently live on Hydra: https://hydra.gnu.org/jobset/gnu/core-updates Since we already have substitutes for CMake and many dependents, this commit will have to wait until the next rebuild cycle. Can you revert it on 'core-updates' and resubmit the patch to 'core-updates-next'? PS: Please also end the phase on #t ;-) Thanks! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlsENXgACgkQoqBt8qM6 VPplygf/VMX13BGXHlTh0Z3AYqdpTdbNZs5clDV1vpF++vhduaA2jbp3ZriE/qA9 XLQhO9LfqVBBsulBcEDVEQaNJRCdmkq7Qj0oRi8C8tjwHkJ5wEnB8sbYH4YrsOBf +lzvl/nZeO5cv2GP79YabsJbRAwxfe+kQaavpLkJKjLeewfZv47sByU5YN/uvOd7 a6DOL1qjHGwur0fFiVSgXZxeYbj1CSzjO2LBz7+C6vIiSIpAS5xd0cUmMVOweBxy OyiUG5C/nJ02L5aIVhyAb5VKw4TVMFeWIKYeV6w9Qxhp7dzDDWyxSRmrGZZoP9kx EpBWmFDIjva6Z5YX9UQ+/SpPtqKAzA== =M83D -----END PGP SIGNATURE----- --=-=-=--