GNU bug report logs - #31462
[PATCH] profiles: Add hook to generate "gschemas.compiled".

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 31462 in the body.
You can then email your comments to 31462 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: guix-patches <at> gnu.org
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>
Subject: [PATCH] profiles: Add hook to generate "gschemas.compiled".
Date: Tue, 15 May 2018 14:49:17 +0200

* guix/profiles.scm (glib-schemas): New procedure.
(%default-profile-hooks): Add it.
---
 guix/profiles.scm | 52 ++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 52 insertions(+)

diff --git a/guix/profiles.scm b/guix/profiles.scm
index dca247976..300324362 100644
--- a/guix/profiles.scm
+++ b/guix/profiles.scm
@@ -843,6 +843,57 @@ MANIFEST.  Single-file bundles are required by programs such as Git and Lynx."
                     #:local-build? #t
                     #:substitutable? #f))
 
+(define (glib-schemas manifest)
+  "Return a derivation that unions all schemas from manifest entries and
+creates the Glib 'gschemas.compiled' file."
+  (define glib  ; lazy reference
+    (module-ref (resolve-interface '(gnu packages glib)) 'glib))
+
+  (mlet %store-monad ((%glib (manifest-lookup-package manifest "glib"))
+                      ;; XXX: Can't use glib-compile-schemas corresponding
+                      ;; to the glib referenced by 'manifest'.  Because
+                      ;; '%glib' can be either a package or store path, and
+                      ;; there's no way to get the "bin" output for the later.
+                      (glib-compile-schemas
+                       -> #~(string-append #+glib:bin
+                                           "/bin/glib-compile-schemas")))
+
+    (define build
+      (with-imported-modules '((guix build utils)
+                               (guix build union)
+                               (guix build profiles)
+                               (guix search-paths)
+                               (guix records))
+        #~(begin
+            (use-modules (guix build utils)
+                         (guix build union)
+                         (guix build profiles)
+                         (srfi srfi-26))
+
+            (let* ((destdir  (string-append #$output "/share/glib-2.0/schemas"))
+                   (schemadirs (filter file-exists?
+                                     (map (cut string-append <> "/share/glib-2.0/schemas")
+                                          '#$(manifest-inputs manifest)))))
+
+              ;; Union all the schemas.
+              (mkdir-p (string-append #$output "/share/glib-2.0"))
+              (union-build destdir schemadirs
+                           #:log-port (%make-void-port "w"))
+
+              (let ((dir destdir))
+                 (when (file-is-directory? dir)
+                   (ensure-writable-directory dir)
+                   (invoke #+glib-compile-schemas
+                           (string-append "--targetdir=" dir)
+                           dir)))))))
+
+    ;; Don't run the hook when there's nothing to do.
+    (if %glib
+        (gexp->derivation "glib-schemas" build
+                          #:local-build? #t
+                          #:substitutable? #f)
+        (return #f))))
+
 (define (gtk-icon-themes manifest)
   "Return a derivation that unions all icon themes from manifest entries and
 creates the GTK+ 'icon-theme.cache' file for each theme."
@@ -1198,6 +1249,7 @@ the entries in MANIFEST."
         fonts-dir-file
         ghc-package-cache-file
         ca-certificate-bundle
+        glib-schemas
         gtk-icon-themes
         gtk-im-modules
         xdg-desktop-database

Message #8 received at 31462 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 宋文武 <iyzsong <at> member.fsf.org>, 31462 <at> debbugs.gnu.org
Subject: Re: [bug#31462] [PATCH] profiles: Add hook to generate
 "gschemas.compiled".
Date: Thu, 17 May 2018 10:57:37 +0200

Hello!

Danny Milosavljevic <dannym <at> scratchpost.org> skribis:

> * guix/profiles.scm (glib-schemas): New procedure.
> (%default-profile-hooks): Add it.

[...]

> +  (mlet %store-monad ((%glib (manifest-lookup-package manifest "glib"))
> +                      ;; XXX: Can't use glib-compile-schemas corresponding
> +                      ;; to the glib referenced by 'manifest'.  Because
> +                      ;; '%glib' can be either a package or store path, and
> +                      ;; there's no way to get the "bin" output for the later.
> +                      (glib-compile-schemas
> +                       -> #~(string-append #+glib:bin
> +                                           "/bin/glib-compile-schemas")))

Oh right, too bad.

宋文武, any comments, since you wrote the existing hooks in that area?

Otherwise LGTM, thank you Danny!

Ludo’.

Message #11 received at 31462 <at> debbugs.gnu.org (full text, mbox):

From: iyzsong <at> member.fsf.org (宋文武)
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>, 31462 <at> debbugs.gnu.org
Subject: Re: [bug#31462] [PATCH] profiles: Add hook to generate
 "gschemas.compiled".
Date: Thu, 17 May 2018 19:55:08 +0800

ludo <at> gnu.org (Ludovic Courtès) writes:

> Hello!
>
> Danny Milosavljevic <dannym <at> scratchpost.org> skribis:
>
>> * guix/profiles.scm (glib-schemas): New procedure.
>> (%default-profile-hooks): Add it.
>
> [...]
>
>> +  (mlet %store-monad ((%glib (manifest-lookup-package manifest "glib"))
>> +                      ;; XXX: Can't use glib-compile-schemas corresponding
>> +                      ;; to the glib referenced by 'manifest'.  Because
>> +                      ;; '%glib' can be either a package or store path, and
>> +                      ;; there's no way to get the "bin" output for the later.
>> +                      (glib-compile-schemas
>> +                       -> #~(string-append #+glib:bin
>> +                                           "/bin/glib-compile-schemas")))
>
> Oh right, too bad.
>
> 宋文武, any comments, since you wrote the existing hooks in that area?
>

Well, I think this situation is not changed.  Our profile hooks
currently use latest version of zlib, gzip, guile-gdbm-ffi, gtk+, ghc
and etc.  We'd like to use packages from the manifest to avoid
additional downloads, but it's not awlays possible...

Message #14 received at 31462 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: iyzsong <at> member.fsf.org (宋文武)
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>, 31462 <at> debbugs.gnu.org
Subject: Re: [bug#31462] [PATCH] profiles: Add hook to generate
 "gschemas.compiled".
Date: Thu, 17 May 2018 17:56:50 +0200

Hey,

iyzsong <at> member.fsf.org (宋文武) skribis:

> ludo <at> gnu.org (Ludovic Courtès) writes:
>
>> Hello!
>>
>> Danny Milosavljevic <dannym <at> scratchpost.org> skribis:
>>
>>> * guix/profiles.scm (glib-schemas): New procedure.
>>> (%default-profile-hooks): Add it.
>>
>> [...]
>>
>>> +  (mlet %store-monad ((%glib (manifest-lookup-package manifest "glib"))
>>> +                      ;; XXX: Can't use glib-compile-schemas corresponding
>>> +                      ;; to the glib referenced by 'manifest'.  Because
>>> +                      ;; '%glib' can be either a package or store path, and
>>> +                      ;; there's no way to get the "bin" output for the later.
>>> +                      (glib-compile-schemas
>>> +                       -> #~(string-append #+glib:bin
>>> +                                           "/bin/glib-compile-schemas")))
>>
>> Oh right, too bad.
>>
>> 宋文武, any comments, since you wrote the existing hooks in that area?
>>
>
> Well, I think this situation is not changed.  Our profile hooks
> currently use latest version of zlib, gzip, guile-gdbm-ffi, gtk+, ghc
> and etc.  We'd like to use packages from the manifest to avoid
> additional downloads, but it's not awlays possible...

Right, so that’s not new.

You’re OK with the rest of the patch?

Thanks for your quick reply!

Ludo’.

Message #17 received at 31462 <at> debbugs.gnu.org (full text, mbox):

From: iyzsong <at> member.fsf.org (宋文武)
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>, 31462 <at> debbugs.gnu.org
Subject: Re: [bug#31462] [PATCH] profiles: Add hook to generate
 "gschemas.compiled".
Date: Sat, 19 May 2018 12:34:09 +0800

ludo <at> gnu.org (Ludovic Courtès) writes:

> Hey,
>
> iyzsong <at> member.fsf.org (宋文武) skribis:
>
>> ludo <at> gnu.org (Ludovic Courtès) writes:
>>
>>> Hello!
>>>
>>> Danny Milosavljevic <dannym <at> scratchpost.org> skribis:
>>>
>>>> * guix/profiles.scm (glib-schemas): New procedure.
>>>> (%default-profile-hooks): Add it.
>>>
>>> [...]
>>>
>>>> +  (mlet %store-monad ((%glib (manifest-lookup-package manifest "glib"))
>>>> +                      ;; XXX: Can't use glib-compile-schemas corresponding
>>>> +                      ;; to the glib referenced by 'manifest'.  Because
>>>> +                      ;; '%glib' can be either a package or store path, and
>>>> +                      ;; there's no way to get the "bin" output for the later.
>>>> +                      (glib-compile-schemas
>>>> +                       -> #~(string-append #+glib:bin
>>>> +                                           "/bin/glib-compile-schemas")))
>>>
>>> Oh right, too bad.
>>>
>>> 宋文武, any comments, since you wrote the existing hooks in that area?
>>>
>>
>> Well, I think this situation is not changed.  Our profile hooks
>> currently use latest version of zlib, gzip, guile-gdbm-ffi, gtk+, ghc
>> and etc.  We'd like to use packages from the manifest to avoid
>> additional downloads, but it's not awlays possible...
>
> Right, so that’s not new.
>
> You’re OK with the rest of the patch?
>

Yes, it looks good to me, and it's useful for the 'dconf-editor'
package, which can edit the dconf database with the support from
available gsetting schemas.

Message #20 received at 31462 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: iyzsong <at> member.fsf.org (宋文武)
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>, 31462 <at> debbugs.gnu.org
Subject: Re: [bug#31462] [PATCH] profiles: Add hook to generate
 "gschemas.compiled".
Date: Sun, 20 May 2018 22:32:56 +0200

iyzsong <at> member.fsf.org (宋文武) skribis:

> ludo <at> gnu.org (Ludovic Courtès) writes:
>
>> Hey,
>>
>> iyzsong <at> member.fsf.org (宋文武) skribis:
>>
>>> ludo <at> gnu.org (Ludovic Courtès) writes:
>>>
>>>> Hello!
>>>>
>>>> Danny Milosavljevic <dannym <at> scratchpost.org> skribis:
>>>>
>>>>> * guix/profiles.scm (glib-schemas): New procedure.
>>>>> (%default-profile-hooks): Add it.
>>>>
>>>> [...]
>>>>
>>>>> +  (mlet %store-monad ((%glib (manifest-lookup-package manifest "glib"))
>>>>> +                      ;; XXX: Can't use glib-compile-schemas corresponding
>>>>> +                      ;; to the glib referenced by 'manifest'.  Because
>>>>> +                      ;; '%glib' can be either a package or store path, and
>>>>> +                      ;; there's no way to get the "bin" output for the later.
>>>>> +                      (glib-compile-schemas
>>>>> +                       -> #~(string-append #+glib:bin
>>>>> +                                           "/bin/glib-compile-schemas")))
>>>>
>>>> Oh right, too bad.
>>>>
>>>> 宋文武, any comments, since you wrote the existing hooks in that area?
>>>>
>>>
>>> Well, I think this situation is not changed.  Our profile hooks
>>> currently use latest version of zlib, gzip, guile-gdbm-ffi, gtk+, ghc
>>> and etc.  We'd like to use packages from the manifest to avoid
>>> additional downloads, but it's not awlays possible...
>>
>> Right, so that’s not new.
>>
>> You’re OK with the rest of the patch?
>>
>
> Yes, it looks good to me, and it's useful for the 'dconf-editor'
> package, which can edit the dconf database with the support from
> available gsetting schemas.

Alright, good to know.  So Danny, go ahead!  :-)

Thanks,
Ludo’.

Message #25 received at 31462 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 31462 <at> debbugs.gnu.org, 30642 <at> debbugs.gnu.org
Subject: Re: [bug#31462] [PATCH] profiles: Add hook to generate
 "gschemas.compiled".
Date: Fri, 25 May 2018 11:16:30 +0200

Hi Danny,

Danny Milosavljevic <dannym <at> scratchpost.org> skribis:

> * guix/profiles.scm (glib-schemas): New procedure.
> (%default-profile-hooks): Add it.

I just tried:

  guix environment --ad-hoc libreoffice -- libreoffice

which at some point shows:

  No schema files found: doing nothing.

and it doesn’t fix the file open dialog crash reported at
<https://bugs.gnu.org/30642>.  Any idea?

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.