GNU bug report logs - #3146
ns: mac-fix-env: CFLAGS / needed?

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 3146 in the body.
You can then email your comments to 3146 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: David Reitter <david.reitter <at> gmail.com>
To: emacs-pretest-bug <at> gnu.org
Subject: ns: mac-fix-env: CFLAGS / needed?
Date: Tue, 28 Apr 2009 11:03:22 -0400

[Message part 1 (text/plain, inline)]

the mac-fix-env program is compiled without the CFLAGS.  See patch  
below.

However, I believe the program is flawed in other ways, given that  
Leopard provides a method (using /etc/paths) to set the environment  
that, I believe, supersedes the former environment.plist technique.

If that is true, we should either fix mac-fix-env or get rid of it.   
(It's also duplicated functionality, given that there is an import  
function in Lisp for this).




diff --git a/lib-src/Makefile.in b/lib-src/Makefile.in
index 612cc94..ffdeacc 100644
--- a/lib-src/Makefile.in
+++ b/lib-src/Makefile.in
@@ -451,4 +451,4 @@ update-game-score.o: ${srcdir}/update-game- 
score.c ../src/config.h $(GETOPT_H)
 	  -DHAVE_SHARED_GAME_DIR="\"$(gamedir)\""

 mac-fix-env: ${srcdir}/mac-fix-env.m
-	$(CC) -o mac-fix-env ${srcdir}/mac-fix-env.m -prebind -framework  
Foundation
+	$(CC) ${ALL_CFLAGS} -o mac-fix-env ${srcdir}/mac-fix-env.m -prebind - 
framework Foundation

[smime.p7s (application/pkcs7-signature, attachment)]

Message #12 received at 3146 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Adrian Robert <adrian.b.robert <at> gmail.com>
To: 3146 <at> debbugs.gnu.org
Cc: David Reitter <david.reitter <at> gmail.com>
Date: Sun, 31 May 2009 12:54:24 +0700

I vote for getting rid of it due to the duplication, and the fact  
that people either don't know about it or don't like it.  Also if it  
would require handling Leopard and Tiger (which is still a viable,  
heavily used OS) separately, that is a pain.

Message #17 received at 3146 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Adrian Robert <adrian.b.robert <at> gmail.com>
Cc: 3146 <at> debbugs.gnu.org, David Reitter <david.reitter <at> gmail.com>
Subject: Re: bug#3146:
Date: Sun, 31 May 2009 11:14:36 -0400

> I vote for getting rid of it due to the duplication, and the fact that
> people either don't know about it or don't like it.  Also if it  would
> require handling Leopard and Tiger (which is still a viable,  heavily used
> OS) separately, that is a pain.

Getting rid of code specific to proprietary platforms always sounds good
to me,


        Stefan

Message #22 received at 3146 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>, 3146 <at> debbugs.gnu.org
Cc: adrian.b.robert <at> gmail.com, david.reitter <at> gmail.com
Subject: Re: bug#3146:
Date: Mon, 01 Jun 2009 10:59:32 -0400

Who or what truncated the rest of the Subject line for this bug
report?

Message #27 received at 3146 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Adrian Robert <adrian.b.robert <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 3146 <at> debbugs.gnu.org
Subject: Re: bug#3146:
Date: Tue, 2 Jun 2009 17:06:36 +0700

On Jun 1, 2009, at 9:59 PM, Eli Zaretskii wrote:

> Who or what truncated the rest of the Subject line for this bug
> report?

If you hit "reply" on the web interface, it does not transfer the  
subject automatically.  I don't always remember to manually copy it.

Message #32 received at 3146 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Adrian Robert <adrian.b.robert <at> gmail.com>
Cc: 3146 <at> debbugs.gnu.org
Subject: Re: bug#3146:
Date: Tue, 02 Jun 2009 12:09:47 -0400

> Cc: 3146 <at> emacsbugs.donarmstrong.com
> From: Adrian Robert <adrian.b.robert <at> gmail.com>
> Date: Tue, 2 Jun 2009 17:06:36 +0700
> 
> 
> On Jun 1, 2009, at 9:59 PM, Eli Zaretskii wrote:
> 
> > Who or what truncated the rest of the Subject line for this bug
> > report?
> 
> If you hit "reply" on the web interface, it does not transfer the  
> subject automatically.  I don't always remember to manually copy it.

Check the headers: it wasn't my mail to which I was responding.

I was asking who or what truncated the subject of this discussion
somewhere along the way.  The subject is now unreadable by humans,
because it includes on the bug number, but not its description.

Message #37 received at 3146 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Adrian Robert <adrian.b.robert <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 3146 <at> debbugs.gnu.org, David Reitter <david.reitter <at> gmail.com>
Subject: Re: bug#3146:
Date: Mon, 8 Jun 2009 15:21:45 +0700

On May 31, 2009, at 10:14 PM, Stefan Monnier wrote:

>> I vote for getting rid of it due to the duplication, and the fact  
>> that
>> people either don't know about it or don't like it.  Also if it   
>> would
>> require handling Leopard and Tiger (which is still a viable,   
>> heavily used
>> OS) separately, that is a pain.
>
> Getting rid of code specific to proprietary platforms always sounds  
> good
> to me,

Would this be OK for 23.1 or wait for 23.2?  As David says there is  
an alternative (also platform-specific) solution for the problem it  
solves for users, and I don't believe many people use it anyway.

Message #42 received at 3146 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Adrian Robert <adrian.b.robert <at> gmail.com>
Cc: 3146 <at> debbugs.gnu.org, David Reitter <david.reitter <at> gmail.com>
Subject: Re: bug#3146:
Date: Mon, 08 Jun 2009 11:42:15 -0400

> Would this be OK for 23.1 or wait for 23.2?

I think it's OK for 23.1.


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.