From debbugs-submit-bounces@debbugs.gnu.org Tue May 15 04:32:09 2018 Received: (at submit) by debbugs.gnu.org; 15 May 2018 08:32:09 +0000 Received: from localhost ([127.0.0.1]:34940 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fIVNR-0007SR-F2 for submit@debbugs.gnu.org; Tue, 15 May 2018 04:32:09 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46398) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fIVNP-0007S1-Sg for submit@debbugs.gnu.org; Tue, 15 May 2018 04:32:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fIVNJ-0008Un-SN for submit@debbugs.gnu.org; Tue, 15 May 2018 04:32:02 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:54230) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fIVNJ-0008Ue-PY for submit@debbugs.gnu.org; Tue, 15 May 2018 04:32:01 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37346) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fIVN9-0007Ra-Mj for guix-patches@gnu.org; Tue, 15 May 2018 04:32:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fIVN3-0008Jo-UT for guix-patches@gnu.org; Tue, 15 May 2018 04:31:51 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57779) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fIVMw-0008FK-UH; Tue, 15 May 2018 04:31:38 -0400 Received: from [193.50.110.240] (port=59636 helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fIVMw-0006SZ-Bb; Tue, 15 May 2018 04:31:38 -0400 From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: guix-patches@gnu.org Subject: [PATCH] union: Do not warn about harmless collissions. Date: Tue, 15 May 2018 10:31:19 +0200 Message-Id: <20180515083119.12788-1-ludo@gnu.org> X-Mailer: git-send-email 2.17.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Until now we'd get pointless messages like: warning: collision encountered: /gnu/store/…-gtk-icon-themes/share/icons/hicolor/icon-theme.cache /gnu/store/…-inkscape-0.92.3/share/icons/hicolor/icon-theme.cache warning: choosing /gnu/store/…-gtk-icon-themes/share/icons/hicolor/icon-theme.cache * guix/build/union.scm (%harmless-collisions): New variable. (warn-about-collision): Honor it. --- guix/build/union.scm | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/guix/build/union.scm b/guix/build/union.scm index 24b366af4..fff795c4d 100644 --- a/guix/build/union.scm +++ b/guix/build/union.scm @@ -81,14 +81,23 @@ identical, #f otherwise." (or (eof-object? n1) (loop)))))))))))))) +(define %harmless-collisions + ;; This is a list of files that are known to collide, but for which emitting + ;; a warning doesn't make sense. For example, "icon-theme.cache" is + ;; regenerated by a profile hook which shadows the file provided by + ;; individual packages, and "gschemas.compiled" is made available to + ;; applications via 'glib-or-gtk-build-system'. + '("icon-theme.cache" "gschemas.compiled")) + (define (warn-about-collision files) "Handle the collision among FILES by emitting a warning and choosing the first one of THEM." - (format (current-error-port) - "~%warning: collision encountered:~%~{ ~a~%~}" - files) (let ((file (first files))) - (format (current-error-port) "warning: choosing ~a~%" file) + (unless (member (basename file) %harmless-collisions) + (format (current-error-port) + "~%warning: collision encountered:~%~{ ~a~%~}" + files) + (format (current-error-port) "warning: choosing ~a~%" file)) file)) (define* (union-build output inputs -- 2.17.0 From debbugs-submit-bounces@debbugs.gnu.org Tue May 15 08:30:00 2018 Received: (at 31458) by debbugs.gnu.org; 15 May 2018 12:30:01 +0000 Received: from localhost ([127.0.0.1]:35158 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fIZ5c-0000JD-GO for submit@debbugs.gnu.org; Tue, 15 May 2018 08:30:00 -0400 Received: from dd26836.kasserver.com ([85.13.145.193]:56662) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fIZ5Y-0000J3-Qg for 31458@debbugs.gnu.org; Tue, 15 May 2018 08:29:57 -0400 Received: from localhost (213162073015.public.t-mobile.at [213.162.73.15]) by dd26836.kasserver.com (Postfix) with ESMTPSA id 25C8F3360141; Tue, 15 May 2018 14:29:54 +0200 (CEST) Date: Tue, 15 May 2018 14:29:43 +0200 From: Danny Milosavljevic To: Ludovic =?ISO-8859-1?Q?Court=E8s?= Subject: Re: [bug#31458] [PATCH] union: Do not warn about harmless collissions. Message-ID: <20180515142446.524bb6ff@scratchpost.org> In-Reply-To: <20180515083119.12788-1-ludo@gnu.org> References: <20180515083119.12788-1-ludo@gnu.org> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/krgtWldItOVNbvLd=KV_m_E"; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 31458 Cc: 31458@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --Sig_/krgtWldItOVNbvLd=KV_m_E Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Ludo, On Tue, 15 May 2018 10:31:19 +0200 Ludovic Court=C3=A8s wrote: > Until now we'd get pointless messages like: >=20 > warning: collision encountered: > /gnu/store/=E2=80=A6-gtk-icon-themes/share/icons/hicolor/icon-theme.c= ache > /gnu/store/=E2=80=A6-inkscape-0.92.3/share/icons/hicolor/icon-theme.c= ache > warning: choosing /gnu/store/=E2=80=A6-gtk-icon-themes/share/icons/hico= lor/icon-theme.cache Hmm, I guess the icon-theme.cache one is harmless enough - however, there s= houldn't be many of those left anyway. Is there an easy way to check the store of h= ydra or something which packages still have those files? I've fixed inkscape now. > +(define %harmless-collisions > + ;; This is a list of files that are known to collide, but for which em= itting > + ;; a warning doesn't make sense. For example, "icon-theme.cache" is > + ;; regenerated by a profile hook which shadows the file provided by > + ;; individual packages, and "gschemas.compiled" is made available to > + ;; applications via 'glib-or-gtk-build-system'. > + '("icon-theme.cache" "gschemas.compiled")) However, about gschemas.compiled I'm not sure yet. How do we ensure that glib-or-gtk-build-system is actually used for package= s that need it? libreoffice has some problem that makes it crash every time it tries to ope= n a file dialog - I wonder if that's related (libreoffice uses gnu-build-system= ). But glib-or-gtk-build-system expicitly generates gschemas.compiled, ensurin= g a collision - what's up with that? Shouldn't there be a profile hook for it instead? There doesn't seem to be= one. --Sig_/krgtWldItOVNbvLd=KV_m_E Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlr60rcACgkQ5xo1VCww uqUarQf/VSghkGKK3UWXe9Qvh+zRrenNxMfenLNy73d4+IEBQpUTSXf4L2RS+Lxx wyshLTaX/GiFpjyGEnGMHJknSGsPKjzgTtwLNxOoC3KBuD2QIxzRuhAM+zLZPVz7 Yz3mC0FV+MBRXqMtZXxnACr5nXc5h0OhfcVr76nvU8xyXUgUFuN9KhdjOzPOCprJ 1YMUfhMQJwklqIaLlHk0korLp/Q8ynvx15+e5/NMlC+mc9m4QxsqT6bBC33cyBTI pT5ZLVhixI8pzETMtT8A+GxyuOZkba5QwxjENKbATXhK1ndnDmM1m1RzEn+xlz5r CKfqV6JLrWG0aPVAptfxkGsGh3y/Xg== =/y1F -----END PGP SIGNATURE----- --Sig_/krgtWldItOVNbvLd=KV_m_E-- From debbugs-submit-bounces@debbugs.gnu.org Tue May 15 08:43:33 2018 Received: (at 31458) by debbugs.gnu.org; 15 May 2018 12:43:33 +0000 Received: from localhost ([127.0.0.1]:35163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fIZIi-0000cR-Tp for submit@debbugs.gnu.org; Tue, 15 May 2018 08:43:33 -0400 Received: from dd26836.kasserver.com ([85.13.145.193]:57658) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fIZIg-0000cJ-Ty for 31458@debbugs.gnu.org; Tue, 15 May 2018 08:43:32 -0400 Received: from localhost (213162073015.public.t-mobile.at [213.162.73.15]) by dd26836.kasserver.com (Postfix) with ESMTPSA id 1398D3360204; Tue, 15 May 2018 14:43:28 +0200 (CEST) Date: Tue, 15 May 2018 14:43:19 +0200 From: Danny Milosavljevic To: Ludovic =?ISO-8859-1?Q?Court=E8s?= Subject: Re: [bug#31458] [PATCH] union: Do not warn about harmless collissions. Message-ID: <20180515144319.69768fee@scratchpost.org> In-Reply-To: <20180515083119.12788-1-ludo@gnu.org> References: <20180515083119.12788-1-ludo@gnu.org> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/7fTojM6EqxEM2Ll/duAExGq"; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 31458 Cc: 31458@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --Sig_/7fTojM6EqxEM2Ll/duAExGq Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable >Re: [bug#31458] [PATCH] union: Do not warn about harmless collissions. typo ------------------------------------------------------------^ --Sig_/7fTojM6EqxEM2Ll/duAExGq Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlr61ecACgkQ5xo1VCww uqVU+AgAiGI8g0/U3Yn+FHBpfnbAqykBglSPM/dlYz+H4Y9KavTJUWkbdMfS7bP4 6v72BKYJAkLRiW4XNQOurldDRnOwXaOA/oLwTxeWT7+oPEAJyyooTGt7K4w244X6 w3P8CU+9QSMAPxzjnOqZPNf2zt7o7uKzNgrcFvSzeq7vdMfAs2iiavQ/xh8J+LjY weErnJFLKfR2GlUgd6n6ZxpZmcS3cn0ZTaLid8XTsL0Zeps3vn/c0nbe7iV4ru7N fPocVdiMazcr4CUwXcQJCs7+mN7AnCIGsLKBvCjd+MNet0Kggs/PcrdRZMzCdZ++ l6CMkGDdLpxGIoK4z5jZSxYRfATjPA== =F4pL -----END PGP SIGNATURE----- --Sig_/7fTojM6EqxEM2Ll/duAExGq-- From debbugs-submit-bounces@debbugs.gnu.org Wed May 16 04:58:11 2018 Received: (at 31458) by debbugs.gnu.org; 16 May 2018 08:58:11 +0000 Received: from localhost ([127.0.0.1]:36360 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fIsGA-0001KG-Uw for submit@debbugs.gnu.org; Wed, 16 May 2018 04:58:11 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55904) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fIsG9-0001K1-Bv for 31458@debbugs.gnu.org; Wed, 16 May 2018 04:58:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fIsFz-0002IK-T2 for 31458@debbugs.gnu.org; Wed, 16 May 2018 04:58:04 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49209) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fIsFz-0002ID-Oo; Wed, 16 May 2018 04:57:59 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=45018 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fIsFz-0000pw-5j; Wed, 16 May 2018 04:57:59 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Danny Milosavljevic Subject: Re: [bug#31458] [PATCH] union: Do not warn about harmless collissions. References: <20180515083119.12788-1-ludo@gnu.org> <20180515142446.524bb6ff@scratchpost.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 27 =?utf-8?Q?Flor=C3=A9al?= an 226 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Wed, 16 May 2018 10:57:57 +0200 In-Reply-To: <20180515142446.524bb6ff@scratchpost.org> (Danny Milosavljevic's message of "Tue, 15 May 2018 14:29:43 +0200") Message-ID: <87zi10gep6.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31458 Cc: 31458@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Hello, Danny Milosavljevic skribis: > On Tue, 15 May 2018 10:31:19 +0200 > Ludovic Court=C3=A8s wrote: > >> Until now we'd get pointless messages like: >>=20 >> warning: collision encountered: >> /gnu/store/=E2=80=A6-gtk-icon-themes/share/icons/hicolor/icon-theme.= cache >> /gnu/store/=E2=80=A6-inkscape-0.92.3/share/icons/hicolor/icon-theme.= cache >> warning: choosing /gnu/store/=E2=80=A6-gtk-icon-themes/share/icons/hic= olor/icon-theme.cache > > Hmm, I guess the icon-theme.cache one is harmless enough - however, there= shouldn't > be many of those left anyway. Is there an easy way to check the store of= hydra or something > which packages still have those files? No, but everyone can check in their own profile. :-) > I've fixed inkscape now. Since =E2=80=9Cfixing=E2=80=9D packages like you just did is a manual step,= I think it=E2=80=99s still fine to ignore =E2=80=9Cicon-theme.cache=E2=80=9D collisions. WDYT? >> +(define %harmless-collisions >> + ;; This is a list of files that are known to collide, but for which e= mitting >> + ;; a warning doesn't make sense. For example, "icon-theme.cache" is >> + ;; regenerated by a profile hook which shadows the file provided by >> + ;; individual packages, and "gschemas.compiled" is made available to >> + ;; applications via 'glib-or-gtk-build-system'. >> + '("icon-theme.cache" "gschemas.compiled")) > > However, about gschemas.compiled I'm not sure yet. > > How do we ensure that glib-or-gtk-build-system is actually used for packa= ges that > need it? I don=E2=80=99t think we can. :-/ > libreoffice has some problem that makes it crash every time it tries to o= pen a > file dialog - I wonder if that's related (libreoffice uses gnu-build-syst= em). It is, see . > But glib-or-gtk-build-system expicitly generates gschemas.compiled, ensur= ing a > collision - what's up with that? glib-or-gtk-build-system wraps binaries so that they refer to the right gschemas.compiled, so in that case the gschemas.compiled file that ends up in the profile doesn=E2=80=99t matter at all. > Shouldn't there be a profile hook for it instead? There doesn't seem to = be one. Maybe, yes, though I=E2=80=99m not sure how that=E2=80=99d work (and would = it be fast enough?). This seems to be orthogonal to this patch, though: we can remove the collision warnings for these files today, because there=E2=80=99s nothing u= sers can do about them and they=E2=80=99re effectively harmless, and later on, i= f we have better gschemas.compiled handling, we can always let them through again. Thoughts? Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Wed May 16 07:07:24 2018 Received: (at 31458) by debbugs.gnu.org; 16 May 2018 11:07:24 +0000 Received: from localhost ([127.0.0.1]:36436 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fIuHE-0006R7-KA for submit@debbugs.gnu.org; Wed, 16 May 2018 07:07:24 -0400 Received: from dd26836.kasserver.com ([85.13.145.193]:42738) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fIuHD-0006Qz-Bg for 31458@debbugs.gnu.org; Wed, 16 May 2018 07:07:24 -0400 Received: from localhost (unknown [193.170.94.190]) by dd26836.kasserver.com (Postfix) with ESMTPSA id 908F233602AE; Wed, 16 May 2018 13:07:21 +0200 (CEST) Date: Wed, 16 May 2018 13:07:10 +0200 From: Danny Milosavljevic To: ludo@gnu.org (Ludovic =?ISO-8859-1?Q?Court=E8s?=) Subject: Re: [bug#31458] [PATCH] union: Do not warn about harmless collissions. Message-ID: <20180516130710.5963fc6b@scratchpost.org> In-Reply-To: <87zi10gep6.fsf@gnu.org> References: <20180515083119.12788-1-ludo@gnu.org> <20180515142446.524bb6ff@scratchpost.org> <87zi10gep6.fsf@gnu.org> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/DjG.1Pcev+/HmR5GFTJV7S0"; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 31458 Cc: 31458@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --Sig_/DjG.1Pcev+/HmR5GFTJV7S0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Ludo, On Wed, 16 May 2018 10:57:57 +0200 ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > Since =E2=80=9Cfixing=E2=80=9D packages like you just did is a manual ste= p, I think it=E2=80=99s > still fine to ignore =E2=80=9Cicon-theme.cache=E2=80=9D collisions. WDYT? Definitely. > > However, about gschemas.compiled I'm not sure yet. > > > > How do we ensure that glib-or-gtk-build-system is actually used for pac= kages that > > need it? =20 >=20 > I don=E2=80=99t think we can. :-/ >=20 > > libreoffice has some problem that makes it crash every time it tries to= open a > > file dialog - I wonder if that's related (libreoffice uses gnu-build-sy= stem). =20 >=20 > It is, see . >=20 > > But glib-or-gtk-build-system expicitly generates gschemas.compiled, ens= uring a > > collision - what's up with that? =20 >=20 > glib-or-gtk-build-system wraps binaries so that they refer to the right > gschemas.compiled, so in that case the gschemas.compiled file that ends > up in the profile doesn=E2=80=99t matter at all. >=20 > > Shouldn't there be a profile hook for it instead? There doesn't seem t= o be one. =20 >=20 > Maybe, yes, though I=E2=80=99m not sure how that=E2=80=99d work (and woul= d it be fast > enough?). I wrote one in bug 31462. Seems to be quite fast. But let's think about w= hether we want it, and whether we want it in addition to the wrapper. (libreoffice works with it now FWIW) > This seems to be orthogonal to this patch, though: we can remove the > collision warnings for these files today, because there=E2=80=99s nothing= users > can do about them and they=E2=80=99re effectively harmless, and later on,= if we > have better gschemas.compiled handling, we can always let them through > again. Yeah, I just wanted to make sure we are not hiding them if they are the only indication that something will break horribly with the program. (see libreoffice) But since the wrapper needs gschemas.compiled, we can't use it as indicator for missing-glib-or-gtk-build-system anyway, so: LGTM! --Sig_/DjG.1Pcev+/HmR5GFTJV7S0 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlr8EN4ACgkQ5xo1VCww uqUpAAgAhG/POxz2gpABxdYpi+dyNeYB03gtCd39OEKC/oLPfbN/m3SRNhvis9C5 5DZi/Vc76SIpz+EflTghvlme68FHAKdwWP/Qy3dB6Na1L0wPbEr/DE9geOzlOLGl 6ZzVnRQDHErUrA/jVhQUCK6VVJCFp5ETP2PcNQJrsTwfnPeL/b9Qe4Yv2sVsgz7L 5Si3XOfmg66gC+QMjrT7z9mZJ3lw8jPHdIrqfM88KjQ/z86/5GFyGRYk/WewCLvK igjLG9X7+cSd1dDZOt1HdL6/mr+ulNq21JXOSMSNuzEEL/DMwuIp2KqnHnvnU/fc pYaqyeklTdXA2iWpihKdThx4QEgH1w== =4h9a -----END PGP SIGNATURE----- --Sig_/DjG.1Pcev+/HmR5GFTJV7S0-- From debbugs-submit-bounces@debbugs.gnu.org Thu May 17 04:50:59 2018 Received: (at 31458-done) by debbugs.gnu.org; 17 May 2018 08:50:59 +0000 Received: from localhost ([127.0.0.1]:37903 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fJEcl-0006yv-1h for submit@debbugs.gnu.org; Thu, 17 May 2018 04:50:59 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38022) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fJEcj-0006yi-5B for 31458-done@debbugs.gnu.org; Thu, 17 May 2018 04:50:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fJEca-0003ah-Qn for 31458-done@debbugs.gnu.org; Thu, 17 May 2018 04:50:51 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43232) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fJEca-0003aS-NM; Thu, 17 May 2018 04:50:48 -0400 Received: from [193.50.110.196] (port=38840 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fJEca-0007rm-1u; Thu, 17 May 2018 04:50:48 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Danny Milosavljevic Subject: Re: [bug#31458] [PATCH] union: Do not warn about harmless collissions. References: <20180515083119.12788-1-ludo@gnu.org> <20180515142446.524bb6ff@scratchpost.org> <87zi10gep6.fsf@gnu.org> <20180516130710.5963fc6b@scratchpost.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 28 =?utf-8?Q?Flor=C3=A9al?= an 226 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 17 May 2018 10:50:45 +0200 In-Reply-To: <20180516130710.5963fc6b@scratchpost.org> (Danny Milosavljevic's message of "Wed, 16 May 2018 13:07:10 +0200") Message-ID: <87po1u4qe2.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31458-done Cc: 31458-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Hi Danny, Danny Milosavljevic skribis: > On Wed, 16 May 2018 10:57:57 +0200 > ludo@gnu.org (Ludovic Court=C3=A8s) wrote: [...] >> > Shouldn't there be a profile hook for it instead? There doesn't seem = to be one.=20=20 >>=20 >> Maybe, yes, though I=E2=80=99m not sure how that=E2=80=99d work (and wou= ld it be fast >> enough?). > > I wrote one in bug 31462. Seems to be quite fast. But let's think about= whether > we want it, and whether we want it in addition to the wrapper. > > (libreoffice works with it now FWIW) Awesome! >> This seems to be orthogonal to this patch, though: we can remove the >> collision warnings for these files today, because there=E2=80=99s nothin= g users >> can do about them and they=E2=80=99re effectively harmless, and later on= , if we >> have better gschemas.compiled handling, we can always let them through >> again. > > Yeah, I just wanted to make sure we are not hiding them if they are the o= nly > indication that something will break horribly with the program. > (see libreoffice) Sure, that makes sense. In this particular case the gschemas.compiled collision did not tell us much: some applications (e.g., Evince) would work fine because they used glib-or-gtk-build-system, while others (e.g., LibreOffice) would fail. > But since the wrapper needs gschemas.compiled, we can't use it as indicat= or > for missing-glib-or-gtk-build-system anyway, so: > > LGTM! Alright, committed! :-) Thank you, Ludo=E2=80=99. From unknown Tue Jun 24 05:10:08 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 14 Jun 2018 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator