From debbugs-submit-bounces@debbugs.gnu.org Mon May 14 20:03:29 2018 Received: (at submit) by debbugs.gnu.org; 15 May 2018 00:03:29 +0000 Received: from localhost ([127.0.0.1]:34767 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fINRA-0001nx-T7 for submit@debbugs.gnu.org; Mon, 14 May 2018 20:03:29 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53333) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fINR9-0001nl-RV for submit@debbugs.gnu.org; Mon, 14 May 2018 20:03:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fINR3-0004AC-BR for submit@debbugs.gnu.org; Mon, 14 May 2018 20:03:22 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:50561) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fINR3-00049G-6l for submit@debbugs.gnu.org; Mon, 14 May 2018 20:03:21 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44292) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fINR1-0001Kz-Bf for bug-gnu-emacs@gnu.org; Mon, 14 May 2018 20:03:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fINQy-0003to-5x for bug-gnu-emacs@gnu.org; Mon, 14 May 2018 20:03:19 -0400 Received: from mail-it0-x232.google.com ([2607:f8b0:4001:c0b::232]:39031) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fINQx-0003s5-Ty for bug-gnu-emacs@gnu.org; Mon, 14 May 2018 20:03:16 -0400 Received: by mail-it0-x232.google.com with SMTP id c3-v6so15619019itj.4 for ; Mon, 14 May 2018 17:03:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=VcTOYOZeyK2s5twPx/ojop1VrLyOP6jQU2LR0vQidhY=; b=Wt992hv4RrKwACGr08C/tSN1OmkAVNnsFg4MGIKV0Z7glmPdVG+GPFz+hN56OW1R0u P1u9wGOzMxBI3dlfmzZuqA1aYo8P+lT0PvQ2OFGUokleLC/6JHbOu0CzZ8/uh4Jl3ZAj K+sMHtm/HqmvjSYMwnqYCypy9zXHjp+PIwk0BCHPumAGZLFd6AjR8eOHsYYTNnn8l6+p bAv3gzgBnEvFM4k2ghQlTn+26XGi6PVYdd260fwks0Fk/mbPzLRogKesuPh9wHP7uu2l xTaxEjvXGFpj7c7kBhxkXcPUfQSO8jFac06nWjCa5ZOsFNf7VhzhFA/zSVrJSDE4IPYk wHIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=VcTOYOZeyK2s5twPx/ojop1VrLyOP6jQU2LR0vQidhY=; b=fTFiWZQrhmPxb2bSOunqEkJxTiq+3FKaJI1emYsOZsHsZBovMZjm3R+voRM693Y/4V cgN6EKrEFo7GUU/dKgfUVPkw739HSeysWsvDQ9Vn88GULomnRxQ0HOMVQNJoXV4QyvIJ /eDjJkSu1COIsaedlPn1mP3ct/IfDv9kwbOvj4hrpCA+k2ixzD9g0EWuhEoKYIsOSQ4h e9fCQXKK/9R9q5SvCginw1SE03j1tb9M/6pZ9OnSl6+E9VLyZ00puIcHtUDiz6v7gm9I qS9X3sgqXkoVwIdQVk3+sfRALce7UVe0rtcUz7NNqEQdQ6yFI4TsjzBwJoBxUK1bc8WD b20g== X-Gm-Message-State: ALKqPwfrA2ErEHOmRYrJXj2iB/ZF3HLiRBsOU8CpEIrBDMOLLTtWB8Mh FkWACkI3lxS59zdciAz8btc+yg== X-Google-Smtp-Source: AB8JxZp+dy0koP5hZRYGBDxdDvtuxmNlbNQqDhispIMe1ucSpghvxbiQAEgGK99qnVNUDPRUJuH9tw== X-Received: by 2002:a6b:9a91:: with SMTP id c139-v6mr11838765ioe.99.1526342595075; Mon, 14 May 2018 17:03:15 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id d143-v6sm4754116itd.35.2018.05.14.17.03.13 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 14 May 2018 17:03:13 -0700 (PDT) From: Noam Postavsky To: bug-gnu-emacs@gnu.org Subject: 27.0.50; Move starttls.el and tls.el to lisp/obsolete/ Date: Mon, 14 May 2018 20:03:12 -0400 Message-ID: <87in7pkcov.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --=-=-= Content-Type: text/plain Tags: patch Severity: minor Use of an external program such as gnutls-cli instead of the builtin libgnutls based functions is already de-facto obsolete: see bugs 15905, 23759, 27658, and 31339. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=v1-0001-Move-tls.el-and-starttls.el-to-lisp-obsolete.patch Content-Description: patch >From e87446e3f1cdecbb270337fe158a702615b5ac54 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Thu, 13 Jul 2017 08:52:39 -0400 Subject: [PATCH v1] Move tls.el and starttls.el to lisp/obsolete/ * lisp/obsolete/tls.el: Moved from lisp/net/tls.el. * lisp/gnus/nnimap.el: * lisp/url/url-http.el: Don't require tls, since it's obsolete. * lisp/net/network-stream.el: Only require tls if we actually try to use it (i.e., when (gnutls-available-p) returns nil). Declare some functions to fix compilation warnings. * lisp/obsolete/starttls.el: Moved from lisp/net/starttls.el. * lisp/net/sieve-manage.el: * lisp/net/network-stream.el: Don't require `starttls' at the top-level, declare the variables and functions used instead. (network-stream-open-starttls): Only require `starttls' if needed (i.e., gnutls-available-p fails). * etc/NEWS: Announce obsoletion. --- etc/NEWS | 3 +++ lisp/gnus/nnimap.el | 1 - lisp/net/network-stream.el | 22 ++++++++++++++++++---- lisp/net/sieve-manage.el | 1 - lisp/{net => obsolete}/starttls.el | 0 lisp/{net => obsolete}/tls.el | 0 lisp/url/url-http.el | 1 - 7 files changed, 21 insertions(+), 7 deletions(-) rename lisp/{net => obsolete}/starttls.el (100%) rename lisp/{net => obsolete}/tls.el (100%) diff --git a/etc/NEWS b/etc/NEWS index 77ef3f3457..8193545d9f 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -419,6 +419,9 @@ or NextCloud hosted files and directories. ** The options.el library has been removed. It was obsolete since Emacs 22.1, replaced by customize. +** The tls.el and starttls.el libraries are now marked obsolete. +Use of builtin of function based on libgnutls is recommended instead. + ** Message diff --git a/lisp/gnus/nnimap.el b/lisp/gnus/nnimap.el index dc51b5f0f0..3b39731927 100644 --- a/lisp/gnus/nnimap.el +++ b/lisp/gnus/nnimap.el @@ -36,7 +36,6 @@ (require 'nnoo) (require 'netrc) (require 'utf7) -(require 'tls) (require 'parse-time) (require 'nnmail) diff --git a/lisp/net/network-stream.el b/lisp/net/network-stream.el index 19e0c6421f..a0589e25a4 100644 --- a/lisp/net/network-stream.el +++ b/lisp/net/network-stream.el @@ -42,14 +42,20 @@ ;;; Code: -(require 'tls) -(require 'starttls) (require 'auth-source) (require 'nsm) (require 'puny) +(declare-function starttls-available-p "starttls" ()) +(declare-function starttls-negotiate "starttls" (process)) + (autoload 'gnutls-negotiate "gnutls") (autoload 'open-gnutls-stream "gnutls") +(defvar starttls-extra-arguments) +(defvar starttls-extra-args) +(defvar starttls-use-gnutls) +(defvar starttls-gnutls-program) +(defvar starttls-program) ;;;###autoload (defun open-network-stream (name buffer host service &rest parameters) @@ -255,7 +261,8 @@ network-stream-open-starttls (or (gnutls-available-p) (and (or require-tls (plist-get parameters :use-starttls-if-possible)) - (starttls-available-p)))) + (require 'starttls) + (starttls-available-p)))) (not (eq (plist-get parameters :type) 'plain))) ;; If using external STARTTLS, drop this connection and start ;; anew with `starttls-open-stream'. @@ -336,7 +343,8 @@ network-stream-open-starttls ;; See `starttls-available-p'. If this predicate ;; changes to allow running under Windows, the error ;; message below should be amended. - (if (memq system-type '(windows-nt ms-dos)) + (if (or (memq system-type '(windows-nt ms-dos)) + (not (featurep 'starttls))) (concat "Emacs does not support TLS") (concat "Emacs does not support TLS, and no external `" (if starttls-use-gnutls @@ -373,6 +381,8 @@ network-stream-get-response (unless (= start (point)) (buffer-substring start (point))))))) +(declare-function open-tls-stream "tls" (name buffer host port)) + (defun network-stream-open-tls (name buffer host service parameters) (with-current-buffer buffer (let* ((start (point-max)) @@ -380,6 +390,7 @@ network-stream-open-tls (if (gnutls-available-p) (open-gnutls-stream name buffer host service (plist-get parameters :nowait)) + (require 'tls) (open-tls-stream name buffer host service))) (eoc (plist-get parameters :end-of-command))) (if (plist-get parameters :nowait) @@ -406,6 +417,9 @@ network-stream-open-tls (network-stream-command stream capability-command eo-capa) 'tls))))))) +(declare-function format-spec "format-spec" (format spec)) +(declare-function format-spec-make "format-spec" (&rest pairs)) + (defun network-stream-open-shell (name buffer host service parameters) (require 'format-spec) (let* ((capability-command (plist-get parameters :capability-command)) diff --git a/lisp/net/sieve-manage.el b/lisp/net/sieve-manage.el index cd40307238..8c70ae037a 100644 --- a/lisp/net/sieve-manage.el +++ b/lisp/net/sieve-manage.el @@ -77,7 +77,6 @@ (eval-when-compile (require 'cl-lib)) (require 'sasl) -(require 'starttls) (autoload 'sasl-find-mechanism "sasl") (autoload 'auth-source-search "auth-source") diff --git a/lisp/net/starttls.el b/lisp/obsolete/starttls.el similarity index 100% rename from lisp/net/starttls.el rename to lisp/obsolete/starttls.el diff --git a/lisp/net/tls.el b/lisp/obsolete/tls.el similarity index 100% rename from lisp/net/tls.el rename to lisp/obsolete/tls.el diff --git a/lisp/url/url-http.el b/lisp/url/url-http.el index 0b95453b30..53798f77c3 100644 --- a/lisp/url/url-http.el +++ b/lisp/url/url-http.el @@ -1600,7 +1600,6 @@ url-http-options ;; HTTPS. This used to be in url-https.el, but that file collides ;; with url-http.el on systems with 8-character file names. -(require 'tls) (defconst url-https-asynchronous-p t "HTTPS retrievals are asynchronous.") -- 2.11.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue May 15 09:27:54 2018 Received: (at 31457) by debbugs.gnu.org; 15 May 2018 13:27:54 +0000 Received: from localhost ([127.0.0.1]:35225 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fIZze-0001gO-GP for submit@debbugs.gnu.org; Tue, 15 May 2018 09:27:54 -0400 Received: from mail-wr0-f176.google.com ([209.85.128.176]:36709) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fIZzc-0001gB-RB for 31457@debbugs.gnu.org; Tue, 15 May 2018 09:27:53 -0400 Received: by mail-wr0-f176.google.com with SMTP id p4-v6so156347wrh.3 for <31457@debbugs.gnu.org>; Tue, 15 May 2018 06:27:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-copies-to:gmane-reply-to-list :date:in-reply-to:message-id:mime-version; bh=MrAPUMvtdbA3bUFt/R+jY72gjyjIaxElqYFG7JFnhNA=; b=RmW6MYduR4UJiNXvVT9Q2yL65W1zNatj5G7V6dRvtrUqYFXqMlFTnJDBo4rscAomyv y88l2obQA5d1zL181Ma9EQcrWj5IctccoZ2jr/q/b+tkEpWT+3RUiHUcKki1cIMI9l1k jhRTpEdDp5r2c35NBLeSodEMbAJHhdIPtVo1ffuOGw2Y/zfPRQJuCLYeuBY88CQbc7u1 4Sbv+AkwplL5TiVr7VDgh9j+XxWMx36Jhp8mc+KauoGFSXGQKOxM3HCpCKhAU9IFS1Cq APylYaNHObwcgx2l++VGJGNRvdxgPQF63YFkh3Aiy1BY3mS5B/mPmy9xAzArh8m5y5AG 4kuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version; bh=MrAPUMvtdbA3bUFt/R+jY72gjyjIaxElqYFG7JFnhNA=; b=XpbXwv/e6+rih8St9sJ9pL4acYzcLCV0mljjNDw1vBslS7Hugw5me96Ul8Py5fyo1p XHX8Lgp1WWDNVZ9gV3n6ZdeSSkucorxDzeXeHLmHFP+5lbbH0yXFj2QsG+rBYd/HOVdM EntGi/cW80v5JubPCN5HwQsZioLKdLy11kM+dqgJQpk045emoKNDCUyrosGItvxrRVuX 3UoT9viVYi7ctmKDUUYg6bHrxVg19trxjOgyP1X/XdicN2+rtz4c35bYTNYFeUIOSHBt aG2y1AeRO+ehcERouegWNQt1xJFeR4zsF7ETv+uygVJixz45/n218RoDDPy9oSRyCW4q OiGw== X-Gm-Message-State: ALKqPwcIebhQ0Us1oR+4l0iDzVZPeeYxEV3UG7oFgLsR3+n93u5shrBV bVvJWBsysoz3Ky5IY4l6tTfLoWNk X-Google-Smtp-Source: AB8JxZrpum1gi4qYgWf18ZKNYLH0oY2242AVkdYq5nSfDy+80WAf9P2b75UFZeE/fqIKh9XVsL4wjw== X-Received: by 2002:adf:a294:: with SMTP id s20-v6mr10104210wra.114.1526390866757; Tue, 15 May 2018 06:27:46 -0700 (PDT) Received: from rpluim-ubuntu ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id b105-v6sm51792wrd.64.2018.05.15.06.27.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 15 May 2018 06:27:45 -0700 (PDT) From: Robert Pluim To: Noam Postavsky Subject: Re: bug#31457: 27.0.50; Move starttls.el and tls.el to lisp/obsolete/ References: <87in7pkcov.fsf@gmail.com> X-Debbugs-No-Ack: yes Mail-Copies-To: never Gmane-Reply-To-List: yes Date: Tue, 15 May 2018 15:27:42 +0200 In-Reply-To: <87in7pkcov.fsf@gmail.com> (Noam Postavsky's message of "Mon, 14 May 2018 20:03:12 -0400") Message-ID: <87k1s5vyk1.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31457 Cc: 31457@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Noam Postavsky writes: > Tags: patch > Severity: minor > > Use of an external program such as gnutls-cli instead of the builtin > libgnutls based functions is already de-facto obsolete: see bugs 15905, > 23759, 27658, and 31339. Cool. Do we want to remove sslv3 support from tls.el as well, or are we not making any more changes to it now? Robert From debbugs-submit-bounces@debbugs.gnu.org Tue May 15 09:42:20 2018 Received: (at 31457) by debbugs.gnu.org; 15 May 2018 13:42:20 +0000 Received: from localhost ([127.0.0.1]:35239 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fIaDc-00021V-10 for submit@debbugs.gnu.org; Tue, 15 May 2018 09:42:20 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:50295) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fIaDZ-00021F-T0 for 31457@debbugs.gnu.org; Tue, 15 May 2018 09:42:18 -0400 Received: by mail-wm0-f66.google.com with SMTP id t11-v6so1154666wmt.0 for <31457@debbugs.gnu.org>; Tue, 15 May 2018 06:42:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:mail-followup-to:date:in-reply-to :message-id:user-agent:mime-version; bh=lZqgNSXxBuptPfTbeQ2bCvpawPyhPt+YF3xslk2b060=; b=pJt1DEEAJT+TT5Bp8DZTuLeCPo5N3aJRmclEsyeIAiJRkjTCxE1o/K75btog1Ff5XB 1xZHMBHXckwPfHf5Kd8k5ygsjjxoG/T8Cmk5CEd8mcvtNnX2yg9f20WUJbM2etWx+3gf wLnOPVcc9+6KsKaOs4Y8qUNjQ8w2Ak8DouE1ynxYKJUJETEiyncZ6mGlx0eRlaCiAv3O O0cjyqwbLRiqNzsVh6IhsOmgXeSc08cr1mA5R35UtM4x/xtf5SERxWmHOMP3P0+3Gsvh xXTOIXOaCri4q3A7dR59I6CmzCyjeACwPJCukGCJPy1qvs3nJbcZzfAibEBxle6YUh1o JF/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-followup-to :date:in-reply-to:message-id:user-agent:mime-version; bh=lZqgNSXxBuptPfTbeQ2bCvpawPyhPt+YF3xslk2b060=; b=MjCsUrDKX4lERCquUDxRJw/PCVkqWNpmMgWqXR4c/GL0tiW8p+MVN2ZrAqD+GREym7 9W1hrDpjOPc07Tliy1kq52qzT0wTXhVArLjl3XQhJEPmvB8RS9QZOm36O9WNySPpAbTD 9yporVgwLoJhoAh7se/fipt8GigRa5Fw4Z3sx71rm2yz/pF4ot2RSDETTrJYOTVYp8Nj TRxrd66e49aBV3K/j42dzn+gxMyGq5WNRaXDC0nNpyoBFtrjqaEZl40PiczEgJMI4lSr zfg1pl1s2W83LA/KKCEQHFCX9cXfIqznhCgiFmD5PXc6Oal8phcTI8pbB4tfypbAc3Xi HZ+g== X-Gm-Message-State: ALKqPwf1yjAIIssBFYJDWdfWRoY8x37aCJBnwV3AdLdKDqnxAw3e78H1 SPwIT6SruM4YnL2qnK52kLACTngn X-Google-Smtp-Source: AB8JxZoclo/JQjOu/Tt9SIowXmP8wtccekeDgcpeHlIGSvV8p3T/esyAHX2rLEkTY7Jn8N0vBEPALw== X-Received: by 2002:a50:b555:: with SMTP id z21-v6mr18228292edd.223.1526391732217; Tue, 15 May 2018 06:42:12 -0700 (PDT) Received: from localhost ([213.233.148.31]) by smtp.gmail.com with ESMTPSA id a20-v6sm172332eda.82.2018.05.15.06.42.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 15 May 2018 06:42:11 -0700 (PDT) From: "Basil L. Contovounesios" To: Noam Postavsky Subject: Re: bug#31457: 27.0.50; Move starttls.el and tls.el to lisp/obsolete/ References: <87in7pkcov.fsf@gmail.com> Mail-Followup-To: Noam Postavsky , 31457@debbugs.gnu.org Date: Tue, 15 May 2018 14:42:10 +0100 In-Reply-To: <87in7pkcov.fsf@gmail.com> (Noam Postavsky's message of "Mon, 14 May 2018 20:03:12 -0400") Message-ID: <87in7pyr0t.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 31457 Cc: 31457@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > From e87446e3f1cdecbb270337fe158a702615b5ac54 Mon Sep 17 00:00:00 2001 > From: Noam Postavsky > Date: Thu, 13 Jul 2017 08:52:39 -0400 > Subject: [PATCH v1] Move tls.el and starttls.el to lisp/obsolete/ > > diff --git a/etc/NEWS b/etc/NEWS > index 77ef3f3457..8193545d9f 100644 > --- a/etc/NEWS > +++ b/etc/NEWS > @@ -419,6 +419,9 @@ or NextCloud hosted files and directories. > ** The options.el library has been removed. > It was obsolete since Emacs 22.1, replaced by customize. > > +** The tls.el and starttls.el libraries are now marked obsolete. > +Use of builtin of function based on libgnutls is recommended instead. ^^^^ Typo? -- Basil From debbugs-submit-bounces@debbugs.gnu.org Tue May 15 12:58:12 2018 Received: (at 31457) by debbugs.gnu.org; 15 May 2018 16:58:12 +0000 Received: from localhost ([127.0.0.1]:35913 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fIdHA-0006gP-Bn for submit@debbugs.gnu.org; Tue, 15 May 2018 12:58:12 -0400 Received: from eggs.gnu.org ([208.118.235.92]:47753) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fIdH8-0006gC-Ie for 31457@debbugs.gnu.org; Tue, 15 May 2018 12:58:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fIdH0-0008Sh-7e for 31457@debbugs.gnu.org; Tue, 15 May 2018 12:58:05 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37038) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fIdH0-0008Sd-42; Tue, 15 May 2018 12:58:02 -0400 Received: from [176.228.60.248] (port=2453 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fIdGz-0003wV-JY; Tue, 15 May 2018 12:58:02 -0400 Date: Tue, 15 May 2018 19:58:09 +0300 Message-Id: <83zi10kg9q.fsf@gnu.org> From: Eli Zaretskii To: Robert Pluim In-reply-to: <87k1s5vyk1.fsf@gmail.com> (message from Robert Pluim on Tue, 15 May 2018 15:27:42 +0200) Subject: Re: bug#31457: 27.0.50; Move starttls.el and tls.el to lisp/obsolete/ References: <87in7pkcov.fsf@gmail.com> <87k1s5vyk1.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31457 Cc: 31457@debbugs.gnu.org, npostavs@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Robert Pluim > Date: Tue, 15 May 2018 15:27:42 +0200 > Cc: 31457@debbugs.gnu.org > > Cool. Do we want to remove sslv3 support from tls.el as well, or are > we not making any more changes to it now? I see no need to remove anything from a package that becomes obsolete. From debbugs-submit-bounces@debbugs.gnu.org Tue May 15 13:00:23 2018 Received: (at 31457) by debbugs.gnu.org; 15 May 2018 17:00:23 +0000 Received: from localhost ([127.0.0.1]:35917 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fIdJH-0006ko-OK for submit@debbugs.gnu.org; Tue, 15 May 2018 13:00:23 -0400 Received: from eggs.gnu.org ([208.118.235.92]:48370) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fIdJG-0006kb-Iu for 31457@debbugs.gnu.org; Tue, 15 May 2018 13:00:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fIdJ5-0001DR-IQ for 31457@debbugs.gnu.org; Tue, 15 May 2018 13:00:17 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37074) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fIdJ5-0001DF-FY; Tue, 15 May 2018 13:00:11 -0400 Received: from [176.228.60.248] (port=2454 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fIdJ5-0007EN-2s; Tue, 15 May 2018 13:00:11 -0400 Date: Tue, 15 May 2018 20:00:19 +0300 Message-Id: <83y3gkkg64.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky In-reply-to: <87in7pkcov.fsf@gmail.com> (message from Noam Postavsky on Mon, 14 May 2018 20:03:12 -0400) Subject: Re: bug#31457: 27.0.50; Move starttls.el and tls.el to lisp/obsolete/ References: <87in7pkcov.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31457 Cc: 31457@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Noam Postavsky > Date: Mon, 14 May 2018 20:03:12 -0400 > > Use of an external program such as gnutls-cli instead of the builtin > libgnutls based functions is already de-facto obsolete: see bugs 15905, > 23759, 27658, and 31339. Fine with me (modulo the typo in NEWS), but please wait for a week or so to give people who want to object time to do so. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue May 15 20:52:00 2018 Received: (at 31457) by debbugs.gnu.org; 16 May 2018 00:52:00 +0000 Received: from localhost ([127.0.0.1]:36148 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fIkfg-0002kx-LI for submit@debbugs.gnu.org; Tue, 15 May 2018 20:52:00 -0400 Received: from mail-it0-f41.google.com ([209.85.214.41]:53680) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fIkff-0002kk-FQ for 31457@debbugs.gnu.org; Tue, 15 May 2018 20:52:00 -0400 Received: by mail-it0-f41.google.com with SMTP id n64-v6so6302242itb.3 for <31457@debbugs.gnu.org>; Tue, 15 May 2018 17:51:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=2jOFWX1uFBmWlziiAgkwL8q+kcVayPCyYxEStuw5EiA=; b=cXIRdNj3blSznx9j2ErpiWSfpKQJui9yQJWX02Jl4SzXTAYmkoFWCJrJDwV2hmvRGg honLqM/3uZsXaj474WIe2X2I0mE81xKWqf0Db1BDYv3NWHVpvupl7VrDPDJFeVJXFXOZ Ad90YtyKrqx1ho7zXdN6rRhhCRdY8gdk3ITACrI4k98LHOKjy/XENpJKS55mm3YfLyAa IdQjDjk1gmH0KXYYeMEXQ6ULpRT55sE9rx5bTnJ68wvYxmV6DzfU1XifGs/gp+YYtA4E VTxDnqtPQAF7nF9rfQ8xYXyHQa3SWVtOQrw6wfeMISQnFcJADdpPuDS/0XYwpd5ieMNO 111g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=2jOFWX1uFBmWlziiAgkwL8q+kcVayPCyYxEStuw5EiA=; b=ucZ/2nKC9seww9x2o8csfu9CMDsM3EzRO0r7KHQrZo1KCpj97FnEfF+OL0g8oSjr4a eZ3nEpLLX1cTssMDO3ceGL+4sKgzuTobqs5PUcGCzIKTANlKnFio/HLAl+5CEl7ttS9o 6OWQ2d2JfFPq86ltz2Ovleb3DEwFFPlr9akmkrM/OQIiaMFSBenG3f3KEEY44fG2u8su PrucwyHxcGaFIrtyhd8DIC8T6H86OlpT0NiA2OYXr0GKhq7+jSMWgQJ1gDcrCs0UoLiQ wQ98Wn7atbCI1K3HLnws75jBF66B54a58iSWSiKgyMtiiAb2aHtPexLFtc8I+L1j4+4X SiEQ== X-Gm-Message-State: ALKqPwcZeT/B//oKNJ2WwaBHUUTC4pJF8Yad2fIu6Td+zHMXfxe0BImA I7X8IXOAyU0uoSDS2LEJu4z5AA== X-Google-Smtp-Source: AB8JxZrh93H1nRNfgyyEVgpdLGe4ijO1iOI1OATSvdHGVQDJkMkTZq5MfFKjHNnlLnEX7FGxU06OvA== X-Received: by 2002:a6b:3306:: with SMTP id z6-v6mr18052209ioz.88.1526431913606; Tue, 15 May 2018 17:51:53 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id x189-v6sm5100235ite.2.2018.05.15.17.51.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 15 May 2018 17:51:52 -0700 (PDT) From: Noam Postavsky To: Eli Zaretskii Subject: Re: bug#31457: 27.0.50; Move starttls.el and tls.el to lisp/obsolete/ References: <87in7pkcov.fsf@gmail.com> <87k1s5vyk1.fsf@gmail.com> <83zi10kg9q.fsf@gnu.org> Date: Tue, 15 May 2018 20:51:51 -0400 In-Reply-To: <83zi10kg9q.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 15 May 2018 19:58:09 +0300") Message-ID: <8736ysjuc8.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 31457 Cc: Robert Pluim , 31457@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Robert Pluim >> Date: Tue, 15 May 2018 15:27:42 +0200 >> Cc: 31457@debbugs.gnu.org >> >> Cool. Do we want to remove sslv3 support from tls.el as well, or are >> we not making any more changes to it now? > > I see no need to remove anything from a package that becomes obsolete. The sslv3 "support" is just the "gnutls-cli --x509cafile %t -p %p %h --protocols ssl3" entry in the default value for tls-program, right? I think removing it wouldn't really be removing the feature as such, just making the default "safer". People who know what they are doing can still customize with the appropriate value to get sslv3 if they want. Hmm, and it looks like my version of gnutls-cli (3.5.8) doesn't even support the --protocols switch anyway. "Basil L. Contovounesios" writes: >> >> +** The tls.el and starttls.el libraries are now marked obsolete. >> +Use of builtin of function based on libgnutls is recommended instead. > ^^^^ > > Typo? Oops. Not sure what I was actually aiming for there. I rewrote like this: ** The tls.el and starttls.el libraries are now marked obsolete. Use of builtin libgnutls based functionality (described in the Emacs GnuTLS manual) is recommended instead. From debbugs-submit-bounces@debbugs.gnu.org Wed May 16 04:55:36 2018 Received: (at 31457) by debbugs.gnu.org; 16 May 2018 08:55:36 +0000 Received: from localhost ([127.0.0.1]:36356 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fIsDg-0001Eg-I5 for submit@debbugs.gnu.org; Wed, 16 May 2018 04:55:36 -0400 Received: from mx2.suse.de ([195.135.220.15]:57383) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fIsDf-0001EL-P1 for 31457@debbugs.gnu.org; Wed, 16 May 2018 04:55:36 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id ABD6BADCC; Wed, 16 May 2018 08:55:29 +0000 (UTC) From: Andreas Schwab To: Noam Postavsky Subject: Re: bug#31457: 27.0.50; Move starttls.el and tls.el to lisp/obsolete/ References: <87in7pkcov.fsf@gmail.com> <87k1s5vyk1.fsf@gmail.com> <83zi10kg9q.fsf@gnu.org> <8736ysjuc8.fsf@gmail.com> X-Yow: GOOD-NIGHT, everybody.. Now I have to go administer FIRST-AID to my pet LEISURE SUIT!! Date: Wed, 16 May 2018 10:55:29 +0200 In-Reply-To: <8736ysjuc8.fsf@gmail.com> (Noam Postavsky's message of "Tue, 15 May 2018 20:51:51 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 31457 Cc: Eli Zaretskii , 31457@debbugs.gnu.org, Robert Pluim X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On Mai 15 2018, Noam Postavsky wrote: > ** The tls.el and starttls.el libraries are now marked obsolete. > Use of builtin libgnutls based functionality (described in the Emacs > GnuTLS manual) is recommended instead. I think it should be `built-in'. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 18 20:12:18 2018 Received: (at 31457) by debbugs.gnu.org; 19 Jun 2018 00:12:18 +0000 Received: from localhost ([127.0.0.1]:55540 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fV4Fu-0007T2-AC for submit@debbugs.gnu.org; Mon, 18 Jun 2018 20:12:18 -0400 Received: from mail-io0-f195.google.com ([209.85.223.195]:42863) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fV4Fs-0007Se-2H; Mon, 18 Jun 2018 20:12:16 -0400 Received: by mail-io0-f195.google.com with SMTP id r24-v6so18472325ioh.9; Mon, 18 Jun 2018 17:12:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=QeAAlt4yA886dZ29GL7RIJnD0zy4r8gd+PkMfs65OZw=; b=CSxwXQHdylRXZ8tBda9uBHbUuJeDl31d94Nk6r2wKKVoitzolVpfovOIf6GdfyESWm nCFjTvbilKuNVnL9h0iNrYEB/v7UrSuZd8NEVOX8SWgS2SIwcxHGdjoxRnlQhVL4PXXX xacOhv6fW3+T0OQyVBvxq6gsEorEakxTbN9eXXXjVdWYSCabEo/rWWPcxcFa4/IhBeMM zukNvy2Dt5J0H4AcXRj5tJCmj51YMJMX1sl0n/UmeirGWaSMsIcWJlAoESHMzUC3TuS2 Vdu0ZXs6IgG/zrim2SM78VWOukzvenh0qvoj7UEt1RJqkTgFcUEgmRDTLZM8Nz1WZYe4 gk8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=QeAAlt4yA886dZ29GL7RIJnD0zy4r8gd+PkMfs65OZw=; b=OMWkefU4cg2iBD1EP8XSdgYeLKH6iw01qqV58Smhl42ligze59p/lyeJYoZ9XiJgQk xi12cdDLiMxADpHB1p8turf4Tcid5Byfa9X3EEo/1J42loe0AzA0QlUcSEoWUgHJidUL BfcG3vYEDB+vmCE0T40bvio8xCV7rBFSOgeMLDhoRWLQsBEObd3TcUl96Miiyd0m5xhp OMhiTLzX/Kw/ks3URqQFQqWyg2NLlLv6L3i9PoWp/sDeHbzPWL14N05f8i0LM9EsnCM6 nTkIA19V6Ty1Lgh9Lrqtw2l+5OGTzWnQ7t/VjS99nLLLoYVQ2zP9it2YytdfbvtGvUhf yDpg== X-Gm-Message-State: APt69E0IieVGWtuBwwEtDSRnrme/EOc3cfk/JvgMuxpP8Aig4wpirRlc j7umW54TiZRyufRPz6P3t/CChA== X-Google-Smtp-Source: ADUXVKKlyZAYxDcNsUI1oTse9TIUWdhFp3d9t0CRFcFApUEO54h9GUK/QVGTjAOVAHfUeMMG9jWcmw== X-Received: by 2002:a6b:da0e:: with SMTP id x14-v6mr11668325iob.19.1529367130468; Mon, 18 Jun 2018 17:12:10 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id f3-v6sm6003590iob.49.2018.06.18.17.12.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Jun 2018 17:12:09 -0700 (PDT) From: Noam Postavsky To: Andreas Schwab Subject: Re: bug#31457: 27.0.50; Move starttls.el and tls.el to lisp/obsolete/ References: <87in7pkcov.fsf@gmail.com> <87k1s5vyk1.fsf@gmail.com> <83zi10kg9q.fsf@gnu.org> <8736ysjuc8.fsf@gmail.com> Date: Mon, 18 Jun 2018 20:12:07 -0400 In-Reply-To: (Andreas Schwab's message of "Wed, 16 May 2018 10:55:29 +0200") Message-ID: <87602ftz1k.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31457 Cc: Eli Zaretskii , 31457@debbugs.gnu.org, Robert Pluim X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 31457 fixed close 31457 27.1 quit Andreas Schwab writes: > On Mai 15 2018, Noam Postavsky wrote: > >> ** The tls.el and starttls.el libraries are now marked obsolete. >> Use of builtin libgnutls based functionality (described in the Emacs >> GnuTLS manual) is recommended instead. > > I think it should be `built-in'. Fixed and push to master. [1: 97d5d1a1f4]: 2018-06-18 20:01:44 -0400 Move tls.el and starttls.el to lisp/obsolete/ (Bug#31457) https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=97d5d1a1f4790f959d1bee64e552b492103eddbe From unknown Mon Jun 23 23:51:19 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 17 Jul 2018 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator