Subject: Re: [bug#31449] [PATCH 1/3] gnu: Add guile-simple-zmq.

From: [email-masked] (Ludovic Courtès)
Date: Mon, 14 May 2018 14:55:01 +0200

Hello!

Rouby Pierre-Antoine <[email-masked]> skribis:

> * gnu/package/guile.scm (guile-simple-zmq): New variable.

[...]

> +(define-public guile-simple-zmq
> +  (package
> +    (name "guile-simple-zmq")
> +    (version "0.0.1")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/jerry40/guile-simple-zmq")
> +             (commit "d76657aeb1cd10ef8136edc06bb90999914c7c3c")))

Nitpick: since there’s no release, I think the version number should be
like:

  (string-append "0-" (string-take commit 7))

along the lines of what the manual suggests (info "(guix) Version
Numbers").

> +    (description
> +     "This package is Guile wrapper over ZeroMQ library.")

What about:

  "This package provides a Guile programming interface to the ZeroMQ
  messaging library."

?

Could you send an updated patch?

Thanks,
Ludo’.