GNU bug report logs - #31430
[PATCH 0/3] gnu: Add xtensor and its dependencies.

Previous Next

Package: guix-patches;

Reported by: Fis Trivial <ybbs.daans <at> hotmail.com>

Date: Sat, 12 May 2018 14:22:02 UTC

Severity: normal

Tags: patch

Done: ludo <at> gnu.org (Ludovic Courtès)

Bug is archived. No further changes may be made.

Full log

Message #23 received at 31430 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Fis Trivial <ybbs.daans <at> hotmail.com>
Cc: "31430 <at> debbugs.gnu.org" <31430 <at> debbugs.gnu.org>
Subject: Re: [bug#31430] [PATCH 3/3] gnu: Add xtensor.
Date: Thu, 24 May 2018 23:34:08 +0200

Fis Trivial <ybbs.daans <at> hotmail.com> skribis:

> * gnu/packages/algebra.scm (xtensor): New variable.

[...]

> +    (home-page "https://github.com/nlohmann/json")

Copy/paste error.  :-)

You can actually arrange to write:

  (package
    ;; …
    (home-page …)
    (source (origin
              ;; …
              (uri (string-append home-page …)))))

That’s slightly less error-prone.

Apart from that LGTM, thanks!

Ludo’.
This bug report was last modified 6 years and 364 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.