GNU bug report logs - #31430
[PATCH 0/3] gnu: Add xtensor and its dependencies.

Previous Next

Full log

Message #20 received at 31430 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Fis Trivial <ybbs.daans <at> hotmail.com>
Cc: "31430 <at> debbugs.gnu.org" <31430 <at> debbugs.gnu.org>
Subject: Re: [bug#31430] [PATCH 2/3] gnu: Add xtl.
Date: Thu, 24 May 2018 23:31:04 +0200

Fis Trivial <ybbs.daans <at> hotmail.com> skribis:

> * gnu/packages/cpp.scm (xtl): New variable.

[...]

> +         (replace 'check
> +           (lambda* _
> +             (invoke "make" "test_xtl")
> +             (chdir "test")
> +             (invoke "./test_xtl")
> +             (chdir ".."))))))

Instead of chdir, rather do:

  (with-directory-excursion "test"
    (invoke "./test_xtl")
    #t)

> +    (home-page "https://github.com/QuantStack/xtl")
> +    (build-system cmake-build-system)
> +    (synopsis "C++ template library providing some basic tools")
> +    (description "xtl is a C++ header-only template library providing basic
> +tools (containers, algorithms) used by other quantstack packages")

I know it’s from upstream, but please s/quantstack/QuantStack/ and add a
period at the end.

Could you send an updated patch?

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.