GNU bug report logs - #3142
23.0.92; split-window-prefered-function should be able to use split-window-horizontally/split-window-vertically

Previous Next

Full log

Message #72 received at 3142 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Juri Linkov <juri <at> jurta.org>
Cc: martin rudalics <rudalics <at> gmx.at>, 3142 <at> debbugs.gnu.org,
        Jared Finder <jfinder <at> crypticstudios.com>
Subject: Re: bug#3142: 23.0.92; split-window-prefered-function should be able to use split-window-horizontally/split-window-vertically
Date: Thu, 30 Apr 2009 14:20:58 -0400

>> + (defcustom split-window-preferred-function 'split-selected-window
>> +   "Function called by `display-buffer' to split a window.
>> + The window that shall be split is selected when this function is
>> + called.  The function is supposed to either return the new window
>> + or nil if the window can (or shall) not be split."
>> +   :type 'function
>> +   :version "23.1"
>> +   :group 'windows)

> If setting this option to `split-window-horizontally' and
> `split-window-vertically' is possible and it works correctly
> with these value, then I suggest adding them as constants,
> e.g. "Always split horizontally" and "Always split vertically".

Agreed (does :options work in such a case?).

> Also I suggest keeping the common function name prefix
> "split-window-",

Yes, please.

> i.e. instead of `split-selected-window' to name it something like
> "split-window-sensibly" or "split-window-with-thresholds".

Or split-window-dwim, split-window-somehow.


        Stefan


PS: Other than that, the code looks fine.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.