From debbugs-submit-bounces@debbugs.gnu.org Wed May 09 16:40:15 2018 Received: (at submit) by debbugs.gnu.org; 9 May 2018 20:40:15 +0000 Received: from localhost ([127.0.0.1]:55579 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fGVsk-0007GB-Rr for submit@debbugs.gnu.org; Wed, 09 May 2018 16:40:15 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44762) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fGVsj-0007Fz-0s for submit@debbugs.gnu.org; Wed, 09 May 2018 16:40:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fGVsd-0002hi-BP for submit@debbugs.gnu.org; Wed, 09 May 2018 16:40:07 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:48838) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fGVsd-0002he-7w for submit@debbugs.gnu.org; Wed, 09 May 2018 16:40:07 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35719) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fGVsc-0005rg-3D for guix-patches@gnu.org; Wed, 09 May 2018 16:40:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fGVsX-0002fc-69 for guix-patches@gnu.org; Wed, 09 May 2018 16:40:06 -0400 Received: from dd26836.kasserver.com ([85.13.145.193]:34968) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fGVsW-0002f4-V7 for guix-patches@gnu.org; Wed, 09 May 2018 16:40:01 -0400 Received: from dayas.3.home (77.118.237.136.wireless.dyn.drei.com [77.118.237.136]) by dd26836.kasserver.com (Postfix) with ESMTPSA id A75B93360204; Wed, 9 May 2018 22:39:58 +0200 (CEST) From: Danny Milosavljevic To: guix-patches@gnu.org Subject: [PATCH 0/4] Add android-fastboot and rename packages. Date: Wed, 9 May 2018 22:39:47 +0200 Message-Id: <20180509203947.10746-1-dannym@scratchpost.org> X-Mailer: git-send-email 2.16.2 Tags: patch X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit Cc: Danny Milosavljevic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Danny Milosavljevic (4): gnu: Add android-fastboot. gnu: Rename "liblog" to "android-liblog". gnu: Rename "libbase" to "android-libbase". gnu: Rename "libcutils" to "android-libcutils". gnu/packages/android.scm | 96 ++++++++++++++++++++++++++++++++++++++++-------- 1 file changed, 80 insertions(+), 16 deletions(-) From debbugs-submit-bounces@debbugs.gnu.org Wed May 09 16:41:49 2018 Received: (at 31393) by debbugs.gnu.org; 9 May 2018 20:41:49 +0000 Received: from localhost ([127.0.0.1]:55586 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fGVuH-0007Io-6T for submit@debbugs.gnu.org; Wed, 09 May 2018 16:41:49 -0400 Received: from dd26836.kasserver.com ([85.13.145.193]:39568) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fGVuF-0007IY-Eq for 31393@debbugs.gnu.org; Wed, 09 May 2018 16:41:48 -0400 Received: from dayas.3.home (77.118.237.136.wireless.dyn.drei.com [77.118.237.136]) by dd26836.kasserver.com (Postfix) with ESMTPSA id D4B323360204; Wed, 9 May 2018 22:41:45 +0200 (CEST) From: Danny Milosavljevic To: 31393@debbugs.gnu.org Subject: [PATCH 1/4] gnu: Add android-fastboot. Date: Wed, 9 May 2018 22:41:37 +0200 Message-Id: <20180509204140.10819-1-dannym@scratchpost.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180509203947.10746-1-dannym@scratchpost.org> References: <20180509203947.10746-1-dannym@scratchpost.org> Tags: patch X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 31393 Cc: Danny Milosavljevic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/android.scm (android-fastboot): New variable. --- gnu/packages/android.scm | 64 ++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 64 insertions(+) diff --git a/gnu/packages/android.scm b/gnu/packages/android.scm index 2e5f1d593..eaae0229a 100644 --- a/gnu/packages/android.scm +++ b/gnu/packages/android.scm @@ -568,6 +568,70 @@ Android core.") (description "@code{android-libutils} provides utilities for Android NDK developers.") (license license:asl2.0))) +(define-public android-fastboot + (package + (name "android-fastboot") + (version (android-platform-version)) + (source #f) + (build-system android-ndk-build-system) + (arguments + `(#:make-flags (list "CXXFLAGS=-std=gnu++11") + #:phases + (modify-phases %standard-phases + (replace 'unpack + (lambda* (#:key inputs #:allow-other-keys) + (mkdir-p "core") + (with-directory-excursion "core" + (invoke "tar" "axf" (assoc-ref inputs "core") "--strip-components=1") + (substitute* "fastboot/Android.mk" + (("libext4_utils_host") "libext4_utils_host libselinux libpcre"))) + (copy-recursively (assoc-ref inputs "extras") "extras" + #:keep-mtime? #t) + #t)) + (add-after 'unpack 'enter-source + (lambda _ + (chdir "core/fastboot") + #t)) + (add-after 'enter-source 'make-googletest-available + (lambda* (#:key inputs #:allow-other-keys) + (let ((googletest (assoc-ref inputs "googletest"))) + (symlink (string-append googletest "/lib/libgtest.so") "libgtest_host.so") + #t))) + (replace 'install + (lambda* (#:key outputs #:allow-other-keys) + (let* ((out (assoc-ref outputs "out")) + (lib (string-append out "/lib")) + (bin (string-append out "/bin"))) + (install-file "fastboot" bin) + #t)))) + #:tests? #f)) + (inputs + `(("adb" ,adb) + ("android-safe-iop" ,android-safe-iop) + ("android-ext4-utils" ,android-ext4-utils) + ("android-f2fs-utils" ,android-f2fs-utils) + ("googletest" ,googletest) + ("libbase" ,libbase) + ("libcutils" ,libcutils) + ("liblog" ,liblog) + ("android-libutils" ,android-libutils) + ("android-libsparse" ,android-libsparse) + ("android-libziparchive" ,android-libziparchive) + ("android-libselinux" ,android-libselinux) + ("pcre" ,pcre) + ("mkbootimg" ,mkbootimg) + ("openssl" ,openssl) ; FIXME remove + ("zlib" ,zlib))) + (native-inputs + `(("core" ,(android-platform-system-core version)) + ("extras" ,(android-platform-system-extras version)) + ("xz" ,xz))) + (home-page "https://developer.android.com/studio/command-line/") + (synopsis "Android image flasher") + (description + "This package provides @command{fastboot}, a tool to upload file system images to Android devices.") + (license license:asl2.0))) + (define-public android-udev-rules (package (name "android-udev-rules") From debbugs-submit-bounces@debbugs.gnu.org Wed May 09 16:41:49 2018 Received: (at 31393) by debbugs.gnu.org; 9 May 2018 20:41:49 +0000 Received: from localhost ([127.0.0.1]:55588 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fGVuH-0007Iv-FE for submit@debbugs.gnu.org; Wed, 09 May 2018 16:41:49 -0400 Received: from dd26836.kasserver.com ([85.13.145.193]:39576) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fGVuF-0007Ia-Vf for 31393@debbugs.gnu.org; Wed, 09 May 2018 16:41:48 -0400 Received: from dayas.3.home (77.118.237.136.wireless.dyn.drei.com [77.118.237.136]) by dd26836.kasserver.com (Postfix) with ESMTPSA id E324F336128F; Wed, 9 May 2018 22:41:46 +0200 (CEST) From: Danny Milosavljevic To: 31393@debbugs.gnu.org Subject: [PATCH 2/4] gnu: Rename "liblog" to "android-liblog". Date: Wed, 9 May 2018 22:41:38 +0200 Message-Id: <20180509204140.10819-2-dannym@scratchpost.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180509204140.10819-1-dannym@scratchpost.org> References: <20180509203947.10746-1-dannym@scratchpost.org> <20180509204140.10819-1-dannym@scratchpost.org> Tags: patch X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 31393 Cc: Danny Milosavljevic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/android.scm (liblog): Rename to... (android-liblog): ...this. --- gnu/packages/android.scm | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/gnu/packages/android.scm b/gnu/packages/android.scm index eaae0229a..db5a00298 100644 --- a/gnu/packages/android.scm +++ b/gnu/packages/android.scm @@ -143,9 +143,9 @@ use their packages mostly unmodified in our Android NDK build system.") (base32 checksum)))) -(define liblog +(define android-liblog (package - (name "liblog") + (name "android-liblog") (version (android-platform-version)) (source (android-platform-system-core version)) (build-system android-ndk-build-system) @@ -182,7 +182,7 @@ in Main, System, Radio and Events sub-logs.") (modify-phases %standard-phases (add-after 'unpack 'enter-source (lambda _ (chdir "base") #t))))) - (inputs `(("liblog" ,liblog))) + (inputs `(("android-liblog" ,android-liblog))) (home-page "https://developer.android.com/") (synopsis "Android platform base library") (description "@code{libbase} is a library in common use by the @@ -322,7 +322,7 @@ various Android core host applications.") (inputs `(("libbase" ,libbase) ("libcutils" ,libcutils) - ("liblog" ,liblog) + ("android-liblog" ,android-liblog) ("openssl" ,openssl))) (home-page "https://developer.android.com/studio/command-line/adb.html") (synopsis "Android Debug Bridge") @@ -477,7 +477,7 @@ that is safe to use for user space. It also includes "/include " "-I " (assoc-ref %build-inputs "libcutils") "/include " - "-I " (assoc-ref %build-inputs "liblog") "/include " + "-I " (assoc-ref %build-inputs "android-liblog") "/include " "-I ../core/include") "CFLAGS=-Wno-error" "install-libext4_utils_host.a" @@ -500,7 +500,7 @@ that is safe to use for user space. It also includes #t))))) (inputs `(("libcutils" ,libcutils) - ("liblog" ,liblog) + ("android-liblog" ,android-liblog) ("android-libselinux" ,android-libselinux) ("android-libsparse" ,android-libsparse) ("zlib" ,zlib))) @@ -613,7 +613,7 @@ Android core.") ("googletest" ,googletest) ("libbase" ,libbase) ("libcutils" ,libcutils) - ("liblog" ,liblog) + ("android-liblog" ,android-liblog) ("android-libutils" ,android-libutils) ("android-libsparse" ,android-libsparse) ("android-libziparchive" ,android-libziparchive) From debbugs-submit-bounces@debbugs.gnu.org Wed May 09 16:41:53 2018 Received: (at 31393) by debbugs.gnu.org; 9 May 2018 20:41:53 +0000 Received: from localhost ([127.0.0.1]:55591 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fGVuK-0007JG-Oi for submit@debbugs.gnu.org; Wed, 09 May 2018 16:41:52 -0400 Received: from dd26836.kasserver.com ([85.13.145.193]:39586) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fGVuG-0007Im-Vk for 31393@debbugs.gnu.org; Wed, 09 May 2018 16:41:49 -0400 Received: from dayas.3.home (77.118.237.136.wireless.dyn.drei.com [77.118.237.136]) by dd26836.kasserver.com (Postfix) with ESMTPSA id ED0E03362271; Wed, 9 May 2018 22:41:47 +0200 (CEST) From: Danny Milosavljevic To: 31393@debbugs.gnu.org Subject: [PATCH 3/4] gnu: Rename "libbase" to "android-libbase". Date: Wed, 9 May 2018 22:41:39 +0200 Message-Id: <20180509204140.10819-3-dannym@scratchpost.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180509204140.10819-1-dannym@scratchpost.org> References: <20180509203947.10746-1-dannym@scratchpost.org> <20180509204140.10819-1-dannym@scratchpost.org> Tags: patch X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 31393 Cc: Danny Milosavljevic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/android.scm (libbase): Rename to... (android-libbase): ...this. --- gnu/packages/android.scm | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/gnu/packages/android.scm b/gnu/packages/android.scm index db5a00298..563ed32ea 100644 --- a/gnu/packages/android.scm +++ b/gnu/packages/android.scm @@ -169,9 +169,9 @@ interfaces for either writing or reading logs. The log buffers are divided up in Main, System, Radio and Events sub-logs.") (license license:asl2.0))) -(define libbase +(define android-libbase (package - (name "libbase") + (name "android-libbase") (version (android-platform-version)) (source (android-platform-system-core version)) (build-system android-ndk-build-system) @@ -320,7 +320,7 @@ various Android core host applications.") (install-file "diagnose_usb.h" (string-append (assoc-ref outputs "out") "/include")) #t))))) (inputs - `(("libbase" ,libbase) + `(("android-libbase" ,android-libbase) ("libcutils" ,libcutils) ("android-liblog" ,android-liblog) ("openssl" ,openssl))) @@ -611,7 +611,7 @@ Android core.") ("android-ext4-utils" ,android-ext4-utils) ("android-f2fs-utils" ,android-f2fs-utils) ("googletest" ,googletest) - ("libbase" ,libbase) + ("android-libbase" ,android-libbase) ("libcutils" ,libcutils) ("android-liblog" ,android-liblog) ("android-libutils" ,android-libutils) From debbugs-submit-bounces@debbugs.gnu.org Wed May 09 16:41:53 2018 Received: (at 31393) by debbugs.gnu.org; 9 May 2018 20:41:53 +0000 Received: from localhost ([127.0.0.1]:55593 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fGVuL-0007JI-2K for submit@debbugs.gnu.org; Wed, 09 May 2018 16:41:53 -0400 Received: from dd26836.kasserver.com ([85.13.145.193]:39594) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fGVuH-0007Iw-SO for 31393@debbugs.gnu.org; Wed, 09 May 2018 16:41:51 -0400 Received: from dayas.3.home (77.118.237.136.wireless.dyn.drei.com [77.118.237.136]) by dd26836.kasserver.com (Postfix) with ESMTPSA id D46F13360204; Wed, 9 May 2018 22:41:48 +0200 (CEST) From: Danny Milosavljevic To: 31393@debbugs.gnu.org Subject: [PATCH 4/4] gnu: Rename "libcutils" to "android-libcutils". Date: Wed, 9 May 2018 22:41:40 +0200 Message-Id: <20180509204140.10819-4-dannym@scratchpost.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180509204140.10819-1-dannym@scratchpost.org> References: <20180509203947.10746-1-dannym@scratchpost.org> <20180509204140.10819-1-dannym@scratchpost.org> Tags: patch X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 31393 Cc: Danny Milosavljevic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/android.scm (libcutils): Rename to... (android-libcutils): ...this. --- gnu/packages/android.scm | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/gnu/packages/android.scm b/gnu/packages/android.scm index 563ed32ea..6f68f583c 100644 --- a/gnu/packages/android.scm +++ b/gnu/packages/android.scm @@ -189,9 +189,9 @@ in Main, System, Radio and Events sub-logs.") various Android core host applications.") (license license:asl2.0))) -(define libcutils +(define android-libcutils (package - (name "libcutils") + (name "android-libcutils") (version (android-platform-version)) (source (android-platform-system-core version)) (build-system gnu-build-system) @@ -321,7 +321,7 @@ various Android core host applications.") #t))))) (inputs `(("android-libbase" ,android-libbase) - ("libcutils" ,libcutils) + ("android-libcutils" ,android-libcutils) ("android-liblog" ,android-liblog) ("openssl" ,openssl))) (home-page "https://developer.android.com/studio/command-line/adb.html") @@ -475,7 +475,7 @@ that is safe to use for user space. It also includes "/include " "-I " (assoc-ref %build-inputs "android-libsparse") "/include " - "-I " (assoc-ref %build-inputs "libcutils") + "-I " (assoc-ref %build-inputs "android-libcutils") "/include " "-I " (assoc-ref %build-inputs "android-liblog") "/include " "-I ../core/include") @@ -499,7 +499,7 @@ that is safe to use for user space. It also includes (copy-recursively "." (string-append out "/include"))) #t))))) (inputs - `(("libcutils" ,libcutils) + `(("android-libcutils" ,android-libcutils) ("android-liblog" ,android-liblog) ("android-libselinux" ,android-libselinux) ("android-libsparse" ,android-libsparse) @@ -533,7 +533,7 @@ Android core.") `(("f2fs-tools" ,f2fs-tools-1.7) ("android-libselinux" ,android-libselinux) ("android-libsparse" ,android-libsparse) - ("libcutils" ,libcutils) + ("android-libcutils" ,android-libcutils) ("zlib" ,zlib))) (home-page "https://developer.android.com/") (synopsis "Android ext4 utils") @@ -560,7 +560,7 @@ Android core.") (copy-recursively "../include/utils" (string-append (assoc-ref outputs "out") "/include/utils"))))))) (inputs `(("android-safe-iop" ,android-safe-iop) - ("libcutils" ,libcutils))) + ("android-libcutils" ,android-libcutils))) (native-inputs `(("android-bionic-uapi" ,android-bionic-uapi))) (home-page "https://developer.android.com/") @@ -612,7 +612,7 @@ Android core.") ("android-f2fs-utils" ,android-f2fs-utils) ("googletest" ,googletest) ("android-libbase" ,android-libbase) - ("libcutils" ,libcutils) + ("android-libcutils" ,android-libcutils) ("android-liblog" ,android-liblog) ("android-libutils" ,android-libutils) ("android-libsparse" ,android-libsparse) From debbugs-submit-bounces@debbugs.gnu.org Wed May 09 16:53:30 2018 Received: (at 31393) by debbugs.gnu.org; 9 May 2018 20:53:30 +0000 Received: from localhost ([127.0.0.1]:55606 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fGW5a-0007aw-GF for submit@debbugs.gnu.org; Wed, 09 May 2018 16:53:30 -0400 Received: from lepiller.eu ([89.234.186.109]:34414) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fGW5Z-0007ap-Bj for 31393@debbugs.gnu.org; Wed, 09 May 2018 16:53:29 -0400 Received: from localhost (static-176-182-42-79.ncc.abo.bbox.fr [176.182.42.79]) by lepiller.eu (OpenSMTPD) with ESMTPSA id 51a63c6a (TLSv1.2:ECDHE-RSA-CHACHA20-POLY1305:256:NO) for <31393@debbugs.gnu.org>; Wed, 9 May 2018 20:54:56 +0000 (UTC) Date: Wed, 9 May 2018 22:53:23 +0200 From: Julien Lepiller To: 31393@debbugs.gnu.org Subject: Re: [bug#31393] [PATCH 0/4] Add android-fastboot and rename packages. Message-ID: <20180509225323.6678fe71@lepiller.eu> In-Reply-To: <20180509203947.10746-1-dannym@scratchpost.org> References: <20180509203947.10746-1-dannym@scratchpost.org> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31393 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Le Wed, 9 May 2018 22:39:47 +0200, Danny Milosavljevic a =C3=A9crit : > Danny Milosavljevic (4): > gnu: Add android-fastboot. > gnu: Rename "liblog" to "android-liblog". > gnu: Rename "libbase" to "android-libbase". > gnu: Rename "libcutils" to "android-libcutils". >=20 > gnu/packages/android.scm | 96 > ++++++++++++++++++++++++++++++++++++++++-------- 1 file changed, 80 > insertions(+), 16 deletions(-) I haven't tested your patches, but if they work, LGTM! Could you simply add a comment to explain why you don't run tests (I guess there aren't any). Also, I'm not sure about the name of the android-fastboot package. Since it provides the fastboot command, I think the convention is to call it fastboot, like adb is not android-adb. From debbugs-submit-bounces@debbugs.gnu.org Wed May 09 20:52:24 2018 Received: (at 31393-done) by debbugs.gnu.org; 10 May 2018 00:52:24 +0000 Received: from localhost ([127.0.0.1]:55769 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fGZom-0008WS-EC for submit@debbugs.gnu.org; Wed, 09 May 2018 20:52:24 -0400 Received: from dd26836.kasserver.com ([85.13.145.193]:57238) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fGZok-0008WK-Px for 31393-done@debbugs.gnu.org; Wed, 09 May 2018 20:52:23 -0400 Received: from localhost (77.118.237.136.wireless.dyn.drei.com [77.118.237.136]) by dd26836.kasserver.com (Postfix) with ESMTPSA id B5DE733601B6; Thu, 10 May 2018 02:52:20 +0200 (CEST) Date: Thu, 10 May 2018 02:52:16 +0200 From: Danny Milosavljevic To: Julien Lepiller Subject: Re: [bug#31393] [PATCH 0/4] Add android-fastboot and rename packages. Message-ID: <20180510025216.1e995bb3@scratchpost.org> In-Reply-To: <20180509225323.6678fe71@lepiller.eu> References: <20180509203947.10746-1-dannym@scratchpost.org> <20180509225323.6678fe71@lepiller.eu> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/qdG1t5t7r40IJIslItxHta4"; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 31393-done Cc: 31393-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --Sig_/qdG1t5t7r40IJIslItxHta4 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Julien, On Wed, 9 May 2018 22:53:23 +0200 Julien Lepiller wrote: > Could you simply add a comment to explain why you don't run tests (I > guess there aren't any). I didn't have the building of the tests implemented yet. I do now :) > Also, I'm not sure about the name of the > android-fastboot package. Since it provides the fastboot command, I > think the convention is to call it fastboot, like adb is not > android-adb. Okay! Pushed to master. Fastboot works now - and a few packages have tests enabled now. Phiew... --Sig_/qdG1t5t7r40IJIslItxHta4 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlrzl8AACgkQ5xo1VCww uqWfBQf+PGgzAWXEociSrNVbvb9kk1yVyBI4Vu8dMUfBLxbK0vEnjqCkxzZznwvb LNpdzc09rrCfix7y+iShwM7vvcK8dG6Pstl1uSlrx1vcjMrc/pr4497wQMflu3HV 5j6OTS3Wya4G4x2NWUtXkPv4wSIIVJce+xNRCQO5EBbMIW0NaOrQlDTdoO+BQz5K 85HfMhTBy/WpvIJL+N/JDnLMze7ThTJDjpBXswu4xv+nCFXaRoDcfVpBl68Mfm1y +0s31+YVBekvTrLhkujNBf4r8ZMEcuSwwXjB9u7IWnX1NFCc/Uoc0ubWgTo+WPcK u2ksn1TTmjrPYOW+OGhGDpT9sdBasA== =4eeD -----END PGP SIGNATURE----- --Sig_/qdG1t5t7r40IJIslItxHta4-- From unknown Mon Aug 18 17:57:51 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 07 Jun 2018 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator