From unknown Wed Jun 25 00:27:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31388: 27.0.50; message-mode hard-codes key bindings in docstring Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: larsi@gnus.org, bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 May 2018 19:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 31388 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 31388@debbugs.gnu.org Cc: Lars Ingebrigtsen X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: Lars Ingebrigtsen Received: via spool by submit@debbugs.gnu.org id=B.152580640817350 (code B ref -1); Tue, 08 May 2018 19:07:02 +0000 Received: (at submit) by debbugs.gnu.org; 8 May 2018 19:06:48 +0000 Received: from localhost ([127.0.0.1]:54523 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fG7wm-0004Vm-2Q for submit@debbugs.gnu.org; Tue, 08 May 2018 15:06:48 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46012) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fG7wk-0004Va-R9 for submit@debbugs.gnu.org; Tue, 08 May 2018 15:06:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fG7we-0007Ct-P8 for submit@debbugs.gnu.org; Tue, 08 May 2018 15:06:41 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:58717) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fG7we-0007Cn-Lw for submit@debbugs.gnu.org; Tue, 08 May 2018 15:06:40 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36981) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fG7wd-0006iB-Kx for bug-gnu-emacs@gnu.org; Tue, 08 May 2018 15:06:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fG7wY-0007A6-Lv for bug-gnu-emacs@gnu.org; Tue, 08 May 2018 15:06:39 -0400 Received: from mail-wm0-x22d.google.com ([2a00:1450:400c:c09::22d]:35446) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fG7wY-00078s-Ea for bug-gnu-emacs@gnu.org; Tue, 08 May 2018 15:06:34 -0400 Received: by mail-wm0-x22d.google.com with SMTP id o78-v6so23471011wmg.0 for ; Tue, 08 May 2018 12:06:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:subject:mail-followup-to:date:message-id:user-agent :mime-version:content-transfer-encoding; bh=umbE7geYxzwHJqv1joeSmlv8BunGiBGR1gjPnXOpXLU=; b=e4m+ESeL9uAELcUO+mx0rgJIwa0oEmrttZNGv+084QZA8xfF4OHTEddFcFgfKl4xbR 9jqiYOGQ6XeXSkeic6mpucfrAa8H3PhystU1biuhv+6IQmoJY+etihVtE2erdCsXK6E1 fEtAYPN5WBrbRJbNxefX9GXEnLoHjSDk+VATtqo4CbqHdxnKOVJKF/UaDtXAW9LRPq8l 4TQT3d688SI7L1IJEl8tt/5QQYzB7uJxlYuDRRs9aVKXbPwNk1nCpwWeWs5Eag58lImp muX99BmKT+LoN7UbhT9aJp1ilaGxmLs/zQ016G5D0bHk2PZ/nWcQcWgeIzMjs1wTJd5G StDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:mail-followup-to:date:message-id :user-agent:mime-version:content-transfer-encoding; bh=umbE7geYxzwHJqv1joeSmlv8BunGiBGR1gjPnXOpXLU=; b=Kw3u1DRHvZNZxXcS3frn3098tmx3SouJnYNwgzz1B6s4tpjgSYpdoygKcSZ/c3gUXs s0Qw8L7XSKJv2Y1eyoOE1vMzMFXw++L23PDK2gAD0+U1Adr2pJfH7N42kFprYw6fnu2x Hn+TXYPL9d8TGgOEJ8Bdy7gN59Id3Tb+n7SKIIsFoeGTH50Y8W5hrlf8HK3VQue325VY Vjo2ZD6b2X5/r37P/ZmDm5aVcMAV4GD1VLMX9XK6nQbcKK/hkJjMD0Ld2P1X0hDTOjRD E0zlDHOcvjocTriWuWHQlsIihqvoTXbGtSN711SGHbb1NKE20sOOJxKnlt2OhAMp09Bh lHZg== X-Gm-Message-State: ALQs6tAJxgaqXS3SQSKF0K2Zjl5KFDH0c8p2K2MjmPNXxxj8ZPV4IELv 2FsrIqmTWMQiyXfqE0mo4EtLdoTN X-Google-Smtp-Source: AB8JxZrsZ/5k9ZJxuYTsu1MbIT/OucUYaI21Cd4vMK6cxGZm+bSSEgfrqTAeWn2g56+BoO2RfgApUA== X-Received: by 2002:a50:b042:: with SMTP id i60-v6mr56279761edd.68.1525806391689; Tue, 08 May 2018 12:06:31 -0700 (PDT) Received: from localhost ([89.100.107.149]) by smtp.gmail.com with ESMTPSA id a2-v6sm150010edd.39.2018.05.08.12.06.30 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 08 May 2018 12:06:31 -0700 (PDT) From: "Basil L. Contovounesios" Mail-Followup-To: bug-gnu-emacs@gnu.org Date: Tue, 08 May 2018 20:06:26 +0100 Message-ID: <874lji6k7h.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) The docstring of message-mode currently hard-codes the bindings provided by message-mode-map. For example: 1. emacs -Q 2. Evaluate: (with-eval-after-load 'message (define-key message-mode-map "\C-c\C-c" #'ignore)) 3. C-x m 4. C-c ? still reports "C-c C-c =E2=80=98message-send-and-exit=E2=80=99". Is this intentional? I realise that this affords summary, custom layout, and descriptions of the available bindings, but isn't it confusing to report the wrong thing in the case that users customise (or use packages which customise) their bindings? One solution is to replace the hard-coded bindings with \[command]-sequences; another to replace the whole listing with \{message-mode-map}. In both cases, the binding listed for message-insert-or-toggle-importance will be C-c C-u instead of C-c C-f C-i, due to the higher precedence of the former. WDYT? P.S. I have, over time, accumulated a set of 12 patches for message.el with refactors such as defining message-mode-map in a single (let ...) calculation, replacing '-quotes with #'-quotes where applicable, removing calls to mapcar where the result is unused, adding tests, etc. I also have a couple of minor and relevant questions to ask. Would patches of this nature be welcome? If so, should I send them here, submit a new bug report, or send mail to emacs-devel? Thanks, --=20 Basil From unknown Wed Jun 25 00:27:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31388: 27.0.50; message-mode hard-codes key bindings in docstring Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 May 2018 19:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31388 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: <31388@debbugs.gnu.org> Cc: Lars Ingebrigtsen Received: via spool by 31388-submit@debbugs.gnu.org id=B31388.152580672817818 (code B ref 31388); Tue, 08 May 2018 19:13:01 +0000 Received: (at 31388) by debbugs.gnu.org; 8 May 2018 19:12:08 +0000 Received: from localhost ([127.0.0.1]:54529 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fG81v-0004dI-MO for submit@debbugs.gnu.org; Tue, 08 May 2018 15:12:08 -0400 Received: from mail-wm0-f47.google.com ([74.125.82.47]:39596) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fG81t-0004cn-Nm for 31388@debbugs.gnu.org; Tue, 08 May 2018 15:12:06 -0400 Received: by mail-wm0-f47.google.com with SMTP id f8-v6so23452748wmc.4 for <31388@debbugs.gnu.org>; Tue, 08 May 2018 12:12:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:subject:references:cc:mail-followup-to:date:in-reply-to :message-id:user-agent:mime-version; bh=A+no1fL81J0ZFvZiP2CIyNQMFbN9jtlibjkn9ZIGKHU=; b=KoWKByh3HWIxPbJrYKg3Hatr3uFoC7Npjo3fVtrwazmOsLqTic6dLQ6qY3o6q/CQhG dbcmEuKlknQbT55MM9tF47urIoCRAev3Tshm3Fmj6d8OmYSHELApe8VBfZ/ZLBcqetSV EWc5BpYgifMJxfmTKDhsf2WQf91lgYptNI4ep7rKe+jPAfQrOHoCsg1tz1uQi2GiZTzP CEF0UxyYSo+nzB8FhWGZhYG10ojjN3elvshG6mbQQbMm8PecPkzGcz5bGlv37TfdKZr0 hkmzfamnYb4WAl2eMlFGJ4gihEi2s9kCcC70byeAotOjrizI3XYMR8ewzzIu2q/eKPk7 bgag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:references:cc:mail-followup-to :date:in-reply-to:message-id:user-agent:mime-version; bh=A+no1fL81J0ZFvZiP2CIyNQMFbN9jtlibjkn9ZIGKHU=; b=E8gD45GmRYPPq14tqZQzm3Vi2wjs38+f9H3+s7hBnBLAruAbzgTl1mt2HsHq1oc3iG tZcDqMAcUsmS2X6OxtawqRb5Y7KepnpLoDgNEx7xO3DajFGof55jP9lxoqQtqKSayUNF IxED2D+KMsY6iFTC0u4kkaE5BfyoimY7mQsbbtm9vlaageEVBm920hdyj3rACOREhOoR nEax6uKSmwumoTo3r0dRrejyZ4zspYLh1yjb15UFlek0+6t7ABA3qvZtvBJJZ0+dswPf YT3diL/+kfgtgKaDrwoacvqLCFxpcFlZ0JYqATBH/Trne8BvaNB3KXU/2l/Xra6/IB4p AYRA== X-Gm-Message-State: ALQs6tA89SM7rnkHHhMC03CIhUrCGXC6svtl/ZHghymiuYzAOSmlN6iz HsczdnRwnMNJ+7GRpz0xYPq8BQJ3 X-Google-Smtp-Source: AB8JxZox/OLfKHn1hVKiQfYXFNRu8D1Eb32q0wa2pTmfFUxYFPOCyJ+mQj4968LQV5416k4Upe6DQw== X-Received: by 2002:a50:87ee:: with SMTP id 43-v6mr56606116edz.1.1525806719761; Tue, 08 May 2018 12:11:59 -0700 (PDT) Received: from localhost ([89.100.107.149]) by smtp.gmail.com with ESMTPSA id d18-v6sm14900778edb.97.2018.05.08.12.11.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 08 May 2018 12:11:58 -0700 (PDT) From: "Basil L. Contovounesios" References: <874lji6k7h.fsf@tcd.ie> Mail-Followup-To: <31388@debbugs.gnu.org>, Lars Ingebrigtsen Date: Tue, 08 May 2018 20:11:58 +0100 In-Reply-To: <874lji6k7h.fsf@tcd.ie> (Basil L. Contovounesios's message of "Tue, 08 May 2018 20:06:26 +0100") Message-ID: <87wowe55dt.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Do-not-hard-code-message-mode-keys-in-docstring.patch >From 0d0afd160b16decb77a9358a49efab5fdf307ba6 Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Mon, 7 May 2018 16:29:19 +0100 Subject: [PATCH] Do not hard-code message-mode keys in docstring * lisp/gnus/message.el (message-mode): Replace hard-coded bindings with \[command] sequences in docstring. --- lisp/gnus/message.el | 101 ++++++++++++++++++++++++++++--------------- 1 file changed, 65 insertions(+), 36 deletions(-) diff --git a/lisp/gnus/message.el b/lisp/gnus/message.el index 867c3d271b..c407fb0a6a 100644 --- a/lisp/gnus/message.el +++ b/lisp/gnus/message.el @@ -2893,42 +2893,71 @@ message--syntax-propertize ;;;###autoload (define-derived-mode message-mode text-mode "Message" "Major mode for editing mail and news to be sent. -Like Text Mode but with these additional commands:\\ -C-c C-s `message-send' (send the message) C-c C-c `message-send-and-exit' -C-c C-d Postpone sending the message C-c C-k Kill the message -C-c C-f move to a header field (and create it if there isn't): - C-c C-f C-t move to To C-c C-f C-s move to Subject - C-c C-f C-c move to Cc C-c C-f C-b move to Bcc - C-c C-f C-w move to Fcc C-c C-f C-r move to Reply-To - C-c C-f C-u move to Summary C-c C-f C-n move to Newsgroups - C-c C-f C-k move to Keywords C-c C-f C-d move to Distribution - C-c C-f C-o move to From (\"Originator\") - C-c C-f C-f move to Followup-To - C-c C-f C-m move to Mail-Followup-To - C-c C-f C-e move to Expires - C-c C-f C-i cycle through Importance values - C-c C-f s change subject and append \"(was: )\" - C-c C-f x crossposting with FollowUp-To header and note in body - C-c C-f t replace To: header with contents of Cc: or Bcc: - C-c C-f a Insert X-No-Archive: header and a note in the body -C-c C-t `message-insert-to' (add a To header to a news followup) -C-c C-l `message-to-list-only' (removes all but list address in to/cc) -C-c C-n `message-insert-newsgroups' (add a Newsgroup header to a news reply) -C-c C-b `message-goto-body' (move to beginning of message text). -C-c C-i `message-goto-signature' (move to the beginning of the signature). -C-c C-w `message-insert-signature' (insert `message-signature-file' file). -C-c C-y `message-yank-original' (insert current message, if any). -C-c C-q `message-fill-yanked-message' (fill what was yanked). -C-c C-e `message-elide-region' (elide the text between point and mark). -C-c C-v `message-delete-not-region' (remove the text outside the region). -C-c C-z `message-kill-to-signature' (kill the text up to the signature). -C-c C-r `message-caesar-buffer-body' (rot13 the message body). -C-c C-a `mml-attach-file' (attach a file as MIME). -C-c C-u `message-insert-or-toggle-importance' (insert or cycle importance). -C-c M-n `message-insert-disposition-notification-to' (request receipt). -C-c M-m `message-mark-inserted-region' (mark region with enclosing tags). -C-c M-f `message-mark-insert-file' (insert file marked with enclosing tags). -M-RET `message-newline-and-reformat' (break the line and reformat)." +Like `text-mode' but with these additional commands:\\ +\\[message-send] `message-send' (send the message) +\\[message-send-and-exit] `message-send-and-exit' +\\[message-dont-send] Postpone sending the message +\\[message-kill-buffer] Kill the message +Commands for moving to a header field, creating it as required: + \\[message-goto-to] Move to To + \\[message-goto-subject] Move to Subject + \\[message-goto-cc] Move to Cc + \\[message-goto-bcc] Move to Bcc + \\[message-goto-fcc] Move to Fcc + \\[message-goto-reply-to] Move to Reply-To + \\[message-goto-summary] Move to Summary + \\[message-goto-newsgroups] Move to Newsgroups + \\[message-goto-keywords] Move to Keywords + \\[message-goto-distribution] Move to Distribution + \\[message-goto-from] Move to From (\"Originator\") + \\[message-goto-followup-to] Move to Followup-To + \\[message-goto-mail-followup-to] Move to Mail-Followup-To + \\[message-insert-expires] Move to Expires + \\[message-insert-or-toggle-importance]\ + Cycle through Importance values + \\[message-change-subject]\ + Change subject and append \"(was: )\" + \\[message-cross-post-followup-to]\ + Crosspost with Followup-To header and note in body + \\[message-reduce-to-to-cc]\ + Replace To header with contents of Cc or Bcc + \\[message-add-archive-header]\ + Insert X-No-Archive header and note in body +\\[message-insert-to]\ + `message-insert-to' (add To header to a news followup) +\\[message-to-list-only]\ + `message-to-list-only' (remove all but list address in To/Cc) +\\[message-insert-newsgroups]\ + `message-insert-newsgroups' (add Newsgroup header to a news reply) +\\[message-goto-body]\ + `message-goto-body' (move to beginning of message text) +\\[message-goto-signature]\ + `message-goto-signature' (move to beginning of the signature) +\\[message-insert-signature]\ + `message-insert-signature' (insert `message-signature-file' file) +\\[message-yank-original]\ + `message-yank-original' (insert current message, if any) +\\[message-fill-yanked-message]\ + `message-fill-yanked-message' (fill what was yanked) +\\[message-elide-region]\ + `message-elide-region' (elide text between point and mark) +\\[message-delete-not-region]\ + `message-delete-not-region' (remove text outside the region) +\\[message-kill-to-signature]\ + `message-kill-to-signature' (kill text up to the signature) +\\[message-caesar-buffer-body]\ + `message-caesar-buffer-body' (rot13 the message body) +\\[mml-attach-file] `mml-attach-file' (attach a file as MIME) +\\[message-insert-or-toggle-importance]\ + `message-insert-or-toggle-importance' (insert or cycle importance) +\\[message-insert-disposition-notification-to]\ + `message-insert-disposition-notification-to' (request receipt) +\\[message-mark-inserted-region]\ + `message-mark-inserted-region' (mark region with enclosing tags) +\\[message-mark-insert-file]\ + `message-mark-insert-file' (insert file marked with enclosing tags) +\\[message-newline-and-reformat]\ + `message-newline-and-reformat' (break line and reformat)" (set (make-local-variable 'message-reply-buffer) nil) (set (make-local-variable 'message-inserted-headers) nil) (set (make-local-variable 'message-send-actions) nil) -- 2.17.0 --=-=-= Content-Type: text/plain "Basil L. Contovounesios" writes: > One solution is to replace the hard-coded bindings with > \[command]-sequences; another to replace the whole listing with > \{message-mode-map}. In both cases, the binding listed for > message-insert-or-toggle-importance will be C-c C-u instead of > C-c C-f C-i, due to the higher precedence of the former. WDYT? I attach a patch as an example of doing the former. The latter would probably look as follows: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Do-not-hard-code-message-mode-keys-in-docstring.patch >From e1b28796dc2c6b6828d73740dd98f4fd83771caa Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Mon, 7 May 2018 16:42:41 +0100 Subject: [PATCH] Do not hard-code message-mode keys in docstring * lisp/gnus/message.el (message-mode): Replace hard-coded bindings in docstring with summary of message-mode-map. --- lisp/gnus/message.el | 39 +++------------------------------------ 1 file changed, 3 insertions(+), 36 deletions(-) diff --git a/lisp/gnus/message.el b/lisp/gnus/message.el index 867c3d271b..a85925d94d 100644 --- a/lisp/gnus/message.el +++ b/lisp/gnus/message.el @@ -2893,42 +2893,9 @@ message--syntax-propertize ;;;###autoload (define-derived-mode message-mode text-mode "Message" "Major mode for editing mail and news to be sent. -Like Text Mode but with these additional commands:\\ -C-c C-s `message-send' (send the message) C-c C-c `message-send-and-exit' -C-c C-d Postpone sending the message C-c C-k Kill the message -C-c C-f move to a header field (and create it if there isn't): - C-c C-f C-t move to To C-c C-f C-s move to Subject - C-c C-f C-c move to Cc C-c C-f C-b move to Bcc - C-c C-f C-w move to Fcc C-c C-f C-r move to Reply-To - C-c C-f C-u move to Summary C-c C-f C-n move to Newsgroups - C-c C-f C-k move to Keywords C-c C-f C-d move to Distribution - C-c C-f C-o move to From (\"Originator\") - C-c C-f C-f move to Followup-To - C-c C-f C-m move to Mail-Followup-To - C-c C-f C-e move to Expires - C-c C-f C-i cycle through Importance values - C-c C-f s change subject and append \"(was: )\" - C-c C-f x crossposting with FollowUp-To header and note in body - C-c C-f t replace To: header with contents of Cc: or Bcc: - C-c C-f a Insert X-No-Archive: header and a note in the body -C-c C-t `message-insert-to' (add a To header to a news followup) -C-c C-l `message-to-list-only' (removes all but list address in to/cc) -C-c C-n `message-insert-newsgroups' (add a Newsgroup header to a news reply) -C-c C-b `message-goto-body' (move to beginning of message text). -C-c C-i `message-goto-signature' (move to the beginning of the signature). -C-c C-w `message-insert-signature' (insert `message-signature-file' file). -C-c C-y `message-yank-original' (insert current message, if any). -C-c C-q `message-fill-yanked-message' (fill what was yanked). -C-c C-e `message-elide-region' (elide the text between point and mark). -C-c C-v `message-delete-not-region' (remove the text outside the region). -C-c C-z `message-kill-to-signature' (kill the text up to the signature). -C-c C-r `message-caesar-buffer-body' (rot13 the message body). -C-c C-a `mml-attach-file' (attach a file as MIME). -C-c C-u `message-insert-or-toggle-importance' (insert or cycle importance). -C-c M-n `message-insert-disposition-notification-to' (request receipt). -C-c M-m `message-mark-inserted-region' (mark region with enclosing tags). -C-c M-f `message-mark-insert-file' (insert file marked with enclosing tags). -M-RET `message-newline-and-reformat' (break the line and reformat)." +Like `text-mode', but with these additional commands: + +\\{message-mode-map}" (set (make-local-variable 'message-reply-buffer) nil) (set (make-local-variable 'message-inserted-headers) nil) (set (make-local-variable 'message-send-actions) nil) -- 2.17.0 --=-=-= Content-Type: text/plain -- Basil --=-=-=-- From unknown Wed Jun 25 00:27:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31388: 27.0.50; message-mode hard-codes key bindings in docstring Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 May 2019 21:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31388 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: <31388@debbugs.gnu.org> Received: via spool by 31388-submit@debbugs.gnu.org id=B31388.155778158012212 (code B ref 31388); Mon, 13 May 2019 21:07:02 +0000 Received: (at 31388) by debbugs.gnu.org; 13 May 2019 21:06:20 +0000 Received: from localhost ([127.0.0.1]:46501 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQI9L-0003Au-Lk for submit@debbugs.gnu.org; Mon, 13 May 2019 17:06:19 -0400 Received: from quimby.gnus.org ([80.91.231.51]:46276) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQI9J-0003Ak-59 for 31388@debbugs.gnu.org; Mon, 13 May 2019 17:06:17 -0400 Received: from [12.41.144.226] (helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hQI9F-0001d4-CF for 31388@debbugs.gnu.org; Mon, 13 May 2019 23:06:15 +0200 From: Lars Ingebrigtsen References: <874lji6k7h.fsf@tcd.ie> <87wowe55dt.fsf@tcd.ie> Date: Mon, 13 May 2019 17:06:11 -0400 In-Reply-To: <87wowe55dt.fsf@tcd.ie> (Basil L. Contovounesios's message of "Tue, 08 May 2018 20:11:58 +0100") Message-ID: <875zqeqd30.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: "Basil L. Contovounesios" writes: > I attach a patch as an example of doing the former. > The latter would probably look as follows: > >>From e1b28796dc2c6b6828d73740dd98f4fd83771caa Mon Sep 17 00:00:00 2001 > From: "Basil L. Contovou [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) "Basil L. Contovounesios" writes: > I attach a patch as an example of doing the former. > The latter would probably look as follows: > >>>From e1b28796dc2c6b6828d73740dd98f4fd83771caa Mon Sep 17 00:00:00 2001 > From: "Basil L. Contovounesios" > Date: Mon, 7 May 2018 16:42:41 +0100 > Subject: [PATCH] Do not hard-code message-mode keys in docstring > > * lisp/gnus/message.el (message-mode): Replace hard-coded bindings > in docstring with summary of message-mode-map. Looks OK to me. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon May 13 19:05:32 2019 Received: (at control) by debbugs.gnu.org; 13 May 2019 23:05:32 +0000 Received: from localhost ([127.0.0.1]:46595 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQK0h-0001k1-PA for submit@debbugs.gnu.org; Mon, 13 May 2019 19:05:32 -0400 Received: from mail-ed1-f66.google.com ([209.85.208.66]:41569) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQK0c-0001je-Ld for control@debbugs.gnu.org; Mon, 13 May 2019 19:05:28 -0400 Received: by mail-ed1-f66.google.com with SMTP id m4so19889536edd.8 for ; Mon, 13 May 2019 16:05:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=djZ/fpxxcbUNYE/b22W0pKCJfYMgJjlm8TN+ZODgQy8=; b=gvgcD80WLMMWp8DY/CzCltXAjcFgM6AKO/YdNTYrQkBHqdBxGlkpjM+sHk9C0j3pzN SgEhYcoyRjr0WhnfYGtQykBw4mK7jDuZUtXpzalEdQSHTxglMPc7R6EzjpDOGq9URC/9 46RDZsMm3ruXRWUQAtA3RSNngO+FhADGVIZo/h6jUPsI8HA7kGUUqWNgbevmT8TfOYqI PjO/xuHDJvFawQQtqgYHyoh334Qn2G9SENjr8sv0DZSDMaj5hkE0aKbxXSUJ850Xr7ZO FwUzVwWKdWNrPwRIRaKz//gCZJb8qJ1IxeZcyZ7BZo+GS5eBVY47X3erRV1u1yENGE55 K9OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=djZ/fpxxcbUNYE/b22W0pKCJfYMgJjlm8TN+ZODgQy8=; b=cD8cbqRaTqHDrcfQe7NqbNxrqlhGLwLMXkJ+at34GSxMhVyszPVW+PwwiiuIKCrpcf 1242GBmqc+8LpIQgJ+y5RbvHt4UW5tOhJRja1oZIr4de2zbM9QahlsxfIBKdFLaGk6sf ujJ2GllNVD5FpZ8kSXl/Nxk9VEA53VZAR5GzEH8LG8cOG+7yVu2YkUAFmUn8jOvNUQS1 2ZiKJoCK+17OTV3HbIMvAm/gQy2+dFoWCszOcguDzJXTS0GN6WTHzeV33cUpayTOP505 TI1hqJH/DKUqloGhgj4R7H4FhT6p530yAoU90TSbaMxEc6XuWgKkZn4aFYyJjrYotv8X ibow== X-Gm-Message-State: APjAAAUBLC59z7W2e/qWFq8iZYFq8uiodijYvmkA4pe6MVcYcUne/WCo cJlf2fk+jJajO4QXwMRXatwr7x/I2+2mIQ== X-Google-Smtp-Source: APXvYqwSud0rZVvY2hHF65UtjE3WgH5CEhEWk3pkOisFHb6DTcfceAhL1W2pSn6DK0G6vptJeAR98w== X-Received: by 2002:a50:bae4:: with SMTP id x91mr32631389ede.76.1557788720873; Mon, 13 May 2019 16:05:20 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:8cad:ae29:555d:852d]) by smtp.gmail.com with ESMTPSA id h2sm1575634ejj.42.2019.05.13.16.05.19 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 13 May 2019 16:05:20 -0700 (PDT) From: "Basil L. Contovounesios" To: Lars Ingebrigtsen Subject: Re: bug#31388: 27.0.50; message-mode hard-codes key bindings in docstring References: <874lji6k7h.fsf@tcd.ie> <87wowe55dt.fsf@tcd.ie> <875zqeqd30.fsf@mouse.gnus.org> Date: Tue, 14 May 2019 00:05:18 +0100 In-Reply-To: <875zqeqd30.fsf@mouse.gnus.org> (Lars Ingebrigtsen's message of "Mon, 13 May 2019 17:06:11 -0400") Message-ID: <87imuearbl.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control Cc: 31388-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 31388 fixed close 31388 quit Lars Ingebrigtsen writes: >>>>From e1b28796dc2c6b6828d73740dd98f4fd83771caa Mon Sep 17 00:00:00 2001 >> From: "Basil L. Contovounesios" >> Date: Mon, 7 May 2018 16:42:41 +0100 >> Subject: [PATCH] Do not hard-code message-mode keys in docstring >> >> * lisp/gnus/message.el (message-mode): Replace hard-coded bindings >> in docstring with summary of message-mode-map. > > Looks OK to me. Thanks, I pushed to master[1] and am therefore closing this report. [1: 364d4e156d]: Do not hard-code message-mode keys in docstring 2019-05-13 23:58:45 +0100 https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=364d4e156d80bff711d000bdb2e0ac765726c953 -- Basil