GNU bug report logs - #31381
Drop libmad from MPD

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 31381 in the body.
You can then email your comments to 31381 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: guix-patches <at> gnu.org
Subject: Drop libmad from MPD
Date: Mon, 7 May 2018 19:03:27 -0400

[Message part 1 (text/plain, inline)]

Currently, MPD links to both LAME (via FFmpeg) and libmad for MP3
decoding. It works for me to drop the dependency on libmad and just use
LAME.

Does anyone else want to check if the change breaks their stereo?

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 31381 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: 31381 <at> debbugs.gnu.org
Subject: [PATCH] gnu: MPD: Remove unecessary dependency on libmad.
Date: Mon,  7 May 2018 19:08:22 -0400

MPD already depends on FFmpeg, which uses LAME for MP3 decoding.

gnu/packages/mpd.scm (mpd)[inputs]: Remove LIBMAD.
---
 gnu/packages/mpd.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/mpd.scm b/gnu/packages/mpd.scm
index 188903549..6f2ff5d78 100644
--- a/gnu/packages/mpd.scm
+++ b/gnu/packages/mpd.scm
@@ -119,9 +119,10 @@ interfacing MPD in the C, C++ & Objective C languages.")
               ("flac" ,flac)
               ("glib" ,glib)
               ("icu4c" ,icu4c)
+              ;; The LAME decoder comes from FFmpeg, but is added here so that
+              ;; configure picks up the LAME encoder.
               ("lame" ,lame)
               ("libid3tag" ,libid3tag)
-              ("libmad" ,libmad)
               ("libmpdclient" ,libmpdclient)
               ("libsamplerate" ,libsamplerate)
               ("libsndfile" ,libsndfile)
-- 
2.17.0

Message #13 received at 31381-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: 31381-done <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: MPD: Remove unecessary dependency on libmad.
Date: Sat, 12 May 2018 16:20:48 -0400

[Message part 1 (text/plain, inline)]

On Mon, May 07, 2018 at 07:08:22PM -0400, Leo Famulari wrote:
> MPD already depends on FFmpeg, which uses LAME for MP3 decoding.
> 
> gnu/packages/mpd.scm (mpd)[inputs]: Remove LIBMAD.

Pushed as 241caa62ca315177fd1dfc10a64621a9d29d26dd

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.