From unknown Mon Jun 23 22:04:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31376: 26.0.50; print-charset-text-property not honored Resent-From: Helmut Eller Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 07 May 2018 06:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 31376 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 31376@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.152567575918462 (code B ref -1); Mon, 07 May 2018 06:50:02 +0000 Received: (at submit) by debbugs.gnu.org; 7 May 2018 06:49:19 +0000 Received: from localhost ([127.0.0.1]:51911 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fFZxX-0004ni-BA for submit@debbugs.gnu.org; Mon, 07 May 2018 02:49:19 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49356) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fFZxV-0004nT-4X for submit@debbugs.gnu.org; Mon, 07 May 2018 02:49:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fFZxP-0005Wu-3L for submit@debbugs.gnu.org; Mon, 07 May 2018 02:49:11 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_20,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:45861) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fFZxP-0005Wp-0R for submit@debbugs.gnu.org; Mon, 07 May 2018 02:49:11 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40314) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fFZxN-0008SV-SU for bug-gnu-emacs@gnu.org; Mon, 07 May 2018 02:49:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fFZxK-0005Tw-Ol for bug-gnu-emacs@gnu.org; Mon, 07 May 2018 02:49:09 -0400 Received: from mail-wm0-x234.google.com ([2a00:1450:400c:c09::234]:38324) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fFZxK-0005TK-I4 for bug-gnu-emacs@gnu.org; Mon, 07 May 2018 02:49:06 -0400 Received: by mail-wm0-x234.google.com with SMTP id m198-v6so12527745wmg.3 for ; Sun, 06 May 2018 23:49:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=XB4p94UHU2a/UBV8G4rNUKQnoNpTclXwavoD/lycqOo=; b=dbt4gWa+H2yn0Ozax7PpAZXi48hnjtnQ8uO6SyfxgAg+4WgkJz9zavnBE80+mHMTnu FMzqQ3KbdwiwylpBnTd7o4MDihF7Man83krqCfEQVgaS64w/P9BQQ766hXxM9xf5gllT KrQnslZRkldWUVMrbTTdzbQ0S01FkDdGmy05snUiH2mRs6KErnIfJxtsn14YXg9VeKHX yOdWtSdhRBR9OH9j3UsYaQov0lC1CQlE07ipmmFnI61E2MKSvRo8Q4INESuwcd+WI04B bkhEd/I9ltJHOII/K0nKW2XOVYbNZugnScUBi3p0rTnkeBCJdOchiO1Lrexet46Y17Cf 2lnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=XB4p94UHU2a/UBV8G4rNUKQnoNpTclXwavoD/lycqOo=; b=XlZ7ueNjPlyrQj+LxpzB9h0T866vqbfQxUtxcLrj13Y61k/hYO3tBsTqlooG2eoUAA d/LhQDKNijxZ9NRM3G5vppEZbvEyLiqMC28fvgn95/53yISrbYvOe6I1zirhXWSUUyiX AlvXDHiIlKkmuiZw55rzCotspk7RoG709Mu+wvZhEwqrtgZeSKsxkwuhTlupMfF2A+Un IukpVGGQUlRcpK3GZOkkFwePdqZ1/CJvdy9nOskkqvsVHvc2A4sfvqn3PQpC8U6igy5V 1MNJFYjrhZLJ/4EOrdGvD66FQIi9vH+JTFBRDuWMZPNWYR0jum2+5HCwzhU4iITmGAU+ dSsA== X-Gm-Message-State: ALQs6tCk1hIw/hSOYvA21YN+8xq/MzkORozOEjBpGIzxSzsW+LRXF0cT NrRxq7ya/6gUwEVhPb6r45T3Ew== X-Google-Smtp-Source: AB8JxZpZEDuIVnjsLsw4G/MTi2jHnpKISspniYTHDAErAp5PpuE80zM+wJGGCOcX119n7c7HRD+gNA== X-Received: by 10.28.28.85 with SMTP id c82mr22928590wmc.69.1525675745076; Sun, 06 May 2018 23:49:05 -0700 (PDT) Received: from caladan ([37.186.165.47]) by smtp.gmail.com with ESMTPSA id m64sm10591326wmb.12.2018.05.06.23.49.03 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 06 May 2018 23:49:04 -0700 (PDT) From: Helmut Eller Date: Mon, 07 May 2018 08:48:59 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) This example (let ((print-charset-text-property nil) (print-escape-multibyte t)) (prin1 #("\x00f6\ " 0 1 (charset iso-8859-1)) (current-buffer))) when executed in the *scratch* buffer inserts #("\x00f6\ " 0 1 (charset iso-8859-1)) I would expect "\x00f6\ " without the #(...) as print-charset-text-property is bound to nil. In GNU Emacs 26.0.50 (build 10, x86_64-pc-linux-gnu, GTK+ Version 3.22.11) of 2017-08-15 built on caladan Repository revision: 66b75d3f2002459edccd241af57c63b380b192d3 Windowing system distributor 'The X.Org Foundation', version 11.0.11902000 System Description: Debian GNU/Linux 9.0 (stretch) Configured using: 'configure --with-xpm=no --with-gif=no --with-tiff=no --with-jpeg=no --without-pop' Configured features: PNG SOUND DBUS GSETTINGS NOTIFY GNUTLS LIBXML2 FREETYPE XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 LIBSYSTEMD Important settings: value of $LANG: C.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: diff-auto-refine-mode: t whitespace-mode: t outline-minor-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t From unknown Mon Jun 23 22:04:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31376: 26.0.50; print-charset-text-property not honored Resent-From: Andreas Schwab Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 07 May 2018 07:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31376 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Helmut Eller Cc: 31376@debbugs.gnu.org Received: via spool by 31376-submit@debbugs.gnu.org id=B31376.152567991424373 (code B ref 31376); Mon, 07 May 2018 07:59:02 +0000 Received: (at 31376) by debbugs.gnu.org; 7 May 2018 07:58:34 +0000 Received: from localhost ([127.0.0.1]:51939 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fFb2X-0006L3-Vp for submit@debbugs.gnu.org; Mon, 07 May 2018 03:58:34 -0400 Received: from mail-out.m-online.net ([212.18.0.10]:38550) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fFb2W-0006Kv-IO for 31376@debbugs.gnu.org; Mon, 07 May 2018 03:58:33 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 40fZkH3qRKz1qtXT; Mon, 7 May 2018 09:58:31 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 40fZkH1mf1z1qvSv; Mon, 7 May 2018 09:58:31 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id fy_S7hBcbBDS; Mon, 7 May 2018 09:58:30 +0200 (CEST) X-Auth-Info: LFmXC/bMaiYNc01Y1JFsiHrELSwNKZFn41Mhv+HjNtgfbsuWYbxeooeBwwtdbxXg Received: from localhost (ppp-188-174-145-238.dynamic.mnet-online.de [188.174.145.238]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Mon, 7 May 2018 09:58:30 +0200 (CEST) Received: by localhost (Postfix, from userid 1000) id 1671A2C132C; Mon, 7 May 2018 09:58:30 +0200 (CEST) From: Andreas Schwab References: X-Yow: Are you selling NYLON OIL WELLS?? If so, we can use TWO DOZEN!! Date: Mon, 07 May 2018 09:58:30 +0200 In-Reply-To: (Helmut Eller's message of "Mon, 07 May 2018 08:48:59 +0200") Message-ID: <87d0y7ew2h.fsf@linux-m68k.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) On Mai 07 2018, Helmut Eller wrote: > This example > > (let ((print-charset-text-property nil) > (print-escape-multibyte t)) > (prin1 #("\x00f6\ " 0 1 (charset iso-8859-1)) > (current-buffer))) > > when executed in the *scratch* buffer inserts > #("\x00f6\ " 0 1 (charset iso-8859-1)) > > I would expect "\x00f6\ " without the #(...) as > print-charset-text-property is bound to nil. > > > In GNU Emacs 26.0.50 (build 10, x86_64-pc-linux-gnu, GTK+ Version 3.22.11) > of 2017-08-15 built on caladan Worksforme. Have you tried a current version? Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different." From unknown Mon Jun 23 22:04:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31376: 26.0.50; print-charset-text-property not honored Resent-From: Helmut Eller Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 07 May 2018 08:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31376 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Andreas Schwab Cc: 31376@debbugs.gnu.org Received: via spool by 31376-submit@debbugs.gnu.org id=B31376.152568232227919 (code B ref 31376); Mon, 07 May 2018 08:39:01 +0000 Received: (at 31376) by debbugs.gnu.org; 7 May 2018 08:38:42 +0000 Received: from localhost ([127.0.0.1]:51957 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fFbfO-0007GE-7m for submit@debbugs.gnu.org; Mon, 07 May 2018 04:38:42 -0400 Received: from mail-wr0-f182.google.com ([209.85.128.182]:46932) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fFbfM-0007G1-Im for 31376@debbugs.gnu.org; Mon, 07 May 2018 04:38:41 -0400 Received: by mail-wr0-f182.google.com with SMTP id o2-v6so24927177wrj.13 for <31376@debbugs.gnu.org>; Mon, 07 May 2018 01:38:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=lV0g8SF1j+js5d6ze48unsKA04IEOoQeUThPA99Vpgg=; b=PHpJ1DQPINIHdJ4+p10+l1Nkv1w1kKBq4K8QYRTzEvU7F65A6g0rHJ1P93NkkUH7S5 JljZUyVWSohGU+ZJgnESd5eVSkZXQ/wpI2D1kBXHYrn4eC9ijeNDQKZWVpQhA5LJSTQG gJgWBWoBN3NzIAGUSobhEmQZk+VVsqcP55M4aSlFlzzQQftgiJOkRt8W8PzBw410qxlQ Y9qypvQabMp7o6rgH6+XP5dyTSCMTIOSqxPD92vAgDLq2gCEpxgdwxCD5ZqvlYx3TMDZ vYldD4+SrYk46pCjSS0inxQukHoIwXgjhJYrliBBIm2v7GVZXdot/2q3x+JmXnlvs+3j YZfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=lV0g8SF1j+js5d6ze48unsKA04IEOoQeUThPA99Vpgg=; b=q2a6nvs90uGfB7XVYDbAR3E43lrcGVO7LLkL7jgxdzIm/UoXcbo+Zdoivd+1NYNmY5 48OpT/VaCUnTyhhaUf3xfwyeb02iQlMkDJ8hmBT3bEc2jMc986Qop2gZBuZfF3gC2Psp SIeqsrT5rovQKpLTgfF4D74E6NUxn+kbJcClPRrj46tmvbxI5o99y87ARnwEgH6MSFQt iBRNBmK9seIj4dKEL0uHWJFiedc/j5ITG0nmZcH/gbUNwzRegBOY0hWr0V2ADnK/wjlK Yw3Bj5SxIvgArcXgFW4fhfY1/VDMEH7r2gbZhxPyYBhclFWxOAa8x0mCTfhv7LBhi4Dw /bgg== X-Gm-Message-State: ALQs6tDKbCH0TOt7n0qQeVXdpTLrWD9V2Q80Dw0gtigNlY1E9Spd1C3v DvGs7qL8tYkzOP0yPXPWPjnUfw== X-Google-Smtp-Source: AB8JxZolEULI1p5/ccm4ezczapN7C3dj+W10938XL8ZS14Sxwp74kJtTwA/h/z3LxRGbmWDqcK3+Rw== X-Received: by 2002:adf:a48d:: with SMTP id g13-v6mr28398072wrb.7.1525682314645; Mon, 07 May 2018 01:38:34 -0700 (PDT) Received: from caladan ([37.186.165.47]) by smtp.gmail.com with ESMTPSA id g127-v6sm8025435wmf.42.2018.05.07.01.38.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 07 May 2018 01:38:33 -0700 (PDT) From: Helmut Eller References: <87d0y7ew2h.fsf@linux-m68k.org> Date: Mon, 07 May 2018 10:38:33 +0200 In-Reply-To: <87d0y7ew2h.fsf@linux-m68k.org> (Andreas Schwab's message of "Mon, 07 May 2018 09:58:30 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Mon, May 07 2018, Andreas Schwab wrote: >> In GNU Emacs 26.0.50 (build 10, x86_64-pc-linux-gnu, GTK+ Version 3.22.11) >> of 2017-08-15 built on caladan > > Worksforme. Have you tried a current version? Same (wrong) result with the current version. Maybe it's an issue with environment settings? Helmut In GNU Emacs 27.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.22.11) of 2018-05-07 built on caladan Repository revision: 6e362a32bc9d21f73a0f29ca6f45481edeea6f29 Windowing system distributor 'The X.Org Foundation', version 11.0.11902000 System Description: Debian GNU/Linux 9 (stretch) Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Configured using: 'configure --with-xpm=no --with-gif=no --with-tiff=no --with-jpeg=no --without-pop' Configured features: PNG SOUND DBUS GSETTINGS NOTIFY GNUTLS LIBXML2 FREETYPE XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 THREADS LIBSYSTEMD Important settings: value of $LANG: C.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny seq byte-opt gv bytecomp byte-compile cconv dired dired-loaddefs format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils time-date elec-pair mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind inotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 96485 9179) (symbols 48 20209 1) (miscs 40 37 70) (strings 32 29094 2061) (string-bytes 1 762890) (vectors 16 14810) (vector-slots 8 501612 12200) (floats 8 48 69) (intervals 56 204 0) (buffers 992 11)) From unknown Mon Jun 23 22:04:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31376: 26.0.50; print-charset-text-property not honored Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 07 May 2018 12:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31376 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Helmut Eller Cc: 31376@debbugs.gnu.org, Andreas Schwab Received: via spool by 31376-submit@debbugs.gnu.org id=B31376.152569784326417 (code B ref 31376); Mon, 07 May 2018 12:58:01 +0000 Received: (at 31376) by debbugs.gnu.org; 7 May 2018 12:57:23 +0000 Received: from localhost ([127.0.0.1]:52123 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fFfhi-0006s1-Ul for submit@debbugs.gnu.org; Mon, 07 May 2018 08:57:23 -0400 Received: from mail-it0-f43.google.com ([209.85.214.43]:54016) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fFfhh-0006rn-GZ for 31376@debbugs.gnu.org; Mon, 07 May 2018 08:57:21 -0400 Received: by mail-it0-f43.google.com with SMTP id n64-v6so5529940itb.3 for <31376@debbugs.gnu.org>; Mon, 07 May 2018 05:57:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=hwaJWUXP6ua236x4JVKgZdN/epreBLMzyr5LDmvRA0g=; b=M2+Hron9pup8wZm/7lEh15nH6je8Fazdys5c2xR5NXltv2xQ4509RQn25c594aeS9m XOcnsag34lxXhLVSUwXYbjyhT3yCjew548BUDpjbJ+YNg8FiXNQSJ+9Wnn+Q+9js64Y8 PIQjLfgFvB8T0VrCgUA/Obu1akK0d+nFXOtCbggASuXGGaoi5GO1F+VlQM0dBnMAd3fr E544oAAo/jOZfZe66vpi/Yj+tqyGmJVghaEdD7cr2wgQolgVRl6dH8cV1HVmfHWqAopK ZeNp5yP5gyEYWE0ZGHNKrSEYXMRmOOLId6E2/QkVD8v1PcfpOLNaXweUISmMwUXQAqSl Gxhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=hwaJWUXP6ua236x4JVKgZdN/epreBLMzyr5LDmvRA0g=; b=hwlEl+uDRyp17wcRiiRWPT7Txlt+kkc2XTrL7h48g5uUtlFGfJqybuS3eVi4doVDDf qCPTY3BTPQ60PAh9FFIp2gcTwRvz4gGzYhYJbx+hfNM8csGf+4n7r14xm3x5h4J7A3U/ jo42+Hs0wd48M2MsNHVEvkjw5vnQCAlP+mItbnrzgz62suUdaEpv6GYjmjJ8V84zcs/8 8wGS5c7iZ4H8oc3H0gud/vBviTkMuCHpt80iYj4joVE1j9MmkQKcYDUfPJ8SDFwjbkVY 22N5wt1I5xpoOEWwP4+ulcH08EQcmICd5IW/JBY89uA3B0lMnMiufazq8d1OkcqOdu/t FqqA== X-Gm-Message-State: ALQs6tC/AgXHhcdGfoTMjc1H0Fdv03CSbolqSCbf4Q66+pMDJS6+9Ej8 q4HIoRuvkohYu8Aw5CZUjAiByw== X-Google-Smtp-Source: AB8JxZrzfy1wvMLjTXq657JVt38ryGjWwDCsawhKg0a9xzRnUu65PvY06DdUH+dXkCjxXMZt32RjIg== X-Received: by 2002:a24:7512:: with SMTP id y18-v6mr1029428itc.31.1525697835622; Mon, 07 May 2018 05:57:15 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id k3-v6sm5870465ioj.55.2018.05.07.05.57.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 07 May 2018 05:57:14 -0700 (PDT) From: Noam Postavsky References: <87d0y7ew2h.fsf@linux-m68k.org> Date: Mon, 07 May 2018 08:57:13 -0400 In-Reply-To: (Helmut Eller's message of "Mon, 07 May 2018 10:38:33 +0200") Message-ID: <87603zmxna.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Helmut Eller writes: > On Mon, May 07 2018, Andreas Schwab wrote: > >>> In GNU Emacs 26.0.50 (build 10, x86_64-pc-linux-gnu, GTK+ Version 3.22.11) >>> of 2017-08-15 built on caladan >> >> Worksforme. Have you tried a current version? > > Same (wrong) result with the current version. Maybe it's an issue with > environment settings? I can reproduce this. I see something about PRINT_STRING_UNSAFE_CHARSET_FOUND in print.c, so I guess iso-8859-1 is considered "unsafe"? From unknown Mon Jun 23 22:04:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31376: 26.0.50; print-charset-text-property not honored Resent-From: Helmut Eller Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 07 May 2018 18:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31376 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Noam Postavsky Cc: 31376@debbugs.gnu.org, Andreas Schwab Received: via spool by 31376-submit@debbugs.gnu.org id=B31376.152571650924128 (code B ref 31376); Mon, 07 May 2018 18:09:02 +0000 Received: (at 31376) by debbugs.gnu.org; 7 May 2018 18:08:29 +0000 Received: from localhost ([127.0.0.1]:53096 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fFkYm-0006H6-VG for submit@debbugs.gnu.org; Mon, 07 May 2018 14:08:29 -0400 Received: from mail-wm0-f49.google.com ([74.125.82.49]:55601) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fFkYk-0006Gh-Ll for 31376@debbugs.gnu.org; Mon, 07 May 2018 14:08:27 -0400 Received: by mail-wm0-f49.google.com with SMTP id a8so14796692wmg.5 for <31376@debbugs.gnu.org>; Mon, 07 May 2018 11:08:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=REWC04rD9H5audbFOUQ3k/C8upo9ZEVUEm/CeEszedQ=; b=djZHAVZVrE/S/WCYPyoS/5Ly4TUJPUCM0twCk2aFQdaUkiTB8nzO1soovlrqQLYXMX jQUEmWTrRBc5MT5+Jz+WvLPFIU+JELZANHzu5VNjuKiQsflBW8ROyXOiAWzNSfNDVPGm GF91wbJiBCi6KfNVbj4K0L48U0sqFIKF8eZSk0MHeGsHEU2mSZ+lnZa9o+rhTlICuzx+ RK0JSg0Zn4ozQJ1W7e/jQFcwc1jRwkyhNKu1LJyx+kKrh2s00QiyFPBxy0Zi/aTkc/XL 76yV52qje8s90HJNFqaiX9lbX8r3+muX9174lDmLuFh1nkK5KSsTYEpD7vOUaujaNkTL tlOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=REWC04rD9H5audbFOUQ3k/C8upo9ZEVUEm/CeEszedQ=; b=Czrw65BvjAgGbE6fEdN8aJjai0rweHIWZ4rylr9aRZPCuFbMR2PBy030dCJISvNqVZ uYgIn5OX4IYFFyUhMTxzdyB1oWjlPWa+RfvpO8i/9nMQ3xm3FQrSvgFXpeI/yczQcYq7 fy14SXdvIzVLAVTJnv3HpNnicjS0qF/5Czu/Z7xSM4OuJNwWGwmsyMTRTHfC3sDYZbAa N4ODQlGVn6CjQS5UM2pdz5VeqdOb9mdM//yDrMsjaEJA9c/JUQybVPVlgC8nIS9hj/eR esSA1EBEAxF7I+XUV+o4p4eNvjjmydcmATqQMg5g/j4lgpQA9napKaa1eh7GAw24qTOS 4QyA== X-Gm-Message-State: ALKqPwctOSnhmrOc1l/Co2qK4diCnpBQ2tsqiBju98Y5rGpwCgO9poY+ habZZZSOGxFoaFZcIDLb58H4YA== X-Google-Smtp-Source: AB8JxZos4Y/REIJReP0p4W4WhV/7ccrnydWQUWiKNvhbNUKl59Ay5nc/inlO38U5hcj+s5b6PoUoNQ== X-Received: by 2002:a1c:c241:: with SMTP id s62-v6mr1532356wmf.112.1525716500774; Mon, 07 May 2018 11:08:20 -0700 (PDT) Received: from caladan ([37.186.165.47]) by smtp.gmail.com with ESMTPSA id k23-v6sm28267204wrc.59.2018.05.07.11.08.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 07 May 2018 11:08:20 -0700 (PDT) From: Helmut Eller References: <87d0y7ew2h.fsf@linux-m68k.org> <87603zmxna.fsf@gmail.com> Date: Mon, 07 May 2018 20:08:19 +0200 In-Reply-To: <87603zmxna.fsf@gmail.com> (Noam Postavsky's message of "Mon, 07 May 2018 08:57:13 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Mon, May 07 2018, Noam Postavsky wrote: > Helmut Eller writes: > >> On Mon, May 07 2018, Andreas Schwab wrote: >> >>>> In GNU Emacs 26.0.50 (build 10, x86_64-pc-linux-gnu, GTK+ Version 3.22.11) >>>> of 2017-08-15 built on caladan >>> >>> Worksforme. Have you tried a current version? >> >> Same (wrong) result with the current version. Maybe it's an issue with >> environment settings? > > I can reproduce this. I see something about > PRINT_STRING_UNSAFE_CHARSET_FOUND in print.c, so I guess iso-8859-1 is > considered "unsafe"? Apparently which charsets are unsafe depends on the current locale. If I start Emacs with LANG=it_IT.UTF-8 emacs -Q, then the charset property is not printed. Even though that locale is not installed and this warning is printed at startup: (process:23336): Gtk-WARNING **: Locale not supported by C library. Using the fallback 'C' locale. With LANG=en_US.UTF-8 emacs -Q the problem is the same as for LANG=C.UTF-8. Maybe this dependency on the current locale is useful, but the docstring of print-charset-text-property should probably mention it. Helmut From unknown Mon Jun 23 22:04:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31376: 26.0.50; print-charset-text-property not honored Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 May 2018 13:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31376 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Helmut Eller , Kenichi Handa Cc: 31376@debbugs.gnu.org, schwab@linux-m68k.org, npostavs@gmail.com Reply-To: Eli Zaretskii Received: via spool by 31376-submit@debbugs.gnu.org id=B31376.152604556119824 (code B ref 31376); Fri, 11 May 2018 13:33:01 +0000 Received: (at 31376) by debbugs.gnu.org; 11 May 2018 13:32:41 +0000 Received: from localhost ([127.0.0.1]:57292 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fH8A1-00059c-Gr for submit@debbugs.gnu.org; Fri, 11 May 2018 09:32:41 -0400 Received: from eggs.gnu.org ([208.118.235.92]:48405) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fH89w-00059J-2v for 31376@debbugs.gnu.org; Fri, 11 May 2018 09:32:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fH89m-0001i3-1b for 31376@debbugs.gnu.org; Fri, 11 May 2018 09:32:27 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36432) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fH89U-0001XK-7s; Fri, 11 May 2018 09:32:04 -0400 Received: from [176.228.60.248] (port=3556 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fH89S-0005fg-Fu; Fri, 11 May 2018 09:32:03 -0400 Date: Fri, 11 May 2018 16:31:51 +0300 Message-Id: <83mux6nws8.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Helmut Eller on Mon, 07 May 2018 20:08:19 +0200) References: <87d0y7ew2h.fsf@linux-m68k.org> <87603zmxna.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Helmut Eller > Date: Mon, 07 May 2018 20:08:19 +0200 > Cc: 31376@debbugs.gnu.org, Andreas Schwab > > On Mon, May 07 2018, Noam Postavsky wrote: > > > Helmut Eller writes: > > > >> On Mon, May 07 2018, Andreas Schwab wrote: > >> > >>>> In GNU Emacs 26.0.50 (build 10, x86_64-pc-linux-gnu, GTK+ Version 3.22.11) > >>>> of 2017-08-15 built on caladan > >>> > >>> Worksforme. Have you tried a current version? > >> > >> Same (wrong) result with the current version. Maybe it's an issue with > >> environment settings? > > > > I can reproduce this. I see something about > > PRINT_STRING_UNSAFE_CHARSET_FOUND in print.c, so I guess iso-8859-1 is > > considered "unsafe"? > > Apparently which charsets are unsafe depends on the current locale. > > If I start Emacs with LANG=it_IT.UTF-8 emacs -Q, then the charset > property is not printed. Even though that locale is not installed and > this warning is printed at startup: > > (process:23336): Gtk-WARNING **: Locale not supported by C library. > Using the fallback 'C' locale. > > With LANG=en_US.UTF-8 emacs -Q the problem is the same as for > LANG=C.UTF-8. Can someone see any difference between the value t and 'default', wrt when/how the 'charset' property of strings is printed? I think the behavior under the value of nil is actually intended for 'default', and the value of nil is not implemented. So I think we should have a change in print_check_string_charset_prop that sets the PRINT_STRING_UNSAFE_CHARSET_FOUND flag whenever it finds _any_ 'charset' property on the string. Comments? From unknown Mon Jun 23 22:04:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31376: 26.0.50; print-charset-text-property not honored Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 May 2018 17:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31376 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: Kenichi Handa , Andreas Schwab , 31376@debbugs.gnu.org, Helmut Eller Received: via spool by 31376-submit@debbugs.gnu.org id=B31376.152606069411039 (code B ref 31376); Fri, 11 May 2018 17:45:01 +0000 Received: (at 31376) by debbugs.gnu.org; 11 May 2018 17:44:54 +0000 Received: from localhost ([127.0.0.1]:58659 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fHC6A-0002ry-Jq for submit@debbugs.gnu.org; Fri, 11 May 2018 13:44:54 -0400 Received: from mail-oi0-f46.google.com ([209.85.218.46]:38936) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fHC69-0002rl-2E for 31376@debbugs.gnu.org; Fri, 11 May 2018 13:44:53 -0400 Received: by mail-oi0-f46.google.com with SMTP id n65-v6so5403632oig.6 for <31376@debbugs.gnu.org>; Fri, 11 May 2018 10:44:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=RYOTun3m+T94aCxrzar0UJfd+lCdXrOy0RD2dO33RT8=; b=i9V5G333hF2XmrKtLmr1XDGqn3d6afkYAlqeMvALvHmdXtfvCsw/BgH2YsGlLrtw2o IZPZ3xNkKbR1vzQbRwkbj6sc4GC0zg3LaYXjId0qlr86vbj+T1j2R1qo5W8K8UXm9bW4 54929uFYV4DLAafHH0s+1EuGSoCRScPGVLDdw2yBu7VsbUI46LbS/bMQsrrD48DdfQaC vpH8UaJl5aP+NB1qlSCgk491h0rR6L9Kib8akgZfQWNhrQ7jaO5N00AT27pAKNLoKB2W ozxySeeHMYNGqll8RFOZog3crcv/uaWunFRmVNVhEmmEKR5dpUSQrNKju7sQcyQhfxqJ mZvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=RYOTun3m+T94aCxrzar0UJfd+lCdXrOy0RD2dO33RT8=; b=NpeITOHPYGwA4wfFSSJ1BPVwT3YvJCJp9s1i2ZG0Hvk5BmH5HnhKcnZZLFhUxjG7rr PH/9zV+Qvv6nf2ln2kFTXJOh76kxk8eXn950opoAmG5+WwH4z8f/MwCbckfPOPJIafj2 MpbXNTaWqBRjGO5MT3wTnce3oJHWv+4e27TFG1qEW51UXaOkBT8FgLjpaeL56wMlxfiY AFaSB0oS+nL2r5rATT2X/DTro0Q9T8YyAvbcqevlM05e1TqcCT2zztJn1M18Scolmx2k 6V9nCvV0vGGC/cLJee29atY48vkNgQk899zDIoTxKGEdmjjCz2Huo3porQFc7sio4K+1 +N3g== X-Gm-Message-State: ALKqPwdcAblD4bQ6UuPMEsD1CxLIGGzqGWmQGT2L8uj2mJVDYHmmoOJz IBDZFAFEV7YvaxmfIIip+NOkXpi0ElahZq39K8M= X-Google-Smtp-Source: AB8JxZpshEhPcW8uquwx0o3WfkXPKRAdMh1K5wACbyTVCPA+XQvCi6hBUB/jgZ5hO2+48nGYWqVPBp996DA3nPe3jHQ= X-Received: by 2002:aca:d052:: with SMTP id h79-v6mr3591441oig.330.1526060687369; Fri, 11 May 2018 10:44:47 -0700 (PDT) MIME-Version: 1.0 Received: by 10.74.5.135 with HTTP; Fri, 11 May 2018 10:44:46 -0700 (PDT) In-Reply-To: <83mux6nws8.fsf@gnu.org> References: <87d0y7ew2h.fsf@linux-m68k.org> <87603zmxna.fsf@gmail.com> <83mux6nws8.fsf@gnu.org> From: Noam Postavsky Date: Fri, 11 May 2018 13:44:46 -0400 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 11 May 2018 at 09:31, Eli Zaretskii wrote: > Can someone see any difference between the value t and 'default', wrt ^ nil > when/how the 'charset' property of strings is printed? Assuming you meant nil, then no, I can't see any difference. As far as I can tell, setting to 'default' just makes Emacs do pointless extra checking for "unsafe" charsets even after it has found one. > I think the behavior under the value of nil is actually intended for > 'default', and the value of nil is not implemented. So I think we > should have a change in print_check_string_charset_prop that sets the > PRINT_STRING_UNSAFE_CHARSET_FOUND flag whenever it finds _any_ > 'charset' property on the string. It looks like the NILP (Vprint_charset_text_property) check is just in the wrong place, if I move it to print_prune_string_charset then it seems to work as documented. --- i/src/print.c +++ w/src/print.c @@ -1317,8 +1317,7 @@ print_check_string_charset_prop (INTERVAL interval, || CONSP (XCDR (XCDR (val)))) print_check_string_result |= PRINT_STRING_NON_CHARSET_FOUND; } - if (NILP (Vprint_charset_text_property) - || ! (print_check_string_result & PRINT_STRING_UNSAFE_CHARSET_FOUND)) + if (! (print_check_string_result & PRINT_STRING_UNSAFE_CHARSET_FOUND)) { int i, c; ptrdiff_t charpos = interval->position; @@ -1348,7 +1347,8 @@ print_prune_string_charset (Lisp_Object string) print_check_string_result = 0; traverse_intervals (string_intervals (string), 0, print_check_string_charset_prop, string); - if (! (print_check_string_result & PRINT_STRING_UNSAFE_CHARSET_FOUND)) + if (NILP (Vprint_charset_text_property) + || ! (print_check_string_result & PRINT_STRING_UNSAFE_CHARSET_FOUND)) { string = Fcopy_sequence (string); if (print_check_string_result & PRINT_STRING_NON_CHARSET_FOUND) From unknown Mon Jun 23 22:04:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31376: 26.0.50; print-charset-text-property not honored Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 May 2018 18:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31376 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Noam Postavsky Cc: handa@gnu.org, schwab@linux-m68k.org, 31376@debbugs.gnu.org, eller.helmut@gmail.com Reply-To: Eli Zaretskii Received: via spool by 31376-submit@debbugs.gnu.org id=B31376.152606435616315 (code B ref 31376); Fri, 11 May 2018 18:46:02 +0000 Received: (at 31376) by debbugs.gnu.org; 11 May 2018 18:45:56 +0000 Received: from localhost ([127.0.0.1]:58679 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fHD3D-0004F5-Ra for submit@debbugs.gnu.org; Fri, 11 May 2018 14:45:56 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41824) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fHD3B-0004Er-2g for 31376@debbugs.gnu.org; Fri, 11 May 2018 14:45:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fHD34-0006A6-Os for 31376@debbugs.gnu.org; Fri, 11 May 2018 14:45:47 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42911) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fHD2x-0005po-LD; Fri, 11 May 2018 14:45:39 -0400 Received: from [176.228.60.248] (port=1455 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fHD2x-00014E-4I; Fri, 11 May 2018 14:45:39 -0400 Date: Fri, 11 May 2018 21:45:36 +0300 Message-Id: <837eoani9b.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Noam Postavsky on Fri, 11 May 2018 13:44:46 -0400) References: <87d0y7ew2h.fsf@linux-m68k.org> <87603zmxna.fsf@gmail.com> <83mux6nws8.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Noam Postavsky > Date: Fri, 11 May 2018 13:44:46 -0400 > Cc: Helmut Eller , Kenichi Handa , 31376@debbugs.gnu.org, > Andreas Schwab > > On 11 May 2018 at 09:31, Eli Zaretskii wrote: > > > Can someone see any difference between the value t and 'default', wrt > ^ > nil > > when/how the 'charset' property of strings is printed? > > Assuming you meant nil, then no, I can't see any difference. Mmm... yes, nil. > As far as > I can tell, setting to 'default' just makes Emacs do pointless extra > checking for "unsafe" charsets even after it has found one. You mean, setting it to nil makes it do pointless extra work, yes? ;-) > It looks like the NILP (Vprint_charset_text_property) check is just in > the wrong place, if I move it to print_prune_string_charset then it > seems to work as documented. > > --- i/src/print.c > +++ w/src/print.c > @@ -1317,8 +1317,7 @@ print_check_string_charset_prop (INTERVAL interval, > || CONSP (XCDR (XCDR (val)))) > print_check_string_result |= PRINT_STRING_NON_CHARSET_FOUND; > } > - if (NILP (Vprint_charset_text_property) > - || ! (print_check_string_result & PRINT_STRING_UNSAFE_CHARSET_FOUND)) > + if (! (print_check_string_result & PRINT_STRING_UNSAFE_CHARSET_FOUND)) > { > int i, c; > ptrdiff_t charpos = interval->position; > @@ -1348,7 +1347,8 @@ print_prune_string_charset (Lisp_Object string) > print_check_string_result = 0; > traverse_intervals (string_intervals (string), 0, > print_check_string_charset_prop, string); > - if (! (print_check_string_result & PRINT_STRING_UNSAFE_CHARSET_FOUND)) > + if (NILP (Vprint_charset_text_property) > + || ! (print_check_string_result & PRINT_STRING_UNSAFE_CHARSET_FOUND)) Yes, that sounds right, thanks. We should also mention in the doc string that any non-nil, non-t value is treated as 'default'. And this variable should be mentioned in the ELisp manual, in the node "Output Variables". From unknown Mon Jun 23 22:04:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31376: 26.0.50; print-charset-text-property not honored Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 May 2018 19:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31376 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii , Noam Postavsky Cc: eller.helmut@gmail.com, 31376@debbugs.gnu.org, schwab@linux-m68k.org Received: via spool by 31376-submit@debbugs.gnu.org id=B31376.152606870222488 (code B ref 31376); Fri, 11 May 2018 19:59:01 +0000 Received: (at 31376) by debbugs.gnu.org; 11 May 2018 19:58:22 +0000 Received: from localhost ([127.0.0.1]:58695 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fHEBK-0005qe-Lv for submit@debbugs.gnu.org; Fri, 11 May 2018 15:58:22 -0400 Received: from aserp2130.oracle.com ([141.146.126.79]:43806) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fHEBJ-0005qO-7T for 31376@debbugs.gnu.org; Fri, 11 May 2018 15:58:21 -0400 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w4BJuEHR071922; Fri, 11 May 2018 19:58:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2017-10-26; bh=Lv1K35bl0wlPteqA3V1oFlVMqyEgJqXjo1hVLO11nfk=; b=ndnkSZMUw0mDDjtBWxbLG9thetD870Eikje64VTk1MwgeTbnuEWr3DGCemHKS2IwoAsn UPRvehx9D9kQXBP4i7nhDxp29o2ziAdyeNTUkBdYacR6XRuCFc4Bl6ayjw5cqm3jjURR Ul44vZAIOS0BLWefHywsBQP7/nE+407iONNPMN36vN2+peTZkHp+07uSNGaRlwqoDQsI zbNEQPtwUoRbrIeJ3XTnWRXKdgeGL69IxVCGZu6UL2QoIj/s2dZixry33a9MVTFbkqtX ic2CP7dagOBBU1Xo+OlIvE7YPqtU52WlrFNO5eapv6P4MQkSpjks6L56BvVDe0TKLsTq bQ== Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by aserp2130.oracle.com with ESMTP id 2hwabc9vx3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 11 May 2018 19:58:14 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w4BJwEnI010074 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 11 May 2018 19:58:14 GMT Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w4BJwCFD023280; Fri, 11 May 2018 19:58:13 GMT MIME-Version: 1.0 Message-ID: Date: Fri, 11 May 2018 12:58:11 -0700 (PDT) From: Drew Adams References: <> <<87d0y7ew2h.fsf@linux-m68k.org> > <<87603zmxna.fsf@gmail.com> > <<83mux6nws8.fsf@gnu.org> > <<837eoani9b.fsf@gnu.org>> In-Reply-To: <<837eoani9b.fsf@gnu.org>> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4690.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8890 signatures=668698 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=548 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1805110182 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > We should also mention in the doc > string that any non-nil, non-t value is treated as 'default'. That doesn't sound great - not very conventional. Instead of `t' meaning something special and other non-nil meaning something non-special we usually have a mnemonic symbol for the special case and other non-nil for the non-special case.=20 It's no doubt too late to change this, since the mistake seems to have been made way back in Emacs 23. The doc should even point out that this is maybe not what you might expect. IOW, stress that `t' is a special case. From unknown Mon Jun 23 22:04:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31376: 26.0.50; print-charset-text-property not honored Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 12 May 2018 06:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31376 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Drew Adams Cc: eller.helmut@gmail.com, 31376@debbugs.gnu.org, schwab@linux-m68k.org, npostavs@gmail.com Reply-To: Eli Zaretskii Received: via spool by 31376-submit@debbugs.gnu.org id=B31376.152610546010707 (code B ref 31376); Sat, 12 May 2018 06:11:01 +0000 Received: (at 31376) by debbugs.gnu.org; 12 May 2018 06:11:00 +0000 Received: from localhost ([127.0.0.1]:58845 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fHNkC-0002mc-5o for submit@debbugs.gnu.org; Sat, 12 May 2018 02:11:00 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49249) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fHNkA-0002mQ-96 for 31376@debbugs.gnu.org; Sat, 12 May 2018 02:10:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fHNk4-0004tQ-7u for 31376@debbugs.gnu.org; Sat, 12 May 2018 02:10:53 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53243) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fHNjv-0004qk-7r; Sat, 12 May 2018 02:10:43 -0400 Received: from [176.228.60.248] (port=1076 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fHNju-0003VY-Kv; Sat, 12 May 2018 02:10:43 -0400 Date: Sat, 12 May 2018 09:10:42 +0300 Message-Id: <834ljdo13x.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Drew Adams on Fri, 11 May 2018 12:58:11 -0700 (PDT)) References: <> <<87d0y7ew2h.fsf@linux-m68k.org> > <<87603zmxna.fsf@gmail.com> > <<83mux6nws8.fsf@gnu.org> > <<837eoani9b.fsf@gnu.org>> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > Date: Fri, 11 May 2018 12:58:11 -0700 (PDT) > From: Drew Adams > Cc: 31376@debbugs.gnu.org, schwab@linux-m68k.org, eller.helmut@gmail.com > > > We should also mention in the doc > > string that any non-nil, non-t value is treated as 'default'. > > That doesn't sound great - not very conventional. > Instead of `t' meaning something special and other > non-nil meaning something non-special we usually > have a mnemonic symbol for the special case and > other non-nil for the non-special case. Usually, but not always. We have examples of the other behavior as well. From unknown Mon Jun 23 22:04:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31376: 26.0.50; print-charset-text-property not honored Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 12 May 2018 20:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31376 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: handa@gnu.org, 31376@debbugs.gnu.org, schwab@linux-m68k.org, eller.helmut@gmail.com Received: via spool by 31376-submit@debbugs.gnu.org id=B31376.15261553321562 (code B ref 31376); Sat, 12 May 2018 20:03:02 +0000 Received: (at 31376) by debbugs.gnu.org; 12 May 2018 20:02:12 +0000 Received: from localhost ([127.0.0.1]:59871 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fHaiY-0000P2-Q8 for submit@debbugs.gnu.org; Sat, 12 May 2018 16:02:11 -0400 Received: from mail-it0-f50.google.com ([209.85.214.50]:36707) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fHaiW-0000Oh-Ua; Sat, 12 May 2018 16:02:09 -0400 Received: by mail-it0-f50.google.com with SMTP id e20-v6so6242513itc.1; Sat, 12 May 2018 13:02:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=eGDqlxXPdswLNub3yzpEBEQI2NybA3NgtJuXlKN+vIE=; b=hfKCt2fOxPDvzqGuqPlRIpRi2k2lwLERiOKZiVq76ShjiKjJZHDgabFyGEcXZ4Rr7k yc8U4KWx+sJJAT/16YH87G1MRekRmZr+GNY21l+z586fg2Xql41LmxetXJLYWfMdJMrK 1xF9y0mnHUgsmM7zOJBPjlTJR5zmgxWHghEGPRU0yEqkZv3AsDa1e1DYpAn7541oIQt/ ujlGYw0Qg0vUe3dmgn4PneiZ+mPTUvRttdzYwv4Q6hPe39VrjWEKHv6Egq6hwPcFK6l/ IbGvgUcNqoG3hpoXFr2epj2qqqdcGqMyv/seBKevVJgQTH2SvmlVZJcHyGrbRsyxKBrS XicA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=eGDqlxXPdswLNub3yzpEBEQI2NybA3NgtJuXlKN+vIE=; b=LDdn1mK6G4AJF0633ij+sKrlu335MfhyIJXflXIp8f4n6UNr5jbAcseX+E+ydZE5MK cuaxn805q+R8EG0NTT0ZQuYgueIGyeVw3rKSMvcN+HTVvSeYZC3OKZO6hxbdssPzvBzP yIJx10dq8Lfp6qmKqbMDeGmxjzXBChjVEYDzR91VK4BQ00Uq7CF5maLprflD7u+EwikA xTWILd3K2oWonRj7ogDX3bKT84wghHORwNQdPD3j8Ql3rSJv6rZfm4yaO0Z01EHpGwre JJ2yNHoiKQK8K3nsTmpX5ePzhQyfloDx4vqOlzLat8PvDo55nGyNKG/BE0lFInrXVbRo IVHA== X-Gm-Message-State: ALKqPwdUTaGpDdIUybd3MMYZCo6nw11zeO5+Z4u6VeYchltJ+UsDJnuN fmmuxClB7/vulCuKxI7vbII6tg== X-Google-Smtp-Source: AB8JxZpBiuXfluf/OBfFvVFvSkWT+J0zxFVPrRMvwGRels2gn/Csf2RrlppzVLYXgR5VhMd5W7Qf1w== X-Received: by 2002:a24:2706:: with SMTP id g6-v6mr3502274ita.5.1526155323201; Sat, 12 May 2018 13:02:03 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id p101-v6sm3303013ioo.12.2018.05.12.13.02.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 12 May 2018 13:02:02 -0700 (PDT) From: Noam Postavsky References: <87d0y7ew2h.fsf@linux-m68k.org> <87603zmxna.fsf@gmail.com> <83mux6nws8.fsf@gnu.org> <837eoani9b.fsf@gnu.org> Date: Sat, 12 May 2018 16:02:01 -0400 In-Reply-To: <837eoani9b.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 11 May 2018 21:45:36 +0300") Message-ID: <871seglk1y.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain tags 31376 + patch quit Eli Zaretskii writes: >> As far as I can tell, setting to 'default' just makes Emacs do >> pointless extra checking for "unsafe" charsets even after it has >> found one. > > You mean, setting it to nil makes it do pointless extra work, yes? ;-) Hah! I guess I really can't tell the difference :) > Yes, that sounds right, thanks. We should also mention in the doc > string that any non-nil, non-t value is treated as 'default'. > And this variable should be mentioned in the ELisp manual, in the node > "Output Variables". Okay, how about this: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Honor-print-charset-text-property-value-of-nil-Bug-3.patch Content-Description: patch >From eed29c8e7164cbc13df4d7b4e3974ae90d9ecb51 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Fri, 11 May 2018 13:44:46 -0400 Subject: [PATCH] Honor print-charset-text-property value of nil (Bug#31376) * src/print.c (print_check_string_charset_prop): Move check for nil Vprint_charset_text_property from here... (print_prune_string_charset): ... to here. (syms_of_print) : Clarify that any non-boolean values are treated the same as `default'. * doc/lispref/streams.texi (Output Variables): Add print-prune-string-charset. --- doc/lispref/streams.texi | 13 +++++++++++++ src/print.c | 11 ++++++----- 2 files changed, 19 insertions(+), 5 deletions(-) diff --git a/doc/lispref/streams.texi b/doc/lispref/streams.texi index ebd806601e..ae3b982080 100644 --- a/doc/lispref/streams.texi +++ b/doc/lispref/streams.texi @@ -809,6 +809,19 @@ Output Variables one. @end defvar +@defvar print-charset-text-property +This variable controls printing of `charset' text property on printing +a string. The value should be @code{nil}, @code{t}, or +@code{default}. + +If the value is @code{nil}, @code{charset} text properties are never +printed. If @code{t}, they are always printed. If the value is +@code{default}, print the text property @code{charset} only when the +value is different from what is guessed in the current charset +priorities. Values other than @code{nil} or @code{t} are treated the +same as @code{default}. +@end defvar + @defvar print-length @cindex printing limits The value of this variable is the maximum number of elements to print in diff --git a/src/print.c b/src/print.c index 15177759cf..427ab7d158 100644 --- a/src/print.c +++ b/src/print.c @@ -1317,8 +1317,7 @@ print_check_string_charset_prop (INTERVAL interval, Lisp_Object string) || CONSP (XCDR (XCDR (val)))) print_check_string_result |= PRINT_STRING_NON_CHARSET_FOUND; } - if (NILP (Vprint_charset_text_property) - || ! (print_check_string_result & PRINT_STRING_UNSAFE_CHARSET_FOUND)) + if (! (print_check_string_result & PRINT_STRING_UNSAFE_CHARSET_FOUND)) { int i, c; ptrdiff_t charpos = interval->position; @@ -1348,7 +1347,8 @@ print_prune_string_charset (Lisp_Object string) print_check_string_result = 0; traverse_intervals (string_intervals (string), 0, print_check_string_charset_prop, string); - if (! (print_check_string_result & PRINT_STRING_UNSAFE_CHARSET_FOUND)) + if (NILP (Vprint_charset_text_property) + || ! (print_check_string_result & PRINT_STRING_UNSAFE_CHARSET_FOUND)) { string = Fcopy_sequence (string); if (print_check_string_result & PRINT_STRING_NON_CHARSET_FOUND) @@ -2422,7 +2422,7 @@ representation) and `#N#' in place of each subsequent occurrence, DEFVAR_LISP ("print-charset-text-property", Vprint_charset_text_property, doc: /* A flag to control printing of `charset' text property on printing a string. -The value must be nil, t, or `default'. +The value should be nil, t, or `default'. If the value is nil, don't print the text property `charset'. @@ -2430,7 +2430,8 @@ representation) and `#N#' in place of each subsequent occurrence, If the value is `default', print the text property `charset' only when the value is different from what is guessed in the current charset -priorities. */); +priorities. Values other than nil or t are also treated as +`default'. */); Vprint_charset_text_property = Qdefault; /* prin1_to_string_buffer initialized in init_buffer_once in buffer.c */ -- 2.11.0 --=-=-=-- From unknown Mon Jun 23 22:04:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31376: 26.0.50; print-charset-text-property not honored Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 May 2018 15:30:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31376 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Noam Postavsky Cc: handa@gnu.org, 31376@debbugs.gnu.org, schwab@linux-m68k.org, eller.helmut@gmail.com Reply-To: Eli Zaretskii Received: via spool by 31376-submit@debbugs.gnu.org id=B31376.152622538520241 (code B ref 31376); Sun, 13 May 2018 15:30:01 +0000 Received: (at 31376) by debbugs.gnu.org; 13 May 2018 15:29:45 +0000 Received: from localhost ([127.0.0.1]:60952 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fHswT-0005GO-2E for submit@debbugs.gnu.org; Sun, 13 May 2018 11:29:45 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42711) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fHswS-0005GC-03 for 31376@debbugs.gnu.org; Sun, 13 May 2018 11:29:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fHswM-000745-0V for 31376@debbugs.gnu.org; Sun, 13 May 2018 11:29:38 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46619) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fHswG-000717-SW; Sun, 13 May 2018 11:29:32 -0400 Received: from [176.228.60.248] (port=3092 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fHswG-00017N-Bl; Sun, 13 May 2018 11:29:32 -0400 Date: Sun, 13 May 2018 18:29:34 +0300 Message-Id: <83r2mflgkh.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <871seglk1y.fsf@gmail.com> (message from Noam Postavsky on Sat, 12 May 2018 16:02:01 -0400) References: <87d0y7ew2h.fsf@linux-m68k.org> <87603zmxna.fsf@gmail.com> <83mux6nws8.fsf@gnu.org> <837eoani9b.fsf@gnu.org> <871seglk1y.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Noam Postavsky > Cc: handa@gnu.org, schwab@linux-m68k.org, 31376@debbugs.gnu.org, eller.helmut@gmail.com > Date: Sat, 12 May 2018 16:02:01 -0400 > > Okay, how about this: > > >From eed29c8e7164cbc13df4d7b4e3974ae90d9ecb51 Mon Sep 17 00:00:00 2001 > From: Noam Postavsky > Date: Fri, 11 May 2018 13:44:46 -0400 > Subject: [PATCH] Honor print-charset-text-property value of nil (Bug#31376) > > * src/print.c (print_check_string_charset_prop): Move check > for nil Vprint_charset_text_property from here... > (print_prune_string_charset): ... to here. > (syms_of_print) : Clarify that any > non-boolean values are treated the same as `default'. > * doc/lispref/streams.texi (Output Variables): Add > print-prune-string-charset. Could we also have a couple of tests, including the original snippet from Helmut that started this? > +@defvar print-charset-text-property > +This variable controls printing of `charset' text property on printing > +a string. The value should be @code{nil}, @code{t}, or > +@code{default}. > + > +If the value is @code{nil}, @code{charset} text properties are never > +printed. If @code{t}, they are always printed. If the value is > +@code{default}, print the text property @code{charset} only when the > +value is different from what is guessed in the current charset > +priorities. Values other than @code{nil} or @code{t} are treated the > +same as @code{default}. > +@end defvar This LGTM, but the description of 'default' IMO is too implementation-centric, which doesn't help the user in understanding what to expect from that value. How about the variant below? If the value is @code{default}, print only those @code{charset} text properties that are ``unusual'' for the respective characters under the current language environment. The @code{charset} property of a character is considered unusual if its value is different from what @code{char-charset} returns for that character. Thanks. From unknown Mon Jun 23 22:04:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31376: 26.0.50; print-charset-text-property not honored Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 May 2018 18:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31376 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: handa@gnu.org, 31376@debbugs.gnu.org, schwab@linux-m68k.org, eller.helmut@gmail.com Received: via spool by 31376-submit@debbugs.gnu.org id=B31376.15262362083186 (code B ref 31376); Sun, 13 May 2018 18:31:01 +0000 Received: (at 31376) by debbugs.gnu.org; 13 May 2018 18:30:08 +0000 Received: from localhost ([127.0.0.1]:60994 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fHvl1-0000pJ-R1 for submit@debbugs.gnu.org; Sun, 13 May 2018 14:30:08 -0400 Received: from mail-it0-f44.google.com ([209.85.214.44]:35375) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fHvl0-0000nY-76 for 31376@debbugs.gnu.org; Sun, 13 May 2018 14:30:06 -0400 Received: by mail-it0-f44.google.com with SMTP id q72-v6so8065766itc.0 for <31376@debbugs.gnu.org>; Sun, 13 May 2018 11:30:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=+34RTGj19qFYp4JshryrMjPNimy8K2F+xkbaGxCrkIc=; b=My4XRi/rRaTY305JailmMhSSVNpDUIHqcPQp+0LqLzRwsjVtOfGLSfe53lOwoqooma TRI7bu9R+Bd9jl2SdYlDJG/3u8AViSARH3AUzGDNJhF8mCnFuvfQAIxXbT24fXGgyueK mMjdiQfF7cW7w4ftd4s/jqH9EofcaZSJNaxwB1XLN4krm1u0I44eTdcxulBewQBAzD1x L6D8xpAgGNA7vcypkS8EY0f267mTIZgzJzjd63AvQl9vf02FVmmzbmjmIPsmoT5B1Uq5 KbFaWqaE9ZMRAQ7WrIDVbFzvsMIFBo70l2nifRZfreWKn948xzjBJ/w3f5nP3MfQ9LVA i2bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=+34RTGj19qFYp4JshryrMjPNimy8K2F+xkbaGxCrkIc=; b=AroyuolB6dvbX0xgCL6n4lUjeXkvw7FgLgE0W8PgrY52KDJdm1R1bTsp8hajsZ+Zdn 0W0cdekSFOdU5UNjMRMRIJweifz5g3GrjbbmNrymhi/DuwaICvcQZwf0duQqc43f1uM1 +P8ffguaPgN29PfSOiiTnQE0MEWJKDWozmbGM19Vtx6CW3haXxSmVGOIT0uckp4qf0yF jwGmwkmnFKFC6LkpGAKVF4E2qODOoB7vO6jto2wGj3msW08bQGSOt08liYPJn8iAcJMJ zjPUievF4eOuigaUAjz2y4fxPtRzxOeucu6VIeBu+GKj9wwkz6zDVsX4jZdV2E+/Oy6F 7eTg== X-Gm-Message-State: ALKqPwc6pq58aU2gNyka6T3ThOJbrNJmaUwzasZhJjrz4/7CsI5SBpB8 tHxlm/L9HA7XjMg4gIHOZto= X-Google-Smtp-Source: AB8JxZpB6QpxkNdBbKX6hbAInJ3sD/S2zPL60nnSjVEvUUOX2hb0FTorzR2Aqk/7SSUrGRdnO7TBFA== X-Received: by 2002:a24:63ca:: with SMTP id j193-v6mr6920513itc.66.1526236200654; Sun, 13 May 2018 11:30:00 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id p4-v6sm3146342itb.1.2018.05.13.11.29.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 13 May 2018 11:30:00 -0700 (PDT) From: Noam Postavsky References: <87d0y7ew2h.fsf@linux-m68k.org> <87603zmxna.fsf@gmail.com> <83mux6nws8.fsf@gnu.org> <837eoani9b.fsf@gnu.org> <871seglk1y.fsf@gmail.com> <83r2mflgkh.fsf@gnu.org> Date: Sun, 13 May 2018 14:29:58 -0400 In-Reply-To: <83r2mflgkh.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 13 May 2018 18:29:34 +0300") Message-ID: <87r2mfjtnd.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > This LGTM, but the description of 'default' IMO is too > implementation-centric, which doesn't help the user in understanding > what to expect from that value. How about the variant below? Yeah, I only understand it from the implementation myself. > If the value is @code{default}, print only those @code{charset} text > properties that are ``unusual'' for the respective characters under > the current language environment. The @code{charset} property of a > character is considered unusual if its value is different from what > @code{char-charset} returns for that character. Okay, when writing up some tests I may have found another minor bug, or at least something which contradicts the text above. Is there supposed to be an exception for ascii characters? (char-charset ?a) ;=3D> ascii (prin1-to-string (propertize (string ?a) 'charset 'chinese-cns11643-15)) ;=3D> "\"a\"" vs (char-charset ?\xf6) ;=3D> unicode (prin1-to-string (propertize (string ?\xf6) 'charset 'chinese-cns11643-15)) ;=3D> "#(\"=C3=B6\" 0 1 (charset chinese-cns11643-15))" (Nothing special about chinese-cns11643-15, by the way, it's just the first element in charset-list.) From unknown Mon Jun 23 22:04:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31376: 26.0.50; print-charset-text-property not honored Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 May 2018 18:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31376 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Noam Postavsky Cc: handa@gnu.org, 31376@debbugs.gnu.org, schwab@linux-m68k.org, eller.helmut@gmail.com Reply-To: Eli Zaretskii Received: via spool by 31376-submit@debbugs.gnu.org id=B31376.15262375025092 (code B ref 31376); Sun, 13 May 2018 18:52:02 +0000 Received: (at 31376) by debbugs.gnu.org; 13 May 2018 18:51:42 +0000 Received: from localhost ([127.0.0.1]:32769 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fHw5t-0001K4-NI for submit@debbugs.gnu.org; Sun, 13 May 2018 14:51:42 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40865) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fHw5s-0001Jn-0D for 31376@debbugs.gnu.org; Sun, 13 May 2018 14:51:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fHw5h-0003o5-VC for 31376@debbugs.gnu.org; Sun, 13 May 2018 14:51:34 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49755) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fHw5Y-0003lz-0G; Sun, 13 May 2018 14:51:20 -0400 Received: from [176.228.60.248] (port=3721 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fHw5X-0006e2-7l; Sun, 13 May 2018 14:51:19 -0400 Date: Sun, 13 May 2018 21:51:18 +0300 Message-Id: <83lgcnl789.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <87r2mfjtnd.fsf@gmail.com> (message from Noam Postavsky on Sun, 13 May 2018 14:29:58 -0400) References: <87d0y7ew2h.fsf@linux-m68k.org> <87603zmxna.fsf@gmail.com> <83mux6nws8.fsf@gnu.org> <837eoani9b.fsf@gnu.org> <871seglk1y.fsf@gmail.com> <83r2mflgkh.fsf@gnu.org> <87r2mfjtnd.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Noam Postavsky > Cc: handa@gnu.org, 31376@debbugs.gnu.org, schwab@linux-m68k.org, eller.helmut@gmail.com > Date: Sun, 13 May 2018 14:29:58 -0400 > > > If the value is @code{default}, print only those @code{charset} text > > properties that are ``unusual'' for the respective characters under > > the current language environment. The @code{charset} property of a > > character is considered unusual if its value is different from what > > @code{char-charset} returns for that character. > > Okay, when writing up some tests I may have found another minor bug, or > at least something which contradicts the text above. Is there supposed > to be an exception for ascii characters? Yes, you can see that in print_check_string_charset_prop: charset = XCAR (XCDR (val)); for (i = 0; i < LENGTH (interval); i++) { FETCH_STRING_CHAR_ADVANCE (c, string, charpos, bytepos); if (! ASCII_CHAR_P (c) <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< && ! EQ (CHARSET_NAME (CHAR_CHARSET (c)), charset)) { print_check_string_result |= PRINT_STRING_UNSAFE_CHARSET_FOUND; break; } } CHAR_CHARSET always returns 'ascii' for ASCII characters, while showing 'charset' for ASCII characters probably makes littles sense. Of course, that's only my guess, the default behavior wrt this is pure heuristics, so YMMV. We could mention this exception in the manual. From unknown Mon Jun 23 22:04:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31376: 26.0.50; print-charset-text-property not honored Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 May 2018 19:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31376 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: handa@gnu.org, 31376@debbugs.gnu.org, schwab@linux-m68k.org, eller.helmut@gmail.com Received: via spool by 31376-submit@debbugs.gnu.org id=B31376.15262405319569 (code B ref 31376); Sun, 13 May 2018 19:43:02 +0000 Received: (at 31376) by debbugs.gnu.org; 13 May 2018 19:42:11 +0000 Received: from localhost ([127.0.0.1]:32781 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fHwsl-0002UG-1s for submit@debbugs.gnu.org; Sun, 13 May 2018 15:42:11 -0400 Received: from mail-it0-f43.google.com ([209.85.214.43]:40660) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fHwsj-0002U2-Oc for 31376@debbugs.gnu.org; Sun, 13 May 2018 15:42:10 -0400 Received: by mail-it0-f43.google.com with SMTP id j186-v6so8163606ita.5 for <31376@debbugs.gnu.org>; Sun, 13 May 2018 12:42:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=/aukJtsYg42a5YbxvVWdSWzUrRcwKrqVFq1RkIk3Nbg=; b=hwOTrfATNy9FfiJtLmxaM6+mRe1JAe1g7KVmSxNgBtzxQapdHWiMhfY+LuN43Nfvmk tc+o0sDlE7ciXAU6RUvht62hSklgZb9l+6wnDRjavcDS1m/0d5BTDII8R9Yv+DxxHAiJ vBF7Q2K32ZfTqUPb9yjdU/QVmrn4pmUKzDXo43q7rV3Zm21jmjW619LGp1fnK13aWR0+ Iu5gD07XbSuzUmLKW9nxZkiU9XtfSrmnWHQX6SeSEl9C8lcWIC/79ADCAd9G3nG2PgRR tCFbpNi/hEIvDUKfFnO4l41Z0cYe6Iq79rO3FCwXOlMCXwqX4TNGGgUWBsYgUjASB4A0 pNZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=/aukJtsYg42a5YbxvVWdSWzUrRcwKrqVFq1RkIk3Nbg=; b=Gellp6OsN+TjqM++cNH/FhRL4iKtLW06XlhVY0nsimwGL2g+L+8eTO7UGyXdn4SvK8 huVr1eCqSTkCJb8mB46H4YSTaBEtKy14aKbGqJnGn9Lc5YWFFnzlKrZcb5vgGIY8Ds3A T5u2iKMHU3DrM/Zwk/vY3WzVvwo56iImvGNXsA73/ki8M0ov/72tGQKxKZ/z+BqRZLae c3iBzeh4k3OdxbaFK1Qh42cUPgs15bvzQx7xJIhx/vkQp0cV0COq+ZUrc+aeeif2y1MY 5V7wuovP+sq713vKwD84G2eI4+XOu5ZvfVoDysVYugxKTkqQ7oWpfcaLXRZh/tanMjpg j3pg== X-Gm-Message-State: ALKqPwce642Y8JcWyai187wE+XMVkHJrIw9nZ/ta1YiFeYlT8qivK4LA an3VyfdGs1Njp2kT1yCAYy4= X-Google-Smtp-Source: AB8JxZpewHKKpTyc0U1b5FfU+WtIafKiANAayCyn2bNVySPJ4mQYFLyscg2zE4hVRJ7S8mhSm/blXg== X-Received: by 2002:a24:b54d:: with SMTP id j13-v6mr6173699iti.127.1526240524229; Sun, 13 May 2018 12:42:04 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id r137-v6sm2816995ita.8.2018.05.13.12.42.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 13 May 2018 12:42:03 -0700 (PDT) From: Noam Postavsky References: <87d0y7ew2h.fsf@linux-m68k.org> <87603zmxna.fsf@gmail.com> <83mux6nws8.fsf@gnu.org> <837eoani9b.fsf@gnu.org> <871seglk1y.fsf@gmail.com> <83r2mflgkh.fsf@gnu.org> <87r2mfjtnd.fsf@gmail.com> <83lgcnl789.fsf@gnu.org> Date: Sun, 13 May 2018 15:42:02 -0400 In-Reply-To: <83lgcnl789.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 13 May 2018 21:51:18 +0300") Message-ID: <87o9hjjqb9.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Eli Zaretskii writes: > CHAR_CHARSET always returns 'ascii' for ASCII characters, while > showing 'charset' for ASCII characters probably makes littles sense. > Of course, that's only my guess, the default behavior wrt this is pure > heuristics, so YMMV. > > We could mention this exception in the manual. Yeah, I think we should. Here's a new patch with updated manual and tests. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=v2-0001-Honor-print-charset-text-property-value-of-nil-Bu.patch Content-Description: patch >From b2ff6ca64fbde643867f4ddada1d8939c7e1ba1f Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Fri, 11 May 2018 13:44:46 -0400 Subject: [PATCH v2] Honor print-charset-text-property value of nil (Bug#31376) * src/print.c (print_check_string_charset_prop): Move check for nil Vprint_charset_text_property from here... (print_prune_string_charset): ... to here. (syms_of_print) : Clarify that any non-boolean values are treated the same as `default'. * doc/lispref/streams.texi (Output Variables): Add print-prune-string-charset. * test/src/print-tests.el (print-charset-text-property-nil) (print-charset-text-property-default) (print-charset-text-property-t): New tests. (print-tests--prints-with-charset-p): New helper function. --- doc/lispref/streams.texi | 15 +++++++++++++++ src/print.c | 11 ++++++----- test/src/print-tests.el | 38 ++++++++++++++++++++++++++++++++++++++ 3 files changed, 59 insertions(+), 5 deletions(-) diff --git a/doc/lispref/streams.texi b/doc/lispref/streams.texi index ebd806601e..032669cb10 100644 --- a/doc/lispref/streams.texi +++ b/doc/lispref/streams.texi @@ -809,6 +809,21 @@ Output Variables one. @end defvar +@defvar print-charset-text-property +This variable controls printing of `charset' text property on printing +a string. The value should be @code{nil}, @code{t}, or +@code{default}. + +If the value is @code{nil}, @code{charset} text properties are never +printed. If @code{t}, they are always printed. + +If the value is @code{default}, only print @code{charset} text +properties if there is an ``unexpected'' @code{charset} property. For +ascii characters, all charsets are considered ``expected''. +Otherwise, the expected @code{charset} property of a character is +given by @code{char-charset}. +@end defvar + @defvar print-length @cindex printing limits The value of this variable is the maximum number of elements to print in diff --git a/src/print.c b/src/print.c index 15177759cf..427ab7d158 100644 --- a/src/print.c +++ b/src/print.c @@ -1317,8 +1317,7 @@ print_check_string_charset_prop (INTERVAL interval, Lisp_Object string) || CONSP (XCDR (XCDR (val)))) print_check_string_result |= PRINT_STRING_NON_CHARSET_FOUND; } - if (NILP (Vprint_charset_text_property) - || ! (print_check_string_result & PRINT_STRING_UNSAFE_CHARSET_FOUND)) + if (! (print_check_string_result & PRINT_STRING_UNSAFE_CHARSET_FOUND)) { int i, c; ptrdiff_t charpos = interval->position; @@ -1348,7 +1347,8 @@ print_prune_string_charset (Lisp_Object string) print_check_string_result = 0; traverse_intervals (string_intervals (string), 0, print_check_string_charset_prop, string); - if (! (print_check_string_result & PRINT_STRING_UNSAFE_CHARSET_FOUND)) + if (NILP (Vprint_charset_text_property) + || ! (print_check_string_result & PRINT_STRING_UNSAFE_CHARSET_FOUND)) { string = Fcopy_sequence (string); if (print_check_string_result & PRINT_STRING_NON_CHARSET_FOUND) @@ -2422,7 +2422,7 @@ representation) and `#N#' in place of each subsequent occurrence, DEFVAR_LISP ("print-charset-text-property", Vprint_charset_text_property, doc: /* A flag to control printing of `charset' text property on printing a string. -The value must be nil, t, or `default'. +The value should be nil, t, or `default'. If the value is nil, don't print the text property `charset'. @@ -2430,7 +2430,8 @@ representation) and `#N#' in place of each subsequent occurrence, If the value is `default', print the text property `charset' only when the value is different from what is guessed in the current charset -priorities. */); +priorities. Values other than nil or t are also treated as +`default'. */); Vprint_charset_text_property = Qdefault; /* prin1_to_string_buffer initialized in init_buffer_once in buffer.c */ diff --git a/test/src/print-tests.el b/test/src/print-tests.el index 01e65028bc..a1825b79d0 100644 --- a/test/src/print-tests.el +++ b/test/src/print-tests.el @@ -27,6 +27,44 @@ (prin1-to-string "\u00A2\ff")) "\"\\x00a2\\ff\""))) +(defun print-tests--prints-with-charset-p (ch odd-charset) + "Return t if `prin1-to-string' prints CH with the `charset' property. +CH is propertized with a `charset' value according to +ODD-CHARSET: if nil, then use the one returned by `char-charset', +otherwise, use a different charset." + (integerp + (string-match + "charset" + (prin1-to-string + (propertize (string ch) + 'charset + (if odd-charset + (car (if (eq (char-charset ch) (car charset-list)) + charset-list + (cdr charset-list))) + (char-charset ch))))))) + +(ert-deftest print-charset-text-property-nil () + (let ((print-charset-text-property nil)) + (should-not (print-tests--prints-with-charset-p ?\xf6 t)) ; Bug#31376. + (should-not (print-tests--prints-with-charset-p ?a t)) + (should-not (print-tests--prints-with-charset-p ?\xf6 nil)) + (should-not (print-tests--prints-with-charset-p ?a nil)))) + +(ert-deftest print-charset-text-property-default () + (let ((print-charset-text-property 'default)) + (should (print-tests--prints-with-charset-p ?\xf6 t)) + (should-not (print-tests--prints-with-charset-p ?a t)) + (should-not (print-tests--prints-with-charset-p ?\xf6 nil)) + (should-not (print-tests--prints-with-charset-p ?a nil)))) + +(ert-deftest print-charset-text-property-t () + (let ((print-charset-text-property t)) + (should (print-tests--prints-with-charset-p ?\xf6 t)) + (should (print-tests--prints-with-charset-p ?a t)) + (should (print-tests--prints-with-charset-p ?\xf6 nil)) + (should (print-tests--prints-with-charset-p ?a nil)))) + (ert-deftest terpri () (should (string= (with-output-to-string (princ 'abc) -- 2.11.0 --=-=-=-- From unknown Mon Jun 23 22:04:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31376: 26.0.50; print-charset-text-property not honored Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 14 May 2018 16:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31376 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Noam Postavsky Cc: handa@gnu.org, 31376@debbugs.gnu.org, schwab@linux-m68k.org, eller.helmut@gmail.com Reply-To: Eli Zaretskii Received: via spool by 31376-submit@debbugs.gnu.org id=B31376.152631570332184 (code B ref 31376); Mon, 14 May 2018 16:36:01 +0000 Received: (at 31376) by debbugs.gnu.org; 14 May 2018 16:35:03 +0000 Received: from localhost ([127.0.0.1]:34608 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fIGRD-0008N2-KQ for submit@debbugs.gnu.org; Mon, 14 May 2018 12:35:03 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37681) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fIGRB-0008M4-HZ for 31376@debbugs.gnu.org; Mon, 14 May 2018 12:35:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fIGR5-0002AJ-MB for 31376@debbugs.gnu.org; Mon, 14 May 2018 12:34:56 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42203) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fIGQx-00026b-N4; Mon, 14 May 2018 12:34:47 -0400 Received: from [176.228.60.248] (port=4871 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fIGQx-0000lJ-4X; Mon, 14 May 2018 12:34:47 -0400 Date: Mon, 14 May 2018 19:34:52 +0300 Message-Id: <837eo6kxg3.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <87o9hjjqb9.fsf@gmail.com> (message from Noam Postavsky on Sun, 13 May 2018 15:42:02 -0400) References: <87d0y7ew2h.fsf@linux-m68k.org> <87603zmxna.fsf@gmail.com> <83mux6nws8.fsf@gnu.org> <837eoani9b.fsf@gnu.org> <871seglk1y.fsf@gmail.com> <83r2mflgkh.fsf@gnu.org> <87r2mfjtnd.fsf@gmail.com> <83lgcnl789.fsf@gnu.org> <87o9hjjqb9.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Noam Postavsky > Cc: handa@gnu.org, 31376@debbugs.gnu.org, schwab@linux-m68k.org, eller.helmut@gmail.com > Date: Sun, 13 May 2018 15:42:02 -0400 > > > We could mention this exception in the manual. > > Yeah, I think we should. Here's a new patch with updated manual and > tests. Thanks. One minor comment about the tests: > +(defun print-tests--prints-with-charset-p (ch odd-charset) > + "Return t if `prin1-to-string' prints CH with the `charset' property. > +CH is propertized with a `charset' value according to > +ODD-CHARSET: if nil, then use the one returned by `char-charset', > +otherwise, use a different charset." > + (integerp > + (string-match > + "charset" > + (prin1-to-string > + (propertize (string ch) > + 'charset > + (if odd-charset > + (car (if (eq (char-charset ch) (car charset-list)) > + charset-list > + (cdr charset-list))) > + (char-charset ch))))))) This seems to rely on some relationship between what char-charset returns and the car of charset-list, is that right? AFAIK, when ODD-CHARSET is non-nil, you want to propertize with a charset that is _different_ from what char-charset returns, but taking the first or the second member of charset-list doesn't guarantee that. It could work with the particular characters you used for the tests, but if this function is limited to such characters, we should document that in the doc string or comments, lest someone will try to expand the tests and will see strange failures. Thanks, I have no other comments. From unknown Mon Jun 23 22:04:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31376: 26.0.50; print-charset-text-property not honored Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 14 May 2018 23:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31376 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: handa@gnu.org, 31376@debbugs.gnu.org, schwab@linux-m68k.org, eller.helmut@gmail.com Received: via spool by 31376-submit@debbugs.gnu.org id=B31376.15263397402685 (code B ref 31376); Mon, 14 May 2018 23:16:01 +0000 Received: (at 31376) by debbugs.gnu.org; 14 May 2018 23:15:40 +0000 Received: from localhost ([127.0.0.1]:34751 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fIMgu-0000hE-Kg for submit@debbugs.gnu.org; Mon, 14 May 2018 19:15:40 -0400 Received: from mail-it0-f41.google.com ([209.85.214.41]:54462) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fIMgt-0000h2-4p for 31376@debbugs.gnu.org; Mon, 14 May 2018 19:15:39 -0400 Received: by mail-it0-f41.google.com with SMTP id z6-v6so14581202iti.4 for <31376@debbugs.gnu.org>; Mon, 14 May 2018 16:15:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=QtFy6gxMgK8lLRgrN2V1zaDX7vTWwkGnaipm4hACOS0=; b=Rtq0fiTjcDP/0FcZHFffYP4hnyldhdcCh+HJY9sA3Q8A3fX9uNVAzaiqJhuq+5zytN vJoVrdeLPwFuhNCO0x9IOa030SfCevEgq6sVKqs+Iq7q38pwru0/pnvnSrT9mbGJi6XZ 586XrYB4WEeNNehsKgHmm0vHUDfmg/3dNeKfQ+RMmMnN2hlFlmIGL0Ga2H5Zuk/nRqP9 EB6KvCA5dnm9iR8ZfRizjL4HoVu0vztLE0ZwDbgbV4AKMvhuABDAFS7mVkJoMAAeKLMW ucB1Lqs401tuVIQ8vfM8c7hzj3IX5KuijXW2Z+03VawrepDhsyX+TWKafTlmwedrx8Az 279g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=QtFy6gxMgK8lLRgrN2V1zaDX7vTWwkGnaipm4hACOS0=; b=pHvIV/saYx79Y6BLIoiDvncQmpP2MAoEtqjPUs9RNC/2NWxv6mZbKZUjZrzHW8q6vJ f3B2dFfstGkyZH2CP/jlfoCmXbGkG8bIEP/dXOrqKA+USeHeYMRUmCUFzlixt1761k2W dseiAZjyb/DX4MU7M1pH9dMmWkrZwPKvS5MPW3AwA3Ym2xPFPN40GxYO4B/13mtxUktZ xSVWD7prWhfEP127zVRznL1VMQgEOmqKCn0OF/ZSv4EjB1owCCpM//UNdl0tOJxtXG6W l8ojMrEF//02hlCWaqkO1LAXII71gpr1qdpwp2MfljZGneUchTLae+LFzLV3Ph+uOl0X K5rQ== X-Gm-Message-State: ALKqPweZCFb5kdq4PCoNS9AVzKDAp6+uCiPGTc7ZVelIleXijzy33iNr qb25mfOIiRkLDzjRpki2JWY= X-Google-Smtp-Source: AB8JxZo5Uu/BwUsU4iOxApvB7k0sThjqSPlLyP5cidGWxpbsHXrwnIq7zEWNwJoo1fCPEYPx/nQeZQ== X-Received: by 2002:a24:e56:: with SMTP id 83-v6mr11355700ite.16.1526339733658; Mon, 14 May 2018 16:15:33 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id o130-v6sm5003013ith.24.2018.05.14.16.15.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 14 May 2018 16:15:32 -0700 (PDT) From: Noam Postavsky References: <87d0y7ew2h.fsf@linux-m68k.org> <87603zmxna.fsf@gmail.com> <83mux6nws8.fsf@gnu.org> <837eoani9b.fsf@gnu.org> <871seglk1y.fsf@gmail.com> <83r2mflgkh.fsf@gnu.org> <87r2mfjtnd.fsf@gmail.com> <83lgcnl789.fsf@gnu.org> <87o9hjjqb9.fsf@gmail.com> <837eo6kxg3.fsf@gnu.org> Date: Mon, 14 May 2018 19:15:30 -0400 In-Reply-To: <837eo6kxg3.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 14 May 2018 19:34:52 +0300") Message-ID: <87lgclkewd.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > This seems to rely on some relationship between what char-charset > returns and the car of charset-list, is that right? The idea is to take the first if it's not eq to what char-charset returns, or the second otherwise (on the assumption that it's different from the first). Perhaps clearer if I use cl-find: (defun print-tests--prints-with-charset-p (ch odd-charset) "Return t if `prin1-to-string' prints CH with the `charset' property. CH is propertized with a `charset' value according to ODD-CHARSET: if nil, then use the one returned by `char-charset', otherwise, use a different charset." (integerp (string-match "charset" (prin1-to-string (propertize (string ch) 'charset (if odd-charset (cl-find (char-charset ch) charset-list :test-not #'eq) (char-charset ch))))))) From unknown Mon Jun 23 22:04:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31376: 26.0.50; print-charset-text-property not honored Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 May 2018 17:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31376 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Noam Postavsky Cc: handa@gnu.org, 31376@debbugs.gnu.org, schwab@linux-m68k.org, eller.helmut@gmail.com Reply-To: Eli Zaretskii Received: via spool by 31376-submit@debbugs.gnu.org id=B31376.152640479727762 (code B ref 31376); Tue, 15 May 2018 17:20:02 +0000 Received: (at 31376) by debbugs.gnu.org; 15 May 2018 17:19:57 +0000 Received: from localhost ([127.0.0.1]:35942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fIdcC-0007Di-JC for submit@debbugs.gnu.org; Tue, 15 May 2018 13:19:56 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52628) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fIdcA-0007DV-Ft for 31376@debbugs.gnu.org; Tue, 15 May 2018 13:19:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fIdc0-0001Vv-5H for 31376@debbugs.gnu.org; Tue, 15 May 2018 13:19:49 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37356) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fIdbp-0001GO-De; Tue, 15 May 2018 13:19:33 -0400 Received: from [176.228.60.248] (port=2481 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fIdbo-0004V8-TG; Tue, 15 May 2018 13:19:33 -0400 Date: Tue, 15 May 2018 20:19:40 +0300 Message-Id: <83vabokf9v.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <87lgclkewd.fsf@gmail.com> (message from Noam Postavsky on Mon, 14 May 2018 19:15:30 -0400) References: <87d0y7ew2h.fsf@linux-m68k.org> <87603zmxna.fsf@gmail.com> <83mux6nws8.fsf@gnu.org> <837eoani9b.fsf@gnu.org> <871seglk1y.fsf@gmail.com> <83r2mflgkh.fsf@gnu.org> <87r2mfjtnd.fsf@gmail.com> <83lgcnl789.fsf@gnu.org> <87o9hjjqb9.fsf@gmail.com> <837eo6kxg3.fsf@gnu.org> <87lgclkewd.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Noam Postavsky > Cc: handa@gnu.org, 31376@debbugs.gnu.org, schwab@linux-m68k.org, eller.helmut@gmail.com > Date: Mon, 14 May 2018 19:15:30 -0400 > > Eli Zaretskii writes: > > > This seems to rely on some relationship between what char-charset > > returns and the car of charset-list, is that right? > > The idea is to take the first if it's not eq to what char-charset > returns, or the second otherwise (on the assumption that it's different > from the first). Perhaps clearer if I use cl-find: > > (defun print-tests--prints-with-charset-p (ch odd-charset) > "Return t if `prin1-to-string' prints CH with the `charset' property. > CH is propertized with a `charset' value according to > ODD-CHARSET: if nil, then use the one returned by `char-charset', > otherwise, use a different charset." > (integerp > (string-match > "charset" > (prin1-to-string > (propertize (string ch) > 'charset > (if odd-charset > (cl-find (char-charset ch) charset-list :test-not #'eq) > (char-charset ch))))))) Maybe I'm missing something, but the negation of the test seemed to be missing from the original code. But it was a hard day, so maybe my mind is foggy... Thanks. From unknown Mon Jun 23 22:04:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31376: 26.0.50; print-charset-text-property not honored Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 May 2018 23:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31376 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: handa@gnu.org, 31376@debbugs.gnu.org, schwab@linux-m68k.org, eller.helmut@gmail.com Received: via spool by 31376-submit@debbugs.gnu.org id=B31376.152642746028916 (code B ref 31376); Tue, 15 May 2018 23:38:01 +0000 Received: (at 31376) by debbugs.gnu.org; 15 May 2018 23:37:40 +0000 Received: from localhost ([127.0.0.1]:36105 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fIjVk-0007WK-B7 for submit@debbugs.gnu.org; Tue, 15 May 2018 19:37:40 -0400 Received: from mail-it0-f47.google.com ([209.85.214.47]:50887) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fIjVi-0007W8-FR for 31376@debbugs.gnu.org; Tue, 15 May 2018 19:37:39 -0400 Received: by mail-it0-f47.google.com with SMTP id p3-v6so6031530itc.0 for <31376@debbugs.gnu.org>; Tue, 15 May 2018 16:37:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=4Smgm7BBCaRMPSkzIw8D4v0gzksUUimvnHWliOuDldo=; b=cqCEvnVIHs2AIk1vonZ6/IC7oDHBIjf4dwlkTjWpDd4gvO2EgrrSisT9+DdWdI0v4R c7N8GTh1UkJgp4nQObsDt9+wxZgHWVJpwQn2Xuza/BHUt6HSqy1ZcxMUm4b/sIwLKz1F feqUYzKTvCUYAwUAmnQJ877d+LsGEOz8Az149aMr+SYfRx4790/eGP/KrUcgrjFkE1H+ DaZQY1WmrVIRRBz+dDaYAAg7NnCPl1xhDGvH7EwAeDFnF3MlXj6yQFyUKHIjvar9ALG2 mYOZ9/SCqCpo3V+ZW6bzWHky+V+UaVeU1qjho2/aebNrXyrByDewAGduE6P2QNH909e2 XCPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=4Smgm7BBCaRMPSkzIw8D4v0gzksUUimvnHWliOuDldo=; b=LNLgAkVsc+xeMhJD2QBEBgRL1ZK/PEpPqcv8z/85+qFDqABVJ+v9idUAb9MSYb9K0p n/HDClx7TOxARww+09BoV/SYJ9JbQ8XPflHOea2HEdkNg6XS5ja1K8jj+YWNPqIdM5rJ qRGVyQfi0l+tLi6i8cInYlkv2JkNvQq1+oTudqfKpDOte/2fujTPzu8BI7H2Wghr7sWn 7wyyU1bu0qrAP52utor7beb6pmeLH2pp1qdYLDL3YhUoUEXQTE3vv1sATAYnEgzFoYFM vHzOqt/mkP2fHiE1QnwyPTJGZJp0lipr9UGlPA89jTMMrrdBwdAxpICDfNZ5OSX/Hv8g VGqA== X-Gm-Message-State: ALKqPwcJUh3langfjC6jLvRPSt3Zpn4YrTZN7iy1ZXMXZzDeWbCRXSi4 FiW5MLlyD3dBTT46Pr1Qaro= X-Google-Smtp-Source: AB8JxZpq34G5z4uriKtlHtxjJq21REvQ52hJLDWTQVbXnmeikDHXpfOe5TnHBGpGXeWG534u/12CPQ== X-Received: by 2002:a24:2b12:: with SMTP id h18-v6mr30221ita.141.1526427452668; Tue, 15 May 2018 16:37:32 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id d8-v6sm614259ioh.20.2018.05.15.16.37.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 15 May 2018 16:37:30 -0700 (PDT) From: Noam Postavsky References: <87d0y7ew2h.fsf@linux-m68k.org> <87603zmxna.fsf@gmail.com> <83mux6nws8.fsf@gnu.org> <837eoani9b.fsf@gnu.org> <871seglk1y.fsf@gmail.com> <83r2mflgkh.fsf@gnu.org> <87r2mfjtnd.fsf@gmail.com> <83lgcnl789.fsf@gnu.org> <87o9hjjqb9.fsf@gmail.com> <837eo6kxg3.fsf@gnu.org> <87lgclkewd.fsf@gmail.com> <83vabokf9v.fsf@gnu.org> Date: Tue, 15 May 2018 19:37:29 -0400 In-Reply-To: <83vabokf9v.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 15 May 2018 20:19:40 +0300") Message-ID: <87d0xwjxs6.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> The idea is to take the first if it's not eq to what char-charset >> returns, or the second otherwise (on the assumption that it's different >> from the first). Perhaps clearer if I use cl-find: >> > Maybe I'm missing something, but the negation of the test seemed to be > missing from the original code. But it was a hard day, so maybe my > mind is foggy... Oh, you're right, it was missing. I didn't notice because both the first two elements of charset-list were different from (char-charset ?\0xf6) which let the test pass regardless. From unknown Mon Jun 23 22:04:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31376: 26.0.50; print-charset-text-property not honored Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 May 2018 23:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31376 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: handa@gnu.org, 31376@debbugs.gnu.org, schwab@linux-m68k.org, eller.helmut@gmail.com Received: via spool by 31376-submit@debbugs.gnu.org id=B31376.152711715728445 (code B ref 31376); Wed, 23 May 2018 23:13:02 +0000 Received: (at 31376) by debbugs.gnu.org; 23 May 2018 23:12:37 +0000 Received: from localhost ([127.0.0.1]:45756 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fLcvs-0007Oe-W8 for submit@debbugs.gnu.org; Wed, 23 May 2018 19:12:37 -0400 Received: from mail-io0-f176.google.com ([209.85.223.176]:43129) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fLcvq-0007OM-Mx; Wed, 23 May 2018 19:12:35 -0400 Received: by mail-io0-f176.google.com with SMTP id t23-v6so44063ioc.10; Wed, 23 May 2018 16:12:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=k/onCTy+EJ/9xqh7s65pl6oSVp1xOh4DJa0O9nPsbyY=; b=SzC+uBSYj9Fu9crgW+UOutLBrMmvjIP2/xQb6cWz9n9JQB9fKCIOJ5h18lkWtQMasv Tx247hGIyfvVhTEYbOazEkIArvrfMBXwbotXQt51E32MoCdjGgVEefqa6tcYoqmDyXcc V5RE6kbiAD2yt75HhSogeobhlnE2yQKgkFbL8ma/1tnJsszvzgAGPe0gUf9JEBpk1o9X 5CFWCFtQkXtpXzN6gJdWazewrEh8GYzOom45SYD+GLj7uQsJq18FImvLUKh7zlMHkX/u LEzCIMKeqWZc0896KsnPEvs4h1FYv7F0iq88sL8+hK6FDxXr6LVLLDgITunwdYovW8E4 fB/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=k/onCTy+EJ/9xqh7s65pl6oSVp1xOh4DJa0O9nPsbyY=; b=GKRsSy61i3qsBQ6Wvypul97KQvNRE4Run9pa985KhizlfPu8Z1bqZhFLkGP1RGchKC Y7CdtjrFQUIsrr6yIAgRnujgDj+ihVmqTBHZPt1hWsmXTWjifWdaKO+TInWe+BSFNxjm OVm5oOwzi0a2s5CP882yxQMVrE2c+1cfUBs5jaNi0zNp5RUE6ZXfF56Q1B5LcZvrCtQq 2C4RqtByhXWzk3uWGi6CxRuCz5fo7nTAUPiAMDE9qSANOp2u3horrdO2g1Iu4hBGBo41 DYhfbkROWvZN/wgvd7ZZNGDh9LI2n+u6y7vO/wHVSA8rbaP9K4kK/H9p8ZMM79NriABt 6zyg== X-Gm-Message-State: ALKqPwf8EEZY5f/Z5DI7Sjp/dI7hkXiRRe6B647Mj8XVf7BoN21d685a bLhJ5pR0uvEX4EdcQnkDAmKjKMfs X-Google-Smtp-Source: AB8JxZoOmU6T6MvXPvjMZUMgyJWJdl9XE1qdxr0cFfWgywVAuqd+1impQJ0uau1OFO0DGIpNUZtkUg== X-Received: by 2002:a6b:dc12:: with SMTP id s18-v6mr4787565ioc.203.1527117149275; Wed, 23 May 2018 16:12:29 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id w12-v6sm11315414iog.53.2018.05.23.16.12.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 23 May 2018 16:12:28 -0700 (PDT) From: Noam Postavsky References: <87d0y7ew2h.fsf@linux-m68k.org> <87603zmxna.fsf@gmail.com> <83mux6nws8.fsf@gnu.org> <837eoani9b.fsf@gnu.org> <871seglk1y.fsf@gmail.com> <83r2mflgkh.fsf@gnu.org> <87r2mfjtnd.fsf@gmail.com> <83lgcnl789.fsf@gnu.org> <87o9hjjqb9.fsf@gmail.com> <837eo6kxg3.fsf@gnu.org> <87lgclkewd.fsf@gmail.com> <83vabokf9v.fsf@gnu.org> <87d0xwjxs6.fsf@gmail.com> Date: Wed, 23 May 2018 19:12:27 -0400 In-Reply-To: <87d0xwjxs6.fsf@gmail.com> (Noam Postavsky's message of "Tue, 15 May 2018 19:37:29 -0400") Message-ID: <87bmd6ge5g.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.8 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) tags 31376 fixed close 31376 27.1 quit Noam Postavsky writes: > Eli Zaretskii writes: > >>> The idea is to take the first if it's not eq to what char-charset >>> returns, or the second otherwise (on the assumption that it's different >>> from the first). Perhaps clearer if I use cl-find: >>> >> Maybe I'm missing something, but the negation of the test seemed to be >> missing from the original code. But it was a hard day, so maybe my >> mind is foggy... > > Oh, you're right, it was missing. I didn't notice because both the > first two elements of charset-list were different from (char-charset > ?\0xf6) which let the test pass regardless. Pushed the one with cl-find to master. [1: 6f037f427a]: 2018-05-23 07:53:58 -0400 Honor print-charset-text-property value of nil (Bug#31376) https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=6f037f427a25160168e842bff0d12b816d69067d