From unknown Sat Sep 06 20:03:32 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#31357 <31357@debbugs.gnu.org> To: bug#31357 <31357@debbugs.gnu.org> Subject: Status: 26.1; tramp-make-tramp-file-name: incompatible lisp changes in 26.1 ? Reply-To: bug#31357 <31357@debbugs.gnu.org> Date: Sun, 07 Sep 2025 03:03:32 +0000 retitle 31357 26.1; tramp-make-tramp-file-name: incompatible lisp changes i= n 26.1 ? reassign 31357 emacs submitter 31357 Phil Sainty severity 31357 minor tag 31357 notabug thanks From debbugs-submit-bounces@debbugs.gnu.org Thu May 03 10:24:14 2018 Received: (at submit) by debbugs.gnu.org; 3 May 2018 14:24:14 +0000 Received: from localhost ([127.0.0.1]:48343 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fEF9Z-0001j2-Vm for submit@debbugs.gnu.org; Thu, 03 May 2018 10:24:14 -0400 Received: from eggs.gnu.org ([208.118.235.92]:58758) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fEF9Y-0001ip-F3 for submit@debbugs.gnu.org; Thu, 03 May 2018 10:24:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fEF9S-0001Yl-13 for submit@debbugs.gnu.org; Thu, 03 May 2018 10:24:07 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:42092) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fEF9R-0001YZ-Tm for submit@debbugs.gnu.org; Thu, 03 May 2018 10:24:05 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49716) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fEF9Q-0003VR-GX for bug-gnu-emacs@gnu.org; Thu, 03 May 2018 10:24:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fEF9J-0001VV-W3 for bug-gnu-emacs@gnu.org; Thu, 03 May 2018 10:24:04 -0400 Received: from smtp-4.orcon.net.nz ([60.234.4.59]:33341) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fEF9J-0001Uc-L3 for bug-gnu-emacs@gnu.org; Thu, 03 May 2018 10:23:57 -0400 Received: from [10.253.37.70] (port=50887 helo=webmail.orcon.net.nz) by smtp-4.orcon.net.nz with esmtpa (Exim 4.86_2) (envelope-from ) id 1fEF97-00030I-Mf for bug-gnu-emacs@gnu.org; Fri, 04 May 2018 02:23:55 +1200 Received: from [150.107.175.243] via [10.253.37.253] by webmail.orcon.net.nz with HTTP (HTTP/1.1 POST); Fri, 04 May 2018 02:23:45 +1200 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 04 May 2018 02:23:45 +1200 From: Phil Sainty To: bug-gnu-emacs@gnu.org Subject: 26.1; tramp-make-tramp-file-name: incompatible lisp changes in 26.1 =?UTF-8?Q?=3F?= Message-ID: <0a062d8f1fea73fcead8cafe8f225378@webmail.orcon.net.nz> X-Sender: psainty@orcon.net.nz User-Agent: Orcon Webmail X-GeoIP: -- X-Spam_score: -2.9 X-Spam_score_int: -28 X-Spam_bar: -- X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.3 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.3 (-----) In Emacs 25 `tramp-make-tramp-file-name' takes 4-5 arguments: (method user host localname &optional hop) In Emacs 26.1 it takes 6-7 (method user domain host port localname &optional hop) That can then trigger a "wrong-number-of-arguments" error. This should surely be covered in NEWS under the "Incompatible Lisp Changes in Emacs 26.1" section? I rather suspect there were also many other functions affected by these changes, but I've not attempted to audit that. I have custom code where I am presently using the following construct to deal with this. (if (version< emacs-version "26") (tramp-make-tramp-file-name method user host localname hop) (tramp-make-tramp-file-name method user domain host port localname hop)) (With a consequential complaint from the 26.1 byte-compiler about the first of those two calls.) Is there a single approach which is backwards-compatible (at least with Emacs 25) ? For my specific use-case, what I really wanted was a way to modify only a specific named component of a tramp file name, but I ended up using `tramp-dissect-file-name', extracting the components with the various `tramp-file-name-COMPONENT' functions, and using `tramp-make-file-name' to put it all back together. I thought there might be a simpler way to do this, but I didn't see one. -Phil In GNU Emacs 26.1 (build 1, x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll bars) of 2018-04-15 built on shodan Windowing system distributor 'The X.Org Foundation', version 11.0.11804000 System Description: Ubuntu 16.04.4 LTS Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Mark activated Configured using: 'configure --prefix=/home/phil/emacs/26.1rc1/usr/local --with-x-toolkit=lucid --without-sound' Configured features: XAW3D XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK DBUS GSETTINGS NOTIFY GNUTLS LIBXML2 FREETYPE XFT ZLIB TOOLKIT_SCROLL_BARS LUCID X11 THREADS LCMS2 Important settings: value of $LANG: en_NZ.UTF-8 locale-coding-system: utf-8 Major mode: Dired by name Minor modes in effect: show-paren-mode: t minibuffer-depth-indicate-mode: t winner-mode: t global-hl-line-mode: t tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib format-spec rfc822 mml mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils dired-x easymenu paren mb-depth winner ring hl-line dired dired-loaddefs advice elec-pair time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 100308 9804) (symbols 48 20761 2) (miscs 40 101 271) (strings 32 30242 1161) (string-bytes 1 789994) (vectors 16 14561) (vector-slots 8 496928 9732) (floats 8 58 59) (intervals 56 269 7) (buffers 992 13) (heap 1024 44332 1473)) From debbugs-submit-bounces@debbugs.gnu.org Thu May 03 11:26:28 2018 Received: (at 31357) by debbugs.gnu.org; 3 May 2018 15:26:28 +0000 Received: from localhost ([127.0.0.1]:48380 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fEG7o-0003A9-9s for submit@debbugs.gnu.org; Thu, 03 May 2018 11:26:28 -0400 Received: from mout.gmx.net ([212.227.15.18]:51019) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fEG7m-00039x-Q9 for 31357@debbugs.gnu.org; Thu, 03 May 2018 11:26:27 -0400 Received: from detlef.gmx.de ([212.86.52.157]) by mail.gmx.com (mrgmx003 [212.227.17.190]) with ESMTPSA (Nemesis) id 0McEI3-1ex0WB3ppv-00JcfE; Thu, 03 May 2018 17:26:13 +0200 From: Michael Albinus To: Phil Sainty Subject: Re: bug#31357: 26.1; tramp-make-tramp-file-name: incompatible lisp changes in 26.1 ? References: <0a062d8f1fea73fcead8cafe8f225378@webmail.orcon.net.nz> Date: Thu, 03 May 2018 17:26:11 +0200 Message-ID: <87k1sksquk.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:PNxCu5kQi8ByYFa4Q+CRL6edRaBT/UaUh6daRx8LkpFo2Qk7xDe KTJEwm/rn9VZ+DCA4m4vFoWd5SRpFePpezS9YgOV18DdjOJe8Lj4+fzYp/coOtDoG86AyOs TyrRi6x/Js+/hIAO4Qjwrqw86CSl8+CeN2sQ/xkSzSfT+C7UV0l4NF74gkTdkDPPw75JedO eeqj6aTNwjBJXn/Dx92Qg== X-UI-Out-Filterresults: notjunk:1;V01:K0:yqAQtQ7b6F4=:qFDUEhyz75/8Qyv6zPU/PG bsAYOeR6+VpkIPIVoquMXe7Ewv3NgHAwNaZAwAzLODULQbrxMMfYQcEJjgxxG9lrbv/Y9151O f/eGLe5sTAm5VSt14XeXMfNqTUw52GkGkZ9MpQmpmn1Go125wtXKO+B+ReLyk6nhDcxKqVGh1 agIOm8MIPlK1LhN1GDzSKv7swCHpRMeF0fzmI5ocjcTsURn3NnBwsJUVh6dX9NRxml6PI/lr3 TctnVKn5KURPYxT+ce6t7hckIf2HNBgJYkgEh8W5gdvC2/1+4bh5fB3x2L8hFLf9DAw26wAJp U6yII4m6SmOtQ9Rt4cMKLJhY9OeCBGFPLEwgn0VvDwsiHZ63V41M+t+uI6KQHnbVQkSERzwo3 577LGRyYYX2nZ/xIbr1R6JFhn9UFQ5cCAXgBXzgQITKxJeB9N5UfYxP4Pn0epBNRnd2J+SsrH eYHcSjVGzV0Kb9A+5e5Qq6ZTRGEcJYbmaAbKtlClHElnKois+rAHUMGLSoXAQLelUfZvbcQUi LHj3TeF/grTkXP3aboQGeGPvrCMLjY8GIwHer0tBztw27EcInOO05Wv6qIVk5V722CiwoS/cW QLY2qcnourWWXqDF3izZa/nxQ4LGhe5ObBSP+JCWuJhZm36VH+gSEjGIpPGi1w2XjXcA140Gl YvMn7juS7e/aCmt84DytEyYAlttEqCoTLUi2qnnRCK2eivs8vXVU/f8wMeAKSUw5RNFVXGP2d jRNZzO5F5ITzFB+hqGeYDWPp5Y6wNsqmqLSb8+olZ6EcDSFPGbq0LWIMh1j+ukV2vS+oojAaq VvN9W0b X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 31357 Cc: 31357@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Phil Sainty writes: Hi Phil, > In Emacs 25 `tramp-make-tramp-file-name' takes 4-5 arguments: > (method user host localname &optional hop) > > In Emacs 26.1 it takes 6-7 > (method user domain host port localname &optional hop) > > That can then trigger a "wrong-number-of-arguments" error. > > This should surely be covered in NEWS under the "Incompatible Lisp > Changes in Emacs 26.1" section? `tramp-make-tramp-file-name' has never been documented as public function, it is intended for internal use. Granted, this should have been signalled better. > I have custom code where I am presently using the following construct > to deal with this. > > (if (version< emacs-version "26") > (tramp-make-tramp-file-name > method user host localname hop) > (tramp-make-tramp-file-name > method user domain host port localname hop)) > > (With a consequential complaint from the 26.1 byte-compiler about > the first of those two calls.) That's the way to go. You could use (funcall 'tramp-make-tramp-file-name ...) in order to make the byte compiler quiet. However, I wouldn't check for emacs-version. Tramp exist as separate package, and the recent Tramp 2.4 runs with all Emacs 24, 25, 26 and 27. You might check for tramp-version. > Is there a single approach which is backwards-compatible (at least with > Emacs 25) ? No. > For my specific use-case, what I really wanted was a way to modify only > a specific named component of a tramp file name, but I ended up using > `tramp-dissect-file-name', extracting the components with the various > `tramp-file-name-COMPONENT' functions, and using `tramp-make-file-name' > to put it all back together. I thought there might be a simpler way to > do this, but I didn't see one. Well, with Emacs 27 (Tramp 2.4) the function's signature has changed, again. It is now (&rest ARGS). This is backwards compatible to Tramp 2.3 / Emacs 26, that means (METHOD USER DOMAIN HOST PORT LOCALNAME &optional HOP) still works. More interesting is the new signature, (VEC &optional LOCALNAME HOP). Usually, you retrieve VEC by tramp-dissect-file-name, or it is already provided as argument (many Tramp functions do so). Then, most of the cases you want to change only the LOCALNAME, which you could do directly in the function call. If you want to change another component of VEC, you could do this via the access functions for the tramp-file-name structure VEC, like (setf (tramp-file-name-host vec) "whatever") (tramp-make-tramp-file-name vec "/remote/dir") So yes, if you want to support several Tramp versions, you must write compatibility functions. > -Phil Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Thu May 03 17:34:52 2018 Received: (at 31357) by debbugs.gnu.org; 3 May 2018 21:34:52 +0000 Received: from localhost ([127.0.0.1]:48665 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fELsK-0005cJ-IB for submit@debbugs.gnu.org; Thu, 03 May 2018 17:34:52 -0400 Received: from smtp-4.orcon.net.nz ([60.234.4.59]:38371) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fELsI-0005cA-Dp for 31357@debbugs.gnu.org; Thu, 03 May 2018 17:34:51 -0400 Received: from [10.253.37.70] (port=39803 helo=webmail.orcon.net.nz) by smtp-4.orcon.net.nz with esmtpa (Exim 4.86_2) (envelope-from ) id 1fELsF-0005a1-92; Fri, 04 May 2018 09:34:47 +1200 Received: from wlgwil-nat-office.catalyst.net.nz ([202.78.240.7]) via [10.253.37.253] by webmail.orcon.net.nz with HTTP (HTTP/1.1 POST); Fri, 04 May 2018 09:34:47 +1200 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 04 May 2018 09:34:47 +1200 From: Phil Sainty To: Michael Albinus Subject: Re: bug#31357: 26.1; tramp-make-tramp-file-name: incompatible lisp changes in 26.1 =?UTF-8?Q?=3F?= In-Reply-To: <87k1sksquk.fsf@gmx.de> References: <0a062d8f1fea73fcead8cafe8f225378@webmail.orcon.net.nz> <87k1sksquk.fsf@gmx.de> Message-ID: <54c47e29d981f94a537aa9bdf0f37276@webmail.orcon.net.nz> X-Sender: psainty@orcon.net.nz User-Agent: Orcon Webmail X-GeoIP: -- X-Spam_score: -2.9 X-Spam_score_int: -28 X-Spam_bar: -- X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 31357 Cc: 31357@debbugs.gnu.org, bug-gnu-emacs X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 2018-05-04 03:26, Michael Albinus wrote: > Phil Sainty writes: >> This should surely be covered in NEWS under the "Incompatible Lisp >> Changes in Emacs 26.1" section? > > `tramp-make-tramp-file-name' has never been documented as public > function, it is intended for internal use. Granted, this should have > been signalled better. Given the function naming, a NEWS entry seems warranted to me. I do think that there *should* be a public interface for manipulating tramp file names. If these were never intended as such then perhaps such functionality could be introduced... > That's the way to go. You could use (funcall > 'tramp-make-tramp-file-name ...) > in order to make the byte compiler quiet. Perfect. > However, I wouldn't check for emacs-version. Tramp exist as separate > package, and the recent Tramp 2.4 runs with all Emacs 24, 25, 26 and > 27. You might check for tramp-version. Thanks; I've gone with this: (apply #'tramp-make-tramp-file-name (if (version< tramp-version "2.3") (list method user host temp hop) (list method user domain host port temp hop))) The changes in 2.4 sound good too. > (setf (tramp-file-name-host vec) "whatever") Ah, I'd actually tried that in 25.2 but those are not generalized variables in that version. I see that it works in 26.1 though, so that's an excellent enhancement. cheers, -Phil From debbugs-submit-bounces@debbugs.gnu.org Fri May 04 03:45:16 2018 Received: (at 31357) by debbugs.gnu.org; 4 May 2018 07:45:16 +0000 Received: from localhost ([127.0.0.1]:48833 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fEVP2-0004y8-HR for submit@debbugs.gnu.org; Fri, 04 May 2018 03:45:16 -0400 Received: from mout.gmx.net ([212.227.15.18]:49065) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fEVP0-0004q1-3c for 31357@debbugs.gnu.org; Fri, 04 May 2018 03:45:14 -0400 Received: from detlef.gmx.de ([212.86.52.157]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0McEkx-1ewh023NCR-00JWzr; Fri, 04 May 2018 09:44:57 +0200 From: Michael Albinus To: Phil Sainty Subject: Re: bug#31357: 26.1; tramp-make-tramp-file-name: incompatible lisp changes in 26.1 ? References: <0a062d8f1fea73fcead8cafe8f225378@webmail.orcon.net.nz> <87k1sksquk.fsf@gmx.de> <54c47e29d981f94a537aa9bdf0f37276@webmail.orcon.net.nz> Date: Fri, 04 May 2018 09:44:56 +0200 In-Reply-To: <54c47e29d981f94a537aa9bdf0f37276@webmail.orcon.net.nz> (Phil Sainty's message of "Fri, 04 May 2018 09:34:47 +1200") Message-ID: <87y3gz50g7.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:DeZaO5gmsEnbJdfT2aOqXwgOBh8OgGIQ5e9uqfumNGy1qODJJ6E E9TGfbdcM1WYRgiVdrRFaUXS1lFno1BAvdH18EzO9U06eGXJ5Ds78iaVwXsSUDBJB+kAhwb YlHuCyHJGBymOsjS/LovcjnxkYklAukaf1IBeDdTRE1vD47p50OvaxwpVd4EenwObUttrbT KR4S+3E7wxC4RaKnXU4PA== X-UI-Out-Filterresults: notjunk:1;V01:K0:OgI51Gf4p6E=:23r2gc38R22cK6VLGUJauJ 2otm2q7DotUYWEY0cPQUUY7Gp/qTKyrmyJM2jmnXcL33tP1cUA9yM1Yaow9aOjdZRhplp/moR xDJphwY0s57sscxWvVn1KremL+u4yQEPeuRhpxGK0mY/Qn3uSxp2x203AyG7jE8MXI33+FlGs CwNunNmn3SBRHHDLOj2RDL0dKMyeLTfx/fe7KDwjVgYEtxEEgUif4T9yTNhRCNEkjfFQni7m3 GBJGcEIvrHiJJEM6ys3LOjqp648/96fCggWcn9stToj/o4quKIEMWl75tp5wunPVvkq5YItd4 C2x3QfwPxxKrN1EOeZt5W7KWZfX1iVAqNPACQUl/76uKzxbAlLyKIbkxCuerqfSLWX1D3GDxK kZrsrKQ5aQZtDJjBHNT8ByqssEoCuZx98EtfoeBfW45x2Ir9t4jqoZli+kB+VOm6H/XmXspJS K8CHfgWXZUdQtY4sFGIo5qZEkGxc8F0jR5FnpStCUQe2vXhgjW4pQNGdnmqLz/HwPEwN86b8F Bf7TZsNMmUK6QC5yK77nfvWCS3xiVjWHNFMgKHwsnTwB9B2HusQbv59f2fpY0aY9zTlXlu0uI J9zO/reRTTJrZ5qCF3ZXyGaObmgbGr2P1VpvBrd2NoD5WmkoOImLUyxT13bC4LYhP50AjD4Nj DsrbZegCmynfHKJA/K8PzeHnMX9SSkeitXp1oA5cHNuIyNbyW/KxkB/7+c2aUL4Mu/i6BIqbL LWPiazMwuxDxuwjvxMq2Gna0xiLmFJ8zwrkg/am3vWr5uSI+WpM/G0mb4SHLyzdMqygCLLTPK L0AyL4t X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 31357 Cc: 31357@debbugs.gnu.org, bug-gnu-emacs X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Phil Sainty writes: Hi Phil, >> `tramp-make-tramp-file-name' has never been documented as public >> function, it is intended for internal use. Granted, this should have >> been signalled better. > > Given the function naming, a NEWS entry seems warranted to me. Well, this is a historical accident. None of the Tramp functions has been indicated as internal (as a double slash in the function name would do). This was already the case when I've entered the Tramp team back in 2002. And later on I resisted to perform a big renaming just for this. > I do think that there *should* be a public interface for manipulating > tramp file names. If these were never intended as such then perhaps > such functionality could be introduced... Perhaps. These days, people dissect a remote file name by the different calls of `file-remote-p', and reconstruct the file name by `concat' or `format'. An public interface might help. But this won't be `tramp-make-tramp-file-name', because this is the internal working horse, which will always be adapted to whatever need arrives in Tramp. Maybe you could propose such a public interface? It shouldn't be Tramp specific, other file name handlers shall profit from this as well. And local file names as arguments shall also be possible, so that you could change a local file name into a remote file name by a simple call (think about the common case changing a local file name into a sudo'ed one). See also function `file-local-name' (introduced in Emacs 26.1), which could be part of such broader interface. >> (setf (tramp-file-name-host vec) "whatever") > > Ah, I'd actually tried that in 25.2 but those are not generalized > variables in that version. I see that it works in 26.1 though, > so that's an excellent enhancement. Well, `tramp-file-name' has been introduced as defstruct in Tramp 2.3. Before, there was no dedicated type, and VEC was always a, hmm, simple vector. > cheers, > -Phil Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 21 07:56:11 2018 Received: (at control) by debbugs.gnu.org; 21 Jun 2018 11:56:11 +0000 Received: from localhost ([127.0.0.1]:58321 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fVyCB-0006V0-JV for submit@debbugs.gnu.org; Thu, 21 Jun 2018 07:56:11 -0400 Received: from mout.gmx.net ([212.227.15.19]:35745) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fVyCA-0006Uo-7l for control@debbugs.gnu.org; Thu, 21 Jun 2018 07:56:10 -0400 Received: from detlef.gmx.de ([212.86.58.122]) by mail.gmx.com (mrgmx003 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MbgKD-1foT382vYr-00Iyat for ; Thu, 21 Jun 2018 13:56:03 +0200 Date: Thu, 21 Jun 2018 13:56:02 +0200 Message-Id: <87tvpwz73h.fsf@gmx.de> To: control@debbugs.gnu.org From: Michael Albinus Subject: control message for bug #31357 X-Provags-ID: V03:K1:vlXDw2BMvkwyhLYzP8RnUgbZvqtViS/JuaxqFcvnY9JlHKQeyty W6Ij/dnk6P9190xKo9Ny69IrdBGD2ETHPW0iU5n6xOEsIc3Lle1UPYCx5UVT6ldm1CmSjFE HRCEmV+W+0ceKcNeZ5HetNMEpKISLnDWNPvvhBcIk+0WfqSmp0druY5uoEZaTNtPDYSkfjc BxePjG0Tic1QWKu7LHj0Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:VupVPTiThEk=:e5cDpb2XpuYTq0Ch3zTi5e bseLA4mRC9+icJkQVgnI/drAZnM1AGYhFoUniM3Nw6ttHUMBKwB/OP49PN1/J0+eWmo8neIfO pu1vu74kVZ2mkEgT+rbyRhUEe5F6SDPTp9H5aFVqj0HbDe+2sgKTKVeSV4umqJSBvDKf+QDbM Gph2PBwKG+xyj3ktdP0BCEo+saEIq8tOxtyJfrqw+g6dYgYSRah1pfNKVwmNvSOTxtLM/Ka3l ybtswul4INA/XtKkWLnVMg6lHtAUpFMg5Io/1RY7CY4x7qny2AtMKy++/0rWh/9Bbovn8ZdXZ FdcfqFJ5An6cSfqtWSTE/pa3YIhGXOLzNI8iNOgn0M2yB+yNoAEDeMxI0Uofep0zgKSeHSRGr PIa4IR3F9+A9vxWMF09VAaUW4kvSw4SxGNM3amJeY1DLlXF6JtuYes+UYVZNMrBERSRal9LGi OgkGrt2sYJodZkK+4onUqhiBKfS8Z5ekuH0rCmJDCO7uDrplsVwv06zOBLbAohdOENIT5Dcd1 2/KhnytN5p40oZsJHxx4m3cy86dL1B9TZo+t8fc/6oLiKjyB2tLF7xFfssB+YIuEfDtnYICG6 rsPUj3k5YdAXeJdDXJnSRjqLh37eS6E9shaW0GnVBRxYQPtnqiBwfB4ejjHsdSr/gISe4lmj3 cUaQFmpaiuI9e/xgkASYfNm8rWTtSniBkpVQq3kPXFGXqsDS9OSsRWtFfLvcWfR6t2ufxflVK EljVuG3STuDJlkoI96ZfYyzv3dH97eU4hk23MN3vBREHTFE+4hV+vSgT1GY= X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 31357 notabug close 31357 From unknown Sat Sep 06 20:03:32 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 20 Jul 2018 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator