From debbugs-submit-bounces@debbugs.gnu.org Wed May 02 16:05:49 2018 Received: (at submit) by debbugs.gnu.org; 2 May 2018 20:05:49 +0000 Received: from localhost ([127.0.0.1]:47356 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fDy0b-0001pw-HA for submit@debbugs.gnu.org; Wed, 02 May 2018 16:05:49 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37238) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fDy0a-0001pf-CN for submit@debbugs.gnu.org; Wed, 02 May 2018 16:05:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fDy0T-0007Iu-W8 for submit@debbugs.gnu.org; Wed, 02 May 2018 16:05:43 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:56287) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fDy0T-0007Io-SB for submit@debbugs.gnu.org; Wed, 02 May 2018 16:05:41 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56437) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fDy0S-00070Q-RN for bug-gnu-emacs@gnu.org; Wed, 02 May 2018 16:05:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fDy0R-0007IF-JH for bug-gnu-emacs@gnu.org; Wed, 02 May 2018 16:05:40 -0400 Received: from mail-qt0-x22e.google.com ([2607:f8b0:400d:c0d::22e]:40271) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fDy0R-0007I2-0a for bug-gnu-emacs@gnu.org; Wed, 02 May 2018 16:05:39 -0400 Received: by mail-qt0-x22e.google.com with SMTP id h2-v6so20074258qtp.7 for ; Wed, 02 May 2018 13:05:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=708VPubfO+XPDjue1wtGtba8fhpvtx2lUC5u4Up05E8=; b=spHAxZ/IrgwRou2BiaFbe8w2pGdO1g004s6Eb7qvRjtCC1NqoD6/52NVC2XGApZ5i5 eCEmW+nzFBepIIwvdfnI2HTlQYRbDX8EZXTHB5y941pbMnrHEApcJXDZa83JKskYS1ka 5Pz/iGIWxNrcsMW66detjCeCrgkYMVEEAeGHMcFOEoDLJiiSD+akegEotCnI1TkGlFTo 9e+3dQ1e1M2/Pf5sKn/ewG884pDacokXp9dnmQg3ZdhX+eBLmQv/ceoono5n2pZv74cA 8aRmwd9rvWszMit268/gETGSGNVzCzkKXcQusL0jQ4Anvn+TYWoD4ME6j90DF0/4xzTz 8c4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=708VPubfO+XPDjue1wtGtba8fhpvtx2lUC5u4Up05E8=; b=O4ksXx36h9gWWd0+1X5Zpgh92gg2f4ZloeD6rEdOUMCb9eZXQ23f9otRRGK4A1grnv S75k9wF5/uZ/QyUQ8tFAmjIG1km9/6H/IpgukpugUbPZO5Ysl/Yb9/KS9rmMkXw846R2 uq4kZQagl6fVkL3S9IZrfCJSKRmt7Z5sK2pQQl/pB7gmJSHqvlfI2cG4lk08bjESMMwC Y7ZX+DJ1EjPApXkyXM3ylPb1m+obGPIkYmRbt5byCgkwc92AotT0HdSWm0i7QW/T89kg fDDpmWjCSHrmIj88dE5GIyLgv1OeIowizdGP9bvahYvt3SGSwOdByXbSsl0NZRk1Kufd aQuw== X-Gm-Message-State: ALQs6tA6xYVsCGkN9vMGjipMgpukqL681G9IYaVPFTXRrTPMOkiVd6IL +7249PfvWIaIEHrXiSj4LLcAQZ8w1OI7EzJQCqiOp63lRK8= X-Google-Smtp-Source: AB8JxZouKdzAYYRLWkhlgZgfkL3cWrzus/h79NBFuoj0nyms6bNgcoierxm6VETXdf1/lM90eb5mnqB7wrbQy8fL26g= X-Received: by 2002:ac8:330e:: with SMTP id t14-v6mr17228573qta.263.1525291537735; Wed, 02 May 2018 13:05:37 -0700 (PDT) MIME-Version: 1.0 From: Daniel Pittman Date: Wed, 02 May 2018 20:05:02 +0000 Message-ID: Subject: 26.1; ispell enchant support generates invalid regexp for empty extra chars To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary="00000000000049e5bf056b3e9ca4" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --00000000000049e5bf056b3e9ca4 Content-Type: text/plain; charset="UTF-8" G'day. With the new Enchant support in 26 I was motivated to try it out. Turns out that some languages generate an empty "extra characters" report for languages I use, which is turned into the (invalid, says `looking-at`) regular expression "[]". This triggers in this function in ispell.el: (defun ispell--get-extra-word-characters (&optional lang) "Get the extra word characters for LANG as a character class. If LANG is omitted, get the extra word characters for the default language." (concat "[" (string-trim-right (apply 'ispell--call-enchant-lsmod (append '("-word-chars") (if lang `(,lang))))) "]")) Obviously, when the result of that call is an empty string we get `[]`; in my case: ] enchant-2-lsmod -word-chars en_US | xxd 00000000: 0a . ...which causes that. (Error is: `(invalid-regexp "Unmatched [ or [^")`) I have attached a patch which correctly handles this case, though I feel there must be a cleaner way to handle this modification of the return. In any case, Google (and I personally) have papers on file with the FSF covering this contribution, if it is non-trivial enough for that to matter. --00000000000049e5bf056b3e9ca4 Content-Type: application/octet-stream; name="emacs-ispell-enchant.patch" Content-Disposition: attachment; filename="emacs-ispell-enchant.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jgpj6dmr0 LS0tIGlzcGVsbC5lbC5vcmlnCTIwMTgtMDUtMDIgMTU6NTg6MzEuMDAwMDAwMDAwIC0wNDAwCisr KyBpc3BlbGwuZWwJMjAxOC0wNS0wMiAxNjowMzo0OS4wMDAwMDAwMDAgLTA0MDAKQEAgLTEyMDYs OCArMTIwNiwxMiBAQAogKGRlZnVuIGlzcGVsbC0tZ2V0LWV4dHJhLXdvcmQtY2hhcmFjdGVycyAo Jm9wdGlvbmFsIGxhbmcpCiAgICJHZXQgdGhlIGV4dHJhIHdvcmQgY2hhcmFjdGVycyBmb3IgTEFO RyBhcyBhIGNoYXJhY3RlciBjbGFzcy4KIElmIExBTkcgaXMgb21pdHRlZCwgZ2V0IHRoZSBleHRy YSB3b3JkIGNoYXJhY3RlcnMgZm9yIHRoZSBkZWZhdWx0IGxhbmd1YWdlLiIKLSAgKGNvbmNhdCAi WyIgKHN0cmluZy10cmltLXJpZ2h0IChhcHBseSAnaXNwZWxsLS1jYWxsLWVuY2hhbnQtbHNtb2QK LSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoYXBwZW5kICcoIi13b3Jk LWNoYXJzIikgKGlmIGxhbmcgYCgsbGFuZykpKSkpICJdIikpCisgIChsZXQgKChleHRyYSAoc3Ry aW5nLXRyaW0tcmlnaHQKKyAgICAgICAgICAgICAgICAoYXBwbHkgJ2lzcGVsbC0tY2FsbC1lbmNo YW50LWxzbW9kCisgICAgICAgICAgICAgICAgICAgICAgIChhcHBlbmQgJygiLXdvcmQtY2hhcnMi KSAoaWYgbGFuZyBgKCxsYW5nKSkpKSkpKQorICAgIChpZiAoZXF1YWwgZXh0cmEgIiIpCisgICAg ICAgICIiCisgICAgICAoY29uY2F0ICJbIiBleHRyYSAiXSIpKSkpCiAKIChkZWZ1biBpc3BlbGwt ZmluZC1lbmNoYW50LWRpY3Rpb25hcmllcyAoKQogICAiRmluZCBFbmNoYW50J3MgZGljdGlvbmFy aWVzLCBhbmQgcmVjb3JkIGluIGBpc3BlbGwtZW5jaGFudC1kaWN0aW9uYXJ5LWFsaXN0Jy4iCg== --00000000000049e5bf056b3e9ca4-- From debbugs-submit-bounces@debbugs.gnu.org Wed May 02 16:08:35 2018 Received: (at 31344) by debbugs.gnu.org; 2 May 2018 20:08:35 +0000 Received: from localhost ([127.0.0.1]:47361 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fDy3G-0001uR-Vk for submit@debbugs.gnu.org; Wed, 02 May 2018 16:08:35 -0400 Received: from mail-qk0-f182.google.com ([209.85.220.182]:34550) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fDy3E-0001uD-Ra for 31344@debbugs.gnu.org; Wed, 02 May 2018 16:08:33 -0400 Received: by mail-qk0-f182.google.com with SMTP id p186so12237022qkd.1 for <31344@debbugs.gnu.org>; Wed, 02 May 2018 13:08:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=urmtIb3NvvwLhIgmVC2sj46tYwanOtyaTrOQ9plnBw0=; b=cIK39/54L0xXjtVZMMxAwvgpJPVzTHZt6bv41ARhIRRRUVQ4EFtFttrNL9L0b5S3ih 6+W5h+M6OS3165OVjc2H2WoRsIwdapbzYNBUxqYDiYvPLKq/QAqbQ4nkpYWV4ArjzGVw zijZZwgcZ4BV26Loz4L2FvDpa1mTBnzJe4yMUNkVckqfBOIkV/fjN/yh+LyUPa4mrRF1 N3weV1V7Px0Fvg4e/2iWSYM1tamkh3bEYm/u6/4ZbtFQiGvkLGzaBITFWa8uyaHoKDe3 P6HrYz1zTlSFgMfi2F6hKsO3kLgFxz48Tj4UD/TflyOIk60CPemzPI4hAY1ma/XO9Nhw C6cA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=urmtIb3NvvwLhIgmVC2sj46tYwanOtyaTrOQ9plnBw0=; b=Dhx1ydEBYon2xJwvxo9Z7jKF01WLWzUVqbEidaAw9Lr2nQBZysGLAQl7Mrfp0TGxfa 7r6P9VqVAmvzkANZjxUnji8dD3ZklVOG4pskVYMwTmEdTTqiTrcueXCMTvXK1QKSN2WQ Qy3HAVPztYQrzNoNQ/SSlqtKadVeuM0ZuDwg2dxlobgvNLlIlLpBhDUe6zTGsTQ1pFHv +pqcJAwedDvst4XlBhzWi8VnuBZIzSvZfcJg+2TzjMw2u6HfaJx3VbBEV6IW6AJem3M4 LHfAbi6BAOHOV56AUs/emuK7EVxq1jMleMGzUSDSHUuifqK8SYdTnLeh3mE78jMSj9jY DJsg== X-Gm-Message-State: ALQs6tDTrv2G/lvINKDmjQKRxEW5tLTl6yrT7bR+Gk6qSAlTqI+QitaE TTQ8HtK4iFdalq474WYVEDiGkvLoaIylqOfjXZMYE+/9 X-Google-Smtp-Source: AB8JxZoBLoSHGPwSYrvxXXFsm8aBtyaoLLvmQ9e4E8WvAclEYeuTei4DPjm5+tFxDvGhHlIYoUTK7KOMqa+zeY3nehE= X-Received: by 10.55.31.233 with SMTP id n102mr15330124qkh.385.1525291706794; Wed, 02 May 2018 13:08:26 -0700 (PDT) MIME-Version: 1.0 From: Daniel Pittman Date: Wed, 02 May 2018 20:07:51 +0000 Message-ID: Subject: additional note: error triggers due to flyspell package using the extra chars regexp To: 31344@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -8.0 (--------) X-Debbugs-Envelope-To: 31344 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -9.0 (---------) Sorry, I forgot to mention in my original post that `flyspell-buffer` is the trigger for this; it uses the extra character regular expression. I have not verified if it can be reproduced with only ispell.el commands, though I assume it must be possible; it will trigger anywhere that regexp is used. From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 19 09:57:42 2018 Received: (at 31344-done) by debbugs.gnu.org; 19 Oct 2018 13:57:42 +0000 Received: from localhost ([127.0.0.1]:59623 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gDVHa-0002BQ-HM for submit@debbugs.gnu.org; Fri, 19 Oct 2018 09:57:42 -0400 Received: from mail-ot1-f53.google.com ([209.85.210.53]:46873) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gDVHY-0002BD-Jg for 31344-done@debbugs.gnu.org; Fri, 19 Oct 2018 09:57:41 -0400 Received: by mail-ot1-f53.google.com with SMTP id o21so33234316otb.13 for <31344-done@debbugs.gnu.org>; Fri, 19 Oct 2018 06:57:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=32kZ437//XFjHeNxeLXrHTSin5/ZOJd8Hl8nAui0m2g=; b=mnbyYP25RXadhDKDpG3vwmpMkg/Ugne/uXzQlMxTqDo/jEDbDI6PKaZME7SFq60xGT Nm2aNy9+1DPUbriPCPc/4EjX3OyPiJOqakZAAyPafKqNFnnFTWYQhIEoatsBkI/A9Ybz wnN82ldsilkKEUPEweV/8BsZYtZJcC6urk8XIVJGfDdysihgHMczwUnP81jiGDTWEobS CTyTxQ/DZh6dR6CVnQ1s9DjDrmXqHDrkN+w53zUN4EI6xzFXBP7ogfYmW8wQTBbIN06t 3ZVAFQtMbpVkAqdP3GCF4CMXiHhSCzQ+8h4lLz2jGoK2MvnPgQtSSooWi+ate3kz6IaV rNWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=32kZ437//XFjHeNxeLXrHTSin5/ZOJd8Hl8nAui0m2g=; b=J/UipO9mASvQIo78AILht5ZdBorUMXWbefq2Zq629tHkYKJtvXGg6FL/8V2mm7mFDb 4CuV84/tBM3ZZHxoTBmewokiXWAoV8yY+MQMYR3LfLvK4xJp/xt8EceQflasEUxz/Pt3 uUcx929A65OzGcpMmNtQJU+VNaYFV3d0Nm7K7FWk/vgoWJD/kQsr2Fewb+kS6huUTLeV uTVzjsQ69nJtXBJKp8/MUu+DNXncmyDvL5NWNPEEjqGcCbupzsi5WpjOGi5WolLmu9Bf ux0fNDWchmXYNzJj65noTXKjePeCToHSEeUHMhinhZdvJ4E8TmtzbwKDeEZoo8czJaPq LW2g== X-Gm-Message-State: ABuFfoho/Aj7T1XEi7qfcQHMv+xtBuqzvktZZLX3vJMjyuKW/+ZcgBQy sRbWIuV7ZLGRSJiRhkSF7H2RfSpSouWxa07sTH5/fu+qcuQ= X-Google-Smtp-Source: ACcGV63o6d7vjtt6XHs2YdT5/UWZKq/3OKpMCt96iuBLBLfNbFZZg25KHhFUmxYqijdclcu675j6S76O1dPRJYwTExI= X-Received: by 2002:a9d:5024:: with SMTP id a36mr21479543oth.195.1539957454391; Fri, 19 Oct 2018 06:57:34 -0700 (PDT) MIME-Version: 1.0 From: Daniel Pittman Date: Fri, 19 Oct 2018 09:56:58 -0400 Message-ID: Subject: resolved in master To: 31344-done@debbugs.gnu.org Content-Type: multipart/alternative; boundary="0000000000000a4944057895493a" X-Spam-Score: -8.0 (--------) X-Debbugs-Envelope-To: 31344-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -9.0 (---------) --0000000000000a4944057895493a Content-Type: text/plain; charset="UTF-8" this issue has been resolved in the master branch, but the bug was not closed. cleaning up. --0000000000000a4944057895493a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
this issue has been resolved in the master branch, but the= bug was not closed.=C2=A0 cleaning up.
--0000000000000a4944057895493a-- From unknown Thu Jun 19 14:20:54 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 17 Nov 2018 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator