Subject: Re: [bug#31331] [PATCH 1/2] gnu: Add bitlbee-discord.

From: parouby <[email-masked]>
Date: Wed, 2 May 2018 22:21:54 +0200

Hi Nils,

On 02/05/2018 20:41, Nils Gillmann wrote:
>> +               (string-append
>> +                "https://github.com/sm00th/bitlbee-discord/"
>> +                "archive/" version ".tar.gz"))
> 
> Nitpick, I would write it like:>  +              (uri
>  +               (string-append "https://github.com/sm00th/bitlbee-discord/"
>  +                              "archive/" version ".tar.gz"))

Yes, it's true, my bad !

>> +         (add-before 'configure 'bash-path
>> +           (lambda* (#:key inputs outputs #:allow-other-keys)
>> +             (substitute* "configure"
>> +               (("\\$SHELL") (string-append (assoc-ref inputs "bash")
>> +                                            "/bin/sh")))))
> 
> Is the configure.ac in this case special, or why doesn't it pick our SHELL
> that is already in the environment of the build chroot?

In this case, without modification the configure try to run '/bin/bash'
and don't care about 'SHELL' environment variable.
I don't found any other way. Any idea ?

>> +    (native-inputs `(("pkg-config" ,pkg-config)
>> +                     ("autoconf" ,autoconf)
>> +                     ("automake" ,automake)
>> +                     ("texinfo" ,texinfo)
>> +                     ("libtool" ,libtool)
>> +                     ("bitlbee" ,bitlbee)
> 
> Does the buildsystem of bitlbee-discord check for bitlbee, or why is this required?

Yes it's need bitlbee lib and header for compilation (just like
bitlbee-dev debian package).

Thanks,
--
Pierre-Antoine