GNU bug report logs - #31326
eshell/clear goes into infinite loop with eshell-smart-initialize

Previous Next

Package: emacs;

Reported by: Jonathan Kyle Mitchell <kyle <at> jonathanmitchell.org>

Date: Tue, 1 May 2018 06:15:02 UTC

Severity: normal

Tags: confirmed, fixed, patch

Merged with 37198

Found in versions 25, 26.2, 27.0.50

Fixed in version 27.1

Done: Noam Postavsky <npostavs <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Jonathan Kyle Mitchell <kyle <at> jonathanmitchell.org>
To: Noam Postavsky <npostavs <at> gmail.com>
Cc: 31326 <at> debbugs.gnu.org
Subject: bug#31326: 27.0.50; eshell/clear exceeds max-lisp-eval-depth
Date: Fri, 4 May 2018 13:07:01 -0500
On 05/04/2018 05:42 AM, Noam Postavsky wrote:
> tags 31326 + patch
> quit
>
> Jonathan Kyle Mitchell <kyle <at> jonathanmitchell.org> writes:
>
>> I did a little more investigation into this issue. While I don't fully
>> understand all the code paths of how it works, I found that let
>> binding eshell-input-filter-functions to nil stops the infinite
>> looping.
>> Here's a diff for the change that works for me:
>> -    (let ((eshell-input-filter-functions
>> -           (remq 'eshell-add-to-history eshell-input-filter-functions)))
>> +    (let ((eshell-input-filter-functions nil))
>>         (insert (make-string (window-size) ?\n))
>>         (eshell-send-input))))
> Makes sense, I'll push this to master in a few days.  Have you assigned
> copyright for Emacs?  If no, I'll mark it as a tiny change.
>
>

Thanks. No, I don't have any copyright papers signed. What's the process 
for doing that?

-- 
Jonathan Kyle Mitchell





This bug report was last modified 5 years and 267 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.