GNU bug report logs - #31325
27.0.50; PROPOSAL: introduce a new function to recenter without redisplaying the frame

Previous Next

Full log

View this message in rfc822 format

From: John Shahid <jvshahid <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: rudalics <at> gmx.at, 31325-done <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca
Subject: bug#31325: 27.0.50; PROPOSAL: introduce a new function to recenter without redisplaying the frame
Date: Sun, 01 Jul 2018 16:54:53 +0000

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: John Shahid <jvshahid <at> gmail.com>
>> Cc: Eli Zaretskii <eliz <at> gnu.org>, 31325 <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca
>> Date: Sun, 01 Jul 2018 13:17:17 +0000
>>
>> Fixed in the attached patch.
>
> Thanks, pushed to the master branch.
>
> Please in the future mention the bug number in the log message, and
> also grep the sources for callers of the functions you change.  (In
> this case, there was one caller in w32console.c, and it wouldn't
> compile after the change, because the number of arguments changed.)

Thanks Eli.  Sorry about that, I will try to be more careful in the
future.

It just occurred to me that this change will break backward
comparability for those who bind some key to the `recenter' command,
since now the second argument will always be nil and thus won't
redisplay.  Should we also change the interactive form of recenter to
use "p" for the second argument?  That way the second arg is never nil
when used interactively.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.