From unknown Tue Aug 19 18:20:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31318: emacs-26 fns-tests-collate-sort failure on glibc 2.27 Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Apr 2018 17:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 31318 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 31318@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.15251098138186 (code B ref -1); Mon, 30 Apr 2018 17:37:01 +0000 Received: (at submit) by debbugs.gnu.org; 30 Apr 2018 17:36:53 +0000 Received: from localhost ([127.0.0.1]:44189 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fDCjN-00027x-76 for submit@debbugs.gnu.org; Mon, 30 Apr 2018 13:36:53 -0400 Received: from eggs.gnu.org ([208.118.235.92]:47622) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fDCjK-00027k-Qq for submit@debbugs.gnu.org; Mon, 30 Apr 2018 13:36:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fDCjD-0003aX-TE for submit@debbugs.gnu.org; Mon, 30 Apr 2018 13:36:45 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:53877) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fDCjD-0003aK-P4 for submit@debbugs.gnu.org; Mon, 30 Apr 2018 13:36:43 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38574) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fDCjB-000487-S3 for bug-gnu-emacs@gnu.org; Mon, 30 Apr 2018 13:36:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fDCj8-0003YW-Ln for bug-gnu-emacs@gnu.org; Mon, 30 Apr 2018 13:36:41 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:40100) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fDCj8-0003YB-AJ for bug-gnu-emacs@gnu.org; Mon, 30 Apr 2018 13:36:38 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 7AFA4160065 for ; Mon, 30 Apr 2018 10:36:36 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id idIr8TJDTS-B for ; Mon, 30 Apr 2018 10:36:32 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 34DCC160085 for ; Mon, 30 Apr 2018 10:36:32 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id GVFNwLBnmQf6 for ; Mon, 30 Apr 2018 10:36:32 -0700 (PDT) Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 161D2160065 for ; Mon, 30 Apr 2018 10:36:32 -0700 (PDT) From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <1cf43452-0e5f-f1f6-6368-d975fd273ce7@cs.ucla.edu> Date: Mon, 30 Apr 2018 10:36:31 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------DEBC4D575B79A4A93C0E5217" Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) This is a multi-part message in MIME format. --------------DEBC4D575B79A4A93C0E5217 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit I upgraded to Fedora 28 beta over the weekend (Fedora 28 is scheduled for release next week) and ran into one test case failure on the emacs-26 branch: fns-tests-collate-sort fails (test/src/fns-tests.log is attached). Looking into the test, it appears that the test is making unportable assumptions about strcoll behavior in non-POSIX locales, an assumption that is not true of glibc 2.27 as shipped in Fedora 28. Proposed patch attached. --------------DEBC4D575B79A4A93C0E5217 Content-Type: text/x-log; name="fns-tests.log" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="fns-tests.log" Running 37 tests (2018-04-30 10:14:49-0700) Test fns-tests-collate-sort backtrace: signal(ert-test-failed (((should (equal (sort '("11" "1 2" "1.2" "12 ert-fail(((should (equal (sort '("11" "1 2" "1.2" "12") (lambda (a b (if (unwind-protect (setq value-355 (apply fn-353 args-354)) (setq f (let (form-description-357) (if (unwind-protect (setq value-355 (app (let ((value-355 'ert-form-evaluation-aborted-356)) (let (form-descr (let* ((fn-353 (function equal)) (args-354 (condition-case err (let (lambda nil (let* ((fn-343 (function fns-tests--collate-enabled-p)) ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name fns-tests-collate-sort :documentation ert-run-or-rerun-test(#s(ert--stats :selector (not (or (tag :expensi ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable))) ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":." "-l" "ert" "-l" "src/fns-tests.el" "--eval command-line() normal-top-level() Test fns-tests-collate-sort condition: (ert-test-failed ((should (equal (sort ... ...) '...)) :form (equal ("1 1" "1.1" "11" "1 2" "1.2" "12") ("11" "1 1" "1.1" "12" "1 2" "1.2")) :value nil :explanation (list-elt 0 (arrays-of-different-length 3 2 "1 1" "11" first-mismatch-at 1)))) FAILED 1/37 fns-tests-collate-sort passed 2/37 fns-tests-collate-strings passed 3/37 fns-tests-compare-strings passed 4/37 fns-tests-func-arity passed 5/37 fns-tests-hash-buffer passed 6/37 fns-tests-mapcan passed 7/37 fns-tests-nreverse passed 8/37 fns-tests-nreverse-bool-vector passed 9/37 fns-tests-reverse passed 10/37 fns-tests-reverse-bool-vector passed 11/37 fns-tests-sort passed 12/37 fns-tests-string-version-lessp passed 13/37 lax-plist-get/odd-number-of-elements passed 14/37 lax-plist-put/odd-number-of-elements passed 15/37 plist-get/odd-number-of-elements passed 16/37 plist-member/improper-list passed 17/37 plist-put/odd-number-of-elements passed 18/37 test-assoc-testfn passed 19/37 test-cycle-assoc passed 20/37 test-cycle-assq passed 21/37 test-cycle-delete passed 22/37 test-cycle-delq passed 23/37 test-cycle-equal passed 24/37 test-cycle-lax-plist-get passed 25/37 test-cycle-lax-plist-put passed 26/37 test-cycle-length passed 27/37 test-cycle-member passed 28/37 test-cycle-memq passed 29/37 test-cycle-memql passed 30/37 test-cycle-nconc passed 31/37 test-cycle-plist-get passed 32/37 test-cycle-plist-member passed 33/37 test-cycle-plist-put passed 34/37 test-cycle-rassoc passed 35/37 test-cycle-rassq passed 36/37 test-cycle-reverse passed 37/37 test-cycle-safe-length Ran 37 tests, 36 results as expected, 1 unexpected (2018-04-30 10:14:52-0700) 1 unexpected results: FAILED fns-tests-collate-sort --------------DEBC4D575B79A4A93C0E5217 Content-Type: text/plain; charset=UTF-8; name="0001-Port-collation-tests-to-glibc-2.27.txt" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-Port-collation-tests-to-glibc-2.27.txt" RnJvbSBkZWFhZGMxOWM4YTU5YjY5YmM1M2I3MzVmOWY2NmU5MzMwNDAxMGU5IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBNb24sIDMwIEFwciAyMDE4IDEwOjM1OjA0IC0wNzAwClN1YmplY3Q6IFtQQVRD SF0gUG9ydCBjb2xsYXRpb24gdGVzdHMgdG8gZ2xpYmMgMi4yNwpNSU1FLVZlcnNpb246IDEu MApDb250ZW50LVR5cGU6IHRleHQvcGxhaW47IGNoYXJzZXQ9VVRGLTgKQ29udGVudC1UcmFu c2Zlci1FbmNvZGluZzogOGJpdAoKKiB0ZXN0L3NyYy9mbnMtdGVzdHMuZWwgKGZucy10ZXN0 cy1jb2xsYXRlLXN0cmluZ3MpCihmbnMtdGVzdHMtY29sbGF0ZS1zb3J0KTogRG9u4oCZdCBt YWtlIHVucG9ydGFibGUgYXNzdW1wdGlvbnMKYWJvdXQgaG93IGVuX1VTLlVURi04IGNvbGxh dGlvbiB3b3Jrcy4gIFRoZXNlIGFzc3VtcHRpb25zCmFyZSBub3QgdHJ1ZSBvbiBGZWRvcmEg MjgsIHdoaWNoIHNoaXBzIHdpdGggZ2xpYmMgMi4yNy4KLS0tCiB0ZXN0L3NyYy9mbnMtdGVz dHMuZWwgfCA0OCArKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0t CiAxIGZpbGUgY2hhbmdlZCwgMjQgaW5zZXJ0aW9ucygrKSwgMjQgZGVsZXRpb25zKC0pCgpk aWZmIC0tZ2l0IGEvdGVzdC9zcmMvZm5zLXRlc3RzLmVsIGIvdGVzdC9zcmMvZm5zLXRlc3Rz LmVsCmluZGV4IGY4NTU0NjM2YmEuLjQ5MTkxNWY1NmEgMTAwNjQ0Ci0tLSBhL3Rlc3Qvc3Jj L2Zucy10ZXN0cy5lbAorKysgYi90ZXN0L3NyYy9mbnMtdGVzdHMuZWwKQEAgLTExOSwxMCAr MTE5LDkgQEAgZm5zLXRlc3RzLS1jb2xsYXRlLWVuYWJsZWQtcAogCiAgIDs7IEluIFBPU0lY IG9yIEMgbG9jYWxlcywgY29sbGF0aW9uIG9yZGVyIGlzIGxleGljb2dyYXBoaWMuCiAgIChz aG91bGQgKHN0cmluZy1jb2xsYXRlLWxlc3NwICJYWVpaWSIgInh5enp5IiAiUE9TSVgiKSkK LSAgOzsgSW4gYSBsYW5ndWFnZSBzcGVjaWZpYyBsb2NhbGUsIGNvbGxhdGlvbiBvcmRlciBp cyBkaWZmZXJlbnQuCi0gIChzaG91bGQgKHN0cmluZy1jb2xsYXRlLWxlc3NwCi0JICAgInh5 enp5IiAiWFlaWlkiCi0JICAgKGlmIChlcSBzeXN0ZW0tdHlwZSAnd2luZG93cy1udCkgImVu dV9VU0EiICJlbl9VUy5VVEYtOCIpKSkKKyAgOzsgSW4gYSBsYW5ndWFnZSBzcGVjaWZpYyBs b2NhbGUgb24gTVMtV2luZG93cywgY29sbGF0aW9uIG9yZGVyIGlzIGRpZmZlcmVudC4KKyAg KHdoZW4gKGVxIHN5c3RlbS10eXBlICd3aW5kb3dzLW50KQorICAgIChzaG91bGQgKHN0cmlu Zy1jb2xsYXRlLWxlc3NwICJ4eXp6eSIgIlhZWlpZIiAiZW5fVVMuVVRGLTgiKSkpCiAKICAg OzsgSWdub3JlIGNhc2UuCiAgIChzaG91bGQgKHN0cmluZy1jb2xsYXRlLWVxdWFscCAieHl6 enkiICJYWVpaWSIgbmlsIHQpKQpAQCAtMTU0LDggKzE1Myw2IEBAIGZucy10ZXN0cy0tY29s bGF0ZS1lbmFibGVkLXAKIAkgICAgKDkgLiAiYWFhIikgKDkgLiAienp6IikgKDkgLiAicHBw IikgKDkgLiAiZmZmIildKSkpCiAKIChlcnQtZGVmdGVzdCBmbnMtdGVzdHMtY29sbGF0ZS1z b3J0ICgpCi0gIDs7IFNlZSBodHRwczovL2xpc3RzLmdudS5vcmcvci9lbWFjcy1kZXZlbC8y MDE1LTEwL21zZzAyNTA1Lmh0bWwuCi0gIDpleHBlY3RlZC1yZXN1bHQgKGlmIChlcSBzeXN0 ZW0tdHlwZSAnY3lnd2luKSA6ZmFpbGVkIDpwYXNzZWQpCiAgIChza2lwLXVubGVzcyAoZm5z LXRlc3RzLS1jb2xsYXRlLWVuYWJsZWQtcCkpCiAKICAgOzsgUHVuY3R1YXRpb24gYW5kIHdo aXRlc3BhY2UgY2hhcmFjdGVycyBhcmUgcmVsZXZhbnQgZm9yIFBPU0lYLgpAQCAtMTY1LDE1 ICsxNjIsMTYgQEAgZm5zLXRlc3RzLS1jb2xsYXRlLWVuYWJsZWQtcAogCSAgKGxhbWJkYSAo YSBiKSAoc3RyaW5nLWNvbGxhdGUtbGVzc3AgYSBiICJQT1NJWCIpKSkKICAgICAnKCIxIDEi ICIxIDIiICIxLjEiICIxLjIiICIxMSIgIjEyIikpKQogICA7OyBQdW5jdHVhdGlvbiBhbmQg d2hpdGVzcGFjZSBjaGFyYWN0ZXJzIGFyZSBub3QgdGFrZW4gaW50byBhY2NvdW50Ci0gIDs7 IGZvciBjb2xsYXRpb24gaW4gb3RoZXIgbG9jYWxlcy4KLSAgKHNob3VsZAotICAgKGVxdWFs Ci0gICAgKHNvcnQgJygiMTEiICIxMiIgIjEgMSIgIjEgMiIgIjEuMSIgIjEuMiIpCi0JICAo bGFtYmRhIChhIGIpCi0JICAgIChsZXQgKCh3MzItY29sbGF0ZS1pZ25vcmUtcHVuY3R1YXRp b24gdCkpCi0JICAgICAgKHN0cmluZy1jb2xsYXRlLWxlc3NwCi0JICAgICAgIGEgYiAoaWYg KGVxIHN5c3RlbS10eXBlICd3aW5kb3dzLW50KSAiZW51X1VTQSIgImVuX1VTLlVURi04Iikp KSkpCi0gICAgJygiMTEiICIxIDEiICIxLjEiICIxMiIgIjEgMiIgIjEuMiIpKSkKKyAgOzsg Zm9yIGNvbGxhdGlvbiBpbiBvdGhlciBsb2NhbGVzLCBvbiBNUy1XaW5kb3dzIHN5c3RlbXMu CisgICh3aGVuIChlcSBzeXN0ZW0tdHlwZSAnd2luZG93cy1udCkKKyAgICAoc2hvdWxkCisg ICAgIChlcXVhbAorICAgICAgKHNvcnQgJygiMTEiICIxMiIgIjEgMSIgIjEgMiIgIjEuMSIg IjEuMiIpCisgICAgICAgICAgICAobGFtYmRhIChhIGIpCisgICAgICAgICAgICAgIChsZXQg KCh3MzItY29sbGF0ZS1pZ25vcmUtcHVuY3R1YXRpb24gdCkpCisgICAgICAgICAgICAgICAg KHN0cmluZy1jb2xsYXRlLWxlc3NwCisgICAgICAgICAgICAgICAgIGEgYiAiZW51X1VTQSIp KSkpCisgICAgICAnKCIxMSIgIjEgMSIgIjEuMSIgIjEyIiAiMSAyIiAiMS4yIikpKSkKIAog ICA7OyBEaWFjcml0aWNzIGFyZSBkaWZmZXJlbnQgbGV0dGVycyBmb3IgUE9TSVgsIHRoZXkg c29ydCBsZXhpY29ncmFwaGljYWwuCiAgIChzaG91bGQKQEAgLTE4MSwxNSArMTc5LDE3IEBA IGZucy10ZXN0cy0tY29sbGF0ZS1lbmFibGVkLXAKICAgICAoc29ydCAnKCLDhnZhciIgIkFn dXN0w61uIiAiQWRyaWFuIiAiRWxpIikKIAkgIChsYW1iZGEgKGEgYikgKHN0cmluZy1jb2xs YXRlLWxlc3NwIGEgYiAiUE9TSVgiKSkpCiAgICAgJygiQWRyaWFuIiAiQWd1c3TDrW4iICJF bGkiICLDhnZhciIpKSkKLSAgOzsgRGlhY3JpdGljcyBhcmUgc29ydGVkIGJldHdlZW4gc2lt aWxhciBsZXR0ZXJzIGZvciBvdGhlciBsb2NhbGVzLgotICAoc2hvdWxkCi0gICAoZXF1YWwK LSAgICAoc29ydCAnKCLDhnZhciIgIkFndXN0w61uIiAiQWRyaWFuIiAiRWxpIikKLQkgIChs YW1iZGEgKGEgYikKLQkgICAgKGxldCAoKHczMi1jb2xsYXRlLWlnbm9yZS1wdW5jdHVhdGlv biB0KSkKLQkgICAgICAoc3RyaW5nLWNvbGxhdGUtbGVzc3AKLQkgICAgICAgYSBiIChpZiAo ZXEgc3lzdGVtLXR5cGUgJ3dpbmRvd3MtbnQpICJlbnVfVVNBIiAiZW5fVVMuVVRGLTgiKSkp KSkKLSAgICAnKCJBZHJpYW4iICLDhnZhciIgIkFndXN0w61uIiAiRWxpIikpKSkKKyAgOzsg RGlhY3JpdGljcyBhcmUgc29ydGVkIGJldHdlZW4gc2ltaWxhciBsZXR0ZXJzIGZvciBvdGhl ciBsb2NhbGVzLAorICA7OyBvbiBNUy1XaW5kb3dzIHN5c3RlbXMuCisgICh3aGVuIChlcSBz eXN0ZW0tdHlwZSAnd2luZG93cy1udCkKKyAgICAoc2hvdWxkCisgICAgIChlcXVhbAorICAg ICAgKHNvcnQgJygiw4Z2YXIiICJBZ3VzdMOtbiIgIkFkcmlhbiIgIkVsaSIpCisgICAgICAg ICAgICAobGFtYmRhIChhIGIpCisgICAgICAgICAgICAgIChsZXQgKCh3MzItY29sbGF0ZS1p Z25vcmUtcHVuY3R1YXRpb24gdCkpCisgICAgICAgICAgICAgICAgKHN0cmluZy1jb2xsYXRl LWxlc3NwCisgICAgICAgICAgICAgICAgIGEgYiAiZW51X1VTQSIpKSkpCisgICAgICAnKCJB ZHJpYW4iICLDhnZhciIgIkFndXN0w61uIiAiRWxpIikpKSkpCiAKIChlcnQtZGVmdGVzdCBm bnMtdGVzdHMtc3RyaW5nLXZlcnNpb24tbGVzc3AgKCkKICAgKHNob3VsZCAoc3RyaW5nLXZl cnNpb24tbGVzc3AgImZvbzIucG5nIiAiZm9vMTIucG5nIikpCi0tIAoyLjE3LjAKCg== --------------DEBC4D575B79A4A93C0E5217-- From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 30 13:44:34 2018 Received: (at control) by debbugs.gnu.org; 30 Apr 2018 17:44:34 +0000 Received: from localhost ([127.0.0.1]:44194 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fDCqo-0002JI-7p for submit@debbugs.gnu.org; Mon, 30 Apr 2018 13:44:34 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:34374) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fDCqm-0002J2-LE for control@debbugs.gnu.org; Mon, 30 Apr 2018 13:44:33 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id D01E8160065 for ; Mon, 30 Apr 2018 10:44:26 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id v3bmw-JcDNzh for ; Mon, 30 Apr 2018 10:44:26 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 363F5160081 for ; Mon, 30 Apr 2018 10:44:26 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Tu88twHp1BOP for ; Mon, 30 Apr 2018 10:44:26 -0700 (PDT) Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 1E571160065 for ; Mon, 30 Apr 2018 10:44:26 -0700 (PDT) To: GNU bug control From: Paul Eggert Subject: 31318 has a patch Organization: UCLA Computer Science Department Message-ID: <270dc800-558e-18bc-7e32-9e74bf2d8c5f@cs.ucla.edu> Date: Mon, 30 Apr 2018 10:44:25 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) tags 31318 patch From unknown Tue Aug 19 18:20:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31318: emacs-26 fns-tests-collate-sort failure on glibc 2.27 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Apr 2018 19:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31318 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Paul Eggert Cc: 31318@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 31318-submit@debbugs.gnu.org id=B31318.152511785527799 (code B ref 31318); Mon, 30 Apr 2018 19:51:01 +0000 Received: (at 31318) by debbugs.gnu.org; 30 Apr 2018 19:50:55 +0000 Received: from localhost ([127.0.0.1]:44262 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fDEp5-0007EJ-6g for submit@debbugs.gnu.org; Mon, 30 Apr 2018 15:50:55 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54299) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fDEp3-0007E0-9P for 31318@debbugs.gnu.org; Mon, 30 Apr 2018 15:50:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fDEou-0006ac-4e for 31318@debbugs.gnu.org; Mon, 30 Apr 2018 15:50:48 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41158) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fDEou-0006aR-0X; Mon, 30 Apr 2018 15:50:44 -0400 Received: from [176.228.60.248] (port=1869 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fDEos-0003av-TL; Mon, 30 Apr 2018 15:50:43 -0400 Date: Mon, 30 Apr 2018 22:50:29 +0300 Message-Id: <83vac8qxru.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <1cf43452-0e5f-f1f6-6368-d975fd273ce7@cs.ucla.edu> (message from Paul Eggert on Mon, 30 Apr 2018 10:36:31 -0700) References: <1cf43452-0e5f-f1f6-6368-d975fd273ce7@cs.ucla.edu> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Paul Eggert > Date: Mon, 30 Apr 2018 10:36:31 -0700 > > I upgraded to Fedora 28 beta over the weekend (Fedora 28 is scheduled > for release next week) and ran into one test case failure on the > emacs-26 branch: fns-tests-collate-sort fails (test/src/fns-tests.log is > attached). Looking into the test, it appears that the test is making > unportable assumptions about strcoll behavior in non-POSIX locales, an > assumption that is not true of glibc 2.27 as shipped in Fedora 28. Really? So you are saying that 'ls' now sorts differently in UTF-8 locales on Fedora 28? That is, it no longer ignores punctuation in file names? Doesn't that cause user outcry? > - ;; In a language specific locale, collation order is different. > - (should (string-collate-lessp > - "xyzzy" "XYZZY" > - (if (eq system-type 'windows-nt) "enu_USA" "en_US.UTF-8"))) > + ;; In a language specific locale on MS-Windows, collation order is different. > + (when (eq system-type 'windows-nt) > + (should (string-collate-lessp "xyzzy" "XYZZY" "en_US.UTF-8"))) This is backwards: Windows needs enu_USA, not en_US.UTF-8 (which is not supported on Windows). > - ;; Diacritics are sorted between similar letters for other locales. > - (should > - (equal > - (sort '("Ævar" "Agustín" "Adrian" "Eli") > - (lambda (a b) > - (let ((w32-collate-ignore-punctuation t)) > - (string-collate-lessp > - a b (if (eq system-type 'windows-nt) "enu_USA" "en_US.UTF-8"))))) > - '("Adrian" "Ævar" "Agustín" "Eli")))) > + ;; Diacritics are sorted between similar letters for other locales, > + ;; on MS-Windows systems. > + (when (eq system-type 'windows-nt) > + (should > + (equal > + (sort '("Ævar" "Agustín" "Adrian" "Eli") > + (lambda (a b) > + (let ((w32-collate-ignore-punctuation t)) > + (string-collate-lessp > + a b "enu_USA")))) > + '("Adrian" "Ævar" "Agustín" "Eli"))))) So none of this now works on Fedora 28? That's too bad, don't you think? Why did they change the collation order? From unknown Tue Aug 19 18:20:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31318: emacs-26 fns-tests-collate-sort failure on glibc 2.27 Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 May 2018 00:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31318 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 31318@debbugs.gnu.org Received: via spool by 31318-submit@debbugs.gnu.org id=B31318.152513520829897 (code B ref 31318); Tue, 01 May 2018 00:41:02 +0000 Received: (at 31318) by debbugs.gnu.org; 1 May 2018 00:40:08 +0000 Received: from localhost ([127.0.0.1]:44571 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fDJKx-0007m9-Fi for submit@debbugs.gnu.org; Mon, 30 Apr 2018 20:40:07 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:47188) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fDJKu-0007lY-QJ for 31318@debbugs.gnu.org; Mon, 30 Apr 2018 20:40:05 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 01AE416006A; Mon, 30 Apr 2018 17:39:59 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id x-VG1hVAU-PB; Mon, 30 Apr 2018 17:39:57 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id B4E38160081; Mon, 30 Apr 2018 17:39:57 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 66FUlU6cH3fo; Mon, 30 Apr 2018 17:39:57 -0700 (PDT) Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 9860D16006A; Mon, 30 Apr 2018 17:39:57 -0700 (PDT) References: <1cf43452-0e5f-f1f6-6368-d975fd273ce7@cs.ucla.edu> <83vac8qxru.fsf@gnu.org> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <6182b73c-4ba6-8f28-0ef4-74107d1ca9dc@cs.ucla.edu> Date: Mon, 30 Apr 2018 17:39:57 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <83vac8qxru.fsf@gnu.org> Content-Type: multipart/mixed; boundary="------------01F27C6068067B1E239D8BBC" Content-Language: en-US X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This is a multi-part message in MIME format. --------------01F27C6068067B1E239D8BBC Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 04/30/2018 12:50 PM, Eli Zaretskii wrote: > > you are saying that 'ls' now sorts differently in UTF-8 > locales on Fedora 28? That is, it no longer ignores punctuation in > file names? Doesn't that cause user outcry? Yes, that's what I'm saying, at least for en_US.utf8. I haven't heard any user outcry. Not that I've been listening for one.... > This is backwards: Windows needs enu_USA, not en_US.UTF-8 (which is > not supported on Windows). Thanks, that was a silly typo. Revised patch attached, for the emacs-26 branch. > Why did they change the collation order? To be more consistent with other platforms, as I understand it. The idea is to do collation consistent with ISO/IEC 14651 . For more details, please see . Regardless of whether one thinks the change was a good idea, the Emacs tests should be portable to any POSIX platform, and since POSIX does not specify how the en_US.utf8 locale works the tests should not insist on either the old glibc implementation or the new one. --------------01F27C6068067B1E239D8BBC Content-Type: text/x-patch; name="0001-Port-collation-tests-to-glibc-2.27.patch" Content-Disposition: attachment; filename="0001-Port-collation-tests-to-glibc-2.27.patch" Content-Transfer-Encoding: quoted-printable >From 5fa31399dc87fc518152e6b695aebb7a5c60825b Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Mon, 30 Apr 2018 17:18:38 -0700 Subject: [PATCH] Port collation tests to glibc 2.27 MIME-Version: 1.0 Content-Type: text/plain; charset=3DUTF-8 Content-Transfer-Encoding: 8bit * test/src/fns-tests.el (fns-tests-collate-strings) (fns-tests-collate-sort): Don=E2=80=99t make unportable assumptions about how en_US.UTF-8 collation works. These assumptions are not true on Fedora 28, which ships with glibc 2.27. --- test/src/fns-tests.el | 48 +++++++++++++++++++++---------------------- 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/test/src/fns-tests.el b/test/src/fns-tests.el index f8554636ba..641947d66a 100644 --- a/test/src/fns-tests.el +++ b/test/src/fns-tests.el @@ -119,10 +119,9 @@ fns-tests--collate-enabled-p =20 ;; In POSIX or C locales, collation order is lexicographic. (should (string-collate-lessp "XYZZY" "xyzzy" "POSIX")) - ;; In a language specific locale, collation order is different. - (should (string-collate-lessp - "xyzzy" "XYZZY" - (if (eq system-type 'windows-nt) "enu_USA" "en_US.UTF-8"))) + ;; In a language specific locale on MS-Windows, collation order is dif= ferent. + (when (eq system-type 'windows-nt) + (should (string-collate-lessp "xyzzy" "XYZZY" "enu_USA"))) =20 ;; Ignore case. (should (string-collate-equalp "xyzzy" "XYZZY" nil t)) @@ -154,8 +153,6 @@ fns-tests--collate-enabled-p (9 . "aaa") (9 . "zzz") (9 . "ppp") (9 . "fff")]))) =20 (ert-deftest fns-tests-collate-sort () - ;; See https://lists.gnu.org/r/emacs-devel/2015-10/msg02505.html. - :expected-result (if (eq system-type 'cygwin) :failed :passed) (skip-unless (fns-tests--collate-enabled-p)) =20 ;; Punctuation and whitespace characters are relevant for POSIX. @@ -165,15 +162,16 @@ fns-tests--collate-enabled-p (lambda (a b) (string-collate-lessp a b "POSIX"))) '("1 1" "1 2" "1.1" "1.2" "11" "12"))) ;; Punctuation and whitespace characters are not taken into account - ;; for collation in other locales. - (should - (equal - (sort '("11" "12" "1 1" "1 2" "1.1" "1.2") - (lambda (a b) - (let ((w32-collate-ignore-punctuation t)) - (string-collate-lessp - a b (if (eq system-type 'windows-nt) "enu_USA" "en_US.UTF-8"))))= ) - '("11" "1 1" "1.1" "12" "1 2" "1.2"))) + ;; for collation in other locales, on MS-Windows systems. + (when (eq system-type 'windows-nt) + (should + (equal + (sort '("11" "12" "1 1" "1 2" "1.1" "1.2") + (lambda (a b) + (let ((w32-collate-ignore-punctuation t)) + (string-collate-lessp + a b "enu_USA")))) + '("11" "1 1" "1.1" "12" "1 2" "1.2")))) =20 ;; Diacritics are different letters for POSIX, they sort lexicographic= al. (should @@ -181,15 +179,17 @@ fns-tests--collate-enabled-p (sort '("=C3=86var" "Agust=C3=ADn" "Adrian" "Eli") (lambda (a b) (string-collate-lessp a b "POSIX"))) '("Adrian" "Agust=C3=ADn" "Eli" "=C3=86var"))) - ;; Diacritics are sorted between similar letters for other locales. - (should - (equal - (sort '("=C3=86var" "Agust=C3=ADn" "Adrian" "Eli") - (lambda (a b) - (let ((w32-collate-ignore-punctuation t)) - (string-collate-lessp - a b (if (eq system-type 'windows-nt) "enu_USA" "en_US.UTF-8"))))= ) - '("Adrian" "=C3=86var" "Agust=C3=ADn" "Eli")))) + ;; Diacritics are sorted between similar letters for other locales, + ;; on MS-Windows systems. + (when (eq system-type 'windows-nt) + (should + (equal + (sort '("=C3=86var" "Agust=C3=ADn" "Adrian" "Eli") + (lambda (a b) + (let ((w32-collate-ignore-punctuation t)) + (string-collate-lessp + a b "enu_USA")))) + '("Adrian" "=C3=86var" "Agust=C3=ADn" "Eli"))))) =20 (ert-deftest fns-tests-string-version-lessp () (should (string-version-lessp "foo2.png" "foo12.png")) --=20 2.17.0 --------------01F27C6068067B1E239D8BBC-- From unknown Tue Aug 19 18:20:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31318: emacs-26 fns-tests-collate-sort failure on glibc 2.27 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 May 2018 16:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31318 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Paul Eggert Cc: 31318@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 31318-submit@debbugs.gnu.org id=B31318.152519108325580 (code B ref 31318); Tue, 01 May 2018 16:12:02 +0000 Received: (at 31318) by debbugs.gnu.org; 1 May 2018 16:11:23 +0000 Received: from localhost ([127.0.0.1]:45934 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fDXsA-0006eW-L9 for submit@debbugs.gnu.org; Tue, 01 May 2018 12:11:22 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43678) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fDXs9-0006eK-0O for 31318@debbugs.gnu.org; Tue, 01 May 2018 12:11:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fDXs0-0000eY-LV for 31318@debbugs.gnu.org; Tue, 01 May 2018 12:11:15 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58317) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fDXs0-0000eL-Ir; Tue, 01 May 2018 12:11:12 -0400 Received: from [176.228.60.248] (port=3110 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fDXs0-0008Pr-24; Tue, 01 May 2018 12:11:12 -0400 Date: Tue, 01 May 2018 19:11:02 +0300 Message-Id: <83in87qru1.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <6182b73c-4ba6-8f28-0ef4-74107d1ca9dc@cs.ucla.edu> (message from Paul Eggert on Mon, 30 Apr 2018 17:39:57 -0700) References: <1cf43452-0e5f-f1f6-6368-d975fd273ce7@cs.ucla.edu> <83vac8qxru.fsf@gnu.org> <6182b73c-4ba6-8f28-0ef4-74107d1ca9dc@cs.ucla.edu> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > Cc: 31318@debbugs.gnu.org > From: Paul Eggert > Date: Mon, 30 Apr 2018 17:39:57 -0700 > > Regardless of whether one thinks the change was a good idea, the Emacs > tests should be portable to any POSIX platform, and since POSIX does not > specify how the en_US.utf8 locale works the tests should not insist on > either the old glibc implementation or the new one. Absolutely. But IMO it'd be a pity not to be able to test this important functionality on Posix platforms. So how about replacing these tests with something that works in a non-en_US locale in a way that is different from en_US? The functions being tested signal an error if a locale passed to them is not installed, so it should be possible to test whether a locale is available before running a test with it. WDYT? From unknown Tue Aug 19 18:20:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31318: emacs-26 fns-tests-collate-sort failure on glibc 2.27 Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 May 2018 16:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31318 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 31318@debbugs.gnu.org Received: via spool by 31318-submit@debbugs.gnu.org id=B31318.152519230327585 (code B ref 31318); Tue, 01 May 2018 16:32:01 +0000 Received: (at 31318) by debbugs.gnu.org; 1 May 2018 16:31:43 +0000 Received: from localhost ([127.0.0.1]:45951 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fDYBr-0007Ar-2s for submit@debbugs.gnu.org; Tue, 01 May 2018 12:31:43 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:57216) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fDYBp-0007Ac-CX for 31318@debbugs.gnu.org; Tue, 01 May 2018 12:31:41 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 629F31600B2; Tue, 1 May 2018 09:31:35 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id cz8BYzriEjjr; Tue, 1 May 2018 09:31:34 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id C95961600A4; Tue, 1 May 2018 09:31:33 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id xlwP0QtqTp6U; Tue, 1 May 2018 09:31:33 -0700 (PDT) Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id A956D1600AC; Tue, 1 May 2018 09:31:33 -0700 (PDT) References: <1cf43452-0e5f-f1f6-6368-d975fd273ce7@cs.ucla.edu> <83vac8qxru.fsf@gnu.org> <6182b73c-4ba6-8f28-0ef4-74107d1ca9dc@cs.ucla.edu> <83in87qru1.fsf@gnu.org> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <4c2bc366-b8e7-c34a-2761-e6dd89cde54e@cs.ucla.edu> Date: Tue, 1 May 2018 09:31:30 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <83in87qru1.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 05/01/2018 09:11 AM, Eli Zaretskii wrote: > how about replacing > these tests with something that works in a non-en_US locale in a way > that is different from en_US? Something along those lines could be done (it's done in coreutils with French), but it's a bit tricky so presumably it should be done in master. In contrast the patch I'm proposing is designed for emacs-26. From unknown Tue Aug 19 18:20:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31318: emacs-26 fns-tests-collate-sort failure on glibc 2.27 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 May 2018 16:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31318 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Paul Eggert Cc: 31318@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 31318-submit@debbugs.gnu.org id=B31318.152519338029246 (code B ref 31318); Tue, 01 May 2018 16:50:02 +0000 Received: (at 31318) by debbugs.gnu.org; 1 May 2018 16:49:40 +0000 Received: from localhost ([127.0.0.1]:45960 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fDYTD-0007bd-RU for submit@debbugs.gnu.org; Tue, 01 May 2018 12:49:40 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37990) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fDYTC-0007bS-Q8 for 31318@debbugs.gnu.org; Tue, 01 May 2018 12:49:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fDYT6-0002P9-QH for 31318@debbugs.gnu.org; Tue, 01 May 2018 12:49:33 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59025) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fDYT6-0002Oz-MO; Tue, 01 May 2018 12:49:32 -0400 Received: from [176.228.60.248] (port=3459 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fDYT6-0000nm-1s; Tue, 01 May 2018 12:49:32 -0400 Date: Tue, 01 May 2018 19:49:22 +0300 Message-Id: <83fu3bqq25.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <4c2bc366-b8e7-c34a-2761-e6dd89cde54e@cs.ucla.edu> (message from Paul Eggert on Tue, 1 May 2018 09:31:30 -0700) References: <1cf43452-0e5f-f1f6-6368-d975fd273ce7@cs.ucla.edu> <83vac8qxru.fsf@gnu.org> <6182b73c-4ba6-8f28-0ef4-74107d1ca9dc@cs.ucla.edu> <83in87qru1.fsf@gnu.org> <4c2bc366-b8e7-c34a-2761-e6dd89cde54e@cs.ucla.edu> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > Cc: 31318@debbugs.gnu.org > From: Paul Eggert > Date: Tue, 1 May 2018 09:31:30 -0700 > > On 05/01/2018 09:11 AM, Eli Zaretskii wrote: > > how about replacing > > these tests with something that works in a non-en_US locale in a way > > that is different from en_US? > > Something along those lines could be done (it's done in coreutils with > French), but it's a bit tricky so presumably it should be done in > master. In contrast the patch I'm proposing is designed for emacs-26. I'm okay with applying your patch to emacs-26 and then re-adding tests on master. Thanks. From unknown Tue Aug 19 18:20:34 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Paul Eggert Subject: bug#31318: closed (Re: emacs-26 fns-tests-collate-sort failure on glibc 2.27) Message-ID: References: <18baa48c-bc10-423a-f435-65aab8164ef1@cs.ucla.edu> <1cf43452-0e5f-f1f6-6368-d975fd273ce7@cs.ucla.edu> X-Gnu-PR-Message: they-closed 31318 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 31318@debbugs.gnu.org Date: Tue, 18 Jun 2019 23:54:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1560902042-18387-1" This is a multi-part message in MIME format... ------------=_1560902042-18387-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #31318: emacs-26 fns-tests-collate-sort failure on glibc 2.27 which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 31318@debbugs.gnu.org. --=20 31318: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D31318 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1560902042-18387-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 31318-done) by debbugs.gnu.org; 18 Jun 2019 23:53:07 +0000 Received: from localhost ([127.0.0.1]:45740 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hdNuU-0004l6-VI for submit@debbugs.gnu.org; Tue, 18 Jun 2019 19:53:07 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:53110) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hdNuS-0004kS-Dr for 31318-done@debbugs.gnu.org; Tue, 18 Jun 2019 19:53:04 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 168FE161C5B for <31318-done@debbugs.gnu.org>; Tue, 18 Jun 2019 16:52:59 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id By_28LpW67AV for <31318-done@debbugs.gnu.org>; Tue, 18 Jun 2019 16:52:58 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 6CAB5161C60 for <31318-done@debbugs.gnu.org>; Tue, 18 Jun 2019 16:52:58 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 6xCTBKBI-MIn for <31318-done@debbugs.gnu.org>; Tue, 18 Jun 2019 16:52:58 -0700 (PDT) Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 53F711617F9 for <31318-done@debbugs.gnu.org>; Tue, 18 Jun 2019 16:52:58 -0700 (PDT) To: 31318-done@debbugs.gnu.org From: Paul Eggert Subject: Re: emacs-26 fns-tests-collate-sort failure on glibc 2.27 Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECHgECF4AACgkQ7ZfpDmKqfjRRGw/+Ij03dhYfYl/gXVRiuzV1gGrbHk+t nfrI/C7fAeoFzQ5tVgVinShaPkZo0HTPf18x6IDEdAiO8Mqo1yp0CtHmzGMCJ50o4Grgfjlr 6g/+vtEOKbhleszN2XpJvpwM2QgGvn/laTLUu8PH9aRWTs7qJJZKKKAb4sxYc92FehPu6FOD 0dDiyhlDAq4lOV2mdBpzQbiojoZzQLMQwjpgCTK2572eK9EOEQySUThXrSIz6ASenp4NYTFH s9tuJQvXk9gZDdPSl3bp+47dGxlxEWLpBIM7zIONw4ks4azgT8nvDZxA5IZHtvqBlJLBObYY 0Le61Wp0y3TlBDh2qdK8eYL426W4scEMSuig5gb8OAtQiBW6k2sGUxxeiv8ovWu8YAZgKJfu oWI+uRnMEddruY8JsoM54KaKvZikkKs2bg1ndtLVzHpJ6qFZC7QVjeHUh6/BmgvdjWPZYFTt N+KA9CWX3GQKKgN3uu988yznD7LnB98T4EUH1HA/GnfBqMV1gpzTvPc4qVQinCmIkEFp83zl +G5fCjJJ3W7ivzCnYo4KhKLpFUm97okTKR2LW3xZzEW4cLSWO387MTK3CzDOx5qe6s4a91Zu ZM/j/TQdTLDaqNn83kA4Hq48UHXYxcIh+Nd8k/3w6lFuoK0wrOFiywjLx+0ur5jmmbecBGHc 1xdhAFHOwU0ETIByZAEQAKaF678T9wyH4wjTrV1Pz3cDEoSnV/0ZUrOT37p1dcGyj/IXq1x6 70HRVahAmk0sZpYc25PF9D5GPYHFWlNjuPU96rDndXB3hedmBRhLdC4bAXjI4DV+bmdVe+q/ IMnlZRaVlm9EiMCVAR6w13sReu7qXkW9r3RwY2AzXskp/tAe4BRKr1Zmbvi2nbnQ6epEC42r Rbx0B1EhjbIQZ5JHGk24iPT7LdBgnNmos5wYjzwNlkMQD5T0Ydzhk7J+UxwA5m46mOhRDC2r FV/A0gm5TLy8DXjv/Esc4gYnYai6SQqnUEVh5LuV8YCJBnijs+Tiw71x1icmn6xGI45EugJO gec+rLypYgpVp4x0HI5T88qBRYCkxH3Kg8Qo+EWNA9A4LRQ9DX8njona0gf0s03tocK8kBN6 6UoqqPtHBnc4eMgBymCflK12eKfd2YYxnyg9cZazWA5VslvTxpm76hbg5oiAEH/Vg/8MxHyA nPhfrgwyPrmJEcVBafdspJnYQxBYNco2LFPIhlOvWh8r4at+s+M3Lb26oUTczlgdW1Sf3SDA 77BMRnF0FQyE+7AzV79MBN4ykiqaezQxtaF1Fy/tvkhffSo8u+dwG0EgJh+te38gTcISVr0G IPplLz6YhjrbHrPRF1CN5UuL9DBGjxuN35RLNVEfta6RUFlR6NctTjvrABEBAAHCwWUEGAEC AA8FAkyAcmQCGwwFCRLMAwAACgkQ7ZfpDmKqfjSrHA/+KzAKvTxRhA9MWNLxIyJ7S5uJ16gs T3oCjZrBKGEhKMOGX4O0GA6VOEryO7QRCCYah3oxSG38IAnNeiwJXgU9Bzkk85UGbPEd7HGF /VSeHCQwWou6jqUDTSDvn9YhNTdG0KXPM74aC+xr2Zow1O2mhXihgWKD0Dw+0LYPnUOsQ0KO FxHXXYHmRrS1OZPU59BLvc+TRhIhafSHKLwbXK+6ckkxBx6h8z5ccpG0Qs4bFhdFYnFrEieD LoGmnE2YLhdV6swJ9VNCS6pLiEohT3fm7aXm15tZOIyzMZhHRSAPblXxQ0ZSWjq8oRrcYNFx c4W1URpAkBCOYJoXvQfD5L3lqAl8TCqDUzYxhH/tJhbDdHrqHH767jaDaTB1+Talp/2AMKwc XNOdiklGxbmHVG6YGl6g8Lrbsu9NZEI4yLlHzuikthJWgz+3vZhVGyNlt+HNIoF6CjDL2omu 5cEq4RDHM44QqPk6l7O0pUvN1mT4B+S1b08RKpqm/ff015E37HNV/piIvJlxGAYz8PSfuGCB 1thMYqlmgdhd9/BabGFbGGYHA6U4/T5zqU+f6xHy1SsAQZ1MSKlLwekBIT+4/cLRGqCHjnV0 q5H/T6a7t5mPkbzSrOLSo4puj+IToNjYyYIDBWzhlA19avOa+rvUjmHtD3sFN7cXWtkGoi8b uNcby4U= Organization: UCLA Computer Science Department Message-ID: <18baa48c-bc10-423a-f435-65aab8164ef1@cs.ucla.edu> Date: Tue, 18 Jun 2019 16:52:58 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 31318-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This patch was installed into the emacs-26 branch last year but I forgot to close the bug report. Closing it now. ------------=_1560902042-18387-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 30 Apr 2018 17:36:53 +0000 Received: from localhost ([127.0.0.1]:44189 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fDCjN-00027x-76 for submit@debbugs.gnu.org; Mon, 30 Apr 2018 13:36:53 -0400 Received: from eggs.gnu.org ([208.118.235.92]:47622) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fDCjK-00027k-Qq for submit@debbugs.gnu.org; Mon, 30 Apr 2018 13:36:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fDCjD-0003aX-TE for submit@debbugs.gnu.org; Mon, 30 Apr 2018 13:36:45 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:53877) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fDCjD-0003aK-P4 for submit@debbugs.gnu.org; Mon, 30 Apr 2018 13:36:43 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38574) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fDCjB-000487-S3 for bug-gnu-emacs@gnu.org; Mon, 30 Apr 2018 13:36:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fDCj8-0003YW-Ln for bug-gnu-emacs@gnu.org; Mon, 30 Apr 2018 13:36:41 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:40100) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fDCj8-0003YB-AJ for bug-gnu-emacs@gnu.org; Mon, 30 Apr 2018 13:36:38 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 7AFA4160065 for ; Mon, 30 Apr 2018 10:36:36 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id idIr8TJDTS-B for ; Mon, 30 Apr 2018 10:36:32 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 34DCC160085 for ; Mon, 30 Apr 2018 10:36:32 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id GVFNwLBnmQf6 for ; Mon, 30 Apr 2018 10:36:32 -0700 (PDT) Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 161D2160065 for ; Mon, 30 Apr 2018 10:36:32 -0700 (PDT) To: bug-gnu-emacs@gnu.org From: Paul Eggert Subject: emacs-26 fns-tests-collate-sort failure on glibc 2.27 Organization: UCLA Computer Science Department Message-ID: <1cf43452-0e5f-f1f6-6368-d975fd273ce7@cs.ucla.edu> Date: Mon, 30 Apr 2018 10:36:31 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------DEBC4D575B79A4A93C0E5217" Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) This is a multi-part message in MIME format. --------------DEBC4D575B79A4A93C0E5217 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit I upgraded to Fedora 28 beta over the weekend (Fedora 28 is scheduled for release next week) and ran into one test case failure on the emacs-26 branch: fns-tests-collate-sort fails (test/src/fns-tests.log is attached). Looking into the test, it appears that the test is making unportable assumptions about strcoll behavior in non-POSIX locales, an assumption that is not true of glibc 2.27 as shipped in Fedora 28. Proposed patch attached. --------------DEBC4D575B79A4A93C0E5217 Content-Type: text/x-log; name="fns-tests.log" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="fns-tests.log" Running 37 tests (2018-04-30 10:14:49-0700) Test fns-tests-collate-sort backtrace: signal(ert-test-failed (((should (equal (sort '("11" "1 2" "1.2" "12 ert-fail(((should (equal (sort '("11" "1 2" "1.2" "12") (lambda (a b (if (unwind-protect (setq value-355 (apply fn-353 args-354)) (setq f (let (form-description-357) (if (unwind-protect (setq value-355 (app (let ((value-355 'ert-form-evaluation-aborted-356)) (let (form-descr (let* ((fn-353 (function equal)) (args-354 (condition-case err (let (lambda nil (let* ((fn-343 (function fns-tests--collate-enabled-p)) ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name fns-tests-collate-sort :documentation ert-run-or-rerun-test(#s(ert--stats :selector (not (or (tag :expensi ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable))) ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":." "-l" "ert" "-l" "src/fns-tests.el" "--eval command-line() normal-top-level() Test fns-tests-collate-sort condition: (ert-test-failed ((should (equal (sort ... ...) '...)) :form (equal ("1 1" "1.1" "11" "1 2" "1.2" "12") ("11" "1 1" "1.1" "12" "1 2" "1.2")) :value nil :explanation (list-elt 0 (arrays-of-different-length 3 2 "1 1" "11" first-mismatch-at 1)))) FAILED 1/37 fns-tests-collate-sort passed 2/37 fns-tests-collate-strings passed 3/37 fns-tests-compare-strings passed 4/37 fns-tests-func-arity passed 5/37 fns-tests-hash-buffer passed 6/37 fns-tests-mapcan passed 7/37 fns-tests-nreverse passed 8/37 fns-tests-nreverse-bool-vector passed 9/37 fns-tests-reverse passed 10/37 fns-tests-reverse-bool-vector passed 11/37 fns-tests-sort passed 12/37 fns-tests-string-version-lessp passed 13/37 lax-plist-get/odd-number-of-elements passed 14/37 lax-plist-put/odd-number-of-elements passed 15/37 plist-get/odd-number-of-elements passed 16/37 plist-member/improper-list passed 17/37 plist-put/odd-number-of-elements passed 18/37 test-assoc-testfn passed 19/37 test-cycle-assoc passed 20/37 test-cycle-assq passed 21/37 test-cycle-delete passed 22/37 test-cycle-delq passed 23/37 test-cycle-equal passed 24/37 test-cycle-lax-plist-get passed 25/37 test-cycle-lax-plist-put passed 26/37 test-cycle-length passed 27/37 test-cycle-member passed 28/37 test-cycle-memq passed 29/37 test-cycle-memql passed 30/37 test-cycle-nconc passed 31/37 test-cycle-plist-get passed 32/37 test-cycle-plist-member passed 33/37 test-cycle-plist-put passed 34/37 test-cycle-rassoc passed 35/37 test-cycle-rassq passed 36/37 test-cycle-reverse passed 37/37 test-cycle-safe-length Ran 37 tests, 36 results as expected, 1 unexpected (2018-04-30 10:14:52-0700) 1 unexpected results: FAILED fns-tests-collate-sort --------------DEBC4D575B79A4A93C0E5217 Content-Type: text/plain; charset=UTF-8; name="0001-Port-collation-tests-to-glibc-2.27.txt" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-Port-collation-tests-to-glibc-2.27.txt" RnJvbSBkZWFhZGMxOWM4YTU5YjY5YmM1M2I3MzVmOWY2NmU5MzMwNDAxMGU5IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBNb24sIDMwIEFwciAyMDE4IDEwOjM1OjA0IC0wNzAwClN1YmplY3Q6IFtQQVRD SF0gUG9ydCBjb2xsYXRpb24gdGVzdHMgdG8gZ2xpYmMgMi4yNwpNSU1FLVZlcnNpb246IDEu MApDb250ZW50LVR5cGU6IHRleHQvcGxhaW47IGNoYXJzZXQ9VVRGLTgKQ29udGVudC1UcmFu c2Zlci1FbmNvZGluZzogOGJpdAoKKiB0ZXN0L3NyYy9mbnMtdGVzdHMuZWwgKGZucy10ZXN0 cy1jb2xsYXRlLXN0cmluZ3MpCihmbnMtdGVzdHMtY29sbGF0ZS1zb3J0KTogRG9u4oCZdCBt YWtlIHVucG9ydGFibGUgYXNzdW1wdGlvbnMKYWJvdXQgaG93IGVuX1VTLlVURi04IGNvbGxh dGlvbiB3b3Jrcy4gIFRoZXNlIGFzc3VtcHRpb25zCmFyZSBub3QgdHJ1ZSBvbiBGZWRvcmEg MjgsIHdoaWNoIHNoaXBzIHdpdGggZ2xpYmMgMi4yNy4KLS0tCiB0ZXN0L3NyYy9mbnMtdGVz dHMuZWwgfCA0OCArKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0t CiAxIGZpbGUgY2hhbmdlZCwgMjQgaW5zZXJ0aW9ucygrKSwgMjQgZGVsZXRpb25zKC0pCgpk aWZmIC0tZ2l0IGEvdGVzdC9zcmMvZm5zLXRlc3RzLmVsIGIvdGVzdC9zcmMvZm5zLXRlc3Rz LmVsCmluZGV4IGY4NTU0NjM2YmEuLjQ5MTkxNWY1NmEgMTAwNjQ0Ci0tLSBhL3Rlc3Qvc3Jj L2Zucy10ZXN0cy5lbAorKysgYi90ZXN0L3NyYy9mbnMtdGVzdHMuZWwKQEAgLTExOSwxMCAr MTE5LDkgQEAgZm5zLXRlc3RzLS1jb2xsYXRlLWVuYWJsZWQtcAogCiAgIDs7IEluIFBPU0lY IG9yIEMgbG9jYWxlcywgY29sbGF0aW9uIG9yZGVyIGlzIGxleGljb2dyYXBoaWMuCiAgIChz aG91bGQgKHN0cmluZy1jb2xsYXRlLWxlc3NwICJYWVpaWSIgInh5enp5IiAiUE9TSVgiKSkK LSAgOzsgSW4gYSBsYW5ndWFnZSBzcGVjaWZpYyBsb2NhbGUsIGNvbGxhdGlvbiBvcmRlciBp cyBkaWZmZXJlbnQuCi0gIChzaG91bGQgKHN0cmluZy1jb2xsYXRlLWxlc3NwCi0JICAgInh5 enp5IiAiWFlaWlkiCi0JICAgKGlmIChlcSBzeXN0ZW0tdHlwZSAnd2luZG93cy1udCkgImVu dV9VU0EiICJlbl9VUy5VVEYtOCIpKSkKKyAgOzsgSW4gYSBsYW5ndWFnZSBzcGVjaWZpYyBs b2NhbGUgb24gTVMtV2luZG93cywgY29sbGF0aW9uIG9yZGVyIGlzIGRpZmZlcmVudC4KKyAg KHdoZW4gKGVxIHN5c3RlbS10eXBlICd3aW5kb3dzLW50KQorICAgIChzaG91bGQgKHN0cmlu Zy1jb2xsYXRlLWxlc3NwICJ4eXp6eSIgIlhZWlpZIiAiZW5fVVMuVVRGLTgiKSkpCiAKICAg OzsgSWdub3JlIGNhc2UuCiAgIChzaG91bGQgKHN0cmluZy1jb2xsYXRlLWVxdWFscCAieHl6 enkiICJYWVpaWSIgbmlsIHQpKQpAQCAtMTU0LDggKzE1Myw2IEBAIGZucy10ZXN0cy0tY29s bGF0ZS1lbmFibGVkLXAKIAkgICAgKDkgLiAiYWFhIikgKDkgLiAienp6IikgKDkgLiAicHBw IikgKDkgLiAiZmZmIildKSkpCiAKIChlcnQtZGVmdGVzdCBmbnMtdGVzdHMtY29sbGF0ZS1z b3J0ICgpCi0gIDs7IFNlZSBodHRwczovL2xpc3RzLmdudS5vcmcvci9lbWFjcy1kZXZlbC8y MDE1LTEwL21zZzAyNTA1Lmh0bWwuCi0gIDpleHBlY3RlZC1yZXN1bHQgKGlmIChlcSBzeXN0 ZW0tdHlwZSAnY3lnd2luKSA6ZmFpbGVkIDpwYXNzZWQpCiAgIChza2lwLXVubGVzcyAoZm5z LXRlc3RzLS1jb2xsYXRlLWVuYWJsZWQtcCkpCiAKICAgOzsgUHVuY3R1YXRpb24gYW5kIHdo aXRlc3BhY2UgY2hhcmFjdGVycyBhcmUgcmVsZXZhbnQgZm9yIFBPU0lYLgpAQCAtMTY1LDE1 ICsxNjIsMTYgQEAgZm5zLXRlc3RzLS1jb2xsYXRlLWVuYWJsZWQtcAogCSAgKGxhbWJkYSAo YSBiKSAoc3RyaW5nLWNvbGxhdGUtbGVzc3AgYSBiICJQT1NJWCIpKSkKICAgICAnKCIxIDEi ICIxIDIiICIxLjEiICIxLjIiICIxMSIgIjEyIikpKQogICA7OyBQdW5jdHVhdGlvbiBhbmQg d2hpdGVzcGFjZSBjaGFyYWN0ZXJzIGFyZSBub3QgdGFrZW4gaW50byBhY2NvdW50Ci0gIDs7 IGZvciBjb2xsYXRpb24gaW4gb3RoZXIgbG9jYWxlcy4KLSAgKHNob3VsZAotICAgKGVxdWFs Ci0gICAgKHNvcnQgJygiMTEiICIxMiIgIjEgMSIgIjEgMiIgIjEuMSIgIjEuMiIpCi0JICAo bGFtYmRhIChhIGIpCi0JICAgIChsZXQgKCh3MzItY29sbGF0ZS1pZ25vcmUtcHVuY3R1YXRp b24gdCkpCi0JICAgICAgKHN0cmluZy1jb2xsYXRlLWxlc3NwCi0JICAgICAgIGEgYiAoaWYg KGVxIHN5c3RlbS10eXBlICd3aW5kb3dzLW50KSAiZW51X1VTQSIgImVuX1VTLlVURi04Iikp KSkpCi0gICAgJygiMTEiICIxIDEiICIxLjEiICIxMiIgIjEgMiIgIjEuMiIpKSkKKyAgOzsg Zm9yIGNvbGxhdGlvbiBpbiBvdGhlciBsb2NhbGVzLCBvbiBNUy1XaW5kb3dzIHN5c3RlbXMu CisgICh3aGVuIChlcSBzeXN0ZW0tdHlwZSAnd2luZG93cy1udCkKKyAgICAoc2hvdWxkCisg ICAgIChlcXVhbAorICAgICAgKHNvcnQgJygiMTEiICIxMiIgIjEgMSIgIjEgMiIgIjEuMSIg IjEuMiIpCisgICAgICAgICAgICAobGFtYmRhIChhIGIpCisgICAgICAgICAgICAgIChsZXQg KCh3MzItY29sbGF0ZS1pZ25vcmUtcHVuY3R1YXRpb24gdCkpCisgICAgICAgICAgICAgICAg KHN0cmluZy1jb2xsYXRlLWxlc3NwCisgICAgICAgICAgICAgICAgIGEgYiAiZW51X1VTQSIp KSkpCisgICAgICAnKCIxMSIgIjEgMSIgIjEuMSIgIjEyIiAiMSAyIiAiMS4yIikpKSkKIAog ICA7OyBEaWFjcml0aWNzIGFyZSBkaWZmZXJlbnQgbGV0dGVycyBmb3IgUE9TSVgsIHRoZXkg c29ydCBsZXhpY29ncmFwaGljYWwuCiAgIChzaG91bGQKQEAgLTE4MSwxNSArMTc5LDE3IEBA IGZucy10ZXN0cy0tY29sbGF0ZS1lbmFibGVkLXAKICAgICAoc29ydCAnKCLDhnZhciIgIkFn dXN0w61uIiAiQWRyaWFuIiAiRWxpIikKIAkgIChsYW1iZGEgKGEgYikgKHN0cmluZy1jb2xs YXRlLWxlc3NwIGEgYiAiUE9TSVgiKSkpCiAgICAgJygiQWRyaWFuIiAiQWd1c3TDrW4iICJF bGkiICLDhnZhciIpKSkKLSAgOzsgRGlhY3JpdGljcyBhcmUgc29ydGVkIGJldHdlZW4gc2lt aWxhciBsZXR0ZXJzIGZvciBvdGhlciBsb2NhbGVzLgotICAoc2hvdWxkCi0gICAoZXF1YWwK LSAgICAoc29ydCAnKCLDhnZhciIgIkFndXN0w61uIiAiQWRyaWFuIiAiRWxpIikKLQkgIChs YW1iZGEgKGEgYikKLQkgICAgKGxldCAoKHczMi1jb2xsYXRlLWlnbm9yZS1wdW5jdHVhdGlv biB0KSkKLQkgICAgICAoc3RyaW5nLWNvbGxhdGUtbGVzc3AKLQkgICAgICAgYSBiIChpZiAo ZXEgc3lzdGVtLXR5cGUgJ3dpbmRvd3MtbnQpICJlbnVfVVNBIiAiZW5fVVMuVVRGLTgiKSkp KSkKLSAgICAnKCJBZHJpYW4iICLDhnZhciIgIkFndXN0w61uIiAiRWxpIikpKSkKKyAgOzsg RGlhY3JpdGljcyBhcmUgc29ydGVkIGJldHdlZW4gc2ltaWxhciBsZXR0ZXJzIGZvciBvdGhl ciBsb2NhbGVzLAorICA7OyBvbiBNUy1XaW5kb3dzIHN5c3RlbXMuCisgICh3aGVuIChlcSBz eXN0ZW0tdHlwZSAnd2luZG93cy1udCkKKyAgICAoc2hvdWxkCisgICAgIChlcXVhbAorICAg ICAgKHNvcnQgJygiw4Z2YXIiICJBZ3VzdMOtbiIgIkFkcmlhbiIgIkVsaSIpCisgICAgICAg ICAgICAobGFtYmRhIChhIGIpCisgICAgICAgICAgICAgIChsZXQgKCh3MzItY29sbGF0ZS1p Z25vcmUtcHVuY3R1YXRpb24gdCkpCisgICAgICAgICAgICAgICAgKHN0cmluZy1jb2xsYXRl LWxlc3NwCisgICAgICAgICAgICAgICAgIGEgYiAiZW51X1VTQSIpKSkpCisgICAgICAnKCJB ZHJpYW4iICLDhnZhciIgIkFndXN0w61uIiAiRWxpIikpKSkpCiAKIChlcnQtZGVmdGVzdCBm bnMtdGVzdHMtc3RyaW5nLXZlcnNpb24tbGVzc3AgKCkKICAgKHNob3VsZCAoc3RyaW5nLXZl cnNpb24tbGVzc3AgImZvbzIucG5nIiAiZm9vMTIucG5nIikpCi0tIAoyLjE3LjAKCg== --------------DEBC4D575B79A4A93C0E5217-- ------------=_1560902042-18387-1--