GNU bug report logs - #31288
27.0.50; [PATCH] Make cairo build somewhat usable

Previous Next

Full log

Message #14 received at 31288 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Ari Roponen <ari.roponen <at> gmail.com>
Cc: 31288 <at> debbugs.gnu.org
Subject: Re: bug#31288: 27.0.50; [PATCH] Make cairo build somewhat usable
Date: Fri, 27 Apr 2018 17:55:57 +0300

> From: Ari Roponen <ari.roponen <at> gmail.com>
> Cc: 31288 <at> debbugs.gnu.org
> Date: Fri, 27 Apr 2018 17:35:58 +0300
> 
> >> -#if defined (USE_GTK) && defined (HAVE_GTK3)
> >> +      /* FIXME */
> >> +#if 0 && defined (USE_GTK) && defined (HAVE_GTK3)
> >>        if (FRAME_GTK_WIDGET (f))
> >>          {
> >>            GdkWindow *w = gtk_widget_get_window (FRAME_GTK_WIDGET (f));
> >
> > This hunk doesn't look right.  If the code in question causes some
> > trouble to a Cairo build, please ifdef it out only when USE_CAIRO is
> > defined, not unconditionally.  And if that still needs a FIXME
> > comment, please add some description of what needs to be fixed and
> > why.
> >
> 
> That hunk is inside #ifdef USE_CAIRO, like almost the whole body of
> x_update_end.

Ah, sorry I missed that.  Still, what is the FIXME there? why not
simply remove that part?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.