GNU bug report logs - #31254
gnu: qemu: Build with Python 3 and SDL 2. (+ GTK 3 frontend)

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 31254 in the body.
You can then email your comments to 31254 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Rutger Helling <rhelling <at> mykolab.com>
To: guix-patches <at> gnu.org
Subject: gnu: qemu: Build with Python 3 and SDL 2. (+ GTK 3 frontend)
Date: Wed, 25 Apr 2018 08:33:46 +0200

[Message part 1 (text/plain, inline)]

Hey Guix,

I saw QEMU was just updated to 2.12. I noticed a few things in the
release notes, namely:
* QEMU can now be built with Python 3.
* Support for SDL 1.2 is considered deprecated and will be removed
  entirely in a future release.

As a result, the first patch builds QEMU with Python 3 and SDL 2.

The second patch is optional and adds the GTK 3 frontend, which IMO
is a nice alternative to the SDL frontend.
This does increase the size of QEMU a bit. OTOH it seems unlikely that
most people who use QEMU don't already have GTK 3 installed in some
form.

[0001-gnu-qemu-Build-with-Python-3-and-SDL-2.patch (text/x-patch, attachment)]

[0002-gnu-qemu-Enable-GTK-3-frontend.patch (text/x-patch, attachment)]

[Message part 4 (application/pgp-signature, inline)]

Message #8 received at 31254 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Rutger Helling <rhelling <at> mykolab.com>, 31254 <at> debbugs.gnu.org
Subject: Re: [bug#31254] gnu: qemu: Build with Python 3 and SDL 2. (+ GTK 3
 frontend)
Date: Wed, 25 Apr 2018 13:19:13 +0200

[Message part 1 (text/plain, inline)]

Hello!

Rutger Helling <rhelling <at> mykolab.com> writes:

> Hey Guix,
>
> I saw QEMU was just updated to 2.12. I noticed a few things in the
> release notes, namely:
> * QEMU can now be built with Python 3.
> * Support for SDL 1.2 is considered deprecated and will be removed
>   entirely in a future release.
>
> As a result, the first patch builds QEMU with Python 3 and SDL 2.

Thanks for looking after this.  I didn't realize it was using SDL1!

> The second patch is optional and adds the GTK 3 frontend, which IMO
> is a nice alternative to the SDL frontend.
> This does increase the size of QEMU a bit. OTOH it seems unlikely that
> most people who use QEMU don't already have GTK 3 installed in some
> form.

Using `guix size`, stock qemu is ~916MiB, and adding gtk+ brings it to
~1131MiB.  I'm not familiar with the GTK+ frontend, would it make sense
to add it in a separate output?

Alternatively, could we replace the SDL frontend with it?

> From 2f1626d4526fee5e7a2836d811c96cc2c823ce71 Mon Sep 17 00:00:00 2001
> From: Rutger Helling <rhelling <at> mykolab.com>
> Date: Wed, 25 Apr 2018 08:13:44 +0200
> Subject: [PATCH 1/2] gnu: qemu: Build with Python 3 and SDL 2.
>
> * gnu/packages/virtualization.scm (qemu)[arguments]: Add configure-flag to build
> with Python 3.
> [inputs]: Use sdl2 instead of sdl.
> [native-inputs]: Use python instead of python <at> 2.
> * gnu/packages/virtualization.scm (qemu-minimal)[native-inputs]: Remove python
> from inherited packages and use python <at> 2 instead.
> [inputs]: Remove sdl2 instead of sdl from inherited packages.

[...]

> @@ -101,6 +101,11 @@
>         ;; boot_sector_test: assertion failed (signature == SIGNATURE): (0x00000000 == 0x0000dead)
>         #:parallel-tests? #f
>         #:configure-flags (list "--enable-usb-redir" "--enable-opengl"
> +                               ;; Remove below once Python 3 becomes the default
> +                               ;; 'python' binary.
> +                               (string-append "--python="
> +                                              (assoc-ref %build-inputs "python")
> +                                              "/bin/python3")

Note: You can use the 'python-wrapper' package, which has python3 as
"/bin/python".  Then this won't be necessary.

>                                 (string-append "--smbd="
>                                                (assoc-ref %outputs "out")
>                                                "/libexec/samba-wrapper")
> @@ -187,7 +192,7 @@ exec smbd $@")))
>         ;; ("pciutils" ,pciutils)
>         ("pixman" ,pixman)
>         ("pulseaudio" ,pulseaudio)
> -       ("sdl" ,sdl)
> +       ("sdl2" ,sdl2)
>         ("spice" ,spice)
>         ("usbredir" ,usbredir)
>         ("util-linux" ,util-linux)
> @@ -197,7 +202,7 @@ exec smbd $@")))
>      (native-inputs `(("glib:bin" ,glib "bin") ; gtester, etc.
>                       ("perl" ,perl)
>                       ("pkg-config" ,pkg-config)
> -                     ("python" ,python-2) ; incompatible with Python 3 according to error message
> +                     ("python" ,python)
>                       ("texinfo" ,texinfo)))
>      (home-page "https://www.qemu.org")
>      (synopsis "Machine emulator and virtualizer")
> @@ -231,9 +236,13 @@ server and embedded PowerPC, and S390 guests.")
>          ;; Restrict to the targets supported by Guix.
>          ''("--target-list=i386-softmmu,x86_64-softmmu,mips64el-softmmu,arm-softmmu,aarch64-softmmu"))))
>  
> +    ;; qemu-minimal-2.10 needs Python 2. Remove below once no longer necessary.
> +    (native-inputs `(("python-2" ,python-2)
> +                     ,@(fold alist-delete (package-native-inputs qemu)
> +                             '("python"))))

It's better to do this in the actual Qemu 2.10 package instead of
arbitrarily using a different Python version in "qemu-minimal" IMO.

Perhaps we should move "qemu <at> 2.10" from (gnu packages bootloaders) into
here and make this change in that package.  WDYT?  Ideally as a public
"hidden-package" so it's not visible to end users.

Can you try it?

[...]

> From a0cc0f8f5632374567ee760d629d80703ec0f41e Mon Sep 17 00:00:00 2001
> From: Rutger Helling <rhelling <at> mykolab.com>
> Date: Wed, 25 Apr 2018 08:14:33 +0200
> Subject: [PATCH 2/2] gnu: qemu: Enable GTK 3 frontend.
>
> * gnu/packages/virtualization.scm (qemu)[inputs]: Add "gettext", "gtk+" to
> inputs.
> * gnu/packages/virtualization.scm (qemu-minimal)[inputs]: Remove "gettext",
> "gtk+" from inherited inputs.

'gettext' should probably be a native-input.  That said I wonder if the
GTK frontend should be a separate output due to the ~21% size increase,
but no strong opinion.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 31254 <at> debbugs.gnu.org (full text, mbox):

From: Rutger Helling <rhelling <at> mykolab.com>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 31254 <at> debbugs.gnu.org
Subject: Re: [bug#31254] gnu: qemu: Build with Python 3 and SDL 2. (+ GTK 3
 frontend) v2
Date: Wed, 25 Apr 2018 15:26:42 +0200

[Message part 1 (text/plain, inline)]

Hello Marius, 

Thanks for the review! I've taken your suggestions into account and
updated the patches.

I don't think it's possible to seperate the GTK3 frontend, since it's
just a parameter you pass to the qemu* binaries (-display gtk instead
of -display sdl).

From my understanding if you have both GTK3 and SDL2 enabled it
defaults to GTK3. We can remove the SDL2 frontend if there are no
objections (and probably sdl from the --audio-drv-list). I just figured
it'd be nicer to enable both to give users maximum flexibility.

On Wed, 25 Apr 2018 13:19:13 +0200
Marius Bakke <mbakke <at> fastmail.com> wrote:

> Hello!
> 
> Rutger Helling <rhelling <at> mykolab.com> writes:
> 
> > Hey Guix,
> >
> > I saw QEMU was just updated to 2.12. I noticed a few things in the
> > release notes, namely:
> > * QEMU can now be built with Python 3.
> > * Support for SDL 1.2 is considered deprecated and will be removed
> >   entirely in a future release.
> >
> > As a result, the first patch builds QEMU with Python 3 and SDL 2.  
> 
> Thanks for looking after this.  I didn't realize it was using SDL1!
> 
> > The second patch is optional and adds the GTK 3 frontend, which IMO
> > is a nice alternative to the SDL frontend.
> > This does increase the size of QEMU a bit. OTOH it seems unlikely
> > that most people who use QEMU don't already have GTK 3 installed in
> > some form.  
> 
> Using `guix size`, stock qemu is ~916MiB, and adding gtk+ brings it to
> ~1131MiB.  I'm not familiar with the GTK+ frontend, would it make
> sense to add it in a separate output?
> 
> Alternatively, could we replace the SDL frontend with it?
> 
> > From 2f1626d4526fee5e7a2836d811c96cc2c823ce71 Mon Sep 17 00:00:00
> > 2001 From: Rutger Helling <rhelling <at> mykolab.com>
> > Date: Wed, 25 Apr 2018 08:13:44 +0200
> > Subject: [PATCH 1/2] gnu: qemu: Build with Python 3 and SDL 2.
> >
> > * gnu/packages/virtualization.scm (qemu)[arguments]: Add
> > configure-flag to build with Python 3.
> > [inputs]: Use sdl2 instead of sdl.
> > [native-inputs]: Use python instead of python <at> 2.
> > * gnu/packages/virtualization.scm (qemu-minimal)[native-inputs]:
> > Remove python from inherited packages and use python <at> 2 instead.
> > [inputs]: Remove sdl2 instead of sdl from inherited packages.  
> 
> [...]
> 
> > @@ -101,6 +101,11 @@
> >         ;; boot_sector_test: assertion failed (signature ==
> > SIGNATURE): (0x00000000 == 0x0000dead) #:parallel-tests? #f
> >         #:configure-flags (list "--enable-usb-redir"
> > "--enable-opengl"
> > +                               ;; Remove below once Python 3
> > becomes the default
> > +                               ;; 'python' binary.
> > +                               (string-append "--python="
> > +                                              (assoc-ref
> > %build-inputs "python")
> > +                                              "/bin/python3")  
> 
> Note: You can use the 'python-wrapper' package, which has python3 as
> "/bin/python".  Then this won't be necessary.
> 
> >                                 (string-append "--smbd="
> >                                                (assoc-ref %outputs
> > "out") "/libexec/samba-wrapper")
> > @@ -187,7 +192,7 @@ exec smbd $@")))
> >         ;; ("pciutils" ,pciutils)
> >         ("pixman" ,pixman)
> >         ("pulseaudio" ,pulseaudio)
> > -       ("sdl" ,sdl)
> > +       ("sdl2" ,sdl2)
> >         ("spice" ,spice)
> >         ("usbredir" ,usbredir)
> >         ("util-linux" ,util-linux)
> > @@ -197,7 +202,7 @@ exec smbd $@")))
> >      (native-inputs `(("glib:bin" ,glib "bin") ; gtester, etc.
> >                       ("perl" ,perl)
> >                       ("pkg-config" ,pkg-config)
> > -                     ("python" ,python-2) ; incompatible with
> > Python 3 according to error message
> > +                     ("python" ,python)
> >                       ("texinfo" ,texinfo)))
> >      (home-page "https://www.qemu.org")
> >      (synopsis "Machine emulator and virtualizer")
> > @@ -231,9 +236,13 @@ server and embedded PowerPC, and S390 guests.")
> >          ;; Restrict to the targets supported by Guix.
> >          ''("--target-list=i386-softmmu,x86_64-softmmu,mips64el-softmmu,arm-softmmu,aarch64-softmmu"))))
> >  
> > +    ;; qemu-minimal-2.10 needs Python 2. Remove below once no
> > longer necessary.
> > +    (native-inputs `(("python-2" ,python-2)
> > +                     ,@(fold alist-delete (package-native-inputs
> > qemu)
> > +                             '("python"))))  
> 
> It's better to do this in the actual Qemu 2.10 package instead of
> arbitrarily using a different Python version in "qemu-minimal" IMO.
> 
> Perhaps we should move "qemu <at> 2.10" from (gnu packages bootloaders)
> into here and make this change in that package.  WDYT?  Ideally as a
> public "hidden-package" so it's not visible to end users.
> 
> Can you try it?
> 
> [...]
> 
> > From a0cc0f8f5632374567ee760d629d80703ec0f41e Mon Sep 17 00:00:00
> > 2001 From: Rutger Helling <rhelling <at> mykolab.com>
> > Date: Wed, 25 Apr 2018 08:14:33 +0200
> > Subject: [PATCH 2/2] gnu: qemu: Enable GTK 3 frontend.
> >
> > * gnu/packages/virtualization.scm (qemu)[inputs]: Add "gettext",
> > "gtk+" to inputs.
> > * gnu/packages/virtualization.scm (qemu-minimal)[inputs]: Remove
> > "gettext", "gtk+" from inherited inputs.  
> 
> 'gettext' should probably be a native-input.  That said I wonder if
> the GTK frontend should be a separate output due to the ~21% size
> increase, but no strong opinion.

[0001-gnu-qemu-Build-with-Python-3-and-SDL2-support.patch (text/x-patch, attachment)]

[0002-gnu-qemu-Enable-GTK3-frontend.patch (text/x-patch, attachment)]

[Message part 4 (application/pgp-signature, inline)]

Message #14 received at 31254 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Rutger Helling <rhelling <at> mykolab.com>
Cc: 31254 <at> debbugs.gnu.org
Subject: Re: [bug#31254] gnu: qemu: Build with Python 3 and SDL 2. (+ GTK 3
 frontend) v2
Date: Wed, 25 Apr 2018 15:40:34 +0200

[Message part 1 (text/plain, inline)]

Rutger Helling <rhelling <at> mykolab.com> writes:

> Hello Marius, 
>
> Thanks for the review! I've taken your suggestions into account and
> updated the patches.
>
> I don't think it's possible to seperate the GTK3 frontend, since it's
> just a parameter you pass to the qemu* binaries (-display gtk instead
> of -display sdl).
>
> From my understanding if you have both GTK3 and SDL2 enabled it
> defaults to GTK3. We can remove the SDL2 frontend if there are no
> objections (and probably sdl from the --audio-drv-list). I just figured
> it'd be nicer to enable both to give users maximum flexibility.

OK!

[...]

> From e1b40133c8aedf84090fbd4292af2b53eb22d669 Mon Sep 17 00:00:00 2001
> From: Rutger Helling <rhelling <at> mykolab.com>
> Date: Wed, 25 Apr 2018 14:59:11 +0200
> Subject: [PATCH 1/2] gnu: qemu: Build with Python 3 and SDL2 support.
>
> * gnu/packages/bootloaders.scm (qemu-minimal-2.10): Remove variable.
> * gnu/packages/virtualization.scm (qemu)[inputs]: Use sdl2 instead of sdl.
> [native-inputs]: Use python instead of python <at> 2. Add python-wrapper.
> * gnu/packages/virtualization.scm (qemu-minimal)[inputs]: Remove sdl2 instead of
> sdl from inherited packages.
> * gnu/packages/virtualization.scm (qemu-minimal-2.10): Add variable.
> [native-inputs]: Remove python from inherited packages and use python <at> 2 instead.
> ---
>  gnu/packages/bootloaders.scm    | 16 ----------------
>  gnu/packages/virtualization.scm | 30 ++++++++++++++++++++++++++----
>  2 files changed, 26 insertions(+), 20 deletions(-)

Can you adjust 'american-fuzzy-lop' to use the moved qemu-minimal-2.10
package too?  Please also drop the '@@ (gnu packages bootloaders)' stuff
and just use '(inherit qemu-minimal-2.10 ...)' now that it's public.

[...]

> @@ -187,7 +187,7 @@ exec smbd $@")))
>         ;; ("pciutils" ,pciutils)
>         ("pixman" ,pixman)
>         ("pulseaudio" ,pulseaudio)
> -       ("sdl" ,sdl)
> +       ("sdl2" ,sdl2)
>         ("spice" ,spice)
>         ("usbredir" ,usbredir)
>         ("util-linux" ,util-linux)
> @@ -197,7 +197,8 @@ exec smbd $@")))
>      (native-inputs `(("glib:bin" ,glib "bin") ; gtester, etc.
>                       ("perl" ,perl)
>                       ("pkg-config" ,pkg-config)
> -                     ("python" ,python-2) ; incompatible with Python 3 according to error message
> +                     ("python" ,python)
> +                     ("python-wrapper" ,python-wrapper)

The first "python" can be removed (only python-wrapper is necessary).

>                       ("texinfo" ,texinfo)))
>      (home-page "https://www.qemu.org")
>      (synopsis "Machine emulator and virtualizer")
> @@ -233,9 +234,30 @@ server and embedded PowerPC, and S390 guests.")
>  
>      ;; Remove dependencies on optional libraries, notably GUI libraries.
>      (inputs (fold alist-delete (package-inputs qemu)
> -                  '("libusb" "mesa" "sdl" "spice" "virglrenderer"
> +                  '("libusb" "mesa" "sdl2" "spice" "virglrenderer"
>                      "usbredir" "libdrm" "libepoxy" "pulseaudio")))))
>  
> +;; The GRUB test suite fails with later versions of Qemu, so we
> +;; keep it at 2.10 for now.  See
> +;; <https://lists.gnu.org/archive/html/bug-grub/2018-02/msg00004.html>.
> +;; TODO: When grub no longer needs this version, move to gnu/packages/debug.scm.

The TODO line can be removed too.  And maybe add a comment such as "Keep
it hidden since we don't backport security patches" or something along
those lines.

[...]

> From edea64c09dc1e0f391e860478dcf99f4d0d1a6d2 Mon Sep 17 00:00:00 2001
> From: Rutger Helling <rhelling <at> mykolab.com>
> Date: Wed, 25 Apr 2018 15:03:29 +0200
> Subject: [PATCH 2/2] gnu: qemu: Enable GTK3 frontend.
>
> * gnu/packages/virtualization.scm (qemu)[native-inputs]: Add "gettext" to native-inputs.
> [inputs]: Add "gtk+" to inputs.
> * gnu/packages/virtualization.scm (qemu-minimal)[native-inputs]: Remove "gettext"
> from inherited inputs.
> [inputs]: Remove "gtk+" from inherited inputs.

LGTM!

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 31254 <at> debbugs.gnu.org (full text, mbox):

From: Rutger Helling <rhelling <at> mykolab.com>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 31254 <at> debbugs.gnu.org
Subject: Re: [bug#31254] gnu: qemu: Build with Python 3 and SDL 2. (+ GTK 3
 frontend) v3
Date: Thu, 26 Apr 2018 08:30:06 +0200

[Message part 1 (text/plain, inline)]

Thanks again! I've made the changes, so here's another set of patches.
Note that the second patch is unchanged, just rebased.

On Wed, 25 Apr 2018 15:40:34 +0200
Marius Bakke <mbakke <at> fastmail.com> wrote:

> Rutger Helling <rhelling <at> mykolab.com> writes:
> 
> > Hello Marius, 
> >
> > Thanks for the review! I've taken your suggestions into account and
> > updated the patches.
> >
> > I don't think it's possible to seperate the GTK3 frontend, since
> > it's just a parameter you pass to the qemu* binaries (-display gtk
> > instead of -display sdl).
> >
> > From my understanding if you have both GTK3 and SDL2 enabled it
> > defaults to GTK3. We can remove the SDL2 frontend if there are no
> > objections (and probably sdl from the --audio-drv-list). I just
> > figured it'd be nicer to enable both to give users maximum
> > flexibility.  
> 
> OK!
> 
> [...]
> 
> > From e1b40133c8aedf84090fbd4292af2b53eb22d669 Mon Sep 17 00:00:00
> > 2001 From: Rutger Helling <rhelling <at> mykolab.com>
> > Date: Wed, 25 Apr 2018 14:59:11 +0200
> > Subject: [PATCH 1/2] gnu: qemu: Build with Python 3 and SDL2
> > support.
> >
> > * gnu/packages/bootloaders.scm (qemu-minimal-2.10): Remove variable.
> > * gnu/packages/virtualization.scm (qemu)[inputs]: Use sdl2 instead
> > of sdl. [native-inputs]: Use python instead of python <at> 2. Add
> > python-wrapper.
> > * gnu/packages/virtualization.scm (qemu-minimal)[inputs]: Remove
> > sdl2 instead of sdl from inherited packages.
> > * gnu/packages/virtualization.scm (qemu-minimal-2.10): Add variable.
> > [native-inputs]: Remove python from inherited packages and use
> > python <at> 2 instead. ---
> >  gnu/packages/bootloaders.scm    | 16 ----------------
> >  gnu/packages/virtualization.scm | 30 ++++++++++++++++++++++++++----
> >  2 files changed, 26 insertions(+), 20 deletions(-)  
> 
> Can you adjust 'american-fuzzy-lop' to use the moved qemu-minimal-2.10
> package too?  Please also drop the '@@ (gnu packages bootloaders)'
> stuff and just use '(inherit qemu-minimal-2.10 ...)' now that it's
> public.
> 
> [...]
> 
> > @@ -187,7 +187,7 @@ exec smbd $@")))
> >         ;; ("pciutils" ,pciutils)
> >         ("pixman" ,pixman)
> >         ("pulseaudio" ,pulseaudio)
> > -       ("sdl" ,sdl)
> > +       ("sdl2" ,sdl2)
> >         ("spice" ,spice)
> >         ("usbredir" ,usbredir)
> >         ("util-linux" ,util-linux)
> > @@ -197,7 +197,8 @@ exec smbd $@")))
> >      (native-inputs `(("glib:bin" ,glib "bin") ; gtester, etc.
> >                       ("perl" ,perl)
> >                       ("pkg-config" ,pkg-config)
> > -                     ("python" ,python-2) ; incompatible with
> > Python 3 according to error message
> > +                     ("python" ,python)
> > +                     ("python-wrapper" ,python-wrapper)  
> 
> The first "python" can be removed (only python-wrapper is necessary).
> 
> >                       ("texinfo" ,texinfo)))
> >      (home-page "https://www.qemu.org")
> >      (synopsis "Machine emulator and virtualizer")
> > @@ -233,9 +234,30 @@ server and embedded PowerPC, and S390 guests.")
> >  
> >      ;; Remove dependencies on optional libraries, notably GUI
> > libraries. (inputs (fold alist-delete (package-inputs qemu)
> > -                  '("libusb" "mesa" "sdl" "spice" "virglrenderer"
> > +                  '("libusb" "mesa" "sdl2" "spice" "virglrenderer"
> >                      "usbredir" "libdrm" "libepoxy"
> > "pulseaudio"))))) 
> > +;; The GRUB test suite fails with later versions of Qemu, so we
> > +;; keep it at 2.10 for now.  See
> > +;;
> > <https://lists.gnu.org/archive/html/bug-grub/2018-02/msg00004.html>.
> > +;; TODO: When grub no longer needs this version, move to
> > gnu/packages/debug.scm.  
> 
> The TODO line can be removed too.  And maybe add a comment such as
> "Keep it hidden since we don't backport security patches" or
> something along those lines.
> 
> [...]
> 
> > From edea64c09dc1e0f391e860478dcf99f4d0d1a6d2 Mon Sep 17 00:00:00
> > 2001 From: Rutger Helling <rhelling <at> mykolab.com>
> > Date: Wed, 25 Apr 2018 15:03:29 +0200
> > Subject: [PATCH 2/2] gnu: qemu: Enable GTK3 frontend.
> >
> > * gnu/packages/virtualization.scm (qemu)[native-inputs]: Add
> > "gettext" to native-inputs. [inputs]: Add "gtk+" to inputs.
> > * gnu/packages/virtualization.scm (qemu-minimal)[native-inputs]:
> > Remove "gettext" from inherited inputs.
> > [inputs]: Remove "gtk+" from inherited inputs.  
> 
> LGTM!

[0001-gnu-qemu-Build-with-Python-3-and-SDL2-support.patch (text/x-patch, attachment)]

[0002-gnu-qemu-Enable-GTK3-frontend.patch (text/x-patch, attachment)]

[Message part 4 (application/pgp-signature, inline)]

Message #20 received at 31254 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Rutger Helling <rhelling <at> mykolab.com>
Cc: 31254 <at> debbugs.gnu.org
Subject: Re: [bug#31254] gnu: qemu: Build with Python 3 and SDL 2. (+ GTK 3
 frontend) v3
Date: Thu, 26 Apr 2018 12:22:54 +0200

[Message part 1 (text/plain, inline)]

Rutger Helling <rhelling <at> mykolab.com> writes:

> Thanks again! I've made the changes, so here's another set of patches.
> Note that the second patch is unchanged, just rebased.

Excellent.  Both patches LGTM.  Thanks!

[signature.asc (application/pgp-signature, inline)]

Message #25 received at 31254-done <at> debbugs.gnu.org (full text, mbox):

From: Rutger Helling <rhelling <at> mykolab.com>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 31254-done <at> debbugs.gnu.org
Subject: Re: [bug#31254] gnu: qemu: Build with Python 3 and SDL 2. (+ GTK 3
 frontend) v3
Date: Thu, 26 Apr 2018 12:54:40 +0200

[Message part 1 (text/plain, inline)]

I pushed the patches. Thanks again for the help!

On Thu, 26 Apr 2018 12:22:54 +0200
Marius Bakke <mbakke <at> fastmail.com> wrote:

> Rutger Helling <rhelling <at> mykolab.com> writes:
> 
> > Thanks again! I've made the changes, so here's another set of
> > patches. Note that the second patch is unchanged, just rebased.  
> 
> Excellent.  Both patches LGTM.  Thanks!

[Message part 2 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.