GNU bug report logs - #31252
[PATCH] gnu: Add Ranger.

Previous Next

Full log

Message #8 received at 31252 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Eric Bavier <ericbavier <at> centurylink.net>
Cc: 31252 <at> debbugs.gnu.org
Subject: Re: [bug#31252] [PATCH] gnu: Add Ranger.
Date: Wed, 25 Apr 2018 23:09:39 +0200

Eric Bavier <ericbavier <at> centurylink.net> skribis:

> From 03abb95c7e551ea45d0742bf72cb78e5f0ce210e Mon Sep 17 00:00:00 2001
> From: Eric Bavier <ericbavier <at> centurylink.net>
> Date: Tue, 24 Apr 2018 18:44:38 -0500
> Subject: [PATCH] gnu: Add Ranger.
> To: guix-patches <at> gnu.org
>
> From: Eric Bavier <bavier <at> member.fsf.org>
>
> * gnu/packages/disk.scm (ranger): New variable.

[...]

> +(define-public ranger
> +  (package
> +    (name "ranger")
> +    (version "1.9.1")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://ranger.github.io/"
> +                                  "ranger-" version ".tar.gz"))
> +              (sha256
> +               (base32
> +
> "1lnzkrxcnlwnyi3z0v8ybyp8d5rm26qm35rr68kbs2lbs06inha0"))))

Patch was mangled.  :-)

> +    (build-system python-build-system)
> +    (native-inputs                      ;for tests
> +     `(("python-pytest" ,python-pytest)
> +       ("python-pylint" ,python-pylint)
> +       ("python-flake8" ,python-flake8)
> +       ("which" ,which)))
> +    (arguments
> +     '(#:phases (modify-phases %standard-phases
> +                  (replace 'check
> +                    (lambda _ (invoke "make" "test"))))))

You can use #:test-target "test" instead.

> +    (home-page "https://ranger.github.io/")
> +    (synopsis "Console file manager")
> +    (description "@code{ranger} is a console file manager with VI key

Nitpick: “Ranger” (or “ranger”?) and “Vi”.

I haven’t tried using it, but otherwise LGTM.  Thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.