GNU bug report logs - #31252
[PATCH] gnu: Add Ranger.

Previous Next

Full log

Message #13 received at 31252-done <at> debbugs.gnu.org (full text, mbox):

From: Eric Bavier <ericbavier <at> centurylink.net>
To: 31252-done <at> debbugs.gnu.org
Subject: Re: [bug#31252] [PATCH] gnu: Add Ranger.
Date: Thu, 26 Apr 2018 21:11:13 -0500

[Message part 1 (text/plain, inline)]

On Wed, 25 Apr 2018 23:09:39 +0200
ludo <at> gnu.org (Ludovic Courtès) wrote:

> Eric Bavier <ericbavier <at> centurylink.net> skribis:
> 
> > +    (arguments
> > +     '(#:phases (modify-phases %standard-phases
> > +                  (replace 'check
> > +                    (lambda _ (invoke "make" "test"))))))  
> 
> You can use #:test-target "test" instead.
> 
> > +    (home-page "https://ranger.github.io/")
> > +    (synopsis "Console file manager")
> > +    (description "@code{ranger} is a console file manager with VI key  
> 
> Nitpick: “Ranger” (or “ranger”?) and “Vi”.
> 
> I haven’t tried using it, but otherwise LGTM.  Thanks!

Thanks for the review.

Pushed in 834b0b9a5ca7ebd2cd3c1b2fe8dcb99e5e2f0841 and
adfc742c420f34ecf925ea00d49204f9863bce33 (forgot to apply fixes before pushing ... oops).

`~Eric

[Message part 2 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.