From unknown Sun Jun 22 11:42:35 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#31240 <31240@debbugs.gnu.org> To: bug#31240 <31240@debbugs.gnu.org> Subject: Status: mouse commands not aware of rectangle regions Reply-To: bug#31240 <31240@debbugs.gnu.org> Date: Sun, 22 Jun 2025 18:42:35 +0000 retitle 31240 mouse commands not aware of rectangle regions reassign 31240 emacs submitter 31240 charles@aurox.ch (Charles A. Roelli) severity 31240 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 22 14:34:40 2018 Received: (at submit) by debbugs.gnu.org; 22 Apr 2018 18:34:40 +0000 Received: from localhost ([127.0.0.1]:36018 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fAJou-0002JV-Ca for submit@debbugs.gnu.org; Sun, 22 Apr 2018 14:34:40 -0400 Received: from eggs.gnu.org ([208.118.235.92]:47108) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fAJos-0002JF-JF for submit@debbugs.gnu.org; Sun, 22 Apr 2018 14:34:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fAJom-0005MO-JH for submit@debbugs.gnu.org; Sun, 22 Apr 2018 14:34:33 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:43154) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fAJom-0005MG-GR for submit@debbugs.gnu.org; Sun, 22 Apr 2018 14:34:32 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38072) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fAJol-00016H-Bs for bug-gnu-emacs@gnu.org; Sun, 22 Apr 2018 14:34:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fAJoi-0005Iv-3i for bug-gnu-emacs@gnu.org; Sun, 22 Apr 2018 14:34:31 -0400 Received: from sinyavsky.aurox.ch ([37.35.109.145]:56567) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fAJoh-0005DM-Tm for bug-gnu-emacs@gnu.org; Sun, 22 Apr 2018 14:34:28 -0400 Received: from sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) by sinyavsky.aurox.ch (Postfix) with ESMTP id A032E2271A for ; Sun, 22 Apr 2018 18:35:42 +0000 (UTC) Authentication-Results: sinyavsky.aurox.ch (amavisd-new); dkim=pass (1024-bit key) reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= subject:subject:to:from:from:message-id:date:date; s=dkim; t= 1524422142; x=1525286143; bh=5VlScR+YF5qmoNtNp4g0Ydl0EBPpGGb5Lho VmWC04GQ=; b=F0Dn0oSYbC5utXd+MK1TPWElNMyxLb0QxgmKChbngm+TavoRpGY I1L5mSUdhlnoLJ7M8YYAyr8tod093a6wkAQ+3fW08Loj5nfSM66boZdvIhmcBgAD H2rR3XJIo9KgEjLT4Ux6QG4gaZ7pJvR4ngB/19S8y+7r4jXzS6n+a+kc= X-Virus-Scanned: Debian amavisd-new at test.virtualizor.com Received: from sinyavsky.aurox.ch ([127.0.0.1]) by sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id B0XZtIxhCel6 for ; Sun, 22 Apr 2018 18:35:42 +0000 (UTC) Received: from gray (202.100.1.85.dynamic.wline.res.cust.swisscom.ch [85.1.100.202]) by sinyavsky.aurox.ch (Postfix) with ESMTPSA id 394AE226F4 for ; Sun, 22 Apr 2018 18:35:42 +0000 (UTC) Date: Sun, 22 Apr 2018 20:35:02 +0200 Message-Id: From: charles@aurox.ch (Charles A. Roelli) To: bug-gnu-emacs@gnu.org Subject: 26.1; mouse-save-then-kill does not kill rectangles X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.1 (-----) >From emacs -Q: C-x SPC mouse-3 on the space after ";; This" mouse-3 again on the same spot You're left with just ";; This". It looks like the region is being killed as a normal region (between point and mark) instead of as a rectangle. From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 19 22:27:28 2018 Received: (at 31240) by debbugs.gnu.org; 20 Aug 2018 02:27:28 +0000 Received: from localhost ([127.0.0.1]:54957 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1frZuh-0006nM-QZ for submit@debbugs.gnu.org; Sun, 19 Aug 2018 22:27:27 -0400 Received: from mail-it0-f45.google.com ([209.85.214.45]:51701) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1frZuf-0006n6-9R for 31240@debbugs.gnu.org; Sun, 19 Aug 2018 22:27:25 -0400 Received: by mail-it0-f45.google.com with SMTP id e14-v6so18611911itf.1 for <31240@debbugs.gnu.org>; Sun, 19 Aug 2018 19:27:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=q5rXgvWKIXZtlMbc/wGuphMfLipjv079cPoglL7Z2pg=; b=meU/OyWbcPB/0Ww6ygAZBpanOd7TcvYzk8iKEerNrLinWoUbTS+LSvOgnJsUnSQLxd NdN+vitzqe6teEZx3LUiSt2IapFcRMHneUqw/FlmqjNPlIX3m92AbNQPnn0d/d9Umc9P fKquR0fCc+QJ6eAJ+f9fSurSFO9lD4WBkUeaEjHzHZBhXIqYPZ5KVBqvYPpn5wMaYjMr y5rg2xZiq5HuOSgIM5DE8RU0g9sCNG1UFEn+V/y1QVpGdNoQrO5fIsiONeZiMMMkV5LH +sBcITU1Y8czoQlYu61Hu75VfvWqW3ItDSi3Nu94a3Z2gEh8ULbRpYD2wjUmINzvpe+W I4Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=q5rXgvWKIXZtlMbc/wGuphMfLipjv079cPoglL7Z2pg=; b=IHOIt1reqjfaYerF72KtL30iz5xKAKhlPUf6Ak4cXHOEnBlXZityecR4tX2mnYrre9 C3KNqHNG2o3twoIPTSlOHSe3PgZsTPkEyvVdIQ90mZnF9DQNuo9LL61dNO//hfbKVEvP 8SfiKX+dgIWMsZTrtde0ureqfnjbdSq+6ttFYqjXXgMQPVs2CtFYPbJqTobQ15xW8UMi sj7bhUycY5RArfaegRvqCGGg6VyZ6vz5wt9YvLRvSIqkcrHNpAzD7N6YLU4mbItPtAOk gm3slvgqQY5WVbgTfFTP6yPKVpvcEO+tMRiaXh8WbQWvU571TFpM7yR034Jn27bkWOv3 V2yA== X-Gm-Message-State: AOUpUlGuZT6C8mzpyTTYX3CBGlW+xp9tbOpNdvvQac3ZZNJB1QK4/FE6 c0Zxbq2QKN/P43efTGhbYkTuY1IbI42TafmvenycjRQr X-Google-Smtp-Source: AA+uWPxbQxEw79uyX/gWd/hzPtyl84WojdjHRnNcPzN1U3O1kNvlr2ts8mJEwnPIuLsZE5gUzV20KTisWFUSU73XccE= X-Received: by 2002:a02:9832:: with SMTP id t47-v6mr3877623jaj.137.1534732039771; Sun, 19 Aug 2018 19:27:19 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:ac0:ae6e:0:0:0:0:0 with HTTP; Sun, 19 Aug 2018 19:26:59 -0700 (PDT) From: Federico Tedin Date: Sun, 19 Aug 2018 23:26:59 -0300 Message-ID: Subject: Re: bug#31240: 26.1; mouse-save-then-kill does not kill rectangles To: charles@aurox.ch Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 31240 Cc: 31240@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) I've looked into this bug. Its seems like the problem is in mouse.el, where line 1610 could be changed from: (kill-region (mark t) (point))) to: (kill-region (mark t) (point) 'region)) Which would make kill-region use the (potentially rectangular) region instead of BEG and END. The problem is, many mouse-related functions still use functions such as filter-buffer-substring and delete-region, which are not rectangular-region aware. Would submitting a patch for this line only make sense? From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 30 16:06:41 2018 Received: (at 31240) by debbugs.gnu.org; 30 Aug 2018 20:06:41 +0000 Received: from localhost ([127.0.0.1]:39446 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fvTDF-00018D-Aa for submit@debbugs.gnu.org; Thu, 30 Aug 2018 16:06:41 -0400 Received: from sinyavsky.aurox.ch ([37.35.109.145]:58983) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fvTDD-00017z-Ic for 31240@debbugs.gnu.org; Thu, 30 Aug 2018 16:06:40 -0400 Received: from sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) by sinyavsky.aurox.ch (Postfix) with ESMTP id DF1302283D for <31240@debbugs.gnu.org>; Thu, 30 Aug 2018 20:10:00 +0000 (UTC) Authentication-Results: sinyavsky.aurox.ch (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= references:subject:subject:in-reply-to:to:from:from:message-id :date:date; s=dkim; t=1535659799; x=1536523800; bh=qdDOwkiuwTf70 0VVS2WCgw5kyuwPOKIZ2y4aXDVoioE=; b=fLn6I5tXtUZ/fg2I/fLlH1Qn9/ReK ZudAofe2j6IQ8Dk143kZ68/O0hMrXHsbgLuYJ87LKl2D+0YWAGd5UF46DEwr6Kt+ 2GLQfVxWXJFHD5uAv6wP3jt+RDvf2PKfx7o/7CoDPy2Plca/2ZE4K6O/LqBcE7Aw oHDADppOgN4FDc= X-Virus-Scanned: Debian amavisd-new at test.virtualizor.com Received: from sinyavsky.aurox.ch ([127.0.0.1]) by sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 6EBpiDfDqTjI for <31240@debbugs.gnu.org>; Thu, 30 Aug 2018 20:09:59 +0000 (UTC) Received: from gray (214.50.105.92.dynamic.wline.res.cust.swisscom.ch [92.105.50.214]) by sinyavsky.aurox.ch (Postfix) with ESMTPSA id A00472280B; Thu, 30 Aug 2018 20:09:59 +0000 (UTC) Date: Thu, 30 Aug 2018 22:06:50 +0200 Message-Id: From: charles@aurox.ch (Charles A. Roelli) To: Federico Tedin In-reply-to: (message from Federico Tedin on Sun, 19 Aug 2018 23:26:59 -0300) Subject: Re: bug#31240: 26.1; mouse-save-then-kill does not kill rectangles References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 31240 Cc: 31240@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Federico Tedin > Date: Sun, 19 Aug 2018 23:26:59 -0300 > > I've looked into this bug. Its seems like the problem is in mouse.el, > where line 1610 could be changed from: > > (kill-region (mark t) (point))) > > to: > > (kill-region (mark t) (point) 'region)) > > Which would make kill-region use the (potentially rectangular) region > instead of BEG and END. The problem is, many mouse-related functions > still use functions such as filter-buffer-substring and delete-region, > which are not rectangular-region aware. Would submitting a patch for > this line only make sense? Thanks for looking into this. It would be great to squash all these problems with one patch to get a consistent behavior. I will retitle the bug to make that clearer. From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 01 13:48:46 2018 Received: (at control) by debbugs.gnu.org; 1 Sep 2018 17:48:46 +0000 Received: from localhost ([127.0.0.1]:42095 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fwA0r-0001Et-V5 for submit@debbugs.gnu.org; Sat, 01 Sep 2018 13:48:46 -0400 Received: from sinyavsky.aurox.ch ([37.35.109.145]:60255) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fwA0q-0001Ed-ER for control@debbugs.gnu.org; Sat, 01 Sep 2018 13:48:44 -0400 Received: from sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) by sinyavsky.aurox.ch (Postfix) with ESMTP id 8DBE522828 for ; Sat, 1 Sep 2018 17:52:07 +0000 (UTC) Authentication-Results: sinyavsky.aurox.ch (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= subject:subject:to:from:from:message-id:date:date; s=dkim; t= 1535824327; x=1536688328; bh=mdP2CUifpZhV/A0358OF92ttTqefijgOCwQ Gtmp2fUQ=; b=JAAh5FyvXGzUr8o4IWrK3jfvMzOoXPzgGzAGu1ZWp8yMbueaRzl X8SrBGbrMluOFgZaxhlvZ2+NGIk25sbKBwVIz3fwgMirDHNrQ/EtfagbgE18Bm5t KiEFFcOTNmW56PqkFfMbF1jsVSIH+8YYyizedNfs8gc5a7gEp08+j6lQ= X-Virus-Scanned: Debian amavisd-new at test.virtualizor.com Received: from sinyavsky.aurox.ch ([127.0.0.1]) by sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id iw-iXLPii9d1 for ; Sat, 1 Sep 2018 17:52:07 +0000 (UTC) Received: from gray (unknown [IPv6:2a02:1205:c693:2d60:c62c:3ff:fe30:b864]) by sinyavsky.aurox.ch (Postfix) with ESMTPSA id E0BCB2280B for ; Sat, 1 Sep 2018 17:52:06 +0000 (UTC) Date: Sat, 01 Sep 2018 19:49:01 +0200 Message-Id: From: charles@aurox.ch (Charles A. Roelli) To: control@debbugs.gnu.org Subject: retitle 31240 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) retitle 31240 mouse commands not aware of rectangle regions From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 11 20:40:04 2018 Received: (at 31240) by debbugs.gnu.org; 12 Sep 2018 00:40:04 +0000 Received: from localhost ([127.0.0.1]:37462 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fztCN-0005uz-Ok for submit@debbugs.gnu.org; Tue, 11 Sep 2018 20:40:04 -0400 Received: from mail-it0-f43.google.com ([209.85.214.43]:53595) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fztCL-0005uN-MV for 31240@debbugs.gnu.org; Tue, 11 Sep 2018 20:40:01 -0400 Received: by mail-it0-f43.google.com with SMTP id p79-v6so749858itp.3 for <31240@debbugs.gnu.org>; Tue, 11 Sep 2018 17:40:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4ohkKhXiWs6zVf69jmLrOv/oc8Q2dR8TdnUh5h2TquY=; b=hnyigVrci8ItrTJEkli+vC2TYYGcs7M89EMCsItz8Y8nXXcCO+VP2z94mruBdna8FQ xYKRH+WLIBqBXQ37qeKCE3RVkxn1h2+NLcsRMuxPs2VD7Z9biPY0+rzey7zprwS4T8na fS44abWm63tj1yXal64iqNOQD94Et3GIiiTbDeTwSzg2Z4cP2EzSAyMMAPN/WyVAlldz 6DQphf0YB7C+QBr+8AC1nzvL4QGKyAkBVkEz3OOC3rqhI0g9HI7mhZI4MhEQ0H7oSEpE UPDPYNlwobDRqA/1of25NQlFViuEDO3B+LtfIYE5jyaGtr+af39e2HptDxjFEfvgV+6r bGgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4ohkKhXiWs6zVf69jmLrOv/oc8Q2dR8TdnUh5h2TquY=; b=SqpypytZ0y4yBk+3/PcmrESQwrhX2ynAYcMVPtifafOUZ+OAE1L+N7zp5kW49QLLI3 LanrOMmkjrAj5qJR2P5m3XL6J7h66okQVRCKZXLqcQYimi1O64mlmJ7xTn7ItYUMk67B iDco0vDodAKAcbOux576O8kRGGQgyPIwFJiiDiKd6yhv+hJOhbyRnreEqOZXSOh8YfVy C4oeHEkDkP/idoC9pkIM04z8rogjlYAJp/cJ3lCy43GHqjTZnDFXVxuGG1KR5Y5SdFKh FekOiYRzCEnMOFQbUygUAv/mcu0RiK+3GhqtDaMBw3wp9jr9BLrDwq/gQ83PXunK6yZE QNfw== X-Gm-Message-State: APzg51D9ZpYw2D97/+W5sIqlfzjWdVPaEU8IjYOrsTGYXg29/w6mjBvL NP5cklL+4pT3DnZW6/tm9eMLU7Gfio8zPyk03Gmz8piR X-Google-Smtp-Source: ANB0VdZr9GTNujY+IWs3KurYpkdbBOUl0OGau7sXMogJn5twt/FDzFmt1x2QFTJOOQ099SJq1DfOaJf8YBLW8LKXUz8= X-Received: by 2002:a24:1d52:: with SMTP id 79-v6mr3775621itj.142.1536712795970; Tue, 11 Sep 2018 17:39:55 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Federico Tedin Date: Tue, 11 Sep 2018 21:39:44 -0300 Message-ID: Subject: Re: bug#31240: 26.1; mouse-save-then-kill does not kill rectangles To: charles@aurox.ch Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31240 Cc: 31240@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Thanks for looking into this. It would be great to squash all these > problems with one patch to get a consistent behavior. I will retitle > the bug to make that clearer. Sorry for the delay, I never received your email for some reason. I'll check if I can find more problems related to mouse + rectangular region. If I find a way to fix them, I'll submit a patch which would also cover the issue originally brought up in this bug report. From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 12 14:13:02 2018 Received: (at 31240) by debbugs.gnu.org; 12 Sep 2018 18:13:02 +0000 Received: from localhost ([127.0.0.1]:38475 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g09dO-0005Qx-H6 for submit@debbugs.gnu.org; Wed, 12 Sep 2018 14:13:02 -0400 Received: from sinyavsky.aurox.ch ([37.35.109.145]:39544) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g09dM-0005QR-Lt for 31240@debbugs.gnu.org; Wed, 12 Sep 2018 14:13:01 -0400 Received: from sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) by sinyavsky.aurox.ch (Postfix) with ESMTP id 4466D22859 for <31240@debbugs.gnu.org>; Wed, 12 Sep 2018 18:16:34 +0000 (UTC) Authentication-Results: sinyavsky.aurox.ch (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= references:subject:subject:in-reply-to:to:from:from:message-id :date:date; s=dkim; t=1536776193; x=1537640194; bh=4rxdB51vz9clF pcfgOzRqwWk83//H5TA3K7kDIdDfzU=; b=AhGNHssAWxhHAhL8f/3NG+DKuzBMv clNIhGZeKihD7suvIzCZJqeVnouNmld81Nt+5kg8CLNMSVZHMiMiyJoifpfKeLq7 bsnkuOoR59VMYAf2+KrBnS6gu7ym7/x2rnJliBwEPO+O+xx9s5+RbIHbJpI/A+W4 YsXgbyFgQerVY4= X-Virus-Scanned: Debian amavisd-new at test.virtualizor.com Received: from sinyavsky.aurox.ch ([127.0.0.1]) by sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 5_voZgTrM_SJ for <31240@debbugs.gnu.org>; Wed, 12 Sep 2018 18:16:33 +0000 (UTC) Received: from gray (unknown [IPv6:2a02:1205:c693:2d60:c62c:3ff:fe30:b864]) by sinyavsky.aurox.ch (Postfix) with ESMTPSA id 0207E2283D; Wed, 12 Sep 2018 18:16:32 +0000 (UTC) Date: Wed, 12 Sep 2018 20:14:19 +0200 Message-Id: From: charles@aurox.ch (Charles A. Roelli) To: Federico Tedin In-reply-to: (message from Federico Tedin on Tue, 11 Sep 2018 21:39:44 -0300) Subject: Re: bug#31240: 26.1; mouse-save-then-kill does not kill rectangles References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 31240 Cc: 31240@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Federico Tedin > Date: Tue, 11 Sep 2018 21:39:44 -0300 > > > Thanks for looking into this. It would be great to squash all these > > problems with one patch to get a consistent behavior. I will retitle > > the bug to make that clearer. > > Sorry for the delay, I never received your email for some reason. My bad; it bounced and I forgot to resend it. > I'll check if I can find more problems related to mouse + rectangular > region. If I find > a way to fix them, I'll submit a patch which would also cover the > issue originally brought > up in this bug report. Thanks! From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 22 16:05:40 2018 Received: (at 31240) by debbugs.gnu.org; 22 Sep 2018 20:05:40 +0000 Received: from localhost ([127.0.0.1]:49916 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g3o9s-0003F1-58 for submit@debbugs.gnu.org; Sat, 22 Sep 2018 16:05:40 -0400 Received: from mail-io1-f46.google.com ([209.85.166.46]:39340) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g3o9p-0003Eo-Q7 for 31240@debbugs.gnu.org; Sat, 22 Sep 2018 16:05:38 -0400 Received: by mail-io1-f46.google.com with SMTP id l7-v6so14940958iok.6 for <31240@debbugs.gnu.org>; Sat, 22 Sep 2018 13:05:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dqoOR/2sOrkNafQIhuJGUZESbi39OfumppF8vShjuDE=; b=Pad+3ZxytH0nv8mLpip+xln7E7Y4eXYztEdcnzDE1QtLnvhPgb3HdYsKG/0MvEdxFW l/XaOI/V9fnOui7Lkh+2bPjzwONuO686dIXsh7YCsPOOzQZKyrxh3I7phLwc9/7BsIek PDeklwI9tQAesxbap58F5YT5A9e+ubrPSRvnNrmJQzL5R/SLQbW23JLSWekz7dpw3yEa i7OdFEO/V9thli/AOQwG4u0CLXFFMXOyVEo+SaratRGksuNSp5hV5WugJ13V8I2JwALJ 6HiNE2G5tgn9/ucfJNepEuqWbkPikIdquAZS3rhtYdk2rotXx+IBO7SUeXoWFg4KK7vz b8ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dqoOR/2sOrkNafQIhuJGUZESbi39OfumppF8vShjuDE=; b=I7CGHXcVypUjPBYOxCjqfB47knn98pgFcvXqra6PkwHuNAUBV5pWlelyVo7afOR2iS zmJ1a1VcllzfA19r8ShljdKMLLc4YRYLvXl/DDz2CcDI/EAXZ+b5wmIk4iesPmqpxcgu NC01hhf6o6KsMo9u4qJMqd+KC0aENp+DyuI2vK68M65yCwgNkSv60GtvluRNp01NBgks kRQQUl1R6Zcy+i7bbHKkKW6XBMvWhLxJ8egwfdG5IUOZEQhI7z5I75/5c4rNqLGbSJvB QdTroK8qiHD7WZuBstim+7S5uBZrxbqkyf9VJSleaTY5r6w5f4W/HmCKIJGc4C1mzjV0 hsmQ== X-Gm-Message-State: ABuFfogiANuRkZ0nhVLftbdjnqDAKk5E2/qzv9DX8yScFs41pXrQVnqG YGWYyj3PhHlMF2gaE82pc3F+f+lvl+5gFF1QZyDE4izj X-Google-Smtp-Source: ACcGV60VdFLSSl/xPqq8DPxOUTSzEzAd1tefoN4WHazb6XY1P7j0OESniJFU3tMy/l+STIg/BqDR6Rs6Tbunspx2WzE= X-Received: by 2002:a6b:9ad4:: with SMTP id c203-v6mr2895113ioe.63.1537646732099; Sat, 22 Sep 2018 13:05:32 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Federico Tedin Date: Sat, 22 Sep 2018 17:05:19 -0300 Message-ID: Subject: Re: bug#31240: 26.1; mouse-save-then-kill does not kill rectangles To: charles@aurox.ch Content-Type: multipart/mixed; boundary="00000000000042817005767b47fd" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31240 Cc: 31240@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000042817005767b47fd Content-Type: text/plain; charset="UTF-8" After reading more of the code in mouse.el, I found that mouse-save-then-kill is the only function that allows using the mouse to set/resize rectangular regions. I'm attaching a patch that fixes all three use cases for this function: setting the region initially, resizing the region, and killing the region. I've also made sure it works correctly when mouse-drag-copy-region is set to t. Hope it helps. --00000000000042817005767b47fd Content-Type: text/x-patch; charset="US-ASCII"; name="mouse.patch" Content-Disposition: attachment; filename="mouse.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jmdv4zo30 RnJvbSAzMTc1OThhNTc5ZDk1Y2EzNGRlZjQ0MGQyYjc3ODlhYmRjZDFhZDQ3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBGZWRlcmljbyBUZWRpbiA8ZmVkZXJpY290ZWRpbkBnbWFpbC5j b20+CkRhdGU6IFNhdCwgMjIgU2VwIDIwMTggMTY6NTE6NTggLTAzMDAKU3ViamVjdDogW1BBVENI IDEvMV0gTWFrZSBtb3VzZS1zYXZlLXRoZW4ta2lsbCB3b3JrIHdpdGggUmVjdGFuZ2xlIE1hcmsg bW9kZQoKKiBsaXNwL21vdXNlLmVsIChtb3VzZS1zYXZlLXRoZW4ta2lsbCk6IE1ha2UgbW91c2Ut c2F2ZS10aGVuLWtpbGwgd29yawogIHdpdGggcmVjdGFuZ3VsYXIgcmVnaW9ucywgaW5jbHVkaW5n IHdoZW4gbW91c2UtZHJhZy1jb3B5LXJlZ2lvbiBpcwogIHNldCB0byB0LiAoQnVnIzMxMjQwKQot LS0KIGxpc3AvbW91c2UuZWwgfCA2ICsrKy0tLQogMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9u cygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL21vdXNlLmVsIGIvbGlzcC9t b3VzZS5lbAppbmRleCBkNWMxMzJmNDg0Li43N2UyZmU3NTIwIDEwMDY0NAotLS0gYS9saXNwL21v dXNlLmVsCisrKyBiL2xpc3AvbW91c2UuZWwKQEAgLTE2MDYsOCArMTYwNiw4IEBAIG1vdXNlLXNh dmUtdGhlbi1raWxsCiAgICAgICAoaWYgbW91c2UtZHJhZy1jb3B5LXJlZ2lvbgogICAgICAgICAg IDs7IFJlZ2lvbiBhbHJlYWR5IHNhdmVkIGluIHRoZSBwcmV2aW91cyBjbGljazsKICAgICAgICAg ICA7OyBkb24ndCBtYWtlIGEgZHVwbGljYXRlIGVudHJ5LCBqdXN0IGRlbGV0ZS4KLSAgICAgICAg ICAoZGVsZXRlLXJlZ2lvbiAobWFyayB0KSAocG9pbnQpKQotICAgICAgICAoa2lsbC1yZWdpb24g KG1hcmsgdCkgKHBvaW50KSkpCisgICAgICAgICAgKGZ1bmNhbGwgcmVnaW9uLWV4dHJhY3QtZnVu Y3Rpb24gJ2RlbGV0ZS1vbmx5KQorICAgICAgICAoa2lsbC1yZWdpb24gKG1hcmsgdCkgKHBvaW50 KSAncmVnaW9uKSkKICAgICAgIChzZXRxIG1vdXNlLXNlbGVjdGlvbi1jbGljay1jb3VudCAwKQog ICAgICAgKHNldHEgbW91c2Utc2F2ZS10aGVuLWtpbGwtcG9zbiBuaWwpKQogCkBAIC0xNjMyLDcg KzE2MzIsNyBAQCBtb3VzZS1zYXZlLXRoZW4ta2lsbAogCShtb3VzZS1zZXQtcmVnaW9uLTEpCiAg ICAgICAgICh3aGVuIG1vdXNlLWRyYWctY29weS1yZWdpb24KICAgICAgICAgICA7OyBSZWdpb24g YWxyZWFkeSBjb3BpZWQgdG8ga2lsbC1yaW5nIG9uY2UsIHNvIHJlcGxhY2UuCi0gICAgICAgICAg KGtpbGwtbmV3IChmaWx0ZXItYnVmZmVyLXN1YnN0cmluZyAobWFyayB0KSAocG9pbnQpKSB0KSkK KyAgICAgICAgICAoa2lsbC1uZXcgKGZ1bmNhbGwgcmVnaW9uLWV4dHJhY3QtZnVuY3Rpb24gbmls KSB0KSkKIAk7OyBBcnJhbmdlIGZvciBhIHJlcGVhdGVkIG1vdXNlLTMgdG8ga2lsbCB0aGUgcmVn aW9uLgogCShzZXRxIG1vdXNlLXNhdmUtdGhlbi1raWxsLXBvc24gY2xpY2stcHQpKSkKIAotLSAK Mi4xNy4xCgo= --00000000000042817005767b47fd-- From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 23 06:14:35 2018 Received: (at 31240) by debbugs.gnu.org; 23 Sep 2018 10:14:35 +0000 Received: from localhost ([127.0.0.1]:50308 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g41PP-00039G-7H for submit@debbugs.gnu.org; Sun, 23 Sep 2018 06:14:35 -0400 Received: from sinyavsky.aurox.ch ([37.35.109.145]:47527) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g41PM-000391-I2 for 31240@debbugs.gnu.org; Sun, 23 Sep 2018 06:14:33 -0400 Received: from sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) by sinyavsky.aurox.ch (Postfix) with ESMTP id 0C21F2286D for <31240@debbugs.gnu.org>; Sun, 23 Sep 2018 10:18:16 +0000 (UTC) Authentication-Results: sinyavsky.aurox.ch (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= references:subject:subject:in-reply-to:to:from:from:message-id :date:date; s=dkim; t=1537697894; x=1538561895; bh=hIRVNrDPSehrv 3J3Dn2+Xno11OPspB/+F8XTAsIFE28=; b=kDmcBpC3EDW1nSU2FP8LAFyndVpd1 2KHTKcOmFhSPQnwCAinnddezjlfCcpTgxt/R7jHEgpv8RKTi+p6d4tIqHeHLaOPU fwup5mezFH39p9yJn8QTphJw5c5dsB5omJyFZrYW0UVBnOUfI8uGhHl99k7S3/mu SBRjXWymtXBsjc= X-Virus-Scanned: Debian amavisd-new at test.virtualizor.com Received: from sinyavsky.aurox.ch ([127.0.0.1]) by sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id z2LJoXGOcn_1 for <31240@debbugs.gnu.org>; Sun, 23 Sep 2018 10:18:14 +0000 (UTC) Received: from gray (unknown [IPv6:2a02:1205:c693:2d60:c62c:3ff:fe30:b864]) by sinyavsky.aurox.ch (Postfix) with ESMTPSA id C1C5922849; Sun, 23 Sep 2018 10:18:14 +0000 (UTC) Date: Sun, 23 Sep 2018 12:16:52 +0200 Message-Id: From: charles@aurox.ch (Charles A. Roelli) To: Federico Tedin In-reply-to: (message from Federico Tedin on Sat, 22 Sep 2018 17:05:19 -0300) Subject: Re: bug#31240: 26.1; mouse-save-then-kill does not kill rectangles References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 31240 Cc: 31240@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Federico Tedin > Date: Sat, 22 Sep 2018 17:05:19 -0300 > > After reading more of the code in mouse.el, I found that > mouse-save-then-kill is the only function that allows using the mouse > to set/resize rectangular regions. I'm attaching a patch that fixes > all three use cases for this function: setting the region initially, > resizing the region, and killing the region. I've also made sure it > works correctly when mouse-drag-copy-region is set to t. Hope it helps. Thanks, this looks good. I think we also need a similar change for function "mouse-drag-and-drop-region", which is used when the variable of the same name is non-nil. For example, the following recipe exposes it: M-x set-variable RET mouse-drag-and-drop-region RET t RET M-< C-SPC M-f C-n C-x SPC Drag the rectangle region with the mouse, and its shape is ignored Hopefully we can apply the same kind of change in that function too. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 23 18:23:33 2018 Received: (at 31240) by debbugs.gnu.org; 23 Sep 2018 22:23:33 +0000 Received: from localhost ([127.0.0.1]:51183 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g4Cmr-0003Wt-BJ for submit@debbugs.gnu.org; Sun, 23 Sep 2018 18:23:33 -0400 Received: from mail-io1-f50.google.com ([209.85.166.50]:44497) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g4Cmp-0003Wh-My for 31240@debbugs.gnu.org; Sun, 23 Sep 2018 18:23:32 -0400 Received: by mail-io1-f50.google.com with SMTP id u12-v6so11187691ioc.11 for <31240@debbugs.gnu.org>; Sun, 23 Sep 2018 15:23:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vihax+6rTmreAFrpZzy0mwA5G+/jNzAxHqVx/SSJhLo=; b=HsqXnWgTTSvIUCU5ikeQLkbxJd7yl9UXVBM4Ujcj8ZHGEfmHjBZTLW7sfQhknuSK9f /HN36tSKYrUjYNRccfqTkXcAdmaF7P6zKvVnhtgMxaMU6N0wZ/WlHcz0V5d38v5t+4Am Qc87MGMbnYfslm4iVlwowEmpqxlAFkzrk+L/BXCahKZeBOAJqpY0LgIFAFZQT1h55em7 fQ1kJkg8O+3156/eto6oiT77Tpth1M0c1Mdimet8HkOnKWpHr7HcahHUgMNOAScZ0k9G xC2G37+H6cyZkC5LnA2Olk7fXMlGY8t6GuqLgKaSE3lY48C5DEPnJukEYzZnSR4gc1l/ Zk6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vihax+6rTmreAFrpZzy0mwA5G+/jNzAxHqVx/SSJhLo=; b=qZRnzjcj6xn8QR8ZeTzxHgdY69KZjHYRLIukfu2qfx+Pt1qtdAB1VGTsixHuO5HUiH rvaFRP/vQFtt/C1SNWnzZHCdxNil34SKDMNafv4JBQ5x+BGjPwhtbaG0T+2SylywtPlq DE+MhG3a+oDBvz5EG9O1geirJrV8J3YROClZI0Vk+Gw6sg7njNK0qyidzSD2zTAWMWEA ho9BpqxbUtr7xkEa2btuKmF3GDy8kxctmghugLHktG3nWjJXghvp5YUYC8YsugcPt7GI 1o3IM5Sqc4pLT6ur5J9afQCbpG0m5c9thf2jMSPyrMzxl+gdAOtCSryE2IMtx9xMtBzc rA1Q== X-Gm-Message-State: ABuFfohijfKPRjaXaFFVWO4ELTirQ1CtLihYn5V/u/0CFJwm+q835u96 C4uOIntx26xg4jv0jTYHcb2UNcw5MzFeD0k/dAyRP8E8 X-Google-Smtp-Source: ACcGV60YGVVlMAjtI7dTXFYMxan1mydP0F/p5sPdK8Cmvs1P5RzXaN31Y59e5qVE8n1UW8LHugptWr6DqQtNhJeSmco= X-Received: by 2002:a5e:8347:: with SMTP id y7-v6mr6356568iom.254.1537741406027; Sun, 23 Sep 2018 15:23:26 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Federico Tedin Date: Sun, 23 Sep 2018 19:23:13 -0300 Message-ID: Subject: Re: bug#31240: 26.1; mouse-save-then-kill does not kill rectangles To: charles@aurox.ch Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31240 Cc: 31240@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Thanks, this looks good. I think we also need a similar change for > function "mouse-drag-and-drop-region", which is used when the variable > of the same name is non-nil. For example, the following recipe > exposes it: > > M-x set-variable RET mouse-drag-and-drop-region RET t RET > M-< C-SPC M-f C-n C-x SPC > Drag the rectangle region with the mouse, and its shape is ignored > > Hopefully we can apply the same kind of change in that function too. You're right about mouse-drag-and-drop-region, it doesn't work correctly when using rectangular regions. After taking a look at the code, I managed to fix two things: the dragged text now has the correct rectangular contents (but the original text is incorrectly deleted using a normal region), and the tooltip displaying the dragged text also shows the correct contents. To fix the rest of the functionalities, I would need to know the recommended way of handling some of the details of how mouse-drag-and-drop-region is implemented: - The dragged region is tracked using an overlay. From what I understand, this is a problem since overlays only handle regions with a single beginning and end, and rectangles have one or more of those. - In order to check if the dragged text is read-only, the function "next-single-char-property-change" is used. This function has the same problem as the overlay, as it assumes the region is contiguous. I'm thinking both problems could be solved by using a list of overlays instead of just one, creating them from the result of calling "region-bounds". Then, the rest of the function could be adapted to use the overlay list. From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 24 16:01:53 2018 Received: (at 31240) by debbugs.gnu.org; 24 Sep 2018 20:01:53 +0000 Received: from localhost ([127.0.0.1]:52401 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g4X3I-0006iZ-Pz for submit@debbugs.gnu.org; Mon, 24 Sep 2018 16:01:52 -0400 Received: from sinyavsky.aurox.ch ([37.35.109.145]:48674) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g4X3H-0006iG-9z for 31240@debbugs.gnu.org; Mon, 24 Sep 2018 16:01:51 -0400 Received: from sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) by sinyavsky.aurox.ch (Postfix) with ESMTP id 1FF1D22869 for <31240@debbugs.gnu.org>; Mon, 24 Sep 2018 20:05:36 +0000 (UTC) Authentication-Results: sinyavsky.aurox.ch (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= references:subject:subject:in-reply-to:to:from:from:message-id :date:date; s=dkim; t=1537819534; x=1538683535; bh=BxZJpUm0fUrDQ JBokakY8nZzSE4G3P6h/GQEIjZuGLM=; b=hKHurQeZ9GDRqAMLP6I47xemrp/t0 y5tvABCmMM3glBpWEUgHjpFd6BRMITy2JjOdSIo6x8CP0al0diK48hieWn1uFkis gh1C43DdaSkSdcZYYAwkYVu9/nZHR3glD4rY69S2mfzcx70XmoxBFwUqveX/aPLM dBBUS8irOODOBg= X-Virus-Scanned: Debian amavisd-new at test.virtualizor.com Received: from sinyavsky.aurox.ch ([127.0.0.1]) by sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id EvEQ9kNejZV0 for <31240@debbugs.gnu.org>; Mon, 24 Sep 2018 20:05:34 +0000 (UTC) Received: from gray (unknown [IPv6:2a02:1205:c693:2d60:c62c:3ff:fe30:b864]) by sinyavsky.aurox.ch (Postfix) with ESMTPSA id B955A22866; Mon, 24 Sep 2018 20:05:34 +0000 (UTC) Date: Mon, 24 Sep 2018 22:04:16 +0200 Message-Id: From: charles@aurox.ch (Charles A. Roelli) To: Federico Tedin In-reply-to: (message from Federico Tedin on Sun, 23 Sep 2018 19:23:13 -0300) Subject: Re: bug#31240: 26.1; mouse-save-then-kill does not kill rectangles References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 31240 Cc: 31240@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Federico Tedin > Date: Sun, 23 Sep 2018 19:23:13 -0300 > > You're right about mouse-drag-and-drop-region, it doesn't work > correctly when using rectangular regions. After taking a look at the > code, I managed to fix two things: the dragged text now has the > correct rectangular contents (but the original text is incorrectly > deleted using a normal region) Would it be feasible to replace calls to "delete-region" with the right call to "region-extract-function"? Even though the current arguments to "delete-region" in "mouse-drag-and-drop-region" are based on the position of "mouse-drag-and-drop-overlay", this should not pose an issue. > , and the tooltip displaying the dragged > text also shows the correct contents. > > To fix the rest of the functionalities, I would need to know the > recommended way of handling some of the details of how > mouse-drag-and-drop-region is implemented: > > - The dragged region is tracked using an overlay. From what I > understand, this is a problem since overlays only handle regions > with a single beginning and end, and rectangles have one or more of > those. We should be able to keep using the overlay for normal regions, and adapt mouse-drag-and-drop-region to use "apply-on-rectangle" with the rectangle bounds as an argument when it needs to do something with a rectangular region. > - In order to check if the dragged text is read-only, the function > "next-single-char-property-change" is used. This function has the > same problem as the overlay, as it assumes the region is contiguous. I think "apply-on-rectangle" could be helpful here too. > I'm thinking both problems could be solved by using a list of overlays > instead of just one, creating them from the result of calling > "region-bounds". Then, the rest of the function could be adapted to > use the overlay list. Yes, this would work too. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 25 20:33:56 2018 Received: (at 31240) by debbugs.gnu.org; 26 Sep 2018 00:33:56 +0000 Received: from localhost ([127.0.0.1]:54227 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g4xm7-00028t-VK for submit@debbugs.gnu.org; Tue, 25 Sep 2018 20:33:56 -0400 Received: from mail-it1-f177.google.com ([209.85.166.177]:39249) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g4xm6-00028g-OV for 31240@debbugs.gnu.org; Tue, 25 Sep 2018 20:33:55 -0400 Received: by mail-it1-f177.google.com with SMTP id w200-v6so627481itc.4 for <31240@debbugs.gnu.org>; Tue, 25 Sep 2018 17:33:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vsvZfXJHbTH0gcSqgwifi8H0Nr8luO67tmN1clEuA8s=; b=XH4F8hvurJaKWY/cbNWz8f0LM1GZLhLEVcwXCmyRYhqUoy29coSkwz8TxvuPDhYyIe zDmDSwvb6A5UqNB+XNOaDj4upTOta1lEAGTKYC6LgF0oSWjHImhZ764RQaW5u+lpajPL LlxtWd/PzU38Nrc+g6c+RlbdA9JpSI3iJ6aAbbW7t5EkOnPG+PucLY5XxwhTdhHhS5hA A941K/u+PDe7DehPz/xGdj9CW66MGzlgR/5dymGptTY1T6rcSbNw0mVYfPREEC6khd7o 9MhaYvZEiOBQ8D2m6vNxXcxuzBXfmtVeEx1k7SZ0TeiDzcYv3wVOURRgP/YcwbwWi4Y6 8nGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vsvZfXJHbTH0gcSqgwifi8H0Nr8luO67tmN1clEuA8s=; b=qmISagzVV48c3L3w3Qx8Z4lO1HmmSQ9q3ZNYVJZKTfd+oAEGun5hQThh44keEJVp10 RrAcULL2XmidcMhod5V4WPtFOIDlxpH5Asqs3f6vJ0KCRqTaq4pea2/ICMw9murWWME4 8fkz4yfIkhcp9h6aEWSxuPeD6cE7CHcKU2n/e1oOxDr9wWhO9Es5vHrxfRClALUNnbTZ xrYRF0LKPqlYIeB9TYwviZsHtBNKltMBYm3/m57XCKVvYQ1wPc+9HMLurBbwFIqbnG0i vyaDKUFK2UWPtOP2RKqoSGKkkRqD/bIAYqAd9RYwtxnk5KDZj9jZMczJK4vjmIbXf1TT bjtg== X-Gm-Message-State: ABuFfoglUd+b8ZagfMNX6MiRL06eTsrwhAzGDvT0HZq5ElXWBosgUmLf HjNtyJvmsy2qazK/0MRawEdVdgMqNh0X5lDx0JjrJ1In X-Google-Smtp-Source: ACcGV62BbqUriMerfnxNYO9JAftJGuXLq/GwHDkU1kPoogmTIDbYA16ZQM6cTZnaHjw/wTb2rjmi5vQ/HH9Hb/6xouM= X-Received: by 2002:a02:49d7:: with SMTP id p84-v6mr3542850jad.97.1537922028947; Tue, 25 Sep 2018 17:33:48 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Federico Tedin Date: Tue, 25 Sep 2018 21:33:35 -0300 Message-ID: Subject: Re: bug#31240: 26.1; mouse-save-then-kill does not kill rectangles To: charles@aurox.ch Content-Type: multipart/mixed; boundary="0000000000003a747e0576bb60c7" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31240 Cc: 31240@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000003a747e0576bb60c7 Content-Type: text/plain; charset="UTF-8" Charles, thanks for your input. I've created a new patch which fixes the handling of rectangular regions on both mouse-save-then-kill and mouse-drag-and-drop-region (it includes the changes made in the previous patch). I'm attaching it below. --0000000000003a747e0576bb60c7 Content-Type: text/x-patch; charset="US-ASCII"; name="mouse.patch" Content-Disposition: attachment; filename="mouse.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jmif1wny0 RnJvbSBhNGE4NjVkYmRmNjAxNThjMmU4MDM2ZDU2NDMxMTUxNWEwOGY0ODMwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBGZWRlcmljbyBUZWRpbiA8ZmVkZXJpY290ZWRpbkBnbWFpbC5j b20+CkRhdGU6IFR1ZSwgMjUgU2VwIDIwMTggMjE6Mjk6MTkgLTAzMDAKU3ViamVjdDogW1BBVENI IDEvMV0gQWxsb3cgdHdvIG1vdXNlIGZ1bmN0aW9ucyB0byB3b3JrIHdpdGggUmVjdGFuZ2xlIE1h cmsKIG1vZGUKCiogbGlzcC9tb3VzZS5lbCAobW91c2Utc2F2ZS10aGVuLWtpbGwpOiBNYWtlIG1v dXNlLXNhdmUtdGhlbi1raWxsIHdvcmsKICB3aXRoIHJlY3Rhbmd1bGFyIHJlZ2lvbnMsIGluY2x1 ZGluZyB3aGVuIG1vdXNlLWRyYWctY29weS1yZWdpb24gaXMKICBzZXQgdG8gdC4gKEJ1ZyMzMTI0 MCkKICAobW91c2UtZHJhZy1hbmQtZHJvcC1yZWdpb24pOiBBbGxvdyBkcmFnZ2luZyBhbmQgZHJv cHBpbmcKICByZWN0YW5ndWxhciByZWdpb25zLgotLS0KIGxpc3AvbW91c2UuZWwgfCA3MSArKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0KIDEgZmlsZSBj aGFuZ2VkLCA0OCBpbnNlcnRpb25zKCspLCAyMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9s aXNwL21vdXNlLmVsIGIvbGlzcC9tb3VzZS5lbAppbmRleCBkNWMxMzJmNDg0Li4zNDRmMzllZGRj IDEwMDY0NAotLS0gYS9saXNwL21vdXNlLmVsCisrKyBiL2xpc3AvbW91c2UuZWwKQEAgLTE2MDYs OCArMTYwNiw4IEBAIG1vdXNlLXNhdmUtdGhlbi1raWxsCiAgICAgICAoaWYgbW91c2UtZHJhZy1j b3B5LXJlZ2lvbgogICAgICAgICAgIDs7IFJlZ2lvbiBhbHJlYWR5IHNhdmVkIGluIHRoZSBwcmV2 aW91cyBjbGljazsKICAgICAgICAgICA7OyBkb24ndCBtYWtlIGEgZHVwbGljYXRlIGVudHJ5LCBq dXN0IGRlbGV0ZS4KLSAgICAgICAgICAoZGVsZXRlLXJlZ2lvbiAobWFyayB0KSAocG9pbnQpKQot ICAgICAgICAoa2lsbC1yZWdpb24gKG1hcmsgdCkgKHBvaW50KSkpCisgICAgICAgICAgKGZ1bmNh bGwgcmVnaW9uLWV4dHJhY3QtZnVuY3Rpb24gJ2RlbGV0ZS1vbmx5KQorICAgICAgICAoa2lsbC1y ZWdpb24gKG1hcmsgdCkgKHBvaW50KSAncmVnaW9uKSkKICAgICAgIChzZXRxIG1vdXNlLXNlbGVj dGlvbi1jbGljay1jb3VudCAwKQogICAgICAgKHNldHEgbW91c2Utc2F2ZS10aGVuLWtpbGwtcG9z biBuaWwpKQogCkBAIC0xNjMyLDcgKzE2MzIsNyBAQCBtb3VzZS1zYXZlLXRoZW4ta2lsbAogCSht b3VzZS1zZXQtcmVnaW9uLTEpCiAgICAgICAgICh3aGVuIG1vdXNlLWRyYWctY29weS1yZWdpb24K ICAgICAgICAgICA7OyBSZWdpb24gYWxyZWFkeSBjb3BpZWQgdG8ga2lsbC1yaW5nIG9uY2UsIHNv IHJlcGxhY2UuCi0gICAgICAgICAgKGtpbGwtbmV3IChmaWx0ZXItYnVmZmVyLXN1YnN0cmluZyAo bWFyayB0KSAocG9pbnQpKSB0KSkKKyAgICAgICAgICAoa2lsbC1uZXcgKGZ1bmNhbGwgcmVnaW9u LWV4dHJhY3QtZnVuY3Rpb24gbmlsKSB0KSkKIAk7OyBBcnJhbmdlIGZvciBhIHJlcGVhdGVkIG1v dXNlLTMgdG8ga2lsbCB0aGUgcmVnaW9uLgogCShzZXRxIG1vdXNlLXNhdmUtdGhlbi1raWxsLXBv c24gY2xpY2stcHQpKSkKIApAQCAtMjQwOCwxMCArMjQwOCwxNSBAQCBtb3VzZS1kcmFnLWFuZC1k cm9wLXJlZ2lvbgogICAgICAgICAgKHN0YXJ0IChyZWdpb24tYmVnaW5uaW5nKSkKICAgICAgICAg IChlbmQgKHJlZ2lvbi1lbmQpKQogICAgICAgICAgKHBvaW50IChwb2ludCkpCisgICAgICAgICAo cmVnaW9uLW5vbmNvbnRpZ3VvdXMgKHJlZ2lvbi1ub25jb250aWd1b3VzLXApKQogICAgICAgICAg KGJ1ZmZlciAoY3VycmVudC1idWZmZXIpKQogICAgICAgICAgKHdpbmRvdyAoc2VsZWN0ZWQtd2lu ZG93KSkKICAgICAgICAgICh0ZXh0LWZyb20tcmVhZC1vbmx5IGJ1ZmZlci1yZWFkLW9ubHkpCi0g ICAgICAgICAobW91c2UtZHJhZy1hbmQtZHJvcC1vdmVybGF5IChtYWtlLW92ZXJsYXkgc3RhcnQg ZW5kKSkKKyAgICAgICAgIDs7IFVzZSBtdWx0aXBsZSBvdmVybGF5cyB0byBjb3ZlciBjYXNlcyB3 aGVyZSB0aGUgcmVnaW9uIGlzIHJlY3Rhbmd1bGFyLgorICAgICAgICAgKG1vdXNlLWRyYWctYW5k LWRyb3Atb3ZlcmxheXMgKG1hcGNhciAobGFtYmRhIChib3VuZHMpCisgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKG1ha2Utb3ZlcmxheSAoY2FyIGJvdW5k cykKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIChjZHIgYm91bmRzKSkpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIChyZWdpb24tYm91bmRzKSkpCiAgICAgICAgICBwb2ludC10by1wYXN0 ZQogICAgICAgICAgcG9pbnQtdG8tcGFzdGUtcmVhZC1vbmx5CiAgICAgICAgICB3aW5kb3ctdG8t cGFzdGUKQEAgLTI0NTUsNyArMjQ2MCwxMSBAQCBtb3VzZS1kcmFnLWFuZC1kcm9wLXJlZ2lvbgog ICAgICAgICAgIDs7IE9idGFpbiB0aGUgZHJhZ2dlZCB0ZXh0IGluIHJlZ2lvbi4gIFdoZW4gdGhl IGxvb3Agd2FzCiAgICAgICAgICAgOzsgc2tpcHBlZCwgdmFsdWUtc2VsZWN0aW9uIHJlbWFpbnMg bmlsLgogICAgICAgICAgICh1bmxlc3MgdmFsdWUtc2VsZWN0aW9uCi0gICAgICAgICAgICAoc2V0 cSB2YWx1ZS1zZWxlY3Rpb24gKGJ1ZmZlci1zdWJzdHJpbmcgc3RhcnQgZW5kKSkKKyAgICAgICAg ICAgIChzZXRxIHZhbHVlLXNlbGVjdGlvbiAoZnVuY2FsbCByZWdpb24tZXh0cmFjdC1mdW5jdGlv biBuaWwpKQorICAgICAgICAgICAgOzsgUmVtb3ZlIHlhbmstaGFuZGxlciBwcm9wZXJ0eSBpbiBv cmRlciB0byByZS1pbnNlcnQgdGV4dCB1c2luZworICAgICAgICAgICAgOzsgdGhlIGBpbnNlcnQt cmVjdGFuZ2xlJyBmdW5jdGlvbiBsYXRlciBvbi4KKyAgICAgICAgICAgIChyZW1vdmUtdGV4dC1w cm9wZXJ0aWVzIDAgKGxlbmd0aCB2YWx1ZS1zZWxlY3Rpb24pCisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAnKHlhbmstaGFuZGxlcikgdmFsdWUtc2VsZWN0aW9uKQogICAgICAg ICAgICAgKHdoZW4gbW91c2UtZHJhZy1hbmQtZHJvcC1yZWdpb24tc2hvdy10b29sdGlwCiAgICAg ICAgICAgICAgIChsZXQgKCh0ZXh0LXNpemUgbW91c2UtZHJhZy1hbmQtZHJvcC1yZWdpb24tc2hv dy10b29sdGlwKSkKICAgICAgICAgICAgICAgICAoc2V0cSB0ZXh0LXRvb2x0aXAKQEAgLTI0Njgs MTIgKzI0NzcsMTggQEAgbW91c2UtZHJhZy1hbmQtZHJvcC1yZWdpb24KICAgICAgICAgICAgICAg ICAgICAgICAgIHZhbHVlLXNlbGVjdGlvbikpKSkKIAogICAgICAgICAgICAgOzsgQ2hlY2sgaWYg c2VsZWN0ZWQgdGV4dCBpcyByZWFkLW9ubHkuCi0gICAgICAgICAgICAoc2V0cSB0ZXh0LWZyb20t cmVhZC1vbmx5IChvciB0ZXh0LWZyb20tcmVhZC1vbmx5Ci0gICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAoZ2V0LXRleHQtcHJvcGVydHkgc3RhcnQgJ3JlYWQtb25seSkK LSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChub3QgKGVxdWFsCi0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAobmV4dC1zaW5n bGUtY2hhci1wcm9wZXJ0eS1jaGFuZ2UKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBzdGFydCAncmVhZC1vbmx5IG5pbCBlbmQpCi0gICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBlbmQpKSkpKQorICAgICAgICAgICAg KHNldHEgdGV4dC1mcm9tLXJlYWQtb25seQorICAgICAgICAgICAgICAgICAgKG9yIHRleHQtZnJv bS1yZWFkLW9ubHkKKyAgICAgICAgICAgICAgICAgICAgICAoZ2V0LXRleHQtcHJvcGVydHkgc3Rh cnQgJ3JlYWQtb25seSkKKyAgICAgICAgICAgICAgICAgICAgICAoZ2V0LXRleHQtcHJvcGVydHkg ZW5kICdyZWFkLW9ubHkpCisgICAgICAgICAgICAgICAgICAgICAgKGNhdGNoICdsb29wCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIChkb2xpc3QgKGJvdW5kIChyZWdpb24tYm91bmRzKSkK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAodW5sZXNzIChlcXVhbAorICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChuZXh0LXNpbmdsZS1jaGFyLXByb3BlcnR5 LWNoYW5nZQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoY2FyIGJv dW5kKSAncmVhZC1vbmx5IG5pbCAoY2RyIGJvdW5kKSkKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAoY2RyIGJvdW5kKSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICh0aHJvdyAnbG9vcCB0KSkpKSkpKQorCiAgICAgICAgICAgKHNldHEgd2luZG93LXRv LXBhc3RlIChwb3NuLXdpbmRvdyAoZXZlbnQtZW5kIGV2ZW50KSkpCiAgICAgICAgICAgKHNldHEg cG9pbnQtdG8tcGFzdGUgKHBvc24tcG9pbnQgKGV2ZW50LWVuZCBldmVudCkpKQogICAgICAgICAg IDs7IFNldCBuaWwgd2hlbiB0YXJnZXQgYnVmZmVyIGlzIG1pbmlidWZmZXIuCkBAIC0yNTAwLDEy ICsyNTE1LDEyIEBAIG1vdXNlLWRyYWctYW5kLWRyb3AtcmVnaW9uCiAgICAgICAgICAgICA7OyB0 ZXh0IHdpbGwgYmUgaW5zZXJ0ZWQgdG8gaW5zaWRlIG9mIHRoZSBvcmlnaW5hbAogICAgICAgICAg ICAgOzsgcmVnaW9uLgogICAgICAgICAgICAgKHNldHEgZHJhZy1idXQtbmVnbGlnaWJsZQotICAg ICAgICAgICAgICAgICAgKGFuZCAoZXEgKG92ZXJsYXktYnVmZmVyIG1vdXNlLWRyYWctYW5kLWRy b3Atb3ZlcmxheSkKKyAgICAgICAgICAgICAgICAgIChhbmQgKGVxIChvdmVybGF5LWJ1ZmZlciAo Y2FyIG1vdXNlLWRyYWctYW5kLWRyb3Atb3ZlcmxheXMpKQogICAgICAgICAgICAgICAgICAgICAg ICAgICAgYnVmZmVyLXRvLXBhc3RlKQotICAgICAgICAgICAgICAgICAgICAgICAoPD0gKG92ZXJs YXktc3RhcnQgbW91c2UtZHJhZy1hbmQtZHJvcC1vdmVybGF5KQorICAgICAgICAgICAgICAgICAg ICAgICAoPD0gKG92ZXJsYXktc3RhcnQgKGNhciBtb3VzZS1kcmFnLWFuZC1kcm9wLW92ZXJsYXlz KSkKICAgICAgICAgICAgICAgICAgICAgICAgICAgcG9pbnQtdG8tcGFzdGUpCiAgICAgICAgICAg ICAgICAgICAgICAgICg8PSBwb2ludC10by1wYXN0ZQotICAgICAgICAgICAgICAgICAgICAgICAg ICAob3ZlcmxheS1lbmQgbW91c2UtZHJhZy1hbmQtZHJvcC1vdmVybGF5KSkpKSkKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgKG92ZXJsYXktZW5kIChjYXIgKGxhc3QgbW91c2UtZHJhZy1hbmQt ZHJvcC1vdmVybGF5cykpKSkpKSkKIAogICAgICAgICAgIDs7IFNob3cgYSB0b29sdGlwLgogICAg ICAgICAgIChpZiBtb3VzZS1kcmFnLWFuZC1kcm9wLXJlZ2lvbi1zaG93LXRvb2x0aXAKQEAgLTI1 MjQsOCArMjUzOSw5IEBAIG1vdXNlLWRyYWctYW5kLWRyb3AtcmVnaW9uCiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgKHQKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJ2Jh cikpKQogICAgICAgICAgICAgKHdoZW4gY3Vyc29yLWluLXRleHQtYXJlYQotICAgICAgICAgICAg ICAob3ZlcmxheS1wdXQgbW91c2UtZHJhZy1hbmQtZHJvcC1vdmVybGF5Ci0gICAgICAgICAgICAg ICAgICAgICAgICAgICAnZmFjZSAnbW91c2UtZHJhZy1hbmQtZHJvcC1yZWdpb24pCisgICAgICAg ICAgICAgIChkb2xpc3QgKG92ZXJsYXkgbW91c2UtZHJhZy1hbmQtZHJvcC1vdmVybGF5cykKKyAg ICAgICAgICAgICAgICAob3ZlcmxheS1wdXQgb3ZlcmxheQorICAgICAgICAgICAgICAgICAgICAg ICAgICAgJ2ZhY2UgJ21vdXNlLWRyYWctYW5kLWRyb3AtcmVnaW9uKSkKICAgICAgICAgICAgICAg KGRlYWN0aXZhdGUtbWFyaykgICAgIDsgTWFpbnRhaW4gcmVnaW9uIGluIG90aGVyIHdpbmRvdy4K ICAgICAgICAgICAgICAgKG1vdXNlLXNldC1wb2ludCBldmVudCkpKSkpCiAKQEAgLTI1OTAsMTEg KzI2MDYsMTcgQEAgbW91c2UtZHJhZy1hbmQtZHJvcC1yZWdpb24KICAgICAgICAgICAoc2V0cSB3 aW5kb3ctZXhlbXB0IHdpbmRvdy10by1wYXN0ZSkKICAgICAgICAgICAoZ290by1jaGFyIHBvaW50 LXRvLXBhc3RlKQogICAgICAgICAgIChwdXNoLW1hcmspCi0gICAgICAgICAgKGluc2VydCB2YWx1 ZS1zZWxlY3Rpb24pCisKKyAgICAgICAgICAoaWYgcmVnaW9uLW5vbmNvbnRpZ3VvdXMKKyAgICAg ICAgICAgICAgKGluc2VydC1yZWN0YW5nbGUgKHNwbGl0LXN0cmluZyB2YWx1ZS1zZWxlY3Rpb24g IlxuIikpCisgICAgICAgICAgICAoaW5zZXJ0IHZhbHVlLXNlbGVjdGlvbikpCisKICAgICAgICAg ICA7OyBPbiBzdWNjZXNzLCBzZXQgdGhlIHRleHQgYXMgcmVnaW9uIG9uIGRlc3RpbmF0aW9uIGJ1 ZmZlci4KICAgICAgICAgICAod2hlbiAobm90IChlcXVhbCAobWFyaykgKHBvaW50KSkpCiAgICAg ICAgICAgICAoc2V0cSBkZWFjdGl2YXRlLW1hcmsgbmlsKQotICAgICAgICAgICAgKGFjdGl2YXRl LW1hcmspKQorICAgICAgICAgICAgKGFjdGl2YXRlLW1hcmspCisgICAgICAgICAgICAod2hlbiBy ZWdpb24tbm9uY29udGlndW91cworICAgICAgICAgICAgICAocmVjdGFuZ2xlLW1hcmstbW9kZSkp KQogCiAgICAgICAgICAgOzsgKiBTT1VSQ0UgQlVGRkVSOjoKICAgICAgICAgICA7OyBTZXQgYmFj ayB0aGUgb3JpZ2luYWwgdGV4dCBhcyByZWdpb24gb3IgZGVsZXRlIHRoZSBvcmlnaW5hbApAQCAt MjYwNCw4ICsyNjI2LDkgQEAgbW91c2UtZHJhZy1hbmQtZHJvcC1yZWdpb24KICAgICAgICAgICAg ICAgOzsgcmVtb3ZlIHRoZSBvcmlnaW5hbCB0ZXh0LgogICAgICAgICAgICAgICAod2hlbiBuby1t b2RpZmllci1vbi1kcm9wCiAgICAgICAgICAgICAgICAgKGxldCAoZGVhY3RpdmF0ZS1tYXJrKQot ICAgICAgICAgICAgICAgICAgKGRlbGV0ZS1yZWdpb24gKG92ZXJsYXktc3RhcnQgbW91c2UtZHJh Zy1hbmQtZHJvcC1vdmVybGF5KQotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKG92 ZXJsYXktZW5kIG1vdXNlLWRyYWctYW5kLWRyb3Atb3ZlcmxheSkpKSkKKyAgICAgICAgICAgICAg ICAgIChkb2xpc3QgKG92ZXJsYXkgbW91c2UtZHJhZy1hbmQtZHJvcC1vdmVybGF5cykKKyAgICAg ICAgICAgICAgICAgICAgKGRlbGV0ZS1yZWdpb24gKG92ZXJsYXktc3RhcnQgb3ZlcmxheSkKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKG92ZXJsYXktZW5kIG92ZXJsYXkpKSkp KQogICAgICAgICAgICAgOzsgV2hlbiBzb3VyY2UgYnVmZmVyIGFuZCBkZXN0aW5hdGlvbiBidWZm ZXIgYXJlIGRpZmZlcmVudCwKICAgICAgICAgICAgIDs7IGtlZXAgKHNldCBiYWNrIHRoZSBvcmln aW5hbCB0ZXh0IGFzIHJlZ2lvbikgb3IgcmVtb3ZlIHRoZQogICAgICAgICAgICAgOzsgb3JpZ2lu YWwgdGV4dC4KQEAgLTI2MTUsMTUgKzI2MzgsMTcgQEAgbW91c2UtZHJhZy1hbmQtZHJvcC1yZWdp b24KICAgICAgICAgICAgIChpZiBtb3VzZS1kcmFnLWFuZC1kcm9wLXJlZ2lvbi1jdXQtd2hlbi1i dWZmZXJzLWRpZmZlcgogICAgICAgICAgICAgICAgIDs7IFJlbW92ZSB0aGUgZHJhZ2dlZCB0ZXh0 IGZyb20gc291cmNlIGJ1ZmZlciBsaWtlCiAgICAgICAgICAgICAgICAgOzsgb3BlcmF0aW9uIGBj dXQnLgotICAgICAgICAgICAgICAgIChkZWxldGUtcmVnaW9uIChvdmVybGF5LXN0YXJ0IG1vdXNl LWRyYWctYW5kLWRyb3Atb3ZlcmxheSkKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAo b3ZlcmxheS1lbmQgbW91c2UtZHJhZy1hbmQtZHJvcC1vdmVybGF5KSkKKyAgICAgICAgICAgICAg ICAoZG9saXN0IChvdmVybGF5IG1vdXNlLWRyYWctYW5kLWRyb3Atb3ZlcmxheXMpCisgICAgICAg ICAgICAgICAgICAgIChkZWxldGUtcmVnaW9uIChvdmVybGF5LXN0YXJ0IG92ZXJsYXkpCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChvdmVybGF5LWVuZCBvdmVybGF5KSkpCiAg ICAgICAgICAgICAgIDs7IFNldCBiYWNrIHRoZSBkcmFnZ2VkIHRleHQgYXMgcmVnaW9uIG9uIHNv dXJjZSBidWZmZXIKICAgICAgICAgICAgICAgOzsgbGlrZSBvcGVyYXRpb24gYGNvcHknLgogICAg ICAgICAgICAgICAoYWN0aXZhdGUtbWFyaykpCiAgICAgICAgICAgICAoc2VsZWN0LXdpbmRvdyB3 aW5kb3ctdG8tcGFzdGUpKSkpKSkKIAogICAgIDs7IENsZWFuIHVwLgotICAgIChkZWxldGUtb3Zl cmxheSBtb3VzZS1kcmFnLWFuZC1kcm9wLW92ZXJsYXkpCisgICAgKGRvbGlzdCAob3ZlcmxheSBt b3VzZS1kcmFnLWFuZC1kcm9wLW92ZXJsYXlzKQorICAgICAgKGRlbGV0ZS1vdmVybGF5IG92ZXJs YXkpKQogCiAgICAgOzsgUmVzdG9yZSBvbGQgc3RhdGVzIGJ1dCBmb3IgdGhlIHdpbmRvdyB3aGVy ZSB0aGUgZHJvcAogICAgIDs7IG9jY3VycmVkLiBSZXN0b3JlIGN1cnNvciB0eXBlcyBmb3IgYWxs IHdpbmRvd3MuCi0tIAoyLjE3LjEKCg== --0000000000003a747e0576bb60c7-- From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 27 16:32:02 2018 Received: (at 31240) by debbugs.gnu.org; 27 Sep 2018 20:32:02 +0000 Received: from localhost ([127.0.0.1]:56979 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g5cx8-0002hE-0E for submit@debbugs.gnu.org; Thu, 27 Sep 2018 16:32:02 -0400 Received: from sinyavsky.aurox.ch ([37.35.109.145]:50875) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g5cx5-0002gx-K0 for 31240@debbugs.gnu.org; Thu, 27 Sep 2018 16:32:00 -0400 Received: from sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) by sinyavsky.aurox.ch (Postfix) with ESMTP id 79A5222878 for <31240@debbugs.gnu.org>; Thu, 27 Sep 2018 20:35:47 +0000 (UTC) Authentication-Results: sinyavsky.aurox.ch (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= references:subject:subject:in-reply-to:to:from:from:message-id :date:date; s=dkim; t=1538080546; x=1538944547; bh=1Ghtjv+Zy0pDZ 4ZxDMycrTFkcPsJ8zOzoV4ZjBoeFow=; b=ooI+W8kxYjKJbozWj9qEvg0Q+5B35 /FkhgBkka1WTNQuuzmxMbBjDTmnDhE8jrYORryJoiQCNNRx2gn3fQcjZDkVqZsj6 dbc2UaCiIIaG0neUwQLJ/ONDHOC/eaVWC+PvjcXyEWPJ5H4mIodPdKz4csBddKd1 RmCQ8R56AyiKtE= X-Virus-Scanned: Debian amavisd-new at test.virtualizor.com Received: from sinyavsky.aurox.ch ([127.0.0.1]) by sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 5b4ZU-O8-y_C for <31240@debbugs.gnu.org>; Thu, 27 Sep 2018 20:35:46 +0000 (UTC) Received: from gray (unknown [IPv6:2a02:1205:c693:2d60:c62c:3ff:fe30:b864]) by sinyavsky.aurox.ch (Postfix) with ESMTPSA id 35BE522867; Thu, 27 Sep 2018 20:35:46 +0000 (UTC) Date: Thu, 27 Sep 2018 22:34:36 +0200 Message-Id: From: charles@aurox.ch (Charles A. Roelli) To: Federico Tedin In-reply-to: (message from Federico Tedin on Tue, 25 Sep 2018 21:33:35 -0300) Subject: Re: bug#31240: 26.1; mouse-save-then-kill does not kill rectangles References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 31240 Cc: 31240@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Federico Tedin > Date: Tue, 25 Sep 2018 21:33:35 -0300 > > Charles, thanks for your input. I've created a new patch which fixes > the handling of rectangular regions on both mouse-save-then-kill and > mouse-drag-and-drop-region (it includes the changes made in the > previous patch). I'm attaching it below. Thanks! I tried this to test the patch: src/emacs -Q M-x set-variable RET mouse-drag-and-drop-region RET t With the mouse, drag from the "n" in "not saved" to the space after "C-x C-f" (in *scratch*) C-x SPC Now drag the region until the cursor is on the "a" of "and" For some reason, the region is not moved, and it gets re-activated as a normal region instead of a rectangular region. Maybe I'm missing something obvious. I was able to get the dragging of a rectangular region working sometimes, but not consistently. From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 27 19:46:02 2018 Received: (at 31240) by debbugs.gnu.org; 27 Sep 2018 23:46:02 +0000 Received: from localhost ([127.0.0.1]:57080 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g5fys-0007MM-7i for submit@debbugs.gnu.org; Thu, 27 Sep 2018 19:46:02 -0400 Received: from mail-it1-f174.google.com ([209.85.166.174]:37119) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g5fyq-0007Lr-IE for 31240@debbugs.gnu.org; Thu, 27 Sep 2018 19:46:01 -0400 Received: by mail-it1-f174.google.com with SMTP id m9-v6so645529ita.2 for <31240@debbugs.gnu.org>; Thu, 27 Sep 2018 16:46:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=e8kHe5M97M5fllFkcBYNnHFqCMJ6S/833AUQNLDCxpI=; b=kewpdHS98Ewh4ICP2ERFc7elgiiZRNviXHd5ai2DXODbq/MMTH4K7FLq4ZMSKx31TT y7G9aCK+bvSeS+YIuEmP2X8cVuh2nOTVPC5Y9kNUSs8ieCQ7ls+YVRTmpaF7eBMvK8Do sVfx+vNL3C9y10oKa84N4UvVUXQq2YItShPuBoYjSYpcAhGXa41x94GNAab5YOkJfM7X ICkmGEeWYDJRXMCiDUGWr/3r8lnoOkW1RNHF9F40GcWukp5w4K8NNr7cUfN4OmBXVdqC chC5ZJzRDGaMq1l+lnAMPZ9sh3vz2Zdwlvh2EMewFXx0r4QIXnWX43fG1aJzRxhfqRV8 VGbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=e8kHe5M97M5fllFkcBYNnHFqCMJ6S/833AUQNLDCxpI=; b=HIQSCnNAf7pL+nKRhjo4DoEKjlHkrOZpmPeR6wmoLuyskNt2dqIHgoyt9EJ3TUm3j9 gj+6QKBlWvptJJ/+a2rClQA3vP2OgO2ZvdSI3e9RDZWGM8F3S3/0GBftwnao/Vm8nNdy WBxdPpVUW3lJO9VyIZ6k396me6R9ck4ZOzJoGrg+QZDNNcEwKfNaqkP1N6vK8xOPaZdQ 75VyOsuL84wkOig3gUO3g/xqqBoMGeHd4XDr5WiwpwMAFpEdOka3idlJD4rWmHeA+cBd jbMlsDC5cu1KFL3GOODtGIIdZjVLXC1mmRvAM664TbwSgl4AddjoL71f2YLHLkIKbxj+ fvlA== X-Gm-Message-State: ABuFfoihaSZ/AIVtXEz9ZljSHN1goL/m/KPyYzR7nP6GpLrS3M6kvJNB hGZBkPngDfJhcfq4gQkEUXn+3oPz3WPxweSeoo/cXLYw X-Google-Smtp-Source: ACcGV62eSIT8sWD6Se3Jp2Pl1Vj8pEh0J39+cIFTyVJ+qC3Nu1rNR17/liYCx7iYWOB0QUS7pQL4qIjJYdV73bGZEl4= X-Received: by 2002:a02:844c:: with SMTP id l12-v6mr7905628jah.137.1538091954665; Thu, 27 Sep 2018 16:45:54 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Federico Tedin Date: Thu, 27 Sep 2018 20:45:42 -0300 Message-ID: Subject: Re: bug#31240: 26.1; mouse-save-then-kill does not kill rectangles To: charles@aurox.ch Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31240 Cc: 31240@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Thanks! > > I tried this to test the patch: > > src/emacs -Q > M-x set-variable RET mouse-drag-and-drop-region RET t > With the mouse, drag from the "n" in "not saved" to the space after "C-x C-f" (in *scratch*) > C-x SPC > Now drag the region until the cursor is on the "a" of "and" > > For some reason, the region is not moved, and it gets re-activated as > a normal region instead of a rectangular region. Maybe I'm missing > something obvious. I was able to get the dragging of a rectangular > region working sometimes, but not consistently. I've tried your test, and it does break my fix, as you mentioned. The problem was in the criteria used to define the variable 'drag-but-negligible'. The drag action used in your test was being incorrectly marked as negligible. Because of this, the region was also re-activated, but not in Rectangle Mark mode (this was also a bug). I have made a correction where the variable 'drag-but-negligible' is defined, so dragging a rectangle region outside of itself will no longer mark it as negligible; and when it _is_ negligible, the region is re-activated as a rectangle again. I've also found some cases where the overlay list is not working well enough to track the selected rectangle. For example, if a buffer contains the following: aaaa BBbb CCcc Dragging a 2x2 square starting from the first 'B' (spaces added for clarity): a a a a [B B]b b [C C]c c to the column where the second 'a' is, results in the following: a B B a a a b b c c In this case, two 'C's are missing in the second line (after the first 'b'). The reason this is happening is the following: when mouse-drag-and-drop-region is called, the initial overlays are the following (shown with braces): a a a a {B B}b b {C C}c c After the 2x2 square is inserted on the second 'a', the first overlay is automatically expanded, because characters where inserted between its start/end: a B B a a a {b C C b}b b {c c}c c When the original text is then deleted (by deleting all overlays), the result is: a B B a a a b b c c So I think I have two options now: either forbid the user from dragging a rectangle to a position where the inserted rectangle would intersect the original rectangle, or find another way to track the originally selected rectangle in a way it can be accurately deleted after inserting it in the new position. I guess I'll go with the second option, since it would make function more useful for users. From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 28 03:47:47 2018 Received: (at 31240) by debbugs.gnu.org; 28 Sep 2018 07:47:47 +0000 Received: from localhost ([127.0.0.1]:57167 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g5nV3-0002z8-1l for submit@debbugs.gnu.org; Fri, 28 Sep 2018 03:47:45 -0400 Received: from mout.gmx.net ([212.227.17.22]:54419) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g5nV0-0002yu-Kl for 31240@debbugs.gnu.org; Fri, 28 Sep 2018 03:47:43 -0400 Received: from [192.168.1.100] ([212.95.5.135]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0LevUh-1fP2pa2wG7-00qkq3; Fri, 28 Sep 2018 09:47:29 +0200 Received: from [192.168.1.100] ([212.95.5.135]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0LevUh-1fP2pa2wG7-00qkq3; Fri, 28 Sep 2018 09:47:29 +0200 Message-ID: <5BADDC88.7010206@gmx.at> Date: Fri, 28 Sep 2018 09:47:20 +0200 From: martin rudalics MIME-Version: 1.0 To: Federico Tedin , charles@aurox.ch Subject: Re: bug#31240: 26.1; mouse-save-then-kill does not kill rectangles References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:2mvnU0pP4GBbKEBDEmw/0woa+UkdM5575hSsdEoykNuHoI8lFJY VxWMGRq92Dewx4m4G7AuxVIMi0MFPk1d3cRF82WZCBIzQ+qegEy7QyLbpYP2bLo9gNM7/HT Q2xiLwV+X9/pQtqg6sVnmtnJZJvayiZ/TbiTILxjSUu8yfK7nSP+yQYNvQIt0kNZlzgdXh9 ITe0u9OGMI7+vitNZNAvw== X-UI-Out-Filterresults: notjunk:1;V01:K0:ERrBRRnmW3A=:2pcgTifazfJSTxcEWOtw2n zLK7/El7u8ByOtsgOQDIxMibws2pDJxOiQ+UGGofbLWuk0yn+kHSOrVZv2u2ASDSDvAYFUERf Fql1mJ8bHqqlD4Xg2xXCybz7lqy0g7EiR2eRKV3E3P9vijkZASk4PzNG2FQPZoijO/R0ltH5L YJed7i2X1nZkxY43WON424tpbHwLrGVzHLpsWNwFuB5WMgQAqOhXSRU1AjQftsusFBC7/olti y6tktX4hRGBDnZM/SJ3M9Rps0cN6NEDq+WzcDqpsRmifwZP+LQrj07d7lyCanWK9doJ13zGkF FbD06zH9Mxi29UeYlSWscBdDpNH+fBoehphWp+XrGeUUsX61sci5wFJ4yQOJSebofk7k3/lBa 14y2YXRqs1xExr7fHYaEZzO6o0D6GzJ9ri/HfDPnQZMq88YLUh4+e2O0ad0Vno/XqOKdnOr61 p8bEyEnhNjgRIO12S8cZuuBL0r0IS/bIUaQwhmbW1vo5frQBZFUQwvzs8Sh9IxFgMO4kac09n lbYyNGWrxvtFXM2bofYzk/5pMagISWcpaAAgsUsZPliWC7/BlCjmOEyIxICrNJebFKrVweJQu baIt+YU45+ZJPb+vnMR1KsYRO3A3t9i9jqOUcL6UU60tf+gkEBe7jd8oeGfkB8C0COosc9Nxl LEfG7fMtBX0YiwFkFx9asFAhhjNZAvguQcUmQ3H+ogqGcM4g1XnKiqrWCNieiq5+hKJSmbpzo 3DjLQJKWgS7iVu/mwflNPYziAsaPSZxVdpUQdDhVzQKeQrgbs50MpO1mF3GaU1zX7kJvqldYm 1xr49z5OqQqYfyBkvw01obKRenZZNN7jj4qRbdxiEPhmzqmkKM= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 31240 Cc: 31240@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > So I think I have two options now: either forbid the user from > dragging a rectangle to a position where the inserted rectangle would > intersect the original rectangle, IIRC that would be faithful to the original (non-rectangle-dragging) design. > or find another way to track the > originally selected rectangle in a way it can be accurately deleted > after inserting it in the new position. I guess I'll go with the > second option, since it would make function more useful for users. In that case we should try to make the non-rectangle-dragging behavior similar. So if you prefer the second option, please do that and make it customizable. Many thanks for working on this, martin From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 29 06:05:13 2018 Received: (at 31240) by debbugs.gnu.org; 29 Sep 2018 10:05:13 +0000 Received: from localhost ([127.0.0.1]:58283 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g6C7c-0008M6-Ow for submit@debbugs.gnu.org; Sat, 29 Sep 2018 06:05:13 -0400 Received: from sinyavsky.aurox.ch ([37.35.109.145]:52088) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g6C7Z-0008Lm-9d for 31240@debbugs.gnu.org; Sat, 29 Sep 2018 06:05:11 -0400 Received: from sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) by sinyavsky.aurox.ch (Postfix) with ESMTP id C0B5422879 for <31240@debbugs.gnu.org>; Sat, 29 Sep 2018 10:08:58 +0000 (UTC) Authentication-Results: sinyavsky.aurox.ch (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= references:reply-to:subject:subject:in-reply-to:to:from:from :message-id:date:date; s=dkim; t=1538215737; x=1539079738; bh=RU U/XIkZz2ZulOTEShoMWCJcqMN06weGsYyrRx0bmyE=; b=GExrBg77fcYekvY091 NpKGubWKjAI6Ape0cxHMX+BIygLJQyscQ2ZNDaXuw2q4Hh8TL5FtnH8aRlgUeeXb P3BKCbT+kVv25u8ayt4X0XpeEgrfXnTS6ul8FwogMlxsPXu4LMGs1KUj4CA41xo1 YMkPFvlQ84J7ct4SfNnHLrfAo= X-Virus-Scanned: Debian amavisd-new at test.virtualizor.com Received: from sinyavsky.aurox.ch ([127.0.0.1]) by sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Q_f-LYbCIfwq for <31240@debbugs.gnu.org>; Sat, 29 Sep 2018 10:08:57 +0000 (UTC) Received: from gray (unknown [IPv6:2a02:1205:c693:2d60:c62c:3ff:fe30:b864]) by sinyavsky.aurox.ch (Postfix) with ESMTPSA id C9BA4226F4; Sat, 29 Sep 2018 10:08:56 +0000 (UTC) Date: Sat, 29 Sep 2018 12:07:58 +0200 Message-Id: From: charles@aurox.ch (Charles A. Roelli) To: Federico Tedin In-reply-to: (message from Federico Tedin on Thu, 27 Sep 2018 20:45:42 -0300) Subject: Re: bug#31240: 26.1; mouse-save-then-kill does not kill rectangles References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 31240 Cc: 31240@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: charles@aurox.ch Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Federico Tedin > Date: Thu, 27 Sep 2018 20:45:42 -0300 > > For some reason, the region is not moved, and it gets re-activated as > > a normal region instead of a rectangular region. Maybe I'm missing > > something obvious. I was able to get the dragging of a rectangular > > region working sometimes, but not consistently. > > I've tried your test, and it does break my fix, as you mentioned. > > The problem was in the criteria used to define the variable > 'drag-but-negligible'. The drag action used in your test was being > incorrectly marked as negligible. Because of this, the region was > also re-activated, but not in Rectangle Mark mode (this was also a bug). > > I have made a correction where the variable 'drag-but-negligible' is > defined, so dragging a rectangle region outside of itself will no longer > mark it as negligible; and when it _is_ negligible, the region is > re-activated as a rectangle again. Thanks, sounds good. > I've also found some cases where the overlay list is not working well > enough to track the selected rectangle. For example, if a buffer > contains the following: > > aaaa > BBbb > CCcc > > Dragging a 2x2 square starting from the first 'B' (spaces added for > clarity): > > a a a a > [B B]b b > [C C]c c > > to the column where the second 'a' is, results in the following: > > a B B a a a > b b > c c > > In this case, two 'C's are missing in the second line (after the first > 'b'). The reason this is happening is the following: when > mouse-drag-and-drop-region is called, the initial overlays are the > following (shown with braces): > > a a a a > {B B}b b > {C C}c c > > After the 2x2 square is inserted on the second 'a', the first overlay > is automatically expanded, because characters where inserted between > its start/end: > > a B B a a a > {b C C b}b b > {c c}c c > > When the original text is then deleted (by deleting all overlays), the > result is: > > a B B a a a > b b > c c > > So I think I have two options now: either forbid the user from > dragging a rectangle to a position where the inserted rectangle would > intersect the original rectangle, or find another way to track the > originally selected rectangle in a way it can be accurately deleted > after inserting it in the new position. I guess I'll go with the > second option, since it would make function more useful for users. This second option sounds like it can be quite hard to define. If you decide in the end to prevent the user from dragging the region somewhere that would intersect with the dragged region (which, as Martin said, is in line with the original design of mouse-drag-and-drop-region) that would be fine. From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 29 19:19:21 2018 Received: (at 31240) by debbugs.gnu.org; 29 Sep 2018 23:19:21 +0000 Received: from localhost ([127.0.0.1]:59266 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g6OW8-0004Yc-S1 for submit@debbugs.gnu.org; Sat, 29 Sep 2018 19:19:21 -0400 Received: from mail-lf1-f67.google.com ([209.85.167.67]:43315) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g6OW6-0004YO-Dv for 31240@debbugs.gnu.org; Sat, 29 Sep 2018 19:19:19 -0400 Received: by mail-lf1-f67.google.com with SMTP id p34-v6so68932lfg.10 for <31240@debbugs.gnu.org>; Sat, 29 Sep 2018 16:19:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YJqpdxHU32twyLn9GDN3UDtvLXEXMptPyyBJpK9sH7Q=; b=bz1l1p6a09641O5f2759akUxt0wRBzNOELgTesEE7KovTsKV/fjjNkL249Td/WJIFl fhF3MiJewgwMZbLwD0grz+4hQ7rjULtH/jDG6jW9WMBcF1etYSqpfacBCiFOctsfeNbZ /7SgqOpLVGhSWz9g7lL890Ub975N8T7ZFpR4GNqrnIXIdszAB+QynCvquLGDcDF1Aa+m ehqywCWcHSdzR61e1Bek6M0QQHZyp6Vyrw37NSo2ySbHW54sbelinyfDHksY89Fw8WzC FIivF3e6YtmcOGezRpFt1TTN/jHCEPyU1eADZd9QM/+gRsiaR6B4gtNL4s1P+u2rn2yI 9ZZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YJqpdxHU32twyLn9GDN3UDtvLXEXMptPyyBJpK9sH7Q=; b=pv5r6f7x/hpV0Tg4rUPjVK8M++wxILOAyi6AmpA/S5M3SsmPBWKpab8c5x9Qr/kR4V CYIEJ+zysJ1Yb38NLK3GOLPSpX2oJ6B8/pDrgNyXd2BvOFH8lytal3Czf5SUSsezlFCY xuTbt3pK6yjy+uOPOsX4AvPDAxYcD7fMGdfu6J+BNFgRsjvBIJqRdBmBqwnlOkSf2NsK sPNXuaKcxULS5fDMD99Y7mN/FkHD3Gb5BFLtxNR7gtETwHmpXG279Uo21JZpgQm5waoA 7B8kRScVb/oLIdimRCdsBgIxuWWhWDYLL3UlXrlc1EzFRybd1Tu8ktnXTX+SPm98AMK4 dt3w== X-Gm-Message-State: ABuFfohT87ef3Vhi+QR8YYnGu0hXM1uaj8SbIxxlh7l9VQAoJEoalJmP poqEpUH+PMT7jzMxyheJ/Mqs0RfRekZGCiLzfSQ= X-Google-Smtp-Source: ACcGV60dQwOvAy40044qIpp9WWUVI7MZ59nDyjGlfY1baA818oSveg5njXBtFDELBIC/EP2mAUXyVr3wc+b9kNOpKVU= X-Received: by 2002:a19:9e54:: with SMTP id h81-v6mr2101137lfe.155.1538263152538; Sat, 29 Sep 2018 16:19:12 -0700 (PDT) MIME-Version: 1.0 References: <5BADDC88.7010206@gmx.at> In-Reply-To: <5BADDC88.7010206@gmx.at> From: Federico Tedin Date: Sat, 29 Sep 2018 20:18:59 -0300 Message-ID: Subject: Re: bug#31240: 26.1; mouse-save-then-kill does not kill rectangles To: rudalics@gmx.at Content-Type: multipart/mixed; boundary="000000000000c76f6105770acc5c" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 31240 Cc: 31240@debbugs.gnu.org, charles@aurox.ch X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000c76f6105770acc5c Content-Type: text/plain; charset="UTF-8" > > So I think I have two options now: either forbid the user from > > dragging a rectangle to a position where the inserted rectangle would > > intersect the original rectangle, > > IIRC that would be faithful to the original (non-rectangle-dragging) > design. > This second option sounds like it can be quite hard to define. If you > decide in the end to prevent the user from dragging the region > somewhere that would intersect with the dragged region (which, as > Martin said, is in line with the original design of > mouse-drag-and-drop-region) that would be fine. After trying out some solutions and reading these two suggestions, I've decided to implement the feature like this. The problem of correctly handling the cases where the dragged rectangular text would overlap with the original one was more complex than I'd thought, and I have some doubts if the usefulness of the feature justifies this added complexity. I'm attaching a new patch with all my changes to mouse.el (and rect.el) so far. I've created two new helper functions in rect.el to avoid cluttering mouse.el with more functions. So, the cases to test out are: 1) Dragging and dropping non-rectangular regions should be exactly the same as before. 2) Dragging and dropping a rectangle _outside_ of itself should insert it in the new position, and then delete the original. 3) Dragging and dropping a rectangle _inside_ of itself should leave everything unchanged. After evaluating "(setq mouse-drag-and-drop-region 'shift)": 4) Dragging and dropping a rectangle inside or outside of itself, while holding the Shift key when dropping, should insert it there, without deleting the original. When I say 'outside of itself' I mean that there shouldn't be any overlapping at all between the original and the newly inserted rectangles. --000000000000c76f6105770acc5c Content-Type: text/x-patch; charset="US-ASCII"; name="mouse.patch" Content-Disposition: attachment; filename="mouse.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jmo24pl30 RnJvbSA3NzdhYWY3MzJmMzQ4YjNiN2NmNDFkMzM2NjA3MWY2MDJiOGNiYjBjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBGZWRlcmljbyBUZWRpbiA8ZmVkZXJpY290ZWRpbkBnbWFpbC5j b20+CkRhdGU6IFNhdCwgMjkgU2VwIDIwMTggMjA6MTY6MDAgLTAzMDAKU3ViamVjdDogW1BBVENI IDEvMV0gQWxsb3cgdHdvIG1vdXNlIGZ1bmN0aW9ucyB0byB3b3JrIHdpdGggUmVjdGFuZ2xlIE1h cmsKIG1vZGUKCiogbGlzcC9tb3VzZS5lbCAobW91c2Utc2F2ZS10aGVuLWtpbGwpOiBNYWtlIG1v dXNlLXNhdmUtdGhlbi1raWxsIHdvcmsKICB3aXRoIHJlY3Rhbmd1bGFyIHJlZ2lvbnMsIGluY2x1 ZGluZyB3aGVuIG1vdXNlLWRyYWctY29weS1yZWdpb24gaXMKICBzZXQgdG8gdC4gKEJ1ZyMzMTI0 MCkKICAobW91c2UtZHJhZy1hbmQtZHJvcC1yZWdpb24pOiBBbGxvdyBkcmFnZ2luZyBhbmQgZHJv cHBpbmcKICByZWN0YW5ndWxhciByZWdpb25zLiAoQnVnIzMxMjQwKQoqIHJlY3QuZWwgKHJlY3Rh bmdsZS1pbnRlcnNlY3QtcCk6IEFkZCBhIG5ldyBmdW5jdGlvbi4KICAocmVjdGFuZ2xlLXBvc2l0 aW9uLWFzLWNvb3JkaW5hdGVzKTogQWRkIGEgbmV3IGZ1bmN0aW9uLgotLS0KIGxpc3AvbW91c2Uu ZWwgfCA5MiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0t LS0KIGxpc3AvcmVjdC5lbCAgfCAzNSArKysrKysrKysrKysrKysrKysrKwogMiBmaWxlcyBjaGFu Z2VkLCAxMDEgaW5zZXJ0aW9ucygrKSwgMjYgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlz cC9tb3VzZS5lbCBiL2xpc3AvbW91c2UuZWwKaW5kZXggY2I2M2NhNTFjNS4uYjAwZjM4YTBmNiAx MDA2NDQKLS0tIGEvbGlzcC9tb3VzZS5lbAorKysgYi9saXNwL21vdXNlLmVsCkBAIC0yOSw2ICsy OSw4IEBACiAKIDs7OyBDb2RlOgogCisoZXZhbC13aGVuLWNvbXBpbGUgKHJlcXVpcmUgJ3JlY3Qp KQorCiA7OzsgVXRpbGl0eSBmdW5jdGlvbnMuCiAKIDs7IEluZGVudCB0cmFjay1tb3VzZSBsaWtl IHByb2duLgpAQCAtMTYwNiw4ICsxNjA4LDggQEAgbW91c2Utc2F2ZS10aGVuLWtpbGwKICAgICAg IChpZiBtb3VzZS1kcmFnLWNvcHktcmVnaW9uCiAgICAgICAgICAgOzsgUmVnaW9uIGFscmVhZHkg c2F2ZWQgaW4gdGhlIHByZXZpb3VzIGNsaWNrOwogICAgICAgICAgIDs7IGRvbid0IG1ha2UgYSBk dXBsaWNhdGUgZW50cnksIGp1c3QgZGVsZXRlLgotICAgICAgICAgIChkZWxldGUtcmVnaW9uICht YXJrIHQpIChwb2ludCkpCi0gICAgICAgIChraWxsLXJlZ2lvbiAobWFyayB0KSAocG9pbnQpKSkK KyAgICAgICAgICAoZnVuY2FsbCByZWdpb24tZXh0cmFjdC1mdW5jdGlvbiAnZGVsZXRlLW9ubHkp CisgICAgICAgIChraWxsLXJlZ2lvbiAobWFyayB0KSAocG9pbnQpICdyZWdpb24pKQogICAgICAg KHNldHEgbW91c2Utc2VsZWN0aW9uLWNsaWNrLWNvdW50IDApCiAgICAgICAoc2V0cSBtb3VzZS1z YXZlLXRoZW4ta2lsbC1wb3NuIG5pbCkpCiAKQEAgLTE2MzIsNyArMTYzNCw3IEBAIG1vdXNlLXNh dmUtdGhlbi1raWxsCiAJKG1vdXNlLXNldC1yZWdpb24tMSkKICAgICAgICAgKHdoZW4gbW91c2Ut ZHJhZy1jb3B5LXJlZ2lvbgogICAgICAgICAgIDs7IFJlZ2lvbiBhbHJlYWR5IGNvcGllZCB0byBr aWxsLXJpbmcgb25jZSwgc28gcmVwbGFjZS4KLSAgICAgICAgICAoa2lsbC1uZXcgKGZpbHRlci1i dWZmZXItc3Vic3RyaW5nIChtYXJrIHQpIChwb2ludCkpIHQpKQorICAgICAgICAgIChraWxsLW5l dyAoZnVuY2FsbCByZWdpb24tZXh0cmFjdC1mdW5jdGlvbiBuaWwpIHQpKQogCTs7IEFycmFuZ2Ug Zm9yIGEgcmVwZWF0ZWQgbW91c2UtMyB0byBraWxsIHRoZSByZWdpb24uCiAJKHNldHEgbW91c2Ut c2F2ZS10aGVuLWtpbGwtcG9zbiBjbGljay1wdCkpKQogCkBAIC0yNDExLDcgKzI0MTMsMTUgQEAg bW91c2UtZHJhZy1hbmQtZHJvcC1yZWdpb24KICAgICAgICAgIChidWZmZXIgKGN1cnJlbnQtYnVm ZmVyKSkKICAgICAgICAgICh3aW5kb3cgKHNlbGVjdGVkLXdpbmRvdykpCiAgICAgICAgICAodGV4 dC1mcm9tLXJlYWQtb25seSBidWZmZXItcmVhZC1vbmx5KQotICAgICAgICAgKG1vdXNlLWRyYWct YW5kLWRyb3Atb3ZlcmxheSAobWFrZS1vdmVybGF5IHN0YXJ0IGVuZCkpCisgICAgICAgICA7OyBV c2UgbXVsdGlwbGUgb3ZlcmxheXMgdG8gY292ZXIgY2FzZXMgd2hlcmUgdGhlIHJlZ2lvbiBpcyBy ZWN0YW5ndWxhci4KKyAgICAgICAgIChtb3VzZS1kcmFnLWFuZC1kcm9wLW92ZXJsYXlzIChtYXBj YXIgKGxhbWJkYSAoYm91bmRzKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIChtYWtlLW92ZXJsYXkgKGNhciBib3VuZHMpCisgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoY2RyIGJvdW5k cykpKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAocmVn aW9uLWJvdW5kcykpKQorICAgICAgICAgKHJlZ2lvbi1ub25jb250aWd1b3VzIChyZWdpb24tbm9u Y29udGlndW91cy1wKSkKKyAgICAgICAgIChyZWdpb24td2lkdGggKC0gKG92ZXJsYXktZW5kIChj YXIgbW91c2UtZHJhZy1hbmQtZHJvcC1vdmVybGF5cykpCisgICAgICAgICAgICAgICAgICAgICAg ICAgIChvdmVybGF5LXN0YXJ0IChjYXIgbW91c2UtZHJhZy1hbmQtZHJvcC1vdmVybGF5cykpKSkK KyAgICAgICAgIChyZWdpb24taGVpZ2h0IChsZW5ndGggbW91c2UtZHJhZy1hbmQtZHJvcC1vdmVy bGF5cykpCiAgICAgICAgICBwb2ludC10by1wYXN0ZQogICAgICAgICAgcG9pbnQtdG8tcGFzdGUt cmVhZC1vbmx5CiAgICAgICAgICB3aW5kb3ctdG8tcGFzdGUKQEAgLTI0NTUsNyArMjQ2NSwxMSBA QCBtb3VzZS1kcmFnLWFuZC1kcm9wLXJlZ2lvbgogICAgICAgICAgIDs7IE9idGFpbiB0aGUgZHJh Z2dlZCB0ZXh0IGluIHJlZ2lvbi4gIFdoZW4gdGhlIGxvb3Agd2FzCiAgICAgICAgICAgOzsgc2tp cHBlZCwgdmFsdWUtc2VsZWN0aW9uIHJlbWFpbnMgbmlsLgogICAgICAgICAgICh1bmxlc3MgdmFs dWUtc2VsZWN0aW9uCi0gICAgICAgICAgICAoc2V0cSB2YWx1ZS1zZWxlY3Rpb24gKGJ1ZmZlci1z dWJzdHJpbmcgc3RhcnQgZW5kKSkKKyAgICAgICAgICAgIChzZXRxIHZhbHVlLXNlbGVjdGlvbiAo ZnVuY2FsbCByZWdpb24tZXh0cmFjdC1mdW5jdGlvbiBuaWwpKQorICAgICAgICAgICAgOzsgUmVt b3ZlIHlhbmstaGFuZGxlciBwcm9wZXJ0eSBpbiBvcmRlciB0byByZS1pbnNlcnQgdGV4dCB1c2lu ZworICAgICAgICAgICAgOzsgdGhlIGBpbnNlcnQtcmVjdGFuZ2xlJyBmdW5jdGlvbiBsYXRlciBv bi4KKyAgICAgICAgICAgIChyZW1vdmUtdGV4dC1wcm9wZXJ0aWVzIDAgKGxlbmd0aCB2YWx1ZS1z ZWxlY3Rpb24pCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnKHlhbmstaGFu ZGxlcikgdmFsdWUtc2VsZWN0aW9uKQogICAgICAgICAgICAgKHdoZW4gbW91c2UtZHJhZy1hbmQt ZHJvcC1yZWdpb24tc2hvdy10b29sdGlwCiAgICAgICAgICAgICAgIChsZXQgKCh0ZXh0LXNpemUg bW91c2UtZHJhZy1hbmQtZHJvcC1yZWdpb24tc2hvdy10b29sdGlwKSkKICAgICAgICAgICAgICAg ICAoc2V0cSB0ZXh0LXRvb2x0aXAKQEAgLTI0NjgsMTIgKzI0ODIsMTggQEAgbW91c2UtZHJhZy1h bmQtZHJvcC1yZWdpb24KICAgICAgICAgICAgICAgICAgICAgICAgIHZhbHVlLXNlbGVjdGlvbikp KSkKIAogICAgICAgICAgICAgOzsgQ2hlY2sgaWYgc2VsZWN0ZWQgdGV4dCBpcyByZWFkLW9ubHku Ci0gICAgICAgICAgICAoc2V0cSB0ZXh0LWZyb20tcmVhZC1vbmx5IChvciB0ZXh0LWZyb20tcmVh ZC1vbmx5Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoZ2V0LXRl eHQtcHJvcGVydHkgc3RhcnQgJ3JlYWQtb25seSkKLSAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIChub3QgKGVxdWFsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAobmV4dC1zaW5nbGUtY2hhci1wcm9wZXJ0eS1jaGFuZ2UKLSAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzdGFydCAncmVh ZC1vbmx5IG5pbCBlbmQpCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBlbmQpKSkpKQorICAgICAgICAgICAgKHNldHEgdGV4dC1mcm9tLXJlYWQtb25seQor ICAgICAgICAgICAgICAgICAgKG9yIHRleHQtZnJvbS1yZWFkLW9ubHkKKyAgICAgICAgICAgICAg ICAgICAgICAoZ2V0LXRleHQtcHJvcGVydHkgc3RhcnQgJ3JlYWQtb25seSkKKyAgICAgICAgICAg ICAgICAgICAgICAoZ2V0LXRleHQtcHJvcGVydHkgZW5kICdyZWFkLW9ubHkpCisgICAgICAgICAg ICAgICAgICAgICAgKGNhdGNoICdsb29wCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChk b2xpc3QgKGJvdW5kIChyZWdpb24tYm91bmRzKSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAodW5sZXNzIChlcXVhbAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIChuZXh0LXNpbmdsZS1jaGFyLXByb3BlcnR5LWNoYW5nZQorICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAoY2FyIGJvdW5kKSAncmVhZC1vbmx5IG5pbCAoY2RyIGJv dW5kKSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoY2RyIGJvdW5k KSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICh0aHJvdyAnbG9vcCB0KSkpKSkp KQorCiAgICAgICAgICAgKHNldHEgd2luZG93LXRvLXBhc3RlIChwb3NuLXdpbmRvdyAoZXZlbnQt ZW5kIGV2ZW50KSkpCiAgICAgICAgICAgKHNldHEgcG9pbnQtdG8tcGFzdGUgKHBvc24tcG9pbnQg KGV2ZW50LWVuZCBldmVudCkpKQogICAgICAgICAgIDs7IFNldCBuaWwgd2hlbiB0YXJnZXQgYnVm ZmVyIGlzIG1pbmlidWZmZXIuCkBAIC0yNTAwLDEyICsyNTIwLDIwIEBAIG1vdXNlLWRyYWctYW5k LWRyb3AtcmVnaW9uCiAgICAgICAgICAgICA7OyB0ZXh0IHdpbGwgYmUgaW5zZXJ0ZWQgdG8gaW5z aWRlIG9mIHRoZSBvcmlnaW5hbAogICAgICAgICAgICAgOzsgcmVnaW9uLgogICAgICAgICAgICAg KHNldHEgZHJhZy1idXQtbmVnbGlnaWJsZQotICAgICAgICAgICAgICAgICAgKGFuZCAoZXEgKG92 ZXJsYXktYnVmZmVyIG1vdXNlLWRyYWctYW5kLWRyb3Atb3ZlcmxheSkKKyAgICAgICAgICAgICAg ICAgIChhbmQgKGVxIChvdmVybGF5LWJ1ZmZlciAoY2FyIG1vdXNlLWRyYWctYW5kLWRyb3Atb3Zl cmxheXMpKQogICAgICAgICAgICAgICAgICAgICAgICAgICAgYnVmZmVyLXRvLXBhc3RlKQotICAg ICAgICAgICAgICAgICAgICAgICAoPD0gKG92ZXJsYXktc3RhcnQgbW91c2UtZHJhZy1hbmQtZHJv cC1vdmVybGF5KQotICAgICAgICAgICAgICAgICAgICAgICAgICBwb2ludC10by1wYXN0ZSkKLSAg ICAgICAgICAgICAgICAgICAgICAgKDw9IHBvaW50LXRvLXBhc3RlCi0gICAgICAgICAgICAgICAg ICAgICAgICAgIChvdmVybGF5LWVuZCBtb3VzZS1kcmFnLWFuZC1kcm9wLW92ZXJsYXkpKSkpKQor ICAgICAgICAgICAgICAgICAgICAgICAoaWYgcmVnaW9uLW5vbmNvbnRpZ3VvdXMKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgIDs7IElmIHRoZSByZWdpb24gaXMgcmVjdGFuZ3VsYXIsIGNoZWNr IGlmIHRoZSBuZXdseSBpbnNlcnRlZAorICAgICAgICAgICAgICAgICAgICAgICAgICAgOzsgcmVj dGFuZ3VsYXIgdGV4dCB3b3VsZCBpbnRlcnNlY3QgdGhlIGFscmVhZHkgc2VsZWN0ZWQKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgIDs7IHJlZ2lvbi4gSWYgaXQgd291bGQsIHRoZW4gc2V0ICJk cmFnLWJ1dC1uZWdsaWdpYmxlIiB0byB0LgorICAgICAgICAgICAgICAgICAgICAgICAgICAgKGxl dCAoKHNpemUgKGNvbnMgcmVnaW9uLXdpZHRoIHJlZ2lvbi1oZWlnaHQpKSkKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgKHJlY3RhbmdsZS1pbnRlcnNlY3QtcAorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgKHJlY3RhbmdsZS1wb3NpdGlvbi1hcy1jb29yZGluYXRlcyBzdGFydCkg c2l6ZQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKHJlY3RhbmdsZS1wb3NpdGlvbi1h cy1jb29yZGluYXRlcyBwb2ludC10by1wYXN0ZSkgc2l6ZSkpCisgICAgICAgICAgICAgICAgICAg ICAgICAgKGFuZCAoPD0gKG92ZXJsYXktc3RhcnQgKGNhciBtb3VzZS1kcmFnLWFuZC1kcm9wLW92 ZXJsYXlzKSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwb2ludC10by1wYXN0 ZSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICg8PSBwb2ludC10by1wYXN0ZQorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChvdmVybGF5LWVuZCAoY2FyIG1vdXNlLWRy YWctYW5kLWRyb3Atb3ZlcmxheXMpKSkpKSkpKQogCiAgICAgICAgICAgOzsgU2hvdyBhIHRvb2x0 aXAuCiAgICAgICAgICAgKGlmIG1vdXNlLWRyYWctYW5kLWRyb3AtcmVnaW9uLXNob3ctdG9vbHRp cApAQCAtMjUyNCw4ICsyNTUyLDkgQEAgbW91c2UtZHJhZy1hbmQtZHJvcC1yZWdpb24KICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAodAogICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAnYmFyKSkpCiAgICAgICAgICAgICAod2hlbiBjdXJzb3ItaW4tdGV4dC1hcmVhCi0gICAg ICAgICAgICAgIChvdmVybGF5LXB1dCBtb3VzZS1kcmFnLWFuZC1kcm9wLW92ZXJsYXkKLSAgICAg ICAgICAgICAgICAgICAgICAgICAgICdmYWNlICdtb3VzZS1kcmFnLWFuZC1kcm9wLXJlZ2lvbikK KyAgICAgICAgICAgICAgKGRvbGlzdCAob3ZlcmxheSBtb3VzZS1kcmFnLWFuZC1kcm9wLW92ZXJs YXlzKQorICAgICAgICAgICAgICAgIChvdmVybGF5LXB1dCBvdmVybGF5CisgICAgICAgICAgICAg ICAgICAgICAgICAgICAnZmFjZSAnbW91c2UtZHJhZy1hbmQtZHJvcC1yZWdpb24pKQogICAgICAg ICAgICAgICAoZGVhY3RpdmF0ZS1tYXJrKSAgICAgOyBNYWludGFpbiByZWdpb24gaW4gb3RoZXIg d2luZG93LgogICAgICAgICAgICAgICAobW91c2Utc2V0LXBvaW50IGV2ZW50KSkpKSkKIApAQCAt MjU4MSw3ICsyNjEwLDkgQEAgbW91c2UtZHJhZy1hbmQtZHJvcC1yZWdpb24KICAgICAgICAgICAo c2VsZWN0LXdpbmRvdyB3aW5kb3cpCiAgICAgICAgICAgKGdvdG8tY2hhciBwb2ludCkKICAgICAg ICAgICAoc2V0cSBkZWFjdGl2YXRlLW1hcmsgbmlsKQotICAgICAgICAgIChhY3RpdmF0ZS1tYXJr KSkKKyAgICAgICAgICAoYWN0aXZhdGUtbWFyaykKKyAgICAgICAgICAod2hlbiByZWdpb24tbm9u Y29udGlndW91cworICAgICAgICAgICAgKHJlY3RhbmdsZS1tYXJrLW1vZGUpKSkKICAgICAgICAg IDs7IE1vZGlmeSBidWZmZXJzLgogICAgICAgICAgKHQKICAgICAgICAgICA7OyAqIERFU1RJTkFU SU9OIEJVRkZFUjo6CkBAIC0yNTkwLDExICsyNjIxLDE3IEBAIG1vdXNlLWRyYWctYW5kLWRyb3At cmVnaW9uCiAgICAgICAgICAgKHNldHEgd2luZG93LWV4ZW1wdCB3aW5kb3ctdG8tcGFzdGUpCiAg ICAgICAgICAgKGdvdG8tY2hhciBwb2ludC10by1wYXN0ZSkKICAgICAgICAgICAocHVzaC1tYXJr KQotICAgICAgICAgIChpbnNlcnQgdmFsdWUtc2VsZWN0aW9uKQorCisgICAgICAgICAgKGlmIHJl Z2lvbi1ub25jb250aWd1b3VzCisgICAgICAgICAgICAgIChpbnNlcnQtcmVjdGFuZ2xlIChzcGxp dC1zdHJpbmcgdmFsdWUtc2VsZWN0aW9uICJcbiIpKQorICAgICAgICAgICAgKGluc2VydCB2YWx1 ZS1zZWxlY3Rpb24pKQorCiAgICAgICAgICAgOzsgT24gc3VjY2Vzcywgc2V0IHRoZSB0ZXh0IGFz IHJlZ2lvbiBvbiBkZXN0aW5hdGlvbiBidWZmZXIuCiAgICAgICAgICAgKHdoZW4gKG5vdCAoZXF1 YWwgKG1hcmspIChwb2ludCkpKQogICAgICAgICAgICAgKHNldHEgZGVhY3RpdmF0ZS1tYXJrIG5p bCkKLSAgICAgICAgICAgIChhY3RpdmF0ZS1tYXJrKSkKKyAgICAgICAgICAgIChhY3RpdmF0ZS1t YXJrKQorICAgICAgICAgICAgKHdoZW4gcmVnaW9uLW5vbmNvbnRpZ3VvdXMKKyAgICAgICAgICAg ICAgKHJlY3RhbmdsZS1tYXJrLW1vZGUpKSkKIAogICAgICAgICAgIDs7ICogU09VUkNFIEJVRkZF Ujo6CiAgICAgICAgICAgOzsgU2V0IGJhY2sgdGhlIG9yaWdpbmFsIHRleHQgYXMgcmVnaW9uIG9y IGRlbGV0ZSB0aGUgb3JpZ2luYWwKQEAgLTI2MDQsOCArMjY0MSw5IEBAIG1vdXNlLWRyYWctYW5k LWRyb3AtcmVnaW9uCiAgICAgICAgICAgICAgIDs7IHJlbW92ZSB0aGUgb3JpZ2luYWwgdGV4dC4K ICAgICAgICAgICAgICAgKHdoZW4gbm8tbW9kaWZpZXItb24tZHJvcAogICAgICAgICAgICAgICAg IChsZXQgKGRlYWN0aXZhdGUtbWFyaykKLSAgICAgICAgICAgICAgICAgIChkZWxldGUtcmVnaW9u IChvdmVybGF5LXN0YXJ0IG1vdXNlLWRyYWctYW5kLWRyb3Atb3ZlcmxheSkKLSAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIChvdmVybGF5LWVuZCBtb3VzZS1kcmFnLWFuZC1kcm9wLW92 ZXJsYXkpKSkpCisgICAgICAgICAgICAgICAgICAoZG9saXN0IChvdmVybGF5IG1vdXNlLWRyYWct YW5kLWRyb3Atb3ZlcmxheXMpCisgICAgICAgICAgICAgICAgICAgIChkZWxldGUtcmVnaW9uIChv dmVybGF5LXN0YXJ0IG92ZXJsYXkpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IChvdmVybGF5LWVuZCBvdmVybGF5KSkpKSkKICAgICAgICAgICAgIDs7IFdoZW4gc291cmNlIGJ1 ZmZlciBhbmQgZGVzdGluYXRpb24gYnVmZmVyIGFyZSBkaWZmZXJlbnQsCiAgICAgICAgICAgICA7 OyBrZWVwIChzZXQgYmFjayB0aGUgb3JpZ2luYWwgdGV4dCBhcyByZWdpb24pIG9yIHJlbW92ZSB0 aGUKICAgICAgICAgICAgIDs7IG9yaWdpbmFsIHRleHQuCkBAIC0yNjE1LDE1ICsyNjUzLDE3IEBA IG1vdXNlLWRyYWctYW5kLWRyb3AtcmVnaW9uCiAgICAgICAgICAgICAoaWYgbW91c2UtZHJhZy1h bmQtZHJvcC1yZWdpb24tY3V0LXdoZW4tYnVmZmVycy1kaWZmZXIKICAgICAgICAgICAgICAgICA7 OyBSZW1vdmUgdGhlIGRyYWdnZWQgdGV4dCBmcm9tIHNvdXJjZSBidWZmZXIgbGlrZQogICAgICAg ICAgICAgICAgIDs7IG9wZXJhdGlvbiBgY3V0Jy4KLSAgICAgICAgICAgICAgICAoZGVsZXRlLXJl Z2lvbiAob3ZlcmxheS1zdGFydCBtb3VzZS1kcmFnLWFuZC1kcm9wLW92ZXJsYXkpCi0gICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgKG92ZXJsYXktZW5kIG1vdXNlLWRyYWctYW5kLWRyb3At b3ZlcmxheSkpCisgICAgICAgICAgICAgICAgKGRvbGlzdCAob3ZlcmxheSBtb3VzZS1kcmFnLWFu ZC1kcm9wLW92ZXJsYXlzKQorICAgICAgICAgICAgICAgICAgICAoZGVsZXRlLXJlZ2lvbiAob3Zl cmxheS1zdGFydCBvdmVybGF5KQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAo b3ZlcmxheS1lbmQgb3ZlcmxheSkpKQogICAgICAgICAgICAgICA7OyBTZXQgYmFjayB0aGUgZHJh Z2dlZCB0ZXh0IGFzIHJlZ2lvbiBvbiBzb3VyY2UgYnVmZmVyCiAgICAgICAgICAgICAgIDs7IGxp a2Ugb3BlcmF0aW9uIGBjb3B5Jy4KICAgICAgICAgICAgICAgKGFjdGl2YXRlLW1hcmspKQogICAg ICAgICAgICAgKHNlbGVjdC13aW5kb3cgd2luZG93LXRvLXBhc3RlKSkpKSkpCiAKICAgICA7OyBD bGVhbiB1cC4KLSAgICAoZGVsZXRlLW92ZXJsYXkgbW91c2UtZHJhZy1hbmQtZHJvcC1vdmVybGF5 KQorICAgIChkb2xpc3QgKG92ZXJsYXkgbW91c2UtZHJhZy1hbmQtZHJvcC1vdmVybGF5cykKKyAg ICAgIChkZWxldGUtb3ZlcmxheSBvdmVybGF5KSkKIAogICAgIDs7IFJlc3RvcmUgb2xkIHN0YXRl cyBidXQgZm9yIHRoZSB3aW5kb3cgd2hlcmUgdGhlIGRyb3AKICAgICA7OyBvY2N1cnJlZC4gUmVz dG9yZSBjdXJzb3IgdHlwZXMgZm9yIGFsbCB3aW5kb3dzLgpkaWZmIC0tZ2l0IGEvbGlzcC9yZWN0 LmVsIGIvbGlzcC9yZWN0LmVsCmluZGV4IDhjY2YwNTFlZTEuLjA0NTYyNDJmNjQgMTAwNjQ0Ci0t LSBhL2xpc3AvcmVjdC5lbAorKysgYi9saXNwL3JlY3QuZWwKQEAgLTE2Nyw2ICsxNjcsNDEgQEAg YXBwbHktb24tcmVjdGFuZ2xlCiAgICAgICAgICAgICAgICAgICg8PSAocG9pbnQpIGVuZHB0KSkp KQogICAgICAgZmluYWwtcG9pbnQpKSkKIAorKGRlZnVuIHJlY3RhbmdsZS1wb3NpdGlvbi1hcy1j b29yZGluYXRlcyAocG9zaXRpb24pCisgICJSZXR1cm4gYW4gaW50ZWdlciBidWZmZXIgcG9zaXRp b24gYXMgYSAoQ09MIC4gTElORSkgY29vcmRpbmF0ZS4iCisgIChzYXZlLWV4Y3Vyc2lvbgorICAg IChnb3RvLWNoYXIgcG9zaXRpb24pCisgICAgKGxldCAoKGNvbCAoY3VycmVudC1jb2x1bW4pKQor ICAgICAgICAgIChsaW5lIChwcm9nbgorICAgICAgICAgICAgICAgICAgKGJlZ2lubmluZy1vZi1s aW5lKQorICAgICAgICAgICAgICAgICAgKGNvdW50LWxpbmVzIDEgcG9zaXRpb24pKSkpCisgICAg ICAoY29ucyBjb2wgbGluZSkpKSkKKworKGRlZnVuIHJlY3RhbmdsZS1pbnRlcnNlY3QtcCAocG9z MSBzaXplMSBwb3MyIHNpemUyKQorICAiUmV0dXJuIHQgaWYgdGhlIHJlY3RhbmdsZSBkZWZpbmVk IGJ5IFBPUzEgYW5kIFNJWkUxIGludGVyc2VjdHMgd2l0aAordGhlIG9uZSBkZWZpbmVkIGJ5IFBP UzIgYW5kIFNJWkUyLCBhbmQgcmV0dXJuIG5pbCBpZiB0aGV5IGRvIG5vdC4KKworUE9TMSBhbmQg UE9TMiBzaG91bGQgZGVzY3JpYmUgdGhlIHBvc2l0aW9ucyBvZiB0aGUgdXBwZXItbGVmdAorY29y bmVycyBvZiB0aGUgZmlyc3QgYW5kIHNlY29uZCByZWN0YW5nbGVzLCBpbiB0aGUgZm9ybSBvZiAo Q09MIC4gTElORSkuCitTSVpFMSBhbmQgU0laRTIgc2hvdWxkIGRlc2NyaWJlIHRoZSBkaW1lbnNp b25zIG9mIHRoZSBmaXJzdCBhbmQgc2Vjb25kCityZWN0YW5nbGVzLCBpbiB0aGUgZm9ybSBvZiAo V0lEVEggLiBIRUlHSFQpLiIKKyAgKGxldCAoKHgxIChjYXIgcG9zMSkpCisgICAgICAgICh5MSAo Y2RyIHBvczEpKQorICAgICAgICAoeDIgKGNhciBwb3MyKSkKKyAgICAgICAgKHkyIChjZHIgcG9z MikpCisgICAgICAgICh3MSAoY2FyIHNpemUxKSkKKyAgICAgICAgKGgxIChjZHIgc2l6ZTEpKQor ICAgICAgICAodzIgKGNhciBzaXplMikpCisgICAgICAgIChoMiAoY2RyIHNpemUyKSkpCisgICAg KG5vdCAob3IgKDw9ICgrIHgxIHcxKQorICAgICAgICAgICAgICAgICB4MikKKyAgICAgICAgICAg ICAoPD0gKCsgeDIgdzIpCisgICAgICAgICAgICAgICAgIHgxKQorICAgICAgICAgICAgICg8PSAo KyB5MSBoMSkKKyAgICAgICAgICAgICAgICAgeTIpCisgICAgICAgICAgICAgKDw9ICgrIHkyIGgy KQorICAgICAgICAgICAgICAgICB5MSkpKSkpCisKIChkZWZ1biBkZWxldGUtcmVjdGFuZ2xlLWxp bmUgKHN0YXJ0Y29sIGVuZGNvbCBmaWxsKQogICAod2hlbiAoPSAobW92ZS10by1jb2x1bW4gc3Rh cnRjb2wgKGlmIGZpbGwgdCAnY29lcmNlKSkgc3RhcnRjb2wpCiAgICAgKGRlbGV0ZS1yZWdpb24g KHBvaW50KQotLSAKMi4xNy4xCgo= --000000000000c76f6105770acc5c-- From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 30 04:00:05 2018 Received: (at 31240) by debbugs.gnu.org; 30 Sep 2018 08:00:05 +0000 Received: from localhost ([127.0.0.1]:59393 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g6We5-0000xV-8p for submit@debbugs.gnu.org; Sun, 30 Sep 2018 04:00:05 -0400 Received: from mout.gmx.net ([212.227.15.18]:54127) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g6We3-0000wR-Gr for 31240@debbugs.gnu.org; Sun, 30 Sep 2018 04:00:04 -0400 Received: from [192.168.1.101] ([213.162.73.174]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MGBdv-1fvJ1F150h-00FE1W; Sun, 30 Sep 2018 09:59:50 +0200 Received: from [192.168.1.101] ([213.162.73.174]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MGBdv-1fvJ1F150h-00FE1W; Sun, 30 Sep 2018 09:59:50 +0200 Message-ID: <5BB08276.1020309@gmx.at> Date: Sun, 30 Sep 2018 09:59:50 +0200 From: martin rudalics MIME-Version: 1.0 To: Federico Tedin Subject: Re: bug#31240: 26.1; mouse-save-then-kill does not kill rectangles References: <5BADDC88.7010206@gmx.at> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:/dSXc8LzmzoBqQN/dKsE6zglmsSxXSNddVjar8r9oL/u4E3q0zT X9cPA0Yk1fmjKOkDvqw7oYw9P25br0abk3b7hD0sxDsF+9ex84qMCBm7LiZ/49r8C7LfmgR Bs3GFGy7/9v1BNHiaWiPU4DaU1InHQsQhT2lca4AKI+ktDXty/4fpFgR8ns+iAJI8lwUDWl ShpKpxz/QrGaM3ai+spKQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:aENGCirwL8I=:7Vk/wK6rnjJ3OhnFxIXbDo NWS7ThTh299wLwst2+6h7uw5HGiLnD95PyQV9ItQLLLeKihX/U0M3gluOh2qIH2rz0GhMpiiC BkcetG1LCITH3UiMYOrX6dc0Ign71J8kIf1g3NhSc2QRQQnwKGJhmhyWyGwao/UJ8wZ/kpNO3 LtdNDqcWKE4Sbq0ac7+PGosg51cKGxgjZ8Gga+pr1Arj9IEP3ZsHZ0PYcCQuBgj8JrDxhS2/6 NbvAfeQOtvOpwbAQGZi1kF4q7Jm2pzZT4IOVOOOU8awr+zR5VOZkImFWB4+7C8Pwj+VT60bPH v3JLhqB6h1w7bWhx/iRD4FfLqE17DDjUpMRjHxfEeprpZh49I7ARaIMwwbqJjTYEZAb8Sjz+h 7ZZTw2WZvRF4rDdhHYBwCZ/2LTikmFVNyi9mL+bvRLZF7zWDHUSYuwKD1X2PSNeE5Lu6a9ePV NnA5O+RFTyraiJh2DUMKEytSD3YOyXZnnPWWYIezqhQoygxAptqvrezfVTLaUpwUGLTQ24+SM c9Apmqf5vMfXOtsEKON1G2sZcRRH/5x4y7HbDGHAvrQ8H3EeJbdHQw8szBzZd0m21Q+B0yvZe uclHFRzm57V6s8Y7TVMSA/Jfq71AeUxLWaN9raZ5gnkkbOulnobjFou5PY052KynJgyTHldd3 WjwJ1IV2qqdT1U5MjWfdi/0NDVqlUMqW4K3CV8rVOr7PRD+DlUKnO+yx5mm46LLK1u9g+0mZr 2jDcWoEtaTdwMiM96llLdVyaTJd+mfTpc4uyS9f9CB7dfJaNqNiHNen9rSGEefD/dqj7KPr3m kg5u5LXCjLTasa3FrvvpTbUnnhqV/+FA3vzM8jF2L8M5R+5XNQ= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 31240 Cc: 31240@debbugs.gnu.org, charles@aurox.ch X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > After trying out some solutions and reading these two suggestions, I've > decided to implement the feature like this. The problem of correctly handling > the cases where the dragged rectangular text would overlap with the original > one was more complex than I'd thought, and I have some doubts if the usefulness > of the feature justifies this added complexity. > > I'm attaching a new patch with all my changes to mouse.el (and rect.el) so far. > I've created two new helper functions in rect.el to avoid cluttering mouse.el > with more functions. > > So, the cases to test out are: > > 1) Dragging and dropping non-rectangular regions should be exactly the > same as before. > 2) Dragging and dropping a rectangle _outside_ of itself should insert > it in the new > position, and then delete the original. > 3) Dragging and dropping a rectangle _inside_ of itself should leave > everything unchanged. > > After evaluating "(setq mouse-drag-and-drop-region 'shift)": > > 4) Dragging and dropping a rectangle inside or outside of itself, while holding > the Shift key when dropping, should insert it there, without deleting > the original. > > When I say 'outside of itself' I mean that there shouldn't be any > overlapping at all > between the original and the newly inserted rectangles. Thank you. From what I can tell, the patch correctly addresses the cases enumerated. Since I don't use rectangle functions I'd urge someone who does use them on a more regular basis to test it. A few issues: I'd rewrite the doc-string of 'rectangle-position-as-coordinates' as something like (defun rectangle-position-as-coordinates (position) "Return cons of the column and line values of POSITION. POSITION specifies a position of the current buffer. The value returned is a cons of the current column of POSITION and its line number." because doc-strings have to describe all arguments of a functions. Also, (count-lines 1 position)))) should become (count-lines (point-min) position)))) And I'd rewrite the doc-string of 'rectangle-intersect-p' like (defun rectangle-intersect-p (pos1 size1 pos2 size2) "Return non-nil if two rectangles intersect. POS1 and POS2 specify the positions of the upper-left corners of the first and second rectangle as conses of their column and line values. SIZE1 and SIZE2 specify the dimensions of the first and second rectangle, as conses of their width and height measured in columns and lines." because the first line of a doc-string must be a complete sentence. Also I'd rewrite forms like (<= (+ x2 w2) x1) as (<= (+ x2 w2) x1) although this still won't make your patch short enough to qualify as "tiny change". So if you haven't done so already, please start the paperwork process so we can apply this patch. Thanks again for working on this, martin From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 30 11:42:12 2018 Received: (at 31240) by debbugs.gnu.org; 30 Sep 2018 15:42:12 +0000 Received: from localhost ([127.0.0.1]:60127 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g6drI-000638-28 for submit@debbugs.gnu.org; Sun, 30 Sep 2018 11:42:12 -0400 Received: from sinyavsky.aurox.ch ([37.35.109.145]:53111) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g6drG-00062v-Bc for 31240@debbugs.gnu.org; Sun, 30 Sep 2018 11:42:11 -0400 Received: from sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) by sinyavsky.aurox.ch (Postfix) with ESMTP id D86DA2287C for <31240@debbugs.gnu.org>; Sun, 30 Sep 2018 15:46:00 +0000 (UTC) Authentication-Results: sinyavsky.aurox.ch (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= references:reply-to:subject:subject:in-reply-to:to:from:from :message-id:date:date; s=dkim; t=1538322359; x=1539186360; bh=xu 264im6l3vEzvO0SB743xQYAYxpgVPTgQw0zS42uMA=; b=F3WeOz3HwZt8XyCnig JFMTYP5hnUSIFYkUfFPZu5REIwM2hNes2SkXFSLVTfLUvEGWmYCTArAhQKS5mOvJ O3G0kDZ6gRlbf0T7wtf8X0jEuhdygxc8jCEK4SHsqJ0KZiKePTGahB0jSRqLrdSU 6Tw+QF30OSRg78qXswTRwP2FU= X-Virus-Scanned: Debian amavisd-new at test.virtualizor.com Received: from sinyavsky.aurox.ch ([127.0.0.1]) by sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id cjaKsHmyfxzO for <31240@debbugs.gnu.org>; Sun, 30 Sep 2018 15:45:59 +0000 (UTC) Received: from gray (unknown [IPv6:2a02:1205:c693:2d60:c62c:3ff:fe30:b864]) by sinyavsky.aurox.ch (Postfix) with ESMTPSA id B94C5226F4; Sun, 30 Sep 2018 15:45:59 +0000 (UTC) Date: Sun, 30 Sep 2018 17:45:06 +0200 Message-Id: From: charles@aurox.ch (Charles A. Roelli) To: Federico Tedin In-reply-to: (message from Federico Tedin on Sat, 29 Sep 2018 20:18:59 -0300) Subject: Re: bug#31240: 26.1; mouse-save-then-kill does not kill rectangles References: <5BADDC88.7010206@gmx.at> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 31240 Cc: rudalics@gmx.at, 31240@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: charles@aurox.ch Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Thanks for the updated patch, it looks good to me. I have one small suggestion: > +(defun rectangle-position-as-coordinates (position) > + "Return an integer buffer position as a (COL . LINE) coordinate." > + (save-excursion > + (goto-char position) > + (let ((col (current-column)) > + (line (progn > + (beginning-of-line) > + (count-lines 1 position)))) > + (cons col line)))) (beginning-of-line) could be replaced with (forward-line 0), which is guaranteed to be at the beginning of the line. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 30 12:20:51 2018 Received: (at 31240) by debbugs.gnu.org; 30 Sep 2018 16:20:51 +0000 Received: from localhost ([127.0.0.1]:60145 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g6eSh-00070I-1s for submit@debbugs.gnu.org; Sun, 30 Sep 2018 12:20:51 -0400 Received: from mail-lj1-f171.google.com ([209.85.208.171]:45169) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g6eSf-000706-DW for 31240@debbugs.gnu.org; Sun, 30 Sep 2018 12:20:50 -0400 Received: by mail-lj1-f171.google.com with SMTP id x16-v6so9860976ljd.12 for <31240@debbugs.gnu.org>; Sun, 30 Sep 2018 09:20:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oNLazo+zmNGMLAsrR+7wwSBPwVpabI4kSTGrt9ikt9A=; b=AZlEgUbZ5Bfr7NhlRnZYfMc9bw9/l/piGxufQ96ajVMtumVuokweiBBt8oHhf22j0O pfQ5pjDsXlrkrPiPVMmtw0sHbgP6x1zKgAVcSs3i35N15lQbrjCm6fI21VZRTCVPfnCs mYMWIyymL9K6z5EEAzrCLUqk+x3EStZaeJGJFB3bePN1QdmwKfno8BjG1lJwDtr5rq3W hvfwKdK36irq2Yu6DBbBEpNLFWjVb0nvOcv7zqFYJIoDzEKh0VDITeoHqXCewJ3YkLTy A/buAjktiPrhPunzE8oCX0IS34bMwhgJ1TIcbi7YpYWfgWMcMiwdMhfx0EvQ1+IETIPc r1+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oNLazo+zmNGMLAsrR+7wwSBPwVpabI4kSTGrt9ikt9A=; b=DBLYLz9zG0QLG0n8VH4PTp6Nb4JrgTvFNxxCZ7O6ODNRBRya4IM6T3J/mqjlLVOoSz qc32+kLsXZR7q+yU7qfpBdW9YzgFKARov52z6mmTsWdbMIzbMG2wSxjQsw+OLNXASroi ev1NPoK+erkRnrHUk7FB3dXUsAhA8R6WTT+Zf74BGmXfgwcTsUVAP0eYXqUk0ZTquYjN RHikgUkdAqwLdMYH2OLwpEpEHsksG91f3OSCz2FEveITJR1PX7+BNdX76gotXG+JMC6B q7vq6+5vpMUWSuNxye+yWiFdfQyxkmiaAID95BkJ69j9B93/sxQxAttY2KHd24IpIILC UClQ== X-Gm-Message-State: ABuFfogenmXY0iK3JhrF7nCQ00FaxKi5+swAfCH6utZyOBhOzjEZ3fkL B44ZY+jaMMzk6ZirEzbD1peTcK4qTMxyGJe4HNg= X-Google-Smtp-Source: ACcGV60AFahCCdIt13YCDnYRrEBD1T7vEPmsab0usGqUHQh6mZJDi7FgJZveJru2UTf3icVD3UU/aD7bd72k1eeU2wg= X-Received: by 2002:a2e:48d:: with SMTP id a13-v6mr4123543ljf.27.1538324443322; Sun, 30 Sep 2018 09:20:43 -0700 (PDT) MIME-Version: 1.0 References: <5BADDC88.7010206@gmx.at> In-Reply-To: From: Federico Tedin Date: Sun, 30 Sep 2018 13:20:31 -0300 Message-ID: Subject: Re: bug#31240: 26.1; mouse-save-then-kill does not kill rectangles To: charles@aurox.ch Content-Type: multipart/mixed; boundary="000000000000fe76db05771911a9" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31240 Cc: rudalics@gmx.at, 31240@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000fe76db05771911a9 Content-Type: text/plain; charset="UTF-8" Martin, Charles: Thanks for the suggestions, I've applied them and I'm attaching the new patch here. > although this still won't make your patch short enough to qualify as > "tiny change". So if you haven't done so already, please start the > paperwork process so we can apply this patch. This shouldn't be a problem, my copyright assignment was filed one or two months ago, and since then I've contributed two patches which have already been merged. --000000000000fe76db05771911a9 Content-Type: text/x-patch; charset="US-ASCII"; name="mouse.patch" Content-Disposition: attachment; filename="mouse.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jmp2l05m0 RnJvbSBlYjVhZDZmYTVhMjk0OGY1YzMyNDk5MjdmOTRlMzE5ZDM4ZmE5MGJhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBGZWRlcmljbyBUZWRpbiA8ZmVkZXJpY290ZWRpbkBnbWFpbC5j b20+CkRhdGU6IFN1biwgMzAgU2VwIDIwMTggMTM6MDk6MTAgLTAzMDAKU3ViamVjdDogW1BBVENI XSBBbGxvdyB0d28gbW91c2UgZnVuY3Rpb25zIHRvIHdvcmsgd2l0aCBSZWN0YW5nbGUgTWFyayBt b2RlCgoqIGxpc3AvbW91c2UuZWwgKG1vdXNlLXNhdmUtdGhlbi1raWxsKTogTWFrZSBtb3VzZS1z YXZlLXRoZW4ta2lsbCB3b3JrCiAgd2l0aCByZWN0YW5ndWxhciByZWdpb25zLCBpbmNsdWRpbmcg d2hlbiBtb3VzZS1kcmFnLWNvcHktcmVnaW9uIGlzCiAgc2V0IHRvIHQuIChCdWcjMzEyNDApCiAg KG1vdXNlLWRyYWctYW5kLWRyb3AtcmVnaW9uKTogQWxsb3cgZHJhZ2dpbmcgYW5kIGRyb3BwaW5n CiAgcmVjdGFuZ3VsYXIgcmVnaW9ucy4gKEJ1ZyMzMTI0MCkKKiByZWN0LmVsIChyZWN0YW5nbGUt aW50ZXJzZWN0LXApOiBBZGQgYSBuZXcgZnVuY3Rpb24uCiAgKHJlY3RhbmdsZS1wb3NpdGlvbi1h cy1jb29yZGluYXRlcyk6IEFkZCBhIG5ldyBmdW5jdGlvbi4KLS0tCiBsaXNwL21vdXNlLmVsIHwg OTIgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tCiBs aXNwL3JlY3QuZWwgIHwgMzMgKysrKysrKysrKysrKysrKysrCiAyIGZpbGVzIGNoYW5nZWQsIDk5 IGluc2VydGlvbnMoKyksIDI2IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3AvbW91c2Uu ZWwgYi9saXNwL21vdXNlLmVsCmluZGV4IGNiNjNjYTUxYzUuLmIwMGYzOGEwZjYgMTAwNjQ0Ci0t LSBhL2xpc3AvbW91c2UuZWwKKysrIGIvbGlzcC9tb3VzZS5lbApAQCAtMjksNiArMjksOCBAQAog CiA7OzsgQ29kZToKIAorKGV2YWwtd2hlbi1jb21waWxlIChyZXF1aXJlICdyZWN0KSkKKwogOzs7 IFV0aWxpdHkgZnVuY3Rpb25zLgogCiA7OyBJbmRlbnQgdHJhY2stbW91c2UgbGlrZSBwcm9nbi4K QEAgLTE2MDYsOCArMTYwOCw4IEBAIG1vdXNlLXNhdmUtdGhlbi1raWxsCiAgICAgICAoaWYgbW91 c2UtZHJhZy1jb3B5LXJlZ2lvbgogICAgICAgICAgIDs7IFJlZ2lvbiBhbHJlYWR5IHNhdmVkIGlu IHRoZSBwcmV2aW91cyBjbGljazsKICAgICAgICAgICA7OyBkb24ndCBtYWtlIGEgZHVwbGljYXRl IGVudHJ5LCBqdXN0IGRlbGV0ZS4KLSAgICAgICAgICAoZGVsZXRlLXJlZ2lvbiAobWFyayB0KSAo cG9pbnQpKQotICAgICAgICAoa2lsbC1yZWdpb24gKG1hcmsgdCkgKHBvaW50KSkpCisgICAgICAg ICAgKGZ1bmNhbGwgcmVnaW9uLWV4dHJhY3QtZnVuY3Rpb24gJ2RlbGV0ZS1vbmx5KQorICAgICAg ICAoa2lsbC1yZWdpb24gKG1hcmsgdCkgKHBvaW50KSAncmVnaW9uKSkKICAgICAgIChzZXRxIG1v dXNlLXNlbGVjdGlvbi1jbGljay1jb3VudCAwKQogICAgICAgKHNldHEgbW91c2Utc2F2ZS10aGVu LWtpbGwtcG9zbiBuaWwpKQogCkBAIC0xNjMyLDcgKzE2MzQsNyBAQCBtb3VzZS1zYXZlLXRoZW4t a2lsbAogCShtb3VzZS1zZXQtcmVnaW9uLTEpCiAgICAgICAgICh3aGVuIG1vdXNlLWRyYWctY29w eS1yZWdpb24KICAgICAgICAgICA7OyBSZWdpb24gYWxyZWFkeSBjb3BpZWQgdG8ga2lsbC1yaW5n IG9uY2UsIHNvIHJlcGxhY2UuCi0gICAgICAgICAgKGtpbGwtbmV3IChmaWx0ZXItYnVmZmVyLXN1 YnN0cmluZyAobWFyayB0KSAocG9pbnQpKSB0KSkKKyAgICAgICAgICAoa2lsbC1uZXcgKGZ1bmNh bGwgcmVnaW9uLWV4dHJhY3QtZnVuY3Rpb24gbmlsKSB0KSkKIAk7OyBBcnJhbmdlIGZvciBhIHJl cGVhdGVkIG1vdXNlLTMgdG8ga2lsbCB0aGUgcmVnaW9uLgogCShzZXRxIG1vdXNlLXNhdmUtdGhl bi1raWxsLXBvc24gY2xpY2stcHQpKSkKIApAQCAtMjQxMSw3ICsyNDEzLDE1IEBAIG1vdXNlLWRy YWctYW5kLWRyb3AtcmVnaW9uCiAgICAgICAgICAoYnVmZmVyIChjdXJyZW50LWJ1ZmZlcikpCiAg ICAgICAgICAod2luZG93IChzZWxlY3RlZC13aW5kb3cpKQogICAgICAgICAgKHRleHQtZnJvbS1y ZWFkLW9ubHkgYnVmZmVyLXJlYWQtb25seSkKLSAgICAgICAgIChtb3VzZS1kcmFnLWFuZC1kcm9w LW92ZXJsYXkgKG1ha2Utb3ZlcmxheSBzdGFydCBlbmQpKQorICAgICAgICAgOzsgVXNlIG11bHRp cGxlIG92ZXJsYXlzIHRvIGNvdmVyIGNhc2VzIHdoZXJlIHRoZSByZWdpb24gaXMgcmVjdGFuZ3Vs YXIuCisgICAgICAgICAobW91c2UtZHJhZy1hbmQtZHJvcC1vdmVybGF5cyAobWFwY2FyIChsYW1i ZGEgKGJvdW5kcykKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAobWFrZS1vdmVybGF5IChjYXIgYm91bmRzKQorICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGNkciBib3VuZHMpKSkKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKHJlZ2lvbi1ib3Vu ZHMpKSkKKyAgICAgICAgIChyZWdpb24tbm9uY29udGlndW91cyAocmVnaW9uLW5vbmNvbnRpZ3Vv dXMtcCkpCisgICAgICAgICAocmVnaW9uLXdpZHRoICgtIChvdmVybGF5LWVuZCAoY2FyIG1vdXNl LWRyYWctYW5kLWRyb3Atb3ZlcmxheXMpKQorICAgICAgICAgICAgICAgICAgICAgICAgICAob3Zl cmxheS1zdGFydCAoY2FyIG1vdXNlLWRyYWctYW5kLWRyb3Atb3ZlcmxheXMpKSkpCisgICAgICAg ICAocmVnaW9uLWhlaWdodCAobGVuZ3RoIG1vdXNlLWRyYWctYW5kLWRyb3Atb3ZlcmxheXMpKQog ICAgICAgICAgcG9pbnQtdG8tcGFzdGUKICAgICAgICAgIHBvaW50LXRvLXBhc3RlLXJlYWQtb25s eQogICAgICAgICAgd2luZG93LXRvLXBhc3RlCkBAIC0yNDU1LDcgKzI0NjUsMTEgQEAgbW91c2Ut ZHJhZy1hbmQtZHJvcC1yZWdpb24KICAgICAgICAgICA7OyBPYnRhaW4gdGhlIGRyYWdnZWQgdGV4 dCBpbiByZWdpb24uICBXaGVuIHRoZSBsb29wIHdhcwogICAgICAgICAgIDs7IHNraXBwZWQsIHZh bHVlLXNlbGVjdGlvbiByZW1haW5zIG5pbC4KICAgICAgICAgICAodW5sZXNzIHZhbHVlLXNlbGVj dGlvbgotICAgICAgICAgICAgKHNldHEgdmFsdWUtc2VsZWN0aW9uIChidWZmZXItc3Vic3RyaW5n IHN0YXJ0IGVuZCkpCisgICAgICAgICAgICAoc2V0cSB2YWx1ZS1zZWxlY3Rpb24gKGZ1bmNhbGwg cmVnaW9uLWV4dHJhY3QtZnVuY3Rpb24gbmlsKSkKKyAgICAgICAgICAgIDs7IFJlbW92ZSB5YW5r LWhhbmRsZXIgcHJvcGVydHkgaW4gb3JkZXIgdG8gcmUtaW5zZXJ0IHRleHQgdXNpbmcKKyAgICAg ICAgICAgIDs7IHRoZSBgaW5zZXJ0LXJlY3RhbmdsZScgZnVuY3Rpb24gbGF0ZXIgb24uCisgICAg ICAgICAgICAocmVtb3ZlLXRleHQtcHJvcGVydGllcyAwIChsZW5ndGggdmFsdWUtc2VsZWN0aW9u KQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJyh5YW5rLWhhbmRsZXIpIHZh bHVlLXNlbGVjdGlvbikKICAgICAgICAgICAgICh3aGVuIG1vdXNlLWRyYWctYW5kLWRyb3AtcmVn aW9uLXNob3ctdG9vbHRpcAogICAgICAgICAgICAgICAobGV0ICgodGV4dC1zaXplIG1vdXNlLWRy YWctYW5kLWRyb3AtcmVnaW9uLXNob3ctdG9vbHRpcCkpCiAgICAgICAgICAgICAgICAgKHNldHEg dGV4dC10b29sdGlwCkBAIC0yNDY4LDEyICsyNDgyLDE4IEBAIG1vdXNlLWRyYWctYW5kLWRyb3At cmVnaW9uCiAgICAgICAgICAgICAgICAgICAgICAgICB2YWx1ZS1zZWxlY3Rpb24pKSkpCiAKICAg ICAgICAgICAgIDs7IENoZWNrIGlmIHNlbGVjdGVkIHRleHQgaXMgcmVhZC1vbmx5LgotICAgICAg ICAgICAgKHNldHEgdGV4dC1mcm9tLXJlYWQtb25seSAob3IgdGV4dC1mcm9tLXJlYWQtb25seQot ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGdldC10ZXh0LXByb3Bl cnR5IHN0YXJ0ICdyZWFkLW9ubHkpCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAobm90IChlcXVhbAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgKG5leHQtc2luZ2xlLWNoYXItcHJvcGVydHktY2hhbmdlCi0gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3RhcnQgJ3JlYWQtb25seSBu aWwgZW5kKQotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ZW5kKSkpKSkKKyAgICAgICAgICAgIChzZXRxIHRleHQtZnJvbS1yZWFkLW9ubHkKKyAgICAgICAg ICAgICAgICAgIChvciB0ZXh0LWZyb20tcmVhZC1vbmx5CisgICAgICAgICAgICAgICAgICAgICAg KGdldC10ZXh0LXByb3BlcnR5IHN0YXJ0ICdyZWFkLW9ubHkpCisgICAgICAgICAgICAgICAgICAg ICAgKGdldC10ZXh0LXByb3BlcnR5IGVuZCAncmVhZC1vbmx5KQorICAgICAgICAgICAgICAgICAg ICAgIChjYXRjaCAnbG9vcAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoZG9saXN0IChi b3VuZCAocmVnaW9uLWJvdW5kcykpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKHVu bGVzcyAoZXF1YWwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAobmV4 dC1zaW5nbGUtY2hhci1wcm9wZXJ0eS1jaGFuZ2UKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgKGNhciBib3VuZCkgJ3JlYWQtb25seSBuaWwgKGNkciBib3VuZCkpCisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGNkciBib3VuZCkpCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAodGhyb3cgJ2xvb3AgdCkpKSkpKSkKKwogICAg ICAgICAgIChzZXRxIHdpbmRvdy10by1wYXN0ZSAocG9zbi13aW5kb3cgKGV2ZW50LWVuZCBldmVu dCkpKQogICAgICAgICAgIChzZXRxIHBvaW50LXRvLXBhc3RlIChwb3NuLXBvaW50IChldmVudC1l bmQgZXZlbnQpKSkKICAgICAgICAgICA7OyBTZXQgbmlsIHdoZW4gdGFyZ2V0IGJ1ZmZlciBpcyBt aW5pYnVmZmVyLgpAQCAtMjUwMCwxMiArMjUyMCwyMCBAQCBtb3VzZS1kcmFnLWFuZC1kcm9wLXJl Z2lvbgogICAgICAgICAgICAgOzsgdGV4dCB3aWxsIGJlIGluc2VydGVkIHRvIGluc2lkZSBvZiB0 aGUgb3JpZ2luYWwKICAgICAgICAgICAgIDs7IHJlZ2lvbi4KICAgICAgICAgICAgIChzZXRxIGRy YWctYnV0LW5lZ2xpZ2libGUKLSAgICAgICAgICAgICAgICAgIChhbmQgKGVxIChvdmVybGF5LWJ1 ZmZlciBtb3VzZS1kcmFnLWFuZC1kcm9wLW92ZXJsYXkpCisgICAgICAgICAgICAgICAgICAoYW5k IChlcSAob3ZlcmxheS1idWZmZXIgKGNhciBtb3VzZS1kcmFnLWFuZC1kcm9wLW92ZXJsYXlzKSkK ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJ1ZmZlci10by1wYXN0ZSkKLSAgICAgICAgICAg ICAgICAgICAgICAgKDw9IChvdmVybGF5LXN0YXJ0IG1vdXNlLWRyYWctYW5kLWRyb3Atb3Zlcmxh eSkKLSAgICAgICAgICAgICAgICAgICAgICAgICAgcG9pbnQtdG8tcGFzdGUpCi0gICAgICAgICAg ICAgICAgICAgICAgICg8PSBwb2ludC10by1wYXN0ZQotICAgICAgICAgICAgICAgICAgICAgICAg ICAob3ZlcmxheS1lbmQgbW91c2UtZHJhZy1hbmQtZHJvcC1vdmVybGF5KSkpKSkKKyAgICAgICAg ICAgICAgICAgICAgICAgKGlmIHJlZ2lvbi1ub25jb250aWd1b3VzCisgICAgICAgICAgICAgICAg ICAgICAgICAgICA7OyBJZiB0aGUgcmVnaW9uIGlzIHJlY3Rhbmd1bGFyLCBjaGVjayBpZiB0aGUg bmV3bHkgaW5zZXJ0ZWQKKyAgICAgICAgICAgICAgICAgICAgICAgICAgIDs7IHJlY3Rhbmd1bGFy IHRleHQgd291bGQgaW50ZXJzZWN0IHRoZSBhbHJlYWR5IHNlbGVjdGVkCisgICAgICAgICAgICAg ICAgICAgICAgICAgICA7OyByZWdpb24uIElmIGl0IHdvdWxkLCB0aGVuIHNldCAiZHJhZy1idXQt bmVnbGlnaWJsZSIgdG8gdC4KKyAgICAgICAgICAgICAgICAgICAgICAgICAgIChsZXQgKChzaXpl IChjb25zIHJlZ2lvbi13aWR0aCByZWdpb24taGVpZ2h0KSkpCisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIChyZWN0YW5nbGUtaW50ZXJzZWN0LXAKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIChyZWN0YW5nbGUtcG9zaXRpb24tYXMtY29vcmRpbmF0ZXMgc3RhcnQpIHNpemUKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIChyZWN0YW5nbGUtcG9zaXRpb24tYXMtY29vcmRp bmF0ZXMgcG9pbnQtdG8tcGFzdGUpIHNpemUpKQorICAgICAgICAgICAgICAgICAgICAgICAgIChh bmQgKDw9IChvdmVybGF5LXN0YXJ0IChjYXIgbW91c2UtZHJhZy1hbmQtZHJvcC1vdmVybGF5cykp CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcG9pbnQtdG8tcGFzdGUpCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAoPD0gcG9pbnQtdG8tcGFzdGUKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAob3ZlcmxheS1lbmQgKGNhciBtb3VzZS1kcmFnLWFuZC1k cm9wLW92ZXJsYXlzKSkpKSkpKSkKIAogICAgICAgICAgIDs7IFNob3cgYSB0b29sdGlwLgogICAg ICAgICAgIChpZiBtb3VzZS1kcmFnLWFuZC1kcm9wLXJlZ2lvbi1zaG93LXRvb2x0aXAKQEAgLTI1 MjQsOCArMjU1Miw5IEBAIG1vdXNlLWRyYWctYW5kLWRyb3AtcmVnaW9uCiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgKHQKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJ2Jh cikpKQogICAgICAgICAgICAgKHdoZW4gY3Vyc29yLWluLXRleHQtYXJlYQotICAgICAgICAgICAg ICAob3ZlcmxheS1wdXQgbW91c2UtZHJhZy1hbmQtZHJvcC1vdmVybGF5Ci0gICAgICAgICAgICAg ICAgICAgICAgICAgICAnZmFjZSAnbW91c2UtZHJhZy1hbmQtZHJvcC1yZWdpb24pCisgICAgICAg ICAgICAgIChkb2xpc3QgKG92ZXJsYXkgbW91c2UtZHJhZy1hbmQtZHJvcC1vdmVybGF5cykKKyAg ICAgICAgICAgICAgICAob3ZlcmxheS1wdXQgb3ZlcmxheQorICAgICAgICAgICAgICAgICAgICAg ICAgICAgJ2ZhY2UgJ21vdXNlLWRyYWctYW5kLWRyb3AtcmVnaW9uKSkKICAgICAgICAgICAgICAg KGRlYWN0aXZhdGUtbWFyaykgICAgIDsgTWFpbnRhaW4gcmVnaW9uIGluIG90aGVyIHdpbmRvdy4K ICAgICAgICAgICAgICAgKG1vdXNlLXNldC1wb2ludCBldmVudCkpKSkpCiAKQEAgLTI1ODEsNyAr MjYxMCw5IEBAIG1vdXNlLWRyYWctYW5kLWRyb3AtcmVnaW9uCiAgICAgICAgICAgKHNlbGVjdC13 aW5kb3cgd2luZG93KQogICAgICAgICAgIChnb3RvLWNoYXIgcG9pbnQpCiAgICAgICAgICAgKHNl dHEgZGVhY3RpdmF0ZS1tYXJrIG5pbCkKLSAgICAgICAgICAoYWN0aXZhdGUtbWFyaykpCisgICAg ICAgICAgKGFjdGl2YXRlLW1hcmspCisgICAgICAgICAgKHdoZW4gcmVnaW9uLW5vbmNvbnRpZ3Vv dXMKKyAgICAgICAgICAgIChyZWN0YW5nbGUtbWFyay1tb2RlKSkpCiAgICAgICAgICA7OyBNb2Rp ZnkgYnVmZmVycy4KICAgICAgICAgICh0CiAgICAgICAgICAgOzsgKiBERVNUSU5BVElPTiBCVUZG RVI6OgpAQCAtMjU5MCwxMSArMjYyMSwxNyBAQCBtb3VzZS1kcmFnLWFuZC1kcm9wLXJlZ2lvbgog ICAgICAgICAgIChzZXRxIHdpbmRvdy1leGVtcHQgd2luZG93LXRvLXBhc3RlKQogICAgICAgICAg IChnb3RvLWNoYXIgcG9pbnQtdG8tcGFzdGUpCiAgICAgICAgICAgKHB1c2gtbWFyaykKLSAgICAg ICAgICAoaW5zZXJ0IHZhbHVlLXNlbGVjdGlvbikKKworICAgICAgICAgIChpZiByZWdpb24tbm9u Y29udGlndW91cworICAgICAgICAgICAgICAoaW5zZXJ0LXJlY3RhbmdsZSAoc3BsaXQtc3RyaW5n IHZhbHVlLXNlbGVjdGlvbiAiXG4iKSkKKyAgICAgICAgICAgIChpbnNlcnQgdmFsdWUtc2VsZWN0 aW9uKSkKKwogICAgICAgICAgIDs7IE9uIHN1Y2Nlc3MsIHNldCB0aGUgdGV4dCBhcyByZWdpb24g b24gZGVzdGluYXRpb24gYnVmZmVyLgogICAgICAgICAgICh3aGVuIChub3QgKGVxdWFsIChtYXJr KSAocG9pbnQpKSkKICAgICAgICAgICAgIChzZXRxIGRlYWN0aXZhdGUtbWFyayBuaWwpCi0gICAg ICAgICAgICAoYWN0aXZhdGUtbWFyaykpCisgICAgICAgICAgICAoYWN0aXZhdGUtbWFyaykKKyAg ICAgICAgICAgICh3aGVuIHJlZ2lvbi1ub25jb250aWd1b3VzCisgICAgICAgICAgICAgIChyZWN0 YW5nbGUtbWFyay1tb2RlKSkpCiAKICAgICAgICAgICA7OyAqIFNPVVJDRSBCVUZGRVI6OgogICAg ICAgICAgIDs7IFNldCBiYWNrIHRoZSBvcmlnaW5hbCB0ZXh0IGFzIHJlZ2lvbiBvciBkZWxldGUg dGhlIG9yaWdpbmFsCkBAIC0yNjA0LDggKzI2NDEsOSBAQCBtb3VzZS1kcmFnLWFuZC1kcm9wLXJl Z2lvbgogICAgICAgICAgICAgICA7OyByZW1vdmUgdGhlIG9yaWdpbmFsIHRleHQuCiAgICAgICAg ICAgICAgICh3aGVuIG5vLW1vZGlmaWVyLW9uLWRyb3AKICAgICAgICAgICAgICAgICAobGV0IChk ZWFjdGl2YXRlLW1hcmspCi0gICAgICAgICAgICAgICAgICAoZGVsZXRlLXJlZ2lvbiAob3Zlcmxh eS1zdGFydCBtb3VzZS1kcmFnLWFuZC1kcm9wLW92ZXJsYXkpCi0gICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAob3ZlcmxheS1lbmQgbW91c2UtZHJhZy1hbmQtZHJvcC1vdmVybGF5KSkp KQorICAgICAgICAgICAgICAgICAgKGRvbGlzdCAob3ZlcmxheSBtb3VzZS1kcmFnLWFuZC1kcm9w LW92ZXJsYXlzKQorICAgICAgICAgICAgICAgICAgICAoZGVsZXRlLXJlZ2lvbiAob3ZlcmxheS1z dGFydCBvdmVybGF5KQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAob3Zlcmxh eS1lbmQgb3ZlcmxheSkpKSkpCiAgICAgICAgICAgICA7OyBXaGVuIHNvdXJjZSBidWZmZXIgYW5k IGRlc3RpbmF0aW9uIGJ1ZmZlciBhcmUgZGlmZmVyZW50LAogICAgICAgICAgICAgOzsga2VlcCAo c2V0IGJhY2sgdGhlIG9yaWdpbmFsIHRleHQgYXMgcmVnaW9uKSBvciByZW1vdmUgdGhlCiAgICAg ICAgICAgICA7OyBvcmlnaW5hbCB0ZXh0LgpAQCAtMjYxNSwxNSArMjY1MywxNyBAQCBtb3VzZS1k cmFnLWFuZC1kcm9wLXJlZ2lvbgogICAgICAgICAgICAgKGlmIG1vdXNlLWRyYWctYW5kLWRyb3At cmVnaW9uLWN1dC13aGVuLWJ1ZmZlcnMtZGlmZmVyCiAgICAgICAgICAgICAgICAgOzsgUmVtb3Zl IHRoZSBkcmFnZ2VkIHRleHQgZnJvbSBzb3VyY2UgYnVmZmVyIGxpa2UKICAgICAgICAgICAgICAg ICA7OyBvcGVyYXRpb24gYGN1dCcuCi0gICAgICAgICAgICAgICAgKGRlbGV0ZS1yZWdpb24gKG92 ZXJsYXktc3RhcnQgbW91c2UtZHJhZy1hbmQtZHJvcC1vdmVybGF5KQotICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIChvdmVybGF5LWVuZCBtb3VzZS1kcmFnLWFuZC1kcm9wLW92ZXJsYXkp KQorICAgICAgICAgICAgICAgIChkb2xpc3QgKG92ZXJsYXkgbW91c2UtZHJhZy1hbmQtZHJvcC1v dmVybGF5cykKKyAgICAgICAgICAgICAgICAgICAgKGRlbGV0ZS1yZWdpb24gKG92ZXJsYXktc3Rh cnQgb3ZlcmxheSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKG92ZXJsYXkt ZW5kIG92ZXJsYXkpKSkKICAgICAgICAgICAgICAgOzsgU2V0IGJhY2sgdGhlIGRyYWdnZWQgdGV4 dCBhcyByZWdpb24gb24gc291cmNlIGJ1ZmZlcgogICAgICAgICAgICAgICA7OyBsaWtlIG9wZXJh dGlvbiBgY29weScuCiAgICAgICAgICAgICAgIChhY3RpdmF0ZS1tYXJrKSkKICAgICAgICAgICAg IChzZWxlY3Qtd2luZG93IHdpbmRvdy10by1wYXN0ZSkpKSkpKQogCiAgICAgOzsgQ2xlYW4gdXAu Ci0gICAgKGRlbGV0ZS1vdmVybGF5IG1vdXNlLWRyYWctYW5kLWRyb3Atb3ZlcmxheSkKKyAgICAo ZG9saXN0IChvdmVybGF5IG1vdXNlLWRyYWctYW5kLWRyb3Atb3ZlcmxheXMpCisgICAgICAoZGVs ZXRlLW92ZXJsYXkgb3ZlcmxheSkpCiAKICAgICA7OyBSZXN0b3JlIG9sZCBzdGF0ZXMgYnV0IGZv ciB0aGUgd2luZG93IHdoZXJlIHRoZSBkcm9wCiAgICAgOzsgb2NjdXJyZWQuIFJlc3RvcmUgY3Vy c29yIHR5cGVzIGZvciBhbGwgd2luZG93cy4KZGlmZiAtLWdpdCBhL2xpc3AvcmVjdC5lbCBiL2xp c3AvcmVjdC5lbAppbmRleCA4Y2NmMDUxZWUxLi5jYWM4YmUzNjI1IDEwMDY0NAotLS0gYS9saXNw L3JlY3QuZWwKKysrIGIvbGlzcC9yZWN0LmVsCkBAIC0xNjcsNiArMTY3LDM5IEBAIGFwcGx5LW9u LXJlY3RhbmdsZQogICAgICAgICAgICAgICAgICAoPD0gKHBvaW50KSBlbmRwdCkpKSkKICAgICAg IGZpbmFsLXBvaW50KSkpCiAKKyhkZWZ1biByZWN0YW5nbGUtcG9zaXRpb24tYXMtY29vcmRpbmF0 ZXMgKHBvc2l0aW9uKQorICAgIlJldHVybiBjb25zIG9mIHRoZSBjb2x1bW4gYW5kIGxpbmUgdmFs dWVzIG9mIFBPU0lUSU9OLgorUE9TSVRJT04gc3BlY2lmaWVzIGEgcG9zaXRpb24gb2YgdGhlIGN1 cnJlbnQgYnVmZmVyLiAgVGhlIHZhbHVlCityZXR1cm5lZCBpcyBhIGNvbnMgb2YgdGhlIGN1cnJl bnQgY29sdW1uIG9mIFBPU0lUSU9OIGFuZCBpdHMgbGluZQorbnVtYmVyLiIKKyAgKHNhdmUtZXhj dXJzaW9uCisgICAgKGdvdG8tY2hhciBwb3NpdGlvbikKKyAgICAobGV0ICgoY29sIChjdXJyZW50 LWNvbHVtbikpCisgICAgICAgICAgKGxpbmUgKHByb2duCisgICAgICAgICAgICAgICAgICAoZm9y d2FyZC1saW5lIDApCisgICAgICAgICAgICAgICAgICAoY291bnQtbGluZXMgKHBvaW50LW1pbikg cG9zaXRpb24pKSkpCisgICAgICAoY29ucyBjb2wgbGluZSkpKSkKKworKGRlZnVuIHJlY3Rhbmds ZS1pbnRlcnNlY3QtcCAocG9zMSBzaXplMSBwb3MyIHNpemUyKQorICAgIlJldHVybiBub24tbmls IGlmIHR3byByZWN0YW5nbGVzIGludGVyc2VjdC4KK1BPUzEgYW5kIFBPUzIgc3BlY2lmeSB0aGUg cG9zaXRpb25zIG9mIHRoZSB1cHBlci1sZWZ0IGNvcm5lcnMgb2YKK3RoZSBmaXJzdCBhbmQgc2Vj b25kIHJlY3RhbmdsZSBhcyBjb25zZXMgb2YgdGhlaXIgY29sdW1uIGFuZCBsaW5lCit2YWx1ZXMu ICBTSVpFMSBhbmQgU0laRTIgc3BlY2lmeSB0aGUgZGltZW5zaW9ucyBvZiB0aGUgZmlyc3QgYW5k CitzZWNvbmQgcmVjdGFuZ2xlLCBhcyBjb25zZXMgb2YgdGhlaXIgd2lkdGggYW5kIGhlaWdodCBt ZWFzdXJlZCBpbgorY29sdW1ucyBhbmQgbGluZXMuIgorICAobGV0ICgoeDEgKGNhciBwb3MxKSkK KyAgICAgICAgKHkxIChjZHIgcG9zMSkpCisgICAgICAgICh4MiAoY2FyIHBvczIpKQorICAgICAg ICAoeTIgKGNkciBwb3MyKSkKKyAgICAgICAgKHcxIChjYXIgc2l6ZTEpKQorICAgICAgICAoaDEg KGNkciBzaXplMSkpCisgICAgICAgICh3MiAoY2FyIHNpemUyKSkKKyAgICAgICAgKGgyIChjZHIg c2l6ZTIpKSkKKyAgICAobm90IChvciAoPD0gKCsgeDEgdzEpIHgyKQorICAgICAgICAgICAgICg8 PSAoKyB4MiB3MikgeDEpCisgICAgICAgICAgICAgKDw9ICgrIHkxIGgxKSB5MikKKyAgICAgICAg ICAgICAoPD0gKCsgeTIgaDIpIHkxKSkpKSkKKwogKGRlZnVuIGRlbGV0ZS1yZWN0YW5nbGUtbGlu ZSAoc3RhcnRjb2wgZW5kY29sIGZpbGwpCiAgICh3aGVuICg9IChtb3ZlLXRvLWNvbHVtbiBzdGFy dGNvbCAoaWYgZmlsbCB0ICdjb2VyY2UpKSBzdGFydGNvbCkKICAgICAoZGVsZXRlLXJlZ2lvbiAo cG9pbnQpCi0tIAoyLjE3LjEKCg== --000000000000fe76db05771911a9-- From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 30 13:19:11 2018 Received: (at 31240) by debbugs.gnu.org; 30 Sep 2018 17:19:11 +0000 Received: from localhost ([127.0.0.1]:60179 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g6fN9-0008Qp-Ig for submit@debbugs.gnu.org; Sun, 30 Sep 2018 13:19:11 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36515) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g6fN8-0008Qd-Dr for 31240@debbugs.gnu.org; Sun, 30 Sep 2018 13:19:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g6fN0-0003Mn-42 for 31240@debbugs.gnu.org; Sun, 30 Sep 2018 13:19:05 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39850) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g6fN0-0003Mi-0F; Sun, 30 Sep 2018 13:19:02 -0400 Received: from [176.228.60.248] (port=4286 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1g6fMz-0006Am-K0; Sun, 30 Sep 2018 13:19:01 -0400 Date: Sun, 30 Sep 2018 20:18:52 +0300 Message-Id: <83h8i652f7.fsf@gnu.org> From: Eli Zaretskii To: Federico Tedin In-reply-to: (message from Federico Tedin on Sun, 30 Sep 2018 13:20:31 -0300) Subject: Re: bug#31240: 26.1; mouse-save-then-kill does not kill rectangles References: <5BADDC88.7010206@gmx.at> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31240 Cc: 31240@debbugs.gnu.org, charles@aurox.ch X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Federico Tedin > Date: Sun, 30 Sep 2018 13:20:31 -0300 > Cc: 31240@debbugs.gnu.org > > > although this still won't make your patch short enough to qualify as > > "tiny change". So if you haven't done so already, please start the > > paperwork process so we can apply this patch. > > This shouldn't be a problem, my copyright assignment was filed one or two months > ago, and since then I've contributed two patches which have already been merged. Your copyright assignment is already on file. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 30 13:50:19 2018 Received: (at 31240) by debbugs.gnu.org; 30 Sep 2018 17:50:19 +0000 Received: from localhost ([127.0.0.1]:60185 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g6frG-0000m5-3S for submit@debbugs.gnu.org; Sun, 30 Sep 2018 13:50:19 -0400 Received: from mout.gmx.net ([212.227.15.18]:34135) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g6frE-0000ls-3H for 31240@debbugs.gnu.org; Sun, 30 Sep 2018 13:50:16 -0400 Received: from [192.168.1.101] ([213.162.73.160]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0LqzEB-1fTVca2Nwx-00egX5; Sun, 30 Sep 2018 19:50:07 +0200 Received: from [192.168.1.101] ([213.162.73.160]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0LqzEB-1fTVca2Nwx-00egX5; Sun, 30 Sep 2018 19:50:07 +0200 Message-ID: <5BB10CCE.4020503@gmx.at> Date: Sun, 30 Sep 2018 19:50:06 +0200 From: martin rudalics MIME-Version: 1.0 To: Federico Tedin , charles@aurox.ch Subject: Re: bug#31240: 26.1; mouse-save-then-kill does not kill rectangles References: <5BADDC88.7010206@gmx.at> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:Y6NBFNz0K0LmNcvyaKl8uaBfjAikbWL2Ak+PZMqrLsT99KyqXVZ rlYyQWIwG3P12hs72buT0NhXlIoilmL95ZfgMzB8ioDizK7Jv/NvaSPRsCHEIsTkbGyVNYb kTaMjXUMyVc325mp1Nga+fs8VY+a6uaZWUL+L+76NHFwJeegcu9sVJPYhForytCXF2lfzxz sRZjcppwocluUfYrnOIGg== X-UI-Out-Filterresults: notjunk:1;V01:K0:2RxXxLGXtDU=:raaVkVxeunaUXLCtkaIrMt Idx2JSNCpA5DpcryMkadXFY4lA+6ydW1uxxB1XQ95JvE24dos5oEYf1LVsQ8VDLyD8byTXD8a vsVy1bnyuP7vG43uZe54noB/C+6BSzqVvpeb9EEzcVIIGRlXIqZg07LtValR1DMo70l9BSPh0 mYc8XrtdTkKmv4ioxRi9Z0hwz0bcZ5TViVUW9Fdercx/VSaKxZ3//wLqhl78c2xZsYPxoBN85 c6vxry2nZ5Rs+9orHyuWqlAFWpfjyTXzXAy/pLnedwTwrM8lagejk7313c4wmAZNdNR1FwFrT lxC3HVqoBzCVaIsFG3LcT3cHwSxUyo51paHlQf8BfKGBux7Xm3fs7umVHX6Lctu9HJV34/+ge BUPsgjFlQ7KRpUzrEAw/kFYrvrQf0qXUPHpmkV4deCOZN04hFLAOpUJjBW51I5K8qf3KYTYAH ghLmaUn5mekVQhoWQCmzGP6G8wUJxX16Ny/yhjPhbysdWhmvZZR4sAkquSciwKoPtECIYl1FY sfNrI9fjhWRxMJAIKr33RNiKAROjI6O5FLILCtA8Qk3xZ/Z9J93kKyp9BsX5UbGSLMLbPtzvS FlNxDYU8UPhGGyb4/0zDLjXVAcUpuSuo0t96RAPpK1eHjG+jpXvlF0hs9TmEAFPdKVIxK3lTM t/NGBqNfE1QN742O0NGP8UbcKSYDrGCWuHVfqYGMb5YtrYJLfobt0tHl7zcwT/u8EX6gbt9/p fMNpdH/yzK9K518ldbh3FIyQf2ubC0UrWMT7ZMLecEtzim3SicwjTdGUPkCTc4pbV5CXxnnQ+ x7Z10LxOKPf+8RMXT/kGM6qmEmPZyNNMDtrzb/vLhivYRtxlS4= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 31240 Cc: 31240@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Looking again at this part + (line (progn + (forward-line 0) + (count-lines (point-min) position)))) I now ask myself why you need to go to the beginning of the line at all. 'count-lines' doesn't care about the actual position of point. So you either have to do (count-lines (point-min) (point)) or just do (count-lines (point-min) position) without going to the beginning of the line because POSITION and the position at the beginning of its line should be on the same line. > This shouldn't be a problem, my copyright assignment was filed one or two months > ago, and since then I've contributed two patches which have already been merged. Great. martin From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 30 14:26:17 2018 Received: (at 31240) by debbugs.gnu.org; 30 Sep 2018 18:26:17 +0000 Received: from localhost ([127.0.0.1]:60234 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g6gQ5-0001j9-Hd for submit@debbugs.gnu.org; Sun, 30 Sep 2018 14:26:17 -0400 Received: from mail-lf1-f65.google.com ([209.85.167.65]:44789) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g6gQ4-0001ix-8W for 31240@debbugs.gnu.org; Sun, 30 Sep 2018 14:26:16 -0400 Received: by mail-lf1-f65.google.com with SMTP id m18-v6so1574337lfl.11 for <31240@debbugs.gnu.org>; Sun, 30 Sep 2018 11:26:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Zi3pigmK5XqQDXgXRlp9WOAqfcsno7HTCsWXKFfK6FE=; b=lUfJtwkCO4BRwQYIgV/wdqccVirulzL+MXQlZDnYVSjbQ5IIP0jV09CmWodpg+eX5H xgualN0+KIFL63SntM3IC4FWcwfrRxgh0+qUDPJNWwWCPm9c5PKWhVsUoqpkJ688zrZD jlUl/wUIp6qiRcbBVsPP44q1D1Y+xWnrIyWHarBUh9vypDhKjMwbOHqtE7wO6IZa1XaT AqYAvrxjcQSvd9nljJOVfrkOSMDsvQgx0N4fGBdPdvv8SZLJextmlES1290EujPK1F6y LwZoyW3JZ1VokmlkOY5OXU8VKmU5HRNtVoxxPzUqRtlGPDxU42+viCI3S+gIMVy760VM w7Rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Zi3pigmK5XqQDXgXRlp9WOAqfcsno7HTCsWXKFfK6FE=; b=ipwchUJCTUBldxE2/Y3+pv1X0M0974vhc3aOnxitRkT/D/VQXvRDpCVHMLSZYsEOsz k2FMj9bTkEJNWX7ZGuCdWwgp2dQy3VN2+F87JeFOTNj9JuY/2pnmM31MPQBY0D+MnA5E NBCPV6152J9ftTjGsuY3VPr3bufzS9Ba6nFpUybqxDS7Lzn//mO0eAbVNXm08ZIy6gj0 vtm4JqDCIP5DSSzfkjM1+jhcJJ85pMRgwq7zMnF7lPFoSTtr2UI8xx97/9MfMr4JiN/x sav7WMM3VkHFT364+cC62b7yksGJklPmbJnYsfhdGpA2yIcNm1bLV8JQnNuYqwbWGAZ5 XXGA== X-Gm-Message-State: ABuFfoiWVt9nOXZwnldNmiAUhIWRLWlix5tQizMj8fFe2EdVwoZMxeeX 433dXPGbfA26UJhmoBfT7OckOQK3Ru7F5fSJqTo= X-Google-Smtp-Source: ACcGV63rIAfipCQ9cEBKbspk3ykuODwB07JspAO1MQjhnBuzUWwqgOaLVhhI55D5cNeRySmqLU0T85bJxlfGvH0HaVQ= X-Received: by 2002:a19:1346:: with SMTP id j67-v6mr3426884lfi.93.1538331970246; Sun, 30 Sep 2018 11:26:10 -0700 (PDT) MIME-Version: 1.0 References: <5BADDC88.7010206@gmx.at> <5BB10CCE.4020503@gmx.at> In-Reply-To: <5BB10CCE.4020503@gmx.at> From: Federico Tedin Date: Sun, 30 Sep 2018 15:25:57 -0300 Message-ID: Subject: Re: bug#31240: 26.1; mouse-save-then-kill does not kill rectangles To: rudalics@gmx.at Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 31240 Cc: 31240@debbugs.gnu.org, charles@aurox.ch X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Looking again at this part > > + (line (progn > + (forward-line 0) > + (count-lines (point-min) position)))) > > I now ask myself why you need to go to the beginning of the line at > all. 'count-lines' doesn't care about the actual position of point. > So you either have to do > > (count-lines (point-min) (point)) > > or just do > > (count-lines (point-min) position) > > without going to the beginning of the line because POSITION and the > position at the beginning of its line should be on the same line. The problem with using just (count-lines (point-min) position) is that the return value is different when the point is on column 0 and when it is on column 1 or greater. I needed to be sure that if the position was anywhere on line N, the result was N (with N starting at 0). From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 01 04:34:11 2018 Received: (at 31240) by debbugs.gnu.org; 1 Oct 2018 08:34:11 +0000 Received: from localhost ([127.0.0.1]:60637 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g6tec-0005gS-Ut for submit@debbugs.gnu.org; Mon, 01 Oct 2018 04:34:11 -0400 Received: from mout.gmx.net ([212.227.15.18]:35989) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g6teb-0005gC-2j for 31240@debbugs.gnu.org; Mon, 01 Oct 2018 04:34:09 -0400 Received: from [192.168.1.101] ([46.125.250.27]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0Lm3H7-1fXHiV3jBx-00Zihr; Mon, 01 Oct 2018 10:33:55 +0200 Received: from [192.168.1.101] ([46.125.250.27]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0Lm3H7-1fXHiV3jBx-00Zihr; Mon, 01 Oct 2018 10:33:55 +0200 Message-ID: <5BB1DBF0.5060706@gmx.at> Date: Mon, 01 Oct 2018 10:33:52 +0200 From: martin rudalics MIME-Version: 1.0 To: Federico Tedin Subject: Re: bug#31240: 26.1; mouse-save-then-kill does not kill rectangles References: <5BADDC88.7010206@gmx.at> <5BB10CCE.4020503@gmx.at> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:EADOokZVHrvCCh8x/DydqSs0NyTjcv0Ek9968z7HoG5xAANZgRS BKoUKCPOrn6FEEmhJfAlmYUESbhMJ6891nl5rJZ7NF44JPXcQ7FbHRTF5/PaDlRLTLe6CGi KF3AAUDAXaMHE2EiUrRJbB22DRAtOSRGIpJxuiuKhoPvLPxKbHZ+vuS9HbS0tT68QfZySuI MSAH/YMRX8ne8RLqGuOog== X-UI-Out-Filterresults: notjunk:1;V01:K0:6Xj4Q5lPkv4=:tKW5VHo6+R1bSi807JG8NC K5vptrZBbMNE6nvQX7H4N4W+oCRO6on0ziWL4qx9gms/CUr8QMSO45DPtaWaibA5LXxLbaQJJ tiDwX6tuZsvzAjr5yHuXGQ43euXIzTnSnnBXG57+TCE/pDUudt00B2kPN9M9yk0Y5Os1Xgv2w dDBPdFqYLRFtgu1sLuCOHJE9U7AOYefL8cnF7oObFa8bVWneMNVn+wyhShDtqJ1hd5EZBLq4v mayWXn1HalYlDE4G0pXx4B7PwqETsWo9rYxCQj9XWpLHpxJJkwQ4nT9YzoVMD7PvpNvkdiiFj 4Fpk0NLN1YIDxadOuJT7R8GzwOjGW31Eu+2uviowNV7sExrcd6Y5QYhtIjFhcTZFmG29Lc6Vf CVkqdrUx2dfAIQGH1BUGV5B0+vLMFhsKm967rls7MKmgIDZuBckGpoGzh2rlAPYxD055iYXwK wYBKRay+ODKZD70x149jTbJh6quaW/Nuxli6wo+IRcAfK5eoy8wslFfB/Srp3eyHYoC1kUHaP iYxf/IBasarVLx0GK/BnD9fVjdlJX/XUXcETnRqlcmBuHuVYWEoxPSA3QKc40+laADkFIG4Vi 4g/r/bwaRT6mzCW3WlItQflQghfiZsBnaUtvb3P8z6Af/BbjbxDwi2YlMvLj2IMX4OHQ1fRdw WasvEcTKQRq1bm+MXQcPLdlpqvtPAoqRnCjGTa+FTPOr8Ig9/8skcFn0z9IqX/cI4nAjHqZOm GY6mNOQ51EvSHt7oHy3JEXu8C7FNsIkNGTaXfFg6EQWMQFyy6yG6tdmrhOU8M4tN52r/EihlA PQKh4Q8/hSSPTx8UHJCAe1l1k51wJcFaJ3rnn0UZBEKK5oXomo= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 31240 Cc: 31240@debbugs.gnu.org, charles@aurox.ch X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > The problem with using just (count-lines (point-min) position) is that > the return value > is different when the point is on column 0 and when it is on column 1 > or greater. OK. (count-lines (point-min) (point-min)) returns 0 because START and END are equal so let's assume you want to special-case that. Now the problem with your code is that + (line (progn + (forward-line 0) + (count-lines (point-min) position)))) probably doesn't do what you expect: The value of POSITION in the call of 'count-lines' is the _same_ it was before the 'forward-line' call because 'forward-line' only changes the value of point but not that of POSITION. So if you want a possible return value of 0 you have to write + (line (progn + (forward-line 0) + (count-lines (point-min) (point))))) instead. > I > needed to be sure that if the position was anywhere on line N, the > result was N (with > N starting at 0). Agreed, once more. You want to special-case POSITION on the first line of the buffer. But go the ends of the following two forms and type C-x C-e on each: (let ((position 3)) (save-excursion (goto-char position) (forward-line 0) (count-lines (point-min) position))) (let ((position 3)) (save-excursion (goto-char position) (forward-line 0) (count-lines (point-min) (point)))) Here the first evaluation gets me 1 and the second 0. I suppose it's the latter you want. martin From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 01 17:35:07 2018 Received: (at 31240) by debbugs.gnu.org; 1 Oct 2018 21:35:07 +0000 Received: from localhost ([127.0.0.1]:33564 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g75qN-0007sH-9g for submit@debbugs.gnu.org; Mon, 01 Oct 2018 17:35:07 -0400 Received: from mail-lf1-f53.google.com ([209.85.167.53]:41953) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g75qK-0007re-JG for 31240@debbugs.gnu.org; Mon, 01 Oct 2018 17:35:05 -0400 Received: by mail-lf1-f53.google.com with SMTP id q39-v6so9632898lfi.8 for <31240@debbugs.gnu.org>; Mon, 01 Oct 2018 14:35:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4pFJRMwADm6z9wlc0saqPwKVwe+CN9DjX52JFNmiCTU=; b=BtEZhwcmze7zLIa15+lBh9YftpFIvXsPEXz6QUZ3HwRVpFv4NN7YXsMVG+AZtjzwQb x3rx4FUWihDKVQ9jMA+y1XYxzGPH42LO1CvwXHEnbv6i0Z7eAeYVPJCXjq3bf60yuW1C mV71q9FZnbo/C7GX8650tb3f7c3fk6D+ssW71UE44N2PwRIt/452tp4JCycT2AFD5xIY REArTjVTnKp1FrWkJBMzMzMY2u3SYjacm9s21PBjZoHVG8OwdbK3M6HpiOeellUN+Qw2 NoEQ+JSJWxLovuWf/egWjrpaqFfXClwB4K1I3iFmPl1OYsDNKS8jayIlY2DkwNPvTGxl ZVBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4pFJRMwADm6z9wlc0saqPwKVwe+CN9DjX52JFNmiCTU=; b=F57DCNXdVvPLiV/oq/47BupVqHTqeHDOBDHFcHR6FxllVtTRrr0Zjf5oDWDWHrYSez 7iLV2JORlwmAT76dnPX3QaqP8BiALlX11jw629XUiwUKLdYiDapJWpRow1lJmTw55lsH 6JhZgQmTvKq2xx1Fs2hkIv54xHaSnfpfvtBxXKgb6tVApin/IW8YljaYXnTOR2+WBZpw n6IJ1N6fxuEqpDUq6j3S2RboO4MEuwFzO+4Og4piLmdkmV4WpLCwjvrZ55WZ/W3+FAE7 OgX2wyZc+weX/TPEBYlcRaIWf31ULa2B7aeYh2EB+qxz1tqWpddHaeHc9uj4T90rW3tB n6DQ== X-Gm-Message-State: ABuFfogIxSweJlzS+NAMj8Wxlk3IUaJTnrNnR8/vPi834N6lwV91MyxJ SAssI7vTsn3IYXD8VkTb9dumyhYWnNutaOXzZuI= X-Google-Smtp-Source: ACcGV600pGV/Qwxgo5Fpemu3RwNK2Rqfywk+k73h6fHx8SXucrNbnHWQBuDcBiQW72IVcQIYcqEJW91VrtZjuUc0CEE= X-Received: by 2002:a19:9e54:: with SMTP id h81-v6mr6279703lfe.155.1538429698540; Mon, 01 Oct 2018 14:34:58 -0700 (PDT) MIME-Version: 1.0 References: <5BADDC88.7010206@gmx.at> <5BB10CCE.4020503@gmx.at> <5BB1DBF0.5060706@gmx.at> In-Reply-To: <5BB1DBF0.5060706@gmx.at> From: Federico Tedin Date: Mon, 1 Oct 2018 18:34:45 -0300 Message-ID: Subject: Re: bug#31240: 26.1; mouse-save-then-kill does not kill rectangles To: rudalics@gmx.at Content-Type: multipart/mixed; boundary="000000000000b1aaeb05773193b1" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31240 Cc: 31240@debbugs.gnu.org, charles@aurox.ch X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000b1aaeb05773193b1 Content-Type: text/plain; charset="UTF-8" > Here the first evaluation gets me 1 and the second 0. I suppose > it's the latter you want. Martin, thanks for your feedback. My use of the variable POSITON was a mistake on my part, the correct thing to do was calling (point), as the point had already been set to POSITION (by goto-char), and then moved by forward-line. While fixing the mistake, I found the function line-number-at-pos, which uses the same method I was using (after your correction) to calculate the line number. I'm attaching a new patch which uses this function instead. Slightly related question: is it better for me to keep sending patches with all my changes and fixes included, or is it better to send an initial one, and then send additional (smaller) patches with fixes to the first one? --000000000000b1aaeb05773193b1 Content-Type: text/x-patch; charset="US-ASCII"; name="mouse.patch" Content-Disposition: attachment; filename="mouse.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jmqtayib0 RnJvbSA3MTVmNTYxNTBjNTEzZDMxYjgxZmRjMTY0ZTAyMGQ3MjI1ODIxOTY0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBGZWRlcmljbyBUZWRpbiA8ZmVkZXJpY290ZWRpbkBnbWFpbC5j b20+CkRhdGU6IE1vbiwgMSBPY3QgMjAxOCAxODoyNzoxOCAtMDMwMApTdWJqZWN0OiBbUEFUQ0gg MS8xXSBBbGxvdyB0d28gbW91c2UgZnVuY3Rpb25zIHRvIHdvcmsgd2l0aCBSZWN0YW5nbGUgTWFy awogbW9kZQoKKiBsaXNwL21vdXNlLmVsIChtb3VzZS1zYXZlLXRoZW4ta2lsbCk6IE1ha2UgbW91 c2Utc2F2ZS10aGVuLWtpbGwgd29yawogIHdpdGggcmVjdGFuZ3VsYXIgcmVnaW9ucywgaW5jbHVk aW5nIHdoZW4gbW91c2UtZHJhZy1jb3B5LXJlZ2lvbiBpcwogIHNldCB0byB0LiAoQnVnIzMxMjQw KQogIChtb3VzZS1kcmFnLWFuZC1kcm9wLXJlZ2lvbik6IEFsbG93IGRyYWdnaW5nIGFuZCBkcm9w cGluZwogIHJlY3Rhbmd1bGFyIHJlZ2lvbnMuIChCdWcjMzEyNDApCiogcmVjdC5lbCAocmVjdGFu Z2xlLWludGVyc2VjdC1wKTogQWRkIGEgbmV3IGZ1bmN0aW9uLgogIChyZWN0YW5nbGUtcG9zaXRp b24tYXMtY29vcmRpbmF0ZXMpOiBBZGQgYSBuZXcgZnVuY3Rpb24uCi0tLQogbGlzcC9tb3VzZS5l bCB8IDkyICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0t LQogbGlzcC9yZWN0LmVsICB8IDMxICsrKysrKysrKysrKysrKysrCiAyIGZpbGVzIGNoYW5nZWQs IDk3IGluc2VydGlvbnMoKyksIDI2IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3AvbW91 c2UuZWwgYi9saXNwL21vdXNlLmVsCmluZGV4IGNiNjNjYTUxYzUuLmIwMGYzOGEwZjYgMTAwNjQ0 Ci0tLSBhL2xpc3AvbW91c2UuZWwKKysrIGIvbGlzcC9tb3VzZS5lbApAQCAtMjksNiArMjksOCBA QAogCiA7OzsgQ29kZToKIAorKGV2YWwtd2hlbi1jb21waWxlIChyZXF1aXJlICdyZWN0KSkKKwog Ozs7IFV0aWxpdHkgZnVuY3Rpb25zLgogCiA7OyBJbmRlbnQgdHJhY2stbW91c2UgbGlrZSBwcm9n bi4KQEAgLTE2MDYsOCArMTYwOCw4IEBAIG1vdXNlLXNhdmUtdGhlbi1raWxsCiAgICAgICAoaWYg bW91c2UtZHJhZy1jb3B5LXJlZ2lvbgogICAgICAgICAgIDs7IFJlZ2lvbiBhbHJlYWR5IHNhdmVk IGluIHRoZSBwcmV2aW91cyBjbGljazsKICAgICAgICAgICA7OyBkb24ndCBtYWtlIGEgZHVwbGlj YXRlIGVudHJ5LCBqdXN0IGRlbGV0ZS4KLSAgICAgICAgICAoZGVsZXRlLXJlZ2lvbiAobWFyayB0 KSAocG9pbnQpKQotICAgICAgICAoa2lsbC1yZWdpb24gKG1hcmsgdCkgKHBvaW50KSkpCisgICAg ICAgICAgKGZ1bmNhbGwgcmVnaW9uLWV4dHJhY3QtZnVuY3Rpb24gJ2RlbGV0ZS1vbmx5KQorICAg ICAgICAoa2lsbC1yZWdpb24gKG1hcmsgdCkgKHBvaW50KSAncmVnaW9uKSkKICAgICAgIChzZXRx IG1vdXNlLXNlbGVjdGlvbi1jbGljay1jb3VudCAwKQogICAgICAgKHNldHEgbW91c2Utc2F2ZS10 aGVuLWtpbGwtcG9zbiBuaWwpKQogCkBAIC0xNjMyLDcgKzE2MzQsNyBAQCBtb3VzZS1zYXZlLXRo ZW4ta2lsbAogCShtb3VzZS1zZXQtcmVnaW9uLTEpCiAgICAgICAgICh3aGVuIG1vdXNlLWRyYWct Y29weS1yZWdpb24KICAgICAgICAgICA7OyBSZWdpb24gYWxyZWFkeSBjb3BpZWQgdG8ga2lsbC1y aW5nIG9uY2UsIHNvIHJlcGxhY2UuCi0gICAgICAgICAgKGtpbGwtbmV3IChmaWx0ZXItYnVmZmVy LXN1YnN0cmluZyAobWFyayB0KSAocG9pbnQpKSB0KSkKKyAgICAgICAgICAoa2lsbC1uZXcgKGZ1 bmNhbGwgcmVnaW9uLWV4dHJhY3QtZnVuY3Rpb24gbmlsKSB0KSkKIAk7OyBBcnJhbmdlIGZvciBh IHJlcGVhdGVkIG1vdXNlLTMgdG8ga2lsbCB0aGUgcmVnaW9uLgogCShzZXRxIG1vdXNlLXNhdmUt dGhlbi1raWxsLXBvc24gY2xpY2stcHQpKSkKIApAQCAtMjQxMSw3ICsyNDEzLDE1IEBAIG1vdXNl LWRyYWctYW5kLWRyb3AtcmVnaW9uCiAgICAgICAgICAoYnVmZmVyIChjdXJyZW50LWJ1ZmZlcikp CiAgICAgICAgICAod2luZG93IChzZWxlY3RlZC13aW5kb3cpKQogICAgICAgICAgKHRleHQtZnJv bS1yZWFkLW9ubHkgYnVmZmVyLXJlYWQtb25seSkKLSAgICAgICAgIChtb3VzZS1kcmFnLWFuZC1k cm9wLW92ZXJsYXkgKG1ha2Utb3ZlcmxheSBzdGFydCBlbmQpKQorICAgICAgICAgOzsgVXNlIG11 bHRpcGxlIG92ZXJsYXlzIHRvIGNvdmVyIGNhc2VzIHdoZXJlIHRoZSByZWdpb24gaXMgcmVjdGFu Z3VsYXIuCisgICAgICAgICAobW91c2UtZHJhZy1hbmQtZHJvcC1vdmVybGF5cyAobWFwY2FyIChs YW1iZGEgKGJvdW5kcykKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAobWFrZS1vdmVybGF5IChjYXIgYm91bmRzKQorICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGNkciBib3VuZHMpKSkK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKHJlZ2lvbi1i b3VuZHMpKSkKKyAgICAgICAgIChyZWdpb24tbm9uY29udGlndW91cyAocmVnaW9uLW5vbmNvbnRp Z3VvdXMtcCkpCisgICAgICAgICAocmVnaW9uLXdpZHRoICgtIChvdmVybGF5LWVuZCAoY2FyIG1v dXNlLWRyYWctYW5kLWRyb3Atb3ZlcmxheXMpKQorICAgICAgICAgICAgICAgICAgICAgICAgICAo b3ZlcmxheS1zdGFydCAoY2FyIG1vdXNlLWRyYWctYW5kLWRyb3Atb3ZlcmxheXMpKSkpCisgICAg ICAgICAocmVnaW9uLWhlaWdodCAobGVuZ3RoIG1vdXNlLWRyYWctYW5kLWRyb3Atb3ZlcmxheXMp KQogICAgICAgICAgcG9pbnQtdG8tcGFzdGUKICAgICAgICAgIHBvaW50LXRvLXBhc3RlLXJlYWQt b25seQogICAgICAgICAgd2luZG93LXRvLXBhc3RlCkBAIC0yNDU1LDcgKzI0NjUsMTEgQEAgbW91 c2UtZHJhZy1hbmQtZHJvcC1yZWdpb24KICAgICAgICAgICA7OyBPYnRhaW4gdGhlIGRyYWdnZWQg dGV4dCBpbiByZWdpb24uICBXaGVuIHRoZSBsb29wIHdhcwogICAgICAgICAgIDs7IHNraXBwZWQs IHZhbHVlLXNlbGVjdGlvbiByZW1haW5zIG5pbC4KICAgICAgICAgICAodW5sZXNzIHZhbHVlLXNl bGVjdGlvbgotICAgICAgICAgICAgKHNldHEgdmFsdWUtc2VsZWN0aW9uIChidWZmZXItc3Vic3Ry aW5nIHN0YXJ0IGVuZCkpCisgICAgICAgICAgICAoc2V0cSB2YWx1ZS1zZWxlY3Rpb24gKGZ1bmNh bGwgcmVnaW9uLWV4dHJhY3QtZnVuY3Rpb24gbmlsKSkKKyAgICAgICAgICAgIDs7IFJlbW92ZSB5 YW5rLWhhbmRsZXIgcHJvcGVydHkgaW4gb3JkZXIgdG8gcmUtaW5zZXJ0IHRleHQgdXNpbmcKKyAg ICAgICAgICAgIDs7IHRoZSBgaW5zZXJ0LXJlY3RhbmdsZScgZnVuY3Rpb24gbGF0ZXIgb24uCisg ICAgICAgICAgICAocmVtb3ZlLXRleHQtcHJvcGVydGllcyAwIChsZW5ndGggdmFsdWUtc2VsZWN0 aW9uKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJyh5YW5rLWhhbmRsZXIp IHZhbHVlLXNlbGVjdGlvbikKICAgICAgICAgICAgICh3aGVuIG1vdXNlLWRyYWctYW5kLWRyb3At cmVnaW9uLXNob3ctdG9vbHRpcAogICAgICAgICAgICAgICAobGV0ICgodGV4dC1zaXplIG1vdXNl LWRyYWctYW5kLWRyb3AtcmVnaW9uLXNob3ctdG9vbHRpcCkpCiAgICAgICAgICAgICAgICAgKHNl dHEgdGV4dC10b29sdGlwCkBAIC0yNDY4LDEyICsyNDgyLDE4IEBAIG1vdXNlLWRyYWctYW5kLWRy b3AtcmVnaW9uCiAgICAgICAgICAgICAgICAgICAgICAgICB2YWx1ZS1zZWxlY3Rpb24pKSkpCiAK ICAgICAgICAgICAgIDs7IENoZWNrIGlmIHNlbGVjdGVkIHRleHQgaXMgcmVhZC1vbmx5LgotICAg ICAgICAgICAgKHNldHEgdGV4dC1mcm9tLXJlYWQtb25seSAob3IgdGV4dC1mcm9tLXJlYWQtb25s eQotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGdldC10ZXh0LXBy b3BlcnR5IHN0YXJ0ICdyZWFkLW9ubHkpCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAobm90IChlcXVhbAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgKG5leHQtc2luZ2xlLWNoYXItcHJvcGVydHktY2hhbmdlCi0gICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3RhcnQgJ3JlYWQtb25s eSBuaWwgZW5kKQotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgZW5kKSkpKSkKKyAgICAgICAgICAgIChzZXRxIHRleHQtZnJvbS1yZWFkLW9ubHkKKyAgICAg ICAgICAgICAgICAgIChvciB0ZXh0LWZyb20tcmVhZC1vbmx5CisgICAgICAgICAgICAgICAgICAg ICAgKGdldC10ZXh0LXByb3BlcnR5IHN0YXJ0ICdyZWFkLW9ubHkpCisgICAgICAgICAgICAgICAg ICAgICAgKGdldC10ZXh0LXByb3BlcnR5IGVuZCAncmVhZC1vbmx5KQorICAgICAgICAgICAgICAg ICAgICAgIChjYXRjaCAnbG9vcAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoZG9saXN0 IChib3VuZCAocmVnaW9uLWJvdW5kcykpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg KHVubGVzcyAoZXF1YWwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAo bmV4dC1zaW5nbGUtY2hhci1wcm9wZXJ0eS1jaGFuZ2UKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgKGNhciBib3VuZCkgJ3JlYWQtb25seSBuaWwgKGNkciBib3VuZCkp CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGNkciBib3VuZCkpCisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAodGhyb3cgJ2xvb3AgdCkpKSkpKSkKKwog ICAgICAgICAgIChzZXRxIHdpbmRvdy10by1wYXN0ZSAocG9zbi13aW5kb3cgKGV2ZW50LWVuZCBl dmVudCkpKQogICAgICAgICAgIChzZXRxIHBvaW50LXRvLXBhc3RlIChwb3NuLXBvaW50IChldmVu dC1lbmQgZXZlbnQpKSkKICAgICAgICAgICA7OyBTZXQgbmlsIHdoZW4gdGFyZ2V0IGJ1ZmZlciBp cyBtaW5pYnVmZmVyLgpAQCAtMjUwMCwxMiArMjUyMCwyMCBAQCBtb3VzZS1kcmFnLWFuZC1kcm9w LXJlZ2lvbgogICAgICAgICAgICAgOzsgdGV4dCB3aWxsIGJlIGluc2VydGVkIHRvIGluc2lkZSBv ZiB0aGUgb3JpZ2luYWwKICAgICAgICAgICAgIDs7IHJlZ2lvbi4KICAgICAgICAgICAgIChzZXRx IGRyYWctYnV0LW5lZ2xpZ2libGUKLSAgICAgICAgICAgICAgICAgIChhbmQgKGVxIChvdmVybGF5 LWJ1ZmZlciBtb3VzZS1kcmFnLWFuZC1kcm9wLW92ZXJsYXkpCisgICAgICAgICAgICAgICAgICAo YW5kIChlcSAob3ZlcmxheS1idWZmZXIgKGNhciBtb3VzZS1kcmFnLWFuZC1kcm9wLW92ZXJsYXlz KSkKICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJ1ZmZlci10by1wYXN0ZSkKLSAgICAgICAg ICAgICAgICAgICAgICAgKDw9IChvdmVybGF5LXN0YXJ0IG1vdXNlLWRyYWctYW5kLWRyb3Atb3Zl cmxheSkKLSAgICAgICAgICAgICAgICAgICAgICAgICAgcG9pbnQtdG8tcGFzdGUpCi0gICAgICAg ICAgICAgICAgICAgICAgICg8PSBwb2ludC10by1wYXN0ZQotICAgICAgICAgICAgICAgICAgICAg ICAgICAob3ZlcmxheS1lbmQgbW91c2UtZHJhZy1hbmQtZHJvcC1vdmVybGF5KSkpKSkKKyAgICAg ICAgICAgICAgICAgICAgICAgKGlmIHJlZ2lvbi1ub25jb250aWd1b3VzCisgICAgICAgICAgICAg ICAgICAgICAgICAgICA7OyBJZiB0aGUgcmVnaW9uIGlzIHJlY3Rhbmd1bGFyLCBjaGVjayBpZiB0 aGUgbmV3bHkgaW5zZXJ0ZWQKKyAgICAgICAgICAgICAgICAgICAgICAgICAgIDs7IHJlY3Rhbmd1 bGFyIHRleHQgd291bGQgaW50ZXJzZWN0IHRoZSBhbHJlYWR5IHNlbGVjdGVkCisgICAgICAgICAg ICAgICAgICAgICAgICAgICA7OyByZWdpb24uIElmIGl0IHdvdWxkLCB0aGVuIHNldCAiZHJhZy1i dXQtbmVnbGlnaWJsZSIgdG8gdC4KKyAgICAgICAgICAgICAgICAgICAgICAgICAgIChsZXQgKChz aXplIChjb25zIHJlZ2lvbi13aWR0aCByZWdpb24taGVpZ2h0KSkpCisgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIChyZWN0YW5nbGUtaW50ZXJzZWN0LXAKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIChyZWN0YW5nbGUtcG9zaXRpb24tYXMtY29vcmRpbmF0ZXMgc3RhcnQpIHNpemUK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChyZWN0YW5nbGUtcG9zaXRpb24tYXMtY29v cmRpbmF0ZXMgcG9pbnQtdG8tcGFzdGUpIHNpemUpKQorICAgICAgICAgICAgICAgICAgICAgICAg IChhbmQgKDw9IChvdmVybGF5LXN0YXJ0IChjYXIgbW91c2UtZHJhZy1hbmQtZHJvcC1vdmVybGF5 cykpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcG9pbnQtdG8tcGFzdGUpCisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoPD0gcG9pbnQtdG8tcGFzdGUKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAob3ZlcmxheS1lbmQgKGNhciBtb3VzZS1kcmFnLWFu ZC1kcm9wLW92ZXJsYXlzKSkpKSkpKSkKIAogICAgICAgICAgIDs7IFNob3cgYSB0b29sdGlwLgog ICAgICAgICAgIChpZiBtb3VzZS1kcmFnLWFuZC1kcm9wLXJlZ2lvbi1zaG93LXRvb2x0aXAKQEAg LTI1MjQsOCArMjU1Miw5IEBAIG1vdXNlLWRyYWctYW5kLWRyb3AtcmVnaW9uCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgKHQKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg J2JhcikpKQogICAgICAgICAgICAgKHdoZW4gY3Vyc29yLWluLXRleHQtYXJlYQotICAgICAgICAg ICAgICAob3ZlcmxheS1wdXQgbW91c2UtZHJhZy1hbmQtZHJvcC1vdmVybGF5Ci0gICAgICAgICAg ICAgICAgICAgICAgICAgICAnZmFjZSAnbW91c2UtZHJhZy1hbmQtZHJvcC1yZWdpb24pCisgICAg ICAgICAgICAgIChkb2xpc3QgKG92ZXJsYXkgbW91c2UtZHJhZy1hbmQtZHJvcC1vdmVybGF5cykK KyAgICAgICAgICAgICAgICAob3ZlcmxheS1wdXQgb3ZlcmxheQorICAgICAgICAgICAgICAgICAg ICAgICAgICAgJ2ZhY2UgJ21vdXNlLWRyYWctYW5kLWRyb3AtcmVnaW9uKSkKICAgICAgICAgICAg ICAgKGRlYWN0aXZhdGUtbWFyaykgICAgIDsgTWFpbnRhaW4gcmVnaW9uIGluIG90aGVyIHdpbmRv dy4KICAgICAgICAgICAgICAgKG1vdXNlLXNldC1wb2ludCBldmVudCkpKSkpCiAKQEAgLTI1ODEs NyArMjYxMCw5IEBAIG1vdXNlLWRyYWctYW5kLWRyb3AtcmVnaW9uCiAgICAgICAgICAgKHNlbGVj dC13aW5kb3cgd2luZG93KQogICAgICAgICAgIChnb3RvLWNoYXIgcG9pbnQpCiAgICAgICAgICAg KHNldHEgZGVhY3RpdmF0ZS1tYXJrIG5pbCkKLSAgICAgICAgICAoYWN0aXZhdGUtbWFyaykpCisg ICAgICAgICAgKGFjdGl2YXRlLW1hcmspCisgICAgICAgICAgKHdoZW4gcmVnaW9uLW5vbmNvbnRp Z3VvdXMKKyAgICAgICAgICAgIChyZWN0YW5nbGUtbWFyay1tb2RlKSkpCiAgICAgICAgICA7OyBN b2RpZnkgYnVmZmVycy4KICAgICAgICAgICh0CiAgICAgICAgICAgOzsgKiBERVNUSU5BVElPTiBC VUZGRVI6OgpAQCAtMjU5MCwxMSArMjYyMSwxNyBAQCBtb3VzZS1kcmFnLWFuZC1kcm9wLXJlZ2lv bgogICAgICAgICAgIChzZXRxIHdpbmRvdy1leGVtcHQgd2luZG93LXRvLXBhc3RlKQogICAgICAg ICAgIChnb3RvLWNoYXIgcG9pbnQtdG8tcGFzdGUpCiAgICAgICAgICAgKHB1c2gtbWFyaykKLSAg ICAgICAgICAoaW5zZXJ0IHZhbHVlLXNlbGVjdGlvbikKKworICAgICAgICAgIChpZiByZWdpb24t bm9uY29udGlndW91cworICAgICAgICAgICAgICAoaW5zZXJ0LXJlY3RhbmdsZSAoc3BsaXQtc3Ry aW5nIHZhbHVlLXNlbGVjdGlvbiAiXG4iKSkKKyAgICAgICAgICAgIChpbnNlcnQgdmFsdWUtc2Vs ZWN0aW9uKSkKKwogICAgICAgICAgIDs7IE9uIHN1Y2Nlc3MsIHNldCB0aGUgdGV4dCBhcyByZWdp b24gb24gZGVzdGluYXRpb24gYnVmZmVyLgogICAgICAgICAgICh3aGVuIChub3QgKGVxdWFsICht YXJrKSAocG9pbnQpKSkKICAgICAgICAgICAgIChzZXRxIGRlYWN0aXZhdGUtbWFyayBuaWwpCi0g ICAgICAgICAgICAoYWN0aXZhdGUtbWFyaykpCisgICAgICAgICAgICAoYWN0aXZhdGUtbWFyaykK KyAgICAgICAgICAgICh3aGVuIHJlZ2lvbi1ub25jb250aWd1b3VzCisgICAgICAgICAgICAgIChy ZWN0YW5nbGUtbWFyay1tb2RlKSkpCiAKICAgICAgICAgICA7OyAqIFNPVVJDRSBCVUZGRVI6Ogog ICAgICAgICAgIDs7IFNldCBiYWNrIHRoZSBvcmlnaW5hbCB0ZXh0IGFzIHJlZ2lvbiBvciBkZWxl dGUgdGhlIG9yaWdpbmFsCkBAIC0yNjA0LDggKzI2NDEsOSBAQCBtb3VzZS1kcmFnLWFuZC1kcm9w LXJlZ2lvbgogICAgICAgICAgICAgICA7OyByZW1vdmUgdGhlIG9yaWdpbmFsIHRleHQuCiAgICAg ICAgICAgICAgICh3aGVuIG5vLW1vZGlmaWVyLW9uLWRyb3AKICAgICAgICAgICAgICAgICAobGV0 IChkZWFjdGl2YXRlLW1hcmspCi0gICAgICAgICAgICAgICAgICAoZGVsZXRlLXJlZ2lvbiAob3Zl cmxheS1zdGFydCBtb3VzZS1kcmFnLWFuZC1kcm9wLW92ZXJsYXkpCi0gICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAob3ZlcmxheS1lbmQgbW91c2UtZHJhZy1hbmQtZHJvcC1vdmVybGF5 KSkpKQorICAgICAgICAgICAgICAgICAgKGRvbGlzdCAob3ZlcmxheSBtb3VzZS1kcmFnLWFuZC1k cm9wLW92ZXJsYXlzKQorICAgICAgICAgICAgICAgICAgICAoZGVsZXRlLXJlZ2lvbiAob3Zlcmxh eS1zdGFydCBvdmVybGF5KQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAob3Zl cmxheS1lbmQgb3ZlcmxheSkpKSkpCiAgICAgICAgICAgICA7OyBXaGVuIHNvdXJjZSBidWZmZXIg YW5kIGRlc3RpbmF0aW9uIGJ1ZmZlciBhcmUgZGlmZmVyZW50LAogICAgICAgICAgICAgOzsga2Vl cCAoc2V0IGJhY2sgdGhlIG9yaWdpbmFsIHRleHQgYXMgcmVnaW9uKSBvciByZW1vdmUgdGhlCiAg ICAgICAgICAgICA7OyBvcmlnaW5hbCB0ZXh0LgpAQCAtMjYxNSwxNSArMjY1MywxNyBAQCBtb3Vz ZS1kcmFnLWFuZC1kcm9wLXJlZ2lvbgogICAgICAgICAgICAgKGlmIG1vdXNlLWRyYWctYW5kLWRy b3AtcmVnaW9uLWN1dC13aGVuLWJ1ZmZlcnMtZGlmZmVyCiAgICAgICAgICAgICAgICAgOzsgUmVt b3ZlIHRoZSBkcmFnZ2VkIHRleHQgZnJvbSBzb3VyY2UgYnVmZmVyIGxpa2UKICAgICAgICAgICAg ICAgICA7OyBvcGVyYXRpb24gYGN1dCcuCi0gICAgICAgICAgICAgICAgKGRlbGV0ZS1yZWdpb24g KG92ZXJsYXktc3RhcnQgbW91c2UtZHJhZy1hbmQtZHJvcC1vdmVybGF5KQotICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIChvdmVybGF5LWVuZCBtb3VzZS1kcmFnLWFuZC1kcm9wLW92ZXJs YXkpKQorICAgICAgICAgICAgICAgIChkb2xpc3QgKG92ZXJsYXkgbW91c2UtZHJhZy1hbmQtZHJv cC1vdmVybGF5cykKKyAgICAgICAgICAgICAgICAgICAgKGRlbGV0ZS1yZWdpb24gKG92ZXJsYXkt c3RhcnQgb3ZlcmxheSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKG92ZXJs YXktZW5kIG92ZXJsYXkpKSkKICAgICAgICAgICAgICAgOzsgU2V0IGJhY2sgdGhlIGRyYWdnZWQg dGV4dCBhcyByZWdpb24gb24gc291cmNlIGJ1ZmZlcgogICAgICAgICAgICAgICA7OyBsaWtlIG9w ZXJhdGlvbiBgY29weScuCiAgICAgICAgICAgICAgIChhY3RpdmF0ZS1tYXJrKSkKICAgICAgICAg ICAgIChzZWxlY3Qtd2luZG93IHdpbmRvdy10by1wYXN0ZSkpKSkpKQogCiAgICAgOzsgQ2xlYW4g dXAuCi0gICAgKGRlbGV0ZS1vdmVybGF5IG1vdXNlLWRyYWctYW5kLWRyb3Atb3ZlcmxheSkKKyAg ICAoZG9saXN0IChvdmVybGF5IG1vdXNlLWRyYWctYW5kLWRyb3Atb3ZlcmxheXMpCisgICAgICAo ZGVsZXRlLW92ZXJsYXkgb3ZlcmxheSkpCiAKICAgICA7OyBSZXN0b3JlIG9sZCBzdGF0ZXMgYnV0 IGZvciB0aGUgd2luZG93IHdoZXJlIHRoZSBkcm9wCiAgICAgOzsgb2NjdXJyZWQuIFJlc3RvcmUg Y3Vyc29yIHR5cGVzIGZvciBhbGwgd2luZG93cy4KZGlmZiAtLWdpdCBhL2xpc3AvcmVjdC5lbCBi L2xpc3AvcmVjdC5lbAppbmRleCA4Y2NmMDUxZWUxLi40OGRiNGZmZDhmIDEwMDY0NAotLS0gYS9s aXNwL3JlY3QuZWwKKysrIGIvbGlzcC9yZWN0LmVsCkBAIC0xNjcsNiArMTY3LDM3IEBAIGFwcGx5 LW9uLXJlY3RhbmdsZQogICAgICAgICAgICAgICAgICAoPD0gKHBvaW50KSBlbmRwdCkpKSkKICAg ICAgIGZpbmFsLXBvaW50KSkpCiAKKyhkZWZ1biByZWN0YW5nbGUtcG9zaXRpb24tYXMtY29vcmRp bmF0ZXMgKHBvc2l0aW9uKQorICAgIlJldHVybiBjb25zIG9mIHRoZSBjb2x1bW4gYW5kIGxpbmUg dmFsdWVzIG9mIFBPU0lUSU9OLgorUE9TSVRJT04gc3BlY2lmaWVzIGEgcG9zaXRpb24gb2YgdGhl IGN1cnJlbnQgYnVmZmVyLiAgVGhlIHZhbHVlCityZXR1cm5lZCBpcyBhIGNvbnMgb2YgdGhlIGN1 cnJlbnQgY29sdW1uIG9mIFBPU0lUSU9OIGFuZCBpdHMgbGluZQorbnVtYmVyLiIKKyAgKHNhdmUt ZXhjdXJzaW9uCisgICAgKGdvdG8tY2hhciBwb3NpdGlvbikKKyAgICAobGV0ICgoY29sIChjdXJy ZW50LWNvbHVtbikpCisgICAgICAgICAgKGxpbmUgKDEtIChsaW5lLW51bWJlci1hdC1wb3MpKSkp CisgICAgICAoY29ucyBjb2wgbGluZSkpKSkKKworKGRlZnVuIHJlY3RhbmdsZS1pbnRlcnNlY3Qt cCAocG9zMSBzaXplMSBwb3MyIHNpemUyKQorICAgIlJldHVybiBub24tbmlsIGlmIHR3byByZWN0 YW5nbGVzIGludGVyc2VjdC4KK1BPUzEgYW5kIFBPUzIgc3BlY2lmeSB0aGUgcG9zaXRpb25zIG9m IHRoZSB1cHBlci1sZWZ0IGNvcm5lcnMgb2YKK3RoZSBmaXJzdCBhbmQgc2Vjb25kIHJlY3Rhbmds ZSBhcyBjb25zZXMgb2YgdGhlaXIgY29sdW1uIGFuZCBsaW5lCit2YWx1ZXMuICBTSVpFMSBhbmQg U0laRTIgc3BlY2lmeSB0aGUgZGltZW5zaW9ucyBvZiB0aGUgZmlyc3QgYW5kCitzZWNvbmQgcmVj dGFuZ2xlLCBhcyBjb25zZXMgb2YgdGhlaXIgd2lkdGggYW5kIGhlaWdodCBtZWFzdXJlZCBpbgor Y29sdW1ucyBhbmQgbGluZXMuIgorICAobGV0ICgoeDEgKGNhciBwb3MxKSkKKyAgICAgICAgKHkx IChjZHIgcG9zMSkpCisgICAgICAgICh4MiAoY2FyIHBvczIpKQorICAgICAgICAoeTIgKGNkciBw b3MyKSkKKyAgICAgICAgKHcxIChjYXIgc2l6ZTEpKQorICAgICAgICAoaDEgKGNkciBzaXplMSkp CisgICAgICAgICh3MiAoY2FyIHNpemUyKSkKKyAgICAgICAgKGgyIChjZHIgc2l6ZTIpKSkKKyAg ICAobm90IChvciAoPD0gKCsgeDEgdzEpIHgyKQorICAgICAgICAgICAgICg8PSAoKyB4MiB3Mikg eDEpCisgICAgICAgICAgICAgKDw9ICgrIHkxIGgxKSB5MikKKyAgICAgICAgICAgICAoPD0gKCsg eTIgaDIpIHkxKSkpKSkKKwogKGRlZnVuIGRlbGV0ZS1yZWN0YW5nbGUtbGluZSAoc3RhcnRjb2wg ZW5kY29sIGZpbGwpCiAgICh3aGVuICg9IChtb3ZlLXRvLWNvbHVtbiBzdGFydGNvbCAoaWYgZmls bCB0ICdjb2VyY2UpKSBzdGFydGNvbCkKICAgICAoZGVsZXRlLXJlZ2lvbiAocG9pbnQpCi0tIAoy LjE3LjEKCg== --000000000000b1aaeb05773193b1-- From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 02 03:40:14 2018 Received: (at 31240) by debbugs.gnu.org; 2 Oct 2018 07:40:14 +0000 Received: from localhost ([127.0.0.1]:33719 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g7FHy-00089k-6e for submit@debbugs.gnu.org; Tue, 02 Oct 2018 03:40:14 -0400 Received: from mout.gmx.net ([212.227.17.22]:42729) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g7FHw-00089V-Hb for 31240@debbugs.gnu.org; Tue, 02 Oct 2018 03:40:13 -0400 Received: from [192.168.1.101] ([212.95.5.220]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MKYpv-1g7Wna2DG3-001zO5; Tue, 02 Oct 2018 09:39:57 +0200 Received: from [192.168.1.101] ([212.95.5.220]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MKYpv-1g7Wna2DG3-001zO5; Tue, 02 Oct 2018 09:39:57 +0200 Message-ID: <5BB320CA.5090606@gmx.at> Date: Tue, 02 Oct 2018 09:39:54 +0200 From: martin rudalics MIME-Version: 1.0 To: Federico Tedin Subject: Re: bug#31240: 26.1; mouse-save-then-kill does not kill rectangles References: <5BADDC88.7010206@gmx.at> <5BB10CCE.4020503@gmx.at> <5BB1DBF0.5060706@gmx.at> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:c6BEKtvFhwffqPmmKpTFOIkv4L5pyy0/wqHWgG9fnPN+s/zwD6u f7QQDCqCQpUnBuV76SeveIBtjsRKydXPt5e1dQT4r81DzkNRPf4WgP7VBt9nhHgwJkMm9W4 9YiFaSjypA21bzzQsFKT3+87AUA1q+7/MTCAHcaAT6sAo/evMxDR6nfS0Ho5q3Ad+KyXSiz 2zb2HPHSNOFgZBUaxL39A== X-UI-Out-Filterresults: notjunk:1;V01:K0:jDysCFaM26w=:LI+5eiA+E0ykh2e6puLVXG 5Jf8FMkLugR20oM1xofCUkoMmRaxcn6JUtLppJPNIXt/4qNsNcGPcc2EP72r0J4O0suPF9L2d vEZjU+xutCj5MYe7o1+Au9y2Xf+1ijXM2WmT5QI/0eM2fL/s+C64PShlzi3vEAA3bVl8qpThX 9toabvdNjqB8XWhEXJ66uqEoUprclW0eG14EVudboxjz6h2tCzV40vfHqlMx9O0c0R/KsMCX+ 3oOa5JiNYZhH9QyRWCpt1wtUwjOKH39p8vs4N5ya6RxEF5VBRIvgrA5Afw1zYB65ZGC3yJBZh Sti42E98kCL7aZuGUiXhVAqX11EsStSYWu9a2m1EdHzv18AEqaIPrxDJr/lKOYe++wo8yf9b1 qb/d81ATjiufcia/H/Q85A0+rPvldffoFAFn4L5SvfT8/PSJCUbqd+x4kfJESd2qnWmTjZgtG i9CpJcLuRLuV1DXqMoSNNe95gjOXNqrP7X4ZVOY3ArO32hLTRF14Id/M41fH/CmuNo11SO48w 4cF2x26FTbavsSknYqpFNVGaCHwprcCg8A2tDtbbSC9jtU1xnI55QjJjkPInNDedzwL3ftL8o uZ94SMw44lFMFw58WawW6sJzUk0v4ctKy8TqfwdAtoyj/1J6sciEPQoI9lDQRw45GXrUuXfnA Kdm9jFaARsXC8z0jmEAvfJxmaNHOV21gwwgvmKk5hlSVBx+LB+9dZ+H2bDrUoDv9mkWmJd+Y8 56qDnvcTc48PXn5ORI/yKYNXCqSoGcNr08pveNqM6DmlXcDWDDwQfeoHmxFiNMnI1ilIqzsPu 4pcf/mmSoq44eLa/AsVaMuzCKNDReObt6G+WKrpsGQ9VeGqfxI= X-Spam-Score: 0.6 (/) X-Debbugs-Envelope-To: 31240 Cc: 31240@debbugs.gnu.org, charles@aurox.ch X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) > While fixing the mistake, I found the function line-number-at-pos, > which uses the same method I was using (after your correction) to > calculate the line number. I'm attaching a new patch which uses this > function instead. OK. I'll install it in a few days if there are no objections. BTW 'line-number-at-pos' is overly complicated, there is no need for 'start' in it, it should simply do (save-excursion (goto-char opoint) (forward-line 0) (1+ (count-lines (point-min) (point))))))) instead. > Slightly related question: is it better for me to keep sending patches > with all my changes and fixes included, or is it better to send an > initial one, and then send additional (smaller) patches with fixes to > the first one? Personally, I prefer "patches with all changes and fixes included" because that makes it easy for me to throw them away immediately and resurrect them any time later. martin From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 02 08:38:01 2018 Received: (at 31240) by debbugs.gnu.org; 2 Oct 2018 12:38:01 +0000 Received: from localhost ([127.0.0.1]:33905 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g7Jw9-0004mQ-Fi for submit@debbugs.gnu.org; Tue, 02 Oct 2018 08:38:01 -0400 Received: from mail-lf1-f46.google.com ([209.85.167.46]:35423) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g7Jw8-0004m7-7h for 31240@debbugs.gnu.org; Tue, 02 Oct 2018 08:38:00 -0400 Received: by mail-lf1-f46.google.com with SMTP id r191-v6so1292928lff.2 for <31240@debbugs.gnu.org>; Tue, 02 Oct 2018 05:38:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bgVFM5mec4jBUWJtHacGNiJirO64AfNWtQMSgZbt6ts=; b=KX4KcUz/OHSYN0FwwWYyknrmrsaZTlr9gdP1OIUcmeo48Abs97Kok0j6MdOq2ycZqf wmIbsonOYW+5kdEO7Az9YLolXF865u74D9GDc0kyyc3rVqIchgOgjsEBVt89rJw8oiNy u+ewSLvUG0BR559ZopkFilzw0/oRDi1vCjS8O7OCrtjpFxvuIiOPtB6s4qrS6A0sEq7/ YTxw3t4rPeQmOMmpX+JS+EHrLN+T44EgI8XlVl9i56uS0U1a3CQ0phPRbq7wLV90b8Nm 5JZbjMV6Vw4rWxD+4rQ2vGm8IPwifVfEOPKh6CmEd4LvYLITJf2VzUVH074gAnOxpp6M UnpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bgVFM5mec4jBUWJtHacGNiJirO64AfNWtQMSgZbt6ts=; b=DsgK2DSFRLcgbK9POJEG4LSrL+ehz3rlAy2veEhJ7C9OJjUW3EomLhIiO7KqiHAfXI MLtmB62N3vfPMcCjH5yaPj2PAWQsH9uxDZfv3WgDNzh+2NjynX5b0o7EOPnWnSbRRIIG Pbhd/igtUbPhLhbugqFaIMHhsvFMTMzV/kqo30Ukzijl4YJIxaAYJc/6O+Mc3Nh/xlNi WcDnvuP7aHx9E9JU3D6pDV/SELTux+hzW5ZFhPIq8s1Oxwes5u5KWHOJsyXXsRkFFavd rawRZep3g1Y/ixgPrcNbbLKIXoe1EwV8fmOYu2rOb4RvK1m1FvsXv5fNyMl0CZH/yuQk ic1A== X-Gm-Message-State: ABuFfog+s0iZeAaAJaKWa+kWgDP13z7ucIHJzm5yaBSmst2b2wwmZsoG ge/aQEno3P0I0iOt4FZ9XJ2VmvAv6FELtoNeAwo= X-Google-Smtp-Source: ACcGV63/gP3kdITX01G3pTpJ2OHQRSGbcZQ4qzymgR2g+aWiFZgsPpvUi7q2Cxr3aw7GHBPmgQBn87OJ8PssHWYturk= X-Received: by 2002:a19:aa8b:: with SMTP id t133-v6mr8179014lfe.92.1538483873830; Tue, 02 Oct 2018 05:37:53 -0700 (PDT) MIME-Version: 1.0 References: <5BADDC88.7010206@gmx.at> <5BB10CCE.4020503@gmx.at> <5BB1DBF0.5060706@gmx.at> <5BB320CA.5090606@gmx.at> In-Reply-To: <5BB320CA.5090606@gmx.at> From: Federico Tedin Date: Tue, 2 Oct 2018 09:37:42 -0300 Message-ID: Subject: Re: bug#31240: 26.1; mouse-save-then-kill does not kill rectangles To: rudalics@gmx.at Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31240 Cc: 31240@debbugs.gnu.org, charles@aurox.ch X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > BTW 'line-number-at-pos' is overly complicated, there is no need for > 'start' in it, it should simply do > > (save-excursion > (goto-char opoint) > (forward-line 0) > (1+ (count-lines (point-min) (point))))))) > > instead. I agree. On the other hand, I imagined it was better to re-use an existing function which had maybe dealed with problems I hadn't thought of. Should I leave the last patch as it is? > Personally, I prefer "patches with all changes and fixes included" > because that makes it easy for me to throw them away immediately and > resurrect them any time later. > > martin Great! From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 02 09:18:00 2018 Received: (at 31240) by debbugs.gnu.org; 2 Oct 2018 13:18:00 +0000 Received: from localhost ([127.0.0.1]:33914 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g7KYq-0005lW-LE for submit@debbugs.gnu.org; Tue, 02 Oct 2018 09:18:00 -0400 Received: from mout.gmx.net ([212.227.17.21]:52703) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g7KYn-0005lE-VX for 31240@debbugs.gnu.org; Tue, 02 Oct 2018 09:17:58 -0400 Received: from [192.168.1.101] ([212.95.5.220]) by mail.gmx.com (mrgmx101 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MRCCJ-1gIU910sEp-00UdG6; Tue, 02 Oct 2018 15:17:44 +0200 Received: from [192.168.1.101] ([212.95.5.220]) by mail.gmx.com (mrgmx101 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MRCCJ-1gIU910sEp-00UdG6; Tue, 02 Oct 2018 15:17:44 +0200 Message-ID: <5BB36FF4.80403@gmx.at> Date: Tue, 02 Oct 2018 15:17:40 +0200 From: martin rudalics MIME-Version: 1.0 To: Federico Tedin Subject: Re: bug#31240: 26.1; mouse-save-then-kill does not kill rectangles References: <5BADDC88.7010206@gmx.at> <5BB10CCE.4020503@gmx.at> <5BB1DBF0.5060706@gmx.at> <5BB320CA.5090606@gmx.at> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:vxOwQgKmqcMhhj2YeYJa7wbkE/0LbwOyJ1K5FptcacmJ0HXnGUP ZuwO9AhmaduTism/z2KH49yLMnXZs70Nac307TWy5VBw/ZZsK3xF1Or0Fd/KIO7D0TIucsA 7xoV429qkZC094Jyqw3N2o/g+L1DH4RfwBrQGo6HsjeESabfLZSUv2eU45E3ywA/llbPohh Nf/XMPD6t5cSeu4BPvPNw== X-UI-Out-Filterresults: notjunk:1;V01:K0:kIfyzImmIO0=:hCt7xE2VbZOAQMz05KmPOK PDc7k7J130SHDa9ViOqH2+nttqwsFZ23dJ+lujJbAp0DzKMmAxrd9s2SyLZC4Vdy+TThwKOxy Vj0F2jGKHhLyATO1qdyMhOdGirV6GLgGlGgLZRYdLt/fKaknwEd4c08DCtxvcwVb20sCPGVbR 9M1E4HxbIQg+k/TwsPOCymhrctLafBpZJOsqjHgbZ5d8CijGRpjmNekgl4QrjRs0NnEf2GR3Y CwQ2POqW8eZAAS9Z1KiwYLEEgeVAdfpyOnp9Iv1Pj1Dx7pffmkEfxF/HTQrwF1oTlPkDjaBoH JEvUkWc/alAlyt6YwK7WJ9tWpUpLF7s0ltKYV9bN9KPYUg0D/XHi6nxmu5j6+dI4038ykNo5p +Vq8OHceNAf1L9Ujz0KLWpia1ZXmabF6c3uF3nz9kJweX/PVJLxB0mxTMsz+bMbND8xcxKU8a 1BGAmpHup5qMjeyVnpS0qR/O5bD5YmHbrsvJ1+jRaiHdDu97CxBpQZ7AN6ZFyO1/vPlPPCud4 PIr+TjVceKvJEx2NHQ7scdJ3wHL3Aiur5NhxuXW7l7aDEiNgmOG45cdqBYEkozVrSw47Xeaae nrfWdC7jkWq17fjKPSoUXrxqZimha0yC+bAnrGw3OOqNHSWNBtv+2f0uMt25l8IHrKQcdEb/V wJMY5Ap1H1gyiWwgHpQB8jxcVDWQRPe67+QX6MctCWvM1SDF6Jb6OYyNLp4SHO/T/X69TM3vj fBhO5/40EOftA99h72F9ol4CuX8bJp96XBzG9rCoz9/buSwGCrwhhvHw9ilCDVU1XSVQwMLDa kBsxwcFAAHZrybTfKBGmvkMPsQpOFDjE18gtn8Pkt9L0FN8G7k= X-Spam-Score: 0.6 (/) X-Debbugs-Envelope-To: 31240 Cc: 31240@debbugs.gnu.org, charles@aurox.ch X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) > I agree. On the other hand, I imagined it was better to re-use an existing > function which had maybe dealed with problems I hadn't thought of. Should > I leave the last patch as it is? Sure. martin From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 03 22:56:21 2018 Received: (at 31240) by debbugs.gnu.org; 4 Oct 2018 02:56:21 +0000 Received: from localhost ([127.0.0.1]:36253 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g7toL-0000RT-0T for submit@debbugs.gnu.org; Wed, 03 Oct 2018 22:56:21 -0400 Received: from mail-oi1-f171.google.com ([209.85.167.171]:40335) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g7toI-0000RF-IJ for 31240@debbugs.gnu.org; Wed, 03 Oct 2018 22:56:19 -0400 Received: by mail-oi1-f171.google.com with SMTP id j68-v6so6278347oib.7 for <31240@debbugs.gnu.org>; Wed, 03 Oct 2018 19:56:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3kVcdW55Lz/K0WsAs5ZXEyo8P2MoCI1EsjxXXtLUcIM=; b=WiBX8ZhXlTqUEAp7UrpFqa7I804exTkYntuV+khW25sbXTW8uxeL9fDHG2VepnrJJS i3rUTJmXAbzlHhQnlTii/ExlBkLaQPx8GYjMfq48H/dKr105UNVVbs5gz3UX/PZOcy9A nlvRaoS3gjDQss+wXLzihr0IPcRBgXIBxQvYNA8jNinNND+hGTX+cew6PYw9u+wlw0NU jV/M7VwV9/anszr44LZ2TWm0IsOSHSl+L+DWDKWqthj9eMorfnnlYpEPA3RIvJBvpZcl 03RZtHhUNaFZxEck8qvxNB82AuJ+3+wS/9ZKJ/hfMtL+zzMdr7W5MgGB3r1RUFNajHVx TQgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3kVcdW55Lz/K0WsAs5ZXEyo8P2MoCI1EsjxXXtLUcIM=; b=czAreuy1QwMsTwVdLXBL9d+B8twLvE/wQB5BNNuef9OYczVAKZw7l+ZjVd6efKsvnN 5M1n4tut5Ic2/rFB4jJvLYnFm3Yncl2GGriiI/Z0/3eOAOsG9+c16xxSS2wwNPRfVOnL SzdkJl7NCuyxdTr03Id1DcpR8sxf2xaiSHnw3w0KasU5rnZCrZ1FEOVu0BzS6tiFZhlN iHwJhi97kkoVrFjBLXMYFsbItZG6PwuZn7Zot6mkrYbKoZbNsgk3SrgqR6xZjNMazch3 u5koiwnTg9eWxptAERyZZ2EMYzpJH3M7pH+ecmficQ529+MBYm90QVhTpmJ/ly91oBh+ Vc5g== X-Gm-Message-State: ABuFfohofaCnqc5VE1EFIfLlu/seyltNBm39MNXGjaHWzDPAN1zg9QAH 4rVQcXsOqbRY7SBHfjcAe3++JIpaJN0/+prYekA= X-Google-Smtp-Source: ACcGV61vF9sqsbwiPYW6NDLc6DQvPqBeoDSaKe4KpbWitAlYmEiYm0dTx2M4GHjPn6lgNZcT+U5sJkd7s+OiMOaDetE= X-Received: by 2002:aca:c392:: with SMTP id t140-v6mr2165362oif.325.1538621772942; Wed, 03 Oct 2018 19:56:12 -0700 (PDT) MIME-Version: 1.0 References: <5BADDC88.7010206@gmx.at> <5BB10CCE.4020503@gmx.at> <5BB1DBF0.5060706@gmx.at> <5BB320CA.5090606@gmx.at> <5BB36FF4.80403@gmx.at> In-Reply-To: <5BB36FF4.80403@gmx.at> From: Homeros Misasa Date: Thu, 4 Oct 2018 11:56:03 +0900 Message-ID: Subject: Re: bug#31240: 26.1; mouse-save-then-kill does not kill rectangles To: martin rudalics Content-Type: multipart/alternative; boundary="00000000000038538005775e4c44" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31240 Cc: 31240@debbugs.gnu.org, "Charles A. Roelli" , federicotedin@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000038538005775e4c44 Content-Type: text/plain; charset="UTF-8" ;; This [buff]er is fo ;; To cr[eate] a file, When I grab a rectangle as shown above, I cannot move the rectangle by 1 char to the left, because of usage of `rectangle-intersect-p'. Behavior on moving up, right, and left seems good. --00000000000038538005775e4c44 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
=C2=A0 ;; This [buff]er is fo
=C2=A0 ;= ; To cr[eate] a file,

When I grab a rectangle as shown above, I cann= ot move the rectangle by
1 char to the left, because of usage of `rectan= gle-intersect-p'.
Behavior on moving up, right, and left seems good.=

--00000000000038538005775e4c44-- From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 05 02:57:46 2018 Received: (at 31240) by debbugs.gnu.org; 5 Oct 2018 06:57:46 +0000 Received: from localhost ([127.0.0.1]:37354 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g8K3W-0000v8-4d for submit@debbugs.gnu.org; Fri, 05 Oct 2018 02:57:46 -0400 Received: from mout.gmx.net ([212.227.15.18]:54571) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g8K3V-0000uu-1n for 31240@debbugs.gnu.org; Fri, 05 Oct 2018 02:57:45 -0400 Received: from [192.168.1.101] ([212.95.5.105]) by mail.gmx.com (mrgmx003 [212.227.17.190]) with ESMTPSA (Nemesis) id 0M0xbD-1frCJ22YUJ-00v6hA; Fri, 05 Oct 2018 08:57:31 +0200 Received: from [192.168.1.101] ([212.95.5.105]) by mail.gmx.com (mrgmx003 [212.227.17.190]) with ESMTPSA (Nemesis) id 0M0xbD-1frCJ22YUJ-00v6hA; Fri, 05 Oct 2018 08:57:31 +0200 Message-ID: <5BB70B54.5000103@gmx.at> Date: Fri, 05 Oct 2018 08:57:24 +0200 From: martin rudalics MIME-Version: 1.0 To: Homeros Misasa Subject: Re: bug#31240: 26.1; mouse-save-then-kill does not kill rectangles References: <5BADDC88.7010206@gmx.at> <5BB10CCE.4020503@gmx.at> <5BB1DBF0.5060706@gmx.at> <5BB320CA.5090606@gmx.at> <5BB36FF4.80403@gmx.at> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:59jqvRWySWl9CpmPZskhxj3EkhJ/8w9OgoKUym+2l7Et+z7CJsX aZCRHGfyXt6XfiXstyUD2AoWbDoV1K2IEZw4cpVGlWOPOv3uTdrnQdZ4c1N57T11SUV7nB0 IhmTmovKjLDLCFiuNrivjOpbeVQ3nkR8wei90BI/rxxemXFwZ88g0i2tM+kzIP0pknbu9Yc Am8zpC5NCrk8AWMPYwodQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:/iKKnM+oMjA=:s2OVWV4N3PZWRwNkpLwuo1 Lp+8edYzWReK5m3GVSDOOv/1+l10/bk0cAU9cClOMgXxlFXPKCQO8vBbqikyU0186R7rsFTp9 z5QEV67VNDSuYkKfTUHvzspd9ccfNixt0ZXstoH3SMtrPXr4vcJcfsqmgRA8ym2c5bpIZEzxL Cd3IwuiH3DCVvE+lNhhqGKf+U/4KXCmTCE0LT0Pn6rJra+THVkwE+qfiK94TReZMHA/f5Ai1m MTDJqXeaFGTD384RX11uaBE2G0Rv8RuHS100EJBg7oHGZ5byTI+15i4q8eQMrmrYzzgO1cY0j yYGrarUP59WLcuNLf8P0BFzvJpLzFp5oqY4AsYXGLQuW5WE5VOuXjEZPBH0kOioRaLjIWTzpN kmYGGCMzeSFTyy+IrT6+/sCDI2oSCG2fiUATKhqvlbPl1tnI55Iw7OaixGQwK/VJMGzazgKQk WMmbKWRua/4EpQT0+dRrAjY0wgARzeN2jJiOkxMXKM6HuFbYrE7JxBYtgQcliypLbbBn+/4jb xzFfRJe5ykyFtf2AsH2upyB8zVOgdgso3EnN6bAAPMGboZjbhSizF1B5Wq8un/kzVFkkCKgvy SAGczvcYUBaADgGkjJb4MPo/zj4qdHZx/Gk1Q742wVLBdR/EIjNFPzhxrQ8MZaNVwMbFzXGGk YtiAp6W7h6lMspeo0RdDk3w5iPBPHz9Ds7/o9kSXAyBd92B9XV8tkEULi4XsyPWIbqN1uuNAC c4258bf2BOoLUe156AygSApaGomF/ZZitZSBoF9LI+UJ2SRS/yC2WG2x7sM+ma+0AVvM3/XOJ zi93PRu6+btWmV0U9tE/yO9EXeS1PCVpY+9/0zXz5AjpXcd2w8= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 31240 Cc: 31240@debbugs.gnu.org, "Charles A. Roelli" , federicotedin@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > ;; This [buff]er is fo > ;; To cr[eate] a file, > > When I grab a rectangle as shown above, I cannot move the rectangle by > 1 char to the left, because of usage of `rectangle-intersect-p'. > Behavior on moving up, right, and left seems good. Please tell us more precisely what you tried to do. With (setq mouse-drag-and-drop-region 'shift) dragging the rectangle by one "character to the left" and dropping it with the shift key pressed gets me ;; Thisbuff buffer is for text that is not saved, and for Lisp evaluation. ;; To ceatereate a file, visit it with C-x C-f and enter text in its buffer. martin From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 05 05:28:47 2018 Received: (at 31240) by debbugs.gnu.org; 5 Oct 2018 09:28:47 +0000 Received: from localhost ([127.0.0.1]:37406 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g8MPf-00052F-Et for submit@debbugs.gnu.org; Fri, 05 Oct 2018 05:28:47 -0400 Received: from mail-pl1-f181.google.com ([209.85.214.181]:45104) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g8MPd-000520-Cp for 31240@debbugs.gnu.org; Fri, 05 Oct 2018 05:28:45 -0400 Received: by mail-pl1-f181.google.com with SMTP id y15-v6so6564790plr.12 for <31240@debbugs.gnu.org>; Fri, 05 Oct 2018 02:28:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=nH4Um6gX4TU+MTeMqqSbGX9TCFziBxbDliZfyFERies=; b=Px9K/3UG3x57ffMRhr+REGjgKPMCXDMdBFxJ1GS8up/QdNXM3s5GCk5M1IiNXGLYPc qbcVQJkg46QSy3ZoGr8DbieHa0R4lmjcH3hpfy3Z6Ci1PQPWkP/y3a++m+xdxmIL/Hcv Veuhd2zGoObhnMQaKy8QpLU3MnJXFfsueApUHZRtiIgZj31O2XzIkN90zZukBu8oK0Wz f53nSx16q5AaG/VraekjyZGsPvk8LUJEubsUC4sqXMvKNsE2FhuYp8/XTT4Kx5dkDHjW LeQoExhrVggSxvLMgjUnrCwB2WstC1iKT6UGFQr+fycbNx8Gs4ndp240voHYsVEBoKTL vqZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=nH4Um6gX4TU+MTeMqqSbGX9TCFziBxbDliZfyFERies=; b=SlTvEBKBXjFxJDuJCRcs1wcdJ2YspjDVu1m16gZWF3EVW8WcHE+4ldtQyBUZ/IxPde E/CULJrx3jTM7lPlRxrYQkvNcxNOco9tO7tTqCSNE+foGOdndFHd6bWPrt1Q2C3YfENB 72XwGHSM4Tlw7TGRl+D1SRQ9ugJ9UDACAY/l0Un7LgRQE2ZUleW8ECOHzFsodBNomnIx qsrca4vDLj7k9gEzZIQUNo7nhBFAP/Scw4Xu12qKaJO04VVHzmaMxsyCW4wYHq4aJTJC FPKk4pJMPZG419KGNc0Je7kS9kgz/rInE/15qImBTRepv55IdFuqRaSWOOgVWexo6JMw jqmg== X-Gm-Message-State: ABuFfoghT1j9/L+SYSSzSRLwyW3CgHEVeeXDHvDil3VwzifpkUFjbi2a X8/wtzId7cfVPhEErW9avlk= X-Google-Smtp-Source: ACcGV63YXopTC6nLNKjbQSt7Tlr4KkfWLwi7pYJpQvw2yZk+dDoq6CU2PzeupgeVMs3inrdgMuZZsA== X-Received: by 2002:a17:902:a40c:: with SMTP id p12-v6mr10769013plq.165.1538731719500; Fri, 05 Oct 2018 02:28:39 -0700 (PDT) Received: from thinkless2017 ([150.46.201.82]) by smtp.gmail.com with ESMTPSA id g6-v6sm14888212pgf.33.2018.10.05.02.28.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 05 Oct 2018 02:28:38 -0700 (PDT) From: Tak Kunihiro X-Google-Original-From: Tak Kunihiro To: martin rudalics Subject: Re: bug#31240: 26.1; mouse-save-then-kill does not kill rectangles References: <5BADDC88.7010206@gmx.at> <5BB10CCE.4020503@gmx.at> <5BB1DBF0.5060706@gmx.at> <5BB320CA.5090606@gmx.at> <5BB36FF4.80403@gmx.at> <5BB70B54.5000103@gmx.at> Date: Fri, 05 Oct 2018 18:28:31 +0900 In-Reply-To: <5BB70B54.5000103@gmx.at> (martin rudalics's message of "Fri, 05 Oct 2018 08:57:24 +0200") Message-ID: <864le0agjk.fsf@misasa.okayama-u.ac.jp> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (windows-nt) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31240 Cc: 31240@debbugs.gnu.org, tkk@misasa.okayama-u.ac.jp, "Charles A. Roelli" , federicotedin@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> ;; This [buff]er is fo >> ;; To cr[eate] a file, >> >> When I grab a rectangle as shown above, I cannot move the rectangle by >> 1 char to the left, because of usage of `rectangle-intersect-p'. >> Behavior on moving up, right, and left seems good. > > (setq mouse-drag-and-drop-region 'shift) > > dragging the rectangle by one "character to the left" and dropping it > with the shift key pressed gets me > > ;; Thisbuff buffer is for text that is not saved, > ;; To ceatereate a file, visit it with C-x C-f an Yes. Dragging the rectangle by one "character to the left" and dropping it with the shift key pressed work as expected. start> ;; This [buff]er is for text that is not saved, and for Lisp evaluation. start> ;; To cr[eate], vie a filsit it with and enter text in its buffer. goal > ;; Thisbuff buffer is for text that is not saved, goal > ;; To ceatereate a file, visit it with C-x C-f an I want to kill the rectangle and yank it to column 7 by dropping it without the shift key pressed. 0123456 start> ;; This [buff]er is for text that is not saved, start> ;; To cr[eate], vie a filsit it with and goal > ;; This[buff] er is for text that is not saved, and for Lisp evaluation. goal > ;; To c[eate]r, vie a filsit it with and enter text in its buffer. When the `inserting' cursor is located at left side of rectangle and on the same line as the first line of the rectangle, user should be allowed to move the rectangle, I think. From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 05 08:16:03 2018 Received: (at 31240) by debbugs.gnu.org; 5 Oct 2018 12:16:03 +0000 Received: from localhost ([127.0.0.1]:37474 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g8P1X-0004qy-JI for submit@debbugs.gnu.org; Fri, 05 Oct 2018 08:16:03 -0400 Received: from mail-lf1-f41.google.com ([209.85.167.41]:41684) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g8P1W-0004qI-DT for 31240@debbugs.gnu.org; Fri, 05 Oct 2018 08:16:02 -0400 Received: by mail-lf1-f41.google.com with SMTP id q39-v6so9182401lfi.8 for <31240@debbugs.gnu.org>; Fri, 05 Oct 2018 05:16:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XJAoo/AURI/lSxN+MtCn/GH7QfJ8xI3yej73KfLxbOs=; b=DW+/rqHoGDpIOuWK8wfGpXHsuOijCG9Vh/DXYRWI4PWgQac5XdWQqOpHMk8YITKJYs 6FHGjs8gPzf91bocQEMBcmbQF9r0ZwdBHcZjz9RlqPJ4aMPEZtJH9s4acPdWN+RHL6IF hbGf+DUOla3bwDZkAozXatI00H8wd0GY3E4iKEbg855CiNZPuHEUAy7M7f0vbXh6VBd5 yurITZdmzKH5DSRURnijzTilaLCOFJHiqqRoZUpgSdX+0TwtwCsqq19UEMrtA3DieqCb 4jn76eLTFVo2+Hgs1mme8+GPcdWxd0htjoMKazORsyZby4qmu/0o9Xrn+syWxUHXIOIA 4sNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XJAoo/AURI/lSxN+MtCn/GH7QfJ8xI3yej73KfLxbOs=; b=EHWW5morQzI3PIs1VvdSBSspwGXmgPtXLRvHB5LdNYQcYbzfbwy3ZyVEUAB4PhRE3m TXPcw4lApFvBJamAI9fGNyunJTYT3pI1HttK7j9OdLe5Hmu97iaA74+kemLH3E4OERmL wOtb/wDAmeZlTBTudUj3zqce3jsdMwK1fre6mDrDPMLxMfdXKD797Btk+aXVvhwt4BiW Czy357y6EeVN9MYVbGy4X6f9Mfo9G+gXsdSAO1D5a6QySLnCJV5SfNsTFNLgBPG8p89g S3kAY0H025Dewkua6T1BKjVsEO/KNO+xUh1vTXW6kpE3U38TEPl59Uk3qGR9v1HoIK7X 6UMQ== X-Gm-Message-State: ABuFfogfqXlEqWg8KxwjU1gst6a3eeMXxsL3oDg+R6MZzJmX0mtuIHuC Df4JdrKY32qdkD20N3QK3m4+fvttsiOnTfbya9I= X-Google-Smtp-Source: ACcGV61dKs22OwYi3DgAWjRv/u3wPS1AkvXAIf6TrN2xwOhsHwgvDmWLGQbvk8RAS3ao3bM+mp9pe2CEzsuw+gQxrpU= X-Received: by 2002:a19:4f17:: with SMTP id d23-v6mr4369306lfb.121.1538741756434; Fri, 05 Oct 2018 05:15:56 -0700 (PDT) MIME-Version: 1.0 References: <5BADDC88.7010206@gmx.at> <5BB10CCE.4020503@gmx.at> <5BB1DBF0.5060706@gmx.at> <5BB320CA.5090606@gmx.at> <5BB36FF4.80403@gmx.at> <5BB70B54.5000103@gmx.at> <864le0agjk.fsf@misasa.okayama-u.ac.jp> In-Reply-To: <864le0agjk.fsf@misasa.okayama-u.ac.jp> From: Federico Tedin Date: Fri, 5 Oct 2018 09:15:44 -0300 Message-ID: Subject: Re: bug#31240: 26.1; mouse-save-then-kill does not kill rectangles To: homeros.misasa@gmail.com Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31240 Cc: rudalics@gmx.at, tkk@misasa.okayama-u.ac.jp, charles@aurox.ch, 31240@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > When the `inserting' cursor is located at left side of rectangle and on > the same line as the first line of the rectangle, user should be allowed > to move the rectangle, I think. The example Homeros tried to run won't work, because the newly intersected rectangle would intersect the original rectangle. This behaviour is intentional, as it is similar to mouse-drag-and-drop-region's behaviour with non-rectangle regions. However, I think an exception could be made for rectangle operations move the rectangle horizontally to the left, as Tak said. When the rectangle is dragged to the left, there's no way its content could be accidentally added to the overlays tracking the original rectangle, so it'll always work correctly (even if rectangle-intersect-p returns t). From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 06 13:09:17 2018 Received: (at 31240) by debbugs.gnu.org; 6 Oct 2018 17:09:17 +0000 Received: from localhost ([127.0.0.1]:38811 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g8q4q-0008UX-PG for submit@debbugs.gnu.org; Sat, 06 Oct 2018 13:09:16 -0400 Received: from mout.gmx.net ([212.227.15.19]:40735) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g8q4p-0008UJ-2L for 31240@debbugs.gnu.org; Sat, 06 Oct 2018 13:09:15 -0400 Received: from [192.168.1.101] ([46.125.250.121]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0Mgt3g-1gLzF724Ho-00M3U2; Sat, 06 Oct 2018 19:08:53 +0200 Received: from [192.168.1.101] ([46.125.250.121]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0Mgt3g-1gLzF724Ho-00M3U2; Sat, 06 Oct 2018 19:08:53 +0200 Message-ID: <5BB8EC23.1040303@gmx.at> Date: Sat, 06 Oct 2018 19:08:51 +0200 From: martin rudalics MIME-Version: 1.0 To: Federico Tedin , homeros.misasa@gmail.com Subject: Re: bug#31240: 26.1; mouse-save-then-kill does not kill rectangles References: <5BADDC88.7010206@gmx.at> <5BB10CCE.4020503@gmx.at> <5BB1DBF0.5060706@gmx.at> <5BB320CA.5090606@gmx.at> <5BB36FF4.80403@gmx.at> <5BB70B54.5000103@gmx.at> <864le0agjk.fsf@misasa.okayama-u.ac.jp> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:nNBW692A9PFGsTM22aII5hFeopQzTGQds0IFhdPeZf7Nu76lA1B o2bhliVHAY4XvZAxuXlqiTZf9Ge5wBiMorgO/tPlguzAJ/R0dEFCv1V0xOzfbnPDf/4cOee wmtWoIX5/9P8K8zz4geCFi6gNtQXgTOOd4bEKd0mouB0UNRc+NVlisceqiQ3A3ku04gpt6x kiZPbcgnvMG6GWAsm4FNg== X-UI-Out-Filterresults: notjunk:1;V01:K0:yhfGjmvmVTM=:zAo6u+zxjDm2JkcQc6FrYC oRB1XJmKImk9773FPbH+dBgtdsjtyOjQXgB8Si3bR6nJ0sesyWOednz9pXk+lPQo0X3Ky2YU/ aMmWhirNJIFUQUmrx4n2/l4e7o2/8j76WeZHW4uiR7D7eDT/J8kKqSB8OXhjotlgU/+P/2EFe glgpa+asdS7lAhdx0GF6rFW9nbq2veeUGaUoWrkAGAnmPE6uk63If5UFULEHUT91C/MZ1LJ74 B6xcikSf5ZL/QbWq0oxHmsruVovmlHgHNoHSFdsvQQNvqJWokJtYAqtAsNQ5rymPAjZDJ0wWN SFPXTZ/uORayZYHmMWaRCjKU9LI0ZAzMSLd2WF+nlQhb2u1Tl7YGaLQKfPRnoQqdOSq/7lI+1 yRXZIExmcfnlLNL5+raa/xwb7U3PPZqHARz9nnkZG+CfTe7vInUG+TInSHhdGTEZV7k2ohvk6 6MsevvTX9z+BIet50pOB9ZHhZpuxc+Q4/C4ZvEPvxi5aklgLzIHb8XwdLKnOuCr1UwFmoeJwf I3yUWclhLPb3NC6T/jYva7c7P7ljHIZO4S7F0eKib0pxVByiYJ18E6wAnbyBHEZQgztmmPUeI ff+SeOOlc6j50tm+lxxTDZHDRjg8dZkyROYNyXQ9CpaUeqWCvtpHzzYIAWWo84OYBThta5dIj JJ5bKsQdllsmBYu8yQxZFn1Q/APeoYTT14sUav4zPx+Za7IVySjzxtHkKOGz3IJ+SP0M/AyXK x2v3QouGB7UPTwK/LKO5x4IcKWs6r3o1Xufqk/G+IQZg4qiuaoO/FYrBOKpho80iwTer9wyDO JMYpzuymw8GptGttE0aDF9WDVnFxmd9Wzy3bdNnEa2WAqyLH+M= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 31240 Cc: 31240@debbugs.gnu.org, tkk@misasa.okayama-u.ac.jp, charles@aurox.ch X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > The example Homeros tried to run won't work, because the newly intersected > rectangle would intersect the original rectangle. This behaviour is > intentional, as it > is similar to mouse-drag-and-drop-region's behaviour with non-rectangle regions. > > However, I think an exception could be made for rectangle operations move the > rectangle horizontally to the left, as Tak said. When the rectangle is > dragged to the left, > there's no way its content could be accidentally added to the overlays > tracking the original > rectangle, so it'll always work correctly (even if > rectangle-intersect-p returns t). FWIW I see no problems with the following naive amendment (let ((size (cons region-width region-height))) (and (rectangle-intersect-p (rectangle-position-as-coordinates start) size (rectangle-position-as-coordinates point-to-paste) size) (not (= (line-number-at-pos start) (line-number-at-pos point-to-paste))))) which also allows shifting the rectangle strictly to the left or right. IIUC it's the deletion of the original rectangle after the copy was inserted on a different line that's causing havoc with intersections. But I have not tested all possible variants so please correct me if I'm wrong. martin From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 06 16:17:19 2018 Received: (at 31240) by debbugs.gnu.org; 6 Oct 2018 20:17:19 +0000 Received: from localhost ([127.0.0.1]:38877 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g8t0p-0006aw-Gl for submit@debbugs.gnu.org; Sat, 06 Oct 2018 16:17:19 -0400 Received: from mail-lj1-f193.google.com ([209.85.208.193]:46727) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g8t0o-0006aj-BY for 31240@debbugs.gnu.org; Sat, 06 Oct 2018 16:17:18 -0400 Received: by mail-lj1-f193.google.com with SMTP id x3-v6so902259lji.13 for <31240@debbugs.gnu.org>; Sat, 06 Oct 2018 13:17:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6yWbBrIVt+7mqyQfsQbzK1EdLXb0Bvxo6e/O8j0ZoSk=; b=PuFJe0+A5wkPXA60efX852fpp6ypqbdCt25376nsEm2I+SlXwegKOrp5PJwsZUXfFT 7ywtBOkW3VRpEb3xq14yv9rsBhf/lkadH7CtnvCxS5N9EDi5z/7hGIVmWuZXLtyezbQk GLvpCVryPtXyNgz85BGUnWICVWzKm2Sj3rJUGG9ffCy+uIcsnGZCIhve1XWSgLHrge0G 0OFd/UXTanOnr+xhhn5soE/i6VrqEySpph9HMj/LuisYAPvpLi5WOmX4yiJ0VB1ybkKc Tck7JUOE3I2GYIbl+FSSiJl69xQvgd3sP6ZdDKtpAOC/x4QBs/Zi7nsX4rUrlu1pUKVL xoBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6yWbBrIVt+7mqyQfsQbzK1EdLXb0Bvxo6e/O8j0ZoSk=; b=IT9LU07Iaynd97c0WyGB05/v5YlPn3V8Rq7KURd41Qi7No0VT3rrqoxcc1qn9yZffl 043B3Otteg2WvDKroCAffTbEJdXkJ/GHLjMo9tFfagAxYW956pLwjum9d+W5yLhcNDBs eVCCMA3ctFkmKrvh94ulABLo43+xO0b/3NEOpFmpDOXKvAeWtxhAeMNiN5ta3KBA/PE/ dUtp63gn6nwSBgwoGgq+yRlSqTDhcMP48KxKV8Twej3+T5gAy8+LaYxJ/863uvplGIPQ SKLfyCa0IC88GWSN6dnt2qlx4OOMUoybLKZ/ztpJm+RgkYJLpDf6aAw7HuHj5+qGKL/G A5/Q== X-Gm-Message-State: ABuFfohOH5z5mRMFAvPTNM+oOR8kMJqk9J96On3/s4vgIBOaEkKS2iM+ PboQ/CMBvyvhMKEyvtt+e7o90uPEdT+JweV9aqU= X-Google-Smtp-Source: ACcGV614Nimr/Gc65cJL/ClzopMagEzYR0djad37wqIwMqmxgnmm7z2qw37eZROJ2vgb1YBv1vCD6DJrVNjPvHPIfpc= X-Received: by 2002:a2e:6a19:: with SMTP id f25-v6mr10708188ljc.50.1538857032122; Sat, 06 Oct 2018 13:17:12 -0700 (PDT) MIME-Version: 1.0 References: <5BADDC88.7010206@gmx.at> <5BB10CCE.4020503@gmx.at> <5BB1DBF0.5060706@gmx.at> <5BB320CA.5090606@gmx.at> <5BB36FF4.80403@gmx.at> <5BB70B54.5000103@gmx.at> <864le0agjk.fsf@misasa.okayama-u.ac.jp> <5BB8EC23.1040303@gmx.at> In-Reply-To: <5BB8EC23.1040303@gmx.at> From: Federico Tedin Date: Sat, 6 Oct 2018 17:16:59 -0300 Message-ID: Subject: Re: bug#31240: 26.1; mouse-save-then-kill does not kill rectangles To: rudalics@gmx.at Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 31240 Cc: 31240@debbugs.gnu.org, homeros.misasa@gmail.com, tkk@misasa.okayama-u.ac.jp, charles@aurox.ch X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > FWIW I see no problems with the following naive amendment > > (let ((size (cons region-width region-height))) > (and (rectangle-intersect-p > (rectangle-position-as-coordinates start) size > (rectangle-position-as-coordinates point-to-paste) size) > (not (= (line-number-at-pos start) > (line-number-at-pos point-to-paste))))) > > which also allows shifting the rectangle strictly to the left or > right. IIUC it's the deletion of the original rectangle after the > copy was inserted on a different line that's causing havoc with > intersections. But I have not tested all possible variants so please > correct me if I'm wrong. The problem with this is that when the rectangle is inserted to the right of the original one, it is inserted inside the overlays tracking the selected rectangular region. When the original rectangle is then deleted (by deleting the overlays), the newly inserted rectangle is also deleted. You can try this by dragging a rectangle 1 char to the right. This problem exists because mouse-drag-and-drop-region first inserts the dragged contents, and then deletes the original selection. Is there a reason this has been implemented like this? It sounds like it would make more sense to first delete the original selection, and then insert it elsewhere. This would be almost the same as killing and then yanking some text. That being said, for non-rectangular regions, any of the two methods works the same. From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 07 02:17:35 2018 Received: (at 31240) by debbugs.gnu.org; 7 Oct 2018 06:17:35 +0000 Received: from localhost ([127.0.0.1]:38991 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g92Nj-000498-79 for submit@debbugs.gnu.org; Sun, 07 Oct 2018 02:17:35 -0400 Received: from mout.gmx.net ([212.227.17.22]:40363) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g92Nh-00048u-W4 for 31240@debbugs.gnu.org; Sun, 07 Oct 2018 02:17:34 -0400 Received: from [192.168.1.101] ([46.125.249.119]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MIPhr-1g8Dh8348d-0049Pb; Sun, 07 Oct 2018 08:17:13 +0200 Received: from [192.168.1.101] ([46.125.249.119]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MIPhr-1g8Dh8348d-0049Pb; Sun, 07 Oct 2018 08:17:13 +0200 Message-ID: <5BB9A4E5.3070308@gmx.at> Date: Sun, 07 Oct 2018 08:17:09 +0200 From: martin rudalics MIME-Version: 1.0 To: Federico Tedin Subject: Re: bug#31240: 26.1; mouse-save-then-kill does not kill rectangles References: <5BADDC88.7010206@gmx.at> <5BB10CCE.4020503@gmx.at> <5BB1DBF0.5060706@gmx.at> <5BB320CA.5090606@gmx.at> <5BB36FF4.80403@gmx.at> <5BB70B54.5000103@gmx.at> <864le0agjk.fsf@misasa.okayama-u.ac.jp> <5BB8EC23.1040303@gmx.at> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:2cO0wUKvzhjaG11F602LQRKZwtFBSgIqGuBk1UpdM8sFhQlJByp WnL1rvvgULXFqAZ5TBu9q6jGpfXQOzeb7siQuAWcUAnarvcN/2P0Eu9m7Pdfjt417jFPDbV GIuecGne9GgoJQtzjp+Y98g41HGMg1YknbvzVPHOuQpjONIv3y6rm0ukQD98vAtUEBVIJrR IM7Lq6+uHWfGuqepsZFQw== X-UI-Out-Filterresults: notjunk:1;V01:K0:FbzXKCx+eHg=:dHYIlC8BZ9tYYUJ66wMDsR iNC8jz90bfnvdyTmWbk9CpQw2Ig0MOqdMwpCeS8AedouyTXyA2WP0d+xU4FSx1ISODI4QvM8G YF+BvFvGwTCkV5Y0ytRm60WJ0f8qOwj2gFddr7bT8xKngozM0KLKfUFyglXmNzqVbEdi0E+Pl son23FVM3W5zb8IB+FN/OgxuYB/hWgnhJ2fD6350Ge0kCA+Y1rl8b0E93hJ9thjHovH02AWQM WbkN/gZyEc9Qho4I4AuiBVnYu7XfX+Q3AdMVgHg7hcXTJscwwNlrznfiRYAehzghmps+6Mzug D4coaJUYGpuMaXrkwR7IaOSz3WyhWNZvdj7lYwKnkHpDXLra+WgCwH21kI6PyfjzkgdJNL15F DVabXpki1tjQT5EByxOLSZ8LOpwjnC/Uxf23EIRWbBZtJVZShUOybaebsC9Zu0qiL78tJjS/f CZaVGtmhT6ahLpHKNNVFzvWYOlvPUmr++yrNUSQMivgTe92Q2Wa6BggThlrBbvDOePOGPcjxc Venf1t8ahF4rvYYCPRL4XdcEnYU5IVzFsHNLD9LruK7OomYLPw8jyakddNZgPw6S5M05Q4beQ dl/DsKmyQtcs8OxNiAFJiYA+vOWK0zPeBSNcDhTSfXyNfV5up0u+aowAREbaxtnjY7Mju0LLX mPYyG999gtWlfWuiU3WoaK2hUL6Yz76MuCWGxq9MlrzVgqIP011tbixcK0cVD0DmF/Tpy0Wcy eLKRggqCsbpqVFy3pw01fUhFdGQrvvszc5BWowZRYK1IGkTAWEGJzgKcqz3n+EVkfHID2Hc5w 3cwM0Zt5KC9NpyUXjx/SYOYr4JD2WJnI91PmBTCUmdzNxvNgUE= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 31240 Cc: 31240@debbugs.gnu.org, homeros.misasa@gmail.com, tkk@misasa.okayama-u.ac.jp, charles@aurox.ch X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > The problem with this is that when the rectangle is inserted to the > right of the original one, it is inserted inside the overlays tracking > the selected rectangular region. When the original rectangle is then > deleted (by deleting the overlays), the newly inserted rectangle is > also deleted. You can try this by dragging a rectangle 1 char to the > right. You're probably right, I have no knowledge of the rectangle code. Another naive try: Disallow inserting the rectangle in the first row of the original because that case is almost identical to that of inserting a contiguous region into itself. (if region-noncontiguous (let ((size (cons region-width region-height))) (and (rectangle-intersect-p (rectangle-position-as-coordinates start) size (rectangle-position-as-coordinates point-to-paste) size) (or (not (= (line-number-at-pos start) (line-number-at-pos point-to-paste))) (and (>= start point-to-paste) (<= point-to-paste (+ start (car size)))))))) > This problem exists because mouse-drag-and-drop-region first inserts > the dragged contents, and then deletes the original selection. Is > there a reason this has been implemented like this? It sounds like it > would make more sense to first delete the original selection, and then > insert it elsewhere. This would be almost the same as killing and then > yanking some text. That being said, for non-rectangular regions, any > of the two methods works the same. Maybe undoing the operation is more conservative the way we do it now: Currently, a first undo step would restore the original and a second step would delete the copy. Otherwise, we would delete the copy first and then restore the original which would leave us with no clue of whatever the region contained after the first undo step. Kunihiro-san could tell us more about this, maybe. OTOH if reverting the order yields good results when moving the text to an intersecting but different line we could special-case the delete first/copy afterwards behavior on region-noncontiguous. martin From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 08 06:26:12 2018 Received: (at 31240) by debbugs.gnu.org; 8 Oct 2018 10:26:12 +0000 Received: from localhost ([127.0.0.1]:39913 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g9Sjr-0006zR-NP for submit@debbugs.gnu.org; Mon, 08 Oct 2018 06:26:11 -0400 Received: from s12p02o152.mxlogic.net ([208.65.145.75]:56024) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g9Sjm-0006zE-BM for 31240@debbugs.gnu.org; Mon, 08 Oct 2018 06:26:08 -0400 Received: from unknown [42.127.236.175] (EHLO mlsec.cc.okayama-u.ac.jp) by s12p02o152.mxlogic.net(mxl_mta-8.5.0-1964) with ESMTP id eb03bbb5.7ff2667e3700.101150273.00-574.107159212.s12p02o152.mxlogic.net (envelope-from ); Mon, 08 Oct 2018 04:26:06 -0600 (MDT) X-MXL-Hash: 5bbb30be3b6aba21-3a71dac1ea3fec6d56649b4ee17132c8abaa7cb5 Received: from unknown [42.127.236.175] (EHLO mlsec.cc.okayama-u.ac.jp) by s12p02o152.mxlogic.net(mxl_mta-8.5.0-1964) over TLS secured channel with ESMTP id da03bbb5.0.101150129.00-335.107159058.s12p02o152.mxlogic.net (envelope-from ); Mon, 08 Oct 2018 04:25:55 -0600 (MDT) X-MXL-Hash: 5bbb30b3659e6647-67ede8e409b662c5401671e86b5e4644a459e22b Received: from alml002.ouadm.okayama-u.ac.jp (unknown [42.127.236.168]) by mlsec.cc.okayama-u.ac.jp with smtp id 1b30_3f2b_4da34553_04f1_4b37_87ff_65317f1a75a8; Mon, 08 Oct 2018 19:25:43 +0900 Received: from localhost (vpn2015.okayama-u.ac.jp [150.46.138.52]) by alml002.ouadm.okayama-u.ac.jp (Postfix) with ESMTPSA id ACC1A4C0C23; Mon, 8 Oct 2018 19:25:43 +0900 (JST) Date: Mon, 08 Oct 2018 19:25:44 +0900 (JST) Message-Id: <20181008.192544.1387561894315194511.tkk@misasa.okayama-u.ac.jp> To: rudalics@gmx.at Subject: Re: bug#31240: 26.1; mouse-save-then-kill does not kill rectangles From: Tak Kunihiro In-Reply-To: <5BB9A4E5.3070308@gmx.at> References: <5BB8EC23.1040303@gmx.at> <5BB9A4E5.3070308@gmx.at> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 11 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 4 Rules triggered EDT_SA_AU_PASS=0, EDT_SA_DN_PASS=0, EDT_SA_TS_PASS=0, RV6389=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6389> : inlines <6917> : streams <1800704> : uri <2726159> X-AnalysisOut: [v=2.2 cv=H7ur+6Qi c=1 sm=1 tr=0 a=8LLPK8U+aGQ6qN8QlyMYtQ==] X-AnalysisOut: [:117 a=8LLPK8U+aGQ6qN8QlyMYtQ==:17 a=kj9zAlcOel0A:10 a=smK] X-AnalysisOut: [x5t2vBNcA:10 a=2ozYQZI27XVEETVXqWQA:9 a=7Zwj6sZBwVKJAoWSPK] X-AnalysisOut: [xL6X1jA+E=:19 a=CjuIK1q_8ugA:10] X-Spam: [F=0.5000000000; SD=0.5; CM=0.500; MH=0.500(2018100804); S=0.211(2015072901)] X-MAIL-FROM: X-SOURCE-IP: [42.127.236.175] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 31240 Cc: 31240@debbugs.gnu.org, homeros.misasa@gmail.com, tkk@misasa.okayama-u.ac.jp, charles@aurox.ch, federicotedin@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> This problem exists because mouse-drag-and-drop-region first inserts >> the dragged contents, and then deletes the original selection. Is >> there a reason this has been implemented like this? It sounds like it >> would make more sense to first delete the original selection, and then >> insert it elsewhere. This would be almost the same as killing and then >> yanking some text. That being said, for non-rectangular regions, any >> of the two methods works the same. I appreciate mouse-drag-and-drop-region when I move a sentence because the sentence never disappears from screen. Based on this criteria, mouse-drag-and-drop-region inserts first and delete second. Practically it is quick, thus order does not matter much. There are two cases for dragging a sentence, that are ones with (1) deleting the original selection and (2) keeping it. Since to insert is common for two cases, deletion of the original selection comes later. If it works, order does not matter much. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 08 19:18:54 2018 Received: (at 31240) by debbugs.gnu.org; 8 Oct 2018 23:18:54 +0000 Received: from localhost ([127.0.0.1]:40935 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g9enc-0001Lh-VZ for submit@debbugs.gnu.org; Mon, 08 Oct 2018 19:18:54 -0400 Received: from mail-lj1-f170.google.com ([209.85.208.170]:45421) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g9enb-0001LO-9D for 31240@debbugs.gnu.org; Mon, 08 Oct 2018 19:18:51 -0400 Received: by mail-lj1-f170.google.com with SMTP id j4-v6so15586109ljc.12 for <31240@debbugs.gnu.org>; Mon, 08 Oct 2018 16:18:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DmVauZIT4hX3Kq2+vN9Lnd+kHDok/MEDbFA4XY3KydI=; b=BjA/b8EyYTbaxMm09bA3goAzg820rFrdBttQ8xctw9Q+O9Fz8XopQXTKacRzBQT9wq CgCAutUqdnWSpHKEZvqkgCMioxYgKYZa1ulK30ocXYW60tHpVz2l26SonTWctUSpiLeD rDa6ju6vPK1BuRjCOoUeotYy+rMje2mWz0dslVvP+TqAXzgCeLMp5fA434dpJudBGKfd epZBGdhHa/aiJT7/GMU4ZY/ln2QYjpZ/NYDZbUHxws+aOugLe3j08YxF/Y0mUfLawtjw 3rxykpJZl9PNUsiipgthAAL8q1PfinxwTZxTF6MueEVLy2ImV32OywAW6GHE+eoR2FWO 3u/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DmVauZIT4hX3Kq2+vN9Lnd+kHDok/MEDbFA4XY3KydI=; b=KusdqZKjQhCl4N6Wio3umzOcRmRJ3L1MnHi6O+q0szXYuDoIdw26N2huEQSbqfHFee 1/bYgeKbPAwac/izIkfxpHSE4us0X53jzmiT1POb+usiwqG5UHnbace2QvvEswWhnRZV KSL96+c1GA8HpgCN23IsOdUDeDFZvFQYvwRb9YI4PYjA264N/y2EpWhcySB/f2q+Db5o JdxiPZ9PnkPYm5A9NWefHgcEsBeMrPYk+tkmWp5slzQUi0r4ATbOc4ikkXtPkb8h8woE 2wNrM/lxT6dC2EYEPomUMtNqIb5G+sPPL3Y0SytJ2IQe19NSOG5N5QsZcLpQ41E1iLhQ kAXg== X-Gm-Message-State: ABuFfogiGsecLS5j9lnEpdwcNOtJaGMW77anQOGU14vwHAe34fm/mfnw YQHH2IPNk6gDqqdSQGuyuYQlMNyShYndT4rE0Ew= X-Google-Smtp-Source: ACcGV61zos5QMjMg0uIkDTXpNpoe0Yzye5Kez9bNusOyW/wWUXWIoVxiqfaMjZAsR77Q+jeL5P3pxg1Q3oasgeGv6jU= X-Received: by 2002:a2e:48d:: with SMTP id a13-v6mr15761629ljf.27.1539040725237; Mon, 08 Oct 2018 16:18:45 -0700 (PDT) MIME-Version: 1.0 References: <5BB8EC23.1040303@gmx.at> <5BB9A4E5.3070308@gmx.at> <20181008.192544.1387561894315194511.tkk@misasa.okayama-u.ac.jp> In-Reply-To: <20181008.192544.1387561894315194511.tkk@misasa.okayama-u.ac.jp> From: Federico Tedin Date: Mon, 8 Oct 2018 20:18:31 -0300 Message-ID: Subject: Re: bug#31240: 26.1; mouse-save-then-kill does not kill rectangles To: tkk@misasa.okayama-u.ac.jp Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 31240 Cc: rudalics@gmx.at, homeros.misasa@gmail.com, charles@aurox.ch, 31240@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > (if region-noncontiguous > (let ((size (cons region-width region-height))) > (and (rectangle-intersect-p > (rectangle-position-as-coordinates start) size > (rectangle-position-as-coordinates point-to-paste) size) > (or (not (= (line-number-at-pos start) > (line-number-at-pos point-to-paste))) > (and (>= start point-to-paste) > (<= point-to-paste (+ start (car size)))))))) Martin, I didn't manage to understand the condition you are testing: (and (>= start point-to-paste) (<= point-to-paste (+ start (car size)))))))) If the first condition is true, the second will also be true (if point-to-paste is smaller than start, point-to-paste will also be smaller than start plus a positive integer). > Maybe undoing the operation is more conservative the way we do it now: > Currently, a first undo step would restore the original and a second > step would delete the copy. Otherwise, we would delete the copy first > and then restore the original which would leave us with no clue of > whatever the region contained after the first undo step. Kunihiro-san > could tell us more about this, maybe. > I appreciate mouse-drag-and-drop-region when I move a sentence because > the sentence never disappears from screen. Based on this criteria, > mouse-drag-and-drop-region inserts first and delete second. > Practically it is quick, thus order does not matter much. >From what I understand, these two explanations refer to the same thing: it is better to have at all times the dragged region somewhere in the buffer (even when undoing the drag operation). It would be best to keep this behaviour in future versions of mouse-drag-and-drop-region. > There are two cases for dragging a sentence, that are ones with (1) > deleting the original selection and (2) keeping it. Since to insert > is common for two cases, deletion of the original selection comes > later. If it works, order does not matter much. I also agree with this, it is tidier to leave the optional operation at the end. > OTOH if reverting the order yields good results when moving the text > to an intersecting but different line we could special-case the delete > first/copy afterwards behavior on region-noncontiguous. I'll check if I can come up with a better solution that best fits the points that have been discussed above. If I can't, I'll check how complex it would be to implement this special case at the end. From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 09 03:44:03 2018 Received: (at 31240) by debbugs.gnu.org; 9 Oct 2018 07:44:03 +0000 Received: from localhost ([127.0.0.1]:41130 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g9mgV-0000gs-4r for submit@debbugs.gnu.org; Tue, 09 Oct 2018 03:44:03 -0400 Received: from mout.gmx.net ([212.227.17.20]:58449) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g9mgT-0000gI-33 for 31240@debbugs.gnu.org; Tue, 09 Oct 2018 03:44:01 -0400 Received: from [192.168.1.101] ([46.125.250.96]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MV30j-1gB60G0NsD-00YUH9; Tue, 09 Oct 2018 09:43:41 +0200 Received: from [192.168.1.101] ([46.125.250.96]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MV30j-1gB60G0NsD-00YUH9; Tue, 09 Oct 2018 09:43:41 +0200 Message-ID: <5BBC5C25.8080002@gmx.at> Date: Tue, 09 Oct 2018 09:43:33 +0200 From: martin rudalics MIME-Version: 1.0 To: Federico Tedin , tkk@misasa.okayama-u.ac.jp Subject: Re: bug#31240: 26.1; mouse-save-then-kill does not kill rectangles References: <5BB8EC23.1040303@gmx.at> <5BB9A4E5.3070308@gmx.at> <20181008.192544.1387561894315194511.tkk@misasa.okayama-u.ac.jp> In-Reply-To: Content-Type: multipart/mixed; boundary="------------050904060507020309040905" X-Provags-ID: V03:K1:9i2Bnwv5OgABYN0liv4wpcrjmkdlr4FZuJs6Ep99afQPeY5SUal IgCPVJaSLeYZy/HEKm+WvF6Ob+b71TZhpsbE4KmrZ+2yM3z46kXp+MNNEqz0+xT/QfBfikD IshlM6BaLFSu1vDaX3ZGcDlgt3bjNXHyY81Txs2y2oqtgARLrcIbff9aDUZpUe+0lBd3jEG 6A1cyLrrnuWg0u/GWbZPw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V01:K0:fHWJogNEXOE=:Zzh+UvSS741Rf3HSvL64+D seCrYgY/jo5ttk10/87f4eN/Q/2S7MyeMr9o2ur4xbNtjOIxmWQiSZOuT66ie3SObtHRsKt96 7WuzFQPkgNd50pDD6+8ZXoLGHpiVDeIKLLHgoVAFvl0cih21PZNqfHCcDLvxSUIwKrOsXDJzh YHe4iiTnT4q5YwQJF8rTI/hlJb/jo6Pa982m5EgFR0ABXUEqM0rG3E3txDwarcTZJ3adGGZR6 pZ3LecTRyrA+Wo10CTYHB+2j+m8A77BfNHS+SIS6WG/KADTDN7U3Cbc6EV+ZvMnjAArwCU+Hq D6WOwEVu2wovTtpOn5uBJTEJ/+4uJGgl7rCAumjTZlddwX9wAHOeNo2O3ysX7TWLWYht8GxM8 natB/775dYIkOWof+FNPPyPfgHIsWVgLaXVn/m0BtiBzEJptVQU6/fkviycwI5s/07mf0apqG WoExO2OAzTZKLfQoE5iAlMcNaD6mCgimWP2bALhEvesQPnphC4ZzuPTQJ0iYV9F/6D66DS25q G0LTH7csHj75yxh/CCZEO9snWpCe165j62GNQ1EZpDCV6X3v5jYcJVJ1Dt9XKBMjiOj48kDpo xuG6+ihOPu22ZdZQ5h6zifXObYdJ72Rz61ChdgzQx8VJzVEGf7irOGc5qCBzVyxD1UAPm/0a2 a2GWqeXNB+VqHFcSSCjt4xvfzUx0o2mXGRlaFpjWCjRnxF8rX59bN1cR0hEA79gw70fhzMHVo QUEVIYKTI5xA5KMmxOaHKOnQBw+ODxOX6WBEKTEJJv7PNM18oT8ZKkZZKhoYfer2MWFcu3JLl FZX3I4cfplHjYrr4Yrimx4sS0cLHg== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 31240 Cc: 31240@debbugs.gnu.org, homeros.misasa@gmail.com, charles@aurox.ch X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is a multi-part message in MIME format. --------------050904060507020309040905 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit > Martin, I didn't manage to understand the condition you are testing: > > (and (>= start point-to-paste) > (<= point-to-paste (+ start (car size)))))))) Obviously so. It should be (and (<= start point-to-paste) (<= point-to-paste (+ start (car size)))))))) I attach a diff of this very chunk against the original trunk version I have here. Sorry for my sloppiness. The idea is to not set drag-but-negligible when point-to-paste is (1) on the first line of the original region and (2) before its start or after its end. To elaborate: If point-to-paste is on the first line of the original region in between its start and end, we would try to replace the text by itself on this and all subsequent lines which is just as silly as replacing a contiguous region with itself. So set drag-but-negligible in such a case. If point-to-paste is not on the first line of the original region but the region to insert intersects with the original region, then killing the original region after inserting the copy might get me some pretty unintelligible result. So set drag-but-negligible in that case as well. But moving the rectangle strictly to the left or the right on the same lines it originally occupied seems to work here. So I would not set drag-but-negligible in that case. > If the first condition is true, the second will also be true (if > point-to-paste is smaller than start, point-to-paste will also be > smaller than start plus a positive integer). Indeed. >>From what I understand, these two explanations refer to the same > thing: it is better to have at all times the dragged region somewhere > in the buffer (even when undoing the drag operation). It would be best > to keep this behaviour in future versions of > mouse-drag-and-drop-region. This looks like an invariant we could try to preserve. But I only tried to guess the rationale of the original design for moving a contiguous region. Note that I have never written or used rectangle code. AFAICT 'insert-rectangle' inserts spaces (via 'move-to-column') when the target line is too short. And these insertions can make the result of a rectangle move look bad when the deletion is done after the copying. Is that interpretation correct? Does it always look intelligible when the deletion is done before the copying? > I'll check if I can come up with a better solution that best fits the > points that have been discussed above. If I can't, I'll check how > complex it would be to implement this special case at the end. IIUC the code of rect.el nowhere provides an operation that kills a rectangle and reinserts it in one and the same step not to mention the possibility that these operations take place in an overlapping area of one and the same buffer. So I think that you are in uncharted waters here and hardly anyone will tell you what to do. If worse comes to worst, we can always leave your patch as it is now. martin --------------050904060507020309040905 Content-Type: text/plain; charset=windows-1252; name="mouse-drag-and-drop-region.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="mouse-drag-and-drop-region.diff" QEAgLTI1MDAsMTIgKzI1MjAsMjQgQEAgbW91c2UtZHJhZy1hbmQtZHJvcC1yZWdpb24KICAg ICAgICAgICAgIDs7IHRleHQgd2lsbCBiZSBpbnNlcnRlZCB0byBpbnNpZGUgb2YgdGhlIG9y aWdpbmFsCiAgICAgICAgICAgICA7OyByZWdpb24uCiAgICAgICAgICAgICAoc2V0cSBkcmFn LWJ1dC1uZWdsaWdpYmxlCi0gICAgICAgICAgICAgICAgICAoYW5kIChlcSAob3ZlcmxheS1i dWZmZXIgbW91c2UtZHJhZy1hbmQtZHJvcC1vdmVybGF5KQorICAgICAgICAgICAgICAgICAg KGFuZCAoZXEgKG92ZXJsYXktYnVmZmVyIChjYXIgbW91c2UtZHJhZy1hbmQtZHJvcC1vdmVy bGF5cykpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICBidWZmZXItdG8tcGFzdGUpCi0g ICAgICAgICAgICAgICAgICAgICAgICg8PSAob3ZlcmxheS1zdGFydCBtb3VzZS1kcmFnLWFu ZC1kcm9wLW92ZXJsYXkpCi0gICAgICAgICAgICAgICAgICAgICAgICAgIHBvaW50LXRvLXBh c3RlKQotICAgICAgICAgICAgICAgICAgICAgICAoPD0gcG9pbnQtdG8tcGFzdGUKLSAgICAg ICAgICAgICAgICAgICAgICAgICAgKG92ZXJsYXktZW5kIG1vdXNlLWRyYWctYW5kLWRyb3At b3ZlcmxheSkpKSkpCisgICAgICAgICAgICAgICAgICAgICAgIChpZiByZWdpb24tbm9uY29u dGlndW91cworICAgICAgICAgICAgICAgICAgICAgICAgICAgOzsgSWYgdGhlIHJlZ2lvbiBp cyByZWN0YW5ndWxhciwgY2hlY2sgaWYgdGhlIG5ld2x5IGluc2VydGVkCisgICAgICAgICAg ICAgICAgICAgICAgICAgICA7OyByZWN0YW5ndWxhciB0ZXh0IHdvdWxkIGludGVyc2VjdCB0 aGUgYWxyZWFkeSBzZWxlY3RlZAorICAgICAgICAgICAgICAgICAgICAgICAgICAgOzsgcmVn aW9uLiBJZiBpdCB3b3VsZCwgdGhlbiBzZXQgImRyYWctYnV0LW5lZ2xpZ2libGUiIHRvIHQu CisgICAgICAgICAgICAgICAgICAgICAgICAgICAobGV0ICgoc2l6ZSAoY29ucyByZWdpb24t d2lkdGggcmVnaW9uLWhlaWdodCkpKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAo YW5kIChyZWN0YW5nbGUtaW50ZXJzZWN0LXAKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgKHJlY3RhbmdsZS1wb3NpdGlvbi1hcy1jb29yZGluYXRlcyBzdGFydCkgc2l6 ZQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAocmVjdGFuZ2xlLXBvc2l0 aW9uLWFzLWNvb3JkaW5hdGVzIHBvaW50LXRvLXBhc3RlKSBzaXplKQorICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIChvciAobm90ICg9IChsaW5lLW51bWJlci1hdC1wb3Mg c3RhcnQpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg KGxpbmUtbnVtYmVyLWF0LXBvcyBwb2ludC10by1wYXN0ZSkpKQorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAoYW5kICg8PSBzdGFydCBwb2ludC10by1wYXN0ZSkK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoPD0gcG9pbnQt dG8tcGFzdGUgKCsgc3RhcnQgKGNhciBzaXplKSkpKSkpKQorICAgICAgICAgICAgICAgICAg ICAgICAgIChhbmQgKDw9IChvdmVybGF5LXN0YXJ0IChjYXIgbW91c2UtZHJhZy1hbmQtZHJv cC1vdmVybGF5cykpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcG9pbnQt dG8tcGFzdGUpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoPD0gcG9pbnQtdG8t cGFzdGUKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAob3ZlcmxheS1lbmQg KGNhciBtb3VzZS1kcmFnLWFuZC1kcm9wLW92ZXJsYXlzKSkpKSkpKSkKIAogICAgICAgICAg IDs7IFNob3cgYSB0b29sdGlwLgogICAgICAgICAgIChpZiBtb3VzZS1kcmFnLWFuZC1kcm9w LXJlZ2lvbi1zaG93LXRvb2x0aXAK --------------050904060507020309040905-- From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 10 02:20:24 2018 Received: (at 31240) by debbugs.gnu.org; 10 Oct 2018 06:20:24 +0000 Received: from localhost ([127.0.0.1]:42780 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gA7r5-0005cj-V3 for submit@debbugs.gnu.org; Wed, 10 Oct 2018 02:20:24 -0400 Received: from mout.gmx.net ([212.227.15.19]:40077) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gA7r4-0005cX-Ts for 31240@debbugs.gnu.org; Wed, 10 Oct 2018 02:20:23 -0400 Received: from [192.168.1.101] ([213.162.73.117]) by mail.gmx.com (mrgmx001 [212.227.17.190]) with ESMTPSA (Nemesis) id 0Le64S-1fKIyD1mrk-00pqTn; Wed, 10 Oct 2018 08:20:01 +0200 Received: from [192.168.1.101] ([213.162.73.117]) by mail.gmx.com (mrgmx001 [212.227.17.190]) with ESMTPSA (Nemesis) id 0Le64S-1fKIyD1mrk-00pqTn; Wed, 10 Oct 2018 08:20:01 +0200 Message-ID: <5BBD9A08.3090707@gmx.at> Date: Wed, 10 Oct 2018 08:19:52 +0200 From: martin rudalics MIME-Version: 1.0 To: Federico Tedin , tkk@misasa.okayama-u.ac.jp Subject: Re: bug#31240: 26.1; mouse-save-then-kill does not kill rectangles References: <5BB8EC23.1040303@gmx.at> <5BB9A4E5.3070308@gmx.at> <20181008.192544.1387561894315194511.tkk@misasa.okayama-u.ac.jp> <5BBC5C25.8080002@gmx.at> In-Reply-To: <5BBC5C25.8080002@gmx.at> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:oFGR8hWayg45IYnEuDXBdWjnJMHZFChoNcLH/ptRiJsrUIQk5IT 5axLT74CjO4TJbOSbM7hqh2qLfd6BWC/Dy2sxs7sdPvl7rMadXgJiAmica8JMnEuxtibYuR FZIg4x1sY26W3DTHeBC3oEYISrav65B7fUji0Mp2Ngq7HfUkk/obJzDktYvUsVPq/onK9pS BwdzZjunNgDXBQedOKYuA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V01:K0:UZFPcbLSUwI=:pxwtoGHGndBbpnczwOaBwl f8iTtySyKm4/ncGNwkm6zF1RbJh9psQS1sEz2K7KCDX8INxSFmsNNvuAKT3dmoLnfF3QVlbqk aIw4S7C8cr3ajznzCowEYDmD5eJmQSXD6xe4TQLBPUL1T/5g2n02CPoqBtADXxTUIsGMn3ZSZ uZprVhCXD2O7jWI14f/VrccuJffmTsGXaODBCrHdDLqVNM1eHrHWWn+xwxpANe2S5po7RBBpy 6mURpLC16e4OaUyAC8OIEDPAi1IYGyKU1bSptnaqA5qAyl6CG1y1tqTluCt472ekaALD9rVQ0 sYlrHpfO1sbRSV8iVpWXJYfo/zsybYtWLAA1pDLluoLGRP/84dxefj3iRoIf7Q20jOpY97dmg /RjP1iQ+PY2gVjY75VYinWg0Djzr92u798UsJDPSR83HuWnvSF/8SSeA2ju8vlKyA/w/C8RUm Aj0hNhxtk1kFqwB9NfPFQWdWbKDGEH6rerBiJ00mMgDf41Je3rOKcDHrbSSdErCmkh9DkIvbm 8YTe3KcYEtUFkTEfK3wKEe6XZgBn5NNMUdzZAyPrrrNLBVMDvBHh0cthwB7d9f5xwBEeCVE88 H1TGgZQRa91Dh/eLjgeAjOhTFPcdx915cSW9rwHhZLsMIWTqJlVQDaRZRQqToz358PdZ0mc2M 41ldUKCU8q4VUlWSIIcBXxKBXExOMck+8bf2cBXCkDjnggzVLAilbcPO+3fSmL3POSOib2Qe/ 6TvmqzKlJdkKj4mymUAlIcjEzrfllHmHnPKLN6eIOKG7SfnKsiD8rkrSprYePduYlBegaoW3L UK173/TmdMcBnv9bC2shit0sR4bGwFEvdd3WA336SeeLemaw5I= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 31240 Cc: 31240@debbugs.gnu.org, homeros.misasa@gmail.com, charles@aurox.ch X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > It should be > > (and (<= start point-to-paste) > (<= point-to-paste (+ start (car size)))))))) I forgot to mention that the second conjunct is probably superfluous here because in that case the rectangles won't intersect in the first place. So (<= start point-to-paste) should be sufficient but I have not tested it. martin From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 10 22:14:51 2018 Received: (at 31240) by debbugs.gnu.org; 11 Oct 2018 02:14:51 +0000 Received: from localhost ([127.0.0.1]:44028 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gAQV1-0006oR-Cx for submit@debbugs.gnu.org; Wed, 10 Oct 2018 22:14:51 -0400 Received: from mail-pf1-f176.google.com ([209.85.210.176]:46099) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gAQUy-0006o7-Uc for 31240@debbugs.gnu.org; Wed, 10 Oct 2018 22:14:49 -0400 Received: by mail-pf1-f176.google.com with SMTP id r64-v6so3556489pfb.13 for <31240@debbugs.gnu.org>; Wed, 10 Oct 2018 19:14:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=scK6VvfMWkgx5MKXKeb8LD3NamfQFiNk3vKhz0AmQOs=; b=rin3YjgaZYah+O+yeEQnzC01csNY9c1q0nE0PtNvyfYpMRIq2hG3JETQKAZCJJf2Bh T9bqLOJD9LJ8JR/1p7vv9gBCiXwlEW5B/FK3Wy/fza+5XYjDJzbxKpGMhWS8HheBsVon 8UfKv9uIU0zZt1iDQbRNlUyIsUTGceQsrBKCn3FCeDNdCLNBKatAGIuOpZdyErgMfKsc vWQh39IwxWLHxnDV0HOEncULv/R7BUAeskNWN6sgSQ4Y6XZnr+R/3SuHddGTxZQP2t5d C2tR7XcRi2gNblD47OB+LuvnHlcxEfmRBjkkX3pzB4haLAh1Q/gDJwWmyla/B/BQ9L83 XIeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=scK6VvfMWkgx5MKXKeb8LD3NamfQFiNk3vKhz0AmQOs=; b=HVLdMC/50sd/z9h38qNGvcBPrLhfcGKNvAjx4BRPxH0TT+StVt02aQLNfcey8Zj7Cc HiHpp4R8UhJmk0h+6fMwTDwhTCetMBerYf3yNh36wgVc0Sv97pttAD0AUJHB5ttQo9yT 8L2lZiciHrjfRxkJXFhE13KlO6T1SmvZxx7viTWvjq0jsxuf5eUjaYDvZWxDJsjcj91T 3yzl+seIH4wt+P4hdD+Oe42Gfq19cwrD3VOJ56w7GKif/kRnLzoZQGykpco/J4yg5CxI cFtw5mM72gcNc1ilY5u1AfAQRKUhR6e3byXBLSM1bTjB9TGklG5Zo7wgPAt5PgyvwCTm emPg== X-Gm-Message-State: ABuFfogNq65bEi/ImmaOZLGsrqOGqKvl5a2BW5Zhhc014veIUigY7cjr uv12eWxK9jnlEaOWAOpC4dU= X-Google-Smtp-Source: ACcGV61T7bA3YO8qx9l3FnVn9qqX+fWJJVYE/W2yolzvaEkLC+sbtLc8qOejWLds+5eubCEAxqfeHA== X-Received: by 2002:a63:d30c:: with SMTP id b12-v6mr31996937pgg.61.1539224083158; Wed, 10 Oct 2018 19:14:43 -0700 (PDT) Received: from thinkless2017 ([150.46.201.92]) by smtp.gmail.com with ESMTPSA id r22-v6sm65770157pfd.174.2018.10.10.19.14.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 10 Oct 2018 19:14:42 -0700 (PDT) From: Tak Kunihiro X-Google-Original-From: Tak Kunihiro To: martin rudalics Subject: Re: bug#31240: 26.1; mouse-save-then-kill does not kill rectangles References: <5BB8EC23.1040303@gmx.at> <5BB9A4E5.3070308@gmx.at> <20181008.192544.1387561894315194511.tkk@misasa.okayama-u.ac.jp> <5BBC5C25.8080002@gmx.at> Date: Thu, 11 Oct 2018 11:14:35 +0900 In-Reply-To: <5BBC5C25.8080002@gmx.at> (martin rudalics's message of "Tue, 09 Oct 2018 09:43:33 +0200") Message-ID: <861s8x5iwk.fsf@misasa.okayama-u.ac.jp> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (windows-nt) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31240 Cc: 31240@debbugs.gnu.org, tkk@misasa.okayama-u.ac.jp, charles@aurox.ch, Federico Tedin X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > I attach a diff of this very chunk against the original trunk version > I have here. I confirmed that I can move the rectangle to the left horizontally. From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 11 20:43:17 2018 Received: (at 31240) by debbugs.gnu.org; 12 Oct 2018 00:43:17 +0000 Received: from localhost ([127.0.0.1]:45746 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gAlXw-0001YZ-GZ for submit@debbugs.gnu.org; Thu, 11 Oct 2018 20:43:17 -0400 Received: from mail-lf1-f66.google.com ([209.85.167.66]:35809) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gAlXu-0001YJ-3c for 31240@debbugs.gnu.org; Thu, 11 Oct 2018 20:43:14 -0400 Received: by mail-lf1-f66.google.com with SMTP id r191-v6so8096559lff.2 for <31240@debbugs.gnu.org>; Thu, 11 Oct 2018 17:43:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=v08D27DNZIty5XLj8pjIZDiPcmOA679IaR7osNT5u+4=; b=EIDlb+UXww/e5DZ4cxYlAISbBMCZ5sZSDky9wHY6UAi5DDtaoPMte/qEhXmE6iobOL r08kLQ/fg/RhoLfXxghuDREXGFguc30pVQWWTpngE5/Hd+SbMZeeCsgfFt2jE+nlRmbe WQ0/U75e2RGmY7ARcq9On6pBy96a4xvFqozIB7Vm052rMklKAo69VjkyIaFJciJwLmDv xFME77e+UQo6vOOFQTX3FzbdCwDfO6AmOjKdrEOh5s0yv4a6Wo3xVvfFKmPHFnw4Gz/6 EZupzNg4YqZeXsdKjlEKZWj4BCoQeNrEm/iBEwHdLAsDurh7N86+gdxeMBwlKdM6cAkh JSPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=v08D27DNZIty5XLj8pjIZDiPcmOA679IaR7osNT5u+4=; b=k8LhFJkM61atz9jiZRD95/BVngCxln5G2jo7nQSAf6jPE4gGZCgj/sdX4XXBXba/ky sZSkl4A6bFYdfxiLqysksXQWgZIyU9d994zq4Rp8Oy13Uj10rmMTYY4H/l9iuh6Fzrwy v3WkXn4F+ZBiVryTb9Ihi+JSzqBQSfWGBC0QRf6ElY9SkZSeSax8PItVq5dQMoCZhvlO 5ac0FBP7a5IyCljvRLVmDRGQTBtVa7MAZi29Kw+N+wonoXGt7QW5l71IypegPPY0AaRV SDTSuS63250lG7fhhE+/9NlcsRAg0UYqxjIYCoS4FbxWYtxRrdyOHiSm43njQT6qkwjJ kXkA== X-Gm-Message-State: ABuFfojLbe1yKL8gIsjyTgZluvpwn+OTsuLLH9MuqVbVyuY7szjhuPFF tLchzkzLuZhp0aSQQsmdmWSdnJ8XQTJYUhRf/SA= X-Google-Smtp-Source: ACcGV62LrgwoGP/M4I5/2vHTA3Gi0fmEoNM1cx5RhjViPqJ+gC8uii5UdrNBDxejbgbqLtH1oVhBUhQr8X+EQVG/2vc= X-Received: by 2002:a19:1447:: with SMTP id k68-v6mr2334252lfi.4.1539304987892; Thu, 11 Oct 2018 17:43:07 -0700 (PDT) MIME-Version: 1.0 References: <5BB8EC23.1040303@gmx.at> <5BB9A4E5.3070308@gmx.at> <20181008.192544.1387561894315194511.tkk@misasa.okayama-u.ac.jp> <5BBC5C25.8080002@gmx.at> <5BBD9A08.3090707@gmx.at> In-Reply-To: <5BBD9A08.3090707@gmx.at> From: Federico Tedin Date: Thu, 11 Oct 2018 21:42:54 -0300 Message-ID: Subject: Re: bug#31240: 26.1; mouse-save-then-kill does not kill rectangles To: rudalics@gmx.at Content-Type: multipart/mixed; boundary="00000000000001d0290577fd5f81" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 31240 Cc: 31240@debbugs.gnu.org, homeros.misasa@gmail.com, tkk@misasa.okayama-u.ac.jp, charles@aurox.ch X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000001d0290577fd5f81 Content-Type: text/plain; charset="UTF-8" > If point-to-paste is on the first line of the original region in > between its start and end, we would try to replace the text by itself > on this and all subsequent lines which is just as silly as replacing a > contiguous region with itself. So set drag-but-negligible in such a > case. > > If point-to-paste is not on the first line of the original region but > the region to insert intersects with the original region, then killing > the original region after inserting the copy might get me some pretty > unintelligible result. So set drag-but-negligible in that case as > well. > > But moving the rectangle strictly to the left or the right on the same > lines it originally occupied seems to work here. So I would not set > drag-but-negligible in that case. > > I forgot to mention that the second conjunct is probably superfluous > here because in that case the rectangles won't intersect in the first > place. So (<= start point-to-paste) should be sufficient but I have > not tested it. Martin, thanks again for your feedback. As you mentioned, dragging the rectangle to the right of its right edge will cause rectangle-intersect-p return nil, so that check will never be evaluated. If I drag the rectangle to the right, but in a way that it intersects with itself (e.g. one char), then its contents would be inserted into the overlays, and it would then be deleted when the original is deleted (this is why I originally added the intersection check). If I drag the rectangle to the left in a way it would intersect with itself, then obviously rectangle-intersect-p will return t. However, what's interesting about this case is that the insert and delete operations could be done anyways, as the new content would be inserted to the left of the overlays, causing them to shift to the right. Then, the overlays would be deleted, taking with them the original rectangle. Note that this works even if the drag has a vertical component (up/down). So then: moving the rectangle to the left is easy, but moving it to the right (into itself) is not. My solution was to implement rectangle-intersection-p to avoid doing the insert and delete if an intersection was found. One of the conditions you added on your patch allows moving the rectangle sideways: in my opinion, allowing the user to move the rectangle only to the left is what's more consistent with mouse-drag-and-drop-region's behaviour with non-rectangular regions. You can check this by selecting a word and dragging it one char to its left: the word is dragged correctly. But if you drag a word one char to the right, the operation is marked as negligible. It would make sense that moving a rectangle to the right or to the left followed the same behaviour. > Note that I have never written or used rectangle code. AFAICT > 'insert-rectangle' inserts spaces (via 'move-to-column') when the > target line is too short. And these insertions can make the result of > a rectangle move look bad when the deletion is done after the copying. > Is that interpretation correct? Does it always look intelligible when > the deletion is done before the copying? Your guess is probably much better than mine, but I think you're right. Inserting a rectangle somewhere in a buffer, and then deleting some text to its left will make it look intelligible. If the deletion is made before the copying, however, I think the rectangle will always be inserted correctly (because move-to-column will ensure its content is aligned correctly). > IIUC the code of rect.el nowhere provides an operation that kills a > rectangle and reinserts it in one and the same step not to mention the > possibility that these operations take place in an overlapping area of > one and the same buffer. So I think that you are in uncharted waters > here and hardly anyone will tell you what to do. > > If worse comes to worst, we can always leave your patch as it is now. At the moment, my current proposal is: allow the user to drag the rectangle anywhere to the left (on the same line, or on a different line), or anywhere else where it would not intersect with itself (I'm attaching a new patch that allows this). - Federico --00000000000001d0290577fd5f81 Content-Type: text/x-patch; charset="US-ASCII"; name="mouse.patch" Content-Disposition: attachment; filename="mouse.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jn5abgms0 RnJvbSA1ODg4Y2U5NzM5YzMyOThhNWYxOTM5YWNmYWY4NzE1OGMxMDIzZmQ5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBGZWRlcmljbyBUZWRpbiA8ZmVkZXJpY290ZWRpbkBnbWFpbC5j b20+CkRhdGU6IFRodSwgMTEgT2N0IDIwMTggMjE6Mjk6NDUgLTAzMDAKU3ViamVjdDogW1BBVENI XSBBbGxvdyB0d28gbW91c2UgZnVuY3Rpb25zIHRvIHdvcmsgd2l0aCBSZWN0YW5nbGUgTWFyayBt b2RlCgoqIGxpc3AvbW91c2UuZWwgKG1vdXNlLXNhdmUtdGhlbi1raWxsKTogTWFrZSBtb3VzZS1z YXZlLXRoZW4ta2lsbCB3b3JrCiAgd2l0aCByZWN0YW5ndWxhciByZWdpb25zLCBpbmNsdWRpbmcg d2hlbiBtb3VzZS1kcmFnLWNvcHktcmVnaW9uIGlzCiAgc2V0IHRvIHQuIChCdWcjMzEyNDApCiAg KG1vdXNlLWRyYWctYW5kLWRyb3AtcmVnaW9uKTogQWxsb3cgZHJhZ2dpbmcgYW5kIGRyb3BwaW5n CiAgcmVjdGFuZ3VsYXIgcmVnaW9ucy4gKEJ1ZyMzMTI0MCkKKiByZWN0LmVsIChyZWN0YW5nbGUt aW50ZXJzZWN0LXApOiBBZGQgYSBuZXcgZnVuY3Rpb24uCiAgKHJlY3RhbmdsZS1wb3NpdGlvbi1h cy1jb29yZGluYXRlcyk6IEFkZCBhIG5ldyBmdW5jdGlvbi4KLS0tCiBsaXNwL21vdXNlLmVsIHwg OTkgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tCiBs aXNwL3JlY3QuZWwgIHwgMzEgKysrKysrKysrKysrKysrKwogMiBmaWxlcyBjaGFuZ2VkLCAxMDQg aW5zZXJ0aW9ucygrKSwgMjYgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9tb3VzZS5l bCBiL2xpc3AvbW91c2UuZWwKaW5kZXggY2I2M2NhNTFjNS4uMzdmNDA4N2U1ZiAxMDA2NDQKLS0t IGEvbGlzcC9tb3VzZS5lbAorKysgYi9saXNwL21vdXNlLmVsCkBAIC0yOSw2ICsyOSw4IEBACiAK IDs7OyBDb2RlOgogCisoZXZhbC13aGVuLWNvbXBpbGUgKHJlcXVpcmUgJ3JlY3QpKQorCiA7Ozsg VXRpbGl0eSBmdW5jdGlvbnMuCiAKIDs7IEluZGVudCB0cmFjay1tb3VzZSBsaWtlIHByb2duLgpA QCAtMTYwNiw4ICsxNjA4LDggQEAgbW91c2Utc2F2ZS10aGVuLWtpbGwKICAgICAgIChpZiBtb3Vz ZS1kcmFnLWNvcHktcmVnaW9uCiAgICAgICAgICAgOzsgUmVnaW9uIGFscmVhZHkgc2F2ZWQgaW4g dGhlIHByZXZpb3VzIGNsaWNrOwogICAgICAgICAgIDs7IGRvbid0IG1ha2UgYSBkdXBsaWNhdGUg ZW50cnksIGp1c3QgZGVsZXRlLgotICAgICAgICAgIChkZWxldGUtcmVnaW9uIChtYXJrIHQpIChw b2ludCkpCi0gICAgICAgIChraWxsLXJlZ2lvbiAobWFyayB0KSAocG9pbnQpKSkKKyAgICAgICAg ICAoZnVuY2FsbCByZWdpb24tZXh0cmFjdC1mdW5jdGlvbiAnZGVsZXRlLW9ubHkpCisgICAgICAg IChraWxsLXJlZ2lvbiAobWFyayB0KSAocG9pbnQpICdyZWdpb24pKQogICAgICAgKHNldHEgbW91 c2Utc2VsZWN0aW9uLWNsaWNrLWNvdW50IDApCiAgICAgICAoc2V0cSBtb3VzZS1zYXZlLXRoZW4t a2lsbC1wb3NuIG5pbCkpCiAKQEAgLTE2MzIsNyArMTYzNCw3IEBAIG1vdXNlLXNhdmUtdGhlbi1r aWxsCiAJKG1vdXNlLXNldC1yZWdpb24tMSkKICAgICAgICAgKHdoZW4gbW91c2UtZHJhZy1jb3B5 LXJlZ2lvbgogICAgICAgICAgIDs7IFJlZ2lvbiBhbHJlYWR5IGNvcGllZCB0byBraWxsLXJpbmcg b25jZSwgc28gcmVwbGFjZS4KLSAgICAgICAgICAoa2lsbC1uZXcgKGZpbHRlci1idWZmZXItc3Vi c3RyaW5nIChtYXJrIHQpIChwb2ludCkpIHQpKQorICAgICAgICAgIChraWxsLW5ldyAoZnVuY2Fs bCByZWdpb24tZXh0cmFjdC1mdW5jdGlvbiBuaWwpIHQpKQogCTs7IEFycmFuZ2UgZm9yIGEgcmVw ZWF0ZWQgbW91c2UtMyB0byBraWxsIHRoZSByZWdpb24uCiAJKHNldHEgbW91c2Utc2F2ZS10aGVu LWtpbGwtcG9zbiBjbGljay1wdCkpKQogCkBAIC0yNDExLDcgKzI0MTMsMTUgQEAgbW91c2UtZHJh Zy1hbmQtZHJvcC1yZWdpb24KICAgICAgICAgIChidWZmZXIgKGN1cnJlbnQtYnVmZmVyKSkKICAg ICAgICAgICh3aW5kb3cgKHNlbGVjdGVkLXdpbmRvdykpCiAgICAgICAgICAodGV4dC1mcm9tLXJl YWQtb25seSBidWZmZXItcmVhZC1vbmx5KQotICAgICAgICAgKG1vdXNlLWRyYWctYW5kLWRyb3At b3ZlcmxheSAobWFrZS1vdmVybGF5IHN0YXJ0IGVuZCkpCisgICAgICAgICA7OyBVc2UgbXVsdGlw bGUgb3ZlcmxheXMgdG8gY292ZXIgY2FzZXMgd2hlcmUgdGhlIHJlZ2lvbiBpcyByZWN0YW5ndWxh ci4KKyAgICAgICAgIChtb3VzZS1kcmFnLWFuZC1kcm9wLW92ZXJsYXlzIChtYXBjYXIgKGxhbWJk YSAoYm91bmRzKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIChtYWtlLW92ZXJsYXkgKGNhciBib3VuZHMpCisgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoY2RyIGJvdW5kcykpKQorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAocmVnaW9uLWJvdW5k cykpKQorICAgICAgICAgKHJlZ2lvbi1ub25jb250aWd1b3VzIChyZWdpb24tbm9uY29udGlndW91 cy1wKSkKKyAgICAgICAgIChyZWdpb24td2lkdGggKC0gKG92ZXJsYXktZW5kIChjYXIgbW91c2Ut ZHJhZy1hbmQtZHJvcC1vdmVybGF5cykpCisgICAgICAgICAgICAgICAgICAgICAgICAgIChvdmVy bGF5LXN0YXJ0IChjYXIgbW91c2UtZHJhZy1hbmQtZHJvcC1vdmVybGF5cykpKSkKKyAgICAgICAg IChyZWdpb24taGVpZ2h0IChsZW5ndGggbW91c2UtZHJhZy1hbmQtZHJvcC1vdmVybGF5cykpCiAg ICAgICAgICBwb2ludC10by1wYXN0ZQogICAgICAgICAgcG9pbnQtdG8tcGFzdGUtcmVhZC1vbmx5 CiAgICAgICAgICB3aW5kb3ctdG8tcGFzdGUKQEAgLTI0NTUsNyArMjQ2NSwxMSBAQCBtb3VzZS1k cmFnLWFuZC1kcm9wLXJlZ2lvbgogICAgICAgICAgIDs7IE9idGFpbiB0aGUgZHJhZ2dlZCB0ZXh0 IGluIHJlZ2lvbi4gIFdoZW4gdGhlIGxvb3Agd2FzCiAgICAgICAgICAgOzsgc2tpcHBlZCwgdmFs dWUtc2VsZWN0aW9uIHJlbWFpbnMgbmlsLgogICAgICAgICAgICh1bmxlc3MgdmFsdWUtc2VsZWN0 aW9uCi0gICAgICAgICAgICAoc2V0cSB2YWx1ZS1zZWxlY3Rpb24gKGJ1ZmZlci1zdWJzdHJpbmcg c3RhcnQgZW5kKSkKKyAgICAgICAgICAgIChzZXRxIHZhbHVlLXNlbGVjdGlvbiAoZnVuY2FsbCBy ZWdpb24tZXh0cmFjdC1mdW5jdGlvbiBuaWwpKQorICAgICAgICAgICAgOzsgUmVtb3ZlIHlhbmst aGFuZGxlciBwcm9wZXJ0eSBpbiBvcmRlciB0byByZS1pbnNlcnQgdGV4dCB1c2luZworICAgICAg ICAgICAgOzsgdGhlIGBpbnNlcnQtcmVjdGFuZ2xlJyBmdW5jdGlvbiBsYXRlciBvbi4KKyAgICAg ICAgICAgIChyZW1vdmUtdGV4dC1wcm9wZXJ0aWVzIDAgKGxlbmd0aCB2YWx1ZS1zZWxlY3Rpb24p CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnKHlhbmstaGFuZGxlcikgdmFs dWUtc2VsZWN0aW9uKQogICAgICAgICAgICAgKHdoZW4gbW91c2UtZHJhZy1hbmQtZHJvcC1yZWdp b24tc2hvdy10b29sdGlwCiAgICAgICAgICAgICAgIChsZXQgKCh0ZXh0LXNpemUgbW91c2UtZHJh Zy1hbmQtZHJvcC1yZWdpb24tc2hvdy10b29sdGlwKSkKICAgICAgICAgICAgICAgICAoc2V0cSB0 ZXh0LXRvb2x0aXAKQEAgLTI0NjgsMTIgKzI0ODIsMTggQEAgbW91c2UtZHJhZy1hbmQtZHJvcC1y ZWdpb24KICAgICAgICAgICAgICAgICAgICAgICAgIHZhbHVlLXNlbGVjdGlvbikpKSkKIAogICAg ICAgICAgICAgOzsgQ2hlY2sgaWYgc2VsZWN0ZWQgdGV4dCBpcyByZWFkLW9ubHkuCi0gICAgICAg ICAgICAoc2V0cSB0ZXh0LWZyb20tcmVhZC1vbmx5IChvciB0ZXh0LWZyb20tcmVhZC1vbmx5Ci0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoZ2V0LXRleHQtcHJvcGVy dHkgc3RhcnQgJ3JlYWQtb25seSkKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIChub3QgKGVxdWFsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAobmV4dC1zaW5nbGUtY2hhci1wcm9wZXJ0eS1jaGFuZ2UKLSAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzdGFydCAncmVhZC1vbmx5IG5p bCBlbmQpCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBl bmQpKSkpKQorICAgICAgICAgICAgKHNldHEgdGV4dC1mcm9tLXJlYWQtb25seQorICAgICAgICAg ICAgICAgICAgKG9yIHRleHQtZnJvbS1yZWFkLW9ubHkKKyAgICAgICAgICAgICAgICAgICAgICAo Z2V0LXRleHQtcHJvcGVydHkgc3RhcnQgJ3JlYWQtb25seSkKKyAgICAgICAgICAgICAgICAgICAg ICAoZ2V0LXRleHQtcHJvcGVydHkgZW5kICdyZWFkLW9ubHkpCisgICAgICAgICAgICAgICAgICAg ICAgKGNhdGNoICdsb29wCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChkb2xpc3QgKGJv dW5kIChyZWdpb24tYm91bmRzKSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAodW5s ZXNzIChlcXVhbAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChuZXh0 LXNpbmdsZS1jaGFyLXByb3BlcnR5LWNoYW5nZQorICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAoY2FyIGJvdW5kKSAncmVhZC1vbmx5IG5pbCAoY2RyIGJvdW5kKSkKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoY2RyIGJvdW5kKSkKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICh0aHJvdyAnbG9vcCB0KSkpKSkpKQorCiAgICAg ICAgICAgKHNldHEgd2luZG93LXRvLXBhc3RlIChwb3NuLXdpbmRvdyAoZXZlbnQtZW5kIGV2ZW50 KSkpCiAgICAgICAgICAgKHNldHEgcG9pbnQtdG8tcGFzdGUgKHBvc24tcG9pbnQgKGV2ZW50LWVu ZCBldmVudCkpKQogICAgICAgICAgIDs7IFNldCBuaWwgd2hlbiB0YXJnZXQgYnVmZmVyIGlzIG1p bmlidWZmZXIuCkBAIC0yNTAwLDEyICsyNTIwLDI3IEBAIG1vdXNlLWRyYWctYW5kLWRyb3AtcmVn aW9uCiAgICAgICAgICAgICA7OyB0ZXh0IHdpbGwgYmUgaW5zZXJ0ZWQgdG8gaW5zaWRlIG9mIHRo ZSBvcmlnaW5hbAogICAgICAgICAgICAgOzsgcmVnaW9uLgogICAgICAgICAgICAgKHNldHEgZHJh Zy1idXQtbmVnbGlnaWJsZQotICAgICAgICAgICAgICAgICAgKGFuZCAoZXEgKG92ZXJsYXktYnVm ZmVyIG1vdXNlLWRyYWctYW5kLWRyb3Atb3ZlcmxheSkKKyAgICAgICAgICAgICAgICAgIChhbmQg KGVxIChvdmVybGF5LWJ1ZmZlciAoY2FyIG1vdXNlLWRyYWctYW5kLWRyb3Atb3ZlcmxheXMpKQog ICAgICAgICAgICAgICAgICAgICAgICAgICAgYnVmZmVyLXRvLXBhc3RlKQotICAgICAgICAgICAg ICAgICAgICAgICAoPD0gKG92ZXJsYXktc3RhcnQgbW91c2UtZHJhZy1hbmQtZHJvcC1vdmVybGF5 KQotICAgICAgICAgICAgICAgICAgICAgICAgICBwb2ludC10by1wYXN0ZSkKLSAgICAgICAgICAg ICAgICAgICAgICAgKDw9IHBvaW50LXRvLXBhc3RlCi0gICAgICAgICAgICAgICAgICAgICAgICAg IChvdmVybGF5LWVuZCBtb3VzZS1kcmFnLWFuZC1kcm9wLW92ZXJsYXkpKSkpKQorICAgICAgICAg ICAgICAgICAgICAgICAoaWYgcmVnaW9uLW5vbmNvbnRpZ3VvdXMKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgIDs7IElmIHRoZSByZWdpb24gaXMgcmVjdGFuZ3VsYXIsIGNoZWNrIGlmIHRoZSBu ZXdseSBpbnNlcnRlZAorICAgICAgICAgICAgICAgICAgICAgICAgICAgOzsgcmVjdGFuZ3VsYXIg dGV4dCB3b3VsZCBpbnRlcnNlY3QgdGhlIGFscmVhZHkgc2VsZWN0ZWQKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgIDs7IHJlZ2lvbi4gSWYgaXQgd291bGQsIHRoZW4gc2V0ICJkcmFnLWJ1dC1u ZWdsaWdpYmxlIiB0byB0LgorICAgICAgICAgICAgICAgICAgICAgICAgICAgOzsgQXMgYSBzcGVj aWFsIGNhc2UsIGFsbG93IGRyYWdnaW5nIHRoZSByZWdpb24gZnJlZWx5IGFueXdoZXJlCisgICAg ICAgICAgICAgICAgICAgICAgICAgICA7OyB0byB0aGUgbGVmdCwgYXMgdGhpcyB3aWxsIG5ldmVy IHRyaWdnZXIgaXRzIGNvbnRlbnRzIHRvIGJlCisgICAgICAgICAgICAgICAgICAgICAgICAgICA7 OyBpbnNlcnRlZCBpbnRvIHRoZSBvdmVybGF5cyB0cmFja2luZyBpdC4KKyAgICAgICAgICAgICAg ICAgICAgICAgICAgIChsZXQgKChzaXplIChjb25zIHJlZ2lvbi13aWR0aCByZWdpb24taGVpZ2h0 KSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChzdGFydC1jb29yZGluYXRlcyAo cmVjdGFuZ2xlLXBvc2l0aW9uLWFzLWNvb3JkaW5hdGVzIHN0YXJ0KSkKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIChwb2ludC10by1wYXN0ZS1jb29yZGluYXRlcyAocmVjdGFuZ2xl LXBvc2l0aW9uLWFzLWNvb3JkaW5hdGVzIHBvaW50LXRvLXBhc3RlKSkpCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIChhbmQgKHJlY3RhbmdsZS1pbnRlcnNlY3QtcAorICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBzdGFydC1jb29yZGluYXRlcyBzaXplCisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIHBvaW50LXRvLXBhc3RlLWNvb3JkaW5hdGVzIHNpemUp CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKG5vdCAoPD0gKGNhciBwb2ludC10 by1wYXN0ZS1jb29yZGluYXRlcykKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAoY2FyIHN0YXJ0LWNvb3JkaW5hdGVzKSkpKSkKKyAgICAgICAgICAgICAgICAgICAg ICAgICAoYW5kICg8PSAob3ZlcmxheS1zdGFydCAoY2FyIG1vdXNlLWRyYWctYW5kLWRyb3Atb3Zl cmxheXMpKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBvaW50LXRvLXBhc3Rl KQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKDw9IHBvaW50LXRvLXBhc3RlCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKG92ZXJsYXktZW5kIChjYXIgbW91c2UtZHJh Zy1hbmQtZHJvcC1vdmVybGF5cykpKSkpKSkpCiAKICAgICAgICAgICA7OyBTaG93IGEgdG9vbHRp cC4KICAgICAgICAgICAoaWYgbW91c2UtZHJhZy1hbmQtZHJvcC1yZWdpb24tc2hvdy10b29sdGlw CkBAIC0yNTI0LDggKzI1NTksOSBAQCBtb3VzZS1kcmFnLWFuZC1kcm9wLXJlZ2lvbgogICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICh0CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICdiYXIpKSkKICAgICAgICAgICAgICh3aGVuIGN1cnNvci1pbi10ZXh0LWFyZWEKLSAgICAg ICAgICAgICAgKG92ZXJsYXktcHV0IG1vdXNlLWRyYWctYW5kLWRyb3Atb3ZlcmxheQotICAgICAg ICAgICAgICAgICAgICAgICAgICAgJ2ZhY2UgJ21vdXNlLWRyYWctYW5kLWRyb3AtcmVnaW9uKQor ICAgICAgICAgICAgICAoZG9saXN0IChvdmVybGF5IG1vdXNlLWRyYWctYW5kLWRyb3Atb3Zlcmxh eXMpCisgICAgICAgICAgICAgICAgKG92ZXJsYXktcHV0IG92ZXJsYXkKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICdmYWNlICdtb3VzZS1kcmFnLWFuZC1kcm9wLXJlZ2lvbikpCiAgICAgICAg ICAgICAgIChkZWFjdGl2YXRlLW1hcmspICAgICA7IE1haW50YWluIHJlZ2lvbiBpbiBvdGhlciB3 aW5kb3cuCiAgICAgICAgICAgICAgIChtb3VzZS1zZXQtcG9pbnQgZXZlbnQpKSkpKQogCkBAIC0y NTgxLDcgKzI2MTcsOSBAQCBtb3VzZS1kcmFnLWFuZC1kcm9wLXJlZ2lvbgogICAgICAgICAgIChz ZWxlY3Qtd2luZG93IHdpbmRvdykKICAgICAgICAgICAoZ290by1jaGFyIHBvaW50KQogICAgICAg ICAgIChzZXRxIGRlYWN0aXZhdGUtbWFyayBuaWwpCi0gICAgICAgICAgKGFjdGl2YXRlLW1hcmsp KQorICAgICAgICAgIChhY3RpdmF0ZS1tYXJrKQorICAgICAgICAgICh3aGVuIHJlZ2lvbi1ub25j b250aWd1b3VzCisgICAgICAgICAgICAocmVjdGFuZ2xlLW1hcmstbW9kZSkpKQogICAgICAgICAg OzsgTW9kaWZ5IGJ1ZmZlcnMuCiAgICAgICAgICAodAogICAgICAgICAgIDs7ICogREVTVElOQVRJ T04gQlVGRkVSOjoKQEAgLTI1OTAsMTEgKzI2MjgsMTcgQEAgbW91c2UtZHJhZy1hbmQtZHJvcC1y ZWdpb24KICAgICAgICAgICAoc2V0cSB3aW5kb3ctZXhlbXB0IHdpbmRvdy10by1wYXN0ZSkKICAg ICAgICAgICAoZ290by1jaGFyIHBvaW50LXRvLXBhc3RlKQogICAgICAgICAgIChwdXNoLW1hcmsp Ci0gICAgICAgICAgKGluc2VydCB2YWx1ZS1zZWxlY3Rpb24pCisKKyAgICAgICAgICAoaWYgcmVn aW9uLW5vbmNvbnRpZ3VvdXMKKyAgICAgICAgICAgICAgKGluc2VydC1yZWN0YW5nbGUgKHNwbGl0 LXN0cmluZyB2YWx1ZS1zZWxlY3Rpb24gIlxuIikpCisgICAgICAgICAgICAoaW5zZXJ0IHZhbHVl LXNlbGVjdGlvbikpCisKICAgICAgICAgICA7OyBPbiBzdWNjZXNzLCBzZXQgdGhlIHRleHQgYXMg cmVnaW9uIG9uIGRlc3RpbmF0aW9uIGJ1ZmZlci4KICAgICAgICAgICAod2hlbiAobm90IChlcXVh bCAobWFyaykgKHBvaW50KSkpCiAgICAgICAgICAgICAoc2V0cSBkZWFjdGl2YXRlLW1hcmsgbmls KQotICAgICAgICAgICAgKGFjdGl2YXRlLW1hcmspKQorICAgICAgICAgICAgKGFjdGl2YXRlLW1h cmspCisgICAgICAgICAgICAod2hlbiByZWdpb24tbm9uY29udGlndW91cworICAgICAgICAgICAg ICAocmVjdGFuZ2xlLW1hcmstbW9kZSkpKQogCiAgICAgICAgICAgOzsgKiBTT1VSQ0UgQlVGRkVS OjoKICAgICAgICAgICA7OyBTZXQgYmFjayB0aGUgb3JpZ2luYWwgdGV4dCBhcyByZWdpb24gb3Ig ZGVsZXRlIHRoZSBvcmlnaW5hbApAQCAtMjYwNCw4ICsyNjQ4LDkgQEAgbW91c2UtZHJhZy1hbmQt ZHJvcC1yZWdpb24KICAgICAgICAgICAgICAgOzsgcmVtb3ZlIHRoZSBvcmlnaW5hbCB0ZXh0Lgog ICAgICAgICAgICAgICAod2hlbiBuby1tb2RpZmllci1vbi1kcm9wCiAgICAgICAgICAgICAgICAg KGxldCAoZGVhY3RpdmF0ZS1tYXJrKQotICAgICAgICAgICAgICAgICAgKGRlbGV0ZS1yZWdpb24g KG92ZXJsYXktc3RhcnQgbW91c2UtZHJhZy1hbmQtZHJvcC1vdmVybGF5KQotICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgKG92ZXJsYXktZW5kIG1vdXNlLWRyYWctYW5kLWRyb3Atb3Zl cmxheSkpKSkKKyAgICAgICAgICAgICAgICAgIChkb2xpc3QgKG92ZXJsYXkgbW91c2UtZHJhZy1h bmQtZHJvcC1vdmVybGF5cykKKyAgICAgICAgICAgICAgICAgICAgKGRlbGV0ZS1yZWdpb24gKG92 ZXJsYXktc3RhcnQgb3ZlcmxheSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg KG92ZXJsYXktZW5kIG92ZXJsYXkpKSkpKQogICAgICAgICAgICAgOzsgV2hlbiBzb3VyY2UgYnVm ZmVyIGFuZCBkZXN0aW5hdGlvbiBidWZmZXIgYXJlIGRpZmZlcmVudCwKICAgICAgICAgICAgIDs7 IGtlZXAgKHNldCBiYWNrIHRoZSBvcmlnaW5hbCB0ZXh0IGFzIHJlZ2lvbikgb3IgcmVtb3ZlIHRo ZQogICAgICAgICAgICAgOzsgb3JpZ2luYWwgdGV4dC4KQEAgLTI2MTUsMTUgKzI2NjAsMTcgQEAg bW91c2UtZHJhZy1hbmQtZHJvcC1yZWdpb24KICAgICAgICAgICAgIChpZiBtb3VzZS1kcmFnLWFu ZC1kcm9wLXJlZ2lvbi1jdXQtd2hlbi1idWZmZXJzLWRpZmZlcgogICAgICAgICAgICAgICAgIDs7 IFJlbW92ZSB0aGUgZHJhZ2dlZCB0ZXh0IGZyb20gc291cmNlIGJ1ZmZlciBsaWtlCiAgICAgICAg ICAgICAgICAgOzsgb3BlcmF0aW9uIGBjdXQnLgotICAgICAgICAgICAgICAgIChkZWxldGUtcmVn aW9uIChvdmVybGF5LXN0YXJ0IG1vdXNlLWRyYWctYW5kLWRyb3Atb3ZlcmxheSkKLSAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAob3ZlcmxheS1lbmQgbW91c2UtZHJhZy1hbmQtZHJvcC1v dmVybGF5KSkKKyAgICAgICAgICAgICAgICAoZG9saXN0IChvdmVybGF5IG1vdXNlLWRyYWctYW5k LWRyb3Atb3ZlcmxheXMpCisgICAgICAgICAgICAgICAgICAgIChkZWxldGUtcmVnaW9uIChvdmVy bGF5LXN0YXJ0IG92ZXJsYXkpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChv dmVybGF5LWVuZCBvdmVybGF5KSkpCiAgICAgICAgICAgICAgIDs7IFNldCBiYWNrIHRoZSBkcmFn Z2VkIHRleHQgYXMgcmVnaW9uIG9uIHNvdXJjZSBidWZmZXIKICAgICAgICAgICAgICAgOzsgbGlr ZSBvcGVyYXRpb24gYGNvcHknLgogICAgICAgICAgICAgICAoYWN0aXZhdGUtbWFyaykpCiAgICAg ICAgICAgICAoc2VsZWN0LXdpbmRvdyB3aW5kb3ctdG8tcGFzdGUpKSkpKSkKIAogICAgIDs7IENs ZWFuIHVwLgotICAgIChkZWxldGUtb3ZlcmxheSBtb3VzZS1kcmFnLWFuZC1kcm9wLW92ZXJsYXkp CisgICAgKGRvbGlzdCAob3ZlcmxheSBtb3VzZS1kcmFnLWFuZC1kcm9wLW92ZXJsYXlzKQorICAg ICAgKGRlbGV0ZS1vdmVybGF5IG92ZXJsYXkpKQogCiAgICAgOzsgUmVzdG9yZSBvbGQgc3RhdGVz IGJ1dCBmb3IgdGhlIHdpbmRvdyB3aGVyZSB0aGUgZHJvcAogICAgIDs7IG9jY3VycmVkLiBSZXN0 b3JlIGN1cnNvciB0eXBlcyBmb3IgYWxsIHdpbmRvd3MuCmRpZmYgLS1naXQgYS9saXNwL3JlY3Qu ZWwgYi9saXNwL3JlY3QuZWwKaW5kZXggOGNjZjA1MWVlMS4uNDhkYjRmZmQ4ZiAxMDA2NDQKLS0t IGEvbGlzcC9yZWN0LmVsCisrKyBiL2xpc3AvcmVjdC5lbApAQCAtMTY3LDYgKzE2NywzNyBAQCBh cHBseS1vbi1yZWN0YW5nbGUKICAgICAgICAgICAgICAgICAgKDw9IChwb2ludCkgZW5kcHQpKSkp CiAgICAgICBmaW5hbC1wb2ludCkpKQogCisoZGVmdW4gcmVjdGFuZ2xlLXBvc2l0aW9uLWFzLWNv b3JkaW5hdGVzIChwb3NpdGlvbikKKyAgICJSZXR1cm4gY29ucyBvZiB0aGUgY29sdW1uIGFuZCBs aW5lIHZhbHVlcyBvZiBQT1NJVElPTi4KK1BPU0lUSU9OIHNwZWNpZmllcyBhIHBvc2l0aW9uIG9m IHRoZSBjdXJyZW50IGJ1ZmZlci4gIFRoZSB2YWx1ZQorcmV0dXJuZWQgaXMgYSBjb25zIG9mIHRo ZSBjdXJyZW50IGNvbHVtbiBvZiBQT1NJVElPTiBhbmQgaXRzIGxpbmUKK251bWJlci4iCisgIChz YXZlLWV4Y3Vyc2lvbgorICAgIChnb3RvLWNoYXIgcG9zaXRpb24pCisgICAgKGxldCAoKGNvbCAo Y3VycmVudC1jb2x1bW4pKQorICAgICAgICAgIChsaW5lICgxLSAobGluZS1udW1iZXItYXQtcG9z KSkpKQorICAgICAgKGNvbnMgY29sIGxpbmUpKSkpCisKKyhkZWZ1biByZWN0YW5nbGUtaW50ZXJz ZWN0LXAgKHBvczEgc2l6ZTEgcG9zMiBzaXplMikKKyAgICJSZXR1cm4gbm9uLW5pbCBpZiB0d28g cmVjdGFuZ2xlcyBpbnRlcnNlY3QuCitQT1MxIGFuZCBQT1MyIHNwZWNpZnkgdGhlIHBvc2l0aW9u cyBvZiB0aGUgdXBwZXItbGVmdCBjb3JuZXJzIG9mCit0aGUgZmlyc3QgYW5kIHNlY29uZCByZWN0 YW5nbGUgYXMgY29uc2VzIG9mIHRoZWlyIGNvbHVtbiBhbmQgbGluZQordmFsdWVzLiAgU0laRTEg YW5kIFNJWkUyIHNwZWNpZnkgdGhlIGRpbWVuc2lvbnMgb2YgdGhlIGZpcnN0IGFuZAorc2Vjb25k IHJlY3RhbmdsZSwgYXMgY29uc2VzIG9mIHRoZWlyIHdpZHRoIGFuZCBoZWlnaHQgbWVhc3VyZWQg aW4KK2NvbHVtbnMgYW5kIGxpbmVzLiIKKyAgKGxldCAoKHgxIChjYXIgcG9zMSkpCisgICAgICAg ICh5MSAoY2RyIHBvczEpKQorICAgICAgICAoeDIgKGNhciBwb3MyKSkKKyAgICAgICAgKHkyIChj ZHIgcG9zMikpCisgICAgICAgICh3MSAoY2FyIHNpemUxKSkKKyAgICAgICAgKGgxIChjZHIgc2l6 ZTEpKQorICAgICAgICAodzIgKGNhciBzaXplMikpCisgICAgICAgIChoMiAoY2RyIHNpemUyKSkp CisgICAgKG5vdCAob3IgKDw9ICgrIHgxIHcxKSB4MikKKyAgICAgICAgICAgICAoPD0gKCsgeDIg dzIpIHgxKQorICAgICAgICAgICAgICg8PSAoKyB5MSBoMSkgeTIpCisgICAgICAgICAgICAgKDw9 ICgrIHkyIGgyKSB5MSkpKSkpCisKIChkZWZ1biBkZWxldGUtcmVjdGFuZ2xlLWxpbmUgKHN0YXJ0 Y29sIGVuZGNvbCBmaWxsKQogICAod2hlbiAoPSAobW92ZS10by1jb2x1bW4gc3RhcnRjb2wgKGlm IGZpbGwgdCAnY29lcmNlKSkgc3RhcnRjb2wpCiAgICAgKGRlbGV0ZS1yZWdpb24gKHBvaW50KQot LSAKMi4xNy4xCgo= --00000000000001d0290577fd5f81-- From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 12 04:45:31 2018 Received: (at 31240) by debbugs.gnu.org; 12 Oct 2018 08:45:31 +0000 Received: from localhost ([127.0.0.1]:45935 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gAt4c-00079T-Sl for submit@debbugs.gnu.org; Fri, 12 Oct 2018 04:45:31 -0400 Received: from mout.gmx.net ([212.227.15.18]:45933) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gAt4b-00073Z-7E for 31240@debbugs.gnu.org; Fri, 12 Oct 2018 04:45:29 -0400 Received: from [192.168.1.101] ([213.162.73.29]) by mail.gmx.com (mrgmx003 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MUILK-1g2bMV05Hm-00R2o1; Fri, 12 Oct 2018 10:45:09 +0200 Received: from [192.168.1.101] ([213.162.73.29]) by mail.gmx.com (mrgmx003 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MUILK-1g2bMV05Hm-00R2o1; Fri, 12 Oct 2018 10:45:09 +0200 Message-ID: <5BC05F09.40007@gmx.at> Date: Fri, 12 Oct 2018 10:44:57 +0200 From: martin rudalics MIME-Version: 1.0 To: Federico Tedin Subject: Re: bug#31240: 26.1; mouse-save-then-kill does not kill rectangles References: <5BB8EC23.1040303@gmx.at> <5BB9A4E5.3070308@gmx.at> <20181008.192544.1387561894315194511.tkk@misasa.okayama-u.ac.jp> <5BBC5C25.8080002@gmx.at> <5BBD9A08.3090707@gmx.at> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:vGeWxbPxs+8WbbDheXwMlwNrk7MLSnPYzxCq+iZecuTfoFdCB1d N+PV+xArB018XGB/FvKcuaZnRc8xLkXDpzhw8Ja3ASkKWJAUPC0SKuarNLZYkk6WY/K5zGQ 7xJXRVVX/rzGPjvnIhds1Hl90pqo/b0+gi9YjE7lb5rmFkpy+x110nygjV7SswIp3GRgnj7 QlG8wAs0503w1pRGWLm9w== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V01:K0:sWIt5/PiMeM=:ofPTAP7+Rlqlq/+BwDP6My Dyg/7amW08mLRrDz4qkM8sgpPtZW3QgptmYcKnWm+7PaQ6mOGDf3PwHydbPjxK12BohrQt8eN M/jCJtGotu/BButqXH5pZxRu42uqsh8vVomi9F42W9GyyVqFsilA78ned/STqYdXKRLFD9oxU sTrkck6ieoDGX+PaDjos39o3Wzc28NF0+5XBMQUCEEcSZbtIGMLCnKcPfbtFl5OklhffPBUeJ lhx5GxDJ09eW3FQ50PvUY8geXwVkuUm7P9DdllDTmzb2Q7dJl5ziQvdhwV8FNcz7mUVCOw6YC iKl9NnAfbPRSrboPuG7g1gWwgtsuoCEc4qgKQqNY8rVa4M6n8Zn10ytfAkyL+TqUCxsEphSLf HCnvG9qcSJ4zAplfo7rrIFpFeVUVK1nqSXbFPoRFKVzJRPy6r0uqInGtZ+LISUXF+Eo5P/xnU avsNzc9a1H4S+yKXbRO08cAuvjOvjLmggEfpR8O/2WF8pgJlmNnEt7yAdTiA+fdVQRRYNYvWI Dh6+YYWUW7n9jhp3qKPlnAazS/7saXbae182T1B/wSWiW8xF/VxMhdOq+hf3rs5if220oBayU FYhWy/hTmEbmln+ZQsovxz+JJ+Pct/+M4ppvjnyKoUePS2EjwPpBYADfiKO8qQ8x9ZZBSume3 jjAevjpXAVoTYSI0ssmvrqmG/01KbKRSX6TZQBljM/bBoYdZYI9BI4dk/mfQ/UY/jVo2S/O1J Nj1jProjtrIG7AWmV3gsd7/9LITnuhFxi0SCDvRvYu3vLyx366BkGQVWPmwuDrxvwnDGW06kZ KDvgpmhtD/rP0fnq7JF6pUCTXerHzhr+5df8a/ObFR574R1VEo= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 31240 Cc: 31240@debbugs.gnu.org, homeros.misasa@gmail.com, tkk@misasa.okayama-u.ac.jp, charles@aurox.ch X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > At the moment, my current proposal is: allow the user to drag the > rectangle anywhere to the left (on the same line, or on a different > line), or anywhere else where it would not intersect with itself (I'm > attaching a new patch that allows this). Thanks. The following case looks a bit problematic here. Suppose my rectangle in an Elisp buffer is ;;;;;;;;;;;;;;;;;;; ;;;;;;RECT;;;;;;;;; ;;;;;;RECT;;;;;;;;; ;;;;;;RECT;;;;;;;;; ;;;;;;RECT;;;;;;;;; ;;;;;;RECT;;;;;;;;; ;;;;;;;;;;;;;;;;;;; If I now drag it up by one line and four columns to the right (so that it just does not intersect with itself) I get ;;;;;;;;;;RECT;;;;;;;;; ;;;;;;RECT;;;;;;;;; ;;;;;;RECT;;;;;;;;; ;;;;;;RECT;;;;;;;;; ;;;;;;RECT;;;;;;;;; ;;;;;;;;;;;;;;; ;;;;;;;;;;;;;;;;;;; which is somehow counterintuitive. Any ideas? Thanks, martin From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 12 18:09:11 2018 Received: (at 31240) by debbugs.gnu.org; 12 Oct 2018 22:09:11 +0000 Received: from localhost ([127.0.0.1]:47560 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gB5cN-0000bY-FN for submit@debbugs.gnu.org; Fri, 12 Oct 2018 18:09:11 -0400 Received: from mail-lj1-f181.google.com ([209.85.208.181]:39304) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gB5cL-0000bL-Da for 31240@debbugs.gnu.org; Fri, 12 Oct 2018 18:09:09 -0400 Received: by mail-lj1-f181.google.com with SMTP id p1-v6so12587679ljg.6 for <31240@debbugs.gnu.org>; Fri, 12 Oct 2018 15:09:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ntWp4oAWkj4oWsaUO6hXFWhzWI/kUCoMkogZYrsBSt4=; b=r1gjd5ldibRkJphHYKjKcGP1P3IkArRkpX78gCsR11dvy8mbthGt/+tLM0UrlvpNkw bkcH77UmmIEGTu8fQEhJ+Rv1nIuMKLcmXHHoA+xY+42sNpbzFIyr9sf5QvAhO2X7L82E 1nwIGYI/PxnZyA5RkZIb8q5HSXGkio4gxe4Q5kbflgfV+34a2l0utRwD7XL2vuRvuboT 8Cck7E4iWBadXdMa0mil3WM1884iHVVgv/PpOCxgguc6IcfFN6YmiG205nbCgc0ccUH1 DPEMCqV700kctqDI4KGx4gB8JWys4zC3MfV7lO0HmR0juVpk54nIEHkMHBB9Pbzye0WM ABGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ntWp4oAWkj4oWsaUO6hXFWhzWI/kUCoMkogZYrsBSt4=; b=tpTjd+bYtUbeP/KRceT35XCEnSIEvGIwzBNMYTanHRZIIuPSL2sLHNnj9D03aySkGM RIDXWkt0FfhQWTKG4I75yMK7Cm+3nqjJVrGFO3gyPZlTjs0OmobWe7ExkwLI5r3LuL/r tfZykFmMq8nimY/2XF1Yhk3bMpS8zZHLD9R6WQYTw1FAVPEqJ3pntBZWyLQpvwLV/VkI Ybd0aLfG0QvZ0kD45EbtGpXn5+Q4YicKgSDoQ4twU0fiF1AT8R6isHVSfmOgG4GNxbXD MoJ16fh01qOy01K93j1F1bGJowF99+/zJJH3WO4Hh7QzzyArhLAYL+jSlOfu2Md4V8t0 nCng== X-Gm-Message-State: ABuFfogTkSlYxInC7pkLBW8nEyqrmMAuGS0lRmS8X+7mKPZhBOQH+FR2 SD3LHHjog0Ay4WPmHGrji6wUU3wpeNdmXhRnOkw= X-Google-Smtp-Source: ACcGV60DqXoGPs943WVv2+dP+3n6wRsobIBbfrVcnWVp1nLUZVDLgZNWevy4j0WDXtJQG3fJrzlbMVFm4mt2bA7aqXw= X-Received: by 2002:a2e:900c:: with SMTP id h12-v6mr5449649ljg.121.1539382143309; Fri, 12 Oct 2018 15:09:03 -0700 (PDT) MIME-Version: 1.0 References: <5BB8EC23.1040303@gmx.at> <5BB9A4E5.3070308@gmx.at> <20181008.192544.1387561894315194511.tkk@misasa.okayama-u.ac.jp> <5BBC5C25.8080002@gmx.at> <5BBD9A08.3090707@gmx.at> <5BC05F09.40007@gmx.at> In-Reply-To: <5BC05F09.40007@gmx.at> From: Federico Tedin Date: Fri, 12 Oct 2018 19:08:50 -0300 Message-ID: Subject: Re: bug#31240: 26.1; mouse-save-then-kill does not kill rectangles To: rudalics@gmx.at Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 31240 Cc: 31240@debbugs.gnu.org, homeros.misasa@gmail.com, tkk@misasa.okayama-u.ac.jp, charles@aurox.ch X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > If I now drag it up by one line and four columns to the right (so that > it just does not intersect with itself) I get > > ;;;;;;;;;;RECT;;;;;;;;; > ;;;;;;RECT;;;;;;;;; > ;;;;;;RECT;;;;;;;;; > ;;;;;;RECT;;;;;;;;; > ;;;;;;RECT;;;;;;;;; > ;;;;;;;;;;;;;;; > ;;;;;;;;;;;;;;;;;;; > > which is somehow counterintuitive. Any ideas? This is because after inserting the rectangle, the original rectangle (which is to the left of the inserted one) is deleted. When it is deleted, then the last 4 lines of the inserted rectangle are shifted to the left: 1) Inserted new rectangle: ;;;;;;;;;;RECT;;;;;;;;; ;;;;;;RECTRECT;;;;;;;;; ;;;;;;RECTRECT;;;;;;;;; ;;;;;;RECTRECT;;;;;;;;; ;;;;;;RECTRECT;;;;;;;;; ;;;;;;RECT;;;;;;;;; ;;;;;;;;;;;;;;;;;;; 2) Deleted the original one: ;;;;;;;;;;RECT;;;;;;;;; <--- this line isn't shifted ;;;;;;RECT;;;;;;;;; ;;;;;;RECT;;;;;;;;; ;;;;;;RECT;;;;;;;;; ;;;;;;RECT;;;;;;;;; ;;;;;;;;;;;;;;; ;;;;;;;;;;;;;;;;;;; I've thought up two ways of dealing with this problem: A) Forbid the user from dragging the rectangle to the right when the new rectangle is *not* completly above or completly below the original one. As an exception, allow the user to drag the rectangle purely to the right (same line). In this option, the drag operation in your example would not be permitted. I think this option would be a bit confusing for users (and too restrictive). B) Add a variable mouse-drag-and-drop-rectangle-fill, initially set to nil. When the variable's value is nil, the behaviour of dragging and dropping rectangles is exactly the same as it is now. When it is set to a non-nil value (for example, " "), then replace all characters of the original rectangle with the variable's value. In this case, your example would look like this: 1) M-: (setq mouse-drag-and-drop-rectangle-fill " ") 2) Inserted new rectangle: ;;;;;;;;;;RECT;;;;;;;;; ;;;;;;RECTRECT;;;;;;;;; ;;;;;;RECTRECT;;;;;;;;; ;;;;;;RECTRECT;;;;;;;;; ;;;;;;RECTRECT;;;;;;;;; ;;;;;;RECT;;;;;;;;; ;;;;;;;;;;;;;;;;;;; 3) Deleted the original one: ;;;;;;;;;;RECT;;;;;;;;; ;;;;;; RECT;;;;;;;;; ;;;;;; RECT;;;;;;;;; ;;;;;; RECT;;;;;;;;; ;;;;;; RECT;;;;;;;;; ;;;;;; ;;;;;;;;; ;;;;;;;;;;;;;;;;;;; I can't think of any other way of ensuring the inserted rectangle retains its shape after being inserted, if there are pending delete operations to its left. From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 13 04:19:19 2018 Received: (at 31240) by debbugs.gnu.org; 13 Oct 2018 08:19:19 +0000 Received: from localhost ([127.0.0.1]:47708 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gBF8p-0006nf-2H for submit@debbugs.gnu.org; Sat, 13 Oct 2018 04:19:19 -0400 Received: from mout.gmx.net ([212.227.17.22]:41751) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gBF8m-0006nN-TW for 31240@debbugs.gnu.org; Sat, 13 Oct 2018 04:19:17 -0400 Received: from [192.168.1.100] ([213.162.73.245]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MKYpv-1gCcZu06rP-001xla; Sat, 13 Oct 2018 10:18:53 +0200 Received: from [192.168.1.100] ([213.162.73.245]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MKYpv-1gCcZu06rP-001xla; Sat, 13 Oct 2018 10:18:53 +0200 Message-ID: <5BC1AA69.5010304@gmx.at> Date: Sat, 13 Oct 2018 10:18:49 +0200 From: martin rudalics MIME-Version: 1.0 To: Federico Tedin Subject: Re: bug#31240: 26.1; mouse-save-then-kill does not kill rectangles References: <5BB8EC23.1040303@gmx.at> <5BB9A4E5.3070308@gmx.at> <20181008.192544.1387561894315194511.tkk@misasa.okayama-u.ac.jp> <5BBC5C25.8080002@gmx.at> <5BBD9A08.3090707@gmx.at> <5BC05F09.40007@gmx.at> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:Mypqmtqmj9cpvbUhhuLPupdqWqB+lquDOc7Wa9XLwRI0KMMu9e7 OUPb7t414sC5DgIU2vjtEB7TAYohLglRnhJ0sAF+oqisRtVG7Zf5sEBdxQsPVM0uMzsKvMv nr3tmv8utHX8wRkYfi4viKXtJcPJg6OaxoOBju3FQ/iol2ojsiZH7C+p7VxWWrI6z4y5Y2J N3Cg+r10Or9NLWXjLjMRw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V01:K0:fBKXJxX28DY=:NYyl2BGRnVkJHeCYks1SvE nA+dHstLDTeoZyGbOOZFjVvd7UY2ikfd8E7yZoyiBn43bfGYqI/011yT0H2cnnANJ9heu4KLS 5PcxthEB1eRjTMM3gmFuaRtsWGLdsV+Hyj7/HJbvxr1miTjKtcgUZIzavYJg90Uhj1xDlfubU pdRsOUTp9cp2qDhzo3Q1hCRlpQuBaozc6q1s7mmtilkqbbykLwSvvtQegB2fGf5ycQlPzuHqi cWSEBmR9cjStqOqfYGdnwYCgQqnOQxvFdx5DkH2HlY01aUMP7aMH/AYJ401dkAMQzlzsYevnr KNbIfcIQkvKZZik++Vms5CO4V5Yy8xiq/exR2IvNhZmHpIiU6xdJFqAX6GgNA55qcbJT4BkaW tu0sTfhLTXC4mXmyg3xTCzZL1RDaDvk6ZgTMi8A/QP9mvh/9RqxpRfIII0cmsHhEWE9s0h9pZ zKTbRpu/ygQOf8cfhmWMygysvA1GxD9ZYx8ZaJMQUyA2Uy1Y/lfC/i00qEI+1/imKFz0rch8V 2ad9O4zFqLFp5k6uxQbfWESRX9o8cJSXKT0kTAcNmCkqLHV6udfEpm1Lufz/qBERph3yGiqe3 1RXeh8nQY+JcYfLnfJr8PTM8BaTLqEnCAwqUUrYNIxYbqHqC9tanAgfKH2ZaPuPQMsjuGY9jS ZnQK+kFYYuV/fBtS7fckr7zXFmNPY/YWG0BECSYYFQ/QjMlrMwJKKzlKxXrYi27ArpXnRX0Nm Euod1AH7K1nY6+FVQJeTGidg7lZ2v2LMA2Bi5xpYjUmijWkZrcLvcrMAzMZOS9s67Ji5sdVA3 B4H4mQDn4Dv5zaz4HU8vP6lYv2FBXnUC3NugUqeER7l9gLCnfE= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 31240 Cc: 31240@debbugs.gnu.org, homeros.misasa@gmail.com, tkk@misasa.okayama-u.ac.jp, charles@aurox.ch X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > This is because after inserting the rectangle, the original rectangle > (which is to the left of the inserted one) is deleted. When it is > deleted, then the last 4 lines of the inserted rectangle are shifted > to the left: > > 1) Inserted new rectangle: > > ;;;;;;;;;;RECT;;;;;;;;; > ;;;;;;RECTRECT;;;;;;;;; > ;;;;;;RECTRECT;;;;;;;;; > ;;;;;;RECTRECT;;;;;;;;; > ;;;;;;RECTRECT;;;;;;;;; > ;;;;;;RECT;;;;;;;;; > ;;;;;;;;;;;;;;;;;;; > > 2) Deleted the original one: > > ;;;;;;;;;;RECT;;;;;;;;; <--- this line isn't shifted > ;;;;;;RECT;;;;;;;;; > ;;;;;;RECT;;;;;;;;; > ;;;;;;RECT;;;;;;;;; > ;;;;;;RECT;;;;;;;;; > ;;;;;;;;;;;;;;; > ;;;;;;;;;;;;;;;;;;; Thanks for the explanation. > I've thought up two ways of dealing with this problem: > > A) Forbid the user from dragging the rectangle to the right when the > new rectangle is *not* completly above or completly below the original > one. As an exception, allow the user to drag the rectangle purely to > the right (same line). In this option, the drag operation in your > example would not be permitted. I think this option would be a bit > confusing for users (and too restrictive). Agreed. > B) Add a variable mouse-drag-and-drop-rectangle-fill, initially set to > nil. When the variable's value is nil, the behaviour of dragging and > dropping rectangles is exactly the same as it is now. When it is set > to a non-nil value (for example, " "), then replace all characters of > the original rectangle with the variable's value. In this case, your > example would look like this: > > 1) M-: (setq mouse-drag-and-drop-rectangle-fill " ") > > 2) Inserted new rectangle: > > ;;;;;;;;;;RECT;;;;;;;;; > ;;;;;;RECTRECT;;;;;;;;; > ;;;;;;RECTRECT;;;;;;;;; > ;;;;;;RECTRECT;;;;;;;;; > ;;;;;;RECTRECT;;;;;;;;; > ;;;;;;RECT;;;;;;;;; > ;;;;;;;;;;;;;;;;;;; > > 3) Deleted the original one: > > ;;;;;;;;;;RECT;;;;;;;;; > ;;;;;; RECT;;;;;;;;; > ;;;;;; RECT;;;;;;;;; > ;;;;;; RECT;;;;;;;;; > ;;;;;; RECT;;;;;;;;; > ;;;;;; ;;;;;;;;; > ;;;;;;;;;;;;;;;;;;; > > I can't think of any other way of ensuring the inserted rectangle > retains its shape after being inserted, if there are pending delete > operations to its left. Let's keep B) in mind for the case that someone comes up with a real use case where this would be needed. Mine was just a constructed one that looked convincing to me to to be reported. The only remaining problem I have now is that we are far beyond the 80 columns limit for code. I came up with truncating the assignment to 'drag-but-negligible' as follows (setq drag-but-negligible (and (eq (overlay-buffer (car mouse-drag-and-drop-overlays)) buffer-to-paste) (if region-noncontiguous ;; If the region is rectangular, check if ;; the newly inserted rectangular text ;; would intersect the already selected ;; region. If it would, then set ;; "drag-but-negligible" to t. As a ;; special case, allow dragging the region ;; freely anywhere to the left, as this ;; will never trigger its contents to be ;; inserted into the overlays tracking it. (let ((size (cons region-width region-height)) (start-coordinates (rectangle-position-as-coordinates start)) (point-to-paste-coordinates (rectangle-position-as-coordinates point-to-paste))) (and (rectangle-intersect-p start-coordinates size point-to-paste-coordinates size) (not (<= (car point-to-paste-coordinates) (car start-coordinates))))) (and (<= (overlay-start (car mouse-drag-and-drop-overlays)) point-to-paste) (<= point-to-paste (overlay-end (car mouse-drag-and-drop-overlays)))))))) but that's ugly. If you have any ideas how to handle that better (for example, by moving the comment up by a few lines) I'll do that. Otherwise, I'll have to use that form above. Thanks, martin From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 13 10:02:04 2018 Received: (at 31240) by debbugs.gnu.org; 13 Oct 2018 14:02:04 +0000 Received: from localhost ([127.0.0.1]:48513 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gBKUU-0002XJ-GF for submit@debbugs.gnu.org; Sat, 13 Oct 2018 10:02:02 -0400 Received: from mail-lj1-f170.google.com ([209.85.208.170]:45479) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gBKUQ-0002Wi-Dv for 31240@debbugs.gnu.org; Sat, 13 Oct 2018 10:02:01 -0400 Received: by mail-lj1-f170.google.com with SMTP id j4-v6so13683469ljc.12 for <31240@debbugs.gnu.org>; Sat, 13 Oct 2018 07:01:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hi+93hFcqdm0lSLwoYxSMlklGw9rlF7D0GHvszQhem8=; b=SCZKaXhl6YGpzJSiJJ6naZz5SJAyiDYHvFpZITu2OR2uTkavgLjdDYXND1pnOoZFUL +ZPTnrqkwZ9thQL7MCvRUueBePZ5A5vkbKmbu+Poi9Cc43XC5YARjjjtWnpogX/Bb9Ps I7Ej3hTAamrjgMohRuxtOnB2qJuTFF8bKBMdFX8LvB6Zhz/wVMh6gDoZGkueF60JE0x9 IcS5UEPOZuSsHljf+qluZOUM5MW57Yu+G9TpiUkxHCdRi4DYX/p9gGrl0YNgmRwbzGjh uhWzZDRqGnOnuXZAFb9fdcev7XVP/FZIsQ6qkp8NQ8hrroY2a5SVU+zFKzJbmqbN1V5k 5D2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hi+93hFcqdm0lSLwoYxSMlklGw9rlF7D0GHvszQhem8=; b=nX40KhSWfC2m7FBu880BMLuBSJK4W+qvx+A+seVNuvovVLOkLslbQvwERLHC9C28JG IGsRbuRGV1Aqv4iD4m23fY+Ejl9RD4lRHUW3pfbcZklE2NoU25Y27cCgo29gr451fm1n 16KwlLBVJ7iBQ+DjiZ+MfxSNccWIhcb+ZkRbkLM0wa+I8q1AQ671HoyWOdiaOOzvKlX0 7IM4PZ3DOlkJb7U0Iac8nSN/AUH+zijAjhavIFEcT/LXa4afEYI/J/D9bLSQ0M0ytOOr RaB0w/oeHXwEmAXxq+yO2/J66+0/3TolELUOM1+CzXKOV9QeQ7dAKP8tus7Cgkifwwha +KzA== X-Gm-Message-State: ABuFfojsTLd5EA8kQ3onObOtfQC/XUeOppRupCcLMNHynh4PNDY5Qa35 QTvojtTB53oKj6fyIPLbnq8DwkfD35wNAoq5jCI= X-Google-Smtp-Source: ACcGV62YERIVx0+uIOZXAEudnNQr7XBgaZ8fRiGQHElZgEnyQFdSa2QwNWHwx7RY3mMjJ5Q2LpX3QhTjM6mbny1PIYw= X-Received: by 2002:a2e:900c:: with SMTP id h12-v6mr7017443ljg.121.1539439312289; Sat, 13 Oct 2018 07:01:52 -0700 (PDT) MIME-Version: 1.0 References: <5BB8EC23.1040303@gmx.at> <5BB9A4E5.3070308@gmx.at> <20181008.192544.1387561894315194511.tkk@misasa.okayama-u.ac.jp> <5BBC5C25.8080002@gmx.at> <5BBD9A08.3090707@gmx.at> <5BC05F09.40007@gmx.at> <5BC1AA69.5010304@gmx.at> In-Reply-To: <5BC1AA69.5010304@gmx.at> From: Federico Tedin Date: Sat, 13 Oct 2018 11:01:38 -0300 Message-ID: Subject: Re: bug#31240: 26.1; mouse-save-then-kill does not kill rectangles To: rudalics@gmx.at Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 31240 Cc: 31240@debbugs.gnu.org, homeros.misasa@gmail.com, tkk@misasa.okayama-u.ac.jp, charles@aurox.ch X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Let's keep B) in mind for the case that someone comes up with a real > use case where this would be needed. Mine was just a constructed one > that looked convincing to me to to be reported. I agree that option B) seems better. Should I implement it now. or would it be better to wait for other opinions? > The only remaining problem I have now is that we are far beyond the 80 > columns limit for code. I came up with truncating the assignment to > 'drag-but-negligible' as follows > ... > but that's ugly. If you have any ideas how to handle that better (for > example, by moving the comment up by a few lines) I'll do that. > Otherwise, I'll have to use that form above. I started re-indenting some lines to see if I could make them fit in 80 columns, but then I realized the results were exactly the same as yours. I just ended up moving the comment instead: ;; Check if "drag but negligible". Operation "drag but ;; negligible" is defined as drag-and-drop the text to ;; the original region. When modifier is pressed, the ;; text will be inserted to inside of the original ;; region. ;; If the region is rectangular, check if the newly inserted ;; rectangular text would intersect the already selected ;; region. If it would, then set "drag-but-negligible" to t. ;; As a special case, allow dragging the region freely anywhere ;; to the left, as this will never trigger its contents to be ;; inserted into the overlays tracking it. (setq drag-but-negligible (and (eq (overlay-buffer (car mouse-drag-and-drop-overlays)) buffer-to-paste) (if region-noncontiguous (let ((size (cons region-width region-height)) (start-coordinates (rectangle-position-as-coordinates start)) (point-to-paste-coordinates (rectangle-position-as-coordinates point-to-paste))) (and (rectangle-intersect-p start-coordinates size point-to-paste-coordinates size) (not (<= (car point-to-paste-coordinates) (car start-coordinates))))) (and (<= (overlay-start (car mouse-drag-and-drop-overlays)) point-to-paste) (<= point-to-paste (overlay-end (car mouse-drag-and-drop-overlays)))))))) From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 15 03:56:41 2018 Received: (at 31240) by debbugs.gnu.org; 15 Oct 2018 07:56:41 +0000 Received: from localhost ([127.0.0.1]:49749 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gBxk0-000474-Rf for submit@debbugs.gnu.org; Mon, 15 Oct 2018 03:56:40 -0400 Received: from mout.gmx.net ([212.227.17.20]:52225) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gBxjz-00046r-Ms for 31240@debbugs.gnu.org; Mon, 15 Oct 2018 03:56:40 -0400 Received: from [192.168.1.101] ([212.95.5.207]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MJjUO-1gAro041TQ-0018LF; Mon, 15 Oct 2018 09:56:21 +0200 Received: from [192.168.1.101] ([212.95.5.207]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MJjUO-1gAro041TQ-0018LF; Mon, 15 Oct 2018 09:56:21 +0200 Message-ID: <5BC4481F.4060107@gmx.at> Date: Mon, 15 Oct 2018 09:56:15 +0200 From: martin rudalics MIME-Version: 1.0 To: Federico Tedin Subject: Re: bug#31240: 26.1; mouse-save-then-kill does not kill rectangles References: <5BB8EC23.1040303@gmx.at> <5BB9A4E5.3070308@gmx.at> <20181008.192544.1387561894315194511.tkk@misasa.okayama-u.ac.jp> <5BBC5C25.8080002@gmx.at> <5BBD9A08.3090707@gmx.at> <5BC05F09.40007@gmx.at> <5BC1AA69.5010304@gmx.at> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:kE3G0bsKYgpAo0JAp3J3LYDKS8bRMVk4nCepmk5nLi928FWfR1a nvVqni+86AAOM3j2TpLL+c+aqiWvky8+QgH2ejz4FjfM/vMh0/cg6tzuJe8NZmu1eFP+ZSR GFYuKSBK6kUO2w2Yd1vYEw6LBwe3cxZB0rArbJh2Nn3iEzwauvOzu8a3y3gVWY+Rktxr5gf VLf6PNmk3X+Eh/eHW236g== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V01:K0:01LsYes7/dQ=:c4unEy3Pf7Xw3nLllyQ3KU S8PtzcDhK6LGQgL8P4zXSmmfXv+WLKIV5lPE9o63WRLItycvU/hDcdx4Uv+0oE0Fpy8iVzm44 QcoJ+AO4At3xlWEQgMeyU/u357ZGaO/+T3jG8DmLrc/mephnfskXb6wuyfpPwEzd4ZmIask8q 3jevtHaJffefxcttijdHjOsZQuvo2m+A1niVR5zdm//ZOsok+kzsARJ6c0RZLcCTW6MLhDvot a0GKt2a4hs4reD8AR8oeZ5kLwjaYyLtIz3dEkWPUkX7RjLkiaOKSiS7bhS0I0n+rOppKvJzq0 6ZvPumdIPSbwYnvCiQpMKHG5ljRBoFyDpZRQpJhCa6JkoLSF8oG2SOH1cwhV7hFNh6TuBbeqV McNPRKD5dbit9trtq5rIsiPmc+HPmBzFl86J6GxrLscP3VIVubWNS36KemptD4Wm+VmDc1JIa CTnbbbABWaYlWBIjZ18kist3pk1aYWRtjXGOfSha9cvUtXDpHi/k1PAqhnydlpwGC6RDDsYIc gLnepeyx94CeMQi7WN9eUqAegyQz4aLcxYgIia4bOHPCjkrK309pXtCBHYnOmuABezcx5t1cZ R/GynnEnq/HE2KCYLHv1dyXNDxndGEI+TTDtshu+gBdJXv9io7QiU1AFOb7jMGhH//MFyHkd6 VW6oSgR3eJcFB7UqzElN/Gmh14+pPoD+A59K7myv0tihEP8erBDrToXvCaxSFzvjEw3EzblVk pJQgQcmZZE7wXsxnGB54tAR9NRhJHCvL0Hd9s5b5ZHmKYlxRYxcF5lGc9hkOXdivum/JhvN8Q MluWbvboz2Qq3+n59TVU0qu4ty/Neiha6lMp3SDN0EStffwNKI= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 31240 Cc: 31240@debbugs.gnu.org, homeros.misasa@gmail.com, tkk@misasa.okayama-u.ac.jp, charles@aurox.ch X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > I agree that option B) seems better. Should I implement it now. or > would it be better to wait for other opinions? Let's wait. > I started re-indenting some lines to see if I could make them fit in 80 columns, > but then I realized the results were exactly the same as yours. I just ended up > moving the comment instead: OK. If there are no further objections I'll install that. Thanks, martin From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 17 03:28:44 2018 Received: (at 31240) by debbugs.gnu.org; 17 Oct 2018 07:28:44 +0000 Received: from localhost ([127.0.0.1]:54321 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gCgG4-0006JE-KK for submit@debbugs.gnu.org; Wed, 17 Oct 2018 03:28:44 -0400 Received: from mout.gmx.net ([212.227.17.20]:37187) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gCgG2-0006Iz-OO for 31240@debbugs.gnu.org; Wed, 17 Oct 2018 03:28:43 -0400 Received: from [192.168.1.101] ([212.95.5.87]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MN748-1gJJ1T0d20-006dRS; Wed, 17 Oct 2018 09:28:23 +0200 Received: from [192.168.1.101] ([212.95.5.87]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MN748-1gJJ1T0d20-006dRS; Wed, 17 Oct 2018 09:28:23 +0200 Message-ID: <5BC6E48F.201@gmx.at> Date: Wed, 17 Oct 2018 09:28:15 +0200 From: martin rudalics MIME-Version: 1.0 To: Federico Tedin Subject: Re: bug#31240: 26.1; mouse-save-then-kill does not kill rectangles References: <5BB8EC23.1040303@gmx.at> <5BB9A4E5.3070308@gmx.at> <20181008.192544.1387561894315194511.tkk@misasa.okayama-u.ac.jp> <5BBC5C25.8080002@gmx.at> <5BBD9A08.3090707@gmx.at> <5BC05F09.40007@gmx.at> <5BC1AA69.5010304@gmx.at> <5BC4481F.4060107@gmx.at> In-Reply-To: <5BC4481F.4060107@gmx.at> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:9KE8eLDJW7pHUxGCVirLxZvmWwU8u/7bZo40tzTrxfcIMk5pBtb 0qSfqxx39NiURM6WubKpq3cUtTXBMCiWHxMPMODrwHttuV8Owyu6WUrmsyy6LBmWqvqQx7d P2EikdNccDD1+wETpftEqsclidD7HW8jEp5d2R/DZoAqkkTAd6JvHoFL0WVYUnBpNiAxyfv JzYdgJgYqY1H54YbNndSA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V01:K0:56Th5FGCp3Y=:w9laFCp7yAVxU+XeOcPyRI 2LF+RYz/AzlsaMGFGUTjIO3TJbYVl04mLP5qazXd5hITW/XtggUo6a/w/Ea3/uhUjRtg/bUWn bGURnnGrLs+FexB2MvOsgZGGQWU1uiJrOBFrwf5mtIsA+mmQ4qt0HAKiakBUn2rKkRJd7t3K5 HBHPoA/It0iHr57GZF4mylh7t40PQwCIzscw9VenCZkoN0Dqtu0H79YPLbbg/MYbrbHzs6mWU QAcHV3sTs+S7t/55uOdZm35HRS78GIzy/4EnCWrlX8Opd5X4cHPIfKxDZRAmhYDk+xb8SFsMd I5d1fj/ahzirahZBw9m/IZUl6cR+s3rWCL1Kj3EPkG9UBkLUioMumMne1K1pSAsQ5ybOqzfeO xCjU6B4vPnmTJzvlkHj9xorzsD6WE/CHX232ETc4iWdwPlyBcOh6UjNdQIwLAg3fK9rnJyHIK NalqrYB2tf6C8vT7Ph7ecebRnx7ggA1sXQLi/dwKs9d8R+JR9nioBu7ckg0hg9xokdsjGBITs 8RoQUtoeYpa6CXeLxJNuhhptWUp13lUh5xBczWMscwjJ4fQ9eeFCc6Ehyy1ghlRWj3AnbZ9LF a+fKgUoFVIhg+jyCNF0oksabGhajpbgDCvLo86L6K4juUpwz03HfVzVubzur+NrbRlO3lj1pM gOhj9eaYTNOge3bwDCxCSTZvnf+tRB636GimnH+/Mj5BIIL2seCHrJb3wBlxLuRK+EnQjozVW TM6EjrTuM8PiJ6WZPxyZR8wIt2uWLkmVFTx5NpJU1xcO3Ay9x1/wdnYmkMAdvq/0tV2bslpWB 7rPs7cqZTkiVODHOcFpZXmiZPkliYuiDw7oqg79v3tLC8Cpx/4= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 31240 Cc: 31240@debbugs.gnu.org, homeros.misasa@gmail.com, tkk@misasa.okayama-u.ac.jp, charles@aurox.ch X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > OK. If there are no further objections I'll install that. Done with commit 134ba45bf0c11048c44a46c11d5dc8da12ca4d3e on master. Please close bug#31240 if nothing else remains to be done. Thanks for the work, martin From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 18 20:03:08 2018 Received: (at 31240) by debbugs.gnu.org; 19 Oct 2018 00:03:08 +0000 Received: from localhost ([127.0.0.1]:57641 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gDIFw-0004Jd-Fq for submit@debbugs.gnu.org; Thu, 18 Oct 2018 20:03:08 -0400 Received: from mail-lf1-f41.google.com ([209.85.167.41]:33683) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gDIFu-0004Gr-W4 for 31240@debbugs.gnu.org; Thu, 18 Oct 2018 20:03:07 -0400 Received: by mail-lf1-f41.google.com with SMTP id o21-v6so23942002lfe.0 for <31240@debbugs.gnu.org>; Thu, 18 Oct 2018 17:03:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gIIvxo761UccwJpIShYwG0HhB/Y8GQj8dTfJvlvN9iE=; b=iHbaZJDvLv9NmcZ1N/zJ35iqsAGydpXOjgFM+hI39A7PQR8cU69+tXivQ5uuZ6oNHv YWhq11R6QozEqMxTkLbILrQTIvavp59kROMgoYq9oPFfqGv0a7zXpo9lXmqexCTqrBQd rJ7z6wrAQwlf7DUW0U8a4pnEcnCn45LURZMc9T8uZdxTOhB0QpqkY1bpamEymVnKYxlv QtFzlnRrHdH8PxH1jEng0JluN7PkEPt08qmly3cOweeUV3czkUIp2SeF0KfvqB0SXxeL KNw+vZV0G8kSFygArjtRyJn9i8fl1dNOI6BBxGcEIkzEoHQ5BSzJxT3VhKSOKXkl2wkK eqjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gIIvxo761UccwJpIShYwG0HhB/Y8GQj8dTfJvlvN9iE=; b=ewKB4iQhy5+Vhcns7h36QcicqP0Fq+owtUYG/F0SM6b7mG4jcLNbZVZjhr+Jh85O7w VwA4paeIPlnIBSt96+WLCi9YpToEBdRFbqUO2yvfEZc79AQanY+IPSzo0RQThVjLnqQi 9YpgFaESTwzLGm8x5Y3LN2aYFWCL4Tqsd9MY3qAmqP85fyVp+sCSr7qth2o/n81QiWUR lQ9ezgFrA2C6BaBaOJuOoP4R448KC111/VoplO9BBZTl0wvce3HW60tp0Euz9zNyNxYu InNK5orOdsFAKTfbwv+lw2/4lrgAtaljAptnNM2m96V8hhUKUr8Tu693H3cINK7Eu5yO /rLA== X-Gm-Message-State: ABuFfogXax5QbRVw0ZArMl1qqxCnazuAIATJiex9Q/YnKwt1Bg2KbTwx hU4q2Y7eUXM38pziZzbvqd09BDf42ZEio5AXc6A= X-Google-Smtp-Source: ACcGV634NyOBZNtq0RuqW1tTFkr3p91bKEwiabvfehgF7ywoBEvEt1e/EwciRIuAORqxIjx5NKPwSC5VDUSafwNu/kI= X-Received: by 2002:a19:aa8b:: with SMTP id t133-v6mr1472282lfe.92.1539907381007; Thu, 18 Oct 2018 17:03:01 -0700 (PDT) MIME-Version: 1.0 References: <5BB8EC23.1040303@gmx.at> <5BB9A4E5.3070308@gmx.at> <20181008.192544.1387561894315194511.tkk@misasa.okayama-u.ac.jp> <5BBC5C25.8080002@gmx.at> <5BBD9A08.3090707@gmx.at> <5BC05F09.40007@gmx.at> <5BC1AA69.5010304@gmx.at> <5BC4481F.4060107@gmx.at> <5BC6E48F.201@gmx.at> In-Reply-To: <5BC6E48F.201@gmx.at> From: Federico Tedin Date: Thu, 18 Oct 2018 21:02:48 -0300 Message-ID: Subject: Re: bug#31240: 26.1; mouse-save-then-kill does not kill rectangles To: rudalics@gmx.at Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 31240 Cc: 31240@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Please close bug#31240 if nothing else remains to be done. Is this something I should do? (If so, how?) > Thanks for the work, martin Thanks for your help. From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 19 03:41:15 2018 Received: (at 31240-done) by debbugs.gnu.org; 19 Oct 2018 07:41:15 +0000 Received: from localhost ([127.0.0.1]:58080 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gDPPG-0007XC-SM for submit@debbugs.gnu.org; Fri, 19 Oct 2018 03:41:15 -0400 Received: from mout.gmx.net ([212.227.15.19]:45761) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gDPPF-0007Wy-6A for 31240-done@debbugs.gnu.org; Fri, 19 Oct 2018 03:41:13 -0400 Received: from [192.168.1.101] ([212.95.5.57]) by mail.gmx.com (mrgmx001 [212.227.17.190]) with ESMTPSA (Nemesis) id 0Mb8MV-1ftwc50bmN-00KkM7; Fri, 19 Oct 2018 09:41:06 +0200 Received: from [192.168.1.101] ([212.95.5.57]) by mail.gmx.com (mrgmx001 [212.227.17.190]) with ESMTPSA (Nemesis) id 0Mb8MV-1ftwc50bmN-00KkM7; Fri, 19 Oct 2018 09:41:06 +0200 Message-ID: <5BC98A89.3040509@gmx.at> Date: Fri, 19 Oct 2018 09:40:57 +0200 From: martin rudalics MIME-Version: 1.0 To: Federico Tedin Subject: Re: bug#31240: 26.1; mouse-save-then-kill does not kill rectangles References: <5BB8EC23.1040303@gmx.at> <5BB9A4E5.3070308@gmx.at> <20181008.192544.1387561894315194511.tkk@misasa.okayama-u.ac.jp> <5BBC5C25.8080002@gmx.at> <5BBD9A08.3090707@gmx.at> <5BC05F09.40007@gmx.at> <5BC1AA69.5010304@gmx.at> <5BC4481F.4060107@gmx.at> <5BC6E48F.201@gmx.at> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:RJ5f8BHXy31fc1/6if7ekEXt6iy3o1izxvRbwdVyD1Jm/4ogHEX 6YiHmAG2DmGHPXCAngAw3aPXbrdU3Us59DOMqU3DEKEbWMpuDQQ9CyJIqOHQ9RDFP+5Su6L lj9B/wpj1VDA2ECStXISWu3gSZmwHoMSEHNZWqCvemI0zD9NXg6Z91Ns/NxXgzYoRlced/L Fx3lUvUsgF83JUszCWiWQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V01:K0:B/jmqWhaaxM=:0omK5ygY3KGwvd+JHudca/ pY0aFzmft66yDkPVIsTh90FxLDmBniiAo7I4vJTPYD2iHQpmXHlV/k4CskSVLaqguyCrYCFrw gIRwPcRzr5SA7r2lFnKNrudvi6sy/GH6gQdYmG2Acr9ke/abwFexUtBg5x2IeYoduCs/2T5dP TnOG9rBujjbe2D7YC6Dh2sEk129n/+19Onqe0zmHzaV77KZveAiusyh/5uu2zDs4nqaCqLG3v BwajGTdtGB/uuH0/Kfi3AZwW41YA9bt++xsSKAJopzPvY1piNCKaC4ojWT7ar3xRYOXKIfF6U XgQNVY1DqU7LtHEPX2rb3SoeuPx7jrV3RWppMtRNmp+C0mVYmnGjMn7d/2MNgrghzc4QpGJXd vhkqOjsfrhJdFHPHdHLWOv/npuGxZ0eyzaPJgZiagEDLbop6dtlH1Zf3c0A3SfZZPaCuws5bS No3xnTODHMyUKNVVCbYmLZEOs3R6gG+8Okn2kZkNSVBQfpjwT57sf2jVKP4FKG8lvRcy8L18w idkT5hOiPll9z2IyRc7+yjgwH6Ghp70hjH2um7CUEH51UOAC5QFIL/LAkjlxLPUC7FJJXXcvS vxhTklvhzTtOP+ZyLWlvhTkG1h3IQKdCQ8Vlg1sDDQQ3hadvD4uAEURTVDo6UC7F6uQtpa/El xfo2Yq2IwVVHP5X3kdyQbDfx9axR1h1x7z2Ik1r4GcPKOcMbRiPQNgMZYhLTe09CtljdAPWhL KyFHWTMj4CJ1zq1TevMYD9QI7+0u4ex6PN826/2HBMd7NAm13nEfEVcZ9AD//R+2+2p/U7+1Q 8E302CB40iBgr6ovITMhlCIgpDy8avx/wNHnnzPBpmvHguuVec= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 31240-done Cc: 31240-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> Please close bug#31240 if nothing else remains to be done. > > Is this something I should do? (If so, how?) By replying to 31240-done@debbugs.gnu.org as I'm trying to do right now. BTW, did you look into Stefan's pretensions? In particular his remark BTW, your "width" is computed AFAICT as (- (overlay-end (car mouse-drag-and-drop-overlays)) (overlay-start (car mouse-drag-and-drop-overlays))) which is a char-distance and not a column-distance (big difference in the presence of TABs and double-width chars). sounds worthy of examination. martin From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 19 08:53:24 2018 Received: (at 31240-done) by debbugs.gnu.org; 19 Oct 2018 12:53:24 +0000 Received: from localhost ([127.0.0.1]:58251 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gDUHM-0000Ip-KN for submit@debbugs.gnu.org; Fri, 19 Oct 2018 08:53:24 -0400 Received: from mail-lf1-f45.google.com ([209.85.167.45]:42861) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gDUHJ-0000Ia-SR for 31240-done@debbugs.gnu.org; Fri, 19 Oct 2018 08:53:22 -0400 Received: by mail-lf1-f45.google.com with SMTP id s10-v6so25123309lfc.9 for <31240-done@debbugs.gnu.org>; Fri, 19 Oct 2018 05:53:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9h4izKhmjV+E10TJL69bLBdCHZS7+/japcQO0lc/WxU=; b=bNQO8+rSYl7nxOyfOn+176gz7NjMyGUF49p9uxoLgB7IgUU6zokMm1QuePQyBdgBVu l0NnLvsv9cIBXQOIKHOR51J/kMxw9DeN41Qvia7aF1WUdS6PCuwGFbBwH8MMaq++St/0 4e2MHNxMySb+mktnfN4wbV5d8sz/nhOrRMiINvSNXUESC6CEu2Mqo9ghz4DZN8waggPk g5hZvgq0wlhXZW9eXL+le8ZDZPsB1V4Qq6oDk2JkGUk/7hORqmavpZ0AC0Gjbv2100g5 dzboY++i4fTXJGqvkGs9SQ2Uwv3CizpGKW9uXqGvAl5ejb5LUCVmBUYgrrmLlz+9AZrM yjuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9h4izKhmjV+E10TJL69bLBdCHZS7+/japcQO0lc/WxU=; b=dZ6zt6JzkfDmndoMHQxAqEMKyZ7hTsc6qXlAuHDiWPX83fycI7YrwwAH+F3DoCJH/z v2Bpl5G4pRtGr9IeMVwG5JqN6qMb/uFTED3I5fNaDqaY9O9dEgQNSH+3YSB0QKz803ZL BjzhLKfC3cvjRzkRNnMP4EOaV4RdqgfYvl6s2PzX+me7YceFPbzLyJYXkxmID7JRQGf/ FzYgxBN4s23vq6c0iKulH2UQ59ypxJEpLobfKTLS9ZO4+HCU9fM6v4OV49bRolNMnNT5 h2lByq3xywcGa1ZN1XktXCVyr09ZDo6j8LZ5zdX786OlFxrFZs5aPU+Zd3YBNeytOnvp ydnQ== X-Gm-Message-State: ABuFfohw+prpNUqznFe8ry67GNCwxQOcq/d3FRNnfnnrTV5L7GTkUz63 Jbdg8ky/KxpIvGj4Nn8mA3KyH7b7nEf9DL6KRf4= X-Google-Smtp-Source: ACcGV62ZTHjsXrCy/PpSCVxjP4x9tRKgRYVCODfN5M+gnGI6DmTTI4k+/CeI/IFI2VGXj1ZtRee1dt5gaSlqXrOWySM= X-Received: by 2002:a19:9e54:: with SMTP id h81-v6mr2787385lfe.155.1539953595914; Fri, 19 Oct 2018 05:53:15 -0700 (PDT) MIME-Version: 1.0 References: <5BB8EC23.1040303@gmx.at> <5BB9A4E5.3070308@gmx.at> <20181008.192544.1387561894315194511.tkk@misasa.okayama-u.ac.jp> <5BBC5C25.8080002@gmx.at> <5BBD9A08.3090707@gmx.at> <5BC05F09.40007@gmx.at> <5BC1AA69.5010304@gmx.at> <5BC4481F.4060107@gmx.at> <5BC6E48F.201@gmx.at> <5BC98A89.3040509@gmx.at> In-Reply-To: <5BC98A89.3040509@gmx.at> From: Federico Tedin Date: Fri, 19 Oct 2018 09:53:04 -0300 Message-ID: Subject: Re: bug#31240: 26.1; mouse-save-then-kill does not kill rectangles To: martin rudalics Content-Type: multipart/alternative; boundary="0000000000000e1e1a05789463da" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31240-done Cc: 31240-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000000e1e1a05789463da Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Martin, I=E2=80=99ve been searching for Stefan=E2=80=99s message and I am u= nable to find it in the bug=E2=80=99s thread. I=E2=80=99m also subscribed to emacs-devel bu= t wasn=E2=80=99t able to find it there either. From what you mentioned, however, I can see the mistake of using overlays when the region is rectangular. To propose a fix should I file a new bug report, or send an email to emacs-devel? Thanks. --0000000000000e1e1a05789463da Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Martin, I=E2=80=99ve been searching for Stefan=E2=80=99s = message and I am unable to find it in the bug=E2=80=99s thread.=C2=A0 I=E2= =80=99m also subscribed to emacs-devel but wasn=E2=80=99t able to find it t= here either. From what you mentioned, however, I can see the mistake of usi= ng overlays when the region is rectangular. To propose a fix should I file = a new bug report, or send an email to emacs-devel?=C2=A0 Thanks.
--0000000000000e1e1a05789463da-- From unknown Sun Jun 22 11:42:35 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 17 Nov 2018 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator