GNU bug report logs - #31239
Make alsa find its plugins

Previous Next

Full log

Message #8 received at 31239 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 31239 <at> debbugs.gnu.org
Subject: Re: [bug#31239] Make alsa find its plugins
Date: Thu, 17 May 2018 08:01:43 +0200

[Message part 1 (text/plain, inline)]

Hi Julien,

good idea!

The indentation in the patch files is off (alsa-lib uses tabs in its source code).

Also, what is 0001-Add-support-for-a-ALSA_PLUGIN_DIR-environment-variab.patch
embedded in this patch for?  Maybe for upstream?  Nice :)

You already patch the individual files in alsa-lib.

Note: It would be possible to use

++      char* plugdir = getenv("ALSA_PLUGIN_DIR") ?: ALSA_PLUGIN_DIR;

instead of

++      char* plugdir = ALSA_PLUGIN_DIR;
++        char* envplugdir = getenv("ALSA_PLUGIN_DIR");
++        if(envplugdir != NULL)
++            plugdir = envplugdir;

(especially since it's repeated multiple times) but maybe that's too obscure.

So LGTM except for the indentation and extra patch file!

[Message part 2 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.