GNU bug report logs - #31239
Make alsa find its plugins

Previous Next

Full log

Message #13 received at 31239-done <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: 31239-done <at> debbugs.gnu.org
Subject: Re: [bug#31239] Make alsa find its plugins
Date: Sun, 27 May 2018 19:07:26 +0200

[Message part 1 (text/plain, inline)]

Le Thu, 17 May 2018 08:01:43 +0200,
Danny Milosavljevic <dannym <at> scratchpost.org> a écrit :

> Hi Julien,
> 
> good idea!
> 
> The indentation in the patch files is off (alsa-lib uses tabs in its
> source code).
> 
> Also, what is
> 0001-Add-support-for-a-ALSA_PLUGIN_DIR-environment-variab.patch
> embedded in this patch for?  Maybe for upstream?  Nice :)
> 
> You already patch the individual files in alsa-lib.
> 
> Note: It would be possible to use
> 
> ++      char* plugdir = getenv("ALSA_PLUGIN_DIR") ?: ALSA_PLUGIN_DIR;
> 
> instead of
> 
> ++      char* plugdir = ALSA_PLUGIN_DIR;
> ++        char* envplugdir = getenv("ALSA_PLUGIN_DIR");
> ++        if(envplugdir != NULL)
> ++            plugdir = envplugdir;
> 
> (especially since it's repeated multiple times) but maybe that's too
> obscure.
> 
> So LGTM except for the indentation and extra patch file!

Pushed as 2101cc3fb691f443b830fdf5f846ded5fa018739 on core-updates.

[Message part 2 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.