GNU bug report logs - #31237
[PATCH] gnu: Add runc.

Previous Next

Package: guix-patches;

Reported by: 宋文武 <iyzsong <at> member.fsf.org>

Date: Sun, 22 Apr 2018 13:00:01 UTC

Severity: normal

Tags: patch

Done: iyzsong <at> member.fsf.org (宋文武)

Bug is archived. No further changes may be made.

Full log


Message #11 received at 31237 <at> debbugs.gnu.org (full text, mbox):

From: Nils Gillmann <ng0 <at> n0.is>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 宋文武 <iyzsong <at> member.fsf.org>, 31237 <at> debbugs.gnu.org
Subject: Re: [bug#31237] [PATCH] gnu: Add runc.
Date: Sun, 22 Apr 2018 23:06:03 +0000
Ludovic Courtès transcribed 1.2K bytes:
> Hello,
> 
> 宋文武 <iyzsong <at> member.fsf.org> skribis:
> 
> > * gnu/packages/virtualization.scm (runc): New variable.
> 
> Nice!
> 
> > +(define-public runc
> > +  (package
> > +    (name "runc")
> > +    (version "1.0.0-rc5")
> 
> If the actual release is going to be out soon, I’d be in favor of
> waiting for it; an RC doesn’t sound great.  WDYT?

What I wanted to comment earlier from my experience packaging this:
I was advised to follow the docker suggestions, where the dependency
versions are known by recommended commit.

> > +    (build-system gnu-build-system)
> 
> Would ‘go-build-system’ work better?  Or is it something of a hybrid
> (apparently it has makefiles)?

Same question here, since my runc package so far (without testing) just builds,
with go-build-system.

> > +    (arguments
> > +     '(#:tests? #f                      ; FIXME: 20/139 tests fail.
> 
> Have you looked a bit into them, just to see if it’s one of the usual
> things (/bin/sh, networking, etc.) or if it’s more involved?
> 
> > +               (invoke "make"))))
> 
> Perhaps honor (parallel-job-count).
> 
> > +    (synopsis "Open container initiative runtime")
> > +    (home-page "https://www.opencontainers.org/")
> > +    (description
> > +     "@command{runc} is a command line client for running applications
> > +packaged according to the Open Container Initiative (OCI) format and is a
>                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
> An @uref would be nice.  :-)
> 
> Thanks!
> 
> Ludo’.
> 
> 
> 




This bug report was last modified 7 years and 29 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.