From unknown Sat Jun 21 03:16:30 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#31237 <31237@debbugs.gnu.org> To: bug#31237 <31237@debbugs.gnu.org> Subject: Status: [PATCH] gnu: Add runc. Reply-To: bug#31237 <31237@debbugs.gnu.org> Date: Sat, 21 Jun 2025 10:16:30 +0000 retitle 31237 [PATCH] gnu: Add runc. reassign 31237 guix-patches submitter 31237 =E5=AE=8B=E6=96=87=E6=AD=A6 severity 31237 normal tag 31237 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 22 08:59:14 2018 Received: (at submit) by debbugs.gnu.org; 22 Apr 2018 12:59:14 +0000 Received: from localhost ([127.0.0.1]:35485 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fAEaC-0002rr-6m for submit@debbugs.gnu.org; Sun, 22 Apr 2018 08:59:14 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45210) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fAEaA-0002rY-Rh for submit@debbugs.gnu.org; Sun, 22 Apr 2018 08:59:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fAEa4-0005O6-96 for submit@debbugs.gnu.org; Sun, 22 Apr 2018 08:59:01 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:51689) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fAEa4-0005O0-6U for submit@debbugs.gnu.org; Sun, 22 Apr 2018 08:59:00 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36143) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fAEa2-000843-Ky for guix-patches@gnu.org; Sun, 22 Apr 2018 08:58:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fAEZz-0005Im-Eo for guix-patches@gnu.org; Sun, 22 Apr 2018 08:58:58 -0400 Received: from rezeros.cc ([2001:19f0:7001:2f3e:5400:ff:fe84:e55d]:43658) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fAEZz-0005Ga-07 for guix-patches@gnu.org; Sun, 22 Apr 2018 08:58:55 -0400 Received: from localhost (118.114.231.92 [118.114.231.92]) by rezeros.cc (OpenSMTPD) with ESMTPSA id 099a0287 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Sun, 22 Apr 2018 12:58:14 +0000 (UTC) Received: from localhost.localdomain (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 9fbf4456; Sun, 22 Apr 2018 12:58:45 +0000 (UTC) From: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= To: guix-patches@gnu.org Subject: [PATCH] gnu: Add runc. Date: Sun, 22 Apr 2018 20:58:44 +0800 Message-Id: <20180422125844.15227-1-iyzsong@member.fsf.org> X-Mailer: git-send-email 2.14.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit Cc: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/virtualization.scm (runc): New variable. --- gnu/packages/virtualization.scm | 54 ++++++++++++++++++++++++++++++++++++++++- 1 file changed, 53 insertions(+), 1 deletion(-) diff --git a/gnu/packages/virtualization.scm b/gnu/packages/virtualization.scm index 55ace5a56..e6d52c870 100644 --- a/gnu/packages/virtualization.scm +++ b/gnu/packages/virtualization.scm @@ -8,6 +8,7 @@ ;;; Copyright © 2017 Rutger Helling ;;; Copyright © 2017, 2018 Tobias Geerinckx-Rice ;;; Copyright © 2018 Danny Milosavljevic +;;; Copyright © 2018 Sou Bunnbu ;;; ;;; This file is part of GNU Guix. ;;; @@ -41,6 +42,7 @@ #:use-module (gnu packages gl) #:use-module (gnu packages glib) #:use-module (gnu packages gnome) + #:use-module (gnu packages golang) #:use-module (gnu packages gtk) #:use-module (gnu packages image) #:use-module (gnu packages libusb) @@ -65,7 +67,8 @@ #:use-module (guix build-system gnu) #:use-module (guix build-system python) #:use-module (guix download) - #:use-module ((guix licenses) #:select (gpl2 gpl2+ gpl3+ lgpl2.1 lgpl2.1+)) + #:use-module ((guix licenses) #:select (gpl2 gpl2+ gpl3+ lgpl2.1 lgpl2.1+ + asl2.0)) #:use-module (guix packages) #:use-module (guix utils) #:use-module (srfi srfi-1)) @@ -772,3 +775,52 @@ monitor/GPU.") ;; This package requires SSE instructions. (supported-systems '("i686-linux" "x86_64-linux")) (license gpl2+))) + +(define-public runc + (package + (name "runc") + (version "1.0.0-rc5") + (source (origin + (method url-fetch) + (uri (string-append + "https://github.com/opencontainers/runc/releases/" + "download/v" version "/runc.tar.xz")) + (sha256 + (base32 + "081avdzwnqpk368wbaihlzsypaxpj42d7699h7jgp0fks14x4103")))) + (build-system gnu-build-system) + (arguments + '(#:tests? #f ; FIXME: 20/139 tests fail. + #:test-target "localunittest" + #:phases + (modify-phases %standard-phases + (delete 'configure) ; no 'configure' script + (replace 'build + (lambda _ + (let* ((gopath (string-append (getenv "TMPDIR") "/go")) + (srcdir (string-append + gopath "/src/github.com/opencontainers/runc"))) + (setenv "GOPATH" gopath) + (mkdir-p (dirname srcdir)) + (copy-recursively (getcwd) srcdir) + (chdir srcdir) + ;; XXX: requires 'go-md2man'. + ;; (invoke "make man") + (invoke "make")))) + (replace 'install + (lambda* (#:key outputs #:allow-other-keys) + (let ((out (assoc-ref outputs "out"))) + (invoke "make" "install" "install-bash" + (string-append "PREFIX=" out)))))))) + (native-inputs + `(("go" ,go) + ("pkg-config" ,pkg-config))) + (inputs + `(("libseccomp" ,libseccomp))) + (synopsis "Open container initiative runtime") + (home-page "https://www.opencontainers.org/") + (description + "@command{runc} is a command line client for running applications +packaged according to the Open Container Initiative (OCI) format and is a +compliant implementation of the Open Container Initiative specification.") + (license asl2.0))) -- 2.13.3 From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 22 18:08:29 2018 Received: (at 31237) by debbugs.gnu.org; 22 Apr 2018 22:08:29 +0000 Received: from localhost ([127.0.0.1]:36185 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fAN9p-0000ge-JO for submit@debbugs.gnu.org; Sun, 22 Apr 2018 18:08:29 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:50814) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fAN9o-0000gX-0T for 31237@debbugs.gnu.org; Sun, 22 Apr 2018 18:08:28 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 64E4012EE0; Mon, 23 Apr 2018 00:08:27 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BneNtNuQcfBf; Mon, 23 Apr 2018 00:08:26 +0200 (CEST) Received: from ribbon (unknown [IPv6:2a01:e0a:1d:7270:af76:b9b:ca24:c465]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 2E51911D04; Mon, 23 Apr 2018 00:08:26 +0200 (CEST) From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: =?utf-8?B?5a6L5paH5q2m?= Subject: Re: [bug#31237] [PATCH] gnu: Add runc. References: <20180422125844.15227-1-iyzsong@member.fsf.org> Date: Mon, 23 Apr 2018 00:08:25 +0200 In-Reply-To: <20180422125844.15227-1-iyzsong@member.fsf.org> (=?utf-8?B?IuWui+aWh+atpiIncw==?= message of "Sun, 22 Apr 2018 20:58:44 +0800") Message-ID: <877eoygahy.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 31237 Cc: 31237@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hello, =E5=AE=8B=E6=96=87=E6=AD=A6 skribis: > * gnu/packages/virtualization.scm (runc): New variable. Nice! > +(define-public runc > + (package > + (name "runc") > + (version "1.0.0-rc5") If the actual release is going to be out soon, I=E2=80=99d be in favor of waiting for it; an RC doesn=E2=80=99t sound great. WDYT? > + (build-system gnu-build-system) Would =E2=80=98go-build-system=E2=80=99 work better? Or is it something of= a hybrid (apparently it has makefiles)? > + (arguments > + '(#:tests? #f ; FIXME: 20/139 tests fail. Have you looked a bit into them, just to see if it=E2=80=99s one of the usu= al things (/bin/sh, networking, etc.) or if it=E2=80=99s more involved? > + (invoke "make")))) Perhaps honor (parallel-job-count). > + (synopsis "Open container initiative runtime") > + (home-page "https://www.opencontainers.org/") > + (description > + "@command{runc} is a command line client for running applications > +packaged according to the Open Container Initiative (OCI) format and is a ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^ An @uref would be nice. :-) Thanks! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 22 19:05:43 2018 Received: (at 31237) by debbugs.gnu.org; 22 Apr 2018 23:05:43 +0000 Received: from localhost ([127.0.0.1]:36267 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fAO3D-00023i-6i for submit@debbugs.gnu.org; Sun, 22 Apr 2018 19:05:43 -0400 Received: from static.195.114.201.195.clients.your-server.de ([195.201.114.195]:51510 helo=conspiracy.of.n0.is) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fAO39-00023X-Bz for 31237@debbugs.gnu.org; Sun, 22 Apr 2018 19:05:40 -0400 Received: by conspiracy.of.n0.is (OpenSMTPD) with ESMTPSA id 585f9ba9 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Sun, 22 Apr 2018 23:05:37 +0000 (UTC) Date: Sun, 22 Apr 2018 23:06:03 +0000 From: Nils Gillmann To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#31237] [PATCH] gnu: Add runc. Message-ID: <20180422230603.gm2u5637w3rkdpvc@abyayala> References: <20180422125844.15227-1-iyzsong@member.fsf.org> <877eoygahy.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <877eoygahy.fsf@gnu.org> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 31237 Cc: =?utf-8?B?5a6L5paH5q2m?= , 31237@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Ludovic Courtès transcribed 1.2K bytes: > Hello, > > 宋文武 skribis: > > > * gnu/packages/virtualization.scm (runc): New variable. > > Nice! > > > +(define-public runc > > + (package > > + (name "runc") > > + (version "1.0.0-rc5") > > If the actual release is going to be out soon, I’d be in favor of > waiting for it; an RC doesn’t sound great. WDYT? What I wanted to comment earlier from my experience packaging this: I was advised to follow the docker suggestions, where the dependency versions are known by recommended commit. > > + (build-system gnu-build-system) > > Would ‘go-build-system’ work better? Or is it something of a hybrid > (apparently it has makefiles)? Same question here, since my runc package so far (without testing) just builds, with go-build-system. > > + (arguments > > + '(#:tests? #f ; FIXME: 20/139 tests fail. > > Have you looked a bit into them, just to see if it’s one of the usual > things (/bin/sh, networking, etc.) or if it’s more involved? > > > + (invoke "make")))) > > Perhaps honor (parallel-job-count). > > > + (synopsis "Open container initiative runtime") > > + (home-page "https://www.opencontainers.org/") > > + (description > > + "@command{runc} is a command line client for running applications > > +packaged according to the Open Container Initiative (OCI) format and is a > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^ > An @uref would be nice. :-) > > Thanks! > > Ludo’. > > > From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 22 23:26:04 2018 Received: (at 31237) by debbugs.gnu.org; 23 Apr 2018 03:26:05 +0000 Received: from localhost ([127.0.0.1]:36342 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fAS77-00082K-Hk for submit@debbugs.gnu.org; Sun, 22 Apr 2018 23:26:04 -0400 Received: from rezeros.cc ([45.76.207.221]:38558) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fAS75-00082A-H9 for 31237@debbugs.gnu.org; Sun, 22 Apr 2018 23:26:00 -0400 Received: from localhost (118.114.231.92 [118.114.231.92]) by rezeros.cc (OpenSMTPD) with ESMTPSA id 2c5bd6cc (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Mon, 23 Apr 2018 03:25:21 +0000 (UTC) Received: from gift (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 873d4894; Mon, 23 Apr 2018 03:25:51 +0000 (UTC) From: iyzsong@member.fsf.org (=?utf-8?B?5a6L5paH5q2m?=) To: Nils Gillmann Subject: Re: [bug#31237] [PATCH] gnu: Add runc. References: <20180422125844.15227-1-iyzsong@member.fsf.org> <877eoygahy.fsf@gnu.org> <20180422230603.gm2u5637w3rkdpvc@abyayala> Date: Mon, 23 Apr 2018 11:25:51 +0800 In-Reply-To: <20180422230603.gm2u5637w3rkdpvc@abyayala> (Nils Gillmann's message of "Sun, 22 Apr 2018 23:06:03 +0000") Message-ID: <87vacizjr4.fsf@member.fsf.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.1 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Nils Gillmann writes: > Ludovic Courtès transcribed 1.2K bytes: >> Hello, >> >> 宋文武 skribis: >> >> > * gnu/packages/virtualization.scm (runc): New variable. >> >> Nice! [...] Content analysis details: (1.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.1 FROM_EXCESS_BASE64 From: base64 encoded unnecessarily X-Debbugs-Envelope-To: 31237 Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , 31237@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.1 (/) Nils Gillmann writes: > Ludovic Court=C3=A8s transcribed 1.2K bytes: >> Hello, >>=20 >> =E5=AE=8B=E6=96=87=E6=AD=A6 skribis: >>=20 >> > * gnu/packages/virtualization.scm (runc): New variable. >>=20 >> Nice! >>=20 >> > +(define-public runc >> > + (package >> > + (name "runc") >> > + (version "1.0.0-rc5") >>=20 >> If the actual release is going to be out soon, I=E2=80=99d be in favor of >> waiting for it; an RC doesn=E2=80=99t sound great. WDYT? Sure, but it's not clear to me when the 1.0.0 release will be out... > > What I wanted to comment earlier from my experience packaging this: > I was advised to follow the docker suggestions, where the dependency > versions are known by recommended commit. Okay, I have some ideas to use runc directly with rootfs bulit by guix, I haven't looked into docker yet. > >> > + (build-system gnu-build-system) >>=20 >> Would =E2=80=98go-build-system=E2=80=99 work better? Or is it something= of a hybrid >> (apparently it has makefiles)? > > Same question here, since my runc package so far (without testing) just b= uilds, > with go-build-system. Okay, I have to modify the unpack phase for the tarball.=20 > >> > + (arguments >> > + '(#:tests? #f ; FIXME: 20/139 tests fail. >>=20 >> Have you looked a bit into them, just to see if it=E2=80=99s one of the = usual >> things (/bin/sh, networking, etc.) or if it=E2=80=99s more involved? No I haven't, some fails are: --- FAIL: TestFactoryNewTmpfs (0.00s) factory_linux_test.go:87: operation not permitted FAIL github.com/opencontainers/runc/libcontainer 0.047s ? github.com/opencontainers/runc/libcontainer/apparmor [no test files] --- FAIL: TestInvalidCgroupPath (0.00s) apply_raw_test.go:16: couldn't get cgroup root: mountpoint for cgroup not = found apply_raw_test.go:25: couldn't get cgroup data: mountpoint for cgroup not = found panic: runtime error: invalid memory address or nil pointer dereference [re= covered] --- FAIL: TestValidateRootlessMountUid (0.00s) rootless_test.go:96: Expected error to not occur when uid=3D not set in mo= unt options: rootfs (/var) does not exist rootless_test.go:106: Expected error to not occur when setting uid=3D0 in = mount options: rootfs (/var) does not exist rootless_test.go:112: Expected error to not occur when setting uid=3D2 in = mount options and UidMapping[0].size is 10 --- FAIL: TestValidateValidSysctl (0.00s) validator_test.go:229: Expected error to not occur with {net.ctl=3Dctl} bu= t got: "rootfs (/var) does not exist" validator_test.go:229: Expected error to not occur with {kernel.msgmax=3Dc= tl} but got: "rootfs (/var) does not exist" validator_test.go:229: Expected error to not occur with {fs.mqueue.ctl=3Dc= tl} but got: "rootfs (/var) does not exist" --- FAIL: TestNsenterValidPaths (0.01s) nsenter_test.go:65: nsenter exits with a non-zero exit status Look like it need /var, network namespace and other things? But thoes are unittest (runc also has integrationtest target)... Need more investment. >>=20 >> > + (invoke "make")))) >>=20 >> Perhaps honor (parallel-job-count). Thanks for the tip! Now I think it's not needed, since the target only run one 'go build' command, so there is nothing to be executed parallel... >>=20 >> > + (synopsis "Open container initiative runtime") >> > + (home-page "https://www.opencontainers.org/") >> > + (description >> > + "@command{runc} is a command line client for running applications >> > +packaged according to the Open Container Initiative (OCI) format and = is a >> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^ >> An @uref would be nice. :-) Okay. Pushed, thanks ludo and ng0 for the review! From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 23 05:41:46 2018 Received: (at 31237) by debbugs.gnu.org; 23 Apr 2018 09:41:46 +0000 Received: from localhost ([127.0.0.1]:36498 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fAXyj-000268-W8 for submit@debbugs.gnu.org; Mon, 23 Apr 2018 05:41:46 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:54340) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fAXyi-00025z-6w for 31237@debbugs.gnu.org; Mon, 23 Apr 2018 05:41:44 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 2224C12B81; Mon, 23 Apr 2018 11:41:43 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id z2PXolYYUyN3; Mon, 23 Apr 2018 11:41:41 +0200 (CEST) Received: from ribbon (unknown [193.50.110.139]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 98403122F5; Mon, 23 Apr 2018 11:41:41 +0200 (CEST) From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: iyzsong@member.fsf.org (=?utf-8?B?5a6L5paH5q2m?=) Subject: Re: [bug#31237] [PATCH] gnu: Add runc. References: <20180422125844.15227-1-iyzsong@member.fsf.org> <877eoygahy.fsf@gnu.org> <20180422230603.gm2u5637w3rkdpvc@abyayala> <87vacizjr4.fsf@member.fsf.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 4 =?utf-8?Q?Flor=C3=A9al?= an 226 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 23 Apr 2018 11:41:41 +0200 In-Reply-To: <87vacizjr4.fsf@member.fsf.org> (=?utf-8?B?IuWui+aWh+atpiIn?= =?utf-8?B?cw==?= message of "Mon, 23 Apr 2018 11:25:51 +0800") Message-ID: <87fu3m45uy.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 31237 Cc: Nils Gillmann , 31237@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hello, iyzsong@member.fsf.org (=E5=AE=8B=E6=96=87=E6=AD=A6) skribis: > No I haven't, some fails are: > > --- FAIL: TestFactoryNewTmpfs (0.00s) > factory_linux_test.go:87: operation not permitted > > FAIL github.com/opencontainers/runc/libcontainer 0.047s > ? github.com/opencontainers/runc/libcontainer/apparmor [no test files] > > --- FAIL: TestInvalidCgroupPath (0.00s) > apply_raw_test.go:16: couldn't get cgroup root: mountpoint for cgroup no= t found > apply_raw_test.go:25: couldn't get cgroup data: mountpoint for cgroup no= t found > panic: runtime error: invalid memory address or nil pointer dereference [= recovered] > > --- FAIL: TestValidateRootlessMountUid (0.00s) > rootless_test.go:96: Expected error to not occur when uid=3D not set in = mount options: rootfs (/var) does not exist > rootless_test.go:106: Expected error to not occur when setting uid=3D0 i= n mount options: rootfs (/var) does not exist > rootless_test.go:112: Expected error to not occur when setting uid=3D2 i= n mount options and UidMapping[0].size is 10 > > --- FAIL: TestValidateValidSysctl (0.00s) > validator_test.go:229: Expected error to not occur with {net.ctl=3Dctl} = but got: "rootfs (/var) does not exist" > validator_test.go:229: Expected error to not occur with {kernel.msgmax= =3Dctl} but got: "rootfs (/var) does not exist" > validator_test.go:229: Expected error to not occur with {fs.mqueue.ctl= =3Dctl} but got: "rootfs (/var) does not exist" > > --- FAIL: TestNsenterValidPaths (0.01s) > nsenter_test.go:65: nsenter exits with a non-zero exit status > > > Look like it need /var, network namespace and other things? But thoes > are unittest (runc also has integrationtest target)... Need more > investment. Right. For now I think we could skip all the tests above, with a comment explaining the reason (/var, cgroups, and apparmor unavailable in the build environment.) Thank you! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 25 21:40:06 2018 Received: (at 31237-done) by debbugs.gnu.org; 26 Apr 2018 01:40:06 +0000 Received: from localhost ([127.0.0.1]:39777 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fBVtF-000887-QY for submit@debbugs.gnu.org; Wed, 25 Apr 2018 21:40:06 -0400 Received: from rezeros.cc ([45.76.207.221]:38926) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fBVtD-00087l-Em for 31237-done@debbugs.gnu.org; Wed, 25 Apr 2018 21:40:04 -0400 Received: from localhost (110.184.85.172 [110.184.85.172]) by rezeros.cc (OpenSMTPD) with ESMTPSA id c2242a9d (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Thu, 26 Apr 2018 01:39:23 +0000 (UTC) Received: from gift (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 9e0a42d2; Thu, 26 Apr 2018 01:39:58 +0000 (UTC) From: iyzsong@member.fsf.org (=?utf-8?B?5a6L5paH5q2m?=) To: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [bug#31237] [PATCH] gnu: Add runc. References: <20180422125844.15227-1-iyzsong@member.fsf.org> <877eoygahy.fsf@gnu.org> <20180422230603.gm2u5637w3rkdpvc@abyayala> <87vacizjr4.fsf@member.fsf.org> <87fu3m45uy.fsf@gnu.org> Date: Thu, 26 Apr 2018 09:39:58 +0800 In-Reply-To: <87fu3m45uy.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Mon, 23 Apr 2018 11:41:41 +0200") Message-ID: <87po2mg2z5.fsf@member.fsf.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.1 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: ludo@gnu.org (Ludovic Courtès) writes: > Hello, > > iyzsong@member.fsf.org (宋文武) skribis: > >> No I haven't, some fails are: >> >> --- FAIL: TestFactoryNewTmpfs (0.00s) >> factory_linux_test.go:87: operation not permitted >> >> FAIL github.com/opencontainers/runc/libcontainer 0.047s >> ? github.com/opencontainers/runc/libcontainer/apparmor [no test files] >> >> --- FAIL: TestInvalidCgroupPath (0.00s) >> apply_raw_test.go:16: couldn't get cgroup root: mountpoint for >> cgroup not found >> apply_raw_test.go:25: couldn't get cgroup data: mountpoint for >> cgroup not found >> panic: runtime error: invalid memory address or nil pointer dereference [recovered] >> >> --- FAIL: TestValidateRootlessMountUid (0.00s) >> rootless_test.go:96: Expected error to not occur when uid= not >> set in mount options: rootfs (/var) does not exist >> rootless_test.go:106: Expected error to not occur when setting >> uid=0 in mount options: rootfs (/var) does not exist >> rootless_test.go:112: Expected error to not occur when setting >> uid=2 in mount options and UidMapping[0].size is 10 >> >> --- FAIL: TestValidateValidSysctl (0.00s) >> validator_test.go:229: Expected error to not occur with >> {net.ctl=ctl} but got: "rootfs (/var) does not exist" >> validator_test.go:229: Expected error to not occur with >> {kernel.msgmax=ctl} but got: "rootfs (/var) does not exist" >> validator_test.go:229: Expected error to not occur with >> {fs.mqueue.ctl=ctl} but got: "rootfs (/var) does not exist" >> >> --- FAIL: TestNsenterValidPaths (0.01s) >> nsenter_test.go:65: nsenter exits with a non-zero exit status >> >> >> Look like it need /var, network namespace and other things? But thoes >> are unittest (runc also has integrationtest target)... Need more >> investment. > > Right. For now I think we could skip all the tests above, with a > comment explaining the reason (/var, cgroups, and apparmor unavailable > in the build environment.) > [...] Content analysis details: (1.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.1 FROM_EXCESS_BASE64 From: base64 encoded unnecessarily X-Debbugs-Envelope-To: 31237-done Cc: 31237-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.1 (/) ludo@gnu.org (Ludovic Court=C3=A8s) writes: > Hello, > > iyzsong@member.fsf.org (=E5=AE=8B=E6=96=87=E6=AD=A6) skribis: > >> No I haven't, some fails are: >> >> --- FAIL: TestFactoryNewTmpfs (0.00s) >> factory_linux_test.go:87: operation not permitted >> >> FAIL github.com/opencontainers/runc/libcontainer 0.047s >> ? github.com/opencontainers/runc/libcontainer/apparmor [no test files] >> >> --- FAIL: TestInvalidCgroupPath (0.00s) >> apply_raw_test.go:16: couldn't get cgroup root: mountpoint for >> cgroup not found >> apply_raw_test.go:25: couldn't get cgroup data: mountpoint for >> cgroup not found >> panic: runtime error: invalid memory address or nil pointer dereference = [recovered] >> >> --- FAIL: TestValidateRootlessMountUid (0.00s) >> rootless_test.go:96: Expected error to not occur when uid=3D not >> set in mount options: rootfs (/var) does not exist >> rootless_test.go:106: Expected error to not occur when setting >> uid=3D0 in mount options: rootfs (/var) does not exist >> rootless_test.go:112: Expected error to not occur when setting >> uid=3D2 in mount options and UidMapping[0].size is 10 >> >> --- FAIL: TestValidateValidSysctl (0.00s) >> validator_test.go:229: Expected error to not occur with >> {net.ctl=3Dctl} but got: "rootfs (/var) does not exist" >> validator_test.go:229: Expected error to not occur with >> {kernel.msgmax=3Dctl} but got: "rootfs (/var) does not exist" >> validator_test.go:229: Expected error to not occur with >> {fs.mqueue.ctl=3Dctl} but got: "rootfs (/var) does not exist" >> >> --- FAIL: TestNsenterValidPaths (0.01s) >> nsenter_test.go:65: nsenter exits with a non-zero exit status >> >> >> Look like it need /var, network namespace and other things? But thoes >> are unittest (runc also has integrationtest target)... Need more >> investment. > > Right. For now I think we could skip all the tests above, with a > comment explaining the reason (/var, cgroups, and apparmor unavailable > in the build environment.) > Done, thank you! From unknown Sat Jun 21 03:16:30 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 24 May 2018 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator