GNU bug report logs - #31236
[PATCH] Fix pre- and post-command-hook errors in term.el

Previous Next

Full log

View this message in rfc822 format

From: Karl Otness <karl <at> karlotness.com>
To: 31236 <at> debbugs.gnu.org
Subject: bug#31236: [PATCH] Fix pre- and post-command-hook errors in term.el
Date: Sat, 21 Apr 2018 23:41:51 -0400

[Message part 1 (text/plain, inline)]

As far as I can tell there isn't an existing bug report for this
issue. It is very minor but I have attached a fix. This affects Emacs
26.1-rc1 `term' and `ansi-term'. In char mode term installs functions
in both pre- and post-command-hooks. After the process exits both of
these hooks produce errors and then are removed by Emacs after
printing a message.

Both of these hooks are re-installed when entering char mode and
removing them if they are not present will do nothing. To produce this
change, I took the remove-hook lines used when entering line mode and
placed them in `term-handle-exit'.

To reproduce the issue in 26.1, M-x term, exit the running process and
execute any command (i.e. move point). In *Messages* there should be
the following lines:

Error in pre-command-hook (term-set-goto-process-mark):
(wrong-type-argument processp nil)
Error in post-command-hook (term-goto-process-mark-maybe):
(wrong-type-argument processp nil)

The error seems to come up from `process-mark'. After this change,
these errors no longer appear as the hooks are removed. I have
attached a patch which applies this change to current master.

Thank you,
Karl

[0001-Fix-pre-and-post-command-hook-errors-in-term.el.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.