From unknown Mon Jun 23 14:58:51 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#31210 <31210@debbugs.gnu.org> To: bug#31210 <31210@debbugs.gnu.org> Subject: Status: Perl graft breakage Reply-To: bug#31210 <31210@debbugs.gnu.org> Date: Mon, 23 Jun 2025 21:58:51 +0000 retitle 31210 Perl graft breakage reassign 31210 guix submitter 31210 Leo Famulari severity 31210 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 18 14:09:08 2018 Received: (at submit) by debbugs.gnu.org; 18 Apr 2018 18:09:08 +0000 Received: from localhost ([127.0.0.1]:59551 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f8rVz-00062J-V2 for submit@debbugs.gnu.org; Wed, 18 Apr 2018 14:09:08 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53124) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f8rVy-00061q-2q for submit@debbugs.gnu.org; Wed, 18 Apr 2018 14:09:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f8rVr-00059c-I2 for submit@debbugs.gnu.org; Wed, 18 Apr 2018 14:09:00 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:52467) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f8rVr-00059E-DL for submit@debbugs.gnu.org; Wed, 18 Apr 2018 14:08:59 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44070) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f8rVq-0007eO-4C for bug-guix@gnu.org; Wed, 18 Apr 2018 14:08:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f8rVm-00056i-2w for bug-guix@gnu.org; Wed, 18 Apr 2018 14:08:58 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:46147) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f8rVl-00056E-IL for bug-guix@gnu.org; Wed, 18 Apr 2018 14:08:54 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id C88CD21AD0; Wed, 18 Apr 2018 14:08:51 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 18 Apr 2018 14:08:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= mesmtp; bh=Se31vEvMAH4lkyo7JWeGkHpb1MHBE7137A4S0V7ruDY=; b=H+vj2 vpmtRahorSKtQyHoqKzAftpgwse2E+ON9FChdyH2xrUzgADdoOOpcS20bTXUblsW FzWf+vqDyKgyvaCCR7E3d+Vck1+0fvGdDAy0cdQYa6OcbXWY4n4PnXRMRoK6H4JX unAIeR4/zEBYf51MLBERlLLGMK+SHr6wW8eZsU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=Se31vEvMAH4lkyo7JWeGkHpb1MHBE 7137A4S0V7ruDY=; b=lYCi5Niry2Hg/5QtYZeJodYgkb/Pv9Dl9i+nsPZCeGqWE 0c3KLpvRFgjtgcJOHoFwQ55NajKJSfFBwGlVCSZ/dSV7+D5rzOZW2NsojHc/+Wi2 /mUNQc20uj7uyJWSHNT2lNGwQqwa/m6hCfKCJYZm1i3vp9Uw3RAZP8ejs57336Rb ++LUHLZhTSU1GA70GxQ4+emjGAQfnS7BsPQ6aXwqJuVbX/fU8Hd62PyV5tllQZ/i MGAJ1C+ZtDfTx6rUy1KVdcxN4S76piEfqNi3m19q/YDsyMCvmv6dzGPJtcNkfeNW gEqvTj2c1TYyTwVh6YEPmg7k0myVxfxAXvjtWAVQg== X-ME-Sender: Received: from localhost (96-90-63-214-static.hfc.comcastbusiness.net [96.90.63.214]) by mail.messagingengine.com (Postfix) with ESMTPA id 60DEF10253 for ; Wed, 18 Apr 2018 14:08:51 -0400 (EDT) Date: Wed, 18 Apr 2018 14:08:50 -0400 From: Leo Famulari To: bug-guix@gnu.org Subject: Perl graft breakage Message-ID: <20180418180850.GA11245@jasmine.lan> References: <20180415153405.5973-1-mbakke@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="IS0zKkzwUGydFO0o" Content-Disposition: inline In-Reply-To: <20180415153405.5973-1-mbakke@fastmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.1 (-----) --IS0zKkzwUGydFO0o Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Apr 15, 2018 at 05:34:05PM +0200, Marius Bakke wrote: > * gnu/packages/perl.scm (perl-5.26.2): New public variable. > (perl)[replacement]: New field. I noticed on my Debian system that this broke rxvt-unicode, and it probably affects other packages as well. The issue is that the full path of libperl.so includes the Perl version number, for example: /gnu/store/...-perl-5.26.1/lib/perl5/5.26.1/x86_64-linux-thread-multi/CORE/libperl.so The RUNPATH of urxvt with the Perl graft includes this bogus path: /gnu/store/ynk3rg3i791i6k7rz2imbyj9wyfjrnrc-perl-5.26.2/lib/perl5/5.26.1/x86_64-linux-thread-multi/CORE Grafting fails to replace the latter instance of the version number, and so lookups fail like this: ------ [...] openat(AT_FDCWD, "/gnu/store/4sqaib7c2dfjv62ivrg9b8wa7bh226la-glibc-2.26.105-g0890d5379c/lib/libperl.so", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory) openat(AT_FDCWD, "/gnu/store/2ifmksc425qcysl5rkxkbv6yrgc1w9cs-gcc-5.5.0-lib/lib/libperl.so", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory) openat(AT_FDCWD, "/gnu/store/95b2fv709zvxdrb38l2w8jd73vz5v5ff-fontconfig-2.12.6/lib/libperl.so", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory) openat(AT_FDCWD, "/gnu/store/4pj266bvxiris0vbvm1j568n1smdj7m8-freetype-2.8.1/lib/libperl.so", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory) openat(AT_FDCWD, "/gnu/store/6n2pn58p6l7v9icg0m3i8kp4wbn8nzl2-libxft-2.3.2/lib/libperl.so", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory) openat(AT_FDCWD, "/gnu/store/7lm90jgm2y00382yqriq4yw1nvb3p7b6-libxrender-0.9.10/lib/libperl.so", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory) openat(AT_FDCWD, "/gnu/store/6x1p96h51dlgpdsmrx3821ixbawbm19l-libx11-1.6.5/lib/libperl.so", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory) openat(AT_FDCWD, "/gnu/store/2ifmksc425qcysl5rkxkbv6yrgc1w9cs-gcc-5.5.0-lib/lib/gcc/x86_64-unknown-linux-gnu/5.5.0/../../../tls/x86_64/x86_64/libperl.so", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory) stat("/gnu/store/2ifmksc425qcysl5rkxkbv6yrgc1w9cs-gcc-5.5.0-lib/lib/gcc/x86_64-unknown-linux-gnu/5.5.0/../../../tls/x86_64/x86_64", 0x7ffd43384b10) = -1 ENOENT (No such file or directory) openat(AT_FDCWD, "/gnu/store/2ifmksc425qcysl5rkxkbv6yrgc1w9cs-gcc-5.5.0-lib/lib/gcc/x86_64-unknown-linux-gnu/5.5.0/../../../tls/x86_64/libperl.so", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory) stat("/gnu/store/2ifmksc425qcysl5rkxkbv6yrgc1w9cs-gcc-5.5.0-lib/lib/gcc/x86_64-unknown-linux-gnu/5.5.0/../../../tls/x86_64", 0x7ffd43384b10) = -1 ENOENT (No such file or directory) openat(AT_FDCWD, "/gnu/store/2ifmksc425qcysl5rkxkbv6yrgc1w9cs-gcc-5.5.0-lib/lib/gcc/x86_64-unknown-linux-gnu/5.5.0/../../../tls/x86_64/libperl.so", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory) stat("/gnu/store/2ifmksc425qcysl5rkxkbv6yrgc1w9cs-gcc-5.5.0-lib/lib/gcc/x86_64-unknown-linux-gnu/5.5.0/../../../tls/x86_64", 0x7ffd43384b10) = -1 ENOENT (No such file or directory) openat(AT_FDCWD, "/gnu/store/2ifmksc425qcysl5rkxkbv6yrgc1w9cs-gcc-5.5.0-lib/lib/gcc/x86_64-unknown-linux-gnu/5.5.0/../../../tls/libperl.so", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory) stat("/gnu/store/2ifmksc425qcysl5rkxkbv6yrgc1w9cs-gcc-5.5.0-lib/lib/gcc/x86_64-unknown-linux-gnu/5.5.0/../../../tls", 0x7ffd43384b10) = -1 ENOENT (No such file or directory) openat(AT_FDCWD, "/gnu/store/2ifmksc425qcysl5rkxkbv6yrgc1w9cs-gcc-5.5.0-lib/lib/gcc/x86_64-unknown-linux-gnu/5.5.0/../../../x86_64/x86_64/libperl.so", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory) stat("/gnu/store/2ifmksc425qcysl5rkxkbv6yrgc1w9cs-gcc-5.5.0-lib/lib/gcc/x86_64-unknown-linux-gnu/5.5.0/../../../x86_64/x86_64", 0x7ffd43384b10) = -1 ENOENT (No such file or directory) openat(AT_FDCWD, "/gnu/store/2ifmksc425qcysl5rkxkbv6yrgc1w9cs-gcc-5.5.0-lib/lib/gcc/x86_64-unknown-linux-gnu/5.5.0/../../../x86_64/libperl.so", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory) stat("/gnu/store/2ifmksc425qcysl5rkxkbv6yrgc1w9cs-gcc-5.5.0-lib/lib/gcc/x86_64-unknown-linux-gnu/5.5.0/../../../x86_64", 0x7ffd43384b10) = -1 ENOENT (No such file or directory) openat(AT_FDCWD, "/gnu/store/2ifmksc425qcysl5rkxkbv6yrgc1w9cs-gcc-5.5.0-lib/lib/gcc/x86_64-unknown-linux-gnu/5.5.0/../../../x86_64/libperl.so", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory) stat("/gnu/store/2ifmksc425qcysl5rkxkbv6yrgc1w9cs-gcc-5.5.0-lib/lib/gcc/x86_64-unknown-linux-gnu/5.5.0/../../../x86_64", 0x7ffd43384b10) = -1 ENOENT (No such file or directory) openat(AT_FDCWD, "/gnu/store/2ifmksc425qcysl5rkxkbv6yrgc1w9cs-gcc-5.5.0-lib/lib/gcc/x86_64-unknown-linux-gnu/5.5.0/../../../libperl.so", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory) stat("/gnu/store/2ifmksc425qcysl5rkxkbv6yrgc1w9cs-gcc-5.5.0-lib/lib/gcc/x86_64-unknown-linux-gnu/5.5.0/../../..", {st_mode=S_IFDIR|0555, st_size=4096, ...}) = 0 openat(AT_FDCWD, "/gnu/store/4sqaib7c2dfjv62ivrg9b8wa7bh226la-glibc-2.26.105-g0890d5379c/lib/libperl.so", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory) writev(2, [{iov_base="urxvt", iov_len=5}, {iov_base=": ", iov_len=2}, {iov_base="error while loading shared libra"..., iov_len=36}, {iov_base=": ", iov_len=2}, {iov_base="libperl.so", iov_len=10}, {iov_base=": ", iov_len=2}, {iov_base="cannot open shared object file", iov_len=30}, {iov_base=": ", iov_len=2}, {iov_base="No such file or directory", iov_len=25}, {iov_base="\n", iov_len=1}], 10urxvt: error while loading shared libraries: libperl.so: cannot open shared object file: No such file or directory ) = 115 exit_group(127) = ? ------ --IS0zKkzwUGydFO0o Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlrXia4ACgkQJkb6MLrK fwgPhRAAypdNkJt0GT2ah1dzZWV5cnb5AajbnG4q2/yoKTGr5iR4KcZzZj7MZA57 LagouZ7X3obi3tQ57ewUafNR66ofn/FNYkpAmv3p3AahXw+dx/1V7+rxNboLwOyC WONdQ0N23zv9UcEluc1U4CzJsRGTdxVUEXb94Kyi4urZXRmyaGWTNPY2CznUx4wI SZ6KY6+4trt6IAsxU4lAd1s6ynR67kZEjhARmM8VMI0xKrguuHP1af/n8jGCjM+5 kOzyDS59FYDSojy2CMSCZbyqO96+a0uxfFvqKzSSu50JEhIA2pYrAWkpAiLQvTI3 y0iaV3kdAI4Wcico+5zvunQBPnLItHl4xqtBaWyha+Z+Jdxa5+PIP4BWRiwq7EoF A/JFRUoZlMV7r3/0NoEWbEVWXmQbmpu0JrxRY68jh4WfSpWsRZDV8hZVTFcVOwwb p6ZWgDgaHUDbjlQJoWe0FxJFpwmXAkbv8IrS4UCa0uXVbFUeTspiATkvw6bR32I7 DWCtVXrY3A2VeXkHwdqB7h8aeHHqDNqNnEmsQCXGhDmkTL9JSSCUB9RSmwCUHm7y O5mPKTZSmw3NqPRkHxRTfkVv8mSIOyuTklot33zydao8gCk3VtAla7l6Wwx/Kn6k mJtij2e4fGb80PKdJxDB8LD59pVqsyHU43XltfVJHD6NndcMEso= =6khZ -----END PGP SIGNATURE----- --IS0zKkzwUGydFO0o-- From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 18 15:15:51 2018 Received: (at 31210) by debbugs.gnu.org; 18 Apr 2018 19:15:51 +0000 Received: from localhost ([127.0.0.1]:59604 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f8sYZ-00015g-Fe for submit@debbugs.gnu.org; Wed, 18 Apr 2018 15:15:51 -0400 Received: from world.peace.net ([50.252.239.5]:41544) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f8sYY-00015L-5T for 31210@debbugs.gnu.org; Wed, 18 Apr 2018 15:15:50 -0400 Received: from mhw by world.peace.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1f8sYS-0001vM-6D; Wed, 18 Apr 2018 15:15:44 -0400 From: Mark H Weaver To: Leo Famulari Subject: Re: bug#31210: Perl graft breakage References: <20180415153405.5973-1-mbakke@fastmail.com> <20180418180850.GA11245@jasmine.lan> Date: Wed, 18 Apr 2018 15:14:45 -0400 In-Reply-To: <20180418180850.GA11245@jasmine.lan> (Leo Famulari's message of "Wed, 18 Apr 2018 14:08:50 -0400") Message-ID: <87muy0iaxm.fsf@netris.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31210 Cc: 31210@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Leo, Leo Famulari writes: > On Sun, Apr 15, 2018 at 05:34:05PM +0200, Marius Bakke wrote: >> * gnu/packages/perl.scm (perl-5.26.2): New public variable. >> (perl)[replacement]: New field. > > I noticed on my Debian system that this broke rxvt-unicode, and it > probably affects other packages as well. > > The issue is that the full path of libperl.so includes the Perl version > number, for example: > > /gnu/store/...-perl-5.26.1/lib/perl5/5.26.1/x86_64-linux-thread-multi/CORE/libperl.so > > The RUNPATH of urxvt with the Perl graft includes this bogus path: > > /gnu/store/ynk3rg3i791i6k7rz2imbyj9wyfjrnrc-perl-5.26.2/lib/perl5/5.26.1/x86_64-linux-thread-multi/CORE I suggest that we add a phase to the replacement 'perl' to install a symlink from $out/lib/perl5/5.26.1 pointing to "5.26.2". Would you like to try this, Leo, and push it if it solves the problem for you? Mark From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 18 16:52:44 2018 Received: (at 31210) by debbugs.gnu.org; 18 Apr 2018 20:52:44 +0000 Received: from localhost ([127.0.0.1]:59710 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f8u4K-0003Tf-9W for submit@debbugs.gnu.org; Wed, 18 Apr 2018 16:52:44 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:42837) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f8u4I-0003TW-MQ for 31210@debbugs.gnu.org; Wed, 18 Apr 2018 16:52:43 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 4A34A21CCD; Wed, 18 Apr 2018 16:52:42 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 18 Apr 2018 16:52:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= mesmtp; bh=zNGknW9e/+UJE15QnTKK7exINGjsd82HMxolQTHo0Po=; b=YDC5E qNRk2Y3EEV67Jle3dDxu/C1kSaHKRgc4Ycn0UsQ7r1qolmMHb1eMLdtMMw2gUId9 n3YSKt8aoVCjYAYerTjq6PucSPfmNS8j/0ayUyZtdjsSvueb2GxyHKq5xdieeE03 smJ0hZlmQTGJqIboUfnq6CWs3vE5Jt56Ai59XU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=zNGknW9e/+UJE15QnTKK7exINGjsd 82HMxolQTHo0Po=; b=VXd5vla6BhOl6Z+mIEpxSP6H8fzU96DsN0J3IHop4wSsN 9BStKUKlOzeAJigCMbE/LDPM4hls5P8hiCiYIcRi7zGZCjN/yPEDEek6olitjGMo wpyxxuGGFEbqwiB2+65gcWoDDZfBBPSNthjb/ItopxPgV3PBu8qEDp4O/K5RCbcx vASP+nyqV990tTC8WJ+zd5tS/rYheN9w7XLd7xm9g3a/g7/V1e4jXY3VEfMusL9K pJSjasFh60nQdoulImByxRoIY7IjoDAMG/pCwUPjuV4TKk6RQ94QQ9858qQ6BmkD f2dWd9KKQDvKWIeH8UNFluNBel1u4TwEgNWzRVqBw== X-ME-Sender: Received: from localhost (96-90-63-214-static.hfc.comcastbusiness.net [96.90.63.214]) by mail.messagingengine.com (Postfix) with ESMTPA id C9F8F1025A; Wed, 18 Apr 2018 16:52:41 -0400 (EDT) Date: Wed, 18 Apr 2018 16:52:36 -0400 From: Leo Famulari To: Mark H Weaver Subject: Re: bug#31210: Perl graft breakage Message-ID: <20180418205236.GA26365@jasmine.lan> References: <20180415153405.5973-1-mbakke@fastmail.com> <20180418180850.GA11245@jasmine.lan> <87muy0iaxm.fsf@netris.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hHWLQfXTYDoKhP50" Content-Disposition: inline In-Reply-To: <87muy0iaxm.fsf@netris.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 31210 Cc: 31210@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --hHWLQfXTYDoKhP50 Content-Type: multipart/mixed; boundary="MGYHOYXEY6WxJCY8" Content-Disposition: inline --MGYHOYXEY6WxJCY8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 18, 2018 at 03:14:45PM -0400, Mark H Weaver wrote: > I suggest that we add a phase to the replacement 'perl' to install a > symlink from $out/lib/perl5/5.26.1 pointing to "5.26.2". >=20 > Would you like to try this, Leo, and push it if it solves the problem > for you? Thanks for your advice. The attached patch fixes the issue for me. I would have pushed it but there is one thing I don't understand. Before I set (replacement #f), the build would fail because the new phase was run twice, and symlinking fails because it is not "forced" (as in `ln -sf`). Is this expected behaviour? --MGYHOYXEY6WxJCY8 Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="0001-gnu-Perl-Fix-a-grafting-failure-due-to-a-path-that-i.patch" Content-Transfer-Encoding: quoted-printable =46rom b49afa6cf9e18d57e67c0580a09e0ee9168218e7 Mon Sep 17 00:00:00 2001 =46rom: Leo Famulari Date: Wed, 18 Apr 2018 16:41:39 -0400 Subject: [PATCH] gnu: Perl: Fix a grafting failure due to a path that inclu= des the package version. Fixes . * gnu/packages/perl.scm (perl-5.26.2)[arguments]: Add a 'workaround-grafting-version-bug' phase. --- gnu/packages/perl.scm | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm index 34eef565b..24e055225 100644 --- a/gnu/packages/perl.scm +++ b/gnu/packages/perl.scm @@ -43,6 +43,7 @@ #:use-module (guix download) #:use-module (guix build-system gnu) #:use-module (guix build-system perl) + #:use-module (guix utils) ;substitute-keyword-arguments for perl-5.26.2 #:use-module (gnu packages base) #:use-module (gnu packages compression) #:use-module (gnu packages perl-check) @@ -161,13 +162,27 @@ (define-public perl-5.26.2 (package/inherit perl (version "5.26.2") + (replacement #f) (source (origin (inherit (package-source perl)) (uri (string-append "mirror://cpan/src/5.0/perl-" version ".tar.gz")) (sha256 (base32 - "03gpnxx1g6hvlh0v4aqx00580h787sfywp1vlvw64q2xcbm9qbsp"))))= )) + "03gpnxx1g6hvlh0v4aqx00580h787sfywp1vlvw64q2xcbm9qbsp")))) + (arguments + (substitute-keyword-arguments (package-arguments perl) + ((#:phases phases) + `(modify-phases ,phases + ;; The path to libperl.so includes the Perl version number, and= this + ;; is not handled by grafting. See . + (add-after 'install 'workaround-grafting-version-bug + (lambda* (#:key outputs #:allow-other-keys) + (let* ((out (assoc-ref outputs "out")) + (new (string-append out "/lib/perl5/5.26.2")) + (old (string-append out "/lib/perl5/5.26.1"))) + (symlink new old) + #t))))))))) =20 (define-public perl-algorithm-c3 (package --=20 2.17.0 --MGYHOYXEY6WxJCY8-- --hHWLQfXTYDoKhP50 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlrXsBEACgkQJkb6MLrK fwhl4xAAmbELxrLVxJl4LdTO0QTeEZGYXwQOgUKdqwrtXN8hkORXVVIRTx/m9ApY hOf/+nOzbnf6CvJHbdIz3EfTweymEAnmTItBuTl4i1S6sembDuAEg/IFOCLzbMvD thsfbHgUGm7tzh3l6V2V7nfwF/WmxAXa2Lh4Zp2TPg0abdHCj1+myy44uoFF1QWP Bj1hXFzdnWEw+5XwiKSXQ8R3e4Lke9j6+tlOVTj2lFvHZ/w0A2M2zxh1qGwkNU/c cLoIflHg1Rd1DJhHksxF0cJwI1odhwxc3mN96tfhNS2sQckwpC5ueYgQllLJzKL6 xTWy0onZMVON/F0bUKi+jdDkF24ER99//Y4PnYO9ElZykeODNJli4S+pJook5OFD a/TwOW9fL4Tsw9wFpx7cRZxsWqlH55ifxseQoQlUouFrprRPYo1dmWYsNrcdCr3h yQ+tqGT3ajLH4+B3MheDRrZo4Owp+TlIfUkvepx/g1pETszSwVpID/EizvVb3ur4 6zmcxWKsaFo0eJZpWdwU2pmaYxYBQc6q//6Y4/nawvzwHE5CFT7fFHo3nvcIo9Ha 3qyOSatgba3ZBjM7gH81R5t3SwBMkVBRRE1N9Ju0rns833W8FQVjKbDdT6aTbIag uE2QQ6cpDVw71sZv09CMrcwG54INAViycIBeKsGCgkai1XxMKlQ= =kgIK -----END PGP SIGNATURE----- --hHWLQfXTYDoKhP50-- From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 19 03:06:22 2018 Received: (at 31210) by debbugs.gnu.org; 19 Apr 2018 07:06:22 +0000 Received: from localhost ([127.0.0.1]:60032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f93e9-0002Kg-V7 for submit@debbugs.gnu.org; Thu, 19 Apr 2018 03:06:22 -0400 Received: from world.peace.net ([50.252.239.5]:43532) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f93e8-0002KP-0W for 31210@debbugs.gnu.org; Thu, 19 Apr 2018 03:06:20 -0400 Received: from mhw by world.peace.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1f93e1-0005XP-V3; Thu, 19 Apr 2018 03:06:14 -0400 From: Mark H Weaver To: Leo Famulari Subject: Re: bug#31210: Perl graft breakage References: <20180415153405.5973-1-mbakke@fastmail.com> <20180418180850.GA11245@jasmine.lan> <87muy0iaxm.fsf@netris.org> <20180418205236.GA26365@jasmine.lan> Date: Thu, 19 Apr 2018 03:05:15 -0400 In-Reply-To: <20180418205236.GA26365@jasmine.lan> (Leo Famulari's message of "Wed, 18 Apr 2018 16:52:36 -0400") Message-ID: <87h8o7oevo.fsf@netris.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31210 Cc: 31210@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Leo Famulari writes: > On Wed, Apr 18, 2018 at 03:14:45PM -0400, Mark H Weaver wrote: >> I suggest that we add a phase to the replacement 'perl' to install a >> symlink from $out/lib/perl5/5.26.1 pointing to "5.26.2". >> >> Would you like to try this, Leo, and push it if it solves the problem >> for you? > > Thanks for your advice. The attached patch fixes the issue for me. > > I would have pushed it but there is one thing I don't understand. Before > I set (replacement #f), the build would fail because the new phase was > run twice, and symlinking fails because it is not "forced" (as in `ln > -sf`). Is this expected behaviour? The problem is that you should never use 'package/inherit' to create a graft. That leads to an infinite tower of grafts. I'm surprised it works at all, but it's definitely not right. Use (package (inherit ...) ...) instead, and leave out the (replacement #f). Thanks! Mark From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 19 06:29:14 2018 Received: (at 31210) by debbugs.gnu.org; 19 Apr 2018 10:29:14 +0000 Received: from localhost ([127.0.0.1]:60134 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f96oU-0000al-1a for submit@debbugs.gnu.org; Thu, 19 Apr 2018 06:29:14 -0400 Received: from world.peace.net ([50.252.239.5]:44228) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f96oR-0000aY-EX for 31210@debbugs.gnu.org; Thu, 19 Apr 2018 06:29:11 -0400 Received: from mhw by world.peace.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1f96oL-0006Dr-Hx; Thu, 19 Apr 2018 06:29:05 -0400 From: Mark H Weaver To: Leo Famulari Subject: Re: bug#31210: Perl graft breakage References: <20180415153405.5973-1-mbakke@fastmail.com> <20180418180850.GA11245@jasmine.lan> <87muy0iaxm.fsf@netris.org> <20180418205236.GA26365@jasmine.lan> <87h8o7oevo.fsf@netris.org> Date: Thu, 19 Apr 2018 06:28:06 -0400 In-Reply-To: <87h8o7oevo.fsf@netris.org> (Mark H. Weaver's message of "Thu, 19 Apr 2018 03:05:15 -0400") Message-ID: <87d0yvo5hl.fsf@netris.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31210 Cc: 31210@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi again, I wrote: > The problem is that you should never use 'package/inherit' to create a > graft. That leads to an infinite tower of grafts. I should explain why this is. We cannot use (package/inherit P ...) to define the replacement of package P, because it leads to a circular definition. Recall that (package/inherit P ...) applies the given transformation to both P and its replacement. In this case, P's replacement is the thing we're trying to define. See the circularity? This would lead to an infinite recursion if not for the fact that 'replacement' is a "thunked" field, i.e. its evaluation is delayed. Instead it leads to an infinite series of replacements, each one based on the previous one, but with the transformation applied one more time. In this example with 'perl', the transformation involved adding a new phase. Let's call that transformation 'f', so that (f perl) is the replacement you wanted. Since you used (package/inherit perl ...) to define perl's replacement, it led to an infinite series of replacements: perl (f perl) (f (f perl)) (f (f (f perl))) ... I would have expected the grafting machinery to iterate until reaching the end of this series of replacements. I guess it didn't because the (f (f perl)) build failed, since it added the phase twice. Also note that since 'package/inherit' implicitly adds its own 'replacement' field, if you manually override 'replacement' within 'package/inherit' as you did in your first proposed patch, it expands into a package definition with two 'replacement' overrides, like this: (package (inherit P) (replacement #f) ... (replacement ...)) Ideally, guix records would report an error in this case. Regards, Mark From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 19 07:58:37 2018 Received: (at 31210) by debbugs.gnu.org; 19 Apr 2018 11:58:37 +0000 Received: from localhost ([127.0.0.1]:60163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f98Cz-0004dx-2E for submit@debbugs.gnu.org; Thu, 19 Apr 2018 07:58:37 -0400 Received: from world.peace.net ([50.252.239.5]:44482) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f98Cx-0004dh-Hu for 31210@debbugs.gnu.org; Thu, 19 Apr 2018 07:58:35 -0400 Received: from mhw by world.peace.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1f98Cr-0006Wy-LW; Thu, 19 Apr 2018 07:58:29 -0400 From: Mark H Weaver To: Leo Famulari Subject: Re: bug#31210: Perl graft breakage References: <20180415153405.5973-1-mbakke@fastmail.com> <20180418180850.GA11245@jasmine.lan> <87muy0iaxm.fsf@netris.org> <20180418205236.GA26365@jasmine.lan> Date: Thu, 19 Apr 2018 07:57:32 -0400 In-Reply-To: <20180418205236.GA26365@jasmine.lan> (Leo Famulari's message of "Wed, 18 Apr 2018 16:52:36 -0400") Message-ID: <87a7tzjtn7.fsf@netris.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31210 Cc: 31210@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Leo, One more thing: Leo Famulari writes: > + (add-after 'install 'workaround-grafting-version-bug > + (lambda* (#:key outputs #:allow-other-keys) > + (let* ((out (assoc-ref outputs "out")) > + (new (string-append out "/lib/perl5/5.26.2")) > + (old (string-append out "/lib/perl5/5.26.1"))) > + (symlink new old) > + #t))))))))) It would be better for 'new' to be simply "5.26.2" instead of an absolute file name. If I'm not mistaken, on ext4, files (including symlinks) smaller than 60 bytes are stored entirely within the inode, saving both a disk block and a seek operation when accessing it. Mark From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 19 10:38:44 2018 Received: (at 31210) by debbugs.gnu.org; 19 Apr 2018 14:38:44 +0000 Received: from localhost ([127.0.0.1]:33030 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f9Ahw-000061-D3 for submit@debbugs.gnu.org; Thu, 19 Apr 2018 10:38:44 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:35331) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f9Ahu-00005s-M4 for 31210@debbugs.gnu.org; Thu, 19 Apr 2018 10:38:43 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 4438F21666; Thu, 19 Apr 2018 10:38:41 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 19 Apr 2018 10:38:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= mesmtp; bh=HNOk812Pn4VJPsQKxXwTUIPIjK+htAPrBW0cC/apJ9M=; b=Z/u1o /66qa8B25rNKbpbpCsnraXyoK3PruHhKDC9CAOzigCD8Uv0zkFLBJ5DO9Fq4qKgO NMP6w0oOlP9r/pDkW1VLTCaZ4IVYiLXhwgLYgGepejD9JOJ2ezV8xIHNRFyETRYJ v1UL3JeGh9KBzvNHS3nKrapdhFh6KBQgSMc+sQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=HNOk812Pn4VJPsQKxXwTUIPIjK+ht APrBW0cC/apJ9M=; b=nIgG45rgYqOa5vnR9DROZxVyKNe8c76SoZL1l+x62sypB kqxknM2DenxVP0mG2mtxQCFO+DMaLCUN1BfbljpyrsV0S1gW9aidOXXQT+apDon6 kcL33tgMO6browJMSbfdYznolufhuW88EniKSS+SmaRNgxoVMi8NZToFKw3U9rGT 5fBSsdMFezPEk8nb2OTB+sGbYBMSDa7/70yr5UNe/SLccwF/4++slvexRMSDhLCG /GiLeRI8njtQgn5yqbKgpdnGxnVSgwuDjaOJgYA1qZvwXu7SgBHM1MoLBbRZZMTK L85tamZH4yYQSJthjL/C+KCbUb2SXqqKQToXP+yLw== X-ME-Sender: Received: from localhost (unknown [172.58.201.72]) by mail.messagingengine.com (Postfix) with ESMTPA id D829AE4661; Thu, 19 Apr 2018 10:38:40 -0400 (EDT) Date: Thu, 19 Apr 2018 10:38:39 -0400 From: Leo Famulari To: Mark H Weaver Subject: Re: bug#31210: Perl graft breakage Message-ID: <20180419143839.GA8699@jasmine.lan> References: <20180415153405.5973-1-mbakke@fastmail.com> <20180418180850.GA11245@jasmine.lan> <87muy0iaxm.fsf@netris.org> <20180418205236.GA26365@jasmine.lan> <87a7tzjtn7.fsf@netris.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="VbJkn9YxBvnuCH5J" Content-Disposition: inline In-Reply-To: <87a7tzjtn7.fsf@netris.org> User-Agent: Mutt/1.9.5 (2018-04-13) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 31210 Cc: 31210@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --VbJkn9YxBvnuCH5J Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 19, 2018 at 07:57:32AM -0400, Mark H Weaver wrote: > Hi Leo, >=20 > One more thing: >=20 > Leo Famulari writes: > > + (add-after 'install 'workaround-grafting-version-bug > > + (lambda* (#:key outputs #:allow-other-keys) > > + (let* ((out (assoc-ref outputs "out")) > > + (new (string-append out "/lib/perl5/5.26.2")) > > + (old (string-append out "/lib/perl5/5.26.1"))) > > + (symlink new old) > > + #t))))))))) >=20 > It would be better for 'new' to be simply "5.26.2" instead of an > absolute file name. If I'm not mistaken, on ext4, files (including > symlinks) smaller than 60 bytes are stored entirely within the inode, > saving both a disk block and a seek operation when accessing it. Thanks for all your expert advice! I pushed a fix as 44b98b00026e62766620dbc4330a305282d61069. --VbJkn9YxBvnuCH5J Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlrYqe8ACgkQJkb6MLrK fwizpxAAxdwevc51xru3x1rkqSX3WCv4WtUKyeXgE1cCMmXa9L5TMXUmM+qcdK1+ bdcynJDx7c4TRZIA/jVnWXxehdK8aBoQDccAeP5mxITMlUSku3Ul4auIJAil2GN/ g/DFOzYyLgkuVO+Ii99HWXWK3R3cJr/07S3V8TNeZ62A0u9KyTa/uKCW6aJ149ab eX+dfOhrxZw4SU5DZzwcgUKoYdDT1Zi0tQiXyvYgJLjA/aA/8mZpQTzvc9/v7RIM EZltp2Ic/ozGWX4FbF+07q2dyTH2dQTQA4+sahEkhkKG2XZ1YfCaaNSyQ1C2jmIv kdzDPlTZMJDcw2TWxB2MXdFO1nK6PkqjpBUZ7Iw8INcvBlzAr8kRLzntUNO8P+7U yOFoV+DDhAUym6+/N4sedhiIPqT8Fjirs67tdBf/DGXBUTjg3I451eqD3dcuVVPF R/bEmHqBFcsKo/YsbIh1Ho2NnqURzMGU5nLVLVR+OF8xEMJahdcv0zon22lhy1Ca rEx2J3XDD6Y9c0Z5wG00oB+UY9SzEM83UGbHFDWW5GH25+2fXWKlAYmlqMz0KawO oxZUF8ensNTLXRVbJi6uf7KC9YW8zjNLfXX6WMu1g/YVc5vMBBxuMDrMsoPhZW2J vIbas9HWc9igLnNtcpETUPDEHxREKTbo4vcogA0f04rVbISaWpw= =OLie -----END PGP SIGNATURE----- --VbJkn9YxBvnuCH5J-- From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 19 10:39:31 2018 Received: (at control) by debbugs.gnu.org; 19 Apr 2018 14:39:31 +0000 Received: from localhost ([127.0.0.1]:33040 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f9Aih-00007l-3M for submit@debbugs.gnu.org; Thu, 19 Apr 2018 10:39:31 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:51577) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f9Aie-00007b-7d for control@debbugs.gnu.org; Thu, 19 Apr 2018 10:39:29 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 131E520FA9; Thu, 19 Apr 2018 10:39:28 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 19 Apr 2018 10:39:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=content-type:date:from:message-id:mime-version:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=cBMFyEG3oruY7Rwywk/qFSSR60 zyICbqqiJIyoHETrc=; b=Qf+EGXNSc1bwb7+o0Mn2Uh+vI91dhW66yXX+8zTMZ/ /Ee6iXL7yDRFsomMc+p4i2WiwkDjuMdmZ2pfSVqn7TpQkc3CsyBe1bpBnf8P15Dy EM5ehRufQGWV6b/7/GpIC3H3pCYh0zGIPnxU0d+UZRVEffhkjFYW5KzC0N048udu 8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=c BMFyEG3oruY7Rwywk/qFSSR60zyICbqqiJIyoHETrc=; b=b+H+0Uf05Lw0drcUC eC/Euk0MpT0A4ea1Yv/cW0a8hH+99BFm5drQThBUrcDctrEI3cDSNXBxWiiKh3SW cpzfLAfBJoWkx+bhUJpH/z6qpU9UGxFBQpNiqYy4YGwr8BDcUgWsSGCl6ZIrX1dH q5X6qDImO+EgIyTQ22+CBct2qxjCitYXV7oUJglLLKtsvd2hMjjiQPRYEZjF3w7d ffkTZF4w1r0iZ3VcW5iAQKH7zSVe4FF8o3PMJ4SOT9AkfGoL4ZAteXEu/sX2YBji +VFqd+5WtGUb+2pyuH4HSWQ7sveOdZpynKBmwN5i2otADK8h32yHGg2GDa7YW3Lg fkKbw== X-ME-Sender: Received: from localhost (unknown [172.58.201.72]) by mail.messagingengine.com (Postfix) with ESMTPA id B9B01E442A for ; Thu, 19 Apr 2018 10:39:27 -0400 (EDT) Date: Thu, 19 Apr 2018 10:39:26 -0400 From: Leo Famulari To: control@debbugs.gnu.org Message-ID: <20180419143926.GA8800@jasmine.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.9.5 (2018-04-13) X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: close 31210 [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [66.111.4.27 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid 0.0 TVD_SPACE_RATIO No description available. X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) close 31210 From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 19 11:21:11 2018 Received: (at 31210) by debbugs.gnu.org; 19 Apr 2018 15:21:11 +0000 Received: from localhost ([127.0.0.1]:33087 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f9BMw-00035Z-I4 for submit@debbugs.gnu.org; Thu, 19 Apr 2018 11:21:11 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:40701) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f9BMt-00035P-1w for 31210@debbugs.gnu.org; Thu, 19 Apr 2018 11:21:05 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 92C9021B8D; Thu, 19 Apr 2018 11:21:02 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Thu, 19 Apr 2018 11:21:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=ooVRxj5raNZ5UOdnb28PjiuurV3PMXMCseZa45Cs0BI=; b=eWTPjo5h mOtxjQ5X4Jlx48GtVdhJTXIdJC2B+ZynyOCAvRyGHkvKpVEg3heauIVcBktUjqej TY/i/6fPpumIFR8TDlbkvvDzMy5yqW0ly1zudYNX2LCF0xxue79F+asSrR4U5Mlm VLn9w7wfqLsZgZOoukFSGgkZmycjA5BQQHdgImm25MN1CZ39TmbGpLzPQi06myJ7 e9mbwYe1ePPttU7r/rNlrctfaNv1I2uU2hkfiTvAgPsGhnGqclsCAtHzKw4FDMob KB4wtFzF84KscGAxnmfr8Wv2hh3b9gFDWj5oDQNoPLLSB8Hd+CDW1l6dUWXUfi0G g6uj4xRN8MsSZQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=ooVRxj5raNZ5UOdnb28PjiuurV3PM XMCseZa45Cs0BI=; b=Z8yWFsqIzasGbvF6YDFyaBRBiK63NyH1Pvmxj7h6yrTCo 3fxkpvk6phyLJV0ix0v+eyFvKd0tXvYa0tN1HY1fwJr9+8MrZ0tg+FljVHdsk7Dq 4EY3xzaZkbznCVwtSOsS/F+TC0LvXtmdzjWwf03mLG+51+ER0Z8/e5uAfCPHk/z+ VHIda0TOqU2+OmRUIT4WvcY8LqocGfBLl9k0dQVnMpFkBoyxQ1pEjj2RG9pi6Ak0 vWA7+E7bUL8v/rAYD67jJXg0Vw3tORCRyyU95uTh9243+0yTxB+3XTZ/QKAe6upj yDYVzSRDljfPt/rmzVs18b1d1tPZlvmB33t89VNtA== X-ME-Sender: Received: from localhost (228.92-221-162.customer.lyse.net [92.221.162.228]) by mail.messagingengine.com (Postfix) with ESMTPA id 0DEE010260; Thu, 19 Apr 2018 11:21:01 -0400 (EDT) From: Marius Bakke To: Mark H Weaver , Leo Famulari Subject: Re: bug#31210: Perl graft breakage In-Reply-To: <87a7tzjtn7.fsf@netris.org> References: <20180415153405.5973-1-mbakke@fastmail.com> <20180418180850.GA11245@jasmine.lan> <87muy0iaxm.fsf@netris.org> <20180418205236.GA26365@jasmine.lan> <87a7tzjtn7.fsf@netris.org> User-Agent: Notmuch/0.26.1 (https://notmuchmail.org) Emacs/25.3.1 (x86_64-pc-linux-gnu) Date: Thu, 19 Apr 2018 17:20:59 +0200 Message-ID: <87zi1z9q90.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 31210 Cc: 31210@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Mark H Weaver writes: > Hi Leo, > > One more thing: > > Leo Famulari writes: >> + (add-after 'install 'workaround-grafting-version-bug >> + (lambda* (#:key outputs #:allow-other-keys) >> + (let* ((out (assoc-ref outputs "out")) >> + (new (string-append out "/lib/perl5/5.26.2")) >> + (old (string-append out "/lib/perl5/5.26.1"))) >> + (symlink new old) >> + #t))))))))) > > It would be better for 'new' to be simply "5.26.2" instead of an > absolute file name. If I'm not mistaken, on ext4, files (including > symlinks) smaller than 60 bytes are stored entirely within the inode, > saving both a disk block and a seek operation when accessing it. Hello Mark and Leo, I'm sorry for not testing this graft more thoroughly. And thanks for the explanation about package/inherit, I had misunderstood its purpose. The attached patch should address all concerns. I have also tested urxvt with it. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnu-perl-Fix-grafting-error-due-to-version-number-in.patch Content-Transfer-Encoding: quoted-printable From=2044ae580e4affc03bcfd6d27277ea78aa63021fb9 Mon Sep 17 00:00:00 2001 From: Marius Bakke Date: Thu, 19 Apr 2018 17:17:54 +0200 Subject: [PATCH] gnu: perl: Fix grafting error due to version number in Perl library path. Fixes . * gnu/packages/perl.scm (perl-5.26.2): Use (package (inherit) ...) instead of (package/inherit ...). [arguments]: Add phase 'workaround-grafting-version-bug'. =2D-- gnu/packages/perl.scm | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm index aaf3e2e82..4cd5bf6df 100644 =2D-- a/gnu/packages/perl.scm +++ b/gnu/packages/perl.scm @@ -44,6 +44,7 @@ #:use-module (guix download) #:use-module (guix build-system gnu) #:use-module (guix build-system perl) + #:use-module (guix utils) ;substitute-keyword-arguments for perl-5.26.2 #:use-module (gnu packages base) #:use-module (gnu packages compression) #:use-module (gnu packages freedesktop) @@ -161,7 +162,8 @@ ;; Fixes CVE-2018-6797, CVE-2018-6798, and CVE-2018-6913. ;; See . (define-public perl-5.26.2 =2D (package/inherit perl + (package + (inherit perl) (version "5.26.2") (source (origin (inherit (package-source perl)) @@ -169,7 +171,19 @@ version ".tar.gz")) (sha256 (base32 =2D "03gpnxx1g6hvlh0v4aqx00580h787sfywp1vlvw64q2xcbm9qbsp"))= )))) + "03gpnxx1g6hvlh0v4aqx00580h787sfywp1vlvw64q2xcbm9qbsp")))) + (arguments + (substitute-keyword-arguments (package-arguments perl) + ((#:phases phases) + `(modify-phases ,phases + ;; The path to libperl.so includes the Perl version number, and= this + ;; is not handled by grafting. See . + (add-after 'install 'workaround-grafting-version-bug + (lambda* (#:key outputs #:allow-other-keys) + (let* ((out (assoc-ref outputs "out"))) + (with-directory-excursion (string-append out "/lib/perl5") + (symlink "5.26.2" "5.26.1") + #t)))))))))) =20 (define-public perl-algorithm-c3 (package =2D-=20 2.17.0 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlrYs9sACgkQoqBt8qM6 VPo8Jgf/V434gskakNAKkJjU5wyzVYHEEK8Rmvc37Lm3VV1rJMKmGKuqQWzg0I2r U3gW5Tu/gvt+/symPQXXriQnyqAerfXNX0b0xxTZgkOCGRlV3VV2os/biERFSm4g y9DTJxRZmDvK6JP4Yl29q1CN9Qrs2zRJYWcsUc09HiNQ+pKGv/pwMY4d5TeHlSYp QdkCq4p46H09JrD89EYtMyKj9brJqpjR2NyezfPJ+gYS4Vk65sk+cxX5/vnckPUG 7XIeddCrn8O4T+6xUMC1mbRdFtxzSR30xhWy9lI4lhfxq4mnt//vEVjDMGx+BX4w 7ntbSShleTkfztPBlABaqDjhJ4k+aw== =uobE -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 21 01:54:49 2018 Received: (at 31210) by debbugs.gnu.org; 21 Apr 2018 05:54:49 +0000 Received: from localhost ([127.0.0.1]:34527 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f9lU1-0002ZJ-2c for submit@debbugs.gnu.org; Sat, 21 Apr 2018 01:54:49 -0400 Received: from world.peace.net ([50.252.239.5]:50598) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f9lTz-0002Z6-IA for 31210@debbugs.gnu.org; Sat, 21 Apr 2018 01:54:47 -0400 Received: from mhw by world.peace.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1f9lTt-0001Kf-Hh; Sat, 21 Apr 2018 01:54:41 -0400 From: Mark H Weaver To: 31210@debbugs.gnu.org Subject: Re: bug#31210: Perl graft breakage Date: Sat, 21 Apr 2018 01:53:40 -0400 Message-ID: <87muxxxfyz.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31210 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) My suggested approach of making compatibility symlinks didn't work. See for details and further discussion. Mark From unknown Mon Jun 23 14:58:51 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 19 May 2018 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator