From unknown Wed Jun 18 23:01:48 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#31200 <31200@debbugs.gnu.org> To: bug#31200 <31200@debbugs.gnu.org> Subject: Status: 27.0.50; Update eww and shr face spec syntax Reply-To: bug#31200 <31200@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:01:48 +0000 retitle 31200 27.0.50; Update eww and shr face spec syntax reassign 31200 emacs submitter 31200 "Basil L. Contovounesios" severity 31200 normal tag 31200 fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 17 15:36:54 2018 Received: (at submit) by debbugs.gnu.org; 17 Apr 2018 19:36:54 +0000 Received: from localhost ([127.0.0.1]:57888 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f8WPN-0003wq-Ly for submit@debbugs.gnu.org; Tue, 17 Apr 2018 15:36:53 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54913) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f8WPK-0003wc-4C for submit@debbugs.gnu.org; Tue, 17 Apr 2018 15:36:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f8WPD-0006eC-TX for submit@debbugs.gnu.org; Tue, 17 Apr 2018 15:36:45 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:46217) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f8WPD-0006e2-Of for submit@debbugs.gnu.org; Tue, 17 Apr 2018 15:36:43 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45851) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f8WPC-00044g-EE for bug-gnu-emacs@gnu.org; Tue, 17 Apr 2018 15:36:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f8WP9-0006aL-AN for bug-gnu-emacs@gnu.org; Tue, 17 Apr 2018 15:36:42 -0400 Received: from mail-wr0-x22b.google.com ([2a00:1450:400c:c0c::22b]:34345) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f8WP8-0006ZB-T9 for bug-gnu-emacs@gnu.org; Tue, 17 Apr 2018 15:36:39 -0400 Received: by mail-wr0-x22b.google.com with SMTP id d19so38624645wre.1 for ; Tue, 17 Apr 2018 12:36:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:subject:mail-followup-to:date:message-id:user-agent :mime-version; bh=thZgsGggUcVS785oayx+EtUDEkAsrLdaP7Gw/2yYCwg=; b=KwT4FshcUAOQAFHeZWRbKIJFRyX49wrtOO+qAZIegjaGePOM2SkfKz6H+SdqPG21JX sA4Vl5AJ2Gya9HEpmgSduLouI0yFVZ4vbtyMkOvU30px7EQU5YmFokZL5wuASKAW7JH5 /qymJfMi6Tctv/cr1NbHnU6gbBTxUkPne3KcKh18jc2eM4FHo80pW5Z7/Fyw5+gTtEV6 byPlKKCmUYqHPNnSoKrrcVT8aNwN338OrryScVYrxeFmw2NAnVczE3cvHrfhXCRsp8je rJ1VOx0ykqa/2T+o7WNJSqRGljjY/ZQK7Zc3ldeUH0SeO0rUAKieoue/bRgPFUTroiH0 ejMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:mail-followup-to:date:message-id :user-agent:mime-version; bh=thZgsGggUcVS785oayx+EtUDEkAsrLdaP7Gw/2yYCwg=; b=pnOVaWa6U50HrqZC1foXLURh5wWIxxdsRSVnJDMYr6/iio3iHgRNVjNWArew2S7/uA re4Je1e+i35KTWn0KkCASHDL9tvXmLoGGFAEnznHJfodhx+UiOOvMOehvL6ntunvMy1a RrSJ6iu8WN181tHcSklGO77cWp/P0I01BMyArZFmrBhGEwzpW/WrKwJhe4IPrjxonpC/ /ctpCNnXOovQH7J1tmWvo90gqoLq8SZJagU0owHoY2V+Jy/nY03ADMuZaDhJRMbkbS+D ppukuD7XWKj2L8A8uaj+SwDBo1DSRjkG9e0FAqwxnyZNEM0ijzf0tmMUuR0fTyXcSkCC ZVGg== X-Gm-Message-State: ALQs6tBuisWQArj3msxjFNbZ9Ds6gofEjr/EIw1EZNWadj0tVBSCU+z2 6cGbYrCfIhcrw9a6Mh8feKl6zbCb X-Google-Smtp-Source: AIpwx4/l7PWIvLeZgzZI1fTZZP4p/edlixMd3dVNxcNV1tYJbQx5qUwh7JZcPzrPQJDJUwMR4r42aQ== X-Received: by 10.80.221.197 with SMTP id x5mr4691317edk.137.1523993797452; Tue, 17 Apr 2018 12:36:37 -0700 (PDT) Received: from localhost ([89.100.107.149]) by smtp.gmail.com with ESMTPSA id s9sm9115622edc.85.2018.04.17.12.36.36 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 17 Apr 2018 12:36:36 -0700 (PDT) From: "Basil L. Contovounesios" To: bug-gnu-emacs@gnu.org Subject: 27.0.50; Update eww and shr face spec syntax X-Debbugs-CC: Lars Ingebrigtsen Mail-Followup-To: bug-gnu-emacs@gnu.org Date: Tue, 17 Apr 2018 20:36:31 +0100 Message-ID: <87wox5mxq8.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Modernize-eww-and-shr-face-spec-syntax.patch >From ce4f67f185572f260bb14abc87cf532bcfedf7b3 Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Tue, 17 Apr 2018 20:02:18 +0100 Subject: [PATCH 1/2] Modernize eww and shr face spec syntax * lisp/net/eww.el (eww-form-text, eww-form-textarea): * lisp/net/shr.el (shr-strike-through, shr-link, shr-selected-link): Use (DISPLAY . PLIST) face spec syntax as recommended in '(elisp) Defining Faces'. --- lisp/net/eww.el | 12 ++++++------ lisp/net/shr.el | 6 +++--- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/lisp/net/eww.el b/lisp/net/eww.el index f737189612..e74f661ac7 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -186,17 +186,17 @@ eww-form-select :group 'eww) (defface eww-form-text - '((t (:background "#505050" - :foreground "white" - :box (:line-width 1)))) + '((t :background "#505050" + :foreground "white" + :box (:line-width 1))) "Face for eww text inputs." :version "24.4" :group 'eww) (defface eww-form-textarea - '((t (:background "#C0C0C0" - :foreground "black" - :box (:line-width 1)))) + '((t :background "#C0C0C0" + :foreground "black" + :box (:line-width 1))) "Face for eww textarea inputs." :version "24.4" :group 'eww) diff --git a/lisp/net/shr.el b/lisp/net/shr.el index 2d913a5a92..6ce2e59840 100644 --- a/lisp/net/shr.el +++ b/lisp/net/shr.el @@ -135,17 +135,17 @@ shr-content-function (defvar shr-put-image-function 'shr-put-image "Function called to put image and alt string.") -(defface shr-strike-through '((t (:strike-through t))) +(defface shr-strike-through '((t :strike-through t)) "Font for elements." :group 'shr) (defface shr-link - '((t (:inherit link))) + '((t :inherit link)) "Font for link elements." :group 'shr) (defface shr-selected-link - '((t (:inherit shr-link :background "red"))) + '((t :inherit shr-link :background "red")) "Font for link elements." :group 'shr) -- 2.17.0 --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0002-Set-version-of-shr-faces.patch >From dfb7a81f60853174e22735fa9246af8675a04ddc Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Tue, 17 Apr 2018 20:08:58 +0100 Subject: [PATCH 2/2] Set :version of shr faces * lisp/net/shr.el (shr-strike-through, shr-link, shr-selected-link): Set :version tag. --- lisp/net/shr.el | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lisp/net/shr.el b/lisp/net/shr.el index 6ce2e59840..c549c8afb0 100644 --- a/lisp/net/shr.el +++ b/lisp/net/shr.el @@ -137,16 +137,19 @@ shr-put-image-function (defface shr-strike-through '((t :strike-through t)) "Font for elements." + :version "24.1" :group 'shr) (defface shr-link '((t :inherit link)) "Font for link elements." + :version "24.1" :group 'shr) (defface shr-selected-link '((t :inherit shr-link :background "red")) "Font for link elements." + :version "27.1" :group 'shr) (defvar shr-inhibit-images nil -- 2.17.0 --=-=-= Content-Type: text/plain Further to Lars' invitation[1] in bug#25096, I attach two patches. The first updates eww and shr faces to use the newer (DISPLAY . PLIST) face spec syntax, and the second sets the :version tag of shr faces. [1] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25096#48 P.S. I noticed that the docstrings of all three shr faces begin with the term "font". Is this deviation from the term "face" intentional? Thanks, -- Basil In GNU Emacs 27.0.50 (build 5, x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll bars) of 2018-04-17 built on thunk Repository revision: 62a075b01678c6a6f5d2a69c9ea6904a3927f1b4 Windowing system distributor 'The X.Org Foundation', version 11.0.11906000 System Description: Debian GNU/Linux buster/sid --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 17 15:42:59 2018 Received: (at submit) by debbugs.gnu.org; 17 Apr 2018 19:42:59 +0000 Received: from localhost ([127.0.0.1]:57897 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f8WVH-00045Z-Jl for submit@debbugs.gnu.org; Tue, 17 Apr 2018 15:42:59 -0400 Received: from eggs.gnu.org ([208.118.235.92]:58632) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f8WVF-00045N-Pu for submit@debbugs.gnu.org; Tue, 17 Apr 2018 15:42:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f8WV9-0005oz-En for submit@debbugs.gnu.org; Tue, 17 Apr 2018 15:42:52 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:57352) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f8WV9-0005oq-C5 for submit@debbugs.gnu.org; Tue, 17 Apr 2018 15:42:51 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49572) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f8WV8-0006a6-5i for bug-gnu-emacs@gnu.org; Tue, 17 Apr 2018 15:42:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f8WV5-0005iz-4L for bug-gnu-emacs@gnu.org; Tue, 17 Apr 2018 15:42:50 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:37593) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f8WV4-0005eb-Ty for bug-gnu-emacs@gnu.org; Tue, 17 Apr 2018 15:42:47 -0400 Received: from 46.67.12.60.tmi.telenormobil.no ([46.67.12.60] helo=corrigan) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1f8WV0-0004aA-E4 for bug-gnu-emacs@gnu.org; Tue, 17 Apr 2018 21:42:44 +0200 Received: from larsi by corrigan with local (Exim 4.89) (envelope-from ) id 1f8WUu-0002S1-Cn for bug-gnu-emacs@gnu.org; Tue, 17 Apr 2018 21:42:36 +0200 From: Lars Ingebrigtsen To: bug-gnu-emacs@gnu.org Subject: Re: bug#31200: 27.0.50; Update eww and shr face spec syntax References: <87wox5mxq8.fsf@tcd.ie> Date: Tue, 17 Apr 2018 21:42:36 +0200 In-Reply-To: <87wox5mxq8.fsf@tcd.ie> (Basil L. Contovounesios's message of "Tue, 17 Apr 2018 20:36:31 +0100") Message-ID: <87h8o9ipqr.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) "Basil L. Contovounesios" writes: > Further to Lars' invitation[1] in bug#25096, I attach two patches. The > first updates eww and shr faces to use the newer (DISPLAY . PLIST) face > spec syntax, and the second sets the :version tag of shr faces. > > [1] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25096#48 Thanks; applied. > P.S. I noticed that the docstrings of all three shr faces begin with the > term "font". Is this deviation from the term "face" intentional? No, that's an oversight. I'll fix those. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 17 15:42:52 2018 Received: (at control) by debbugs.gnu.org; 17 Apr 2018 19:42:52 +0000 Received: from localhost ([127.0.0.1]:57894 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f8WV8-00045E-Eb for submit@debbugs.gnu.org; Tue, 17 Apr 2018 15:42:52 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:37419) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f8WV6-000454-Aa for control@debbugs.gnu.org; Tue, 17 Apr 2018 15:42:48 -0400 Received: from 46.67.12.60.tmi.telenormobil.no ([46.67.12.60] helo=corrigan) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1f8WV3-0004l6-ED for control@debbugs.gnu.org; Tue, 17 Apr 2018 21:42:47 +0200 Received: from larsi by corrigan with local (Exim 4.89) (envelope-from ) id 1f8WUx-0002S4-OW for control@debbugs.gnu.org; Tue, 17 Apr 2018 21:42:39 +0200 To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #31200 Message-Id: Date: Tue, 17 Apr 2018 21:42:39 +0200 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 31200 fixed close 31200 From unknown Wed Jun 18 23:01:48 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 16 May 2018 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator