GNU bug report logs - #31192
27.0.50; artist-mode throws a wrong type argument

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Tino Calancha <tino.calancha <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#31192: closed (27.0.50; artist-mode throws a wrong type
 argument )
Date: Tue, 17 Apr 2018 13:23:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 17 Apr 2018 22:22:37 +0900
with message-id <87fu3uezmq.fsf <at> gmail.com>
and subject line Re: bug#31192: 27.0.50; artist-mode throws a wrong type argument
has caused the debbugs.gnu.org bug report #31192,
regarding 27.0.50; artist-mode throws a wrong type argument 
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
31192: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=31192
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Tino Calancha <tino.calancha <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.0.50; artist-mode throws a wrong type argument 
Date: Tue, 17 Apr 2018 21:57:23 +0900

X-Debbugs-CC: Lars Ingebrigtsen <larsi <at> gnus.org>

After commit '(artist-mode): Warn about proportional fonts'
(36e5673753b985dee06b255be237dce9e96b0eb7)

emacs -batch -eval "(artist-mode)"
throws
Wrong type argument: font, unspecified

That causes two ibuffer-tests.el to fail:
(ibuffer-filter-inclusion-7, ibuffer-filter-inclusion-8)

--8<-----------------------------cut here---------------start------------->8---
commit 04f528b864490f22e773d185f2a4980b29306eb0
Author: Tino Calancha <tino.calancha <at> gmail.com>
Date:   Tue Apr 17 21:34:25 2018 +0900

    * lisp/textmodes/artist.el (artist-mode): Ensure we have a font

diff --git a/lisp/textmodes/artist.el b/lisp/textmodes/artist.el
index 7c261f8d2d..e9ae6a4ce9 100644
--- a/lisp/textmodes/artist.el
+++ b/lisp/textmodes/artist.el
@@ -1402,8 +1402,9 @@ artist-mode
 	(t
 	 ;; Turn mode on
 	 (artist-mode-init)
-         (unless (font-get (face-attribute 'default :font) :spacing)
-           (message "The default font isn't monospaced, so the drawings in this buffer may look odd")))))
+         (let ((font (face-attribute 'default :font)))
+           (when (and (fontp font) (not (font-get font :spacing)))
+             (message "The default font isn't monospaced, so the drawings in this buffer may look odd"))))))
 
 ;; Init and exit
 (defun artist-mode-init ()
--8<-----------------------------cut here---------------end--------------->8---
In GNU Emacs 27.0.50 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.22.11)
 of 2018-04-17
Repository revision: 003071346cdc914f28a8e8b3a8bf0c8f5f3b52dc

[Message part 3 (message/rfc822, inline)]

From: Tino Calancha <tino.calancha <at> gmail.com>
To: 31192-done <at> debbugs.gnu.org
Subject: Re: bug#31192: 27.0.50; artist-mode throws a wrong type argument
Date: Tue, 17 Apr 2018 22:22:37 +0900

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Tino Calancha <tino.calancha <at> gmail.com> writes:
>
>>     * lisp/textmodes/artist.el (artist-mode): Ensure we have a font
>
> Makes sense.
Fixed in master branch with commit
'* lisp/textmodes/artist.el (artist-mode): Ensure we have a font'
(c969fbd40bcad0de6322895a5ad4d53144309315)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.