GNU bug report logs - #31175
[PATCH] gnu: Add postgis.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 31175 in the body.
You can then email your comments to 31175 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add postgis.
Date: Mon, 16 Apr 2018 11:18:21 +0200

[Message part 1 (text/plain, inline)]

Hi, here are two patches to add postgis and its dependency gdal.

[0001-gnu-Add-gdal.patch (text/x-patch, attachment)]

[0002-gnu-Add-postgis.patch (text/x-patch, attachment)]

Message #8 received at 31175 <at> debbugs.gnu.org (full text, mbox):

From: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 31175 <at> debbugs.gnu.org
Subject: Re: [bug#31175] [PATCH] gnu: Add postgis.
Date: Wed, 18 Apr 2018 00:26:45 +0200

[Message part 1 (text/plain, inline)]

Hi Julien,

cool! Thanks for adding GDAL (and PostGIS). I have this on my TODO-list
but haven't done it yet because of the long license list and all the
dependencies. That's also the reason of why I haven't (yet?) done a
full review. I only noticed two things:


* Add a Copyright header for you.


On Mon, 16 Apr 2018 11:18:21 +0200
Julien Lepiller <julien <at> lepiller.eu> wrote:

> * gnu/packages/geo.scm (gdal): New variable.
> ---
>  gnu/packages/geo.scm | 93
> ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 93
> insertions(+)

[..]

> +    (home-page "http://www.gdal.org/")
> +    (synopsis "Raster and vector geospation data format library")
This should be:                     geospatiAL 

> +    (description "GDAL is a translator library for raster and vector
> geospatial +data formats.  As a library, it presents a single raster
> abstract data model +and single vector abstract data model to the
> calling application for all +supported formats.  It also comes with a
> variety of useful command line +utilities for data translation and
> processing.")

OK.

> +    (license (list

Not looked into this.

Björn

[Message part 2 (application/pgp-signature, inline)]

Message #11 received at 31175 <at> debbugs.gnu.org (full text, mbox):

From: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 31175 <at> debbugs.gnu.org
Subject: Re: [bug#31175] [PATCH] gnu: Add postgis.
Date: Wed, 9 May 2018 07:44:45 +0200

[Message part 1 (text/plain, inline)]

On Mon, 16 Apr 2018 11:18:21 +0200
Julien Lepiller <julien <at> lepiller.eu> wrote:

> Hi, here are two patches to add postgis and its dependency gdal.

Hi Julien,

I did a concise review of GDAL now. Besides of my above remarks, I have
the following small notes:

   (license (list
               ; general license
 --> I think full-line comments should start with ";;" double semi-colons.


       ("libjpeg" ,libjpeg)

--> Can you use libjpeg-turbo?

The list of dependencies/supported algorithms could of cause be
extended, but as a first start, this is OK.

 I could successfully use in
a guix container ogr2ogr with a shapefile, transforming coordinates from
EPSG:31468 to EPSG:4326. Furthermore, I could gdal_translate a tif+tfw
into a jpeg*world-file.

Thanks,

Björn

[Message part 2 (application/pgp-signature, inline)]

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
To: guix-patches <at> gnu.org
Subject: Re: [bug#31175] [PATCH] gnu: Add postgis.
Date: Wed, 9 May 2018 08:50:52 +0200

[Message part 1 (text/plain, inline)]

Hu Julien,

looking at PostGIS:

On Mon, 16 Apr 2018 11:18:21 +0200
Julien Lepiller <julien <at> lepiller.eu> wrote:

> Hi, here are two patches to add postgis and its dependency gdal.

+    (description " PostGIS is a spatial database extender for PostgreSQL

--> There is a space at the beginning.

Besides of that, this looks good.

I have successfully tried shp2pgsql. 

I have not tried and have no idea of how to use Postgresql+PostGIS
within GuixSD or with a temp database in a Guix container.

Thanks,

Björn

[Message part 2 (application/pgp-signature, inline)]

Message #17 received at 31175 <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: 31175 <at> debbugs.gnu.org
Subject: Re: [bug#31175] [PATCH] gnu: Add postgis.
Date: Wed, 9 May 2018 22:44:43 +0200

Le Wed, 9 May 2018 08:50:52 +0200,
Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de> a écrit :

> Hu Julien,
> 
> looking at PostGIS:
> 
> On Mon, 16 Apr 2018 11:18:21 +0200
> Julien Lepiller <julien <at> lepiller.eu> wrote:
> 
> > Hi, here are two patches to add postgis and its dependency gdal.  
> 
> +    (description " PostGIS is a spatial database extender for
> PostgreSQL
> 
> --> There is a space at the beginning.  
> 
> Besides of that, this looks good.
> 
> I have successfully tried shp2pgsql. 
> 
> I have not tried and have no idea of how to use Postgresql+PostGIS
> within GuixSD or with a temp database in a Guix container.

I've tried to, but the extension directory is hardcoded. Nix has this
patch for postgresql:

https://github.com/NixOS/nixpkgs/blob/master/pkgs/servers/sql/postgresql/specify_pkglibdir_at_runtime.patch

With this, we could add a field to the postgresql configuration that
would take a list of extension packages and set the environment
variable accordingly. The patch only allows one path though. Do you
think it's worth it to adjust it and allow more paths?

> 
> Thanks,
> 
> Björn

Message #22 received at 31175-done <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: 31175-done <at> debbugs.gnu.org
Subject: Re: [bug#31175] [PATCH] gnu: Add postgis.
Date: Wed, 23 May 2018 23:08:58 +0200

[Message part 1 (text/plain, inline)]

Pushed as 2b9be1a63aef1a0e67e94bfd9a676b6cb5c8463f and
996e45cbf7e46977e16c4ebc5ecc394db28f4a21, thank you for your review!

[Message part 2 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.