Subject: Re: [bug#31153] [PATCH] gnu: nestopia-ue: Update to 1.48.

From: Marius Bakke <[email-masked]>
Date: Tue, 17 Apr 2018 00:17:03 +0200

Kei Kebreau <[email-masked]> writes:

> * gnu/packages/emulators.scm (nestopia-ue): Update to 1.48.
> [source]: Simplify snippet.
> [build-system]: Switch to cmake-build-system.
> [inputs]: Remove glu and mesa. Add libepoxy.
> [arguments]: Remove modified phases.

[...]

>                (modules '((guix build utils)))
>                (snippet
>                 '(begin
>                    ;; We don't need libretro for the GNU/Linux build.
> -                  (delete-file-recursively "libretro")
> -                  ;; Use system zlib.
> -                  (delete-file-recursively "source/zlib")
> -                  (substitute* "source/core/NstZlib.cpp"
> -                    (("#include \"../zlib/zlib.h\"") "#include <zlib.h>"))))))
> -    (build-system gnu-build-system)
> +                  (delete-file-recursively "libretro")))))
> +    (build-system cmake-build-system)

The commit message says 'simplify snippet', but the actual change is to
not delete the zlib subfolder.  Is zlib no longer bundled?  If so,
please mention that in the commit message.

Apart from that LGTM.